For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

Stricter checking for skip1 and skip2.

As we do elsewhere in the tree, make sure we (a) got a number at all,
(b) that it doesn't have non-digits dangling off the end, (c) that it's
positive, and (d) that it didn't overflow.

ok tb@

Add fatal() and fatalx() and put them to use.

... but don't use them for pledge errors or usage errors.

They are convenience wrappers that check if sflag is set before
logging an error. They always exit with status 2.

We were not honoring sflag in special.c at all. Now we do.

ok tb@

Delete some useless setlocale(3) calls in /usr/bin, no functional change.
Patches from Jan Stary <hans at stare dot cz>, tweaked by me and tb@.
While here, apply some simple style improvements:
Sort headers, static void __dead usage(), return from main(),
zap case '?', drop /* NOTREACHED */, drop break after usage(), ...
OK tb@ millert@

Convert remaining calls to strtoq/strtouq in base with strtoll/strtoull.
Fix a type mismatch in ftp's "page" command and could make transfers restart
at the wrong position.

ok and a ull->ll tweak from natano@, ok tedu@

fix exit status on pledge(2) failure.

OK tb@ jsg@

Add pledge support to cmp(1).

This is a simple case of using "stdio rpath" until all files are opened and
then dropping down to "stdio" since it includes "rw" on open fds.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

use particular mapping type instead of bogus zero.
-Wall overall happiness; millert@ ok

error

allow hex/octal offsets; metcalf@snet.net

getopt(3) returns -1 when out of args, not EOF, whee!

whoops, goofed on the last one, this should be correct.

Modified cmp to, when given arg -s, really be silent. (reported by
marc@mit.edu, netbsd pr #2642.) Changed main() to use return()
rather than exit().

(just tried checking it in, but local cvs got killed while writting
log message)

rcsid

branches: 1.1.1;
Initial revision

Stricter checking for skip1 and skip2.

As we do elsewhere in the tree, make sure we (a) got a number at all,
(b) that it doesn't have non-digits dangling off the end, (c) that it's
positive, and (d) that it didn't overflow.

ok tb@

Add fatal() and fatalx() and put them to use.

... but don't use them for pledge errors or usage errors.

They are convenience wrappers that check if sflag is set before
logging an error. They always exit with status 2.

We were not honoring sflag in special.c at all. Now we do.

ok tb@

Delete some useless setlocale(3) calls in /usr/bin, no functional change.
Patches from Jan Stary <hans at stare dot cz>, tweaked by me and tb@.
While here, apply some simple style improvements:
Sort headers, static void __dead usage(), return from main(),
zap case '?', drop /* NOTREACHED */, drop break after usage(), ...
OK tb@ millert@

Convert remaining calls to strtoq/strtouq in base with strtoll/strtoull.
Fix a type mismatch in ftp's "page" command and could make transfers restart
at the wrong position.

ok and a ull->ll tweak from natano@, ok tedu@

fix exit status on pledge(2) failure.

OK tb@ jsg@

Add pledge support to cmp(1).

This is a simple case of using "stdio rpath" until all files are opened and
then dropping down to "stdio" since it includes "rw" on open fds.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

use particular mapping type instead of bogus zero.
-Wall overall happiness; millert@ ok

error

allow hex/octal offsets; metcalf@snet.net

getopt(3) returns -1 when out of args, not EOF, whee!

whoops, goofed on the last one, this should be correct.

Modified cmp to, when given arg -s, really be silent. (reported by
marc@mit.edu, netbsd pr #2642.) Changed main() to use return()
rather than exit().

(just tried checking it in, but local cvs got killed while writting
log message)

rcsid

branches: 1.1.1;
Initial revision

Delete some useless setlocale(3) calls in /usr/bin, no functional change.
Patches from Jan Stary <hans at stare dot cz>, tweaked by me and tb@.
While here, apply some simple style improvements:
Sort headers, static void __dead usage(), return from main(),
zap case '?', drop /* NOTREACHED */, drop break after usage(), ...
OK tb@ millert@

Convert remaining calls to strtoq/strtouq in base with strtoll/strtoull.
Fix a type mismatch in ftp's "page" command and could make transfers restart
at the wrong position.

ok and a ull->ll tweak from natano@, ok tedu@

fix exit status on pledge(2) failure.

OK tb@ jsg@

Add pledge support to cmp(1).

This is a simple case of using "stdio rpath" until all files are opened and
then dropping down to "stdio" since it includes "rw" on open fds.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

use particular mapping type instead of bogus zero.
-Wall overall happiness; millert@ ok

error

allow hex/octal offsets; metcalf@snet.net

getopt(3) returns -1 when out of args, not EOF, whee!

whoops, goofed on the last one, this should be correct.

Modified cmp to, when given arg -s, really be silent. (reported by
marc@mit.edu, netbsd pr #2642.) Changed main() to use return()
rather than exit().

(just tried checking it in, but local cvs got killed while writting
log message)

rcsid

branches: 1.1.1;
Initial revision