userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

Remove igetnext prototype for the function does not exist.

ok deraadt@

Actually, the C standard only guarantees that atexit(3) returns non-zero
on error, so tweak previous to test "atexit(...) != 0" for portability.
"OK ok ok sorry backwards" deraadt@

atexit() returns -1 on failure

remove -i from SYNOPSIS and usage();

cap_mkdb no longer needs to understand terminfo files, so remove -i.

ok tedu millert

Pretty sure this can pledge "stdio rpath wpath cpath". Commiting to start
the review for regressions...

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Nuke a load of trailing whitespace; no binary change.

If the last name field looks like a description rather than an alias (if it
contains spaces), ignore it. Knocks a few K off the termcap and terminfo
databases and gets rid of some warnings.

ok millert

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Change cap_mkdb and curses to be a better about reformatting terminfo entries
into the cap database format and back: rather than replacing all colons with
commas, only touch real separators (skip those with a leading \ or ^) and
replace an unadorned colon with a literal "\072".

Fixes problems with quite a few caps including acsc in "screen" (:s instead of
,s) and setab/initc in "xterm-256color" (wrongly concatenated together).

ok millert

Plug a mem leak; ok millert@

better realloc. ok deraadt@

Replace err(1, "") with err(1, NULL) to avoid a warning; Andrey Matveev

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

first pass at a -Wall cleanup

use cgetusedb(3)

- move break from loop on EOF in order to make cap_mkdb not ignore the final
record in terminfo mode
- while we're here fix indentation, spelling
okay millert@

When storing termcap entry in the .db file, prune out empty entries like
:\t: since space may be tight with the 1023 character termcap limit.

Merge cap_mkdb(1) and info_mkdb(1)

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision

Remove igetnext prototype for the function does not exist.

ok deraadt@

Actually, the C standard only guarantees that atexit(3) returns non-zero
on error, so tweak previous to test "atexit(...) != 0" for portability.
"OK ok ok sorry backwards" deraadt@

atexit() returns -1 on failure

remove -i from SYNOPSIS and usage();

cap_mkdb no longer needs to understand terminfo files, so remove -i.

ok tedu millert

Pretty sure this can pledge "stdio rpath wpath cpath". Commiting to start
the review for regressions...

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Nuke a load of trailing whitespace; no binary change.

If the last name field looks like a description rather than an alias (if it
contains spaces), ignore it. Knocks a few K off the termcap and terminfo
databases and gets rid of some warnings.

ok millert

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Change cap_mkdb and curses to be a better about reformatting terminfo entries
into the cap database format and back: rather than replacing all colons with
commas, only touch real separators (skip those with a leading \ or ^) and
replace an unadorned colon with a literal "\072".

Fixes problems with quite a few caps including acsc in "screen" (:s instead of
,s) and setab/initc in "xterm-256color" (wrongly concatenated together).

ok millert

Plug a mem leak; ok millert@

better realloc. ok deraadt@

Replace err(1, "") with err(1, NULL) to avoid a warning; Andrey Matveev

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

first pass at a -Wall cleanup

use cgetusedb(3)

- move break from loop on EOF in order to make cap_mkdb not ignore the final
record in terminfo mode
- while we're here fix indentation, spelling
okay millert@

When storing termcap entry in the .db file, prune out empty entries like
:\t: since space may be tight with the 1023 character termcap limit.

Merge cap_mkdb(1) and info_mkdb(1)

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision

Actually, the C standard only guarantees that atexit(3) returns non-zero
on error, so tweak previous to test "atexit(...) != 0" for portability.
"OK ok ok sorry backwards" deraadt@

atexit() returns -1 on failure

remove -i from SYNOPSIS and usage();

cap_mkdb no longer needs to understand terminfo files, so remove -i.

ok tedu millert

Pretty sure this can pledge "stdio rpath wpath cpath". Commiting to start
the review for regressions...

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Nuke a load of trailing whitespace; no binary change.

If the last name field looks like a description rather than an alias (if it
contains spaces), ignore it. Knocks a few K off the termcap and terminfo
databases and gets rid of some warnings.

ok millert

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Change cap_mkdb and curses to be a better about reformatting terminfo entries
into the cap database format and back: rather than replacing all colons with
commas, only touch real separators (skip those with a leading \ or ^) and
replace an unadorned colon with a literal "\072".

Fixes problems with quite a few caps including acsc in "screen" (:s instead of
,s) and setab/initc in "xterm-256color" (wrongly concatenated together).

ok millert

Plug a mem leak; ok millert@

better realloc. ok deraadt@

Replace err(1, "") with err(1, NULL) to avoid a warning; Andrey Matveev

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

first pass at a -Wall cleanup

use cgetusedb(3)

- move break from loop on EOF in order to make cap_mkdb not ignore the final
record in terminfo mode
- while we're here fix indentation, spelling
okay millert@

When storing termcap entry in the .db file, prune out empty entries like
:\t: since space may be tight with the 1023 character termcap limit.

Merge cap_mkdb(1) and info_mkdb(1)

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision

atexit() returns -1 on failure

remove -i from SYNOPSIS and usage();

cap_mkdb no longer needs to understand terminfo files, so remove -i.

ok tedu millert

Pretty sure this can pledge "stdio rpath wpath cpath". Commiting to start
the review for regressions...

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Nuke a load of trailing whitespace; no binary change.

If the last name field looks like a description rather than an alias (if it
contains spaces), ignore it. Knocks a few K off the termcap and terminfo
databases and gets rid of some warnings.

ok millert

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Change cap_mkdb and curses to be a better about reformatting terminfo entries
into the cap database format and back: rather than replacing all colons with
commas, only touch real separators (skip those with a leading \ or ^) and
replace an unadorned colon with a literal "\072".

Fixes problems with quite a few caps including acsc in "screen" (:s instead of
,s) and setab/initc in "xterm-256color" (wrongly concatenated together).

ok millert

Plug a mem leak; ok millert@

better realloc. ok deraadt@

Replace err(1, "") with err(1, NULL) to avoid a warning; Andrey Matveev

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

first pass at a -Wall cleanup

use cgetusedb(3)

- move break from loop on EOF in order to make cap_mkdb not ignore the final
record in terminfo mode
- while we're here fix indentation, spelling
okay millert@

When storing termcap entry in the .db file, prune out empty entries like
:\t: since space may be tight with the 1023 character termcap limit.

Merge cap_mkdb(1) and info_mkdb(1)

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision

remove -i from SYNOPSIS and usage();

cap_mkdb no longer needs to understand terminfo files, so remove -i.

ok tedu millert

Pretty sure this can pledge "stdio rpath wpath cpath". Commiting to start
the review for regressions...

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Nuke a load of trailing whitespace; no binary change.

If the last name field looks like a description rather than an alias (if it
contains spaces), ignore it. Knocks a few K off the termcap and terminfo
databases and gets rid of some warnings.

ok millert

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Change cap_mkdb and curses to be a better about reformatting terminfo entries
into the cap database format and back: rather than replacing all colons with
commas, only touch real separators (skip those with a leading \ or ^) and
replace an unadorned colon with a literal "\072".

Fixes problems with quite a few caps including acsc in "screen" (:s instead of
,s) and setab/initc in "xterm-256color" (wrongly concatenated together).

ok millert

Plug a mem leak; ok millert@

better realloc. ok deraadt@

Replace err(1, "") with err(1, NULL) to avoid a warning; Andrey Matveev

mostly ansi cleanup; pval ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

first pass at a -Wall cleanup

use cgetusedb(3)

- move break from loop on EOF in order to make cap_mkdb not ignore the final
record in terminfo mode
- while we're here fix indentation, spelling
okay millert@

When storing termcap entry in the .db file, prune out empty entries like
:\t: since space may be tight with the 1023 character termcap limit.

Merge cap_mkdb(1) and info_mkdb(1)

getopt(3) returns -1 when out of args, not EOF, whee!

rcsid

branches: 1.1.1;
Initial revision