remove unneeded includes; ok mpi@

Remove unused device poll functions.

Also remove unneeded includes of <sys/poll.h> and <sys/select.h>.

Some addenda from jsg@.

OK miod@ mpi@

constify method tables in USB serial drivers

ok miod@

spelling
feedback and ok tb@ jmc@ ok ratchov@

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usbdi.c rev. 1.57 did add usbd_abort_pipe()
to usbd_close_pipe(), but the drivers didn't get cleaned up afterwards.

ok gerhard@

Convert tsleep(9) that wait for a multiple of `hz' to tsleep_nsec(9).

ok cheloha@

Delete superfluous includes of <sys/file.>

ok krw@

Remove unused struct member.

ok deraadt@

A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Kill the last dumb DVACT_DEACTIVATE handlers.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Sort-out activate functionality for ucom(4) and it's parents.


The child should not have to call the parent for deactivation.
The parent should handle it.
So kill the activate routine in ucom(4) and adapt the parents
to no longer call it.


Also remove sc_dying in ucom(4) and use usbd_is_dying() instead.

Okay mpi@.

Replace sc_dying in favour of usbd_is_dying() and usbd_deactivate().

Okay mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

- use usb_lookup() instead of handrolled macro

ok jakemsr@

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

treat usb vendor/product names as a locator, and have usbd_print handle it,
so that it shows up before the :. as a result, all the usb devices do not
need to have name printing code anymore. all this now works and prints
nicely because usbd_probe_and_attach() is serialized. ok kettenis

Remove the definition and usage of the USB_DECLARE_DRIVER_CLASS and
USB_DECLARE_DRIVER macros.

No binary change.

ok dlg.

Apply some KNF after the recent removal of macros and type definitions.

No binary change.

ok ray.

Remove the definition and use of the device_ptr_t which was a struct device *.

No binary change.

ok mk.

Remove the definition and use of the USBDEVNAME macro.

(This might look easy, but it was a big diff. Thanks to dlg and especially jsg
for looking over it; we found at least four mistakes in the initial diff.)

ok jsg.

Remove the definition and use of the USBDEV macro. It only created confusion
and the address of it's argument: USBDEV(sc->sc_dev) yields &sc->sc_dev.

No binary changes.

ok jsg.

Mechanical removal of USBBASEDEVICE. No binary change.

Tested by thib and myself.

ok mbalmer jsg

Remove the "Static" declaration of many functions. It was defined to be empty
and it was not consistently used. It was confusing as it suggested these
functions were static, which they were not.

discussed with dlg and jsg, ok jsg.

Remove more #ifdef/#endif's that checked for other bsds. No binary
change, no functionality change.

ok jsg

Farewell USB_{ATTACH,MATCH,DETACH}* you will not be missed.
ok deraadt@ krw@ mbalmer@

Remove logprintf macro

In a drivers activate() entry point, if on DVACT_DEACTIVATE it does
something, then it MUST return zero on DVACT_ACTIVATE, not EOPNOTSUPP;
this very popular bug has been cut and pasted a lot of times...
ok deraadt@ mickey@

spaces vs tab

Don't keep the devinfo string on the stack, instead use malloc/free.
This should cure some rare stack overflows.

From augustss NetBSD

ok dlg@ pascoe@

support two more suntac products; from freebsd

put "do { } while (0)" wrappers on all the debug maroc functions

more devices from NetBSD

string cleanup; nate ok

branches: 1.1.4;
Add driver for SUNTAC Slipper VS-10U communications device

Remove unused device poll functions.

Also remove unneeded includes of <sys/poll.h> and <sys/select.h>.

Some addenda from jsg@.

OK miod@ mpi@

constify method tables in USB serial drivers

ok miod@

spelling
feedback and ok tb@ jmc@ ok ratchov@

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usbdi.c rev. 1.57 did add usbd_abort_pipe()
to usbd_close_pipe(), but the drivers didn't get cleaned up afterwards.

ok gerhard@

Convert tsleep(9) that wait for a multiple of `hz' to tsleep_nsec(9).

ok cheloha@

Delete superfluous includes of <sys/file.>

ok krw@

Remove unused struct member.

ok deraadt@

A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Kill the last dumb DVACT_DEACTIVATE handlers.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Sort-out activate functionality for ucom(4) and it's parents.


The child should not have to call the parent for deactivation.
The parent should handle it.
So kill the activate routine in ucom(4) and adapt the parents
to no longer call it.


Also remove sc_dying in ucom(4) and use usbd_is_dying() instead.

Okay mpi@.

Replace sc_dying in favour of usbd_is_dying() and usbd_deactivate().

Okay mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

- use usb_lookup() instead of handrolled macro

ok jakemsr@

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

treat usb vendor/product names as a locator, and have usbd_print handle it,
so that it shows up before the :. as a result, all the usb devices do not
need to have name printing code anymore. all this now works and prints
nicely because usbd_probe_and_attach() is serialized. ok kettenis

Remove the definition and usage of the USB_DECLARE_DRIVER_CLASS and
USB_DECLARE_DRIVER macros.

No binary change.

ok dlg.

Apply some KNF after the recent removal of macros and type definitions.

No binary change.

ok ray.

Remove the definition and use of the device_ptr_t which was a struct device *.

No binary change.

ok mk.

Remove the definition and use of the USBDEVNAME macro.

(This might look easy, but it was a big diff. Thanks to dlg and especially jsg
for looking over it; we found at least four mistakes in the initial diff.)

ok jsg.

Remove the definition and use of the USBDEV macro. It only created confusion
and the address of it's argument: USBDEV(sc->sc_dev) yields &sc->sc_dev.

No binary changes.

ok jsg.

Mechanical removal of USBBASEDEVICE. No binary change.

Tested by thib and myself.

ok mbalmer jsg

Remove the "Static" declaration of many functions. It was defined to be empty
and it was not consistently used. It was confusing as it suggested these
functions were static, which they were not.

discussed with dlg and jsg, ok jsg.

Remove more #ifdef/#endif's that checked for other bsds. No binary
change, no functionality change.

ok jsg

Farewell USB_{ATTACH,MATCH,DETACH}* you will not be missed.
ok deraadt@ krw@ mbalmer@

Remove logprintf macro

In a drivers activate() entry point, if on DVACT_DEACTIVATE it does
something, then it MUST return zero on DVACT_ACTIVATE, not EOPNOTSUPP;
this very popular bug has been cut and pasted a lot of times...
ok deraadt@ mickey@

spaces vs tab

Don't keep the devinfo string on the stack, instead use malloc/free.
This should cure some rare stack overflows.

From augustss NetBSD

ok dlg@ pascoe@

support two more suntac products; from freebsd

put "do { } while (0)" wrappers on all the debug maroc functions

more devices from NetBSD

string cleanup; nate ok

branches: 1.1.4;
Add driver for SUNTAC Slipper VS-10U communications device

constify method tables in USB serial drivers

ok miod@

spelling
feedback and ok tb@ jmc@ ok ratchov@

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usbdi.c rev. 1.57 did add usbd_abort_pipe()
to usbd_close_pipe(), but the drivers didn't get cleaned up afterwards.

ok gerhard@

Convert tsleep(9) that wait for a multiple of `hz' to tsleep_nsec(9).

ok cheloha@

Delete superfluous includes of <sys/file.>

ok krw@

Remove unused struct member.

ok deraadt@

A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Kill the last dumb DVACT_DEACTIVATE handlers.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Sort-out activate functionality for ucom(4) and it's parents.


The child should not have to call the parent for deactivation.
The parent should handle it.
So kill the activate routine in ucom(4) and adapt the parents
to no longer call it.


Also remove sc_dying in ucom(4) and use usbd_is_dying() instead.

Okay mpi@.

Replace sc_dying in favour of usbd_is_dying() and usbd_deactivate().

Okay mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

- use usb_lookup() instead of handrolled macro

ok jakemsr@

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

treat usb vendor/product names as a locator, and have usbd_print handle it,
so that it shows up before the :. as a result, all the usb devices do not
need to have name printing code anymore. all this now works and prints
nicely because usbd_probe_and_attach() is serialized. ok kettenis

Remove the definition and usage of the USB_DECLARE_DRIVER_CLASS and
USB_DECLARE_DRIVER macros.

No binary change.

ok dlg.

Apply some KNF after the recent removal of macros and type definitions.

No binary change.

ok ray.

Remove the definition and use of the device_ptr_t which was a struct device *.

No binary change.

ok mk.

Remove the definition and use of the USBDEVNAME macro.

(This might look easy, but it was a big diff. Thanks to dlg and especially jsg
for looking over it; we found at least four mistakes in the initial diff.)

ok jsg.

Remove the definition and use of the USBDEV macro. It only created confusion
and the address of it's argument: USBDEV(sc->sc_dev) yields &sc->sc_dev.

No binary changes.

ok jsg.

Mechanical removal of USBBASEDEVICE. No binary change.

Tested by thib and myself.

ok mbalmer jsg

Remove the "Static" declaration of many functions. It was defined to be empty
and it was not consistently used. It was confusing as it suggested these
functions were static, which they were not.

discussed with dlg and jsg, ok jsg.

Remove more #ifdef/#endif's that checked for other bsds. No binary
change, no functionality change.

ok jsg

Farewell USB_{ATTACH,MATCH,DETACH}* you will not be missed.
ok deraadt@ krw@ mbalmer@

Remove logprintf macro

In a drivers activate() entry point, if on DVACT_DEACTIVATE it does
something, then it MUST return zero on DVACT_ACTIVATE, not EOPNOTSUPP;
this very popular bug has been cut and pasted a lot of times...
ok deraadt@ mickey@

spaces vs tab

Don't keep the devinfo string on the stack, instead use malloc/free.
This should cure some rare stack overflows.

From augustss NetBSD

ok dlg@ pascoe@

support two more suntac products; from freebsd

put "do { } while (0)" wrappers on all the debug maroc functions

more devices from NetBSD

string cleanup; nate ok

branches: 1.1.4;
Add driver for SUNTAC Slipper VS-10U communications device

spelling
feedback and ok tb@ jmc@ ok ratchov@

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usbdi.c rev. 1.57 did add usbd_abort_pipe()
to usbd_close_pipe(), but the drivers didn't get cleaned up afterwards.

ok gerhard@

Convert tsleep(9) that wait for a multiple of `hz' to tsleep_nsec(9).

ok cheloha@

Delete superfluous includes of <sys/file.>

ok krw@

Remove unused struct member.

ok deraadt@

A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Kill the last dumb DVACT_DEACTIVATE handlers.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Sort-out activate functionality for ucom(4) and it's parents.


The child should not have to call the parent for deactivation.
The parent should handle it.
So kill the activate routine in ucom(4) and adapt the parents
to no longer call it.


Also remove sc_dying in ucom(4) and use usbd_is_dying() instead.

Okay mpi@.

Replace sc_dying in favour of usbd_is_dying() and usbd_deactivate().

Okay mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

- use usb_lookup() instead of handrolled macro

ok jakemsr@

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

treat usb vendor/product names as a locator, and have usbd_print handle it,
so that it shows up before the :. as a result, all the usb devices do not
need to have name printing code anymore. all this now works and prints
nicely because usbd_probe_and_attach() is serialized. ok kettenis

Remove the definition and usage of the USB_DECLARE_DRIVER_CLASS and
USB_DECLARE_DRIVER macros.

No binary change.

ok dlg.

Apply some KNF after the recent removal of macros and type definitions.

No binary change.

ok ray.

Remove the definition and use of the device_ptr_t which was a struct device *.

No binary change.

ok mk.

Remove the definition and use of the USBDEVNAME macro.

(This might look easy, but it was a big diff. Thanks to dlg and especially jsg
for looking over it; we found at least four mistakes in the initial diff.)

ok jsg.

Remove the definition and use of the USBDEV macro. It only created confusion
and the address of it's argument: USBDEV(sc->sc_dev) yields &sc->sc_dev.

No binary changes.

ok jsg.

Mechanical removal of USBBASEDEVICE. No binary change.

Tested by thib and myself.

ok mbalmer jsg

Remove the "Static" declaration of many functions. It was defined to be empty
and it was not consistently used. It was confusing as it suggested these
functions were static, which they were not.

discussed with dlg and jsg, ok jsg.

Remove more #ifdef/#endif's that checked for other bsds. No binary
change, no functionality change.

ok jsg

Farewell USB_{ATTACH,MATCH,DETACH}* you will not be missed.
ok deraadt@ krw@ mbalmer@

Remove logprintf macro

In a drivers activate() entry point, if on DVACT_DEACTIVATE it does
something, then it MUST return zero on DVACT_ACTIVATE, not EOPNOTSUPP;
this very popular bug has been cut and pasted a lot of times...
ok deraadt@ mickey@

spaces vs tab

Don't keep the devinfo string on the stack, instead use malloc/free.
This should cure some rare stack overflows.

From augustss NetBSD

ok dlg@ pascoe@

support two more suntac products; from freebsd

put "do { } while (0)" wrappers on all the debug maroc functions

more devices from NetBSD

string cleanup; nate ok

branches: 1.1.4;
Add driver for SUNTAC Slipper VS-10U communications device

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usbdi.c rev. 1.57 did add usbd_abort_pipe()
to usbd_close_pipe(), but the drivers didn't get cleaned up afterwards.

ok gerhard@

Convert tsleep(9) that wait for a multiple of `hz' to tsleep_nsec(9).

ok cheloha@

Delete superfluous includes of <sys/file.>

ok krw@

Remove unused struct member.

ok deraadt@

A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Kill the last dumb DVACT_DEACTIVATE handlers.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Sort-out activate functionality for ucom(4) and it's parents.


The child should not have to call the parent for deactivation.
The parent should handle it.
So kill the activate routine in ucom(4) and adapt the parents
to no longer call it.


Also remove sc_dying in ucom(4) and use usbd_is_dying() instead.

Okay mpi@.

Replace sc_dying in favour of usbd_is_dying() and usbd_deactivate().

Okay mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

- use usb_lookup() instead of handrolled macro

ok jakemsr@

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

treat usb vendor/product names as a locator, and have usbd_print handle it,
so that it shows up before the :. as a result, all the usb devices do not
need to have name printing code anymore. all this now works and prints
nicely because usbd_probe_and_attach() is serialized. ok kettenis

Remove the definition and usage of the USB_DECLARE_DRIVER_CLASS and
USB_DECLARE_DRIVER macros.

No binary change.

ok dlg.

Apply some KNF after the recent removal of macros and type definitions.

No binary change.

ok ray.

Remove the definition and use of the device_ptr_t which was a struct device *.

No binary change.

ok mk.

Remove the definition and use of the USBDEVNAME macro.

(This might look easy, but it was a big diff. Thanks to dlg and especially jsg
for looking over it; we found at least four mistakes in the initial diff.)

ok jsg.

Remove the definition and use of the USBDEV macro. It only created confusion
and the address of it's argument: USBDEV(sc->sc_dev) yields &sc->sc_dev.

No binary changes.

ok jsg.

Mechanical removal of USBBASEDEVICE. No binary change.

Tested by thib and myself.

ok mbalmer jsg

Remove the "Static" declaration of many functions. It was defined to be empty
and it was not consistently used. It was confusing as it suggested these
functions were static, which they were not.

discussed with dlg and jsg, ok jsg.

Remove more #ifdef/#endif's that checked for other bsds. No binary
change, no functionality change.

ok jsg

Farewell USB_{ATTACH,MATCH,DETACH}* you will not be missed.
ok deraadt@ krw@ mbalmer@

Remove logprintf macro

In a drivers activate() entry point, if on DVACT_DEACTIVATE it does
something, then it MUST return zero on DVACT_ACTIVATE, not EOPNOTSUPP;
this very popular bug has been cut and pasted a lot of times...
ok deraadt@ mickey@

spaces vs tab

Don't keep the devinfo string on the stack, instead use malloc/free.
This should cure some rare stack overflows.

From augustss NetBSD

ok dlg@ pascoe@

support two more suntac products; from freebsd

put "do { } while (0)" wrappers on all the debug maroc functions

more devices from NetBSD

string cleanup; nate ok

branches: 1.1.4;
Add driver for SUNTAC Slipper VS-10U communications device

Convert tsleep(9) that wait for a multiple of `hz' to tsleep_nsec(9).

ok cheloha@

Delete superfluous includes of <sys/file.>

ok krw@

Remove unused struct member.

ok deraadt@

A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Kill the last dumb DVACT_DEACTIVATE handlers.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Sort-out activate functionality for ucom(4) and it's parents.


The child should not have to call the parent for deactivation.
The parent should handle it.
So kill the activate routine in ucom(4) and adapt the parents
to no longer call it.


Also remove sc_dying in ucom(4) and use usbd_is_dying() instead.

Okay mpi@.

Replace sc_dying in favour of usbd_is_dying() and usbd_deactivate().

Okay mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

- use usb_lookup() instead of handrolled macro

ok jakemsr@

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

treat usb vendor/product names as a locator, and have usbd_print handle it,
so that it shows up before the :. as a result, all the usb devices do not
need to have name printing code anymore. all this now works and prints
nicely because usbd_probe_and_attach() is serialized. ok kettenis

Remove the definition and usage of the USB_DECLARE_DRIVER_CLASS and
USB_DECLARE_DRIVER macros.

No binary change.

ok dlg.

Apply some KNF after the recent removal of macros and type definitions.

No binary change.

ok ray.

Remove the definition and use of the device_ptr_t which was a struct device *.

No binary change.

ok mk.

Remove the definition and use of the USBDEVNAME macro.

(This might look easy, but it was a big diff. Thanks to dlg and especially jsg
for looking over it; we found at least four mistakes in the initial diff.)

ok jsg.

Remove the definition and use of the USBDEV macro. It only created confusion
and the address of it's argument: USBDEV(sc->sc_dev) yields &sc->sc_dev.

No binary changes.

ok jsg.

Mechanical removal of USBBASEDEVICE. No binary change.

Tested by thib and myself.

ok mbalmer jsg

Remove the "Static" declaration of many functions. It was defined to be empty
and it was not consistently used. It was confusing as it suggested these
functions were static, which they were not.

discussed with dlg and jsg, ok jsg.

Remove more #ifdef/#endif's that checked for other bsds. No binary
change, no functionality change.

ok jsg

Farewell USB_{ATTACH,MATCH,DETACH}* you will not be missed.
ok deraadt@ krw@ mbalmer@

Remove logprintf macro

In a drivers activate() entry point, if on DVACT_DEACTIVATE it does
something, then it MUST return zero on DVACT_ACTIVATE, not EOPNOTSUPP;
this very popular bug has been cut and pasted a lot of times...
ok deraadt@ mickey@

spaces vs tab

Don't keep the devinfo string on the stack, instead use malloc/free.
This should cure some rare stack overflows.

From augustss NetBSD

ok dlg@ pascoe@

support two more suntac products; from freebsd

put "do { } while (0)" wrappers on all the debug maroc functions

more devices from NetBSD

string cleanup; nate ok

branches: 1.1.4;
Add driver for SUNTAC Slipper VS-10U communications device

Delete superfluous includes of <sys/file.>

ok krw@

Remove unused struct member.

ok deraadt@

A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Kill the last dumb DVACT_DEACTIVATE handlers.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Sort-out activate functionality for ucom(4) and it's parents.


The child should not have to call the parent for deactivation.
The parent should handle it.
So kill the activate routine in ucom(4) and adapt the parents
to no longer call it.


Also remove sc_dying in ucom(4) and use usbd_is_dying() instead.

Okay mpi@.

Replace sc_dying in favour of usbd_is_dying() and usbd_deactivate().

Okay mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

- use usb_lookup() instead of handrolled macro

ok jakemsr@

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

treat usb vendor/product names as a locator, and have usbd_print handle it,
so that it shows up before the :. as a result, all the usb devices do not
need to have name printing code anymore. all this now works and prints
nicely because usbd_probe_and_attach() is serialized. ok kettenis

Remove the definition and usage of the USB_DECLARE_DRIVER_CLASS and
USB_DECLARE_DRIVER macros.

No binary change.

ok dlg.

Apply some KNF after the recent removal of macros and type definitions.

No binary change.

ok ray.

Remove the definition and use of the device_ptr_t which was a struct device *.

No binary change.

ok mk.

Remove the definition and use of the USBDEVNAME macro.

(This might look easy, but it was a big diff. Thanks to dlg and especially jsg
for looking over it; we found at least four mistakes in the initial diff.)

ok jsg.

Remove the definition and use of the USBDEV macro. It only created confusion
and the address of it's argument: USBDEV(sc->sc_dev) yields &sc->sc_dev.

No binary changes.

ok jsg.

Mechanical removal of USBBASEDEVICE. No binary change.

Tested by thib and myself.

ok mbalmer jsg

Remove the "Static" declaration of many functions. It was defined to be empty
and it was not consistently used. It was confusing as it suggested these
functions were static, which they were not.

discussed with dlg and jsg, ok jsg.

Remove more #ifdef/#endif's that checked for other bsds. No binary
change, no functionality change.

ok jsg

Farewell USB_{ATTACH,MATCH,DETACH}* you will not be missed.
ok deraadt@ krw@ mbalmer@

Remove logprintf macro

In a drivers activate() entry point, if on DVACT_DEACTIVATE it does
something, then it MUST return zero on DVACT_ACTIVATE, not EOPNOTSUPP;
this very popular bug has been cut and pasted a lot of times...
ok deraadt@ mickey@

spaces vs tab

Don't keep the devinfo string on the stack, instead use malloc/free.
This should cure some rare stack overflows.

From augustss NetBSD

ok dlg@ pascoe@

support two more suntac products; from freebsd

put "do { } while (0)" wrappers on all the debug maroc functions

more devices from NetBSD

string cleanup; nate ok

branches: 1.1.4;
Add driver for SUNTAC Slipper VS-10U communications device

Remove unused struct member.

ok deraadt@

A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Kill the last dumb DVACT_DEACTIVATE handlers.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Sort-out activate functionality for ucom(4) and it's parents.


The child should not have to call the parent for deactivation.
The parent should handle it.
So kill the activate routine in ucom(4) and adapt the parents
to no longer call it.


Also remove sc_dying in ucom(4) and use usbd_is_dying() instead.

Okay mpi@.

Replace sc_dying in favour of usbd_is_dying() and usbd_deactivate().

Okay mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

- use usb_lookup() instead of handrolled macro

ok jakemsr@

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

treat usb vendor/product names as a locator, and have usbd_print handle it,
so that it shows up before the :. as a result, all the usb devices do not
need to have name printing code anymore. all this now works and prints
nicely because usbd_probe_and_attach() is serialized. ok kettenis

Remove the definition and usage of the USB_DECLARE_DRIVER_CLASS and
USB_DECLARE_DRIVER macros.

No binary change.

ok dlg.

Apply some KNF after the recent removal of macros and type definitions.

No binary change.

ok ray.

Remove the definition and use of the device_ptr_t which was a struct device *.

No binary change.

ok mk.

Remove the definition and use of the USBDEVNAME macro.

(This might look easy, but it was a big diff. Thanks to dlg and especially jsg
for looking over it; we found at least four mistakes in the initial diff.)

ok jsg.

Remove the definition and use of the USBDEV macro. It only created confusion
and the address of it's argument: USBDEV(sc->sc_dev) yields &sc->sc_dev.

No binary changes.

ok jsg.

Mechanical removal of USBBASEDEVICE. No binary change.

Tested by thib and myself.

ok mbalmer jsg

Remove the "Static" declaration of many functions. It was defined to be empty
and it was not consistently used. It was confusing as it suggested these
functions were static, which they were not.

discussed with dlg and jsg, ok jsg.

Remove more #ifdef/#endif's that checked for other bsds. No binary
change, no functionality change.

ok jsg

Farewell USB_{ATTACH,MATCH,DETACH}* you will not be missed.
ok deraadt@ krw@ mbalmer@

Remove logprintf macro

In a drivers activate() entry point, if on DVACT_DEACTIVATE it does
something, then it MUST return zero on DVACT_ACTIVATE, not EOPNOTSUPP;
this very popular bug has been cut and pasted a lot of times...
ok deraadt@ mickey@

spaces vs tab

Don't keep the devinfo string on the stack, instead use malloc/free.
This should cure some rare stack overflows.

From augustss NetBSD

ok dlg@ pascoe@

support two more suntac products; from freebsd

put "do { } while (0)" wrappers on all the debug maroc functions

more devices from NetBSD

string cleanup; nate ok

branches: 1.1.4;
Add driver for SUNTAC Slipper VS-10U communications device

A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Kill the last dumb DVACT_DEACTIVATE handlers.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Sort-out activate functionality for ucom(4) and it's parents.


The child should not have to call the parent for deactivation.
The parent should handle it.
So kill the activate routine in ucom(4) and adapt the parents
to no longer call it.


Also remove sc_dying in ucom(4) and use usbd_is_dying() instead.

Okay mpi@.

Replace sc_dying in favour of usbd_is_dying() and usbd_deactivate().

Okay mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

- use usb_lookup() instead of handrolled macro

ok jakemsr@

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

treat usb vendor/product names as a locator, and have usbd_print handle it,
so that it shows up before the :. as a result, all the usb devices do not
need to have name printing code anymore. all this now works and prints
nicely because usbd_probe_and_attach() is serialized. ok kettenis

Remove the definition and usage of the USB_DECLARE_DRIVER_CLASS and
USB_DECLARE_DRIVER macros.

No binary change.

ok dlg.

Apply some KNF after the recent removal of macros and type definitions.

No binary change.

ok ray.

Remove the definition and use of the device_ptr_t which was a struct device *.

No binary change.

ok mk.

Remove the definition and use of the USBDEVNAME macro.

(This might look easy, but it was a big diff. Thanks to dlg and especially jsg
for looking over it; we found at least four mistakes in the initial diff.)

ok jsg.

Remove the definition and use of the USBDEV macro. It only created confusion
and the address of it's argument: USBDEV(sc->sc_dev) yields &sc->sc_dev.

No binary changes.

ok jsg.

Mechanical removal of USBBASEDEVICE. No binary change.

Tested by thib and myself.

ok mbalmer jsg

Remove the "Static" declaration of many functions. It was defined to be empty
and it was not consistently used. It was confusing as it suggested these
functions were static, which they were not.

discussed with dlg and jsg, ok jsg.

Remove more #ifdef/#endif's that checked for other bsds. No binary
change, no functionality change.

ok jsg

Farewell USB_{ATTACH,MATCH,DETACH}* you will not be missed.
ok deraadt@ krw@ mbalmer@

Remove logprintf macro

In a drivers activate() entry point, if on DVACT_DEACTIVATE it does
something, then it MUST return zero on DVACT_ACTIVATE, not EOPNOTSUPP;
this very popular bug has been cut and pasted a lot of times...
ok deraadt@ mickey@

spaces vs tab

Don't keep the devinfo string on the stack, instead use malloc/free.
This should cure some rare stack overflows.

From augustss NetBSD

ok dlg@ pascoe@

support two more suntac products; from freebsd

put "do { } while (0)" wrappers on all the debug maroc functions

more devices from NetBSD

string cleanup; nate ok

branches: 1.1.4;
Add driver for SUNTAC Slipper VS-10U communications device