remove unneeded includes; ok mpi@

Remove unused device poll functions.

Also remove unneeded includes of <sys/poll.h> and <sys/select.h>.

Some addenda from jsg@.

OK miod@ mpi@

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usbdi.c rev. 1.57 did add usbd_abort_pipe()
to usbd_close_pipe(), but the drivers didn't get cleaned up afterwards.

ok gerhard@

support Meinberg DCF600USB, from weerd@, ok phessler

Delete unnecessary <sys/file.h> includes

ok millert@ krw@

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

tedu another bunch of DVACT_DEACTIVATE handlers that do nothing but set
the 'dying' flag.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

Instead of using a wrapper around usbd_transfer() when submitting a
transfer synchronously just pass the USBD_SYNCHRONOUS flag like any
other flags when creating a transfer.

ok sthen@, mglocker@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

* replace per-driver dying and/or other state variables with use of
usbd_deactivete() and usbd_is_dying()
* use usbd_deactivate() in activate()/DEACTIVATE
* convert a few more direct checks of the associated bus' dying flag
with usbd_is_dying()

check that a timeout(9) has been initialized before deleting it

ok phessler

create another kthread to run xfer abort tasks. xfer abort tasks cannot
be run from the generic task kthread, because xfers that need to be
aborted block newly queued tasks from running (i.e. the xfer to be aborted
blocks the abort of that task). as there are now three types of usb
tasks, add an argument to usb_init_task() and another member to struct
usb_task to specify the task type.

fixes boot hangs that are showing up because we now use usb tasks to
attach/detach usb devices.

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

in the detach function remove our usb task before calling any other
teardown functions which could potentially sleep (and then, the usb
task would get called for a half-torn down device)

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

in ca_attach() there is no need to set .value and .flags of sensors to 0,
since autoconf(9) allocates softc with M_ZERO; ok deraadt

Kill whitespace, remove unneeded ,

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

Don't use uninitialized variables in umbg_detach.

Degrade sensor status in an interrupt context.

Don't use utc_off, time is always reported in UTC.

Clean up some debugging left-overs.

knf.

umbg(4) is a driver to support the USB attached Meinberg USB5131 DCF77
radio clock. umbg(4) implements a timedelta sensor and reports the
signal quality in the Signal sensor as percentage. The signal sensor status
further indicates if the clock is free running (WARN).

ok dlg, jsg

Remove unused device poll functions.

Also remove unneeded includes of <sys/poll.h> and <sys/select.h>.

Some addenda from jsg@.

OK miod@ mpi@

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usbdi.c rev. 1.57 did add usbd_abort_pipe()
to usbd_close_pipe(), but the drivers didn't get cleaned up afterwards.

ok gerhard@

support Meinberg DCF600USB, from weerd@, ok phessler

Delete unnecessary <sys/file.h> includes

ok millert@ krw@

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

tedu another bunch of DVACT_DEACTIVATE handlers that do nothing but set
the 'dying' flag.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

Instead of using a wrapper around usbd_transfer() when submitting a
transfer synchronously just pass the USBD_SYNCHRONOUS flag like any
other flags when creating a transfer.

ok sthen@, mglocker@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

* replace per-driver dying and/or other state variables with use of
usbd_deactivete() and usbd_is_dying()
* use usbd_deactivate() in activate()/DEACTIVATE
* convert a few more direct checks of the associated bus' dying flag
with usbd_is_dying()

check that a timeout(9) has been initialized before deleting it

ok phessler

create another kthread to run xfer abort tasks. xfer abort tasks cannot
be run from the generic task kthread, because xfers that need to be
aborted block newly queued tasks from running (i.e. the xfer to be aborted
blocks the abort of that task). as there are now three types of usb
tasks, add an argument to usb_init_task() and another member to struct
usb_task to specify the task type.

fixes boot hangs that are showing up because we now use usb tasks to
attach/detach usb devices.

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

in the detach function remove our usb task before calling any other
teardown functions which could potentially sleep (and then, the usb
task would get called for a half-torn down device)

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

in ca_attach() there is no need to set .value and .flags of sensors to 0,
since autoconf(9) allocates softc with M_ZERO; ok deraadt

Kill whitespace, remove unneeded ,

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

Don't use uninitialized variables in umbg_detach.

Degrade sensor status in an interrupt context.

Don't use utc_off, time is always reported in UTC.

Clean up some debugging left-overs.

knf.

umbg(4) is a driver to support the USB attached Meinberg USB5131 DCF77
radio clock. umbg(4) implements a timedelta sensor and reports the
signal quality in the Signal sensor as percentage. The signal sensor status
further indicates if the clock is free running (WARN).

ok dlg, jsg

Nuke all occurrences of usbd_abort_pipe() if it gets called right
before usbd_close_pipe(), since usbd_close_pipe() already takes care
about aborting non-empty pipes.

As investigated by gerhard@ usbdi.c rev. 1.57 did add usbd_abort_pipe()
to usbd_close_pipe(), but the drivers didn't get cleaned up afterwards.

ok gerhard@

support Meinberg DCF600USB, from weerd@, ok phessler

Delete unnecessary <sys/file.h> includes

ok millert@ krw@

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

tedu another bunch of DVACT_DEACTIVATE handlers that do nothing but set
the 'dying' flag.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

Instead of using a wrapper around usbd_transfer() when submitting a
transfer synchronously just pass the USBD_SYNCHRONOUS flag like any
other flags when creating a transfer.

ok sthen@, mglocker@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

* replace per-driver dying and/or other state variables with use of
usbd_deactivete() and usbd_is_dying()
* use usbd_deactivate() in activate()/DEACTIVATE
* convert a few more direct checks of the associated bus' dying flag
with usbd_is_dying()

check that a timeout(9) has been initialized before deleting it

ok phessler

create another kthread to run xfer abort tasks. xfer abort tasks cannot
be run from the generic task kthread, because xfers that need to be
aborted block newly queued tasks from running (i.e. the xfer to be aborted
blocks the abort of that task). as there are now three types of usb
tasks, add an argument to usb_init_task() and another member to struct
usb_task to specify the task type.

fixes boot hangs that are showing up because we now use usb tasks to
attach/detach usb devices.

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

in the detach function remove our usb task before calling any other
teardown functions which could potentially sleep (and then, the usb
task would get called for a half-torn down device)

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

in ca_attach() there is no need to set .value and .flags of sensors to 0,
since autoconf(9) allocates softc with M_ZERO; ok deraadt

Kill whitespace, remove unneeded ,

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

Don't use uninitialized variables in umbg_detach.

Degrade sensor status in an interrupt context.

Don't use utc_off, time is always reported in UTC.

Clean up some debugging left-overs.

knf.

umbg(4) is a driver to support the USB attached Meinberg USB5131 DCF77
radio clock. umbg(4) implements a timedelta sensor and reports the
signal quality in the Signal sensor as percentage. The signal sensor status
further indicates if the clock is free running (WARN).

ok dlg, jsg

support Meinberg DCF600USB, from weerd@, ok phessler

Delete unnecessary <sys/file.h> includes

ok millert@ krw@

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

tedu another bunch of DVACT_DEACTIVATE handlers that do nothing but set
the 'dying' flag.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

Instead of using a wrapper around usbd_transfer() when submitting a
transfer synchronously just pass the USBD_SYNCHRONOUS flag like any
other flags when creating a transfer.

ok sthen@, mglocker@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

* replace per-driver dying and/or other state variables with use of
usbd_deactivete() and usbd_is_dying()
* use usbd_deactivate() in activate()/DEACTIVATE
* convert a few more direct checks of the associated bus' dying flag
with usbd_is_dying()

check that a timeout(9) has been initialized before deleting it

ok phessler

create another kthread to run xfer abort tasks. xfer abort tasks cannot
be run from the generic task kthread, because xfers that need to be
aborted block newly queued tasks from running (i.e. the xfer to be aborted
blocks the abort of that task). as there are now three types of usb
tasks, add an argument to usb_init_task() and another member to struct
usb_task to specify the task type.

fixes boot hangs that are showing up because we now use usb tasks to
attach/detach usb devices.

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

in the detach function remove our usb task before calling any other
teardown functions which could potentially sleep (and then, the usb
task would get called for a half-torn down device)

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

in ca_attach() there is no need to set .value and .flags of sensors to 0,
since autoconf(9) allocates softc with M_ZERO; ok deraadt

Kill whitespace, remove unneeded ,

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

Don't use uninitialized variables in umbg_detach.

Degrade sensor status in an interrupt context.

Don't use utc_off, time is always reported in UTC.

Clean up some debugging left-overs.

knf.

umbg(4) is a driver to support the USB attached Meinberg USB5131 DCF77
radio clock. umbg(4) implements a timedelta sensor and reports the
signal quality in the Signal sensor as percentage. The signal sensor status
further indicates if the clock is free running (WARN).

ok dlg, jsg

Delete unnecessary <sys/file.h> includes

ok millert@ krw@

Avoid calling usbd_set_config_index() in *_attach() and let the stack
do it instead.

If anything bad happen due to a malformed descriptor it makes no sense
to try to attach a driver, and bail before probing.

tedu another bunch of DVACT_DEACTIVATE handlers that do nothing but set
the 'dying' flag.

Clean-up usbd_abort_pipe() usage.


This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.

"If it compiles, ok" mpi@

Get rid of various 'typedef struct' definitions and use plain structure
definitions instead. We don't change usb.h for now to stay compatible
with userland.

Tested by mpi@ on macppc and myself on i386.

ok mpi@

Instead of using a wrapper around usbd_transfer() when submitting a
transfer synchronously just pass the USBD_SYNCHRONOUS flag like any
other flags when creating a transfer.

ok sthen@, mglocker@

proc.h is way too much header for usb to handle.

you probably don't need to include vnode.h or reboot.h. you most definitely
absolutely do not need to include vnode.h because it includes uvm_extern.h
and you want the idiotic TRUE FALSE defines from uvm.

Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thing
that's ever used it, and it's long since been changed to use
DVACT_{QUIESCE,SUSPEND,RESUME} instead.

ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it
up a few weeks ago

garbage collect "usb events". without /dev/usb there is no way to access
them from userland, and nothing in the kernel uses them.

ok krw@, miod@

* replace per-driver dying and/or other state variables with use of
usbd_deactivete() and usbd_is_dying()
* use usbd_deactivate() in activate()/DEACTIVATE
* convert a few more direct checks of the associated bus' dying flag
with usbd_is_dying()

check that a timeout(9) has been initialized before deleting it

ok phessler

create another kthread to run xfer abort tasks. xfer abort tasks cannot
be run from the generic task kthread, because xfers that need to be
aborted block newly queued tasks from running (i.e. the xfer to be aborted
blocks the abort of that task). as there are now three types of usb
tasks, add an argument to usb_init_task() and another member to struct
usb_task to specify the task type.

fixes boot hangs that are showing up because we now use usb tasks to
attach/detach usb devices.

remove dying flag in detach() function.
The dying flag will be set in activate()/DEACTIVATE.

ok deraadt@

in the detach function remove our usb task before calling any other
teardown functions which could potentially sleep (and then, the usb
task would get called for a half-torn down device)

Get rid of devact enum, substitute it with an int and coresponding defines.

This is needed for the addition of further suspend/resume actions.

Okay deraadt@, marco@.

in ca_attach() there is no need to set .value and .flags of sensors to 0,
since autoconf(9) allocates softc with M_ZERO; ok deraadt

Kill whitespace, remove unneeded ,

Convert timeout_add() calls using multiples of hz to timeout_add_sec()

Really just the low-hanging fruit of (hopefully) forthcoming timeout
conversions.

ok art@, krw@

Don't use uninitialized variables in umbg_detach.

Degrade sensor status in an interrupt context.

Don't use utc_off, time is always reported in UTC.

Clean up some debugging left-overs.

knf.

umbg(4) is a driver to support the USB attached Meinberg USB5131 DCF77
radio clock. umbg(4) implements a timedelta sensor and reports the
signal quality in the Signal sensor as percentage. The signal sensor status
further indicates if the clock is free running (WARN).

ok dlg, jsg