return type on a dedicated line when declaring functions
ok mglocker@

vio: Fix signal handling and locking in sysctl path

Commits f0b002d01d5 "Release the netlock when sleeping for control
messages in in vioioctl()" and 126b881f71 "Insert a workaround for
per-ifp ioctl being called w/o NET_LOCK()." in vio(4) fixed a deadlock
but may cause a crash with a protection fault trap if addresses are
added/removed concurrently.

The actual issue is that signals are not handled correctly while
sleeping. After a signal, there is a race condition where sc_ctrl_inuse
is first set to FREE and then the interrupt handler sets it to DONE,
causing a hang in the next vio_wait_ctrl() call.

To fix it:

* Revert the NET_LOCK unlocking work-around.

* Remove PCATCH from the sleep call when we wait for control queue,
avoiding the race with vio_ctrleof(). To ensure that we don't hang
forever, use a 5 second timeout.

* If the timeout is hit, or if the hypervisor has set the
DEVICE_NEEDS_RESET status bit, do not try to use the control queue
until the next ifconfig down/up which resets the device.

* In order to allow reading the device status from device drivers, add a
new interface to the virtio transport drivers.

* Avoid a crash if there is outgoing traffic while doing ifconfig down.

OK bluhm@

vio(4): poll device status after issuing device reset.

The virtio spec says a driver "should" wait for a device to report
a clear device status after performing a reset. In some hypervisors,
this doesn't matter as the vcpu's io instruction emulation and
virtio network device emulation happen serially in the same thread.
In hypervisors like vmd(8), device reset happens asynchronously and
the driver can't assume the device is ready.

This race condition results in mbuf pool corruption, causing panics.

Bug reported and reproduced by bluhm@. Root cause found and diff
from sf@. ok dv@ and committed on sf@'s behalf with his permission.

The per-VQ MSI-X interrupt handler needs to sync DMA mappings in the
same way that the shared interrupt handler does. This is one of the
requirements of virtio_dequeue(), as specified in its comment above.

Without the DMA sync, it will not see a new entry on the ring and
return. Since the interrupt is edge-triggered there won't be another
one and we'll get stuck.

ok dv@

Fix off-by-one in the MSI-X interrupt establish loop that always tried to
establish one more interrupt than would be needed for per-VQ IRQs. This
meant even though there were enough MSI-X vectors available this path could
fail, roll back previously established interrupts and switch to shared IRQs
as a fallback.

ok dv@

virtio: Set DRIVER_OK earlier

The DRIVER_OK bit must be set before using any virt-queues. To allow
virtio device drivers to use the virt-queues in their attach functions,
set the bit there and not in the virtio transport attach function. Only
vioscsi and viogpu really need this, but let's only have one standard
way to do this.

Noticed because of hangs with vioscsi on qemu/windows and in the Oracle
cloud. With much debugging help by Aaron Mason.

Also revert vioscsi.c 1.31 "Temporarily workaround double calls into
vioscsi_req_done()"

ok krw@

remove duplicate includes
ok deraadt@ miod@ krw@

Constify struct cfattach.

Make virtio(4) less restrictive on the type of BAR it supports for
legacy versions. The current version of Parallels on M1 seems to
not provide the I/O BAR that we expect, and reducing our expectations
seems to be help.

ok kettenis@

Restrict MSI override to i386 and amd64. On other architectures we can
trust the flag set by the PCI host bridge driver and there are cases
where it isn't set because MSIs aren't implemented (for example on riscv64).

ok patrick@, sf@

fix virtio_pci on 32bit archs

bus_space_read/write_8 do not exist there, use two 32bit operations.

Support virtio 1.0 for virtio_pci

virtio 1.0 for virtio_mmio it not yet implemented, but 0.9 devices
continue to work.

Rework virtio_negotiate_features()

Add a sc_driver_features field that is automatically used by
virtio_negotiate_features() and during reinit.

Make virtio_negotiate_features() return an error code. Virtio 1.0 has a
special status bit for feature negotiation that means that negotiation
can fail. Make virtio_negotiate_features() return an error code instead
of the features.

Make virtio_reinit_start() automatically call
virtio_negotiate_features().

Add a convenience function virtio_has_feature() to make checking bits
easier.

Add an error check in viomb for virtio_negotiate_features because it has
some feature bits that may cause negotiation to fail. More error
checking in the child drivers is still missing.

ok mlarkin@

virtio_pci: Move msix vector config into functions

ok mlarkin@

virtio_pci: Split bus space handles

In virtio_pci 1.0, different parts of the register set may be located in
different BARs. Use subregions to make the access independent of the
virtio version.

virtio: Prepare for 64 feature bits

virtio 1.0 supports an arbitrary number of feature bits. However, so far
no more than 64 are used (compared to 32 in virtio 0.9). Adjust data
types to support 64 feature bits.

Later, we may want to use bitmaps and setbit(), ... to support even more
feature bits.

ok mlarkin@

virtio: adjust virtio_setup_queue prototype for 1.0

Make it take an address instead of a PFN.
Pass the virtqueue pointer. In virtio 1.0, more information has to be
configured in the device. Also call virtio_setup_queue() after the
information has been filled in.

ok mlarkin@

virtio: Introduce defines for config(8) flags

Move some PCI-specific defines to a new virtio_pcireg.h file

Also add some virtio 1.0 status and feature bits

Move some common defines to virtiovar.h

And fix some comments

virtio_pci: Support IPL_MPSAFE interrupt handlers

Switch include of virtio header from dev/pci/to dev/pv/

Add vmmci(4) (VMM control interface), a simple guest-side driver for vmm(4) VMs

While we don't have ACPI in vmm(4), we need a simple way to shutdown
and reboot VMs gracefully but the device also allows to add more
direct communications between host and guest later.

OK mlarkin@

virtio_pci: Always allow MSI/MSI-X

For virtio devices, ignore the black/white-listing depending on the PCI
bridge. This enables MSI-X with qemu's old "82441FX" pci-bridge.

Suggested by kettenis@

Support MSI-X in virtio

This increases performance for interrupt heavy loads.

While suspend/resume support for MSI-X is missing, this is also missing for
virtio. So no new issue there.

Currently, qemu's old "82441FX" pci-bridge is still blacklisted for MSI. But
MSI-X is used if qemu is started with "-M q35".

virtio: Move interrupt handler into transport specific code

For MSI-X (and also possibly for other transports), the interrupt
handler must do different things. Move it out of virtio.c and into
virtio_pci.

ARM part tested by patrick@

virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00: Virtio Network Device
becomes simply
virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00

virtio_pci: Do the ISR read without kernel lock

The ISR read is relatively expensive because it causes a vmexit. Grab the
kernel lock only after it is done.

KNF fixes

No object file changes besides line numbers in KASSERTs

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Consistency with the pci_intr_map bits.

ok sf@

Support MSI for virtio. This is useful for bhyve.

Rename write_queue_address -> setup_queue

For transports supporting several interrupts, this function needs to
setup per-queue interrupts in addition of setting the queue address.

No logic change.

OK jasper@

Move sc_ih to virtio_pci_softc, it is not used outside of virtio_pci
and is really a transport-specific thing.

OK jasper@

Remove excessive sys/cdefs.h inclusion
ok guenther millert kettenis

Add $OpenBSD$ CVS Ids.

ok sf@

make the lines printed during attach more consistent with other drivers

ok mikeb@ sf@

Add new drivers for virtio network (vio) and block devices (vioblk, the disks
attach as scsi disks). These are paravirtualized devices offered by some
hypervisors like kvm and virtualbox.

The virtio transport driver has the pci specific parts separated out. This
will make it easier to add support for mmio (e.g. for ARM) later.

OK mikeb
OK jasper
"commit what you have" deraadt

vio: Fix signal handling and locking in sysctl path

Commits f0b002d01d5 "Release the netlock when sleeping for control
messages in in vioioctl()" and 126b881f71 "Insert a workaround for
per-ifp ioctl being called w/o NET_LOCK()." in vio(4) fixed a deadlock
but may cause a crash with a protection fault trap if addresses are
added/removed concurrently.

The actual issue is that signals are not handled correctly while
sleeping. After a signal, there is a race condition where sc_ctrl_inuse
is first set to FREE and then the interrupt handler sets it to DONE,
causing a hang in the next vio_wait_ctrl() call.

To fix it:

* Revert the NET_LOCK unlocking work-around.

* Remove PCATCH from the sleep call when we wait for control queue,
avoiding the race with vio_ctrleof(). To ensure that we don't hang
forever, use a 5 second timeout.

* If the timeout is hit, or if the hypervisor has set the
DEVICE_NEEDS_RESET status bit, do not try to use the control queue
until the next ifconfig down/up which resets the device.

* In order to allow reading the device status from device drivers, add a
new interface to the virtio transport drivers.

* Avoid a crash if there is outgoing traffic while doing ifconfig down.

OK bluhm@

vio(4): poll device status after issuing device reset.

The virtio spec says a driver "should" wait for a device to report
a clear device status after performing a reset. In some hypervisors,
this doesn't matter as the vcpu's io instruction emulation and
virtio network device emulation happen serially in the same thread.
In hypervisors like vmd(8), device reset happens asynchronously and
the driver can't assume the device is ready.

This race condition results in mbuf pool corruption, causing panics.

Bug reported and reproduced by bluhm@. Root cause found and diff
from sf@. ok dv@ and committed on sf@'s behalf with his permission.

The per-VQ MSI-X interrupt handler needs to sync DMA mappings in the
same way that the shared interrupt handler does. This is one of the
requirements of virtio_dequeue(), as specified in its comment above.

Without the DMA sync, it will not see a new entry on the ring and
return. Since the interrupt is edge-triggered there won't be another
one and we'll get stuck.

ok dv@

Fix off-by-one in the MSI-X interrupt establish loop that always tried to
establish one more interrupt than would be needed for per-VQ IRQs. This
meant even though there were enough MSI-X vectors available this path could
fail, roll back previously established interrupts and switch to shared IRQs
as a fallback.

ok dv@

virtio: Set DRIVER_OK earlier

The DRIVER_OK bit must be set before using any virt-queues. To allow
virtio device drivers to use the virt-queues in their attach functions,
set the bit there and not in the virtio transport attach function. Only
vioscsi and viogpu really need this, but let's only have one standard
way to do this.

Noticed because of hangs with vioscsi on qemu/windows and in the Oracle
cloud. With much debugging help by Aaron Mason.

Also revert vioscsi.c 1.31 "Temporarily workaround double calls into
vioscsi_req_done()"

ok krw@

remove duplicate includes
ok deraadt@ miod@ krw@

Constify struct cfattach.

Make virtio(4) less restrictive on the type of BAR it supports for
legacy versions. The current version of Parallels on M1 seems to
not provide the I/O BAR that we expect, and reducing our expectations
seems to be help.

ok kettenis@

Restrict MSI override to i386 and amd64. On other architectures we can
trust the flag set by the PCI host bridge driver and there are cases
where it isn't set because MSIs aren't implemented (for example on riscv64).

ok patrick@, sf@

fix virtio_pci on 32bit archs

bus_space_read/write_8 do not exist there, use two 32bit operations.

Support virtio 1.0 for virtio_pci

virtio 1.0 for virtio_mmio it not yet implemented, but 0.9 devices
continue to work.

Rework virtio_negotiate_features()

Add a sc_driver_features field that is automatically used by
virtio_negotiate_features() and during reinit.

Make virtio_negotiate_features() return an error code. Virtio 1.0 has a
special status bit for feature negotiation that means that negotiation
can fail. Make virtio_negotiate_features() return an error code instead
of the features.

Make virtio_reinit_start() automatically call
virtio_negotiate_features().

Add a convenience function virtio_has_feature() to make checking bits
easier.

Add an error check in viomb for virtio_negotiate_features because it has
some feature bits that may cause negotiation to fail. More error
checking in the child drivers is still missing.

ok mlarkin@

virtio_pci: Move msix vector config into functions

ok mlarkin@

virtio_pci: Split bus space handles

In virtio_pci 1.0, different parts of the register set may be located in
different BARs. Use subregions to make the access independent of the
virtio version.

virtio: Prepare for 64 feature bits

virtio 1.0 supports an arbitrary number of feature bits. However, so far
no more than 64 are used (compared to 32 in virtio 0.9). Adjust data
types to support 64 feature bits.

Later, we may want to use bitmaps and setbit(), ... to support even more
feature bits.

ok mlarkin@

virtio: adjust virtio_setup_queue prototype for 1.0

Make it take an address instead of a PFN.
Pass the virtqueue pointer. In virtio 1.0, more information has to be
configured in the device. Also call virtio_setup_queue() after the
information has been filled in.

ok mlarkin@

virtio: Introduce defines for config(8) flags

Move some PCI-specific defines to a new virtio_pcireg.h file

Also add some virtio 1.0 status and feature bits

Move some common defines to virtiovar.h

And fix some comments

virtio_pci: Support IPL_MPSAFE interrupt handlers

Switch include of virtio header from dev/pci/to dev/pv/

Add vmmci(4) (VMM control interface), a simple guest-side driver for vmm(4) VMs

While we don't have ACPI in vmm(4), we need a simple way to shutdown
and reboot VMs gracefully but the device also allows to add more
direct communications between host and guest later.

OK mlarkin@

virtio_pci: Always allow MSI/MSI-X

For virtio devices, ignore the black/white-listing depending on the PCI
bridge. This enables MSI-X with qemu's old "82441FX" pci-bridge.

Suggested by kettenis@

Support MSI-X in virtio

This increases performance for interrupt heavy loads.

While suspend/resume support for MSI-X is missing, this is also missing for
virtio. So no new issue there.

Currently, qemu's old "82441FX" pci-bridge is still blacklisted for MSI. But
MSI-X is used if qemu is started with "-M q35".

virtio: Move interrupt handler into transport specific code

For MSI-X (and also possibly for other transports), the interrupt
handler must do different things. Move it out of virtio.c and into
virtio_pci.

ARM part tested by patrick@

virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00: Virtio Network Device
becomes simply
virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00

virtio_pci: Do the ISR read without kernel lock

The ISR read is relatively expensive because it causes a vmexit. Grab the
kernel lock only after it is done.

KNF fixes

No object file changes besides line numbers in KASSERTs

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Consistency with the pci_intr_map bits.

ok sf@

Support MSI for virtio. This is useful for bhyve.

Rename write_queue_address -> setup_queue

For transports supporting several interrupts, this function needs to
setup per-queue interrupts in addition of setting the queue address.

No logic change.

OK jasper@

Move sc_ih to virtio_pci_softc, it is not used outside of virtio_pci
and is really a transport-specific thing.

OK jasper@

Remove excessive sys/cdefs.h inclusion
ok guenther millert kettenis

Add $OpenBSD$ CVS Ids.

ok sf@

make the lines printed during attach more consistent with other drivers

ok mikeb@ sf@

Add new drivers for virtio network (vio) and block devices (vioblk, the disks
attach as scsi disks). These are paravirtualized devices offered by some
hypervisors like kvm and virtualbox.

The virtio transport driver has the pci specific parts separated out. This
will make it easier to add support for mmio (e.g. for ARM) later.

OK mikeb
OK jasper
"commit what you have" deraadt

vio(4): poll device status after issuing device reset.

The virtio spec says a driver "should" wait for a device to report
a clear device status after performing a reset. In some hypervisors,
this doesn't matter as the vcpu's io instruction emulation and
virtio network device emulation happen serially in the same thread.
In hypervisors like vmd(8), device reset happens asynchronously and
the driver can't assume the device is ready.

This race condition results in mbuf pool corruption, causing panics.

Bug reported and reproduced by bluhm@. Root cause found and diff
from sf@. ok dv@ and committed on sf@'s behalf with his permission.

The per-VQ MSI-X interrupt handler needs to sync DMA mappings in the
same way that the shared interrupt handler does. This is one of the
requirements of virtio_dequeue(), as specified in its comment above.

Without the DMA sync, it will not see a new entry on the ring and
return. Since the interrupt is edge-triggered there won't be another
one and we'll get stuck.

ok dv@

Fix off-by-one in the MSI-X interrupt establish loop that always tried to
establish one more interrupt than would be needed for per-VQ IRQs. This
meant even though there were enough MSI-X vectors available this path could
fail, roll back previously established interrupts and switch to shared IRQs
as a fallback.

ok dv@

virtio: Set DRIVER_OK earlier

The DRIVER_OK bit must be set before using any virt-queues. To allow
virtio device drivers to use the virt-queues in their attach functions,
set the bit there and not in the virtio transport attach function. Only
vioscsi and viogpu really need this, but let's only have one standard
way to do this.

Noticed because of hangs with vioscsi on qemu/windows and in the Oracle
cloud. With much debugging help by Aaron Mason.

Also revert vioscsi.c 1.31 "Temporarily workaround double calls into
vioscsi_req_done()"

ok krw@

remove duplicate includes
ok deraadt@ miod@ krw@

Constify struct cfattach.

Make virtio(4) less restrictive on the type of BAR it supports for
legacy versions. The current version of Parallels on M1 seems to
not provide the I/O BAR that we expect, and reducing our expectations
seems to be help.

ok kettenis@

Restrict MSI override to i386 and amd64. On other architectures we can
trust the flag set by the PCI host bridge driver and there are cases
where it isn't set because MSIs aren't implemented (for example on riscv64).

ok patrick@, sf@

fix virtio_pci on 32bit archs

bus_space_read/write_8 do not exist there, use two 32bit operations.

Support virtio 1.0 for virtio_pci

virtio 1.0 for virtio_mmio it not yet implemented, but 0.9 devices
continue to work.

Rework virtio_negotiate_features()

Add a sc_driver_features field that is automatically used by
virtio_negotiate_features() and during reinit.

Make virtio_negotiate_features() return an error code. Virtio 1.0 has a
special status bit for feature negotiation that means that negotiation
can fail. Make virtio_negotiate_features() return an error code instead
of the features.

Make virtio_reinit_start() automatically call
virtio_negotiate_features().

Add a convenience function virtio_has_feature() to make checking bits
easier.

Add an error check in viomb for virtio_negotiate_features because it has
some feature bits that may cause negotiation to fail. More error
checking in the child drivers is still missing.

ok mlarkin@

virtio_pci: Move msix vector config into functions

ok mlarkin@

virtio_pci: Split bus space handles

In virtio_pci 1.0, different parts of the register set may be located in
different BARs. Use subregions to make the access independent of the
virtio version.

virtio: Prepare for 64 feature bits

virtio 1.0 supports an arbitrary number of feature bits. However, so far
no more than 64 are used (compared to 32 in virtio 0.9). Adjust data
types to support 64 feature bits.

Later, we may want to use bitmaps and setbit(), ... to support even more
feature bits.

ok mlarkin@

virtio: adjust virtio_setup_queue prototype for 1.0

Make it take an address instead of a PFN.
Pass the virtqueue pointer. In virtio 1.0, more information has to be
configured in the device. Also call virtio_setup_queue() after the
information has been filled in.

ok mlarkin@

virtio: Introduce defines for config(8) flags

Move some PCI-specific defines to a new virtio_pcireg.h file

Also add some virtio 1.0 status and feature bits

Move some common defines to virtiovar.h

And fix some comments

virtio_pci: Support IPL_MPSAFE interrupt handlers

Switch include of virtio header from dev/pci/to dev/pv/

Add vmmci(4) (VMM control interface), a simple guest-side driver for vmm(4) VMs

While we don't have ACPI in vmm(4), we need a simple way to shutdown
and reboot VMs gracefully but the device also allows to add more
direct communications between host and guest later.

OK mlarkin@

virtio_pci: Always allow MSI/MSI-X

For virtio devices, ignore the black/white-listing depending on the PCI
bridge. This enables MSI-X with qemu's old "82441FX" pci-bridge.

Suggested by kettenis@

Support MSI-X in virtio

This increases performance for interrupt heavy loads.

While suspend/resume support for MSI-X is missing, this is also missing for
virtio. So no new issue there.

Currently, qemu's old "82441FX" pci-bridge is still blacklisted for MSI. But
MSI-X is used if qemu is started with "-M q35".

virtio: Move interrupt handler into transport specific code

For MSI-X (and also possibly for other transports), the interrupt
handler must do different things. Move it out of virtio.c and into
virtio_pci.

ARM part tested by patrick@

virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00: Virtio Network Device
becomes simply
virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00

virtio_pci: Do the ISR read without kernel lock

The ISR read is relatively expensive because it causes a vmexit. Grab the
kernel lock only after it is done.

KNF fixes

No object file changes besides line numbers in KASSERTs

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Consistency with the pci_intr_map bits.

ok sf@

Support MSI for virtio. This is useful for bhyve.

Rename write_queue_address -> setup_queue

For transports supporting several interrupts, this function needs to
setup per-queue interrupts in addition of setting the queue address.

No logic change.

OK jasper@

Move sc_ih to virtio_pci_softc, it is not used outside of virtio_pci
and is really a transport-specific thing.

OK jasper@

Remove excessive sys/cdefs.h inclusion
ok guenther millert kettenis

Add $OpenBSD$ CVS Ids.

ok sf@

make the lines printed during attach more consistent with other drivers

ok mikeb@ sf@

Add new drivers for virtio network (vio) and block devices (vioblk, the disks
attach as scsi disks). These are paravirtualized devices offered by some
hypervisors like kvm and virtualbox.

The virtio transport driver has the pci specific parts separated out. This
will make it easier to add support for mmio (e.g. for ARM) later.

OK mikeb
OK jasper
"commit what you have" deraadt

The per-VQ MSI-X interrupt handler needs to sync DMA mappings in the
same way that the shared interrupt handler does. This is one of the
requirements of virtio_dequeue(), as specified in its comment above.

Without the DMA sync, it will not see a new entry on the ring and
return. Since the interrupt is edge-triggered there won't be another
one and we'll get stuck.

ok dv@

Fix off-by-one in the MSI-X interrupt establish loop that always tried to
establish one more interrupt than would be needed for per-VQ IRQs. This
meant even though there were enough MSI-X vectors available this path could
fail, roll back previously established interrupts and switch to shared IRQs
as a fallback.

ok dv@

virtio: Set DRIVER_OK earlier

The DRIVER_OK bit must be set before using any virt-queues. To allow
virtio device drivers to use the virt-queues in their attach functions,
set the bit there and not in the virtio transport attach function. Only
vioscsi and viogpu really need this, but let's only have one standard
way to do this.

Noticed because of hangs with vioscsi on qemu/windows and in the Oracle
cloud. With much debugging help by Aaron Mason.

Also revert vioscsi.c 1.31 "Temporarily workaround double calls into
vioscsi_req_done()"

ok krw@

remove duplicate includes
ok deraadt@ miod@ krw@

Constify struct cfattach.

Make virtio(4) less restrictive on the type of BAR it supports for
legacy versions. The current version of Parallels on M1 seems to
not provide the I/O BAR that we expect, and reducing our expectations
seems to be help.

ok kettenis@

Restrict MSI override to i386 and amd64. On other architectures we can
trust the flag set by the PCI host bridge driver and there are cases
where it isn't set because MSIs aren't implemented (for example on riscv64).

ok patrick@, sf@

fix virtio_pci on 32bit archs

bus_space_read/write_8 do not exist there, use two 32bit operations.

Support virtio 1.0 for virtio_pci

virtio 1.0 for virtio_mmio it not yet implemented, but 0.9 devices
continue to work.

Rework virtio_negotiate_features()

Add a sc_driver_features field that is automatically used by
virtio_negotiate_features() and during reinit.

Make virtio_negotiate_features() return an error code. Virtio 1.0 has a
special status bit for feature negotiation that means that negotiation
can fail. Make virtio_negotiate_features() return an error code instead
of the features.

Make virtio_reinit_start() automatically call
virtio_negotiate_features().

Add a convenience function virtio_has_feature() to make checking bits
easier.

Add an error check in viomb for virtio_negotiate_features because it has
some feature bits that may cause negotiation to fail. More error
checking in the child drivers is still missing.

ok mlarkin@

virtio_pci: Move msix vector config into functions

ok mlarkin@

virtio_pci: Split bus space handles

In virtio_pci 1.0, different parts of the register set may be located in
different BARs. Use subregions to make the access independent of the
virtio version.

virtio: Prepare for 64 feature bits

virtio 1.0 supports an arbitrary number of feature bits. However, so far
no more than 64 are used (compared to 32 in virtio 0.9). Adjust data
types to support 64 feature bits.

Later, we may want to use bitmaps and setbit(), ... to support even more
feature bits.

ok mlarkin@

virtio: adjust virtio_setup_queue prototype for 1.0

Make it take an address instead of a PFN.
Pass the virtqueue pointer. In virtio 1.0, more information has to be
configured in the device. Also call virtio_setup_queue() after the
information has been filled in.

ok mlarkin@

virtio: Introduce defines for config(8) flags

Move some PCI-specific defines to a new virtio_pcireg.h file

Also add some virtio 1.0 status and feature bits

Move some common defines to virtiovar.h

And fix some comments

virtio_pci: Support IPL_MPSAFE interrupt handlers

Switch include of virtio header from dev/pci/to dev/pv/

Add vmmci(4) (VMM control interface), a simple guest-side driver for vmm(4) VMs

While we don't have ACPI in vmm(4), we need a simple way to shutdown
and reboot VMs gracefully but the device also allows to add more
direct communications between host and guest later.

OK mlarkin@

virtio_pci: Always allow MSI/MSI-X

For virtio devices, ignore the black/white-listing depending on the PCI
bridge. This enables MSI-X with qemu's old "82441FX" pci-bridge.

Suggested by kettenis@

Support MSI-X in virtio

This increases performance for interrupt heavy loads.

While suspend/resume support for MSI-X is missing, this is also missing for
virtio. So no new issue there.

Currently, qemu's old "82441FX" pci-bridge is still blacklisted for MSI. But
MSI-X is used if qemu is started with "-M q35".

virtio: Move interrupt handler into transport specific code

For MSI-X (and also possibly for other transports), the interrupt
handler must do different things. Move it out of virtio.c and into
virtio_pci.

ARM part tested by patrick@

virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00: Virtio Network Device
becomes simply
virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00

virtio_pci: Do the ISR read without kernel lock

The ISR read is relatively expensive because it causes a vmexit. Grab the
kernel lock only after it is done.

KNF fixes

No object file changes besides line numbers in KASSERTs

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Consistency with the pci_intr_map bits.

ok sf@

Support MSI for virtio. This is useful for bhyve.

Rename write_queue_address -> setup_queue

For transports supporting several interrupts, this function needs to
setup per-queue interrupts in addition of setting the queue address.

No logic change.

OK jasper@

Move sc_ih to virtio_pci_softc, it is not used outside of virtio_pci
and is really a transport-specific thing.

OK jasper@

Remove excessive sys/cdefs.h inclusion
ok guenther millert kettenis

Add $OpenBSD$ CVS Ids.

ok sf@

make the lines printed during attach more consistent with other drivers

ok mikeb@ sf@

Add new drivers for virtio network (vio) and block devices (vioblk, the disks
attach as scsi disks). These are paravirtualized devices offered by some
hypervisors like kvm and virtualbox.

The virtio transport driver has the pci specific parts separated out. This
will make it easier to add support for mmio (e.g. for ARM) later.

OK mikeb
OK jasper
"commit what you have" deraadt

Fix off-by-one in the MSI-X interrupt establish loop that always tried to
establish one more interrupt than would be needed for per-VQ IRQs. This
meant even though there were enough MSI-X vectors available this path could
fail, roll back previously established interrupts and switch to shared IRQs
as a fallback.

ok dv@

virtio: Set DRIVER_OK earlier

The DRIVER_OK bit must be set before using any virt-queues. To allow
virtio device drivers to use the virt-queues in their attach functions,
set the bit there and not in the virtio transport attach function. Only
vioscsi and viogpu really need this, but let's only have one standard
way to do this.

Noticed because of hangs with vioscsi on qemu/windows and in the Oracle
cloud. With much debugging help by Aaron Mason.

Also revert vioscsi.c 1.31 "Temporarily workaround double calls into
vioscsi_req_done()"

ok krw@

remove duplicate includes
ok deraadt@ miod@ krw@

Constify struct cfattach.

Make virtio(4) less restrictive on the type of BAR it supports for
legacy versions. The current version of Parallels on M1 seems to
not provide the I/O BAR that we expect, and reducing our expectations
seems to be help.

ok kettenis@

Restrict MSI override to i386 and amd64. On other architectures we can
trust the flag set by the PCI host bridge driver and there are cases
where it isn't set because MSIs aren't implemented (for example on riscv64).

ok patrick@, sf@

fix virtio_pci on 32bit archs

bus_space_read/write_8 do not exist there, use two 32bit operations.

Support virtio 1.0 for virtio_pci

virtio 1.0 for virtio_mmio it not yet implemented, but 0.9 devices
continue to work.

Rework virtio_negotiate_features()

Add a sc_driver_features field that is automatically used by
virtio_negotiate_features() and during reinit.

Make virtio_negotiate_features() return an error code. Virtio 1.0 has a
special status bit for feature negotiation that means that negotiation
can fail. Make virtio_negotiate_features() return an error code instead
of the features.

Make virtio_reinit_start() automatically call
virtio_negotiate_features().

Add a convenience function virtio_has_feature() to make checking bits
easier.

Add an error check in viomb for virtio_negotiate_features because it has
some feature bits that may cause negotiation to fail. More error
checking in the child drivers is still missing.

ok mlarkin@

virtio_pci: Move msix vector config into functions

ok mlarkin@

virtio_pci: Split bus space handles

In virtio_pci 1.0, different parts of the register set may be located in
different BARs. Use subregions to make the access independent of the
virtio version.

virtio: Prepare for 64 feature bits

virtio 1.0 supports an arbitrary number of feature bits. However, so far
no more than 64 are used (compared to 32 in virtio 0.9). Adjust data
types to support 64 feature bits.

Later, we may want to use bitmaps and setbit(), ... to support even more
feature bits.

ok mlarkin@

virtio: adjust virtio_setup_queue prototype for 1.0

Make it take an address instead of a PFN.
Pass the virtqueue pointer. In virtio 1.0, more information has to be
configured in the device. Also call virtio_setup_queue() after the
information has been filled in.

ok mlarkin@

virtio: Introduce defines for config(8) flags

Move some PCI-specific defines to a new virtio_pcireg.h file

Also add some virtio 1.0 status and feature bits

Move some common defines to virtiovar.h

And fix some comments

virtio_pci: Support IPL_MPSAFE interrupt handlers

Switch include of virtio header from dev/pci/to dev/pv/

Add vmmci(4) (VMM control interface), a simple guest-side driver for vmm(4) VMs

While we don't have ACPI in vmm(4), we need a simple way to shutdown
and reboot VMs gracefully but the device also allows to add more
direct communications between host and guest later.

OK mlarkin@

virtio_pci: Always allow MSI/MSI-X

For virtio devices, ignore the black/white-listing depending on the PCI
bridge. This enables MSI-X with qemu's old "82441FX" pci-bridge.

Suggested by kettenis@

Support MSI-X in virtio

This increases performance for interrupt heavy loads.

While suspend/resume support for MSI-X is missing, this is also missing for
virtio. So no new issue there.

Currently, qemu's old "82441FX" pci-bridge is still blacklisted for MSI. But
MSI-X is used if qemu is started with "-M q35".

virtio: Move interrupt handler into transport specific code

For MSI-X (and also possibly for other transports), the interrupt
handler must do different things. Move it out of virtio.c and into
virtio_pci.

ARM part tested by patrick@

virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00: Virtio Network Device
becomes simply
virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00

virtio_pci: Do the ISR read without kernel lock

The ISR read is relatively expensive because it causes a vmexit. Grab the
kernel lock only after it is done.

KNF fixes

No object file changes besides line numbers in KASSERTs

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Consistency with the pci_intr_map bits.

ok sf@

Support MSI for virtio. This is useful for bhyve.

Rename write_queue_address -> setup_queue

For transports supporting several interrupts, this function needs to
setup per-queue interrupts in addition of setting the queue address.

No logic change.

OK jasper@

Move sc_ih to virtio_pci_softc, it is not used outside of virtio_pci
and is really a transport-specific thing.

OK jasper@

Remove excessive sys/cdefs.h inclusion
ok guenther millert kettenis

Add $OpenBSD$ CVS Ids.

ok sf@

make the lines printed during attach more consistent with other drivers

ok mikeb@ sf@

Add new drivers for virtio network (vio) and block devices (vioblk, the disks
attach as scsi disks). These are paravirtualized devices offered by some
hypervisors like kvm and virtualbox.

The virtio transport driver has the pci specific parts separated out. This
will make it easier to add support for mmio (e.g. for ARM) later.

OK mikeb
OK jasper
"commit what you have" deraadt

virtio: Set DRIVER_OK earlier

The DRIVER_OK bit must be set before using any virt-queues. To allow
virtio device drivers to use the virt-queues in their attach functions,
set the bit there and not in the virtio transport attach function. Only
vioscsi and viogpu really need this, but let's only have one standard
way to do this.

Noticed because of hangs with vioscsi on qemu/windows and in the Oracle
cloud. With much debugging help by Aaron Mason.

Also revert vioscsi.c 1.31 "Temporarily workaround double calls into
vioscsi_req_done()"

ok krw@

remove duplicate includes
ok deraadt@ miod@ krw@

Constify struct cfattach.

Make virtio(4) less restrictive on the type of BAR it supports for
legacy versions. The current version of Parallels on M1 seems to
not provide the I/O BAR that we expect, and reducing our expectations
seems to be help.

ok kettenis@

Restrict MSI override to i386 and amd64. On other architectures we can
trust the flag set by the PCI host bridge driver and there are cases
where it isn't set because MSIs aren't implemented (for example on riscv64).

ok patrick@, sf@

fix virtio_pci on 32bit archs

bus_space_read/write_8 do not exist there, use two 32bit operations.

Support virtio 1.0 for virtio_pci

virtio 1.0 for virtio_mmio it not yet implemented, but 0.9 devices
continue to work.

Rework virtio_negotiate_features()

Add a sc_driver_features field that is automatically used by
virtio_negotiate_features() and during reinit.

Make virtio_negotiate_features() return an error code. Virtio 1.0 has a
special status bit for feature negotiation that means that negotiation
can fail. Make virtio_negotiate_features() return an error code instead
of the features.

Make virtio_reinit_start() automatically call
virtio_negotiate_features().

Add a convenience function virtio_has_feature() to make checking bits
easier.

Add an error check in viomb for virtio_negotiate_features because it has
some feature bits that may cause negotiation to fail. More error
checking in the child drivers is still missing.

ok mlarkin@

virtio_pci: Move msix vector config into functions

ok mlarkin@

virtio_pci: Split bus space handles

In virtio_pci 1.0, different parts of the register set may be located in
different BARs. Use subregions to make the access independent of the
virtio version.

virtio: Prepare for 64 feature bits

virtio 1.0 supports an arbitrary number of feature bits. However, so far
no more than 64 are used (compared to 32 in virtio 0.9). Adjust data
types to support 64 feature bits.

Later, we may want to use bitmaps and setbit(), ... to support even more
feature bits.

ok mlarkin@

virtio: adjust virtio_setup_queue prototype for 1.0

Make it take an address instead of a PFN.
Pass the virtqueue pointer. In virtio 1.0, more information has to be
configured in the device. Also call virtio_setup_queue() after the
information has been filled in.

ok mlarkin@

virtio: Introduce defines for config(8) flags

Move some PCI-specific defines to a new virtio_pcireg.h file

Also add some virtio 1.0 status and feature bits

Move some common defines to virtiovar.h

And fix some comments

virtio_pci: Support IPL_MPSAFE interrupt handlers

Switch include of virtio header from dev/pci/to dev/pv/

Add vmmci(4) (VMM control interface), a simple guest-side driver for vmm(4) VMs

While we don't have ACPI in vmm(4), we need a simple way to shutdown
and reboot VMs gracefully but the device also allows to add more
direct communications between host and guest later.

OK mlarkin@

virtio_pci: Always allow MSI/MSI-X

For virtio devices, ignore the black/white-listing depending on the PCI
bridge. This enables MSI-X with qemu's old "82441FX" pci-bridge.

Suggested by kettenis@

Support MSI-X in virtio

This increases performance for interrupt heavy loads.

While suspend/resume support for MSI-X is missing, this is also missing for
virtio. So no new issue there.

Currently, qemu's old "82441FX" pci-bridge is still blacklisted for MSI. But
MSI-X is used if qemu is started with "-M q35".

virtio: Move interrupt handler into transport specific code

For MSI-X (and also possibly for other transports), the interrupt
handler must do different things. Move it out of virtio.c and into
virtio_pci.

ARM part tested by patrick@

virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00: Virtio Network Device
becomes simply
virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00

virtio_pci: Do the ISR read without kernel lock

The ISR read is relatively expensive because it causes a vmexit. Grab the
kernel lock only after it is done.

KNF fixes

No object file changes besides line numbers in KASSERTs

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Consistency with the pci_intr_map bits.

ok sf@

Support MSI for virtio. This is useful for bhyve.

Rename write_queue_address -> setup_queue

For transports supporting several interrupts, this function needs to
setup per-queue interrupts in addition of setting the queue address.

No logic change.

OK jasper@

Move sc_ih to virtio_pci_softc, it is not used outside of virtio_pci
and is really a transport-specific thing.

OK jasper@

Remove excessive sys/cdefs.h inclusion
ok guenther millert kettenis

Add $OpenBSD$ CVS Ids.

ok sf@

make the lines printed during attach more consistent with other drivers

ok mikeb@ sf@

Add new drivers for virtio network (vio) and block devices (vioblk, the disks
attach as scsi disks). These are paravirtualized devices offered by some
hypervisors like kvm and virtualbox.

The virtio transport driver has the pci specific parts separated out. This
will make it easier to add support for mmio (e.g. for ARM) later.

OK mikeb
OK jasper
"commit what you have" deraadt

remove duplicate includes
ok deraadt@ miod@ krw@

Constify struct cfattach.

Make virtio(4) less restrictive on the type of BAR it supports for
legacy versions. The current version of Parallels on M1 seems to
not provide the I/O BAR that we expect, and reducing our expectations
seems to be help.

ok kettenis@

Restrict MSI override to i386 and amd64. On other architectures we can
trust the flag set by the PCI host bridge driver and there are cases
where it isn't set because MSIs aren't implemented (for example on riscv64).

ok patrick@, sf@

fix virtio_pci on 32bit archs

bus_space_read/write_8 do not exist there, use two 32bit operations.

Support virtio 1.0 for virtio_pci

virtio 1.0 for virtio_mmio it not yet implemented, but 0.9 devices
continue to work.

Rework virtio_negotiate_features()

Add a sc_driver_features field that is automatically used by
virtio_negotiate_features() and during reinit.

Make virtio_negotiate_features() return an error code. Virtio 1.0 has a
special status bit for feature negotiation that means that negotiation
can fail. Make virtio_negotiate_features() return an error code instead
of the features.

Make virtio_reinit_start() automatically call
virtio_negotiate_features().

Add a convenience function virtio_has_feature() to make checking bits
easier.

Add an error check in viomb for virtio_negotiate_features because it has
some feature bits that may cause negotiation to fail. More error
checking in the child drivers is still missing.

ok mlarkin@

virtio_pci: Move msix vector config into functions

ok mlarkin@

virtio_pci: Split bus space handles

In virtio_pci 1.0, different parts of the register set may be located in
different BARs. Use subregions to make the access independent of the
virtio version.

virtio: Prepare for 64 feature bits

virtio 1.0 supports an arbitrary number of feature bits. However, so far
no more than 64 are used (compared to 32 in virtio 0.9). Adjust data
types to support 64 feature bits.

Later, we may want to use bitmaps and setbit(), ... to support even more
feature bits.

ok mlarkin@

virtio: adjust virtio_setup_queue prototype for 1.0

Make it take an address instead of a PFN.
Pass the virtqueue pointer. In virtio 1.0, more information has to be
configured in the device. Also call virtio_setup_queue() after the
information has been filled in.

ok mlarkin@

virtio: Introduce defines for config(8) flags

Move some PCI-specific defines to a new virtio_pcireg.h file

Also add some virtio 1.0 status and feature bits

Move some common defines to virtiovar.h

And fix some comments

virtio_pci: Support IPL_MPSAFE interrupt handlers

Switch include of virtio header from dev/pci/to dev/pv/

Add vmmci(4) (VMM control interface), a simple guest-side driver for vmm(4) VMs

While we don't have ACPI in vmm(4), we need a simple way to shutdown
and reboot VMs gracefully but the device also allows to add more
direct communications between host and guest later.

OK mlarkin@

virtio_pci: Always allow MSI/MSI-X

For virtio devices, ignore the black/white-listing depending on the PCI
bridge. This enables MSI-X with qemu's old "82441FX" pci-bridge.

Suggested by kettenis@

Support MSI-X in virtio

This increases performance for interrupt heavy loads.

While suspend/resume support for MSI-X is missing, this is also missing for
virtio. So no new issue there.

Currently, qemu's old "82441FX" pci-bridge is still blacklisted for MSI. But
MSI-X is used if qemu is started with "-M q35".

virtio: Move interrupt handler into transport specific code

For MSI-X (and also possibly for other transports), the interrupt
handler must do different things. Move it out of virtio.c and into
virtio_pci.

ARM part tested by patrick@

virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00: Virtio Network Device
becomes simply
virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00

virtio_pci: Do the ISR read without kernel lock

The ISR read is relatively expensive because it causes a vmexit. Grab the
kernel lock only after it is done.

KNF fixes

No object file changes besides line numbers in KASSERTs

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Consistency with the pci_intr_map bits.

ok sf@

Support MSI for virtio. This is useful for bhyve.

Rename write_queue_address -> setup_queue

For transports supporting several interrupts, this function needs to
setup per-queue interrupts in addition of setting the queue address.

No logic change.

OK jasper@

Move sc_ih to virtio_pci_softc, it is not used outside of virtio_pci
and is really a transport-specific thing.

OK jasper@

Remove excessive sys/cdefs.h inclusion
ok guenther millert kettenis

Add $OpenBSD$ CVS Ids.

ok sf@

make the lines printed during attach more consistent with other drivers

ok mikeb@ sf@

Add new drivers for virtio network (vio) and block devices (vioblk, the disks
attach as scsi disks). These are paravirtualized devices offered by some
hypervisors like kvm and virtualbox.

The virtio transport driver has the pci specific parts separated out. This
will make it easier to add support for mmio (e.g. for ARM) later.

OK mikeb
OK jasper
"commit what you have" deraadt

Constify struct cfattach.

Make virtio(4) less restrictive on the type of BAR it supports for
legacy versions. The current version of Parallels on M1 seems to
not provide the I/O BAR that we expect, and reducing our expectations
seems to be help.

ok kettenis@

Restrict MSI override to i386 and amd64. On other architectures we can
trust the flag set by the PCI host bridge driver and there are cases
where it isn't set because MSIs aren't implemented (for example on riscv64).

ok patrick@, sf@

fix virtio_pci on 32bit archs

bus_space_read/write_8 do not exist there, use two 32bit operations.

Support virtio 1.0 for virtio_pci

virtio 1.0 for virtio_mmio it not yet implemented, but 0.9 devices
continue to work.

Rework virtio_negotiate_features()

Add a sc_driver_features field that is automatically used by
virtio_negotiate_features() and during reinit.

Make virtio_negotiate_features() return an error code. Virtio 1.0 has a
special status bit for feature negotiation that means that negotiation
can fail. Make virtio_negotiate_features() return an error code instead
of the features.

Make virtio_reinit_start() automatically call
virtio_negotiate_features().

Add a convenience function virtio_has_feature() to make checking bits
easier.

Add an error check in viomb for virtio_negotiate_features because it has
some feature bits that may cause negotiation to fail. More error
checking in the child drivers is still missing.

ok mlarkin@

virtio_pci: Move msix vector config into functions

ok mlarkin@

virtio_pci: Split bus space handles

In virtio_pci 1.0, different parts of the register set may be located in
different BARs. Use subregions to make the access independent of the
virtio version.

virtio: Prepare for 64 feature bits

virtio 1.0 supports an arbitrary number of feature bits. However, so far
no more than 64 are used (compared to 32 in virtio 0.9). Adjust data
types to support 64 feature bits.

Later, we may want to use bitmaps and setbit(), ... to support even more
feature bits.

ok mlarkin@

virtio: adjust virtio_setup_queue prototype for 1.0

Make it take an address instead of a PFN.
Pass the virtqueue pointer. In virtio 1.0, more information has to be
configured in the device. Also call virtio_setup_queue() after the
information has been filled in.

ok mlarkin@

virtio: Introduce defines for config(8) flags

Move some PCI-specific defines to a new virtio_pcireg.h file

Also add some virtio 1.0 status and feature bits

Move some common defines to virtiovar.h

And fix some comments

virtio_pci: Support IPL_MPSAFE interrupt handlers

Switch include of virtio header from dev/pci/to dev/pv/

Add vmmci(4) (VMM control interface), a simple guest-side driver for vmm(4) VMs

While we don't have ACPI in vmm(4), we need a simple way to shutdown
and reboot VMs gracefully but the device also allows to add more
direct communications between host and guest later.

OK mlarkin@

virtio_pci: Always allow MSI/MSI-X

For virtio devices, ignore the black/white-listing depending on the PCI
bridge. This enables MSI-X with qemu's old "82441FX" pci-bridge.

Suggested by kettenis@

Support MSI-X in virtio

This increases performance for interrupt heavy loads.

While suspend/resume support for MSI-X is missing, this is also missing for
virtio. So no new issue there.

Currently, qemu's old "82441FX" pci-bridge is still blacklisted for MSI. But
MSI-X is used if qemu is started with "-M q35".

virtio: Move interrupt handler into transport specific code

For MSI-X (and also possibly for other transports), the interrupt
handler must do different things. Move it out of virtio.c and into
virtio_pci.

ARM part tested by patrick@

virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00: Virtio Network Device
becomes simply
virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00

virtio_pci: Do the ISR read without kernel lock

The ISR read is relatively expensive because it causes a vmexit. Grab the
kernel lock only after it is done.

KNF fixes

No object file changes besides line numbers in KASSERTs

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Consistency with the pci_intr_map bits.

ok sf@

Support MSI for virtio. This is useful for bhyve.

Rename write_queue_address -> setup_queue

For transports supporting several interrupts, this function needs to
setup per-queue interrupts in addition of setting the queue address.

No logic change.

OK jasper@

Move sc_ih to virtio_pci_softc, it is not used outside of virtio_pci
and is really a transport-specific thing.

OK jasper@

Remove excessive sys/cdefs.h inclusion
ok guenther millert kettenis

Add $OpenBSD$ CVS Ids.

ok sf@

make the lines printed during attach more consistent with other drivers

ok mikeb@ sf@

Add new drivers for virtio network (vio) and block devices (vioblk, the disks
attach as scsi disks). These are paravirtualized devices offered by some
hypervisors like kvm and virtualbox.

The virtio transport driver has the pci specific parts separated out. This
will make it easier to add support for mmio (e.g. for ARM) later.

OK mikeb
OK jasper
"commit what you have" deraadt

Make virtio(4) less restrictive on the type of BAR it supports for
legacy versions. The current version of Parallels on M1 seems to
not provide the I/O BAR that we expect, and reducing our expectations
seems to be help.

ok kettenis@

Restrict MSI override to i386 and amd64. On other architectures we can
trust the flag set by the PCI host bridge driver and there are cases
where it isn't set because MSIs aren't implemented (for example on riscv64).

ok patrick@, sf@

fix virtio_pci on 32bit archs

bus_space_read/write_8 do not exist there, use two 32bit operations.

Support virtio 1.0 for virtio_pci

virtio 1.0 for virtio_mmio it not yet implemented, but 0.9 devices
continue to work.

Rework virtio_negotiate_features()

Add a sc_driver_features field that is automatically used by
virtio_negotiate_features() and during reinit.

Make virtio_negotiate_features() return an error code. Virtio 1.0 has a
special status bit for feature negotiation that means that negotiation
can fail. Make virtio_negotiate_features() return an error code instead
of the features.

Make virtio_reinit_start() automatically call
virtio_negotiate_features().

Add a convenience function virtio_has_feature() to make checking bits
easier.

Add an error check in viomb for virtio_negotiate_features because it has
some feature bits that may cause negotiation to fail. More error
checking in the child drivers is still missing.

ok mlarkin@

virtio_pci: Move msix vector config into functions

ok mlarkin@

virtio_pci: Split bus space handles

In virtio_pci 1.0, different parts of the register set may be located in
different BARs. Use subregions to make the access independent of the
virtio version.

virtio: Prepare for 64 feature bits

virtio 1.0 supports an arbitrary number of feature bits. However, so far
no more than 64 are used (compared to 32 in virtio 0.9). Adjust data
types to support 64 feature bits.

Later, we may want to use bitmaps and setbit(), ... to support even more
feature bits.

ok mlarkin@

virtio: adjust virtio_setup_queue prototype for 1.0

Make it take an address instead of a PFN.
Pass the virtqueue pointer. In virtio 1.0, more information has to be
configured in the device. Also call virtio_setup_queue() after the
information has been filled in.

ok mlarkin@

virtio: Introduce defines for config(8) flags

Move some PCI-specific defines to a new virtio_pcireg.h file

Also add some virtio 1.0 status and feature bits

Move some common defines to virtiovar.h

And fix some comments

virtio_pci: Support IPL_MPSAFE interrupt handlers

Switch include of virtio header from dev/pci/to dev/pv/

Add vmmci(4) (VMM control interface), a simple guest-side driver for vmm(4) VMs

While we don't have ACPI in vmm(4), we need a simple way to shutdown
and reboot VMs gracefully but the device also allows to add more
direct communications between host and guest later.

OK mlarkin@

virtio_pci: Always allow MSI/MSI-X

For virtio devices, ignore the black/white-listing depending on the PCI
bridge. This enables MSI-X with qemu's old "82441FX" pci-bridge.

Suggested by kettenis@

Support MSI-X in virtio

This increases performance for interrupt heavy loads.

While suspend/resume support for MSI-X is missing, this is also missing for
virtio. So no new issue there.

Currently, qemu's old "82441FX" pci-bridge is still blacklisted for MSI. But
MSI-X is used if qemu is started with "-M q35".

virtio: Move interrupt handler into transport specific code

For MSI-X (and also possibly for other transports), the interrupt
handler must do different things. Move it out of virtio.c and into
virtio_pci.

ARM part tested by patrick@

virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00: Virtio Network Device
becomes simply
virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00

virtio_pci: Do the ISR read without kernel lock

The ISR read is relatively expensive because it causes a vmexit. Grab the
kernel lock only after it is done.

KNF fixes

No object file changes besides line numbers in KASSERTs

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Consistency with the pci_intr_map bits.

ok sf@

Support MSI for virtio. This is useful for bhyve.

Rename write_queue_address -> setup_queue

For transports supporting several interrupts, this function needs to
setup per-queue interrupts in addition of setting the queue address.

No logic change.

OK jasper@

Move sc_ih to virtio_pci_softc, it is not used outside of virtio_pci
and is really a transport-specific thing.

OK jasper@

Remove excessive sys/cdefs.h inclusion
ok guenther millert kettenis

Add $OpenBSD$ CVS Ids.

ok sf@

make the lines printed during attach more consistent with other drivers

ok mikeb@ sf@

Add new drivers for virtio network (vio) and block devices (vioblk, the disks
attach as scsi disks). These are paravirtualized devices offered by some
hypervisors like kvm and virtualbox.

The virtio transport driver has the pci specific parts separated out. This
will make it easier to add support for mmio (e.g. for ARM) later.

OK mikeb
OK jasper
"commit what you have" deraadt

Restrict MSI override to i386 and amd64. On other architectures we can
trust the flag set by the PCI host bridge driver and there are cases
where it isn't set because MSIs aren't implemented (for example on riscv64).

ok patrick@, sf@

fix virtio_pci on 32bit archs

bus_space_read/write_8 do not exist there, use two 32bit operations.

Support virtio 1.0 for virtio_pci

virtio 1.0 for virtio_mmio it not yet implemented, but 0.9 devices
continue to work.

Rework virtio_negotiate_features()

Add a sc_driver_features field that is automatically used by
virtio_negotiate_features() and during reinit.

Make virtio_negotiate_features() return an error code. Virtio 1.0 has a
special status bit for feature negotiation that means that negotiation
can fail. Make virtio_negotiate_features() return an error code instead
of the features.

Make virtio_reinit_start() automatically call
virtio_negotiate_features().

Add a convenience function virtio_has_feature() to make checking bits
easier.

Add an error check in viomb for virtio_negotiate_features because it has
some feature bits that may cause negotiation to fail. More error
checking in the child drivers is still missing.

ok mlarkin@

virtio_pci: Move msix vector config into functions

ok mlarkin@

virtio_pci: Split bus space handles

In virtio_pci 1.0, different parts of the register set may be located in
different BARs. Use subregions to make the access independent of the
virtio version.

virtio: Prepare for 64 feature bits

virtio 1.0 supports an arbitrary number of feature bits. However, so far
no more than 64 are used (compared to 32 in virtio 0.9). Adjust data
types to support 64 feature bits.

Later, we may want to use bitmaps and setbit(), ... to support even more
feature bits.

ok mlarkin@

virtio: adjust virtio_setup_queue prototype for 1.0

Make it take an address instead of a PFN.
Pass the virtqueue pointer. In virtio 1.0, more information has to be
configured in the device. Also call virtio_setup_queue() after the
information has been filled in.

ok mlarkin@

virtio: Introduce defines for config(8) flags

Move some PCI-specific defines to a new virtio_pcireg.h file

Also add some virtio 1.0 status and feature bits

Move some common defines to virtiovar.h

And fix some comments

virtio_pci: Support IPL_MPSAFE interrupt handlers

Switch include of virtio header from dev/pci/to dev/pv/

Add vmmci(4) (VMM control interface), a simple guest-side driver for vmm(4) VMs

While we don't have ACPI in vmm(4), we need a simple way to shutdown
and reboot VMs gracefully but the device also allows to add more
direct communications between host and guest later.

OK mlarkin@

virtio_pci: Always allow MSI/MSI-X

For virtio devices, ignore the black/white-listing depending on the PCI
bridge. This enables MSI-X with qemu's old "82441FX" pci-bridge.

Suggested by kettenis@

Support MSI-X in virtio

This increases performance for interrupt heavy loads.

While suspend/resume support for MSI-X is missing, this is also missing for
virtio. So no new issue there.

Currently, qemu's old "82441FX" pci-bridge is still blacklisted for MSI. But
MSI-X is used if qemu is started with "-M q35".

virtio: Move interrupt handler into transport specific code

For MSI-X (and also possibly for other transports), the interrupt
handler must do different things. Move it out of virtio.c and into
virtio_pci.

ARM part tested by patrick@

virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00: Virtio Network Device
becomes simply
virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00

virtio_pci: Do the ISR read without kernel lock

The ISR read is relatively expensive because it causes a vmexit. Grab the
kernel lock only after it is done.

KNF fixes

No object file changes besides line numbers in KASSERTs

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Consistency with the pci_intr_map bits.

ok sf@

Support MSI for virtio. This is useful for bhyve.

Rename write_queue_address -> setup_queue

For transports supporting several interrupts, this function needs to
setup per-queue interrupts in addition of setting the queue address.

No logic change.

OK jasper@

Move sc_ih to virtio_pci_softc, it is not used outside of virtio_pci
and is really a transport-specific thing.

OK jasper@

Remove excessive sys/cdefs.h inclusion
ok guenther millert kettenis

Add $OpenBSD$ CVS Ids.

ok sf@

make the lines printed during attach more consistent with other drivers

ok mikeb@ sf@

Add new drivers for virtio network (vio) and block devices (vioblk, the disks
attach as scsi disks). These are paravirtualized devices offered by some
hypervisors like kvm and virtualbox.

The virtio transport driver has the pci specific parts separated out. This
will make it easier to add support for mmio (e.g. for ARM) later.

OK mikeb
OK jasper
"commit what you have" deraadt

fix virtio_pci on 32bit archs

bus_space_read/write_8 do not exist there, use two 32bit operations.

Support virtio 1.0 for virtio_pci

virtio 1.0 for virtio_mmio it not yet implemented, but 0.9 devices
continue to work.

Rework virtio_negotiate_features()

Add a sc_driver_features field that is automatically used by
virtio_negotiate_features() and during reinit.

Make virtio_negotiate_features() return an error code. Virtio 1.0 has a
special status bit for feature negotiation that means that negotiation
can fail. Make virtio_negotiate_features() return an error code instead
of the features.

Make virtio_reinit_start() automatically call
virtio_negotiate_features().

Add a convenience function virtio_has_feature() to make checking bits
easier.

Add an error check in viomb for virtio_negotiate_features because it has
some feature bits that may cause negotiation to fail. More error
checking in the child drivers is still missing.

ok mlarkin@

virtio_pci: Move msix vector config into functions

ok mlarkin@

virtio_pci: Split bus space handles

In virtio_pci 1.0, different parts of the register set may be located in
different BARs. Use subregions to make the access independent of the
virtio version.

virtio: Prepare for 64 feature bits

virtio 1.0 supports an arbitrary number of feature bits. However, so far
no more than 64 are used (compared to 32 in virtio 0.9). Adjust data
types to support 64 feature bits.

Later, we may want to use bitmaps and setbit(), ... to support even more
feature bits.

ok mlarkin@

virtio: adjust virtio_setup_queue prototype for 1.0

Make it take an address instead of a PFN.
Pass the virtqueue pointer. In virtio 1.0, more information has to be
configured in the device. Also call virtio_setup_queue() after the
information has been filled in.

ok mlarkin@

virtio: Introduce defines for config(8) flags

Move some PCI-specific defines to a new virtio_pcireg.h file

Also add some virtio 1.0 status and feature bits

Move some common defines to virtiovar.h

And fix some comments

virtio_pci: Support IPL_MPSAFE interrupt handlers

Switch include of virtio header from dev/pci/to dev/pv/

Add vmmci(4) (VMM control interface), a simple guest-side driver for vmm(4) VMs

While we don't have ACPI in vmm(4), we need a simple way to shutdown
and reboot VMs gracefully but the device also allows to add more
direct communications between host and guest later.

OK mlarkin@

virtio_pci: Always allow MSI/MSI-X

For virtio devices, ignore the black/white-listing depending on the PCI
bridge. This enables MSI-X with qemu's old "82441FX" pci-bridge.

Suggested by kettenis@

Support MSI-X in virtio

This increases performance for interrupt heavy loads.

While suspend/resume support for MSI-X is missing, this is also missing for
virtio. So no new issue there.

Currently, qemu's old "82441FX" pci-bridge is still blacklisted for MSI. But
MSI-X is used if qemu is started with "-M q35".

virtio: Move interrupt handler into transport specific code

For MSI-X (and also possibly for other transports), the interrupt
handler must do different things. Move it out of virtio.c and into
virtio_pci.

ARM part tested by patrick@

virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00: Virtio Network Device
becomes simply
virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00

virtio_pci: Do the ISR read without kernel lock

The ISR read is relatively expensive because it causes a vmexit. Grab the
kernel lock only after it is done.

KNF fixes

No object file changes besides line numbers in KASSERTs

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Consistency with the pci_intr_map bits.

ok sf@

Support MSI for virtio. This is useful for bhyve.

Rename write_queue_address -> setup_queue

For transports supporting several interrupts, this function needs to
setup per-queue interrupts in addition of setting the queue address.

No logic change.

OK jasper@

Move sc_ih to virtio_pci_softc, it is not used outside of virtio_pci
and is really a transport-specific thing.

OK jasper@

Remove excessive sys/cdefs.h inclusion
ok guenther millert kettenis

Add $OpenBSD$ CVS Ids.

ok sf@

make the lines printed during attach more consistent with other drivers

ok mikeb@ sf@

Add new drivers for virtio network (vio) and block devices (vioblk, the disks
attach as scsi disks). These are paravirtualized devices offered by some
hypervisors like kvm and virtualbox.

The virtio transport driver has the pci specific parts separated out. This
will make it easier to add support for mmio (e.g. for ARM) later.

OK mikeb
OK jasper
"commit what you have" deraadt

Support virtio 1.0 for virtio_pci

virtio 1.0 for virtio_mmio it not yet implemented, but 0.9 devices
continue to work.

Rework virtio_negotiate_features()

Add a sc_driver_features field that is automatically used by
virtio_negotiate_features() and during reinit.

Make virtio_negotiate_features() return an error code. Virtio 1.0 has a
special status bit for feature negotiation that means that negotiation
can fail. Make virtio_negotiate_features() return an error code instead
of the features.

Make virtio_reinit_start() automatically call
virtio_negotiate_features().

Add a convenience function virtio_has_feature() to make checking bits
easier.

Add an error check in viomb for virtio_negotiate_features because it has
some feature bits that may cause negotiation to fail. More error
checking in the child drivers is still missing.

ok mlarkin@

virtio_pci: Move msix vector config into functions

ok mlarkin@

virtio_pci: Split bus space handles

In virtio_pci 1.0, different parts of the register set may be located in
different BARs. Use subregions to make the access independent of the
virtio version.

virtio: Prepare for 64 feature bits

virtio 1.0 supports an arbitrary number of feature bits. However, so far
no more than 64 are used (compared to 32 in virtio 0.9). Adjust data
types to support 64 feature bits.

Later, we may want to use bitmaps and setbit(), ... to support even more
feature bits.

ok mlarkin@

virtio: adjust virtio_setup_queue prototype for 1.0

Make it take an address instead of a PFN.
Pass the virtqueue pointer. In virtio 1.0, more information has to be
configured in the device. Also call virtio_setup_queue() after the
information has been filled in.

ok mlarkin@

virtio: Introduce defines for config(8) flags

Move some PCI-specific defines to a new virtio_pcireg.h file

Also add some virtio 1.0 status and feature bits

Move some common defines to virtiovar.h

And fix some comments

virtio_pci: Support IPL_MPSAFE interrupt handlers

Switch include of virtio header from dev/pci/to dev/pv/

Add vmmci(4) (VMM control interface), a simple guest-side driver for vmm(4) VMs

While we don't have ACPI in vmm(4), we need a simple way to shutdown
and reboot VMs gracefully but the device also allows to add more
direct communications between host and guest later.

OK mlarkin@

virtio_pci: Always allow MSI/MSI-X

For virtio devices, ignore the black/white-listing depending on the PCI
bridge. This enables MSI-X with qemu's old "82441FX" pci-bridge.

Suggested by kettenis@

Support MSI-X in virtio

This increases performance for interrupt heavy loads.

While suspend/resume support for MSI-X is missing, this is also missing for
virtio. So no new issue there.

Currently, qemu's old "82441FX" pci-bridge is still blacklisted for MSI. But
MSI-X is used if qemu is started with "-M q35".

virtio: Move interrupt handler into transport specific code

For MSI-X (and also possibly for other transports), the interrupt
handler must do different things. Move it out of virtio.c and into
virtio_pci.

ARM part tested by patrick@

virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00: Virtio Network Device
becomes simply
virtio2 at pci0 dev 3 function 0 "Qumranet Virtio Network" rev 0x00

virtio_pci: Do the ISR read without kernel lock

The ISR read is relatively expensive because it causes a vmexit. Grab the
kernel lock only after it is done.