Cast to unsigned integer before overflow can happen.
found by kubsan; joint work with tobhe@; OK miod@

Update ix(4) from freebsd to add support for X553 controllers.

Tested on 82599 (sfp+) and X540 (baseT) by me and Hrvoje Popovski,
and on X553 by sthen@ and abieber@, and possibly more via snapshots
ok sthen@ mikeb@

oops some snapshot tests fell in

sync

Don't overwrite the selected flow control settings

procter@ has noticed that flow control settings survive module change
when they should be forgotten. It became clear that we're overwriting
the selected FC mode with the requested version instead of keeping
negotiated settings. Tested by procter@.

Enable support for the X550 family of 10 Gigabit controllers

Code was obtained from FreeBSD. Make release testing by tb@ on i386
and mikeb@ on amd64 and sparc64. X552 SFP tested by Hrvoje Popovski,
HUGE thanks! X550T tested by mikeb@ on amd64 and sparc64.

ok kettenis, deraadt

Fixup a PCIe transaction completion timeout issue

Mirrors the change 71bde60191a9fa44d33b582c5e3713ffe99b0fef in Linux;
taken as a part of the 280182 commit to FreeBSD.

Correctly set the default value for the FCRTH

X540 datasheet specifies that Flow Control Receive Threshold High
should be set to the Rx Buffer Size minus the delay value which is
different for different modes of operation, however the minimum is
0x6000 (24576).

Mirrors the bc1fc64fd2d9093496e5b04c6d94d26bfa629c9c commit to the
Linux source code, but picked up from the 280182 commit to FreeBSD.

Autoconfiguration and firmware semaphore refactoring

EEPROM code refactoring for X540

Bring in new PHY bits, some of the 82599 specific stuff becomes shared

Style and typo fixes; no binary change

Remove unused bits; no functional change

The onboard ix(4) interfaces on the SPARC T5 machines don't have a valid MAC
address in their EEPROM. Use the MAC address given by the "local-mac-address"
Open Firmware property instead.

ok mikeb@, deraadt@

First stab at updating this monster to the Intel/FreeBSD current version.
This syncs PHY and chip dependent parts as well as brings support for the
flow control and additional (untested) bits for 1G fiber versions.

Tested by Hrvoje Popovski <hrvoje at srce ! hr> on 82599/SFP+DA, florian@
and benno@ on 82599/SFP+SR and on 82598/CX4-BP, 82599/SFP+DA and X540/RJ45
by me.

correctly update the current flow control mode

Fix a link autonegotiation bug on 10GbaseT controllers and improve
link information reporting in general. Obtained for the most part
from FreeBSD, tested by mxb at alumni ! chalmers ! se on X540 and
me on 82598 (XAUI, KR4), 82599 (SFP+) and X540 (baseT); ok jsg

minor cleanup, whitespaces, mostly synced with freebsd

Remove Flow Director code that is not used, is outdated and tends
to get in the way. ok krw, brad

Add support for 10Gb ethernet cards based on the Intel X540 chipset.
The code was obtained from FreeBSD and tested on the hardware kindly
donated by Tony Sarendal <tony () polarcap ! org>. Thanks a lot!

ok jsg

whitespace cleanup, no binary change

Monster update of ix(4). This brings ix(4) close to what is currently
in FreeBSD. This seems to fix a lot of problems on 82599 based cards
including the VLAN problems and the corrupted receives.
Putting this in now to work on it in tree since a few additional things
need to be merged. Tested by myself, deraadt@ and jsg@ on both 98er and
99er cards.
OK jsg@, deraadt@

Partial sync to the latest version of ixgbe in FreeBSD leaving things
like if_ix.c mostly untouched for now. This brings in support for
newer 82598 parts and adds several things that will be needed for 82599.

Initially from claudio with some additions by me.

Tested by claudio, dlg (earlier version) and myself on different cards
and media types.

ok claudio@

In ixgbe_acquire_swfw_sync don't return -IXGBE_ERR_SWFW_SYNC as this
works out to --16, which is nonsense.

No functional change as all callers only check if the return value
is or isn't equal to IXGBE_SUCCESS.

more cleanup, removed unused code. we don't do LRO/RSS yet, code can
be added later if we ever support it.

replace strange Linux-style u8/u16/u32/u64/s32 integer types with the
standard C99 uint*_t/int*_t types (i don't get why these drivers
always use their own types when there is a well-defined standard).

Import ix, a driver for the Intel 82598 PCI-Express 10 Gig Ethernet Adapter,
based on Intel's ixgbe driver.

Done on borrowed hardware since Intel was too poor to give us a card.

ok deraadt@

Update ix(4) from freebsd to add support for X553 controllers.

Tested on 82599 (sfp+) and X540 (baseT) by me and Hrvoje Popovski,
and on X553 by sthen@ and abieber@, and possibly more via snapshots
ok sthen@ mikeb@

oops some snapshot tests fell in

sync

Don't overwrite the selected flow control settings

procter@ has noticed that flow control settings survive module change
when they should be forgotten. It became clear that we're overwriting
the selected FC mode with the requested version instead of keeping
negotiated settings. Tested by procter@.

Enable support for the X550 family of 10 Gigabit controllers

Code was obtained from FreeBSD. Make release testing by tb@ on i386
and mikeb@ on amd64 and sparc64. X552 SFP tested by Hrvoje Popovski,
HUGE thanks! X550T tested by mikeb@ on amd64 and sparc64.

ok kettenis, deraadt

Fixup a PCIe transaction completion timeout issue

Mirrors the change 71bde60191a9fa44d33b582c5e3713ffe99b0fef in Linux;
taken as a part of the 280182 commit to FreeBSD.

Correctly set the default value for the FCRTH

X540 datasheet specifies that Flow Control Receive Threshold High
should be set to the Rx Buffer Size minus the delay value which is
different for different modes of operation, however the minimum is
0x6000 (24576).

Mirrors the bc1fc64fd2d9093496e5b04c6d94d26bfa629c9c commit to the
Linux source code, but picked up from the 280182 commit to FreeBSD.

Autoconfiguration and firmware semaphore refactoring

EEPROM code refactoring for X540

Bring in new PHY bits, some of the 82599 specific stuff becomes shared

Style and typo fixes; no binary change

Remove unused bits; no functional change

The onboard ix(4) interfaces on the SPARC T5 machines don't have a valid MAC
address in their EEPROM. Use the MAC address given by the "local-mac-address"
Open Firmware property instead.

ok mikeb@, deraadt@

First stab at updating this monster to the Intel/FreeBSD current version.
This syncs PHY and chip dependent parts as well as brings support for the
flow control and additional (untested) bits for 1G fiber versions.

Tested by Hrvoje Popovski <hrvoje at srce ! hr> on 82599/SFP+DA, florian@
and benno@ on 82599/SFP+SR and on 82598/CX4-BP, 82599/SFP+DA and X540/RJ45
by me.

correctly update the current flow control mode

Fix a link autonegotiation bug on 10GbaseT controllers and improve
link information reporting in general. Obtained for the most part
from FreeBSD, tested by mxb at alumni ! chalmers ! se on X540 and
me on 82598 (XAUI, KR4), 82599 (SFP+) and X540 (baseT); ok jsg

minor cleanup, whitespaces, mostly synced with freebsd

Remove Flow Director code that is not used, is outdated and tends
to get in the way. ok krw, brad

Add support for 10Gb ethernet cards based on the Intel X540 chipset.
The code was obtained from FreeBSD and tested on the hardware kindly
donated by Tony Sarendal <tony () polarcap ! org>. Thanks a lot!

ok jsg

whitespace cleanup, no binary change

Monster update of ix(4). This brings ix(4) close to what is currently
in FreeBSD. This seems to fix a lot of problems on 82599 based cards
including the VLAN problems and the corrupted receives.
Putting this in now to work on it in tree since a few additional things
need to be merged. Tested by myself, deraadt@ and jsg@ on both 98er and
99er cards.
OK jsg@, deraadt@

Partial sync to the latest version of ixgbe in FreeBSD leaving things
like if_ix.c mostly untouched for now. This brings in support for
newer 82598 parts and adds several things that will be needed for 82599.

Initially from claudio with some additions by me.

Tested by claudio, dlg (earlier version) and myself on different cards
and media types.

ok claudio@

In ixgbe_acquire_swfw_sync don't return -IXGBE_ERR_SWFW_SYNC as this
works out to --16, which is nonsense.

No functional change as all callers only check if the return value
is or isn't equal to IXGBE_SUCCESS.

more cleanup, removed unused code. we don't do LRO/RSS yet, code can
be added later if we ever support it.

replace strange Linux-style u8/u16/u32/u64/s32 integer types with the
standard C99 uint*_t/int*_t types (i don't get why these drivers
always use their own types when there is a well-defined standard).

Import ix, a driver for the Intel 82598 PCI-Express 10 Gig Ethernet Adapter,
based on Intel's ixgbe driver.

Done on borrowed hardware since Intel was too poor to give us a card.

ok deraadt@

oops some snapshot tests fell in

sync

Don't overwrite the selected flow control settings

procter@ has noticed that flow control settings survive module change
when they should be forgotten. It became clear that we're overwriting
the selected FC mode with the requested version instead of keeping
negotiated settings. Tested by procter@.

Enable support for the X550 family of 10 Gigabit controllers

Code was obtained from FreeBSD. Make release testing by tb@ on i386
and mikeb@ on amd64 and sparc64. X552 SFP tested by Hrvoje Popovski,
HUGE thanks! X550T tested by mikeb@ on amd64 and sparc64.

ok kettenis, deraadt

Fixup a PCIe transaction completion timeout issue

Mirrors the change 71bde60191a9fa44d33b582c5e3713ffe99b0fef in Linux;
taken as a part of the 280182 commit to FreeBSD.

Correctly set the default value for the FCRTH

X540 datasheet specifies that Flow Control Receive Threshold High
should be set to the Rx Buffer Size minus the delay value which is
different for different modes of operation, however the minimum is
0x6000 (24576).

Mirrors the bc1fc64fd2d9093496e5b04c6d94d26bfa629c9c commit to the
Linux source code, but picked up from the 280182 commit to FreeBSD.

Autoconfiguration and firmware semaphore refactoring

EEPROM code refactoring for X540

Bring in new PHY bits, some of the 82599 specific stuff becomes shared

Style and typo fixes; no binary change

Remove unused bits; no functional change

The onboard ix(4) interfaces on the SPARC T5 machines don't have a valid MAC
address in their EEPROM. Use the MAC address given by the "local-mac-address"
Open Firmware property instead.

ok mikeb@, deraadt@

First stab at updating this monster to the Intel/FreeBSD current version.
This syncs PHY and chip dependent parts as well as brings support for the
flow control and additional (untested) bits for 1G fiber versions.

Tested by Hrvoje Popovski <hrvoje at srce ! hr> on 82599/SFP+DA, florian@
and benno@ on 82599/SFP+SR and on 82598/CX4-BP, 82599/SFP+DA and X540/RJ45
by me.

correctly update the current flow control mode

Fix a link autonegotiation bug on 10GbaseT controllers and improve
link information reporting in general. Obtained for the most part
from FreeBSD, tested by mxb at alumni ! chalmers ! se on X540 and
me on 82598 (XAUI, KR4), 82599 (SFP+) and X540 (baseT); ok jsg

minor cleanup, whitespaces, mostly synced with freebsd

Remove Flow Director code that is not used, is outdated and tends
to get in the way. ok krw, brad

Add support for 10Gb ethernet cards based on the Intel X540 chipset.
The code was obtained from FreeBSD and tested on the hardware kindly
donated by Tony Sarendal <tony () polarcap ! org>. Thanks a lot!

ok jsg

whitespace cleanup, no binary change

Monster update of ix(4). This brings ix(4) close to what is currently
in FreeBSD. This seems to fix a lot of problems on 82599 based cards
including the VLAN problems and the corrupted receives.
Putting this in now to work on it in tree since a few additional things
need to be merged. Tested by myself, deraadt@ and jsg@ on both 98er and
99er cards.
OK jsg@, deraadt@

Partial sync to the latest version of ixgbe in FreeBSD leaving things
like if_ix.c mostly untouched for now. This brings in support for
newer 82598 parts and adds several things that will be needed for 82599.

Initially from claudio with some additions by me.

Tested by claudio, dlg (earlier version) and myself on different cards
and media types.

ok claudio@

In ixgbe_acquire_swfw_sync don't return -IXGBE_ERR_SWFW_SYNC as this
works out to --16, which is nonsense.

No functional change as all callers only check if the return value
is or isn't equal to IXGBE_SUCCESS.

more cleanup, removed unused code. we don't do LRO/RSS yet, code can
be added later if we ever support it.

replace strange Linux-style u8/u16/u32/u64/s32 integer types with the
standard C99 uint*_t/int*_t types (i don't get why these drivers
always use their own types when there is a well-defined standard).

Import ix, a driver for the Intel 82598 PCI-Express 10 Gig Ethernet Adapter,
based on Intel's ixgbe driver.

Done on borrowed hardware since Intel was too poor to give us a card.

ok deraadt@

Don't overwrite the selected flow control settings

procter@ has noticed that flow control settings survive module change
when they should be forgotten. It became clear that we're overwriting
the selected FC mode with the requested version instead of keeping
negotiated settings. Tested by procter@.

Enable support for the X550 family of 10 Gigabit controllers

Code was obtained from FreeBSD. Make release testing by tb@ on i386
and mikeb@ on amd64 and sparc64. X552 SFP tested by Hrvoje Popovski,
HUGE thanks! X550T tested by mikeb@ on amd64 and sparc64.

ok kettenis, deraadt

Fixup a PCIe transaction completion timeout issue

Mirrors the change 71bde60191a9fa44d33b582c5e3713ffe99b0fef in Linux;
taken as a part of the 280182 commit to FreeBSD.

Correctly set the default value for the FCRTH

X540 datasheet specifies that Flow Control Receive Threshold High
should be set to the Rx Buffer Size minus the delay value which is
different for different modes of operation, however the minimum is
0x6000 (24576).

Mirrors the bc1fc64fd2d9093496e5b04c6d94d26bfa629c9c commit to the
Linux source code, but picked up from the 280182 commit to FreeBSD.

Autoconfiguration and firmware semaphore refactoring

EEPROM code refactoring for X540

Bring in new PHY bits, some of the 82599 specific stuff becomes shared

Style and typo fixes; no binary change

Remove unused bits; no functional change

The onboard ix(4) interfaces on the SPARC T5 machines don't have a valid MAC
address in their EEPROM. Use the MAC address given by the "local-mac-address"
Open Firmware property instead.

ok mikeb@, deraadt@

First stab at updating this monster to the Intel/FreeBSD current version.
This syncs PHY and chip dependent parts as well as brings support for the
flow control and additional (untested) bits for 1G fiber versions.

Tested by Hrvoje Popovski <hrvoje at srce ! hr> on 82599/SFP+DA, florian@
and benno@ on 82599/SFP+SR and on 82598/CX4-BP, 82599/SFP+DA and X540/RJ45
by me.

correctly update the current flow control mode

Fix a link autonegotiation bug on 10GbaseT controllers and improve
link information reporting in general. Obtained for the most part
from FreeBSD, tested by mxb at alumni ! chalmers ! se on X540 and
me on 82598 (XAUI, KR4), 82599 (SFP+) and X540 (baseT); ok jsg

minor cleanup, whitespaces, mostly synced with freebsd

Remove Flow Director code that is not used, is outdated and tends
to get in the way. ok krw, brad

Add support for 10Gb ethernet cards based on the Intel X540 chipset.
The code was obtained from FreeBSD and tested on the hardware kindly
donated by Tony Sarendal <tony () polarcap ! org>. Thanks a lot!

ok jsg

whitespace cleanup, no binary change

Monster update of ix(4). This brings ix(4) close to what is currently
in FreeBSD. This seems to fix a lot of problems on 82599 based cards
including the VLAN problems and the corrupted receives.
Putting this in now to work on it in tree since a few additional things
need to be merged. Tested by myself, deraadt@ and jsg@ on both 98er and
99er cards.
OK jsg@, deraadt@

Partial sync to the latest version of ixgbe in FreeBSD leaving things
like if_ix.c mostly untouched for now. This brings in support for
newer 82598 parts and adds several things that will be needed for 82599.

Initially from claudio with some additions by me.

Tested by claudio, dlg (earlier version) and myself on different cards
and media types.

ok claudio@

In ixgbe_acquire_swfw_sync don't return -IXGBE_ERR_SWFW_SYNC as this
works out to --16, which is nonsense.

No functional change as all callers only check if the return value
is or isn't equal to IXGBE_SUCCESS.

more cleanup, removed unused code. we don't do LRO/RSS yet, code can
be added later if we ever support it.

replace strange Linux-style u8/u16/u32/u64/s32 integer types with the
standard C99 uint*_t/int*_t types (i don't get why these drivers
always use their own types when there is a well-defined standard).

Import ix, a driver for the Intel 82598 PCI-Express 10 Gig Ethernet Adapter,
based on Intel's ixgbe driver.

Done on borrowed hardware since Intel was too poor to give us a card.

ok deraadt@