remove space between function names and argument list

spelling
feedback and ok tb@ jmc@ ok ratchov@

dev/rndvar.h no longer has statistical interfaces (removed during various
conversion steps). it only contains kernel prototypes for 4 interfaces,
all of which legitimately belong in sys/systm.h, which are already included
by all enqueue_randomness() users.

bktr(4): tsleep(9) -> tsleep_nsec(9)

ok deraadt@

Remove useless assignment, value is overwritten right after being set.

Both assignements are in our tree since the driver got imported from
FreeBSD in 2001 and remained untouched since import.

The second assignment in its current form got introduced in FreeBSD in
1997 with r29233 [1], when syncinc the driver. The first assignment got
removed in 2017 with r314147 [2].

[1]: https://svnweb.freebsd.org/base?view=revision&revision=29233
[2]: https://svnweb.freebsd.org/base?view=revision&revision=314147

Coverity CID 1453008.

OK deraadt@

replace add_*_randomness with enqueue_randomness()

this gets rid of the source annotation which doesn't really add
anything other than adding complexitiy. randomess is generally
good enough that the few extra bits that the source type would
add are not worth it.

ok mikeb@ deraadt@

Change a bunch of (<blah> *)0 to NULL.

ok beck@ deraadt@

Convert to uiomove. From Martin Natano.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

First step towards making uiomove() take a size_t size argument:
- rename uiomove() to uiomovei() and update all its users.
- introduce uiomove(), which is similar to uiomovei() but with a size_t.
- rewrite uiomovei() as an uiomove() wrapper.
ok kettenis@

primary change: move uvm_vnode out of vnode, keeping only a pointer.
objective: vnode.h doesn't include uvm_extern.h anymore.
followup changes: include uvm_extern.h or lock.h where necessary.
ok and help from deraadt

format string fixes for bus_addr_t and bus_size_t

bus_addr_t and bus_size_t are u_long everywhere

ok kettenis@

1 << 31 cleanup. Eitan Adler pointed out that there has been a
resurrection of the bad idiom in the tree.
sufficient review by miod, kettenis, tedu

Fix tuner ioctl TVTUNER_SETFREQ after rev 1.30.

Pointed out by Pedro
ok krw@

Use tmp_int to be able to pass back the -1 upon error and check for it properly
but the value passed forward throughout the ioctl handler otherwise is an
unsigned value.

Pointed out by LLVM.

bktr_core.c:1737:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:1779:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:2063:16: error: comparison of unsigned expression < 0 is always false

ok krw@

don't return (potential errno) + (potential errno), instead only perform
the second errno-capable function if the first one didn't fail.
ok deraadt@

Every selwakeup() should have a matching KNOTE() (even if kqueue isn't
supported it doesn't do any harm), so put the KNOTE() in selwakeup() itself and
remove it from any occurences where both are used, except one for kqueue itself
and one in sys_pipe.c (where the selwakeup is under a PIPE_SEL flag).

Based on a diff from tedu.

ok deraadt

Add missing KNOTE() calls after selwakeup(), until we decide if the KNOTE()
calls can go directly into selwakeup() safely
long discussion with nicm, murmers of consent from tedu and miod, noone
else seems to care of kqueue is busted as long as it makes their sockets
move data fast... pretty sad.

typos; ok jmc@
sys/netinet/in_pcb.c and sys/net/bridgestp.c ok henning@
sys/dev/pci/bktr/* ok jakemsr@

replace ctob and btoc with ptoa and atop respectively

help and ok miod@ thib@

Back out the tracking of procs in struct selinfo. There's one serious
bug in the code, but as soon as I try to fix it, it seems to trigger
some other bugs. Instead of trying to figure out what's going on
while everyone suffers, it's better to back out and figure out
the bugs outside the tree.

remove all FreeBSD/NetBSD specific code because we will
never use them and the code is much more readable now

ok jakemsr@

Kill the horrible hack of storing the pid in struct selinfo.

Instead, keep the proc pointer in it and put the selinfo on a list
in struct proc in selrecord. Then clean up the list when leaving
sys_select and sys_poll.

miod@ ok, testing by many, including Bobs spamd boxes.

Remove _KERNEL_OPT leftovers.

Avoid void * arithmetic, okay deraadt@, suggestions from millert@

Include sys/stdint.h instead of defining uintptr_t ourselves.
OK mickey@

Undefine STATUS_SUM, because it is not needed, and it makes
bktr(4) work on alpha.

ok mickey@

Use proper type for 32 bit entity. s/long/int
This is needed for bktr(4) to work on sparc64.

testing and ok by mickey and Jacob Meuser <jakemsr@jakemsr.com>

apparently i got the last one reversed; from jakemsr@

no need for BKTR_NO_OPEN_RESET option now that all tuners sw has been fixed; from jakemsr@

do not reset tuner and audio settings on open/close; from jakemsr@

do not use u_long for 32bit data; found by Jacob Meuser

cummulative update from freebsd an netbsd:
PCI_VENROD_PINNACLE -> PCI_VENDOR_PINNACLE_ALT;
correct brightness ioctl; missing htole32s;
fix "set chroma comb" command in yuv422_prog();
use defines instead of magic numbers; fix statics and comments.
from jakemsr@jakemsr.com

a missing htole32 and a pasto; from netbsd

be consistant on Hz vs hz

fix cut and paste piece in dma programming, caused jumpieness in animation; good diagnose by Kamil Andrusz <wizz@mniam.net>

Get rid of vm_offset_t in bktr.

proper endianess handling in 16 and 32 bit video modes, 24 bit is not supported by the card

endianess-free, works on macppc now, except for the fb endianess

constify a few structs

Final __P removal plus some cosmetic fixups

branches: 1.3.2;
Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

supply some entropy from here

branches: 1.1.4;
Latest bktr driver from FreeBSD; thanks to Andres Gunnarsson
<andreas@crt.se> for testing.

spelling
feedback and ok tb@ jmc@ ok ratchov@

dev/rndvar.h no longer has statistical interfaces (removed during various
conversion steps). it only contains kernel prototypes for 4 interfaces,
all of which legitimately belong in sys/systm.h, which are already included
by all enqueue_randomness() users.

bktr(4): tsleep(9) -> tsleep_nsec(9)

ok deraadt@

Remove useless assignment, value is overwritten right after being set.

Both assignements are in our tree since the driver got imported from
FreeBSD in 2001 and remained untouched since import.

The second assignment in its current form got introduced in FreeBSD in
1997 with r29233 [1], when syncinc the driver. The first assignment got
removed in 2017 with r314147 [2].

[1]: https://svnweb.freebsd.org/base?view=revision&revision=29233
[2]: https://svnweb.freebsd.org/base?view=revision&revision=314147

Coverity CID 1453008.

OK deraadt@

replace add_*_randomness with enqueue_randomness()

this gets rid of the source annotation which doesn't really add
anything other than adding complexitiy. randomess is generally
good enough that the few extra bits that the source type would
add are not worth it.

ok mikeb@ deraadt@

Change a bunch of (<blah> *)0 to NULL.

ok beck@ deraadt@

Convert to uiomove. From Martin Natano.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

First step towards making uiomove() take a size_t size argument:
- rename uiomove() to uiomovei() and update all its users.
- introduce uiomove(), which is similar to uiomovei() but with a size_t.
- rewrite uiomovei() as an uiomove() wrapper.
ok kettenis@

primary change: move uvm_vnode out of vnode, keeping only a pointer.
objective: vnode.h doesn't include uvm_extern.h anymore.
followup changes: include uvm_extern.h or lock.h where necessary.
ok and help from deraadt

format string fixes for bus_addr_t and bus_size_t

bus_addr_t and bus_size_t are u_long everywhere

ok kettenis@

1 << 31 cleanup. Eitan Adler pointed out that there has been a
resurrection of the bad idiom in the tree.
sufficient review by miod, kettenis, tedu

Fix tuner ioctl TVTUNER_SETFREQ after rev 1.30.

Pointed out by Pedro
ok krw@

Use tmp_int to be able to pass back the -1 upon error and check for it properly
but the value passed forward throughout the ioctl handler otherwise is an
unsigned value.

Pointed out by LLVM.

bktr_core.c:1737:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:1779:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:2063:16: error: comparison of unsigned expression < 0 is always false

ok krw@

don't return (potential errno) + (potential errno), instead only perform
the second errno-capable function if the first one didn't fail.
ok deraadt@

Every selwakeup() should have a matching KNOTE() (even if kqueue isn't
supported it doesn't do any harm), so put the KNOTE() in selwakeup() itself and
remove it from any occurences where both are used, except one for kqueue itself
and one in sys_pipe.c (where the selwakeup is under a PIPE_SEL flag).

Based on a diff from tedu.

ok deraadt

Add missing KNOTE() calls after selwakeup(), until we decide if the KNOTE()
calls can go directly into selwakeup() safely
long discussion with nicm, murmers of consent from tedu and miod, noone
else seems to care of kqueue is busted as long as it makes their sockets
move data fast... pretty sad.

typos; ok jmc@
sys/netinet/in_pcb.c and sys/net/bridgestp.c ok henning@
sys/dev/pci/bktr/* ok jakemsr@

replace ctob and btoc with ptoa and atop respectively

help and ok miod@ thib@

Back out the tracking of procs in struct selinfo. There's one serious
bug in the code, but as soon as I try to fix it, it seems to trigger
some other bugs. Instead of trying to figure out what's going on
while everyone suffers, it's better to back out and figure out
the bugs outside the tree.

remove all FreeBSD/NetBSD specific code because we will
never use them and the code is much more readable now

ok jakemsr@

Kill the horrible hack of storing the pid in struct selinfo.

Instead, keep the proc pointer in it and put the selinfo on a list
in struct proc in selrecord. Then clean up the list when leaving
sys_select and sys_poll.

miod@ ok, testing by many, including Bobs spamd boxes.

Remove _KERNEL_OPT leftovers.

Avoid void * arithmetic, okay deraadt@, suggestions from millert@

Include sys/stdint.h instead of defining uintptr_t ourselves.
OK mickey@

Undefine STATUS_SUM, because it is not needed, and it makes
bktr(4) work on alpha.

ok mickey@

Use proper type for 32 bit entity. s/long/int
This is needed for bktr(4) to work on sparc64.

testing and ok by mickey and Jacob Meuser <jakemsr@jakemsr.com>

apparently i got the last one reversed; from jakemsr@

no need for BKTR_NO_OPEN_RESET option now that all tuners sw has been fixed; from jakemsr@

do not reset tuner and audio settings on open/close; from jakemsr@

do not use u_long for 32bit data; found by Jacob Meuser

cummulative update from freebsd an netbsd:
PCI_VENROD_PINNACLE -> PCI_VENDOR_PINNACLE_ALT;
correct brightness ioctl; missing htole32s;
fix "set chroma comb" command in yuv422_prog();
use defines instead of magic numbers; fix statics and comments.
from jakemsr@jakemsr.com

a missing htole32 and a pasto; from netbsd

be consistant on Hz vs hz

fix cut and paste piece in dma programming, caused jumpieness in animation; good diagnose by Kamil Andrusz <wizz@mniam.net>

Get rid of vm_offset_t in bktr.

proper endianess handling in 16 and 32 bit video modes, 24 bit is not supported by the card

endianess-free, works on macppc now, except for the fb endianess

constify a few structs

Final __P removal plus some cosmetic fixups

branches: 1.3.2;
Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

supply some entropy from here

branches: 1.1.4;
Latest bktr driver from FreeBSD; thanks to Andres Gunnarsson
<andreas@crt.se> for testing.

dev/rndvar.h no longer has statistical interfaces (removed during various
conversion steps). it only contains kernel prototypes for 4 interfaces,
all of which legitimately belong in sys/systm.h, which are already included
by all enqueue_randomness() users.

bktr(4): tsleep(9) -> tsleep_nsec(9)

ok deraadt@

Remove useless assignment, value is overwritten right after being set.

Both assignements are in our tree since the driver got imported from
FreeBSD in 2001 and remained untouched since import.

The second assignment in its current form got introduced in FreeBSD in
1997 with r29233 [1], when syncinc the driver. The first assignment got
removed in 2017 with r314147 [2].

[1]: https://svnweb.freebsd.org/base?view=revision&revision=29233
[2]: https://svnweb.freebsd.org/base?view=revision&revision=314147

Coverity CID 1453008.

OK deraadt@

replace add_*_randomness with enqueue_randomness()

this gets rid of the source annotation which doesn't really add
anything other than adding complexitiy. randomess is generally
good enough that the few extra bits that the source type would
add are not worth it.

ok mikeb@ deraadt@

Change a bunch of (<blah> *)0 to NULL.

ok beck@ deraadt@

Convert to uiomove. From Martin Natano.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

First step towards making uiomove() take a size_t size argument:
- rename uiomove() to uiomovei() and update all its users.
- introduce uiomove(), which is similar to uiomovei() but with a size_t.
- rewrite uiomovei() as an uiomove() wrapper.
ok kettenis@

primary change: move uvm_vnode out of vnode, keeping only a pointer.
objective: vnode.h doesn't include uvm_extern.h anymore.
followup changes: include uvm_extern.h or lock.h where necessary.
ok and help from deraadt

format string fixes for bus_addr_t and bus_size_t

bus_addr_t and bus_size_t are u_long everywhere

ok kettenis@

1 << 31 cleanup. Eitan Adler pointed out that there has been a
resurrection of the bad idiom in the tree.
sufficient review by miod, kettenis, tedu

Fix tuner ioctl TVTUNER_SETFREQ after rev 1.30.

Pointed out by Pedro
ok krw@

Use tmp_int to be able to pass back the -1 upon error and check for it properly
but the value passed forward throughout the ioctl handler otherwise is an
unsigned value.

Pointed out by LLVM.

bktr_core.c:1737:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:1779:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:2063:16: error: comparison of unsigned expression < 0 is always false

ok krw@

don't return (potential errno) + (potential errno), instead only perform
the second errno-capable function if the first one didn't fail.
ok deraadt@

Every selwakeup() should have a matching KNOTE() (even if kqueue isn't
supported it doesn't do any harm), so put the KNOTE() in selwakeup() itself and
remove it from any occurences where both are used, except one for kqueue itself
and one in sys_pipe.c (where the selwakeup is under a PIPE_SEL flag).

Based on a diff from tedu.

ok deraadt

Add missing KNOTE() calls after selwakeup(), until we decide if the KNOTE()
calls can go directly into selwakeup() safely
long discussion with nicm, murmers of consent from tedu and miod, noone
else seems to care of kqueue is busted as long as it makes their sockets
move data fast... pretty sad.

typos; ok jmc@
sys/netinet/in_pcb.c and sys/net/bridgestp.c ok henning@
sys/dev/pci/bktr/* ok jakemsr@

replace ctob and btoc with ptoa and atop respectively

help and ok miod@ thib@

Back out the tracking of procs in struct selinfo. There's one serious
bug in the code, but as soon as I try to fix it, it seems to trigger
some other bugs. Instead of trying to figure out what's going on
while everyone suffers, it's better to back out and figure out
the bugs outside the tree.

remove all FreeBSD/NetBSD specific code because we will
never use them and the code is much more readable now

ok jakemsr@

Kill the horrible hack of storing the pid in struct selinfo.

Instead, keep the proc pointer in it and put the selinfo on a list
in struct proc in selrecord. Then clean up the list when leaving
sys_select and sys_poll.

miod@ ok, testing by many, including Bobs spamd boxes.

Remove _KERNEL_OPT leftovers.

Avoid void * arithmetic, okay deraadt@, suggestions from millert@

Include sys/stdint.h instead of defining uintptr_t ourselves.
OK mickey@

Undefine STATUS_SUM, because it is not needed, and it makes
bktr(4) work on alpha.

ok mickey@

Use proper type for 32 bit entity. s/long/int
This is needed for bktr(4) to work on sparc64.

testing and ok by mickey and Jacob Meuser <jakemsr@jakemsr.com>

apparently i got the last one reversed; from jakemsr@

no need for BKTR_NO_OPEN_RESET option now that all tuners sw has been fixed; from jakemsr@

do not reset tuner and audio settings on open/close; from jakemsr@

do not use u_long for 32bit data; found by Jacob Meuser

cummulative update from freebsd an netbsd:
PCI_VENROD_PINNACLE -> PCI_VENDOR_PINNACLE_ALT;
correct brightness ioctl; missing htole32s;
fix "set chroma comb" command in yuv422_prog();
use defines instead of magic numbers; fix statics and comments.
from jakemsr@jakemsr.com

a missing htole32 and a pasto; from netbsd

be consistant on Hz vs hz

fix cut and paste piece in dma programming, caused jumpieness in animation; good diagnose by Kamil Andrusz <wizz@mniam.net>

Get rid of vm_offset_t in bktr.

proper endianess handling in 16 and 32 bit video modes, 24 bit is not supported by the card

endianess-free, works on macppc now, except for the fb endianess

constify a few structs

Final __P removal plus some cosmetic fixups

branches: 1.3.2;
Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

supply some entropy from here

branches: 1.1.4;
Latest bktr driver from FreeBSD; thanks to Andres Gunnarsson
<andreas@crt.se> for testing.

bktr(4): tsleep(9) -> tsleep_nsec(9)

ok deraadt@

Remove useless assignment, value is overwritten right after being set.

Both assignements are in our tree since the driver got imported from
FreeBSD in 2001 and remained untouched since import.

The second assignment in its current form got introduced in FreeBSD in
1997 with r29233 [1], when syncinc the driver. The first assignment got
removed in 2017 with r314147 [2].

[1]: https://svnweb.freebsd.org/base?view=revision&revision=29233
[2]: https://svnweb.freebsd.org/base?view=revision&revision=314147

Coverity CID 1453008.

OK deraadt@

replace add_*_randomness with enqueue_randomness()

this gets rid of the source annotation which doesn't really add
anything other than adding complexitiy. randomess is generally
good enough that the few extra bits that the source type would
add are not worth it.

ok mikeb@ deraadt@

Change a bunch of (<blah> *)0 to NULL.

ok beck@ deraadt@

Convert to uiomove. From Martin Natano.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

First step towards making uiomove() take a size_t size argument:
- rename uiomove() to uiomovei() and update all its users.
- introduce uiomove(), which is similar to uiomovei() but with a size_t.
- rewrite uiomovei() as an uiomove() wrapper.
ok kettenis@

primary change: move uvm_vnode out of vnode, keeping only a pointer.
objective: vnode.h doesn't include uvm_extern.h anymore.
followup changes: include uvm_extern.h or lock.h where necessary.
ok and help from deraadt

format string fixes for bus_addr_t and bus_size_t

bus_addr_t and bus_size_t are u_long everywhere

ok kettenis@

1 << 31 cleanup. Eitan Adler pointed out that there has been a
resurrection of the bad idiom in the tree.
sufficient review by miod, kettenis, tedu

Fix tuner ioctl TVTUNER_SETFREQ after rev 1.30.

Pointed out by Pedro
ok krw@

Use tmp_int to be able to pass back the -1 upon error and check for it properly
but the value passed forward throughout the ioctl handler otherwise is an
unsigned value.

Pointed out by LLVM.

bktr_core.c:1737:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:1779:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:2063:16: error: comparison of unsigned expression < 0 is always false

ok krw@

don't return (potential errno) + (potential errno), instead only perform
the second errno-capable function if the first one didn't fail.
ok deraadt@

Every selwakeup() should have a matching KNOTE() (even if kqueue isn't
supported it doesn't do any harm), so put the KNOTE() in selwakeup() itself and
remove it from any occurences where both are used, except one for kqueue itself
and one in sys_pipe.c (where the selwakeup is under a PIPE_SEL flag).

Based on a diff from tedu.

ok deraadt

Add missing KNOTE() calls after selwakeup(), until we decide if the KNOTE()
calls can go directly into selwakeup() safely
long discussion with nicm, murmers of consent from tedu and miod, noone
else seems to care of kqueue is busted as long as it makes their sockets
move data fast... pretty sad.

typos; ok jmc@
sys/netinet/in_pcb.c and sys/net/bridgestp.c ok henning@
sys/dev/pci/bktr/* ok jakemsr@

replace ctob and btoc with ptoa and atop respectively

help and ok miod@ thib@

Back out the tracking of procs in struct selinfo. There's one serious
bug in the code, but as soon as I try to fix it, it seems to trigger
some other bugs. Instead of trying to figure out what's going on
while everyone suffers, it's better to back out and figure out
the bugs outside the tree.

remove all FreeBSD/NetBSD specific code because we will
never use them and the code is much more readable now

ok jakemsr@

Kill the horrible hack of storing the pid in struct selinfo.

Instead, keep the proc pointer in it and put the selinfo on a list
in struct proc in selrecord. Then clean up the list when leaving
sys_select and sys_poll.

miod@ ok, testing by many, including Bobs spamd boxes.

Remove _KERNEL_OPT leftovers.

Avoid void * arithmetic, okay deraadt@, suggestions from millert@

Include sys/stdint.h instead of defining uintptr_t ourselves.
OK mickey@

Undefine STATUS_SUM, because it is not needed, and it makes
bktr(4) work on alpha.

ok mickey@

Use proper type for 32 bit entity. s/long/int
This is needed for bktr(4) to work on sparc64.

testing and ok by mickey and Jacob Meuser <jakemsr@jakemsr.com>

apparently i got the last one reversed; from jakemsr@

no need for BKTR_NO_OPEN_RESET option now that all tuners sw has been fixed; from jakemsr@

do not reset tuner and audio settings on open/close; from jakemsr@

do not use u_long for 32bit data; found by Jacob Meuser

cummulative update from freebsd an netbsd:
PCI_VENROD_PINNACLE -> PCI_VENDOR_PINNACLE_ALT;
correct brightness ioctl; missing htole32s;
fix "set chroma comb" command in yuv422_prog();
use defines instead of magic numbers; fix statics and comments.
from jakemsr@jakemsr.com

a missing htole32 and a pasto; from netbsd

be consistant on Hz vs hz

fix cut and paste piece in dma programming, caused jumpieness in animation; good diagnose by Kamil Andrusz <wizz@mniam.net>

Get rid of vm_offset_t in bktr.

proper endianess handling in 16 and 32 bit video modes, 24 bit is not supported by the card

endianess-free, works on macppc now, except for the fb endianess

constify a few structs

Final __P removal plus some cosmetic fixups

branches: 1.3.2;
Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

supply some entropy from here

branches: 1.1.4;
Latest bktr driver from FreeBSD; thanks to Andres Gunnarsson
<andreas@crt.se> for testing.

Remove useless assignment, value is overwritten right after being set.

Both assignements are in our tree since the driver got imported from
FreeBSD in 2001 and remained untouched since import.

The second assignment in its current form got introduced in FreeBSD in
1997 with r29233 [1], when syncinc the driver. The first assignment got
removed in 2017 with r314147 [2].

[1]: https://svnweb.freebsd.org/base?view=revision&revision=29233
[2]: https://svnweb.freebsd.org/base?view=revision&revision=314147

Coverity CID 1453008.

OK deraadt@

replace add_*_randomness with enqueue_randomness()

this gets rid of the source annotation which doesn't really add
anything other than adding complexitiy. randomess is generally
good enough that the few extra bits that the source type would
add are not worth it.

ok mikeb@ deraadt@

Change a bunch of (<blah> *)0 to NULL.

ok beck@ deraadt@

Convert to uiomove. From Martin Natano.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

First step towards making uiomove() take a size_t size argument:
- rename uiomove() to uiomovei() and update all its users.
- introduce uiomove(), which is similar to uiomovei() but with a size_t.
- rewrite uiomovei() as an uiomove() wrapper.
ok kettenis@

primary change: move uvm_vnode out of vnode, keeping only a pointer.
objective: vnode.h doesn't include uvm_extern.h anymore.
followup changes: include uvm_extern.h or lock.h where necessary.
ok and help from deraadt

format string fixes for bus_addr_t and bus_size_t

bus_addr_t and bus_size_t are u_long everywhere

ok kettenis@

1 << 31 cleanup. Eitan Adler pointed out that there has been a
resurrection of the bad idiom in the tree.
sufficient review by miod, kettenis, tedu

Fix tuner ioctl TVTUNER_SETFREQ after rev 1.30.

Pointed out by Pedro
ok krw@

Use tmp_int to be able to pass back the -1 upon error and check for it properly
but the value passed forward throughout the ioctl handler otherwise is an
unsigned value.

Pointed out by LLVM.

bktr_core.c:1737:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:1779:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:2063:16: error: comparison of unsigned expression < 0 is always false

ok krw@

don't return (potential errno) + (potential errno), instead only perform
the second errno-capable function if the first one didn't fail.
ok deraadt@

Every selwakeup() should have a matching KNOTE() (even if kqueue isn't
supported it doesn't do any harm), so put the KNOTE() in selwakeup() itself and
remove it from any occurences where both are used, except one for kqueue itself
and one in sys_pipe.c (where the selwakeup is under a PIPE_SEL flag).

Based on a diff from tedu.

ok deraadt

Add missing KNOTE() calls after selwakeup(), until we decide if the KNOTE()
calls can go directly into selwakeup() safely
long discussion with nicm, murmers of consent from tedu and miod, noone
else seems to care of kqueue is busted as long as it makes their sockets
move data fast... pretty sad.

typos; ok jmc@
sys/netinet/in_pcb.c and sys/net/bridgestp.c ok henning@
sys/dev/pci/bktr/* ok jakemsr@

replace ctob and btoc with ptoa and atop respectively

help and ok miod@ thib@

Back out the tracking of procs in struct selinfo. There's one serious
bug in the code, but as soon as I try to fix it, it seems to trigger
some other bugs. Instead of trying to figure out what's going on
while everyone suffers, it's better to back out and figure out
the bugs outside the tree.

remove all FreeBSD/NetBSD specific code because we will
never use them and the code is much more readable now

ok jakemsr@

Kill the horrible hack of storing the pid in struct selinfo.

Instead, keep the proc pointer in it and put the selinfo on a list
in struct proc in selrecord. Then clean up the list when leaving
sys_select and sys_poll.

miod@ ok, testing by many, including Bobs spamd boxes.

Remove _KERNEL_OPT leftovers.

Avoid void * arithmetic, okay deraadt@, suggestions from millert@

Include sys/stdint.h instead of defining uintptr_t ourselves.
OK mickey@

Undefine STATUS_SUM, because it is not needed, and it makes
bktr(4) work on alpha.

ok mickey@

Use proper type for 32 bit entity. s/long/int
This is needed for bktr(4) to work on sparc64.

testing and ok by mickey and Jacob Meuser <jakemsr@jakemsr.com>

apparently i got the last one reversed; from jakemsr@

no need for BKTR_NO_OPEN_RESET option now that all tuners sw has been fixed; from jakemsr@

do not reset tuner and audio settings on open/close; from jakemsr@

do not use u_long for 32bit data; found by Jacob Meuser

cummulative update from freebsd an netbsd:
PCI_VENROD_PINNACLE -> PCI_VENDOR_PINNACLE_ALT;
correct brightness ioctl; missing htole32s;
fix "set chroma comb" command in yuv422_prog();
use defines instead of magic numbers; fix statics and comments.
from jakemsr@jakemsr.com

a missing htole32 and a pasto; from netbsd

be consistant on Hz vs hz

fix cut and paste piece in dma programming, caused jumpieness in animation; good diagnose by Kamil Andrusz <wizz@mniam.net>

Get rid of vm_offset_t in bktr.

proper endianess handling in 16 and 32 bit video modes, 24 bit is not supported by the card

endianess-free, works on macppc now, except for the fb endianess

constify a few structs

Final __P removal plus some cosmetic fixups

branches: 1.3.2;
Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

supply some entropy from here

branches: 1.1.4;
Latest bktr driver from FreeBSD; thanks to Andres Gunnarsson
<andreas@crt.se> for testing.

replace add_*_randomness with enqueue_randomness()

this gets rid of the source annotation which doesn't really add
anything other than adding complexitiy. randomess is generally
good enough that the few extra bits that the source type would
add are not worth it.

ok mikeb@ deraadt@

Change a bunch of (<blah> *)0 to NULL.

ok beck@ deraadt@

Convert to uiomove. From Martin Natano.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

First step towards making uiomove() take a size_t size argument:
- rename uiomove() to uiomovei() and update all its users.
- introduce uiomove(), which is similar to uiomovei() but with a size_t.
- rewrite uiomovei() as an uiomove() wrapper.
ok kettenis@

primary change: move uvm_vnode out of vnode, keeping only a pointer.
objective: vnode.h doesn't include uvm_extern.h anymore.
followup changes: include uvm_extern.h or lock.h where necessary.
ok and help from deraadt

format string fixes for bus_addr_t and bus_size_t

bus_addr_t and bus_size_t are u_long everywhere

ok kettenis@

1 << 31 cleanup. Eitan Adler pointed out that there has been a
resurrection of the bad idiom in the tree.
sufficient review by miod, kettenis, tedu

Fix tuner ioctl TVTUNER_SETFREQ after rev 1.30.

Pointed out by Pedro
ok krw@

Use tmp_int to be able to pass back the -1 upon error and check for it properly
but the value passed forward throughout the ioctl handler otherwise is an
unsigned value.

Pointed out by LLVM.

bktr_core.c:1737:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:1779:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:2063:16: error: comparison of unsigned expression < 0 is always false

ok krw@

don't return (potential errno) + (potential errno), instead only perform
the second errno-capable function if the first one didn't fail.
ok deraadt@

Every selwakeup() should have a matching KNOTE() (even if kqueue isn't
supported it doesn't do any harm), so put the KNOTE() in selwakeup() itself and
remove it from any occurences where both are used, except one for kqueue itself
and one in sys_pipe.c (where the selwakeup is under a PIPE_SEL flag).

Based on a diff from tedu.

ok deraadt

Add missing KNOTE() calls after selwakeup(), until we decide if the KNOTE()
calls can go directly into selwakeup() safely
long discussion with nicm, murmers of consent from tedu and miod, noone
else seems to care of kqueue is busted as long as it makes their sockets
move data fast... pretty sad.

typos; ok jmc@
sys/netinet/in_pcb.c and sys/net/bridgestp.c ok henning@
sys/dev/pci/bktr/* ok jakemsr@

replace ctob and btoc with ptoa and atop respectively

help and ok miod@ thib@

Back out the tracking of procs in struct selinfo. There's one serious
bug in the code, but as soon as I try to fix it, it seems to trigger
some other bugs. Instead of trying to figure out what's going on
while everyone suffers, it's better to back out and figure out
the bugs outside the tree.

remove all FreeBSD/NetBSD specific code because we will
never use them and the code is much more readable now

ok jakemsr@

Kill the horrible hack of storing the pid in struct selinfo.

Instead, keep the proc pointer in it and put the selinfo on a list
in struct proc in selrecord. Then clean up the list when leaving
sys_select and sys_poll.

miod@ ok, testing by many, including Bobs spamd boxes.

Remove _KERNEL_OPT leftovers.

Avoid void * arithmetic, okay deraadt@, suggestions from millert@

Include sys/stdint.h instead of defining uintptr_t ourselves.
OK mickey@

Undefine STATUS_SUM, because it is not needed, and it makes
bktr(4) work on alpha.

ok mickey@

Use proper type for 32 bit entity. s/long/int
This is needed for bktr(4) to work on sparc64.

testing and ok by mickey and Jacob Meuser <jakemsr@jakemsr.com>

apparently i got the last one reversed; from jakemsr@

no need for BKTR_NO_OPEN_RESET option now that all tuners sw has been fixed; from jakemsr@

do not reset tuner and audio settings on open/close; from jakemsr@

do not use u_long for 32bit data; found by Jacob Meuser

cummulative update from freebsd an netbsd:
PCI_VENROD_PINNACLE -> PCI_VENDOR_PINNACLE_ALT;
correct brightness ioctl; missing htole32s;
fix "set chroma comb" command in yuv422_prog();
use defines instead of magic numbers; fix statics and comments.
from jakemsr@jakemsr.com

a missing htole32 and a pasto; from netbsd

be consistant on Hz vs hz

fix cut and paste piece in dma programming, caused jumpieness in animation; good diagnose by Kamil Andrusz <wizz@mniam.net>

Get rid of vm_offset_t in bktr.

proper endianess handling in 16 and 32 bit video modes, 24 bit is not supported by the card

endianess-free, works on macppc now, except for the fb endianess

constify a few structs

Final __P removal plus some cosmetic fixups

branches: 1.3.2;
Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

supply some entropy from here

branches: 1.1.4;
Latest bktr driver from FreeBSD; thanks to Andres Gunnarsson
<andreas@crt.se> for testing.

Change a bunch of (<blah> *)0 to NULL.

ok beck@ deraadt@

Convert to uiomove. From Martin Natano.

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

First step towards making uiomove() take a size_t size argument:
- rename uiomove() to uiomovei() and update all its users.
- introduce uiomove(), which is similar to uiomovei() but with a size_t.
- rewrite uiomovei() as an uiomove() wrapper.
ok kettenis@

primary change: move uvm_vnode out of vnode, keeping only a pointer.
objective: vnode.h doesn't include uvm_extern.h anymore.
followup changes: include uvm_extern.h or lock.h where necessary.
ok and help from deraadt

format string fixes for bus_addr_t and bus_size_t

bus_addr_t and bus_size_t are u_long everywhere

ok kettenis@

1 << 31 cleanup. Eitan Adler pointed out that there has been a
resurrection of the bad idiom in the tree.
sufficient review by miod, kettenis, tedu

Fix tuner ioctl TVTUNER_SETFREQ after rev 1.30.

Pointed out by Pedro
ok krw@

Use tmp_int to be able to pass back the -1 upon error and check for it properly
but the value passed forward throughout the ioctl handler otherwise is an
unsigned value.

Pointed out by LLVM.

bktr_core.c:1737:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:1779:13: error: comparison of unsigned expression < 0 is always false
bktr_core.c:2063:16: error: comparison of unsigned expression < 0 is always false

ok krw@

don't return (potential errno) + (potential errno), instead only perform
the second errno-capable function if the first one didn't fail.
ok deraadt@

Every selwakeup() should have a matching KNOTE() (even if kqueue isn't
supported it doesn't do any harm), so put the KNOTE() in selwakeup() itself and
remove it from any occurences where both are used, except one for kqueue itself
and one in sys_pipe.c (where the selwakeup is under a PIPE_SEL flag).

Based on a diff from tedu.

ok deraadt

Add missing KNOTE() calls after selwakeup(), until we decide if the KNOTE()
calls can go directly into selwakeup() safely
long discussion with nicm, murmers of consent from tedu and miod, noone
else seems to care of kqueue is busted as long as it makes their sockets
move data fast... pretty sad.

typos; ok jmc@
sys/netinet/in_pcb.c and sys/net/bridgestp.c ok henning@
sys/dev/pci/bktr/* ok jakemsr@

replace ctob and btoc with ptoa and atop respectively

help and ok miod@ thib@

Back out the tracking of procs in struct selinfo. There's one serious
bug in the code, but as soon as I try to fix it, it seems to trigger
some other bugs. Instead of trying to figure out what's going on
while everyone suffers, it's better to back out and figure out
the bugs outside the tree.

remove all FreeBSD/NetBSD specific code because we will
never use them and the code is much more readable now

ok jakemsr@

Kill the horrible hack of storing the pid in struct selinfo.

Instead, keep the proc pointer in it and put the selinfo on a list
in struct proc in selrecord. Then clean up the list when leaving
sys_select and sys_poll.

miod@ ok, testing by many, including Bobs spamd boxes.

Remove _KERNEL_OPT leftovers.

Avoid void * arithmetic, okay deraadt@, suggestions from millert@

Include sys/stdint.h instead of defining uintptr_t ourselves.
OK mickey@

Undefine STATUS_SUM, because it is not needed, and it makes
bktr(4) work on alpha.

ok mickey@

Use proper type for 32 bit entity. s/long/int
This is needed for bktr(4) to work on sparc64.

testing and ok by mickey and Jacob Meuser <jakemsr@jakemsr.com>

apparently i got the last one reversed; from jakemsr@

no need for BKTR_NO_OPEN_RESET option now that all tuners sw has been fixed; from jakemsr@

do not reset tuner and audio settings on open/close; from jakemsr@

do not use u_long for 32bit data; found by Jacob Meuser

cummulative update from freebsd an netbsd:
PCI_VENROD_PINNACLE -> PCI_VENDOR_PINNACLE_ALT;
correct brightness ioctl; missing htole32s;
fix "set chroma comb" command in yuv422_prog();
use defines instead of magic numbers; fix statics and comments.
from jakemsr@jakemsr.com

a missing htole32 and a pasto; from netbsd

be consistant on Hz vs hz

fix cut and paste piece in dma programming, caused jumpieness in animation; good diagnose by Kamil Andrusz <wizz@mniam.net>

Get rid of vm_offset_t in bktr.

proper endianess handling in 16 and 32 bit video modes, 24 bit is not supported by the card

endianess-free, works on macppc now, except for the fb endianess

constify a few structs

Final __P removal plus some cosmetic fixups

branches: 1.3.2;
Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

supply some entropy from here

branches: 1.1.4;
Latest bktr driver from FreeBSD; thanks to Andres Gunnarsson
<andreas@crt.se> for testing.