Disallow setting the voltage of coupled regulators for now. Some RK3588
boards use different regulators for CPU core voltage and memory interface
voltage. But the two have to be kept synchronized. So the devicetree for
these boards marks these regulators as coupled. We have no support for
coupled regulators yet and letting the DVFS code set just the CPU core
voltage would probably lead to strange crashes.

ok mlarkin@

fixed regulators might rely on other regulators specified by "vin-supply"

when turning a fixed regulator on, turn on the regulator specified
in vin-supply too.

kettenis agrees we should do this.

fixed regulators could have a "gpios" or "gpio" property.

we only handled "gpio" before. figuring this out has wasted many
days of my life recently.

ok patrick@ kettenis@

Implement regulator notifiers which get called when the voltage/current
for a regulator is changed or when the regulator gets initialized when it
attaches for the first time. The latter makes it possible to register
a notifier for a regulator that hasn't attached yet.

ok dlg@

OF_getproplen() returns -1 on error, so don't store result in size_t
spotted by and ok tb@, ok tobhe@

Fix regulators that use "active-low" polarity. Our implementation now
ignores the presence "enable-active-high" property and relies on the
encode polarity of the GPIO in the flags in the device tree instead.
This might not be the case for older device trees; such device trees
should be fixed.

ok patrick@

Some devices have no phandle since they are not referenced in the
device tree, but they are still registered in our OFW framework.
These then tend to have a phandle 0. If we are trying to lookup
a device by phandle, we should explicitly check for phandle 0 and
bail, since otherwise it is possible that we falsely match that
phandle and return a device.

ok kettenis@

We are allowed to enable regulators with the "regulator-always-on"
property. The definition is that a regulator with this property
should never be disabled.

ok kettenis@

Add support for current limit regulators in addition to the voltage
regulators we already support. The GPIO-based regulators are rather
independent of the type, we only need to know the type to check the
upper and lower limits.

With feedback from kettenis@

In the voltage regulator getter we need to actually check the GPIO
pin before setting the "pin is high" bit in the index for the states.
Otherwise the index always has all possible bits sets.

ok kettenis@

Setting a fixed voltage regulator to the voltage it is fixed to
should not throw an error.

ok kettenis@

A fixed regulator's minimum voltage attribute is called regulator-min-microvolt
instead of regulator-min-voltage.

ok kettenis@

Fix OFW GPIO regulator by breaking out of the loop once the correct
match has been found. Otherwise the error condition will always
be true.

ok kettenis@

avoid uninitialised variable use
ok patrick@ kettenis@

Support GPIO-based voltage regulators.

ok kettenis@

Add delay when increasing the voltage of a regulator that has a
"regulator-ramp-delay" property to guerantee that the target voltage has
been reached when regulator_set_voltage(9) returns.

ok patrick@

Add support for enabling registered regulators. Make sure that we leave
regulators with a "regulator-always-on" property alone.

ok patrick@

Enforce voltage limits from the device tree. Enforcing the limits also
happens when regulators are registered. As a consequence they will be
properly initialized even when the firmware doesn't do that.

ok patrick@

Extend regulator "framework" with functions to get/set voltages.

ok jsg@

Add a minimal regulator "framework".

ok jsg@, patrick@

fixed regulators might rely on other regulators specified by "vin-supply"

when turning a fixed regulator on, turn on the regulator specified
in vin-supply too.

kettenis agrees we should do this.

fixed regulators could have a "gpios" or "gpio" property.

we only handled "gpio" before. figuring this out has wasted many
days of my life recently.

ok patrick@ kettenis@

Implement regulator notifiers which get called when the voltage/current
for a regulator is changed or when the regulator gets initialized when it
attaches for the first time. The latter makes it possible to register
a notifier for a regulator that hasn't attached yet.

ok dlg@

OF_getproplen() returns -1 on error, so don't store result in size_t
spotted by and ok tb@, ok tobhe@

Fix regulators that use "active-low" polarity. Our implementation now
ignores the presence "enable-active-high" property and relies on the
encode polarity of the GPIO in the flags in the device tree instead.
This might not be the case for older device trees; such device trees
should be fixed.

ok patrick@

Some devices have no phandle since they are not referenced in the
device tree, but they are still registered in our OFW framework.
These then tend to have a phandle 0. If we are trying to lookup
a device by phandle, we should explicitly check for phandle 0 and
bail, since otherwise it is possible that we falsely match that
phandle and return a device.

ok kettenis@

We are allowed to enable regulators with the "regulator-always-on"
property. The definition is that a regulator with this property
should never be disabled.

ok kettenis@

Add support for current limit regulators in addition to the voltage
regulators we already support. The GPIO-based regulators are rather
independent of the type, we only need to know the type to check the
upper and lower limits.

With feedback from kettenis@

In the voltage regulator getter we need to actually check the GPIO
pin before setting the "pin is high" bit in the index for the states.
Otherwise the index always has all possible bits sets.

ok kettenis@

Setting a fixed voltage regulator to the voltage it is fixed to
should not throw an error.

ok kettenis@

A fixed regulator's minimum voltage attribute is called regulator-min-microvolt
instead of regulator-min-voltage.

ok kettenis@

Fix OFW GPIO regulator by breaking out of the loop once the correct
match has been found. Otherwise the error condition will always
be true.

ok kettenis@

avoid uninitialised variable use
ok patrick@ kettenis@

Support GPIO-based voltage regulators.

ok kettenis@

Add delay when increasing the voltage of a regulator that has a
"regulator-ramp-delay" property to guerantee that the target voltage has
been reached when regulator_set_voltage(9) returns.

ok patrick@

Add support for enabling registered regulators. Make sure that we leave
regulators with a "regulator-always-on" property alone.

ok patrick@

Enforce voltage limits from the device tree. Enforcing the limits also
happens when regulators are registered. As a consequence they will be
properly initialized even when the firmware doesn't do that.

ok patrick@

Extend regulator "framework" with functions to get/set voltages.

ok jsg@

Add a minimal regulator "framework".

ok jsg@, patrick@

OF_getproplen() returns -1 on error, so don't store result in size_t
spotted by and ok tb@, ok tobhe@

Fix regulators that use "active-low" polarity. Our implementation now
ignores the presence "enable-active-high" property and relies on the
encode polarity of the GPIO in the flags in the device tree instead.
This might not be the case for older device trees; such device trees
should be fixed.

ok patrick@

Some devices have no phandle since they are not referenced in the
device tree, but they are still registered in our OFW framework.
These then tend to have a phandle 0. If we are trying to lookup
a device by phandle, we should explicitly check for phandle 0 and
bail, since otherwise it is possible that we falsely match that
phandle and return a device.

ok kettenis@

We are allowed to enable regulators with the "regulator-always-on"
property. The definition is that a regulator with this property
should never be disabled.

ok kettenis@

Add support for current limit regulators in addition to the voltage
regulators we already support. The GPIO-based regulators are rather
independent of the type, we only need to know the type to check the
upper and lower limits.

With feedback from kettenis@

In the voltage regulator getter we need to actually check the GPIO
pin before setting the "pin is high" bit in the index for the states.
Otherwise the index always has all possible bits sets.

ok kettenis@

Setting a fixed voltage regulator to the voltage it is fixed to
should not throw an error.

ok kettenis@

A fixed regulator's minimum voltage attribute is called regulator-min-microvolt
instead of regulator-min-voltage.

ok kettenis@

Fix OFW GPIO regulator by breaking out of the loop once the correct
match has been found. Otherwise the error condition will always
be true.

ok kettenis@

avoid uninitialised variable use
ok patrick@ kettenis@

Support GPIO-based voltage regulators.

ok kettenis@

Add delay when increasing the voltage of a regulator that has a
"regulator-ramp-delay" property to guerantee that the target voltage has
been reached when regulator_set_voltage(9) returns.

ok patrick@

Add support for enabling registered regulators. Make sure that we leave
regulators with a "regulator-always-on" property alone.

ok patrick@

Enforce voltage limits from the device tree. Enforcing the limits also
happens when regulators are registered. As a consequence they will be
properly initialized even when the firmware doesn't do that.

ok patrick@

Extend regulator "framework" with functions to get/set voltages.

ok jsg@

Add a minimal regulator "framework".

ok jsg@, patrick@

Fix regulators that use "active-low" polarity. Our implementation now
ignores the presence "enable-active-high" property and relies on the
encode polarity of the GPIO in the flags in the device tree instead.
This might not be the case for older device trees; such device trees
should be fixed.

ok patrick@

Some devices have no phandle since they are not referenced in the
device tree, but they are still registered in our OFW framework.
These then tend to have a phandle 0. If we are trying to lookup
a device by phandle, we should explicitly check for phandle 0 and
bail, since otherwise it is possible that we falsely match that
phandle and return a device.

ok kettenis@

We are allowed to enable regulators with the "regulator-always-on"
property. The definition is that a regulator with this property
should never be disabled.

ok kettenis@

Add support for current limit regulators in addition to the voltage
regulators we already support. The GPIO-based regulators are rather
independent of the type, we only need to know the type to check the
upper and lower limits.

With feedback from kettenis@

In the voltage regulator getter we need to actually check the GPIO
pin before setting the "pin is high" bit in the index for the states.
Otherwise the index always has all possible bits sets.

ok kettenis@

Setting a fixed voltage regulator to the voltage it is fixed to
should not throw an error.

ok kettenis@

A fixed regulator's minimum voltage attribute is called regulator-min-microvolt
instead of regulator-min-voltage.

ok kettenis@

Fix OFW GPIO regulator by breaking out of the loop once the correct
match has been found. Otherwise the error condition will always
be true.

ok kettenis@

avoid uninitialised variable use
ok patrick@ kettenis@

Support GPIO-based voltage regulators.

ok kettenis@

Add delay when increasing the voltage of a regulator that has a
"regulator-ramp-delay" property to guerantee that the target voltage has
been reached when regulator_set_voltage(9) returns.

ok patrick@

Add support for enabling registered regulators. Make sure that we leave
regulators with a "regulator-always-on" property alone.

ok patrick@

Enforce voltage limits from the device tree. Enforcing the limits also
happens when regulators are registered. As a consequence they will be
properly initialized even when the firmware doesn't do that.

ok patrick@

Extend regulator "framework" with functions to get/set voltages.

ok jsg@

Add a minimal regulator "framework".

ok jsg@, patrick@

Some devices have no phandle since they are not referenced in the
device tree, but they are still registered in our OFW framework.
These then tend to have a phandle 0. If we are trying to lookup
a device by phandle, we should explicitly check for phandle 0 and
bail, since otherwise it is possible that we falsely match that
phandle and return a device.

ok kettenis@

We are allowed to enable regulators with the "regulator-always-on"
property. The definition is that a regulator with this property
should never be disabled.

ok kettenis@

Add support for current limit regulators in addition to the voltage
regulators we already support. The GPIO-based regulators are rather
independent of the type, we only need to know the type to check the
upper and lower limits.

With feedback from kettenis@

In the voltage regulator getter we need to actually check the GPIO
pin before setting the "pin is high" bit in the index for the states.
Otherwise the index always has all possible bits sets.

ok kettenis@

Setting a fixed voltage regulator to the voltage it is fixed to
should not throw an error.

ok kettenis@

A fixed regulator's minimum voltage attribute is called regulator-min-microvolt
instead of regulator-min-voltage.

ok kettenis@

Fix OFW GPIO regulator by breaking out of the loop once the correct
match has been found. Otherwise the error condition will always
be true.

ok kettenis@

avoid uninitialised variable use
ok patrick@ kettenis@

Support GPIO-based voltage regulators.

ok kettenis@

Add delay when increasing the voltage of a regulator that has a
"regulator-ramp-delay" property to guerantee that the target voltage has
been reached when regulator_set_voltage(9) returns.

ok patrick@

Add support for enabling registered regulators. Make sure that we leave
regulators with a "regulator-always-on" property alone.

ok patrick@

Enforce voltage limits from the device tree. Enforcing the limits also
happens when regulators are registered. As a consequence they will be
properly initialized even when the firmware doesn't do that.

ok patrick@

Extend regulator "framework" with functions to get/set voltages.

ok jsg@

Add a minimal regulator "framework".

ok jsg@, patrick@

We are allowed to enable regulators with the "regulator-always-on"
property. The definition is that a regulator with this property
should never be disabled.

ok kettenis@

Add support for current limit regulators in addition to the voltage
regulators we already support. The GPIO-based regulators are rather
independent of the type, we only need to know the type to check the
upper and lower limits.

With feedback from kettenis@

In the voltage regulator getter we need to actually check the GPIO
pin before setting the "pin is high" bit in the index for the states.
Otherwise the index always has all possible bits sets.

ok kettenis@

Setting a fixed voltage regulator to the voltage it is fixed to
should not throw an error.

ok kettenis@

A fixed regulator's minimum voltage attribute is called regulator-min-microvolt
instead of regulator-min-voltage.

ok kettenis@

Fix OFW GPIO regulator by breaking out of the loop once the correct
match has been found. Otherwise the error condition will always
be true.

ok kettenis@

avoid uninitialised variable use
ok patrick@ kettenis@

Support GPIO-based voltage regulators.

ok kettenis@

Add delay when increasing the voltage of a regulator that has a
"regulator-ramp-delay" property to guerantee that the target voltage has
been reached when regulator_set_voltage(9) returns.

ok patrick@

Add support for enabling registered regulators. Make sure that we leave
regulators with a "regulator-always-on" property alone.

ok patrick@

Enforce voltage limits from the device tree. Enforcing the limits also
happens when regulators are registered. As a consequence they will be
properly initialized even when the firmware doesn't do that.

ok patrick@

Extend regulator "framework" with functions to get/set voltages.

ok jsg@

Add a minimal regulator "framework".

ok jsg@, patrick@

Add support for current limit regulators in addition to the voltage
regulators we already support. The GPIO-based regulators are rather
independent of the type, we only need to know the type to check the
upper and lower limits.

With feedback from kettenis@

In the voltage regulator getter we need to actually check the GPIO
pin before setting the "pin is high" bit in the index for the states.
Otherwise the index always has all possible bits sets.

ok kettenis@

Setting a fixed voltage regulator to the voltage it is fixed to
should not throw an error.

ok kettenis@

A fixed regulator's minimum voltage attribute is called regulator-min-microvolt
instead of regulator-min-voltage.

ok kettenis@

Fix OFW GPIO regulator by breaking out of the loop once the correct
match has been found. Otherwise the error condition will always
be true.

ok kettenis@

avoid uninitialised variable use
ok patrick@ kettenis@

Support GPIO-based voltage regulators.

ok kettenis@

Add delay when increasing the voltage of a regulator that has a
"regulator-ramp-delay" property to guerantee that the target voltage has
been reached when regulator_set_voltage(9) returns.

ok patrick@

Add support for enabling registered regulators. Make sure that we leave
regulators with a "regulator-always-on" property alone.

ok patrick@

Enforce voltage limits from the device tree. Enforcing the limits also
happens when regulators are registered. As a consequence they will be
properly initialized even when the firmware doesn't do that.

ok patrick@

Extend regulator "framework" with functions to get/set voltages.

ok jsg@

Add a minimal regulator "framework".

ok jsg@, patrick@

In the voltage regulator getter we need to actually check the GPIO
pin before setting the "pin is high" bit in the index for the states.
Otherwise the index always has all possible bits sets.

ok kettenis@

Setting a fixed voltage regulator to the voltage it is fixed to
should not throw an error.

ok kettenis@

A fixed regulator's minimum voltage attribute is called regulator-min-microvolt
instead of regulator-min-voltage.

ok kettenis@

Fix OFW GPIO regulator by breaking out of the loop once the correct
match has been found. Otherwise the error condition will always
be true.

ok kettenis@

avoid uninitialised variable use
ok patrick@ kettenis@

Support GPIO-based voltage regulators.

ok kettenis@

Add delay when increasing the voltage of a regulator that has a
"regulator-ramp-delay" property to guerantee that the target voltage has
been reached when regulator_set_voltage(9) returns.

ok patrick@

Add support for enabling registered regulators. Make sure that we leave
regulators with a "regulator-always-on" property alone.

ok patrick@

Enforce voltage limits from the device tree. Enforcing the limits also
happens when regulators are registered. As a consequence they will be
properly initialized even when the firmware doesn't do that.

ok patrick@

Extend regulator "framework" with functions to get/set voltages.

ok jsg@

Add a minimal regulator "framework".

ok jsg@, patrick@

Setting a fixed voltage regulator to the voltage it is fixed to
should not throw an error.

ok kettenis@

A fixed regulator's minimum voltage attribute is called regulator-min-microvolt
instead of regulator-min-voltage.

ok kettenis@

Fix OFW GPIO regulator by breaking out of the loop once the correct
match has been found. Otherwise the error condition will always
be true.

ok kettenis@

avoid uninitialised variable use
ok patrick@ kettenis@

Support GPIO-based voltage regulators.

ok kettenis@

Add delay when increasing the voltage of a regulator that has a
"regulator-ramp-delay" property to guerantee that the target voltage has
been reached when regulator_set_voltage(9) returns.

ok patrick@

Add support for enabling registered regulators. Make sure that we leave
regulators with a "regulator-always-on" property alone.

ok patrick@

Enforce voltage limits from the device tree. Enforcing the limits also
happens when regulators are registered. As a consequence they will be
properly initialized even when the firmware doesn't do that.

ok patrick@

Extend regulator "framework" with functions to get/set voltages.

ok jsg@

Add a minimal regulator "framework".

ok jsg@, patrick@

Fix OFW GPIO regulator by breaking out of the loop once the correct
match has been found. Otherwise the error condition will always
be true.

ok kettenis@

avoid uninitialised variable use
ok patrick@ kettenis@

Support GPIO-based voltage regulators.

ok kettenis@

Add delay when increasing the voltage of a regulator that has a
"regulator-ramp-delay" property to guerantee that the target voltage has
been reached when regulator_set_voltage(9) returns.

ok patrick@

Add support for enabling registered regulators. Make sure that we leave
regulators with a "regulator-always-on" property alone.

ok patrick@

Enforce voltage limits from the device tree. Enforcing the limits also
happens when regulators are registered. As a consequence they will be
properly initialized even when the firmware doesn't do that.

ok patrick@

Extend regulator "framework" with functions to get/set voltages.

ok jsg@

Add a minimal regulator "framework".

ok jsg@, patrick@

avoid uninitialised variable use
ok patrick@ kettenis@

Support GPIO-based voltage regulators.

ok kettenis@

Add delay when increasing the voltage of a regulator that has a
"regulator-ramp-delay" property to guerantee that the target voltage has
been reached when regulator_set_voltage(9) returns.

ok patrick@

Add support for enabling registered regulators. Make sure that we leave
regulators with a "regulator-always-on" property alone.

ok patrick@

Enforce voltage limits from the device tree. Enforcing the limits also
happens when regulators are registered. As a consequence they will be
properly initialized even when the firmware doesn't do that.

ok patrick@

Extend regulator "framework" with functions to get/set voltages.

ok jsg@

Add a minimal regulator "framework".

ok jsg@, patrick@

Add support for enabling registered regulators. Make sure that we leave
regulators with a "regulator-always-on" property alone.

ok patrick@

Enforce voltage limits from the device tree. Enforcing the limits also
happens when regulators are registered. As a consequence they will be
properly initialized even when the firmware doesn't do that.

ok patrick@

Extend regulator "framework" with functions to get/set voltages.

ok jsg@

Add a minimal regulator "framework".

ok jsg@, patrick@