Kill unused `aac_select'. Build test performed with uncommented aac(4)
in GENERIC.

ok jsg

Change function definitions using the identifier-list form used in the
1st edition of Kernighan and Ritchie's The C Programming Language, to
that of the parameter-type-list form described in the ANSI X3.159-1989
standard.

In ISO/IEC 9899:2023 drafts, there is only one form of function definition.
"N2432 Remove support for function definitions with identifier lists".

spelling
feedback and ok tb@ jmc@ ok ratchov@

Nuke unused struct scsi_link members of adapter softc's where the
driver successfully compiles on one or more of amd64, i386, hppa.

fix build errors of aac(4)

Remove outdated unused compat define. mono_time no longer exists and
the kernel has had time_second since 2004.

remove a XS_NO_CCB case by moving aac to iopools.

eyes and ok by krw@ jmatthew@

replace aacminphys with scsi_minphys. both are just wrappers around
minphys.

aacvar advertises a public api which is only used inside aac.c. make it
"private" so i dont feel bad about changing it.

acknowlege -> acknowledge
compatability -> compatibility

OK jmc@.

Extend the scsi_adapter minphys() callback to take a struct scsi_link *
as additional argument. This will allow intermediate layers between
scsi devices such as sd and scsi host adapters to take appropriate
action if necessary.

add a name to rwlock so that we can tell where procs are getting stuck
without breaking into ddb. doubles the size of rwlock [1], but moving
forward this really helps. ok/tested pedro fgsch millert krw
[1 - next person to add a field to this struct gets whipped with a wet noodle]

Add support for the Adaptec RAID-On-Chip architecture. This in turn
provides support for the Adaptec 2130S and 2230SLP adapters.

From FreeBSD

ok dlg@

Major improvements to the aac(4) device driver.
- decouple the command structures from scsi structures, allowing non block
oriented commands (e.g. management commands) to be built.
- redesign the various command queues to remove race conditions and to allow
commands from multiple sources to coexist in the system
- move major processing of commands and messages to a dedicated kernel
thread to avoid spending too long in the interrupt handler
- add device data structures for various management commands to the header
file

Much code from FreeBSD

typos from Tom Cosgrove;

Tom: I did not commit a couple of your changes.

i did not include some punctuation fixes (full stops, etc.)
mnemorable -> mnemonic: i decided memorable was probably better
instrunctions -> instruction: i kept the plural

kill __FUNCTION__

First round of __P removal in sys

branches: 1.1.4; 1.1.8;
Adaptec "FSA" RAID driver

Change function definitions using the identifier-list form used in the
1st edition of Kernighan and Ritchie's The C Programming Language, to
that of the parameter-type-list form described in the ANSI X3.159-1989
standard.

In ISO/IEC 9899:2023 drafts, there is only one form of function definition.
"N2432 Remove support for function definitions with identifier lists".

spelling
feedback and ok tb@ jmc@ ok ratchov@

Nuke unused struct scsi_link members of adapter softc's where the
driver successfully compiles on one or more of amd64, i386, hppa.

fix build errors of aac(4)

Remove outdated unused compat define. mono_time no longer exists and
the kernel has had time_second since 2004.

remove a XS_NO_CCB case by moving aac to iopools.

eyes and ok by krw@ jmatthew@

replace aacminphys with scsi_minphys. both are just wrappers around
minphys.

aacvar advertises a public api which is only used inside aac.c. make it
"private" so i dont feel bad about changing it.

acknowlege -> acknowledge
compatability -> compatibility

OK jmc@.

Extend the scsi_adapter minphys() callback to take a struct scsi_link *
as additional argument. This will allow intermediate layers between
scsi devices such as sd and scsi host adapters to take appropriate
action if necessary.

add a name to rwlock so that we can tell where procs are getting stuck
without breaking into ddb. doubles the size of rwlock [1], but moving
forward this really helps. ok/tested pedro fgsch millert krw
[1 - next person to add a field to this struct gets whipped with a wet noodle]

Add support for the Adaptec RAID-On-Chip architecture. This in turn
provides support for the Adaptec 2130S and 2230SLP adapters.

From FreeBSD

ok dlg@

Major improvements to the aac(4) device driver.
- decouple the command structures from scsi structures, allowing non block
oriented commands (e.g. management commands) to be built.
- redesign the various command queues to remove race conditions and to allow
commands from multiple sources to coexist in the system
- move major processing of commands and messages to a dedicated kernel
thread to avoid spending too long in the interrupt handler
- add device data structures for various management commands to the header
file

Much code from FreeBSD

typos from Tom Cosgrove;

Tom: I did not commit a couple of your changes.

i did not include some punctuation fixes (full stops, etc.)
mnemorable -> mnemonic: i decided memorable was probably better
instrunctions -> instruction: i kept the plural

kill __FUNCTION__

First round of __P removal in sys

branches: 1.1.4; 1.1.8;
Adaptec "FSA" RAID driver

spelling
feedback and ok tb@ jmc@ ok ratchov@

Nuke unused struct scsi_link members of adapter softc's where the
driver successfully compiles on one or more of amd64, i386, hppa.

fix build errors of aac(4)

Remove outdated unused compat define. mono_time no longer exists and
the kernel has had time_second since 2004.

remove a XS_NO_CCB case by moving aac to iopools.

eyes and ok by krw@ jmatthew@

replace aacminphys with scsi_minphys. both are just wrappers around
minphys.

aacvar advertises a public api which is only used inside aac.c. make it
"private" so i dont feel bad about changing it.

acknowlege -> acknowledge
compatability -> compatibility

OK jmc@.

Extend the scsi_adapter minphys() callback to take a struct scsi_link *
as additional argument. This will allow intermediate layers between
scsi devices such as sd and scsi host adapters to take appropriate
action if necessary.

add a name to rwlock so that we can tell where procs are getting stuck
without breaking into ddb. doubles the size of rwlock [1], but moving
forward this really helps. ok/tested pedro fgsch millert krw
[1 - next person to add a field to this struct gets whipped with a wet noodle]

Add support for the Adaptec RAID-On-Chip architecture. This in turn
provides support for the Adaptec 2130S and 2230SLP adapters.

From FreeBSD

ok dlg@

Major improvements to the aac(4) device driver.
- decouple the command structures from scsi structures, allowing non block
oriented commands (e.g. management commands) to be built.
- redesign the various command queues to remove race conditions and to allow
commands from multiple sources to coexist in the system
- move major processing of commands and messages to a dedicated kernel
thread to avoid spending too long in the interrupt handler
- add device data structures for various management commands to the header
file

Much code from FreeBSD

typos from Tom Cosgrove;

Tom: I did not commit a couple of your changes.

i did not include some punctuation fixes (full stops, etc.)
mnemorable -> mnemonic: i decided memorable was probably better
instrunctions -> instruction: i kept the plural

kill __FUNCTION__

First round of __P removal in sys

branches: 1.1.4; 1.1.8;
Adaptec "FSA" RAID driver

Nuke unused struct scsi_link members of adapter softc's where the
driver successfully compiles on one or more of amd64, i386, hppa.

fix build errors of aac(4)

Remove outdated unused compat define. mono_time no longer exists and
the kernel has had time_second since 2004.

remove a XS_NO_CCB case by moving aac to iopools.

eyes and ok by krw@ jmatthew@

replace aacminphys with scsi_minphys. both are just wrappers around
minphys.

aacvar advertises a public api which is only used inside aac.c. make it
"private" so i dont feel bad about changing it.

acknowlege -> acknowledge
compatability -> compatibility

OK jmc@.

Extend the scsi_adapter minphys() callback to take a struct scsi_link *
as additional argument. This will allow intermediate layers between
scsi devices such as sd and scsi host adapters to take appropriate
action if necessary.

add a name to rwlock so that we can tell where procs are getting stuck
without breaking into ddb. doubles the size of rwlock [1], but moving
forward this really helps. ok/tested pedro fgsch millert krw
[1 - next person to add a field to this struct gets whipped with a wet noodle]

Add support for the Adaptec RAID-On-Chip architecture. This in turn
provides support for the Adaptec 2130S and 2230SLP adapters.

From FreeBSD

ok dlg@

Major improvements to the aac(4) device driver.
- decouple the command structures from scsi structures, allowing non block
oriented commands (e.g. management commands) to be built.
- redesign the various command queues to remove race conditions and to allow
commands from multiple sources to coexist in the system
- move major processing of commands and messages to a dedicated kernel
thread to avoid spending too long in the interrupt handler
- add device data structures for various management commands to the header
file

Much code from FreeBSD

typos from Tom Cosgrove;

Tom: I did not commit a couple of your changes.

i did not include some punctuation fixes (full stops, etc.)
mnemorable -> mnemonic: i decided memorable was probably better
instrunctions -> instruction: i kept the plural

kill __FUNCTION__

First round of __P removal in sys

branches: 1.1.4; 1.1.8;
Adaptec "FSA" RAID driver

fix build errors of aac(4)

Remove outdated unused compat define. mono_time no longer exists and
the kernel has had time_second since 2004.

remove a XS_NO_CCB case by moving aac to iopools.

eyes and ok by krw@ jmatthew@

replace aacminphys with scsi_minphys. both are just wrappers around
minphys.

aacvar advertises a public api which is only used inside aac.c. make it
"private" so i dont feel bad about changing it.

acknowlege -> acknowledge
compatability -> compatibility

OK jmc@.

Extend the scsi_adapter minphys() callback to take a struct scsi_link *
as additional argument. This will allow intermediate layers between
scsi devices such as sd and scsi host adapters to take appropriate
action if necessary.

add a name to rwlock so that we can tell where procs are getting stuck
without breaking into ddb. doubles the size of rwlock [1], but moving
forward this really helps. ok/tested pedro fgsch millert krw
[1 - next person to add a field to this struct gets whipped with a wet noodle]

Add support for the Adaptec RAID-On-Chip architecture. This in turn
provides support for the Adaptec 2130S and 2230SLP adapters.

From FreeBSD

ok dlg@

Major improvements to the aac(4) device driver.
- decouple the command structures from scsi structures, allowing non block
oriented commands (e.g. management commands) to be built.
- redesign the various command queues to remove race conditions and to allow
commands from multiple sources to coexist in the system
- move major processing of commands and messages to a dedicated kernel
thread to avoid spending too long in the interrupt handler
- add device data structures for various management commands to the header
file

Much code from FreeBSD

typos from Tom Cosgrove;

Tom: I did not commit a couple of your changes.

i did not include some punctuation fixes (full stops, etc.)
mnemorable -> mnemonic: i decided memorable was probably better
instrunctions -> instruction: i kept the plural

kill __FUNCTION__

First round of __P removal in sys

branches: 1.1.4; 1.1.8;
Adaptec "FSA" RAID driver

Remove outdated unused compat define. mono_time no longer exists and
the kernel has had time_second since 2004.

remove a XS_NO_CCB case by moving aac to iopools.

eyes and ok by krw@ jmatthew@

replace aacminphys with scsi_minphys. both are just wrappers around
minphys.

aacvar advertises a public api which is only used inside aac.c. make it
"private" so i dont feel bad about changing it.

acknowlege -> acknowledge
compatability -> compatibility

OK jmc@.

Extend the scsi_adapter minphys() callback to take a struct scsi_link *
as additional argument. This will allow intermediate layers between
scsi devices such as sd and scsi host adapters to take appropriate
action if necessary.

add a name to rwlock so that we can tell where procs are getting stuck
without breaking into ddb. doubles the size of rwlock [1], but moving
forward this really helps. ok/tested pedro fgsch millert krw
[1 - next person to add a field to this struct gets whipped with a wet noodle]

Add support for the Adaptec RAID-On-Chip architecture. This in turn
provides support for the Adaptec 2130S and 2230SLP adapters.

From FreeBSD

ok dlg@

Major improvements to the aac(4) device driver.
- decouple the command structures from scsi structures, allowing non block
oriented commands (e.g. management commands) to be built.
- redesign the various command queues to remove race conditions and to allow
commands from multiple sources to coexist in the system
- move major processing of commands and messages to a dedicated kernel
thread to avoid spending too long in the interrupt handler
- add device data structures for various management commands to the header
file

Much code from FreeBSD

typos from Tom Cosgrove;

Tom: I did not commit a couple of your changes.

i did not include some punctuation fixes (full stops, etc.)
mnemorable -> mnemonic: i decided memorable was probably better
instrunctions -> instruction: i kept the plural

kill __FUNCTION__

First round of __P removal in sys

branches: 1.1.4; 1.1.8;
Adaptec "FSA" RAID driver