Some machines send AC change notifications to acpibat(4). Forward this
notification to acpiac(4), so that the AC status can be reflected correctly
to programs like apm(8).

This for example fixes the AC status on the Microsoft Surface Go 4.

Help from kettenis@

ok deraadt@, kettenis@

constify struct cfattach

add Surface Go 3 hid to acpibat(4)

Microsoft decided to break with basic ACPI standards with the Go 3.
In this case, they don't expose the battery in a standard way, so
acpibat(4) needs to look for the special Microsoft hid.

From mlarkin@, ok kettenis@

Give userland a consistent battery and A/C state after resume

Previously we refreshed the state of acpiac(4) and acpibat(4)/acpisbs(4)
by queueing fake ACPI events to be processed by the acpi thread.
acpibat(4) using ACPIDEV_POLL meant that its status could be refreshed
first, resulting in an APM_POWER_CHANGE event sent to userland before
the state of acpiac(4) was up to date. Because of this, apmd(8) could
see A/C unplugged when it was in fact plugged, possibly leading to
a wrong decision.

Instead of using fake ACPI events, refresh the status of acpiac(4) and
acpibat(4)/acpisbs(4) right away at DVACT_WAKEUP time. To reuse the
existing refresh code of those drivers, make their ACPI *_notify()
handlers responsible for sending APM_POWER_CHANGE events instead. Also
queue an APM_POWER_CHANGE event right after resume to retain existing
behavior.

This fixes the consistency of data shown to userland, and makes those
drivers less special.

Initially discussed last year (!) with mpi@ at Miod's place.
Feedback and ok jcs@, deraadt@ agrees with the use of DVACT_WAKEUP here.

acpi: clean up some inconsistent style in the hid matching arrays

ok millert, kettenis, jcs, phessler, deraadt, mpi

Don't require exactly 20 elements in the _BIX package if at least 20
are returned since extras may be OEM-specific values we end up
ignoring anyway, such as on the Lenovo X1C 5th Gen which returns 21
elements.

ok mpi

fallback on _BIF properly when _BIX exists and returns a package
successfully but has an unexpected length, as on the X1C gen 5

tested by naddy

acpibat: look for _BIX first before falling back on _BIF

ACPI 4.0 deprecated _BIF for battery status so some newer machines
are exporting _BIX which extends _BIF's package with a few extra
fields. When using _BIX, export the new discharge cycle count as a
sensor.

feedback from kettenis and anton
ok deraadt

try to attach acpisbs first and if successful, don't attach acpibat

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

remove uneeded proc.h includes
ok mpi@ kspillner@

Expose bif_capacity as the 'design capacity' through an acpibat sensor,
giving you the original capacity of the battery:

hw.sensors.acpibat0.watthour0=64.07 Wh (last full capacity)
hw.sensors.acpibat0.watthour4=84.24 Wh (design capacity)

hw.sensors.acpibat0.amphour0=2.03 Ah (last full capacity)
hw.sensors.acpibat0.amphour4=4.40 Ah (design capacity)

Diff from Fabian Raetz on tech@, thanks!

ok mlarkin@ zhuk@ armani@ kettenis@

Provide battery charge/discharge rate in proper units.

Based on a diff from Vladimir Kirrillov.

The acpibat(4) notify function should not unconditionally call both _BIF
and _BST. Some machines (like the Toshiba Satellite Pro U550 18F mentioned
in PR 6508) have AML that does a Notify(0x81) from the _BST method, which leads
to infinite recursion. Instead call _BIF when the argument is 0x81 and call
_BST when the argument is 0x80 or 0x00 (the latter indicates we're polling).
Simplify the battery detection logic while there.

ok mikeb@, marco@

Generate power change events for APM. Makes powerup and powerdown scripts
work with ACPI.
ok deraadt@, phessler@, feedback kettenis@

spacing and indents that are driving me crazy

Reporting battery insert/removal was debug code. dmesg is not
a place to spam informational messages about unimportant events.
That is what the sensor framework is for (and that is already
done)
ok kettenis

More aml_evalinteger fixup
ok marco@

Collapse all sanity checks of hids into one function.

Originaly from jordan

add missing semicolon; ok mbalmer@, marco@

Fix spurious 0 values on batteries seen on laptopts that have an embedded
controller.

Found, diagnosed and patch from Stefan Sperling <stsp@stsp.name>
Minor KNF changes while here.

Tested by many on a variaty of IBM laptops and others with and without
acpiec.

ok deraadt

Properly handle battery insertion/removal
ok @marco

Re-enable new parser. Lots of testing by various folks. Fits all media
now too.

ok kettenis deraadt

back out jordans new parser.

it didnt have enough oks from the right people, it did break machines
that were previously working, and it bloated the RAMDISKS and install
media beyond the constraints of the media.

requested by deraadt@

Adding new ACPI Parser code
Old guts of code still exists, needs to be torn out next
ok marco@
ok brad@

quotes around model name too

spacing

spacing

only print bif info that is complete

convert the value to a string instead of using aml_val2str()
which returns invalid pointers if the value is not a string, causing
acpibat to panic, as reported by mbalmer@ and Alexey Suslikov.
tested by Alexey Suslikov, ok marco@

repair attach messages; ok gwk canacar

Use aml_val2int() instead of accessing v_integer directly.

`sort of ok' marco (before lock)

Since a full battery can still have state BST_CHARGE ("charging"),
fullness needs to be checked first. Otherwise, full batteries are
always described as "charging."

ok marco

Do the sensor magic correctly. Found by Constantine Murenin.
help from mickey

Add polling to devices that require it such as acpibat and acpitz.
Use the same tsleep/wakeup mechanism as the interrupt code to keep it non-
concurrent.

adapt to new two-level sensor api; Constantine A. Murenin

even more knf love

Tweak to report full battery.

more minor knf

Fix silly logic errors.

Silence acpibat significantly and shave off about 1k. Also add some smarts
for battery removal and insertion.

After a long debate at the hackathon it was decided that the acpi implementation
is not concurrent if the sensors thread goes away. This makes acpi completly
lockless.

help and ok dlg

Reduce the scope of the locks.

KNF and some cleanup

Replace ACPI ioctls with APM ioctls. This makes ACPI talk the same protocol
as APM therefore userspace can now retrieve power information in the same
fashion as all other apm arches (zaurus, macppc, i386 etc).

To use force the use of acpi device like so: apmd -f /dev/acpi

ok jordan@

Fix capacity calculations. Tested on Dell C610, D810, Lenovo X60s.

ok jordan

Massive ACPI changes
Fixed ACPI leaks
new ACPI API
ok marco@

Typo fixes.

ok marco

fix a bad strlcpy, from ben lovett

Use rwlock instead of lockmgr locks.
ok marco@

rv not set. Sloppy but didn't matter.
pointed out by joris@

KNF nit.

Rework notify handler.
Use jordan's new notify register function.
ok jordan@

Add insertion and removal events for batteries.
Some cleanup & KNF.

KNF

Adjust debugging levels to something more reasonable.

Better comments.

Propogate some values through the sysctl hw.sesnsors interface for debug
purposes. This will be removed later and replaced with something better.

Detect if battery slot is available but without a battery in it.

ok jordan

Print useful information during boot about the battery and power supply.

ok jordan.

Adjust debug levels to something sane.

Rewrote aml parser yet again...
Fixed bus_space_map for i386/amd64
Added _BST and _BIF to acpibat to get status/info
ok marco@

Major overhaul of the aml parser. Evaluater temporarily disabled.

ok marco@

Sudden newline

make ACPI_DEBUG compile

oops enabled a method that doesnt work yet so disabled getbif for now.
ok jordan@

Add some return values to getbst and getbif.
ok jordan@

Add 2 methods (Battery Info and Battery Status)
ok jordan@

Use new unified header.

Use shiny new acpibat.h

Add battery device.

constify struct cfattach

add Surface Go 3 hid to acpibat(4)

Microsoft decided to break with basic ACPI standards with the Go 3.
In this case, they don't expose the battery in a standard way, so
acpibat(4) needs to look for the special Microsoft hid.

From mlarkin@, ok kettenis@

Give userland a consistent battery and A/C state after resume

Previously we refreshed the state of acpiac(4) and acpibat(4)/acpisbs(4)
by queueing fake ACPI events to be processed by the acpi thread.
acpibat(4) using ACPIDEV_POLL meant that its status could be refreshed
first, resulting in an APM_POWER_CHANGE event sent to userland before
the state of acpiac(4) was up to date. Because of this, apmd(8) could
see A/C unplugged when it was in fact plugged, possibly leading to
a wrong decision.

Instead of using fake ACPI events, refresh the status of acpiac(4) and
acpibat(4)/acpisbs(4) right away at DVACT_WAKEUP time. To reuse the
existing refresh code of those drivers, make their ACPI *_notify()
handlers responsible for sending APM_POWER_CHANGE events instead. Also
queue an APM_POWER_CHANGE event right after resume to retain existing
behavior.

This fixes the consistency of data shown to userland, and makes those
drivers less special.

Initially discussed last year (!) with mpi@ at Miod's place.
Feedback and ok jcs@, deraadt@ agrees with the use of DVACT_WAKEUP here.

acpi: clean up some inconsistent style in the hid matching arrays

ok millert, kettenis, jcs, phessler, deraadt, mpi

Don't require exactly 20 elements in the _BIX package if at least 20
are returned since extras may be OEM-specific values we end up
ignoring anyway, such as on the Lenovo X1C 5th Gen which returns 21
elements.

ok mpi

fallback on _BIF properly when _BIX exists and returns a package
successfully but has an unexpected length, as on the X1C gen 5

tested by naddy

acpibat: look for _BIX first before falling back on _BIF

ACPI 4.0 deprecated _BIF for battery status so some newer machines
are exporting _BIX which extends _BIF's package with a few extra
fields. When using _BIX, export the new discharge cycle count as a
sensor.

feedback from kettenis and anton
ok deraadt

try to attach acpisbs first and if successful, don't attach acpibat

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

remove uneeded proc.h includes
ok mpi@ kspillner@

Expose bif_capacity as the 'design capacity' through an acpibat sensor,
giving you the original capacity of the battery:

hw.sensors.acpibat0.watthour0=64.07 Wh (last full capacity)
hw.sensors.acpibat0.watthour4=84.24 Wh (design capacity)

hw.sensors.acpibat0.amphour0=2.03 Ah (last full capacity)
hw.sensors.acpibat0.amphour4=4.40 Ah (design capacity)

Diff from Fabian Raetz on tech@, thanks!

ok mlarkin@ zhuk@ armani@ kettenis@

Provide battery charge/discharge rate in proper units.

Based on a diff from Vladimir Kirrillov.

The acpibat(4) notify function should not unconditionally call both _BIF
and _BST. Some machines (like the Toshiba Satellite Pro U550 18F mentioned
in PR 6508) have AML that does a Notify(0x81) from the _BST method, which leads
to infinite recursion. Instead call _BIF when the argument is 0x81 and call
_BST when the argument is 0x80 or 0x00 (the latter indicates we're polling).
Simplify the battery detection logic while there.

ok mikeb@, marco@

Generate power change events for APM. Makes powerup and powerdown scripts
work with ACPI.
ok deraadt@, phessler@, feedback kettenis@

spacing and indents that are driving me crazy

Reporting battery insert/removal was debug code. dmesg is not
a place to spam informational messages about unimportant events.
That is what the sensor framework is for (and that is already
done)
ok kettenis

More aml_evalinteger fixup
ok marco@

Collapse all sanity checks of hids into one function.

Originaly from jordan

add missing semicolon; ok mbalmer@, marco@

Fix spurious 0 values on batteries seen on laptopts that have an embedded
controller.

Found, diagnosed and patch from Stefan Sperling <stsp@stsp.name>
Minor KNF changes while here.

Tested by many on a variaty of IBM laptops and others with and without
acpiec.

ok deraadt

Properly handle battery insertion/removal
ok @marco

Re-enable new parser. Lots of testing by various folks. Fits all media
now too.

ok kettenis deraadt

back out jordans new parser.

it didnt have enough oks from the right people, it did break machines
that were previously working, and it bloated the RAMDISKS and install
media beyond the constraints of the media.

requested by deraadt@

Adding new ACPI Parser code
Old guts of code still exists, needs to be torn out next
ok marco@
ok brad@

quotes around model name too

spacing

spacing

only print bif info that is complete

convert the value to a string instead of using aml_val2str()
which returns invalid pointers if the value is not a string, causing
acpibat to panic, as reported by mbalmer@ and Alexey Suslikov.
tested by Alexey Suslikov, ok marco@

repair attach messages; ok gwk canacar

Use aml_val2int() instead of accessing v_integer directly.

`sort of ok' marco (before lock)

Since a full battery can still have state BST_CHARGE ("charging"),
fullness needs to be checked first. Otherwise, full batteries are
always described as "charging."

ok marco

Do the sensor magic correctly. Found by Constantine Murenin.
help from mickey

Add polling to devices that require it such as acpibat and acpitz.
Use the same tsleep/wakeup mechanism as the interrupt code to keep it non-
concurrent.

adapt to new two-level sensor api; Constantine A. Murenin

even more knf love

Tweak to report full battery.

more minor knf

Fix silly logic errors.

Silence acpibat significantly and shave off about 1k. Also add some smarts
for battery removal and insertion.

After a long debate at the hackathon it was decided that the acpi implementation
is not concurrent if the sensors thread goes away. This makes acpi completly
lockless.

help and ok dlg

Reduce the scope of the locks.

KNF and some cleanup

Replace ACPI ioctls with APM ioctls. This makes ACPI talk the same protocol
as APM therefore userspace can now retrieve power information in the same
fashion as all other apm arches (zaurus, macppc, i386 etc).

To use force the use of acpi device like so: apmd -f /dev/acpi

ok jordan@

Fix capacity calculations. Tested on Dell C610, D810, Lenovo X60s.

ok jordan

Massive ACPI changes
Fixed ACPI leaks
new ACPI API
ok marco@

Typo fixes.

ok marco

fix a bad strlcpy, from ben lovett

Use rwlock instead of lockmgr locks.
ok marco@

rv not set. Sloppy but didn't matter.
pointed out by joris@

KNF nit.

Rework notify handler.
Use jordan's new notify register function.
ok jordan@

Add insertion and removal events for batteries.
Some cleanup & KNF.

KNF

Adjust debugging levels to something more reasonable.

Better comments.

Propogate some values through the sysctl hw.sesnsors interface for debug
purposes. This will be removed later and replaced with something better.

Detect if battery slot is available but without a battery in it.

ok jordan

Print useful information during boot about the battery and power supply.

ok jordan.

Adjust debug levels to something sane.

Rewrote aml parser yet again...
Fixed bus_space_map for i386/amd64
Added _BST and _BIF to acpibat to get status/info
ok marco@

Major overhaul of the aml parser. Evaluater temporarily disabled.

ok marco@

Sudden newline

make ACPI_DEBUG compile

oops enabled a method that doesnt work yet so disabled getbif for now.
ok jordan@

Add some return values to getbst and getbif.
ok jordan@

Add 2 methods (Battery Info and Battery Status)
ok jordan@

Use new unified header.

Use shiny new acpibat.h

Add battery device.

add Surface Go 3 hid to acpibat(4)

Microsoft decided to break with basic ACPI standards with the Go 3.
In this case, they don't expose the battery in a standard way, so
acpibat(4) needs to look for the special Microsoft hid.

From mlarkin@, ok kettenis@

Give userland a consistent battery and A/C state after resume

Previously we refreshed the state of acpiac(4) and acpibat(4)/acpisbs(4)
by queueing fake ACPI events to be processed by the acpi thread.
acpibat(4) using ACPIDEV_POLL meant that its status could be refreshed
first, resulting in an APM_POWER_CHANGE event sent to userland before
the state of acpiac(4) was up to date. Because of this, apmd(8) could
see A/C unplugged when it was in fact plugged, possibly leading to
a wrong decision.

Instead of using fake ACPI events, refresh the status of acpiac(4) and
acpibat(4)/acpisbs(4) right away at DVACT_WAKEUP time. To reuse the
existing refresh code of those drivers, make their ACPI *_notify()
handlers responsible for sending APM_POWER_CHANGE events instead. Also
queue an APM_POWER_CHANGE event right after resume to retain existing
behavior.

This fixes the consistency of data shown to userland, and makes those
drivers less special.

Initially discussed last year (!) with mpi@ at Miod's place.
Feedback and ok jcs@, deraadt@ agrees with the use of DVACT_WAKEUP here.

acpi: clean up some inconsistent style in the hid matching arrays

ok millert, kettenis, jcs, phessler, deraadt, mpi

Don't require exactly 20 elements in the _BIX package if at least 20
are returned since extras may be OEM-specific values we end up
ignoring anyway, such as on the Lenovo X1C 5th Gen which returns 21
elements.

ok mpi

fallback on _BIF properly when _BIX exists and returns a package
successfully but has an unexpected length, as on the X1C gen 5

tested by naddy

acpibat: look for _BIX first before falling back on _BIF

ACPI 4.0 deprecated _BIF for battery status so some newer machines
are exporting _BIX which extends _BIF's package with a few extra
fields. When using _BIX, export the new discharge cycle count as a
sensor.

feedback from kettenis and anton
ok deraadt

try to attach acpisbs first and if successful, don't attach acpibat

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

remove uneeded proc.h includes
ok mpi@ kspillner@

Expose bif_capacity as the 'design capacity' through an acpibat sensor,
giving you the original capacity of the battery:

hw.sensors.acpibat0.watthour0=64.07 Wh (last full capacity)
hw.sensors.acpibat0.watthour4=84.24 Wh (design capacity)

hw.sensors.acpibat0.amphour0=2.03 Ah (last full capacity)
hw.sensors.acpibat0.amphour4=4.40 Ah (design capacity)

Diff from Fabian Raetz on tech@, thanks!

ok mlarkin@ zhuk@ armani@ kettenis@

Provide battery charge/discharge rate in proper units.

Based on a diff from Vladimir Kirrillov.

The acpibat(4) notify function should not unconditionally call both _BIF
and _BST. Some machines (like the Toshiba Satellite Pro U550 18F mentioned
in PR 6508) have AML that does a Notify(0x81) from the _BST method, which leads
to infinite recursion. Instead call _BIF when the argument is 0x81 and call
_BST when the argument is 0x80 or 0x00 (the latter indicates we're polling).
Simplify the battery detection logic while there.

ok mikeb@, marco@

Generate power change events for APM. Makes powerup and powerdown scripts
work with ACPI.
ok deraadt@, phessler@, feedback kettenis@

spacing and indents that are driving me crazy

Reporting battery insert/removal was debug code. dmesg is not
a place to spam informational messages about unimportant events.
That is what the sensor framework is for (and that is already
done)
ok kettenis

More aml_evalinteger fixup
ok marco@

Collapse all sanity checks of hids into one function.

Originaly from jordan

add missing semicolon; ok mbalmer@, marco@

Fix spurious 0 values on batteries seen on laptopts that have an embedded
controller.

Found, diagnosed and patch from Stefan Sperling <stsp@stsp.name>
Minor KNF changes while here.

Tested by many on a variaty of IBM laptops and others with and without
acpiec.

ok deraadt

Properly handle battery insertion/removal
ok @marco

Re-enable new parser. Lots of testing by various folks. Fits all media
now too.

ok kettenis deraadt

back out jordans new parser.

it didnt have enough oks from the right people, it did break machines
that were previously working, and it bloated the RAMDISKS and install
media beyond the constraints of the media.

requested by deraadt@

Adding new ACPI Parser code
Old guts of code still exists, needs to be torn out next
ok marco@
ok brad@

quotes around model name too

spacing

spacing

only print bif info that is complete

convert the value to a string instead of using aml_val2str()
which returns invalid pointers if the value is not a string, causing
acpibat to panic, as reported by mbalmer@ and Alexey Suslikov.
tested by Alexey Suslikov, ok marco@

repair attach messages; ok gwk canacar

Use aml_val2int() instead of accessing v_integer directly.

`sort of ok' marco (before lock)

Since a full battery can still have state BST_CHARGE ("charging"),
fullness needs to be checked first. Otherwise, full batteries are
always described as "charging."

ok marco

Do the sensor magic correctly. Found by Constantine Murenin.
help from mickey

Add polling to devices that require it such as acpibat and acpitz.
Use the same tsleep/wakeup mechanism as the interrupt code to keep it non-
concurrent.

adapt to new two-level sensor api; Constantine A. Murenin

even more knf love

Tweak to report full battery.

more minor knf

Fix silly logic errors.

Silence acpibat significantly and shave off about 1k. Also add some smarts
for battery removal and insertion.

After a long debate at the hackathon it was decided that the acpi implementation
is not concurrent if the sensors thread goes away. This makes acpi completly
lockless.

help and ok dlg

Reduce the scope of the locks.

KNF and some cleanup

Replace ACPI ioctls with APM ioctls. This makes ACPI talk the same protocol
as APM therefore userspace can now retrieve power information in the same
fashion as all other apm arches (zaurus, macppc, i386 etc).

To use force the use of acpi device like so: apmd -f /dev/acpi

ok jordan@

Fix capacity calculations. Tested on Dell C610, D810, Lenovo X60s.

ok jordan

Massive ACPI changes
Fixed ACPI leaks
new ACPI API
ok marco@

Typo fixes.

ok marco

fix a bad strlcpy, from ben lovett

Use rwlock instead of lockmgr locks.
ok marco@

rv not set. Sloppy but didn't matter.
pointed out by joris@

KNF nit.

Rework notify handler.
Use jordan's new notify register function.
ok jordan@

Add insertion and removal events for batteries.
Some cleanup & KNF.

KNF

Adjust debugging levels to something more reasonable.

Better comments.

Propogate some values through the sysctl hw.sesnsors interface for debug
purposes. This will be removed later and replaced with something better.

Detect if battery slot is available but without a battery in it.

ok jordan

Print useful information during boot about the battery and power supply.

ok jordan.

Adjust debug levels to something sane.

Rewrote aml parser yet again...
Fixed bus_space_map for i386/amd64
Added _BST and _BIF to acpibat to get status/info
ok marco@

Major overhaul of the aml parser. Evaluater temporarily disabled.

ok marco@

Sudden newline

make ACPI_DEBUG compile

oops enabled a method that doesnt work yet so disabled getbif for now.
ok jordan@

Add some return values to getbst and getbif.
ok jordan@

Add 2 methods (Battery Info and Battery Status)
ok jordan@

Use new unified header.

Use shiny new acpibat.h

Add battery device.

Give userland a consistent battery and A/C state after resume

Previously we refreshed the state of acpiac(4) and acpibat(4)/acpisbs(4)
by queueing fake ACPI events to be processed by the acpi thread.
acpibat(4) using ACPIDEV_POLL meant that its status could be refreshed
first, resulting in an APM_POWER_CHANGE event sent to userland before
the state of acpiac(4) was up to date. Because of this, apmd(8) could
see A/C unplugged when it was in fact plugged, possibly leading to
a wrong decision.

Instead of using fake ACPI events, refresh the status of acpiac(4) and
acpibat(4)/acpisbs(4) right away at DVACT_WAKEUP time. To reuse the
existing refresh code of those drivers, make their ACPI *_notify()
handlers responsible for sending APM_POWER_CHANGE events instead. Also
queue an APM_POWER_CHANGE event right after resume to retain existing
behavior.

This fixes the consistency of data shown to userland, and makes those
drivers less special.

Initially discussed last year (!) with mpi@ at Miod's place.
Feedback and ok jcs@, deraadt@ agrees with the use of DVACT_WAKEUP here.

acpi: clean up some inconsistent style in the hid matching arrays

ok millert, kettenis, jcs, phessler, deraadt, mpi

Don't require exactly 20 elements in the _BIX package if at least 20
are returned since extras may be OEM-specific values we end up
ignoring anyway, such as on the Lenovo X1C 5th Gen which returns 21
elements.

ok mpi

fallback on _BIF properly when _BIX exists and returns a package
successfully but has an unexpected length, as on the X1C gen 5

tested by naddy

acpibat: look for _BIX first before falling back on _BIF

ACPI 4.0 deprecated _BIF for battery status so some newer machines
are exporting _BIX which extends _BIF's package with a few extra
fields. When using _BIX, export the new discharge cycle count as a
sensor.

feedback from kettenis and anton
ok deraadt

try to attach acpisbs first and if successful, don't attach acpibat

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

remove uneeded proc.h includes
ok mpi@ kspillner@

Expose bif_capacity as the 'design capacity' through an acpibat sensor,
giving you the original capacity of the battery:

hw.sensors.acpibat0.watthour0=64.07 Wh (last full capacity)
hw.sensors.acpibat0.watthour4=84.24 Wh (design capacity)

hw.sensors.acpibat0.amphour0=2.03 Ah (last full capacity)
hw.sensors.acpibat0.amphour4=4.40 Ah (design capacity)

Diff from Fabian Raetz on tech@, thanks!

ok mlarkin@ zhuk@ armani@ kettenis@

Provide battery charge/discharge rate in proper units.

Based on a diff from Vladimir Kirrillov.

The acpibat(4) notify function should not unconditionally call both _BIF
and _BST. Some machines (like the Toshiba Satellite Pro U550 18F mentioned
in PR 6508) have AML that does a Notify(0x81) from the _BST method, which leads
to infinite recursion. Instead call _BIF when the argument is 0x81 and call
_BST when the argument is 0x80 or 0x00 (the latter indicates we're polling).
Simplify the battery detection logic while there.

ok mikeb@, marco@

Generate power change events for APM. Makes powerup and powerdown scripts
work with ACPI.
ok deraadt@, phessler@, feedback kettenis@

spacing and indents that are driving me crazy

Reporting battery insert/removal was debug code. dmesg is not
a place to spam informational messages about unimportant events.
That is what the sensor framework is for (and that is already
done)
ok kettenis

More aml_evalinteger fixup
ok marco@

Collapse all sanity checks of hids into one function.

Originaly from jordan

add missing semicolon; ok mbalmer@, marco@

Fix spurious 0 values on batteries seen on laptopts that have an embedded
controller.

Found, diagnosed and patch from Stefan Sperling <stsp@stsp.name>
Minor KNF changes while here.

Tested by many on a variaty of IBM laptops and others with and without
acpiec.

ok deraadt

Properly handle battery insertion/removal
ok @marco

Re-enable new parser. Lots of testing by various folks. Fits all media
now too.

ok kettenis deraadt

back out jordans new parser.

it didnt have enough oks from the right people, it did break machines
that were previously working, and it bloated the RAMDISKS and install
media beyond the constraints of the media.

requested by deraadt@

Adding new ACPI Parser code
Old guts of code still exists, needs to be torn out next
ok marco@
ok brad@

quotes around model name too

spacing

spacing

only print bif info that is complete

convert the value to a string instead of using aml_val2str()
which returns invalid pointers if the value is not a string, causing
acpibat to panic, as reported by mbalmer@ and Alexey Suslikov.
tested by Alexey Suslikov, ok marco@

repair attach messages; ok gwk canacar

Use aml_val2int() instead of accessing v_integer directly.

`sort of ok' marco (before lock)

Since a full battery can still have state BST_CHARGE ("charging"),
fullness needs to be checked first. Otherwise, full batteries are
always described as "charging."

ok marco

Do the sensor magic correctly. Found by Constantine Murenin.
help from mickey

Add polling to devices that require it such as acpibat and acpitz.
Use the same tsleep/wakeup mechanism as the interrupt code to keep it non-
concurrent.

adapt to new two-level sensor api; Constantine A. Murenin

even more knf love

Tweak to report full battery.

more minor knf

Fix silly logic errors.

Silence acpibat significantly and shave off about 1k. Also add some smarts
for battery removal and insertion.

After a long debate at the hackathon it was decided that the acpi implementation
is not concurrent if the sensors thread goes away. This makes acpi completly
lockless.

help and ok dlg

Reduce the scope of the locks.

KNF and some cleanup

Replace ACPI ioctls with APM ioctls. This makes ACPI talk the same protocol
as APM therefore userspace can now retrieve power information in the same
fashion as all other apm arches (zaurus, macppc, i386 etc).

To use force the use of acpi device like so: apmd -f /dev/acpi

ok jordan@

Fix capacity calculations. Tested on Dell C610, D810, Lenovo X60s.

ok jordan

Massive ACPI changes
Fixed ACPI leaks
new ACPI API
ok marco@

Typo fixes.

ok marco

fix a bad strlcpy, from ben lovett

Use rwlock instead of lockmgr locks.
ok marco@

rv not set. Sloppy but didn't matter.
pointed out by joris@

KNF nit.

Rework notify handler.
Use jordan's new notify register function.
ok jordan@

Add insertion and removal events for batteries.
Some cleanup & KNF.

KNF

Adjust debugging levels to something more reasonable.

Better comments.

Propogate some values through the sysctl hw.sesnsors interface for debug
purposes. This will be removed later and replaced with something better.

Detect if battery slot is available but without a battery in it.

ok jordan

Print useful information during boot about the battery and power supply.

ok jordan.

Adjust debug levels to something sane.

Rewrote aml parser yet again...
Fixed bus_space_map for i386/amd64
Added _BST and _BIF to acpibat to get status/info
ok marco@

Major overhaul of the aml parser. Evaluater temporarily disabled.

ok marco@

Sudden newline

make ACPI_DEBUG compile

oops enabled a method that doesnt work yet so disabled getbif for now.
ok jordan@

Add some return values to getbst and getbif.
ok jordan@

Add 2 methods (Battery Info and Battery Status)
ok jordan@

Use new unified header.

Use shiny new acpibat.h

Add battery device.

acpi: clean up some inconsistent style in the hid matching arrays

ok millert, kettenis, jcs, phessler, deraadt, mpi

Don't require exactly 20 elements in the _BIX package if at least 20
are returned since extras may be OEM-specific values we end up
ignoring anyway, such as on the Lenovo X1C 5th Gen which returns 21
elements.

ok mpi

fallback on _BIF properly when _BIX exists and returns a package
successfully but has an unexpected length, as on the X1C gen 5

tested by naddy

acpibat: look for _BIX first before falling back on _BIF

ACPI 4.0 deprecated _BIF for battery status so some newer machines
are exporting _BIX which extends _BIF's package with a few extra
fields. When using _BIX, export the new discharge cycle count as a
sensor.

feedback from kettenis and anton
ok deraadt

try to attach acpisbs first and if successful, don't attach acpibat

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

remove uneeded proc.h includes
ok mpi@ kspillner@

Expose bif_capacity as the 'design capacity' through an acpibat sensor,
giving you the original capacity of the battery:

hw.sensors.acpibat0.watthour0=64.07 Wh (last full capacity)
hw.sensors.acpibat0.watthour4=84.24 Wh (design capacity)

hw.sensors.acpibat0.amphour0=2.03 Ah (last full capacity)
hw.sensors.acpibat0.amphour4=4.40 Ah (design capacity)

Diff from Fabian Raetz on tech@, thanks!

ok mlarkin@ zhuk@ armani@ kettenis@

Provide battery charge/discharge rate in proper units.

Based on a diff from Vladimir Kirrillov.

The acpibat(4) notify function should not unconditionally call both _BIF
and _BST. Some machines (like the Toshiba Satellite Pro U550 18F mentioned
in PR 6508) have AML that does a Notify(0x81) from the _BST method, which leads
to infinite recursion. Instead call _BIF when the argument is 0x81 and call
_BST when the argument is 0x80 or 0x00 (the latter indicates we're polling).
Simplify the battery detection logic while there.

ok mikeb@, marco@

Generate power change events for APM. Makes powerup and powerdown scripts
work with ACPI.
ok deraadt@, phessler@, feedback kettenis@

spacing and indents that are driving me crazy

Reporting battery insert/removal was debug code. dmesg is not
a place to spam informational messages about unimportant events.
That is what the sensor framework is for (and that is already
done)
ok kettenis

More aml_evalinteger fixup
ok marco@

Collapse all sanity checks of hids into one function.

Originaly from jordan

add missing semicolon; ok mbalmer@, marco@

Fix spurious 0 values on batteries seen on laptopts that have an embedded
controller.

Found, diagnosed and patch from Stefan Sperling <stsp@stsp.name>
Minor KNF changes while here.

Tested by many on a variaty of IBM laptops and others with and without
acpiec.

ok deraadt

Properly handle battery insertion/removal
ok @marco

Re-enable new parser. Lots of testing by various folks. Fits all media
now too.

ok kettenis deraadt

back out jordans new parser.

it didnt have enough oks from the right people, it did break machines
that were previously working, and it bloated the RAMDISKS and install
media beyond the constraints of the media.

requested by deraadt@

Adding new ACPI Parser code
Old guts of code still exists, needs to be torn out next
ok marco@
ok brad@

quotes around model name too

spacing

spacing

only print bif info that is complete

convert the value to a string instead of using aml_val2str()
which returns invalid pointers if the value is not a string, causing
acpibat to panic, as reported by mbalmer@ and Alexey Suslikov.
tested by Alexey Suslikov, ok marco@

repair attach messages; ok gwk canacar

Use aml_val2int() instead of accessing v_integer directly.

`sort of ok' marco (before lock)

Since a full battery can still have state BST_CHARGE ("charging"),
fullness needs to be checked first. Otherwise, full batteries are
always described as "charging."

ok marco

Do the sensor magic correctly. Found by Constantine Murenin.
help from mickey

Add polling to devices that require it such as acpibat and acpitz.
Use the same tsleep/wakeup mechanism as the interrupt code to keep it non-
concurrent.

adapt to new two-level sensor api; Constantine A. Murenin

even more knf love

Tweak to report full battery.

more minor knf

Fix silly logic errors.

Silence acpibat significantly and shave off about 1k. Also add some smarts
for battery removal and insertion.

After a long debate at the hackathon it was decided that the acpi implementation
is not concurrent if the sensors thread goes away. This makes acpi completly
lockless.

help and ok dlg

Reduce the scope of the locks.

KNF and some cleanup

Replace ACPI ioctls with APM ioctls. This makes ACPI talk the same protocol
as APM therefore userspace can now retrieve power information in the same
fashion as all other apm arches (zaurus, macppc, i386 etc).

To use force the use of acpi device like so: apmd -f /dev/acpi

ok jordan@

Fix capacity calculations. Tested on Dell C610, D810, Lenovo X60s.

ok jordan

Massive ACPI changes
Fixed ACPI leaks
new ACPI API
ok marco@

Typo fixes.

ok marco

fix a bad strlcpy, from ben lovett

Use rwlock instead of lockmgr locks.
ok marco@

rv not set. Sloppy but didn't matter.
pointed out by joris@

KNF nit.

Rework notify handler.
Use jordan's new notify register function.
ok jordan@

Add insertion and removal events for batteries.
Some cleanup & KNF.

KNF

Adjust debugging levels to something more reasonable.

Better comments.

Propogate some values through the sysctl hw.sesnsors interface for debug
purposes. This will be removed later and replaced with something better.

Detect if battery slot is available but without a battery in it.

ok jordan

Print useful information during boot about the battery and power supply.

ok jordan.

Adjust debug levels to something sane.

Rewrote aml parser yet again...
Fixed bus_space_map for i386/amd64
Added _BST and _BIF to acpibat to get status/info
ok marco@

Major overhaul of the aml parser. Evaluater temporarily disabled.

ok marco@

Sudden newline

make ACPI_DEBUG compile

oops enabled a method that doesnt work yet so disabled getbif for now.
ok jordan@

Add some return values to getbst and getbif.
ok jordan@

Add 2 methods (Battery Info and Battery Status)
ok jordan@

Use new unified header.

Use shiny new acpibat.h

Add battery device.

Don't require exactly 20 elements in the _BIX package if at least 20
are returned since extras may be OEM-specific values we end up
ignoring anyway, such as on the Lenovo X1C 5th Gen which returns 21
elements.

ok mpi

fallback on _BIF properly when _BIX exists and returns a package
successfully but has an unexpected length, as on the X1C gen 5

tested by naddy

acpibat: look for _BIX first before falling back on _BIF

ACPI 4.0 deprecated _BIF for battery status so some newer machines
are exporting _BIX which extends _BIF's package with a few extra
fields. When using _BIX, export the new discharge cycle count as a
sensor.

feedback from kettenis and anton
ok deraadt

try to attach acpisbs first and if successful, don't attach acpibat

Remove some includes include-what-you-use claims don't
have any direct symbols used. Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

remove uneeded proc.h includes
ok mpi@ kspillner@

Expose bif_capacity as the 'design capacity' through an acpibat sensor,
giving you the original capacity of the battery:

hw.sensors.acpibat0.watthour0=64.07 Wh (last full capacity)
hw.sensors.acpibat0.watthour4=84.24 Wh (design capacity)

hw.sensors.acpibat0.amphour0=2.03 Ah (last full capacity)
hw.sensors.acpibat0.amphour4=4.40 Ah (design capacity)

Diff from Fabian Raetz on tech@, thanks!

ok mlarkin@ zhuk@ armani@ kettenis@

Provide battery charge/discharge rate in proper units.

Based on a diff from Vladimir Kirrillov.

The acpibat(4) notify function should not unconditionally call both _BIF
and _BST. Some machines (like the Toshiba Satellite Pro U550 18F mentioned
in PR 6508) have AML that does a Notify(0x81) from the _BST method, which leads
to infinite recursion. Instead call _BIF when the argument is 0x81 and call
_BST when the argument is 0x80 or 0x00 (the latter indicates we're polling).
Simplify the battery detection logic while there.

ok mikeb@, marco@

Generate power change events for APM. Makes powerup and powerdown scripts
work with ACPI.
ok deraadt@, phessler@, feedback kettenis@

spacing and indents that are driving me crazy

Reporting battery insert/removal was debug code. dmesg is not
a place to spam informational messages about unimportant events.
That is what the sensor framework is for (and that is already
done)
ok kettenis

More aml_evalinteger fixup
ok marco@

Collapse all sanity checks of hids into one function.

Originaly from jordan

add missing semicolon; ok mbalmer@, marco@

Fix spurious 0 values on batteries seen on laptopts that have an embedded
controller.

Found, diagnosed and patch from Stefan Sperling <stsp@stsp.name>
Minor KNF changes while here.

Tested by many on a variaty of IBM laptops and others with and without
acpiec.

ok deraadt

Properly handle battery insertion/removal
ok @marco

Re-enable new parser. Lots of testing by various folks. Fits all media
now too.

ok kettenis deraadt

back out jordans new parser.

it didnt have enough oks from the right people, it did break machines
that were previously working, and it bloated the RAMDISKS and install
media beyond the constraints of the media.

requested by deraadt@

Adding new ACPI Parser code
Old guts of code still exists, needs to be torn out next
ok marco@
ok brad@

quotes around model name too

spacing

spacing

only print bif info that is complete

convert the value to a string instead of using aml_val2str()
which returns invalid pointers if the value is not a string, causing
acpibat to panic, as reported by mbalmer@ and Alexey Suslikov.
tested by Alexey Suslikov, ok marco@

repair attach messages; ok gwk canacar

Use aml_val2int() instead of accessing v_integer directly.

`sort of ok' marco (before lock)

Since a full battery can still have state BST_CHARGE ("charging"),
fullness needs to be checked first. Otherwise, full batteries are
always described as "charging."

ok marco

Do the sensor magic correctly. Found by Constantine Murenin.
help from mickey

Add polling to devices that require it such as acpibat and acpitz.
Use the same tsleep/wakeup mechanism as the interrupt code to keep it non-
concurrent.

adapt to new two-level sensor api; Constantine A. Murenin

even more knf love

Tweak to report full battery.

more minor knf

Fix silly logic errors.

Silence acpibat significantly and shave off about 1k. Also add some smarts
for battery removal and insertion.

After a long debate at the hackathon it was decided that the acpi implementation
is not concurrent if the sensors thread goes away. This makes acpi completly
lockless.

help and ok dlg

Reduce the scope of the locks.

KNF and some cleanup

Replace ACPI ioctls with APM ioctls. This makes ACPI talk the same protocol
as APM therefore userspace can now retrieve power information in the same
fashion as all other apm arches (zaurus, macppc, i386 etc).

To use force the use of acpi device like so: apmd -f /dev/acpi

ok jordan@

Fix capacity calculations. Tested on Dell C610, D810, Lenovo X60s.

ok jordan

Massive ACPI changes
Fixed ACPI leaks
new ACPI API
ok marco@

Typo fixes.

ok marco

fix a bad strlcpy, from ben lovett

Use rwlock instead of lockmgr locks.
ok marco@

rv not set. Sloppy but didn't matter.
pointed out by joris@

KNF nit.

Rework notify handler.
Use jordan's new notify register function.
ok jordan@

Add insertion and removal events for batteries.
Some cleanup & KNF.

KNF

Adjust debugging levels to something more reasonable.

Better comments.

Propogate some values through the sysctl hw.sesnsors interface for debug
purposes. This will be removed later and replaced with something better.

Detect if battery slot is available but without a battery in it.

ok jordan

Print useful information during boot about the battery and power supply.

ok jordan.

Adjust debug levels to something sane.

Rewrote aml parser yet again...
Fixed bus_space_map for i386/amd64
Added _BST and _BIF to acpibat to get status/info
ok marco@

Major overhaul of the aml parser. Evaluater temporarily disabled.

ok marco@

Sudden newline

make ACPI_DEBUG compile

oops enabled a method that doesnt work yet so disabled getbif for now.
ok jordan@

Add some return values to getbst and getbif.
ok jordan@

Add 2 methods (Battery Info and Battery Status)
ok jordan@

Use new unified header.

Use shiny new acpibat.h

Add battery device.