remove prototypes with no matching function and externs with no var

with empty body loops, put final semicolon on a new line for readability
ok bluhm@ jca@

Make audio(9) get_props() optional, remove it from duplex drivers

The property bits of audio(9) are obsolete and ought to be removed
completely.

sys/dev/audio.c:audio_open() currently uses get_props() to bail out if
read *and* write was requested on a non-duplex driver.

Drivers that currently support playing but not recording need adjustment
before the API can be cleaned up.

Drivers that advertise themselves as full duplex, i.e. those that always
return AUDIO_PROP_FULLDUPLEX unconditionally in their get_props() currently
always succeed this check.

As this is the only property, losen audio_open()'s DIAGNOSTIC check and only
do the duplex check if the driver provides get_props().

This allows for simple removal of get_props() from full-duplex drivers
without adding any other code or without changing functionality.

This includes all audio drivers under sys/dev/pci/ (maestro(4) being the
only unfinished exception here).

Other drivers as well as the API change can then follow in smaller diffs.

This builds on amd64, arm64, i386, macppc and sparc64.
amd64 with azalia(4) still plays, records as well as plays and records
at the same time on my X230 as tested with

$ aucat -i play.wav [-o rec.wav]

alpha and hppa tests by miod
OK ratchov miod

Remove unused AUDIO_PROP_{MMAP,INDEPENDENT}

AUDIO_PROP_FULLDUPLEX is the only audio(9) in use, the other two died with
commit 1cf2860827c8ca659d8097d8da94a5ae5b888c53
Author: ratchov <ratchov@openbsd.org>
Date: Thu Jun 25 06:43:45 2015 +0000

Reimplement the audio driver in a simpler way, removing unused/unusable
functionality. Same API and ABI except for the removed bits and no
behaviour change for programs using libsndio. With help from armani@
and mpi@, thanks.

but remained defined and set in drivers.

and the following merely moved them when they were dead code already:

commit 9215aa3dfad387bca877a805534df6dcfe8722eb
Author: ratchov <ratchov@openbsd.org>
Date: Wed Aug 31 07:22:43 2016 +0000

Delete unused ioctls and associated macros. Move macros that are still
used internally by low-level drivers from sys/audioio.h to
dev/audio_if.h instead of deleting them.

None of this is used in base or ports; codesearch.debian.net only shows
AUDIO_PROP_{CAPTURE,PLAYBACK} in firefox-esr, mozjs and cubeb.

ratchov points out that audio_if.h and audioio.h are private interfaces
and the codesearch shows SunOS and NetBSD bits (#ifdef'd out on OpenBSD).

OK ratchov

ansi

Remove drain(), query_encoding(), mappage() and get_default_params()
methods from all audio drivers and from the audio_if structure as they
are never called.

Properly set "msb" and "bps" fields for both play and rec directions.
Fixes "audio0: different play and record parameters ... " errors, and
probably other unreported errors.

help and ok landry@

Oups, remove '#define I2S_DEBUG' again.

Make i2s compile with I2S_DEBUG; %x -> %p.

sizes for free(); ok semarie

Make sound cards work on older PowerMacs.

On such machines the device-tree contains absolute addresses for the
various sound buttons and the hardware was not properly initiliazed.

Problem reported and fix tested by Fabian Fr��d��rick.

Check for the correct bit in the interrupts property of the device-tree
to determin if interrupts should be established as edge/level triggered.

Fix audio interrupts on U4 systems. On such systems the "interrupts"
fields in the device-tree has more bits set and cannot be compared to
0.

Remove all audio format conversion code from the kernel (btw holding
the kernel_lock), as we already do better conversions in
user-mode. Yet, no need for every single driver to fiddle with the
conversion code as they are done transparently by common MI code. With
help from armani and miod, support from mpi

ok armani@

Mark audio interrupt handlers as MPSAFE, they already grab the right
mutex when necessary.

ok kettenis@, ratchov@

Work around broken device-tree in PowerMac7,2 and PowerMac7,3 (K2 systems)
and get the correct offsets from the "i2s" node. Also explicitly enable
the clock in FCR1 as the firmware does not do it on such machine.

Still not enough to get the sound working in such systems but get rid of
the annoying "i2s_set_rate: timeout" message during boot and plugging an
headphone is now correctly detected.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Introduce a global interrupt-aware mutex protecting data
structures (including sound-card registers) from concurent
access by syscall and interrupt code-paths. Since critical
sections remain the same, calls to splraise/spllower can be
safely replaced by calls to mtx_enter/mtx_leave with two
exceptions: (1) mutexes are not reentrant (the inner splraise
is thus removed), and (2) we're not allowed to sleep with a
mutex (either msleep is used or the mutex is released before
sleeping).

ok and help from kettenis, a lot of work from armani

Make use of macobio_* methods to manage the i2s GPIOs, remove the customs
gpio_* methods and move the remaining global variables in the softc.

ok ratchov@, krw@

Unify various gpio access using methods that take an offset relative to the
mac-io bus base address. Needed by upcoming dfs(4) support.

On some Apple machines, the openfirmware returns a gpio offset relative to
the gpio controller (generaly at 0x50). These offsets should be corrected
to be relative to the bus base address.

looks fine to kettenis@, ok miod@

add support for muting the master channel on i2s based cards, this allows the
"mute" key on keyboards to function too.
tested by kettenis on aoa(4) and snapper(4) by me.

from Martin Pieuchot
ok kettenis@ ratchov@

fix volume up and down using the keyboard keys

from Martin Pieuchot
ok ratchov@

add two new members to structs audio_encoding and audio_prinfo.
for both structs, the new members are 'bps' and 'msb', which
describe the number of bytes per sample and data alignment in the
sample, respectively. drivers must properly set these fields in
the 'query_encoding', 'set_parameters' and 'get_default_params'
hardware interface methods.

discussed with ratchov, deraadt

different fix for pr5883 than proposed by the submitter, found when glancing
at apple code
go ahead drahn@

return an error when trying to get stereo values from a mono
control. makes mixerctl(1) output more sensible.

ok drahn, todd

patches for macppc to remove more EINVAL returns in the audio code
tested by me, from ratchov@, please commit ratchov@

come on -- this was not even test compiled

native default parameters for i2s devices instead of 8kHz
mulaw mono, which few can even do.

"Please just get this in." brad@

o implement proper volume control table based on chipset docs
o attempt to make record work (but silence for now)
from drahn@, ok maja@, drahn@

remove support for 8kHz sample rates. not all i2s based audio
devices support 8kHz sample rates, and there is insufficient
code to enable it properly on the devices that do support 8kHz.

fixes "evil sound" problem reported by ajacoutot@ and jdixon@.

ok deanna@, ratchov@, ajacoutot@

audio encoding conversion cleanup

- the endianness of the conversions don't depend on the endianness
of machine the conversions are built on, but the endianness of the
audio data itself. choose encoding conversions explicitly, instead
of relying on #defines based on the endianness of the machine.
- replace home-grown conversions with comparable conversions in
auconv.c and mulaw.c
- use the proper conversion for ulinear_be:16 -> slinear_le:16 in
auixp(4)

thanks ajacoutot@ and sthen@ for !x86 testing

Only the most obvious bzero() -> M_ZERO changes. No cast changes, no
MALLOC/FREE, etc. Just adding M_ZERO to malloc() and deleting an
immediately adjacent bzero().

better interrupt names for vmstat -iz; ok miod gwk

Add blinkenlights(4) a driver to control the 16 leds found on the front
panel of the Xserve G4 and G5. The leds will provide an indication of the
system load slowing as the load climbs, and system health e.g. no
lights means its dead or in DDB.

Split some of the shared registers and clock divisors from i2s into
i2sreg.h while there nuke some evil C++ style comments.
Man page to follow shortly.

ok deraadt

Don't provide bass and treble mixer controls if the underlying hardware doesn't
provide these. Put them in the outputs class.
ok joris@

Fix mixer for machines that have lineout and/or don't have headphone.
ok joris@

Get device resources from soundbus node instead of i2s node. This makes sound
work on the iMac G5, and should work on older systems too.
tested by cloder@, miod@; ok brad@

fix mixer control names.

i2s.c diff from Tsubai Masanari's CVS repo.

ok joris@

- add needed bass & treble glue in i2s;
- add support for bass & treble in snapper;

ok drahn@

add an i2s framework, which can be reused in new audio drivers
for macppc, as most modern Apple machines have i2s-based audio.

also let snapper use i2s.c right away;

tested by Antoine Jacoutot, drahn@ and kettenis@
"yes, commit!" drahn@, ok kettenis@

with empty body loops, put final semicolon on a new line for readability
ok bluhm@ jca@

Make audio(9) get_props() optional, remove it from duplex drivers

The property bits of audio(9) are obsolete and ought to be removed
completely.

sys/dev/audio.c:audio_open() currently uses get_props() to bail out if
read *and* write was requested on a non-duplex driver.

Drivers that currently support playing but not recording need adjustment
before the API can be cleaned up.

Drivers that advertise themselves as full duplex, i.e. those that always
return AUDIO_PROP_FULLDUPLEX unconditionally in their get_props() currently
always succeed this check.

As this is the only property, losen audio_open()'s DIAGNOSTIC check and only
do the duplex check if the driver provides get_props().

This allows for simple removal of get_props() from full-duplex drivers
without adding any other code or without changing functionality.

This includes all audio drivers under sys/dev/pci/ (maestro(4) being the
only unfinished exception here).

Other drivers as well as the API change can then follow in smaller diffs.

This builds on amd64, arm64, i386, macppc and sparc64.
amd64 with azalia(4) still plays, records as well as plays and records
at the same time on my X230 as tested with

$ aucat -i play.wav [-o rec.wav]

alpha and hppa tests by miod
OK ratchov miod

Remove unused AUDIO_PROP_{MMAP,INDEPENDENT}

AUDIO_PROP_FULLDUPLEX is the only audio(9) in use, the other two died with
commit 1cf2860827c8ca659d8097d8da94a5ae5b888c53
Author: ratchov <ratchov@openbsd.org>
Date: Thu Jun 25 06:43:45 2015 +0000

Reimplement the audio driver in a simpler way, removing unused/unusable
functionality. Same API and ABI except for the removed bits and no
behaviour change for programs using libsndio. With help from armani@
and mpi@, thanks.

but remained defined and set in drivers.

and the following merely moved them when they were dead code already:

commit 9215aa3dfad387bca877a805534df6dcfe8722eb
Author: ratchov <ratchov@openbsd.org>
Date: Wed Aug 31 07:22:43 2016 +0000

Delete unused ioctls and associated macros. Move macros that are still
used internally by low-level drivers from sys/audioio.h to
dev/audio_if.h instead of deleting them.

None of this is used in base or ports; codesearch.debian.net only shows
AUDIO_PROP_{CAPTURE,PLAYBACK} in firefox-esr, mozjs and cubeb.

ratchov points out that audio_if.h and audioio.h are private interfaces
and the codesearch shows SunOS and NetBSD bits (#ifdef'd out on OpenBSD).

OK ratchov

ansi

Remove drain(), query_encoding(), mappage() and get_default_params()
methods from all audio drivers and from the audio_if structure as they
are never called.

Properly set "msb" and "bps" fields for both play and rec directions.
Fixes "audio0: different play and record parameters ... " errors, and
probably other unreported errors.

help and ok landry@

Oups, remove '#define I2S_DEBUG' again.

Make i2s compile with I2S_DEBUG; %x -> %p.

sizes for free(); ok semarie

Make sound cards work on older PowerMacs.

On such machines the device-tree contains absolute addresses for the
various sound buttons and the hardware was not properly initiliazed.

Problem reported and fix tested by Fabian Fr��d��rick.

Check for the correct bit in the interrupts property of the device-tree
to determin if interrupts should be established as edge/level triggered.

Fix audio interrupts on U4 systems. On such systems the "interrupts"
fields in the device-tree has more bits set and cannot be compared to
0.

Remove all audio format conversion code from the kernel (btw holding
the kernel_lock), as we already do better conversions in
user-mode. Yet, no need for every single driver to fiddle with the
conversion code as they are done transparently by common MI code. With
help from armani and miod, support from mpi

ok armani@

Mark audio interrupt handlers as MPSAFE, they already grab the right
mutex when necessary.

ok kettenis@, ratchov@

Work around broken device-tree in PowerMac7,2 and PowerMac7,3 (K2 systems)
and get the correct offsets from the "i2s" node. Also explicitly enable
the clock in FCR1 as the firmware does not do it on such machine.

Still not enough to get the sound working in such systems but get rid of
the annoying "i2s_set_rate: timeout" message during boot and plugging an
headphone is now correctly detected.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Introduce a global interrupt-aware mutex protecting data
structures (including sound-card registers) from concurent
access by syscall and interrupt code-paths. Since critical
sections remain the same, calls to splraise/spllower can be
safely replaced by calls to mtx_enter/mtx_leave with two
exceptions: (1) mutexes are not reentrant (the inner splraise
is thus removed), and (2) we're not allowed to sleep with a
mutex (either msleep is used or the mutex is released before
sleeping).

ok and help from kettenis, a lot of work from armani

Make use of macobio_* methods to manage the i2s GPIOs, remove the customs
gpio_* methods and move the remaining global variables in the softc.

ok ratchov@, krw@

Unify various gpio access using methods that take an offset relative to the
mac-io bus base address. Needed by upcoming dfs(4) support.

On some Apple machines, the openfirmware returns a gpio offset relative to
the gpio controller (generaly at 0x50). These offsets should be corrected
to be relative to the bus base address.

looks fine to kettenis@, ok miod@

add support for muting the master channel on i2s based cards, this allows the
"mute" key on keyboards to function too.
tested by kettenis on aoa(4) and snapper(4) by me.

from Martin Pieuchot
ok kettenis@ ratchov@

fix volume up and down using the keyboard keys

from Martin Pieuchot
ok ratchov@

add two new members to structs audio_encoding and audio_prinfo.
for both structs, the new members are 'bps' and 'msb', which
describe the number of bytes per sample and data alignment in the
sample, respectively. drivers must properly set these fields in
the 'query_encoding', 'set_parameters' and 'get_default_params'
hardware interface methods.

discussed with ratchov, deraadt

different fix for pr5883 than proposed by the submitter, found when glancing
at apple code
go ahead drahn@

return an error when trying to get stereo values from a mono
control. makes mixerctl(1) output more sensible.

ok drahn, todd

patches for macppc to remove more EINVAL returns in the audio code
tested by me, from ratchov@, please commit ratchov@

come on -- this was not even test compiled

native default parameters for i2s devices instead of 8kHz
mulaw mono, which few can even do.

"Please just get this in." brad@

o implement proper volume control table based on chipset docs
o attempt to make record work (but silence for now)
from drahn@, ok maja@, drahn@

remove support for 8kHz sample rates. not all i2s based audio
devices support 8kHz sample rates, and there is insufficient
code to enable it properly on the devices that do support 8kHz.

fixes "evil sound" problem reported by ajacoutot@ and jdixon@.

ok deanna@, ratchov@, ajacoutot@

audio encoding conversion cleanup

- the endianness of the conversions don't depend on the endianness
of machine the conversions are built on, but the endianness of the
audio data itself. choose encoding conversions explicitly, instead
of relying on #defines based on the endianness of the machine.
- replace home-grown conversions with comparable conversions in
auconv.c and mulaw.c
- use the proper conversion for ulinear_be:16 -> slinear_le:16 in
auixp(4)

thanks ajacoutot@ and sthen@ for !x86 testing

Only the most obvious bzero() -> M_ZERO changes. No cast changes, no
MALLOC/FREE, etc. Just adding M_ZERO to malloc() and deleting an
immediately adjacent bzero().

better interrupt names for vmstat -iz; ok miod gwk

Add blinkenlights(4) a driver to control the 16 leds found on the front
panel of the Xserve G4 and G5. The leds will provide an indication of the
system load slowing as the load climbs, and system health e.g. no
lights means its dead or in DDB.

Split some of the shared registers and clock divisors from i2s into
i2sreg.h while there nuke some evil C++ style comments.
Man page to follow shortly.

ok deraadt

Don't provide bass and treble mixer controls if the underlying hardware doesn't
provide these. Put them in the outputs class.
ok joris@

Fix mixer for machines that have lineout and/or don't have headphone.
ok joris@

Get device resources from soundbus node instead of i2s node. This makes sound
work on the iMac G5, and should work on older systems too.
tested by cloder@, miod@; ok brad@

fix mixer control names.

i2s.c diff from Tsubai Masanari's CVS repo.

ok joris@

- add needed bass & treble glue in i2s;
- add support for bass & treble in snapper;

ok drahn@

add an i2s framework, which can be reused in new audio drivers
for macppc, as most modern Apple machines have i2s-based audio.

also let snapper use i2s.c right away;

tested by Antoine Jacoutot, drahn@ and kettenis@
"yes, commit!" drahn@, ok kettenis@

Make audio(9) get_props() optional, remove it from duplex drivers

The property bits of audio(9) are obsolete and ought to be removed
completely.

sys/dev/audio.c:audio_open() currently uses get_props() to bail out if
read *and* write was requested on a non-duplex driver.

Drivers that currently support playing but not recording need adjustment
before the API can be cleaned up.

Drivers that advertise themselves as full duplex, i.e. those that always
return AUDIO_PROP_FULLDUPLEX unconditionally in their get_props() currently
always succeed this check.

As this is the only property, losen audio_open()'s DIAGNOSTIC check and only
do the duplex check if the driver provides get_props().

This allows for simple removal of get_props() from full-duplex drivers
without adding any other code or without changing functionality.

This includes all audio drivers under sys/dev/pci/ (maestro(4) being the
only unfinished exception here).

Other drivers as well as the API change can then follow in smaller diffs.

This builds on amd64, arm64, i386, macppc and sparc64.
amd64 with azalia(4) still plays, records as well as plays and records
at the same time on my X230 as tested with

$ aucat -i play.wav [-o rec.wav]

alpha and hppa tests by miod
OK ratchov miod

Remove unused AUDIO_PROP_{MMAP,INDEPENDENT}

AUDIO_PROP_FULLDUPLEX is the only audio(9) in use, the other two died with
commit 1cf2860827c8ca659d8097d8da94a5ae5b888c53
Author: ratchov <ratchov@openbsd.org>
Date: Thu Jun 25 06:43:45 2015 +0000

Reimplement the audio driver in a simpler way, removing unused/unusable
functionality. Same API and ABI except for the removed bits and no
behaviour change for programs using libsndio. With help from armani@
and mpi@, thanks.

but remained defined and set in drivers.

and the following merely moved them when they were dead code already:

commit 9215aa3dfad387bca877a805534df6dcfe8722eb
Author: ratchov <ratchov@openbsd.org>
Date: Wed Aug 31 07:22:43 2016 +0000

Delete unused ioctls and associated macros. Move macros that are still
used internally by low-level drivers from sys/audioio.h to
dev/audio_if.h instead of deleting them.

None of this is used in base or ports; codesearch.debian.net only shows
AUDIO_PROP_{CAPTURE,PLAYBACK} in firefox-esr, mozjs and cubeb.

ratchov points out that audio_if.h and audioio.h are private interfaces
and the codesearch shows SunOS and NetBSD bits (#ifdef'd out on OpenBSD).

OK ratchov

ansi

Remove drain(), query_encoding(), mappage() and get_default_params()
methods from all audio drivers and from the audio_if structure as they
are never called.

Properly set "msb" and "bps" fields for both play and rec directions.
Fixes "audio0: different play and record parameters ... " errors, and
probably other unreported errors.

help and ok landry@

Oups, remove '#define I2S_DEBUG' again.

Make i2s compile with I2S_DEBUG; %x -> %p.

sizes for free(); ok semarie

Make sound cards work on older PowerMacs.

On such machines the device-tree contains absolute addresses for the
various sound buttons and the hardware was not properly initiliazed.

Problem reported and fix tested by Fabian Fr��d��rick.

Check for the correct bit in the interrupts property of the device-tree
to determin if interrupts should be established as edge/level triggered.

Fix audio interrupts on U4 systems. On such systems the "interrupts"
fields in the device-tree has more bits set and cannot be compared to
0.

Remove all audio format conversion code from the kernel (btw holding
the kernel_lock), as we already do better conversions in
user-mode. Yet, no need for every single driver to fiddle with the
conversion code as they are done transparently by common MI code. With
help from armani and miod, support from mpi

ok armani@

Mark audio interrupt handlers as MPSAFE, they already grab the right
mutex when necessary.

ok kettenis@, ratchov@

Work around broken device-tree in PowerMac7,2 and PowerMac7,3 (K2 systems)
and get the correct offsets from the "i2s" node. Also explicitly enable
the clock in FCR1 as the firmware does not do it on such machine.

Still not enough to get the sound working in such systems but get rid of
the annoying "i2s_set_rate: timeout" message during boot and plugging an
headphone is now correctly detected.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Introduce a global interrupt-aware mutex protecting data
structures (including sound-card registers) from concurent
access by syscall and interrupt code-paths. Since critical
sections remain the same, calls to splraise/spllower can be
safely replaced by calls to mtx_enter/mtx_leave with two
exceptions: (1) mutexes are not reentrant (the inner splraise
is thus removed), and (2) we're not allowed to sleep with a
mutex (either msleep is used or the mutex is released before
sleeping).

ok and help from kettenis, a lot of work from armani

Make use of macobio_* methods to manage the i2s GPIOs, remove the customs
gpio_* methods and move the remaining global variables in the softc.

ok ratchov@, krw@

Unify various gpio access using methods that take an offset relative to the
mac-io bus base address. Needed by upcoming dfs(4) support.

On some Apple machines, the openfirmware returns a gpio offset relative to
the gpio controller (generaly at 0x50). These offsets should be corrected
to be relative to the bus base address.

looks fine to kettenis@, ok miod@

add support for muting the master channel on i2s based cards, this allows the
"mute" key on keyboards to function too.
tested by kettenis on aoa(4) and snapper(4) by me.

from Martin Pieuchot
ok kettenis@ ratchov@

fix volume up and down using the keyboard keys

from Martin Pieuchot
ok ratchov@

add two new members to structs audio_encoding and audio_prinfo.
for both structs, the new members are 'bps' and 'msb', which
describe the number of bytes per sample and data alignment in the
sample, respectively. drivers must properly set these fields in
the 'query_encoding', 'set_parameters' and 'get_default_params'
hardware interface methods.

discussed with ratchov, deraadt

different fix for pr5883 than proposed by the submitter, found when glancing
at apple code
go ahead drahn@

return an error when trying to get stereo values from a mono
control. makes mixerctl(1) output more sensible.

ok drahn, todd

patches for macppc to remove more EINVAL returns in the audio code
tested by me, from ratchov@, please commit ratchov@

come on -- this was not even test compiled

native default parameters for i2s devices instead of 8kHz
mulaw mono, which few can even do.

"Please just get this in." brad@

o implement proper volume control table based on chipset docs
o attempt to make record work (but silence for now)
from drahn@, ok maja@, drahn@

remove support for 8kHz sample rates. not all i2s based audio
devices support 8kHz sample rates, and there is insufficient
code to enable it properly on the devices that do support 8kHz.

fixes "evil sound" problem reported by ajacoutot@ and jdixon@.

ok deanna@, ratchov@, ajacoutot@

audio encoding conversion cleanup

- the endianness of the conversions don't depend on the endianness
of machine the conversions are built on, but the endianness of the
audio data itself. choose encoding conversions explicitly, instead
of relying on #defines based on the endianness of the machine.
- replace home-grown conversions with comparable conversions in
auconv.c and mulaw.c
- use the proper conversion for ulinear_be:16 -> slinear_le:16 in
auixp(4)

thanks ajacoutot@ and sthen@ for !x86 testing

Only the most obvious bzero() -> M_ZERO changes. No cast changes, no
MALLOC/FREE, etc. Just adding M_ZERO to malloc() and deleting an
immediately adjacent bzero().

better interrupt names for vmstat -iz; ok miod gwk

Add blinkenlights(4) a driver to control the 16 leds found on the front
panel of the Xserve G4 and G5. The leds will provide an indication of the
system load slowing as the load climbs, and system health e.g. no
lights means its dead or in DDB.

Split some of the shared registers and clock divisors from i2s into
i2sreg.h while there nuke some evil C++ style comments.
Man page to follow shortly.

ok deraadt

Don't provide bass and treble mixer controls if the underlying hardware doesn't
provide these. Put them in the outputs class.
ok joris@

Fix mixer for machines that have lineout and/or don't have headphone.
ok joris@

Get device resources from soundbus node instead of i2s node. This makes sound
work on the iMac G5, and should work on older systems too.
tested by cloder@, miod@; ok brad@

fix mixer control names.

i2s.c diff from Tsubai Masanari's CVS repo.

ok joris@

- add needed bass & treble glue in i2s;
- add support for bass & treble in snapper;

ok drahn@

add an i2s framework, which can be reused in new audio drivers
for macppc, as most modern Apple machines have i2s-based audio.

also let snapper use i2s.c right away;

tested by Antoine Jacoutot, drahn@ and kettenis@
"yes, commit!" drahn@, ok kettenis@

Remove unused AUDIO_PROP_{MMAP,INDEPENDENT}

AUDIO_PROP_FULLDUPLEX is the only audio(9) in use, the other two died with
commit 1cf2860827c8ca659d8097d8da94a5ae5b888c53
Author: ratchov <ratchov@openbsd.org>
Date: Thu Jun 25 06:43:45 2015 +0000

Reimplement the audio driver in a simpler way, removing unused/unusable
functionality. Same API and ABI except for the removed bits and no
behaviour change for programs using libsndio. With help from armani@
and mpi@, thanks.

but remained defined and set in drivers.

and the following merely moved them when they were dead code already:

commit 9215aa3dfad387bca877a805534df6dcfe8722eb
Author: ratchov <ratchov@openbsd.org>
Date: Wed Aug 31 07:22:43 2016 +0000

Delete unused ioctls and associated macros. Move macros that are still
used internally by low-level drivers from sys/audioio.h to
dev/audio_if.h instead of deleting them.

None of this is used in base or ports; codesearch.debian.net only shows
AUDIO_PROP_{CAPTURE,PLAYBACK} in firefox-esr, mozjs and cubeb.

ratchov points out that audio_if.h and audioio.h are private interfaces
and the codesearch shows SunOS and NetBSD bits (#ifdef'd out on OpenBSD).

OK ratchov

ansi

Remove drain(), query_encoding(), mappage() and get_default_params()
methods from all audio drivers and from the audio_if structure as they
are never called.

Properly set "msb" and "bps" fields for both play and rec directions.
Fixes "audio0: different play and record parameters ... " errors, and
probably other unreported errors.

help and ok landry@

Oups, remove '#define I2S_DEBUG' again.

Make i2s compile with I2S_DEBUG; %x -> %p.

sizes for free(); ok semarie

Make sound cards work on older PowerMacs.

On such machines the device-tree contains absolute addresses for the
various sound buttons and the hardware was not properly initiliazed.

Problem reported and fix tested by Fabian Fr��d��rick.

Check for the correct bit in the interrupts property of the device-tree
to determin if interrupts should be established as edge/level triggered.

Fix audio interrupts on U4 systems. On such systems the "interrupts"
fields in the device-tree has more bits set and cannot be compared to
0.

Remove all audio format conversion code from the kernel (btw holding
the kernel_lock), as we already do better conversions in
user-mode. Yet, no need for every single driver to fiddle with the
conversion code as they are done transparently by common MI code. With
help from armani and miod, support from mpi

ok armani@

Mark audio interrupt handlers as MPSAFE, they already grab the right
mutex when necessary.

ok kettenis@, ratchov@

Work around broken device-tree in PowerMac7,2 and PowerMac7,3 (K2 systems)
and get the correct offsets from the "i2s" node. Also explicitly enable
the clock in FCR1 as the firmware does not do it on such machine.

Still not enough to get the sound working in such systems but get rid of
the annoying "i2s_set_rate: timeout" message during boot and plugging an
headphone is now correctly detected.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Introduce a global interrupt-aware mutex protecting data
structures (including sound-card registers) from concurent
access by syscall and interrupt code-paths. Since critical
sections remain the same, calls to splraise/spllower can be
safely replaced by calls to mtx_enter/mtx_leave with two
exceptions: (1) mutexes are not reentrant (the inner splraise
is thus removed), and (2) we're not allowed to sleep with a
mutex (either msleep is used or the mutex is released before
sleeping).

ok and help from kettenis, a lot of work from armani

Make use of macobio_* methods to manage the i2s GPIOs, remove the customs
gpio_* methods and move the remaining global variables in the softc.

ok ratchov@, krw@

Unify various gpio access using methods that take an offset relative to the
mac-io bus base address. Needed by upcoming dfs(4) support.

On some Apple machines, the openfirmware returns a gpio offset relative to
the gpio controller (generaly at 0x50). These offsets should be corrected
to be relative to the bus base address.

looks fine to kettenis@, ok miod@

add support for muting the master channel on i2s based cards, this allows the
"mute" key on keyboards to function too.
tested by kettenis on aoa(4) and snapper(4) by me.

from Martin Pieuchot
ok kettenis@ ratchov@

fix volume up and down using the keyboard keys

from Martin Pieuchot
ok ratchov@

add two new members to structs audio_encoding and audio_prinfo.
for both structs, the new members are 'bps' and 'msb', which
describe the number of bytes per sample and data alignment in the
sample, respectively. drivers must properly set these fields in
the 'query_encoding', 'set_parameters' and 'get_default_params'
hardware interface methods.

discussed with ratchov, deraadt

different fix for pr5883 than proposed by the submitter, found when glancing
at apple code
go ahead drahn@

return an error when trying to get stereo values from a mono
control. makes mixerctl(1) output more sensible.

ok drahn, todd

patches for macppc to remove more EINVAL returns in the audio code
tested by me, from ratchov@, please commit ratchov@

come on -- this was not even test compiled

native default parameters for i2s devices instead of 8kHz
mulaw mono, which few can even do.

"Please just get this in." brad@

o implement proper volume control table based on chipset docs
o attempt to make record work (but silence for now)
from drahn@, ok maja@, drahn@

remove support for 8kHz sample rates. not all i2s based audio
devices support 8kHz sample rates, and there is insufficient
code to enable it properly on the devices that do support 8kHz.

fixes "evil sound" problem reported by ajacoutot@ and jdixon@.

ok deanna@, ratchov@, ajacoutot@

audio encoding conversion cleanup

- the endianness of the conversions don't depend on the endianness
of machine the conversions are built on, but the endianness of the
audio data itself. choose encoding conversions explicitly, instead
of relying on #defines based on the endianness of the machine.
- replace home-grown conversions with comparable conversions in
auconv.c and mulaw.c
- use the proper conversion for ulinear_be:16 -> slinear_le:16 in
auixp(4)

thanks ajacoutot@ and sthen@ for !x86 testing

Only the most obvious bzero() -> M_ZERO changes. No cast changes, no
MALLOC/FREE, etc. Just adding M_ZERO to malloc() and deleting an
immediately adjacent bzero().

better interrupt names for vmstat -iz; ok miod gwk

Add blinkenlights(4) a driver to control the 16 leds found on the front
panel of the Xserve G4 and G5. The leds will provide an indication of the
system load slowing as the load climbs, and system health e.g. no
lights means its dead or in DDB.

Split some of the shared registers and clock divisors from i2s into
i2sreg.h while there nuke some evil C++ style comments.
Man page to follow shortly.

ok deraadt

Don't provide bass and treble mixer controls if the underlying hardware doesn't
provide these. Put them in the outputs class.
ok joris@

Fix mixer for machines that have lineout and/or don't have headphone.
ok joris@

Get device resources from soundbus node instead of i2s node. This makes sound
work on the iMac G5, and should work on older systems too.
tested by cloder@, miod@; ok brad@

fix mixer control names.

i2s.c diff from Tsubai Masanari's CVS repo.

ok joris@

- add needed bass & treble glue in i2s;
- add support for bass & treble in snapper;

ok drahn@

add an i2s framework, which can be reused in new audio drivers
for macppc, as most modern Apple machines have i2s-based audio.

also let snapper use i2s.c right away;

tested by Antoine Jacoutot, drahn@ and kettenis@
"yes, commit!" drahn@, ok kettenis@

ansi

Remove drain(), query_encoding(), mappage() and get_default_params()
methods from all audio drivers and from the audio_if structure as they
are never called.

Properly set "msb" and "bps" fields for both play and rec directions.
Fixes "audio0: different play and record parameters ... " errors, and
probably other unreported errors.

help and ok landry@

Oups, remove '#define I2S_DEBUG' again.

Make i2s compile with I2S_DEBUG; %x -> %p.

sizes for free(); ok semarie

Make sound cards work on older PowerMacs.

On such machines the device-tree contains absolute addresses for the
various sound buttons and the hardware was not properly initiliazed.

Problem reported and fix tested by Fabian Fr��d��rick.

Check for the correct bit in the interrupts property of the device-tree
to determin if interrupts should be established as edge/level triggered.

Fix audio interrupts on U4 systems. On such systems the "interrupts"
fields in the device-tree has more bits set and cannot be compared to
0.

Remove all audio format conversion code from the kernel (btw holding
the kernel_lock), as we already do better conversions in
user-mode. Yet, no need for every single driver to fiddle with the
conversion code as they are done transparently by common MI code. With
help from armani and miod, support from mpi

ok armani@

Mark audio interrupt handlers as MPSAFE, they already grab the right
mutex when necessary.

ok kettenis@, ratchov@

Work around broken device-tree in PowerMac7,2 and PowerMac7,3 (K2 systems)
and get the correct offsets from the "i2s" node. Also explicitly enable
the clock in FCR1 as the firmware does not do it on such machine.

Still not enough to get the sound working in such systems but get rid of
the annoying "i2s_set_rate: timeout" message during boot and plugging an
headphone is now correctly detected.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Introduce a global interrupt-aware mutex protecting data
structures (including sound-card registers) from concurent
access by syscall and interrupt code-paths. Since critical
sections remain the same, calls to splraise/spllower can be
safely replaced by calls to mtx_enter/mtx_leave with two
exceptions: (1) mutexes are not reentrant (the inner splraise
is thus removed), and (2) we're not allowed to sleep with a
mutex (either msleep is used or the mutex is released before
sleeping).

ok and help from kettenis, a lot of work from armani

Make use of macobio_* methods to manage the i2s GPIOs, remove the customs
gpio_* methods and move the remaining global variables in the softc.

ok ratchov@, krw@

Unify various gpio access using methods that take an offset relative to the
mac-io bus base address. Needed by upcoming dfs(4) support.

On some Apple machines, the openfirmware returns a gpio offset relative to
the gpio controller (generaly at 0x50). These offsets should be corrected
to be relative to the bus base address.

looks fine to kettenis@, ok miod@

add support for muting the master channel on i2s based cards, this allows the
"mute" key on keyboards to function too.
tested by kettenis on aoa(4) and snapper(4) by me.

from Martin Pieuchot
ok kettenis@ ratchov@

fix volume up and down using the keyboard keys

from Martin Pieuchot
ok ratchov@

add two new members to structs audio_encoding and audio_prinfo.
for both structs, the new members are 'bps' and 'msb', which
describe the number of bytes per sample and data alignment in the
sample, respectively. drivers must properly set these fields in
the 'query_encoding', 'set_parameters' and 'get_default_params'
hardware interface methods.

discussed with ratchov, deraadt

different fix for pr5883 than proposed by the submitter, found when glancing
at apple code
go ahead drahn@

return an error when trying to get stereo values from a mono
control. makes mixerctl(1) output more sensible.

ok drahn, todd

patches for macppc to remove more EINVAL returns in the audio code
tested by me, from ratchov@, please commit ratchov@

come on -- this was not even test compiled

native default parameters for i2s devices instead of 8kHz
mulaw mono, which few can even do.

"Please just get this in." brad@

o implement proper volume control table based on chipset docs
o attempt to make record work (but silence for now)
from drahn@, ok maja@, drahn@

remove support for 8kHz sample rates. not all i2s based audio
devices support 8kHz sample rates, and there is insufficient
code to enable it properly on the devices that do support 8kHz.

fixes "evil sound" problem reported by ajacoutot@ and jdixon@.

ok deanna@, ratchov@, ajacoutot@

audio encoding conversion cleanup

- the endianness of the conversions don't depend on the endianness
of machine the conversions are built on, but the endianness of the
audio data itself. choose encoding conversions explicitly, instead
of relying on #defines based on the endianness of the machine.
- replace home-grown conversions with comparable conversions in
auconv.c and mulaw.c
- use the proper conversion for ulinear_be:16 -> slinear_le:16 in
auixp(4)

thanks ajacoutot@ and sthen@ for !x86 testing

Only the most obvious bzero() -> M_ZERO changes. No cast changes, no
MALLOC/FREE, etc. Just adding M_ZERO to malloc() and deleting an
immediately adjacent bzero().

better interrupt names for vmstat -iz; ok miod gwk

Add blinkenlights(4) a driver to control the 16 leds found on the front
panel of the Xserve G4 and G5. The leds will provide an indication of the
system load slowing as the load climbs, and system health e.g. no
lights means its dead or in DDB.

Split some of the shared registers and clock divisors from i2s into
i2sreg.h while there nuke some evil C++ style comments.
Man page to follow shortly.

ok deraadt

Don't provide bass and treble mixer controls if the underlying hardware doesn't
provide these. Put them in the outputs class.
ok joris@

Fix mixer for machines that have lineout and/or don't have headphone.
ok joris@

Get device resources from soundbus node instead of i2s node. This makes sound
work on the iMac G5, and should work on older systems too.
tested by cloder@, miod@; ok brad@

fix mixer control names.

i2s.c diff from Tsubai Masanari's CVS repo.

ok joris@

- add needed bass & treble glue in i2s;
- add support for bass & treble in snapper;

ok drahn@

add an i2s framework, which can be reused in new audio drivers
for macppc, as most modern Apple machines have i2s-based audio.

also let snapper use i2s.c right away;

tested by Antoine Jacoutot, drahn@ and kettenis@
"yes, commit!" drahn@, ok kettenis@

Remove drain(), query_encoding(), mappage() and get_default_params()
methods from all audio drivers and from the audio_if structure as they
are never called.

Properly set "msb" and "bps" fields for both play and rec directions.
Fixes "audio0: different play and record parameters ... " errors, and
probably other unreported errors.

help and ok landry@

Oups, remove '#define I2S_DEBUG' again.

Make i2s compile with I2S_DEBUG; %x -> %p.

sizes for free(); ok semarie

Make sound cards work on older PowerMacs.

On such machines the device-tree contains absolute addresses for the
various sound buttons and the hardware was not properly initiliazed.

Problem reported and fix tested by Fabian Fr��d��rick.

Check for the correct bit in the interrupts property of the device-tree
to determin if interrupts should be established as edge/level triggered.

Fix audio interrupts on U4 systems. On such systems the "interrupts"
fields in the device-tree has more bits set and cannot be compared to
0.

Remove all audio format conversion code from the kernel (btw holding
the kernel_lock), as we already do better conversions in
user-mode. Yet, no need for every single driver to fiddle with the
conversion code as they are done transparently by common MI code. With
help from armani and miod, support from mpi

ok armani@

Mark audio interrupt handlers as MPSAFE, they already grab the right
mutex when necessary.

ok kettenis@, ratchov@

Work around broken device-tree in PowerMac7,2 and PowerMac7,3 (K2 systems)
and get the correct offsets from the "i2s" node. Also explicitly enable
the clock in FCR1 as the firmware does not do it on such machine.

Still not enough to get the sound working in such systems but get rid of
the annoying "i2s_set_rate: timeout" message during boot and plugging an
headphone is now correctly detected.

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Introduce a global interrupt-aware mutex protecting data
structures (including sound-card registers) from concurent
access by syscall and interrupt code-paths. Since critical
sections remain the same, calls to splraise/spllower can be
safely replaced by calls to mtx_enter/mtx_leave with two
exceptions: (1) mutexes are not reentrant (the inner splraise
is thus removed), and (2) we're not allowed to sleep with a
mutex (either msleep is used or the mutex is released before
sleeping).

ok and help from kettenis, a lot of work from armani

Make use of macobio_* methods to manage the i2s GPIOs, remove the customs
gpio_* methods and move the remaining global variables in the softc.

ok ratchov@, krw@

Unify various gpio access using methods that take an offset relative to the
mac-io bus base address. Needed by upcoming dfs(4) support.

On some Apple machines, the openfirmware returns a gpio offset relative to
the gpio controller (generaly at 0x50). These offsets should be corrected
to be relative to the bus base address.

looks fine to kettenis@, ok miod@

add support for muting the master channel on i2s based cards, this allows the
"mute" key on keyboards to function too.
tested by kettenis on aoa(4) and snapper(4) by me.

from Martin Pieuchot
ok kettenis@ ratchov@

fix volume up and down using the keyboard keys

from Martin Pieuchot
ok ratchov@

add two new members to structs audio_encoding and audio_prinfo.
for both structs, the new members are 'bps' and 'msb', which
describe the number of bytes per sample and data alignment in the
sample, respectively. drivers must properly set these fields in
the 'query_encoding', 'set_parameters' and 'get_default_params'
hardware interface methods.

discussed with ratchov, deraadt

different fix for pr5883 than proposed by the submitter, found when glancing
at apple code
go ahead drahn@

return an error when trying to get stereo values from a mono
control. makes mixerctl(1) output more sensible.

ok drahn, todd

patches for macppc to remove more EINVAL returns in the audio code
tested by me, from ratchov@, please commit ratchov@

come on -- this was not even test compiled

native default parameters for i2s devices instead of 8kHz
mulaw mono, which few can even do.

"Please just get this in." brad@

o implement proper volume control table based on chipset docs
o attempt to make record work (but silence for now)
from drahn@, ok maja@, drahn@

remove support for 8kHz sample rates. not all i2s based audio
devices support 8kHz sample rates, and there is insufficient
code to enable it properly on the devices that do support 8kHz.

fixes "evil sound" problem reported by ajacoutot@ and jdixon@.

ok deanna@, ratchov@, ajacoutot@

audio encoding conversion cleanup

- the endianness of the conversions don't depend on the endianness
of machine the conversions are built on, but the endianness of the
audio data itself. choose encoding conversions explicitly, instead
of relying on #defines based on the endianness of the machine.
- replace home-grown conversions with comparable conversions in
auconv.c and mulaw.c
- use the proper conversion for ulinear_be:16 -> slinear_le:16 in
auixp(4)

thanks ajacoutot@ and sthen@ for !x86 testing

Only the most obvious bzero() -> M_ZERO changes. No cast changes, no
MALLOC/FREE, etc. Just adding M_ZERO to malloc() and deleting an
immediately adjacent bzero().

better interrupt names for vmstat -iz; ok miod gwk

Add blinkenlights(4) a driver to control the 16 leds found on the front
panel of the Xserve G4 and G5. The leds will provide an indication of the
system load slowing as the load climbs, and system health e.g. no
lights means its dead or in DDB.

Split some of the shared registers and clock divisors from i2s into
i2sreg.h while there nuke some evil C++ style comments.
Man page to follow shortly.

ok deraadt

Don't provide bass and treble mixer controls if the underlying hardware doesn't
provide these. Put them in the outputs class.
ok joris@

Fix mixer for machines that have lineout and/or don't have headphone.
ok joris@

Get device resources from soundbus node instead of i2s node. This makes sound
work on the iMac G5, and should work on older systems too.
tested by cloder@, miod@; ok brad@

fix mixer control names.

i2s.c diff from Tsubai Masanari's CVS repo.

ok joris@

- add needed bass & treble glue in i2s;
- add support for bass & treble in snapper;

ok drahn@

add an i2s framework, which can be reused in new audio drivers
for macppc, as most modern Apple machines have i2s-based audio.

also let snapper use i2s.c right away;

tested by Antoine Jacoutot, drahn@ and kettenis@
"yes, commit!" drahn@, ok kettenis@