userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

Do nog segfault on malformed ttys(5) entry; ok kn@ jca@

Skip open of "network" ttys because they permanently retain the (large)
tty buffers after that.
from miod

remove some unnecessary sys/cdefs.h inclusions

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

simplify synopsis somewhat, sort options, and sync usage();

ansi

more strlcat

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Initialize path earlier so we never try to use it before it has been
initialized; from Time Pierce <twpierce@mail.bsd.uchicago.edu>

getopt(3) returns -1 when out of args, not EOF, whee!

Really set flags...

add -p for printing; cleanup error handling

update rcsid

sync to netbsd 960418

branches: 1.1.1;
Initial revision

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

Do nog segfault on malformed ttys(5) entry; ok kn@ jca@

Skip open of "network" ttys because they permanently retain the (large)
tty buffers after that.
from miod

remove some unnecessary sys/cdefs.h inclusions

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

simplify synopsis somewhat, sort options, and sync usage();

ansi

more strlcat

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Initialize path earlier so we never try to use it before it has been
initialized; from Time Pierce <twpierce@mail.bsd.uchicago.edu>

getopt(3) returns -1 when out of args, not EOF, whee!

Really set flags...

add -p for printing; cleanup error handling

update rcsid

sync to netbsd 960418

branches: 1.1.1;
Initial revision

Do nog segfault on malformed ttys(5) entry; ok kn@ jca@

Skip open of "network" ttys because they permanently retain the (large)
tty buffers after that.
from miod

remove some unnecessary sys/cdefs.h inclusions

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

simplify synopsis somewhat, sort options, and sync usage();

ansi

more strlcat

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Initialize path earlier so we never try to use it before it has been
initialized; from Time Pierce <twpierce@mail.bsd.uchicago.edu>

getopt(3) returns -1 when out of args, not EOF, whee!

Really set flags...

add -p for printing; cleanup error handling

update rcsid

sync to netbsd 960418

branches: 1.1.1;
Initial revision

Skip open of "network" ttys because they permanently retain the (large)
tty buffers after that.
from miod

remove some unnecessary sys/cdefs.h inclusions

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

simplify synopsis somewhat, sort options, and sync usage();

ansi

more strlcat

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Initialize path earlier so we never try to use it before it has been
initialized; from Time Pierce <twpierce@mail.bsd.uchicago.edu>

getopt(3) returns -1 when out of args, not EOF, whee!

Really set flags...

add -p for printing; cleanup error handling

update rcsid

sync to netbsd 960418

branches: 1.1.1;
Initial revision

remove some unnecessary sys/cdefs.h inclusions

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

simplify synopsis somewhat, sort options, and sync usage();

ansi

more strlcat

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Initialize path earlier so we never try to use it before it has been
initialized; from Time Pierce <twpierce@mail.bsd.uchicago.edu>

getopt(3) returns -1 when out of args, not EOF, whee!

Really set flags...

add -p for printing; cleanup error handling

update rcsid

sync to netbsd 960418

branches: 1.1.1;
Initial revision