Initialize rejecttype to appease static analyzers

-t has already been checked in main() and can only be "blk" or "noblk",
but static analyzers like scan-build fail to spot this. From miod@

Remove clause #3 from mrg@NetBSD license.

In May 29 2008, Matthew R. Green removed it in NetBSD:
github.com/IIJ-NetBSD/netbsd-src/commit/7ea20401d535da9996394136ef

ok deraadt@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Last parameter to execl[e]() functions *must* be cast to a pointer.
Just NULL is not good practise as NULL is theoretically allowed to
be an integer rather than a pointer.

Use (char *)NULL consistently instead of scattering a few (char *)0
and (void *)NULL into the mix.

Prompted by and probably ok deraadt@ millert@ kettenis@

Definitely ok mestre@ ratchov@

update spacing in usage(); reminded by jmc@

switch from system(3) to vfork(2)+execl(2) for invoking mount_nfs(8) when fstab
contains option for swapping to NFS files.

ok millert@

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Fix swapctl -A with DUIDs in /etc/fstab, and plug a small memory leak.
ok jsing@ (who also pointed out a DPADD tweak missing from my diff)

if no arguments given, assume a nice default; ok miod jakemsr deanna

sync swapon usage(); from Igor Zinovik

Remove dead code and fix incorrect comment. From Igor Zinovik.

handle snprintf potential -1 case

- avoid variable sized static array (from millert@)
- check for snprintf overflow
- errx -> err for strdup

commit #1000!

check strdup failure; ok anil millert

Fix inaccuracies in comments.

ansi

typo in comment.
From Sam Smith S at mSmith.net

Kill commented out stubs for swapoff.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

return from main() don't exit

Various swapctl(8) improvements:
- don't print an error message when trying to enable swap on an
already active swap point.
- better handling of -t option.
- silently ignores swap points which are neither block devices nor
regular files, and don't consider swap points not starting with /dev/
as valid block devices, when invoked with -A.

Work by deraadt@ and myself, ok millert@

PATH_MAX+1 is wrong. Not cranking libc/libc_r majors over this, since they just got cranked a little while ago. discussion with millert

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.2.2;
add rcs idents

branches: 1.1.1;
Initial revision

Remove clause #3 from mrg@NetBSD license.

In May 29 2008, Matthew R. Green removed it in NetBSD:
github.com/IIJ-NetBSD/netbsd-src/commit/7ea20401d535da9996394136ef

ok deraadt@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Last parameter to execl[e]() functions *must* be cast to a pointer.
Just NULL is not good practise as NULL is theoretically allowed to
be an integer rather than a pointer.

Use (char *)NULL consistently instead of scattering a few (char *)0
and (void *)NULL into the mix.

Prompted by and probably ok deraadt@ millert@ kettenis@

Definitely ok mestre@ ratchov@

update spacing in usage(); reminded by jmc@

switch from system(3) to vfork(2)+execl(2) for invoking mount_nfs(8) when fstab
contains option for swapping to NFS files.

ok millert@

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Fix swapctl -A with DUIDs in /etc/fstab, and plug a small memory leak.
ok jsing@ (who also pointed out a DPADD tweak missing from my diff)

if no arguments given, assume a nice default; ok miod jakemsr deanna

sync swapon usage(); from Igor Zinovik

Remove dead code and fix incorrect comment. From Igor Zinovik.

handle snprintf potential -1 case

- avoid variable sized static array (from millert@)
- check for snprintf overflow
- errx -> err for strdup

commit #1000!

check strdup failure; ok anil millert

Fix inaccuracies in comments.

ansi

typo in comment.
From Sam Smith S at mSmith.net

Kill commented out stubs for swapoff.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

return from main() don't exit

Various swapctl(8) improvements:
- don't print an error message when trying to enable swap on an
already active swap point.
- better handling of -t option.
- silently ignores swap points which are neither block devices nor
regular files, and don't consider swap points not starting with /dev/
as valid block devices, when invoked with -A.

Work by deraadt@ and myself, ok millert@

PATH_MAX+1 is wrong. Not cranking libc/libc_r majors over this, since they just got cranked a little while ago. discussion with millert

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.2.2;
add rcs idents

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Last parameter to execl[e]() functions *must* be cast to a pointer.
Just NULL is not good practise as NULL is theoretically allowed to
be an integer rather than a pointer.

Use (char *)NULL consistently instead of scattering a few (char *)0
and (void *)NULL into the mix.

Prompted by and probably ok deraadt@ millert@ kettenis@

Definitely ok mestre@ ratchov@

update spacing in usage(); reminded by jmc@

switch from system(3) to vfork(2)+execl(2) for invoking mount_nfs(8) when fstab
contains option for swapping to NFS files.

ok millert@

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Fix swapctl -A with DUIDs in /etc/fstab, and plug a small memory leak.
ok jsing@ (who also pointed out a DPADD tweak missing from my diff)

if no arguments given, assume a nice default; ok miod jakemsr deanna

sync swapon usage(); from Igor Zinovik

Remove dead code and fix incorrect comment. From Igor Zinovik.

handle snprintf potential -1 case

- avoid variable sized static array (from millert@)
- check for snprintf overflow
- errx -> err for strdup

commit #1000!

check strdup failure; ok anil millert

Fix inaccuracies in comments.

ansi

typo in comment.
From Sam Smith S at mSmith.net

Kill commented out stubs for swapoff.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

return from main() don't exit

Various swapctl(8) improvements:
- don't print an error message when trying to enable swap on an
already active swap point.
- better handling of -t option.
- silently ignores swap points which are neither block devices nor
regular files, and don't consider swap points not starting with /dev/
as valid block devices, when invoked with -A.

Work by deraadt@ and myself, ok millert@

PATH_MAX+1 is wrong. Not cranking libc/libc_r majors over this, since they just got cranked a little while ago. discussion with millert

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.2.2;
add rcs idents

branches: 1.1.1;
Initial revision

Last parameter to execl[e]() functions *must* be cast to a pointer.
Just NULL is not good practise as NULL is theoretically allowed to
be an integer rather than a pointer.

Use (char *)NULL consistently instead of scattering a few (char *)0
and (void *)NULL into the mix.

Prompted by and probably ok deraadt@ millert@ kettenis@

Definitely ok mestre@ ratchov@

update spacing in usage(); reminded by jmc@

switch from system(3) to vfork(2)+execl(2) for invoking mount_nfs(8) when fstab
contains option for swapping to NFS files.

ok millert@

Convert many atoi() calls to strtonum(), adding range checks and failure
handling along the way.
Reviews by Brendan MacDonell, Jeremy Devenport, florian, doug, millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Fix swapctl -A with DUIDs in /etc/fstab, and plug a small memory leak.
ok jsing@ (who also pointed out a DPADD tweak missing from my diff)

if no arguments given, assume a nice default; ok miod jakemsr deanna

sync swapon usage(); from Igor Zinovik

Remove dead code and fix incorrect comment. From Igor Zinovik.

handle snprintf potential -1 case

- avoid variable sized static array (from millert@)
- check for snprintf overflow
- errx -> err for strdup

commit #1000!

check strdup failure; ok anil millert

Fix inaccuracies in comments.

ansi

typo in comment.
From Sam Smith S at mSmith.net

Kill commented out stubs for swapoff.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

return from main() don't exit

Various swapctl(8) improvements:
- don't print an error message when trying to enable swap on an
already active swap point.
- better handling of -t option.
- silently ignores swap points which are neither block devices nor
regular files, and don't consider swap points not starting with /dev/
as valid block devices, when invoked with -A.

Work by deraadt@ and myself, ok millert@

PATH_MAX+1 is wrong. Not cranking libc/libc_r majors over this, since they just got cranked a little while ago. discussion with millert

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant). These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

branches: 1.2.2;
add rcs idents

branches: 1.1.1;
Initial revision