Delete support for FFS filesystems before the in-inode symlink
optimization. As observed by ali_farzanrad(at)riseup.net, support
for these was broken in the 5.5 release in early 2014 by the time_t
changes. No one noticed before now, so clearly this isn't something
we need to continue to support; rejecting in ffs_validate() is an
improvement.

Also: simplify DIRSIZ(), drop OLDDIRFMT and NEWDIRFMT, tests of
fs_maxsymlinklen against zero, #ifdef tests of FS_44INODEFMT, and
remove support for newfs -O0, last used in 2016.

ok miod@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Switch from utimes() to utimensat() to $estore full nanosecond granularity

ok millert@ deraadt@

Adjust <sys/param.h> comments regarding use of use of MAXFRAG, or
delete <sys/param.h> if now possible
ok guenther

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Reuse xtrfile() to avoid duplication.
Casting from long to int for a size_t argument is dumb.
Calling warnx() right before err() is silly.

ok millert@

Switch from <sys/endian.h> or <machine/endian.h> to the new,
being-standardized <endian.h>

ok deraadt@ millert@ beck@

Make sure the correct errno is reported by warn* or err* and not
the errno of an intervening cleanup operation like close/unlink/etc.

Diff from Doug Hogan (doug (at) acyclic.org)

big int_t/time_t fixes; ok deraadt@ krw@

pretty print bigger off_t
ok tedu otto

remove some useless casts. ok krw

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Add ffs2 support to dump/restore. From FreeBSD with some NetBSD changes.
With help from otto@

Use strlcpy() not snprintf(). OK otto@ and moritz@

Replace home-grown byte swapping routine with calls to swap* macros
from endian.h. Header swapping is moved into its own function.
Fixes problems reading non-native endian dump images on sparc64.
Adapted from changes in NetBSD.

some ansi; khalek@linuxgamers.net

fix restore so that it can actually restore files larger than 4GB by
changing the type of "size" to off_t in getfiles() plus little dependent
type cleanup, from Daniel Lucq <daniel@lucq.org>
ok tdeval@ millert@ otto@

rename struct dinode to ufs1_dinode. clears the namespace and makes
way for some future work. no function changes yet.
help testing otto@ and markus@

spaces

rcsid should say openbsd. make 'em const while here.

Repair last commit, the NUL termination of locname is required
for the strlcat() to work since the buffer gets used for each
entry in a directory.

convert strn{cpy,cat}->strl{cpy,cat} in directory processing
comments and from krw@, tdeval@, tedu@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

more strlcpy; most from Hans-Joerg.Hoexer@yerbouti.franken.de, a bit from me

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

More <sys/file.h> vs. <fcntl.h> and open() flags fixes.

Fix snprintf return value usage.

chflags(2) take a u_int

vprintf -> Vprintf and dprintf -> Dprintf to avoid confusion
Use err/errx and warn/warnx where it makes sense.
Some sprintf -> snprintf, strcpy -> strncpy, and strcat -> strncat.
Honor $TMPDIR (based on changes from NetBSD)
Use __progname not "restore" (we could be called as rrestore).
Some -Wall happiness.

No need for "pathnames.h" now that _PATH_DEFTAPE is in <paths.h>
Fix rmt -> rst in man page and change ".Nm restore" -> ".Nm"

use mkstemp()

does noone know how to use strncat correctly?

Fix strncpy usage and correct strncat length field, from Theo.
Also change some occurrence of MAXPATHLEN with sizeof(foo).

64 bit patches, tih@nhh.no

/tmp// -> /tmp/

ptr check in skipdirs(), by joerg from freebsd

mktemp whoops

mktemp open & fdopen

update rcsid

updated patch from lukem@supp.cpr.itg.telecom.com.au to also make -r and -R work again

use unique temporary files; netbsd pr#2544; lukem@supp.cpr.itg.telecom.com.au

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Switch from utimes() to utimensat() to $estore full nanosecond granularity

ok millert@ deraadt@

Adjust <sys/param.h> comments regarding use of use of MAXFRAG, or
delete <sys/param.h> if now possible
ok guenther

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Reuse xtrfile() to avoid duplication.
Casting from long to int for a size_t argument is dumb.
Calling warnx() right before err() is silly.

ok millert@

Switch from <sys/endian.h> or <machine/endian.h> to the new,
being-standardized <endian.h>

ok deraadt@ millert@ beck@

Make sure the correct errno is reported by warn* or err* and not
the errno of an intervening cleanup operation like close/unlink/etc.

Diff from Doug Hogan (doug (at) acyclic.org)

big int_t/time_t fixes; ok deraadt@ krw@

pretty print bigger off_t
ok tedu otto

remove some useless casts. ok krw

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Add ffs2 support to dump/restore. From FreeBSD with some NetBSD changes.
With help from otto@

Use strlcpy() not snprintf(). OK otto@ and moritz@

Replace home-grown byte swapping routine with calls to swap* macros
from endian.h. Header swapping is moved into its own function.
Fixes problems reading non-native endian dump images on sparc64.
Adapted from changes in NetBSD.

some ansi; khalek@linuxgamers.net

fix restore so that it can actually restore files larger than 4GB by
changing the type of "size" to off_t in getfiles() plus little dependent
type cleanup, from Daniel Lucq <daniel@lucq.org>
ok tdeval@ millert@ otto@

rename struct dinode to ufs1_dinode. clears the namespace and makes
way for some future work. no function changes yet.
help testing otto@ and markus@

spaces

rcsid should say openbsd. make 'em const while here.

Repair last commit, the NUL termination of locname is required
for the strlcat() to work since the buffer gets used for each
entry in a directory.

convert strn{cpy,cat}->strl{cpy,cat} in directory processing
comments and from krw@, tdeval@, tedu@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

more strlcpy; most from Hans-Joerg.Hoexer@yerbouti.franken.de, a bit from me

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

More <sys/file.h> vs. <fcntl.h> and open() flags fixes.

Fix snprintf return value usage.

chflags(2) take a u_int

vprintf -> Vprintf and dprintf -> Dprintf to avoid confusion
Use err/errx and warn/warnx where it makes sense.
Some sprintf -> snprintf, strcpy -> strncpy, and strcat -> strncat.
Honor $TMPDIR (based on changes from NetBSD)
Use __progname not "restore" (we could be called as rrestore).
Some -Wall happiness.

No need for "pathnames.h" now that _PATH_DEFTAPE is in <paths.h>
Fix rmt -> rst in man page and change ".Nm restore" -> ".Nm"

use mkstemp()

does noone know how to use strncat correctly?

Fix strncpy usage and correct strncat length field, from Theo.
Also change some occurrence of MAXPATHLEN with sizeof(foo).

64 bit patches, tih@nhh.no

/tmp// -> /tmp/

ptr check in skipdirs(), by joerg from freebsd

mktemp whoops

mktemp open & fdopen

update rcsid

updated patch from lukem@supp.cpr.itg.telecom.com.au to also make -r and -R work again

use unique temporary files; netbsd pr#2544; lukem@supp.cpr.itg.telecom.com.au

branches: 1.1.1;
Initial revision

Switch from utimes() to utimensat() to $estore full nanosecond granularity

ok millert@ deraadt@

Adjust <sys/param.h> comments regarding use of use of MAXFRAG, or
delete <sys/param.h> if now possible
ok guenther

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Reuse xtrfile() to avoid duplication.
Casting from long to int for a size_t argument is dumb.
Calling warnx() right before err() is silly.

ok millert@

Switch from <sys/endian.h> or <machine/endian.h> to the new,
being-standardized <endian.h>

ok deraadt@ millert@ beck@

Make sure the correct errno is reported by warn* or err* and not
the errno of an intervening cleanup operation like close/unlink/etc.

Diff from Doug Hogan (doug (at) acyclic.org)

big int_t/time_t fixes; ok deraadt@ krw@

pretty print bigger off_t
ok tedu otto

remove some useless casts. ok krw

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Add ffs2 support to dump/restore. From FreeBSD with some NetBSD changes.
With help from otto@

Use strlcpy() not snprintf(). OK otto@ and moritz@

Replace home-grown byte swapping routine with calls to swap* macros
from endian.h. Header swapping is moved into its own function.
Fixes problems reading non-native endian dump images on sparc64.
Adapted from changes in NetBSD.

some ansi; khalek@linuxgamers.net

fix restore so that it can actually restore files larger than 4GB by
changing the type of "size" to off_t in getfiles() plus little dependent
type cleanup, from Daniel Lucq <daniel@lucq.org>
ok tdeval@ millert@ otto@

rename struct dinode to ufs1_dinode. clears the namespace and makes
way for some future work. no function changes yet.
help testing otto@ and markus@

spaces

rcsid should say openbsd. make 'em const while here.

Repair last commit, the NUL termination of locname is required
for the strlcat() to work since the buffer gets used for each
entry in a directory.

convert strn{cpy,cat}->strl{cpy,cat} in directory processing
comments and from krw@, tdeval@, tedu@

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

more strlcpy; most from Hans-Joerg.Hoexer@yerbouti.franken.de, a bit from me

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

More <sys/file.h> vs. <fcntl.h> and open() flags fixes.

Fix snprintf return value usage.

chflags(2) take a u_int

vprintf -> Vprintf and dprintf -> Dprintf to avoid confusion
Use err/errx and warn/warnx where it makes sense.
Some sprintf -> snprintf, strcpy -> strncpy, and strcat -> strncat.
Honor $TMPDIR (based on changes from NetBSD)
Use __progname not "restore" (we could be called as rrestore).
Some -Wall happiness.

No need for "pathnames.h" now that _PATH_DEFTAPE is in <paths.h>
Fix rmt -> rst in man page and change ".Nm restore" -> ".Nm"

use mkstemp()

does noone know how to use strncat correctly?

Fix strncpy usage and correct strncat length field, from Theo.
Also change some occurrence of MAXPATHLEN with sizeof(foo).

64 bit patches, tih@nhh.no

/tmp// -> /tmp/

ptr check in skipdirs(), by joerg from freebsd

mktemp whoops

mktemp open & fdopen

update rcsid

updated patch from lukem@supp.cpr.itg.telecom.com.au to also make -r and -R work again

use unique temporary files; netbsd pr#2544; lukem@supp.cpr.itg.telecom.com.au

branches: 1.1.1;
Initial revision