isakmpd: remove #ifdefs for ancient OPENSSL_VERSIONs.

No-one is going to build this with OpenSSL 0.9.7 or earlier, so we
can remove this code.

ok bluhm sthen (as part of a larger diff)

Stop assuming that in_{addr,port}_t are typedefed in <sys/types.h> and
instead pull in <netinet/in.h> or <arpa/inet.h> when those are needed.

ok florian@ beck@ millert@

Set pointer to NULL after freeing it, so callers of
key_from_printable() are not fooled into using it
afterwards.

OK hshoexer@

Be cleaner about signed vs. unsigned when it's easy to do so. OK hshoexer

Add a new raw2hex function and yank out several pieces of code in other
places that were doing this. Prodding deraadt. OK hshoexer.

Make deterministic randomness (only ever used for testing) a compile-time
option. Reduces chances of somehow setting regrand when it's not supposed
to be set. Remove "-r" option from man page. Also xref certpatch(8) while
we are in there. And remove some include sysdep.h where it is no longer
needed.
OK hshoexer

Always compile X509 support. Almost everyone uses it. Makes the code
much easier to read and to maintain.
OK and testing by hshoexer@, more testing by me

Correctly determine length of rsa key passed by the kernel to userland. Found
and fix provided by Stefan Miltchev. Again, many thanks!

Slightly different fix.
ok ho@

Missing #ifdefs.

KNF, style, 80c, etc. hshoexer@ ok

More KNF. Mainly spaces and line-wraps, no binary change.

ok ho@

greater care with arguments

partial move to KNF. More to come. This has happened because there
are a raft of source code auditors who are willing to help improve this
code only if this is done, and hey, isakmpd does need our standard
auditing process. ok ho hshoexer

Reset *data in case of unknown key types

Style nits.

signed vs unsigned, some void * arithmetic, from -pedantic. niklas@ ok.

The dlopen() stuff goes away.

size_t must be cast to (unsigned long) and printed using %lu

Compile without warnings for older/newer OpenSSL.

Fix a couple of snprintf length bugs. Same problem <chris@stallion.oz.au>
found for policy passphrases.

handle constification from new openssl

the last few sprintf -> snprintf

libcrypto.h should be included. Sort includes.

make the alpha happy

Style

Copyright update.

Key handling routines.

Stop assuming that in_{addr,port}_t are typedefed in <sys/types.h> and
instead pull in <netinet/in.h> or <arpa/inet.h> when those are needed.

ok florian@ beck@ millert@

Set pointer to NULL after freeing it, so callers of
key_from_printable() are not fooled into using it
afterwards.

OK hshoexer@

Be cleaner about signed vs. unsigned when it's easy to do so. OK hshoexer

Add a new raw2hex function and yank out several pieces of code in other
places that were doing this. Prodding deraadt. OK hshoexer.

Make deterministic randomness (only ever used for testing) a compile-time
option. Reduces chances of somehow setting regrand when it's not supposed
to be set. Remove "-r" option from man page. Also xref certpatch(8) while
we are in there. And remove some include sysdep.h where it is no longer
needed.
OK hshoexer

Always compile X509 support. Almost everyone uses it. Makes the code
much easier to read and to maintain.
OK and testing by hshoexer@, more testing by me

Correctly determine length of rsa key passed by the kernel to userland. Found
and fix provided by Stefan Miltchev. Again, many thanks!

Slightly different fix.
ok ho@

Missing #ifdefs.

KNF, style, 80c, etc. hshoexer@ ok

More KNF. Mainly spaces and line-wraps, no binary change.

ok ho@

greater care with arguments

partial move to KNF. More to come. This has happened because there
are a raft of source code auditors who are willing to help improve this
code only if this is done, and hey, isakmpd does need our standard
auditing process. ok ho hshoexer

Reset *data in case of unknown key types

Style nits.

signed vs unsigned, some void * arithmetic, from -pedantic. niklas@ ok.

The dlopen() stuff goes away.

size_t must be cast to (unsigned long) and printed using %lu

Compile without warnings for older/newer OpenSSL.

Fix a couple of snprintf length bugs. Same problem <chris@stallion.oz.au>
found for policy passphrases.

handle constification from new openssl

the last few sprintf -> snprintf

libcrypto.h should be included. Sort includes.

make the alpha happy

Style

Copyright update.

Key handling routines.