Avoid the possibility of accessing an array out of bounds.
Found with cppcheck. ok krw@

Remove NULL-checks before free(). ok tb@

<stdlib.h> is included, so do not need to cast result from
malloc, calloc, realloc*
ok krw millert

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Nuke some obvious #include duplications.

ok espie@ deraadt@ millert@ tedu@

Remove redundant check and wrong fix: fat.c checks already take care
about cluster chains. If the user didn't want to fix them at that time,
he asks for trouble -- and these checks didn't help in all cases either.

discussed with and ok krw@

Avoid out of boundary access when checking invalid long filenames.

Addressed by NetBSD in revision 1.24, but instead of ignoring the filename,
consider it invalid -- because it is.

ok krw@, tedu@

Merge memory leak fix from NetBSD's dir.c revision 1.20, but actually
release all reserved memory chunks in all error cases.

with input by and ok tedu@, ok deraadt@

Always keep length of cluster chain up to date, otherwise the drop of
superfluous clusters can lead to out of boundary access.

ok krw@

Merge NetBSD commit:
Move to 2 clause license, approved by Wolfgang Solfrank.

ok deraadt@, krw@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

newline fix + s/perror/xperror since we are
using a home rolled version.

ok pedro@

some ansi; khalek@linuxgamers.net

spaces

snprintf

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

major -Wall cleanup, almost complete

Put missing \n's in som error messages; consolidate redundant "if" (OK theo@).

Corrected overflow logic in fullpath.

<subliminal FreeBSD/NetBSD>Oh yeah, baby, you want that one</subliminal :->

Fix obvious logic error (from netbsd)

FAT32 support from NetBSD by Wolfgang Solfrank.

from ws@netbsd; Fix a few bugs, especially when repairing disks:
Print correct pathname in error messages
Fix unterminating loop when trying to correct a bad fat
Require fat media byte to be the same as the one in the bpb
Fix unterminating loop when looking for free directory slot in LOST.DIR
(bad disk image provided by Christoph Badura)

Update based on latest NetBSD version.
Now uses functions from util.[ch] instead of local ones.
Also some anal KNF from me...

From NetBSD (ws)
Fix handling of clusters marked bad; Noted by Rafal Boni

"prs are sometimes wrong" (theo)
fix wrong fix. "kak v zadnitsu kol, russkiy rock-n-roll" (4epHeuKuu)

realpath fix, do not dump; pr#2765, david@mono.org

update rcsid

from ws;
Check return values of malloc
Generate full pathnames only on request
Minor cleanup, RCS Ids in .h files
Don't allocate data structures for non-directories
Free any data structures when finishing a check (at the latest)

add fsck_msdos