userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

dmesg(8): don't accept positional arguments

dmesg(8) doesn't use any positional arguments. If we see any, it's a
usage error.

ok florian@, "Sure" deraadt@ millert@

dmesg(8) allocated a bit too much memory due to padding of struct
msgbuf. Use the same size algorithm in kernel and userland.
OK cheloha@ guenther@ deraadt@

drop unused <time.h>

ok kn@ mpi@

free() the memory we allocate in dmesg.c. While this memory would be
released on process exit, otto@ points out that various checks happen
on free(), so this helps detect memory management errors.

Based on a diff from Nan Xiao - thanks.

ok otto@

Be more precise in the messages given by err() after calling sysctl()
in dmesg.c.

Based on a diff from xiao_nan (at) dsi (dot) a-star (dot) edu (dot) sg -
thanks.

ok otto@

Change all tame callers to namechange to pledge(2).

dmesg has two modes. The normal sysctl mode, and the -M/-N kvm searcher.
In both cases once the relevant setup is done, it can drop to tame "stdio".

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Add dmesg -s support, to view the output of rc(8) system startup messages.
Help and feedback by Theo and Miod.
OK deraadt@, manpage-ok jmc@

malloc/memset -> calloc. from peter malone

some data structures were still present when NOKVM was defined

init bufdata to NULL for when compiled without KVM support

zap incorrect comment

tiny doses of KNF, inspired by a diff for sth else from Brian <bwaichu@yahoo.com>

shave off a few bytes, alpha floppies fit again now

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

major -Wall cleanup, almost complete

#include <string.h> for memset() proto

smaller dmesg

use sysctl to retreive msgbuf out of live system, keep the kvm iface, remove sgid

return from main() don't exit

enlarge msgbuf, somewhat line netbsd did

whack kmem gid after kvm_openfiles()

split KREAD() calls

Avoid infinite loops; from NetBSD PR 3285

getopt(3) returns -1 when out of args, not EOF, whee!

Deal with _POSIX_SAVED_IDS when relinquishing privileges

update rcsid

branches: 1.1.1;
Initial revision

dmesg(8): don't accept positional arguments

dmesg(8) doesn't use any positional arguments. If we see any, it's a
usage error.

ok florian@, "Sure" deraadt@ millert@

dmesg(8) allocated a bit too much memory due to padding of struct
msgbuf. Use the same size algorithm in kernel and userland.
OK cheloha@ guenther@ deraadt@

drop unused <time.h>

ok kn@ mpi@

free() the memory we allocate in dmesg.c. While this memory would be
released on process exit, otto@ points out that various checks happen
on free(), so this helps detect memory management errors.

Based on a diff from Nan Xiao - thanks.

ok otto@

Be more precise in the messages given by err() after calling sysctl()
in dmesg.c.

Based on a diff from xiao_nan (at) dsi (dot) a-star (dot) edu (dot) sg -
thanks.

ok otto@

Change all tame callers to namechange to pledge(2).

dmesg has two modes. The normal sysctl mode, and the -M/-N kvm searcher.
In both cases once the relevant setup is done, it can drop to tame "stdio".

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Add dmesg -s support, to view the output of rc(8) system startup messages.
Help and feedback by Theo and Miod.
OK deraadt@, manpage-ok jmc@

malloc/memset -> calloc. from peter malone

some data structures were still present when NOKVM was defined

init bufdata to NULL for when compiled without KVM support

zap incorrect comment

tiny doses of KNF, inspired by a diff for sth else from Brian <bwaichu@yahoo.com>

shave off a few bytes, alpha floppies fit again now

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

major -Wall cleanup, almost complete

#include <string.h> for memset() proto

smaller dmesg

use sysctl to retreive msgbuf out of live system, keep the kvm iface, remove sgid

return from main() don't exit

enlarge msgbuf, somewhat line netbsd did

whack kmem gid after kvm_openfiles()

split KREAD() calls

Avoid infinite loops; from NetBSD PR 3285

getopt(3) returns -1 when out of args, not EOF, whee!

Deal with _POSIX_SAVED_IDS when relinquishing privileges

update rcsid

branches: 1.1.1;
Initial revision

dmesg(8) allocated a bit too much memory due to padding of struct
msgbuf. Use the same size algorithm in kernel and userland.
OK cheloha@ guenther@ deraadt@

drop unused <time.h>

ok kn@ mpi@

free() the memory we allocate in dmesg.c. While this memory would be
released on process exit, otto@ points out that various checks happen
on free(), so this helps detect memory management errors.

Based on a diff from Nan Xiao - thanks.

ok otto@

Be more precise in the messages given by err() after calling sysctl()
in dmesg.c.

Based on a diff from xiao_nan (at) dsi (dot) a-star (dot) edu (dot) sg -
thanks.

ok otto@

Change all tame callers to namechange to pledge(2).

dmesg has two modes. The normal sysctl mode, and the -M/-N kvm searcher.
In both cases once the relevant setup is done, it can drop to tame "stdio".

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Add dmesg -s support, to view the output of rc(8) system startup messages.
Help and feedback by Theo and Miod.
OK deraadt@, manpage-ok jmc@

malloc/memset -> calloc. from peter malone

some data structures were still present when NOKVM was defined

init bufdata to NULL for when compiled without KVM support

zap incorrect comment

tiny doses of KNF, inspired by a diff for sth else from Brian <bwaichu@yahoo.com>

shave off a few bytes, alpha floppies fit again now

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

major -Wall cleanup, almost complete

#include <string.h> for memset() proto

smaller dmesg

use sysctl to retreive msgbuf out of live system, keep the kvm iface, remove sgid

return from main() don't exit

enlarge msgbuf, somewhat line netbsd did

whack kmem gid after kvm_openfiles()

split KREAD() calls

Avoid infinite loops; from NetBSD PR 3285

getopt(3) returns -1 when out of args, not EOF, whee!

Deal with _POSIX_SAVED_IDS when relinquishing privileges

update rcsid

branches: 1.1.1;
Initial revision

drop unused <time.h>

ok kn@ mpi@

free() the memory we allocate in dmesg.c. While this memory would be
released on process exit, otto@ points out that various checks happen
on free(), so this helps detect memory management errors.

Based on a diff from Nan Xiao - thanks.

ok otto@

Be more precise in the messages given by err() after calling sysctl()
in dmesg.c.

Based on a diff from xiao_nan (at) dsi (dot) a-star (dot) edu (dot) sg -
thanks.

ok otto@

Change all tame callers to namechange to pledge(2).

dmesg has two modes. The normal sysctl mode, and the -M/-N kvm searcher.
In both cases once the relevant setup is done, it can drop to tame "stdio".

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Add dmesg -s support, to view the output of rc(8) system startup messages.
Help and feedback by Theo and Miod.
OK deraadt@, manpage-ok jmc@

malloc/memset -> calloc. from peter malone

some data structures were still present when NOKVM was defined

init bufdata to NULL for when compiled without KVM support

zap incorrect comment

tiny doses of KNF, inspired by a diff for sth else from Brian <bwaichu@yahoo.com>

shave off a few bytes, alpha floppies fit again now

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

major -Wall cleanup, almost complete

#include <string.h> for memset() proto

smaller dmesg

use sysctl to retreive msgbuf out of live system, keep the kvm iface, remove sgid

return from main() don't exit

enlarge msgbuf, somewhat line netbsd did

whack kmem gid after kvm_openfiles()

split KREAD() calls

Avoid infinite loops; from NetBSD PR 3285

getopt(3) returns -1 when out of args, not EOF, whee!

Deal with _POSIX_SAVED_IDS when relinquishing privileges

update rcsid

branches: 1.1.1;
Initial revision

free() the memory we allocate in dmesg.c. While this memory would be
released on process exit, otto@ points out that various checks happen
on free(), so this helps detect memory management errors.

Based on a diff from Nan Xiao - thanks.

ok otto@

Be more precise in the messages given by err() after calling sysctl()
in dmesg.c.

Based on a diff from xiao_nan (at) dsi (dot) a-star (dot) edu (dot) sg -
thanks.

ok otto@

Change all tame callers to namechange to pledge(2).

dmesg has two modes. The normal sysctl mode, and the -M/-N kvm searcher.
In both cases once the relevant setup is done, it can drop to tame "stdio".

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Add dmesg -s support, to view the output of rc(8) system startup messages.
Help and feedback by Theo and Miod.
OK deraadt@, manpage-ok jmc@

malloc/memset -> calloc. from peter malone

some data structures were still present when NOKVM was defined

init bufdata to NULL for when compiled without KVM support

zap incorrect comment

tiny doses of KNF, inspired by a diff for sth else from Brian <bwaichu@yahoo.com>

shave off a few bytes, alpha floppies fit again now

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

major -Wall cleanup, almost complete

#include <string.h> for memset() proto

smaller dmesg

use sysctl to retreive msgbuf out of live system, keep the kvm iface, remove sgid

return from main() don't exit

enlarge msgbuf, somewhat line netbsd did

whack kmem gid after kvm_openfiles()

split KREAD() calls

Avoid infinite loops; from NetBSD PR 3285

getopt(3) returns -1 when out of args, not EOF, whee!

Deal with _POSIX_SAVED_IDS when relinquishing privileges

update rcsid

branches: 1.1.1;
Initial revision