Fix up whitespace left by previous change removing privsep. No other
changes.

Remove (almost all) references to privsep. This removes several do..while
loops but does not change the indentation of the now-shallower loops,
which will be done in a separate whitespace-only commit to keep changes
of style and substance separate.

Use "skip" instead of "fatal" if SUDO isn't set for the *-command tests.
This means running "make tests" without SUDO set will perform all of the
tests that it can instead of failing on the ones it cannot run.

test security key host keys in addition to user keys

it's no longer possible to disable privilege separation in sshd, so
don't double the tests' work by trying both off/on

test FIDO2/U2F key types; ok markus@

skip security-key key types for tests until we have a dummy
U2F middleware to use.

Check for RSA support before using it for the user key, otherwise use
ed25519 which is supported when built without OpenSSL.

Append pid to temp files in /var/run and set a cleanup trap for them.
This allows multiple instances of tests to run without colliding.

UsePrivilegeSeparation no is deprecated, test "yes" and "sandbox".
rCVS: ----------------------------------------------------------------------

eliminate explicit specification of protocol in tests and loops over
protocol. We only support SSHv2 now.

Allow to run ssh regression tests as root. If the user is already
root, the test should not expect that SUDO is set. If ssh needs
another user, use sudo or doas to switch from root if necessary.
OK dtucker@

test all the AuthorizedPrincipalsCommand % expansions

regress test for AuthorizedPrincipalsCommand

test security key host keys in addition to user keys

it's no longer possible to disable privilege separation in sshd, so
don't double the tests' work by trying both off/on

test FIDO2/U2F key types; ok markus@

skip security-key key types for tests until we have a dummy
U2F middleware to use.

Check for RSA support before using it for the user key, otherwise use
ed25519 which is supported when built without OpenSSL.

Append pid to temp files in /var/run and set a cleanup trap for them.
This allows multiple instances of tests to run without colliding.

UsePrivilegeSeparation no is deprecated, test "yes" and "sandbox".
rCVS: ----------------------------------------------------------------------

eliminate explicit specification of protocol in tests and loops over
protocol. We only support SSHv2 now.

Allow to run ssh regression tests as root. If the user is already
root, the test should not expect that SUDO is set. If ssh needs
another user, use sudo or doas to switch from root if necessary.
OK dtucker@

test all the AuthorizedPrincipalsCommand % expansions

regress test for AuthorizedPrincipalsCommand

it's no longer possible to disable privilege separation in sshd, so
don't double the tests' work by trying both off/on

test FIDO2/U2F key types; ok markus@

skip security-key key types for tests until we have a dummy
U2F middleware to use.

Check for RSA support before using it for the user key, otherwise use
ed25519 which is supported when built without OpenSSL.

Append pid to temp files in /var/run and set a cleanup trap for them.
This allows multiple instances of tests to run without colliding.

UsePrivilegeSeparation no is deprecated, test "yes" and "sandbox".
rCVS: ----------------------------------------------------------------------

eliminate explicit specification of protocol in tests and loops over
protocol. We only support SSHv2 now.

Allow to run ssh regression tests as root. If the user is already
root, the test should not expect that SUDO is set. If ssh needs
another user, use sudo or doas to switch from root if necessary.
OK dtucker@

test all the AuthorizedPrincipalsCommand % expansions

regress test for AuthorizedPrincipalsCommand

test FIDO2/U2F key types; ok markus@

skip security-key key types for tests until we have a dummy
U2F middleware to use.

Check for RSA support before using it for the user key, otherwise use
ed25519 which is supported when built without OpenSSL.

Append pid to temp files in /var/run and set a cleanup trap for them.
This allows multiple instances of tests to run without colliding.

UsePrivilegeSeparation no is deprecated, test "yes" and "sandbox".
rCVS: ----------------------------------------------------------------------

eliminate explicit specification of protocol in tests and loops over
protocol. We only support SSHv2 now.

Allow to run ssh regression tests as root. If the user is already
root, the test should not expect that SUDO is set. If ssh needs
another user, use sudo or doas to switch from root if necessary.
OK dtucker@

test all the AuthorizedPrincipalsCommand % expansions

regress test for AuthorizedPrincipalsCommand

skip security-key key types for tests until we have a dummy
U2F middleware to use.

Check for RSA support before using it for the user key, otherwise use
ed25519 which is supported when built without OpenSSL.

Append pid to temp files in /var/run and set a cleanup trap for them.
This allows multiple instances of tests to run without colliding.

UsePrivilegeSeparation no is deprecated, test "yes" and "sandbox".
rCVS: ----------------------------------------------------------------------

eliminate explicit specification of protocol in tests and loops over
protocol. We only support SSHv2 now.

Allow to run ssh regression tests as root. If the user is already
root, the test should not expect that SUDO is set. If ssh needs
another user, use sudo or doas to switch from root if necessary.
OK dtucker@

test all the AuthorizedPrincipalsCommand % expansions

regress test for AuthorizedPrincipalsCommand

Check for RSA support before using it for the user key, otherwise use
ed25519 which is supported when built without OpenSSL.

Append pid to temp files in /var/run and set a cleanup trap for them.
This allows multiple instances of tests to run without colliding.

UsePrivilegeSeparation no is deprecated, test "yes" and "sandbox".
rCVS: ----------------------------------------------------------------------

eliminate explicit specification of protocol in tests and loops over
protocol. We only support SSHv2 now.

Allow to run ssh regression tests as root. If the user is already
root, the test should not expect that SUDO is set. If ssh needs
another user, use sudo or doas to switch from root if necessary.
OK dtucker@

test all the AuthorizedPrincipalsCommand % expansions

regress test for AuthorizedPrincipalsCommand

Append pid to temp files in /var/run and set a cleanup trap for them.
This allows multiple instances of tests to run without colliding.

UsePrivilegeSeparation no is deprecated, test "yes" and "sandbox".
rCVS: ----------------------------------------------------------------------

eliminate explicit specification of protocol in tests and loops over
protocol. We only support SSHv2 now.

Allow to run ssh regression tests as root. If the user is already
root, the test should not expect that SUDO is set. If ssh needs
another user, use sudo or doas to switch from root if necessary.
OK dtucker@

test all the AuthorizedPrincipalsCommand % expansions

regress test for AuthorizedPrincipalsCommand

UsePrivilegeSeparation no is deprecated, test "yes" and "sandbox".
rCVS: ----------------------------------------------------------------------

eliminate explicit specification of protocol in tests and loops over
protocol. We only support SSHv2 now.

Allow to run ssh regression tests as root. If the user is already
root, the test should not expect that SUDO is set. If ssh needs
another user, use sudo or doas to switch from root if necessary.
OK dtucker@

test all the AuthorizedPrincipalsCommand % expansions

regress test for AuthorizedPrincipalsCommand

eliminate explicit specification of protocol in tests and loops over
protocol. We only support SSHv2 now.

Allow to run ssh regression tests as root. If the user is already
root, the test should not expect that SUDO is set. If ssh needs
another user, use sudo or doas to switch from root if necessary.
OK dtucker@

test all the AuthorizedPrincipalsCommand % expansions

regress test for AuthorizedPrincipalsCommand