Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

remove a couple hundred sys/param.h includes in userland code, and
also whack some sys/cdefs.h early includes which is such a brutally
bad pattern
ok bluhm mbuhl

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

Test for EMSGSIZE return when sending more fds in a message then the receiver
can handle and also test the case where the reciever is using read() instead
of recvmsg() to test the unp_discard() codepath in the kernel. The latter test
is just instrumenting the code but has no way to check if the discarding was
successful.
OK guenther@ bluhm@

enable compiler warnings and fix them.

The kernel doesn't actually care what a sockaddr's sa_len is on input,
so don't waste code setting it

Add a regression test for file descriptor passing with UNIX sockets.

ok claudio@

First pass at removing clauses 3 and 4 from NetBSD licenses.

Not sure what's more surprising: how long it took for NetBSD to
catch up to the rest of the BSDs (including UCB), or the amount of
code that NetBSD has claimed for itself without attributing to the
actual authors.

OK deraadt@

msg_controllen has to be CMSG_SPACE so that the kernel can account for
each cmsg_len (ie. msg_controllen = sum of CMSG_ALIGN(cmsg_len). This
works now that kernel fd passing has been fixed to accept a bit of
sloppiness because of this ABI repair.
lots of discussion with kettenis

Repair usage of CMSG_SPACE and CMSG_LEN. While there, send three fds
instead of just two as this decreases the propability that things just
work although the sizes are wrong (ie. 8 aligns correctly on both 32 and 64 bit
platforms even with wrong usage of CMSG_{LEN,SPACE} whereas 12 doesn't).

Correct CMSG_SPACE and CMSG_LEN usage everywhere in the tree. Due to
an extensive discussion with otto, kettenis, millert, and hshoexer

Use CMSG_SPACE when allocating space for the control message.
Fixes a bogus regression on sparc64. OK henning@

Remove statement with no effect.

fd passing works over a socketpair too of course so document this.
Also test it in regress to be pedantic (though the kernel path is
really the same). While there, remove cred-passing code that we
don't support. OK deraadt@,

avoid bad functions; tedu ok

various cleanups; david says results are same

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

OpenBSD doesn't implement the cred part yet. comment out.

Make this 64-bit safe.

Let this test build.

signal race fixes

$OpenBSD$

copy from netbsd...

remove a couple hundred sys/param.h includes in userland code, and
also whack some sys/cdefs.h early includes which is such a brutally
bad pattern
ok bluhm mbuhl

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

Test for EMSGSIZE return when sending more fds in a message then the receiver
can handle and also test the case where the reciever is using read() instead
of recvmsg() to test the unp_discard() codepath in the kernel. The latter test
is just instrumenting the code but has no way to check if the discarding was
successful.
OK guenther@ bluhm@

enable compiler warnings and fix them.

The kernel doesn't actually care what a sockaddr's sa_len is on input,
so don't waste code setting it

Add a regression test for file descriptor passing with UNIX sockets.

ok claudio@

First pass at removing clauses 3 and 4 from NetBSD licenses.

Not sure what's more surprising: how long it took for NetBSD to
catch up to the rest of the BSDs (including UCB), or the amount of
code that NetBSD has claimed for itself without attributing to the
actual authors.

OK deraadt@

msg_controllen has to be CMSG_SPACE so that the kernel can account for
each cmsg_len (ie. msg_controllen = sum of CMSG_ALIGN(cmsg_len). This
works now that kernel fd passing has been fixed to accept a bit of
sloppiness because of this ABI repair.
lots of discussion with kettenis

Repair usage of CMSG_SPACE and CMSG_LEN. While there, send three fds
instead of just two as this decreases the propability that things just
work although the sizes are wrong (ie. 8 aligns correctly on both 32 and 64 bit
platforms even with wrong usage of CMSG_{LEN,SPACE} whereas 12 doesn't).

Correct CMSG_SPACE and CMSG_LEN usage everywhere in the tree. Due to
an extensive discussion with otto, kettenis, millert, and hshoexer

Use CMSG_SPACE when allocating space for the control message.
Fixes a bogus regression on sparc64. OK henning@

Remove statement with no effect.

fd passing works over a socketpair too of course so document this.
Also test it in regress to be pedantic (though the kernel path is
really the same). While there, remove cred-passing code that we
don't support. OK deraadt@,

avoid bad functions; tedu ok

various cleanups; david says results are same

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

OpenBSD doesn't implement the cred part yet. comment out.

Make this 64-bit safe.

Let this test build.

signal race fixes

$OpenBSD$

copy from netbsd...

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

Test for EMSGSIZE return when sending more fds in a message then the receiver
can handle and also test the case where the reciever is using read() instead
of recvmsg() to test the unp_discard() codepath in the kernel. The latter test
is just instrumenting the code but has no way to check if the discarding was
successful.
OK guenther@ bluhm@

enable compiler warnings and fix them.

The kernel doesn't actually care what a sockaddr's sa_len is on input,
so don't waste code setting it

Add a regression test for file descriptor passing with UNIX sockets.

ok claudio@

First pass at removing clauses 3 and 4 from NetBSD licenses.

Not sure what's more surprising: how long it took for NetBSD to
catch up to the rest of the BSDs (including UCB), or the amount of
code that NetBSD has claimed for itself without attributing to the
actual authors.

OK deraadt@

msg_controllen has to be CMSG_SPACE so that the kernel can account for
each cmsg_len (ie. msg_controllen = sum of CMSG_ALIGN(cmsg_len). This
works now that kernel fd passing has been fixed to accept a bit of
sloppiness because of this ABI repair.
lots of discussion with kettenis

Repair usage of CMSG_SPACE and CMSG_LEN. While there, send three fds
instead of just two as this decreases the propability that things just
work although the sizes are wrong (ie. 8 aligns correctly on both 32 and 64 bit
platforms even with wrong usage of CMSG_{LEN,SPACE} whereas 12 doesn't).

Correct CMSG_SPACE and CMSG_LEN usage everywhere in the tree. Due to
an extensive discussion with otto, kettenis, millert, and hshoexer

Use CMSG_SPACE when allocating space for the control message.
Fixes a bogus regression on sparc64. OK henning@

Remove statement with no effect.

fd passing works over a socketpair too of course so document this.
Also test it in regress to be pedantic (though the kernel path is
really the same). While there, remove cred-passing code that we
don't support. OK deraadt@,

avoid bad functions; tedu ok

various cleanups; david says results are same

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

OpenBSD doesn't implement the cred part yet. comment out.

Make this 64-bit safe.

Let this test build.

signal race fixes

$OpenBSD$

copy from netbsd...

Test for EMSGSIZE return when sending more fds in a message then the receiver
can handle and also test the case where the reciever is using read() instead
of recvmsg() to test the unp_discard() codepath in the kernel. The latter test
is just instrumenting the code but has no way to check if the discarding was
successful.
OK guenther@ bluhm@

enable compiler warnings and fix them.

The kernel doesn't actually care what a sockaddr's sa_len is on input,
so don't waste code setting it

Add a regression test for file descriptor passing with UNIX sockets.

ok claudio@

First pass at removing clauses 3 and 4 from NetBSD licenses.

Not sure what's more surprising: how long it took for NetBSD to
catch up to the rest of the BSDs (including UCB), or the amount of
code that NetBSD has claimed for itself without attributing to the
actual authors.

OK deraadt@

msg_controllen has to be CMSG_SPACE so that the kernel can account for
each cmsg_len (ie. msg_controllen = sum of CMSG_ALIGN(cmsg_len). This
works now that kernel fd passing has been fixed to accept a bit of
sloppiness because of this ABI repair.
lots of discussion with kettenis

Repair usage of CMSG_SPACE and CMSG_LEN. While there, send three fds
instead of just two as this decreases the propability that things just
work although the sizes are wrong (ie. 8 aligns correctly on both 32 and 64 bit
platforms even with wrong usage of CMSG_{LEN,SPACE} whereas 12 doesn't).

Correct CMSG_SPACE and CMSG_LEN usage everywhere in the tree. Due to
an extensive discussion with otto, kettenis, millert, and hshoexer

Use CMSG_SPACE when allocating space for the control message.
Fixes a bogus regression on sparc64. OK henning@

Remove statement with no effect.

fd passing works over a socketpair too of course so document this.
Also test it in regress to be pedantic (though the kernel path is
really the same). While there, remove cred-passing code that we
don't support. OK deraadt@,

avoid bad functions; tedu ok

various cleanups; david says results are same

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

OpenBSD doesn't implement the cred part yet. comment out.

Make this 64-bit safe.

Let this test build.

signal race fixes

$OpenBSD$

copy from netbsd...

enable compiler warnings and fix them.

The kernel doesn't actually care what a sockaddr's sa_len is on input,
so don't waste code setting it

Add a regression test for file descriptor passing with UNIX sockets.

ok claudio@

First pass at removing clauses 3 and 4 from NetBSD licenses.

Not sure what's more surprising: how long it took for NetBSD to
catch up to the rest of the BSDs (including UCB), or the amount of
code that NetBSD has claimed for itself without attributing to the
actual authors.

OK deraadt@

msg_controllen has to be CMSG_SPACE so that the kernel can account for
each cmsg_len (ie. msg_controllen = sum of CMSG_ALIGN(cmsg_len). This
works now that kernel fd passing has been fixed to accept a bit of
sloppiness because of this ABI repair.
lots of discussion with kettenis

Repair usage of CMSG_SPACE and CMSG_LEN. While there, send three fds
instead of just two as this decreases the propability that things just
work although the sizes are wrong (ie. 8 aligns correctly on both 32 and 64 bit
platforms even with wrong usage of CMSG_{LEN,SPACE} whereas 12 doesn't).

Correct CMSG_SPACE and CMSG_LEN usage everywhere in the tree. Due to
an extensive discussion with otto, kettenis, millert, and hshoexer

Use CMSG_SPACE when allocating space for the control message.
Fixes a bogus regression on sparc64. OK henning@

Remove statement with no effect.

fd passing works over a socketpair too of course so document this.
Also test it in regress to be pedantic (though the kernel path is
really the same). While there, remove cred-passing code that we
don't support. OK deraadt@,

avoid bad functions; tedu ok

various cleanups; david says results are same

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

OpenBSD doesn't implement the cred part yet. comment out.

Make this 64-bit safe.

Let this test build.

signal race fixes

$OpenBSD$

copy from netbsd...