ssltest: drop another use of CRYPTO_mem_leaks()

Remove last OPENSSL_NO_ENGINE from libssl regress

Avoid memcmp() with NULL pointer and 0 length

Prepare the ssltest for the upcoming bump

This is a hack. The test is in rather poor shape and it is hard to tell
whether it still does what it is supposed to be doing. Hopefully somemone
will rewrite this in a style that doesn't make me squeal on opening this
file...

Plug leak in the ssltest

Removing -tls1 moved some tests from the legacy stack to the TLSv1.3 stack.
On a HRR, the alpn callback would be called twice and allocate the global
twice, thereby leaking. So free it up front.

Joint suffering with bcook and beck

Disable TLS 1.0 and TLS 1.1 in libssl

Their time has long since past, and they should not be used.
This change restricts ssl to versions 1.2 and 1.3, and changes
the regression tests to understand we no longer speak the legacy
protocols.

For the moment the magical "golden" byte for byte comparison
tests of raw handshake values are disabled util jsing fixes them.

ok jsing@ tb@

ssltest: Drop more policy go from this test.

Hopefully that is all. What an absolutely horrid mess.

ssltest: initial pass of dropping proxy cert goo

Sync function prototypes and declarations to satisfy clang 15.

ok jsing@

Make internal header file names consistent

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names
used for internal headers. Move all these headers we inherited from
OpenSSL to *_local.h, reserving the name *_internal.h for our own code.
Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h.
constant_time_locl.h is moved to constant_time.h since it's special.

Adjust all .c files in libcrypto, libssl and regress.

The diff is mechanical with the exception of tls13_quic.c, where
#include <ssl_locl.h> was fixed manually.

discussed with jsing,
no objection bcook

Make the ssltest security level aware.

From beck

Switch ssltest to using the newly generated certs that use SHA-256 instead
of SHA-1. This helps the switch to security-level aware ssltest.

From jsing

Prepare ssltest for opaque DH

Fix ssltest to work with opaque EVP_PKEY.

Make this test compile again after the damage done in libcrypto

Pull in ssl_locl.h so that we can keep reaching into libssl internals.

ssltest.c does not need param.h

From Jonas Termansen

Garbage collect do_test_cipherlist().

This code no longer compiles and the equivalent test coverage has been
added to regress/lib/libssl/ciphers (and is actually run).

Disable some code that reaches into libssl internals.

This should be moved to a dedicated regress test.

Add a -tls1_2 option so we can force TLSv1.2 for testing.

Remove temporary RSA keys/callbacks code.

This was removed from libssl a very long time ago...

exitting -> exiting

From Michael Scovetta, PR #108

Add automatic threading initialization for libcrypto.

This implements automatic thread support initialization in libcrypto.
This does not remove any functions from the ABI, but does turn them into
no-ops. Stub implementations of pthread_mutex_(init|lock|unlock) are
provided for ramdisks.

This does not implement the new OpenSSL 1.1 thread API internally,
keeping the original CRYTPO_lock / CRYPTO_add_lock functions for library
locking. For -portable, crypto_lock.c can be reimplemented with
OS-specific primitives as needed.

ok beck@, tb@, looks sane guenther@

Remove NPN test coverage.

Treat "ERROR in STARTUP" as an actual error, rather than failing without
exiting non-zero (which has been masking a DTLS related issue). Also make
the message consistent with other errors.

Spotted by inogochi@

Remove commented out code and fix indentation of surrounding statements.

Remove handling for SSLv2.

Use prime256v1 for tests unless otherwise specified.

remove e_os2.h includes
ok jsing@

Remove SSLv3 support from LibreSSL regression tests.

Reject DH keys sent by a server if they are considered too small; inspired
by a similar BoringSSL change, but raising the limit to 1024 bits.
ok jsing@ markus@ guenther@ deraadt@

unifdef OPENSSL_NO_NEXTPROTONEG

Add regress for ALPN.

Based on OpenSSL.

The -ssl2 flag does nothing - remove the flag and any tests that were
using it.

Remove _XOPEN_SOURCE_EXTENDED since we're not too concerned about
gethostname being declared properly on Compaq platforms that use DEC C...

BIO_free() and SSL_CTX_free() have explicit NULL checks, so there is no
need to have additional checks here.

Add NPN regress tests from OpenSSL. However, unlike OpenSSL, actually exit
with a failure if the NPN verification fails.

More KNF.

Remove #ifndefs for OPENSSL_NO_DH, OPENSSL_NO_ECDH and
OPENSSL_NO_X509_VERIFY. We're not going to build with these and the same
removal has already been done for libssl.

Remove PSK from the ssl regress.

Uncompress ssltest.

Add DTLS support to ssltest and wire up some regress tests.

ok miod@

Remove support for the `opaque PRF input' extension, which draft has expired
7 years ago and never made it into an RFC. That code wasn't compiled in
anyway unless one would define the actual on-the-wire extension id bytes;
crank libssl major.

With help and enlightenment from Brendan MacDonell.

Build with WARNINGS=Yes and Werror.

Move ssltest.c to a regress test.

Remove last OPENSSL_NO_ENGINE from libssl regress

Avoid memcmp() with NULL pointer and 0 length

Prepare the ssltest for the upcoming bump

This is a hack. The test is in rather poor shape and it is hard to tell
whether it still does what it is supposed to be doing. Hopefully somemone
will rewrite this in a style that doesn't make me squeal on opening this
file...

Plug leak in the ssltest

Removing -tls1 moved some tests from the legacy stack to the TLSv1.3 stack.
On a HRR, the alpn callback would be called twice and allocate the global
twice, thereby leaking. So free it up front.

Joint suffering with bcook and beck

Disable TLS 1.0 and TLS 1.1 in libssl

Their time has long since past, and they should not be used.
This change restricts ssl to versions 1.2 and 1.3, and changes
the regression tests to understand we no longer speak the legacy
protocols.

For the moment the magical "golden" byte for byte comparison
tests of raw handshake values are disabled util jsing fixes them.

ok jsing@ tb@

ssltest: Drop more policy go from this test.

Hopefully that is all. What an absolutely horrid mess.

ssltest: initial pass of dropping proxy cert goo

Sync function prototypes and declarations to satisfy clang 15.

ok jsing@

Make internal header file names consistent

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names
used for internal headers. Move all these headers we inherited from
OpenSSL to *_local.h, reserving the name *_internal.h for our own code.
Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h.
constant_time_locl.h is moved to constant_time.h since it's special.

Adjust all .c files in libcrypto, libssl and regress.

The diff is mechanical with the exception of tls13_quic.c, where
#include <ssl_locl.h> was fixed manually.

discussed with jsing,
no objection bcook

Make the ssltest security level aware.

From beck

Switch ssltest to using the newly generated certs that use SHA-256 instead
of SHA-1. This helps the switch to security-level aware ssltest.

From jsing

Prepare ssltest for opaque DH

Fix ssltest to work with opaque EVP_PKEY.

Make this test compile again after the damage done in libcrypto

Pull in ssl_locl.h so that we can keep reaching into libssl internals.

ssltest.c does not need param.h

From Jonas Termansen

Garbage collect do_test_cipherlist().

This code no longer compiles and the equivalent test coverage has been
added to regress/lib/libssl/ciphers (and is actually run).

Disable some code that reaches into libssl internals.

This should be moved to a dedicated regress test.

Add a -tls1_2 option so we can force TLSv1.2 for testing.

Remove temporary RSA keys/callbacks code.

This was removed from libssl a very long time ago...

exitting -> exiting

From Michael Scovetta, PR #108

Add automatic threading initialization for libcrypto.

This implements automatic thread support initialization in libcrypto.
This does not remove any functions from the ABI, but does turn them into
no-ops. Stub implementations of pthread_mutex_(init|lock|unlock) are
provided for ramdisks.

This does not implement the new OpenSSL 1.1 thread API internally,
keeping the original CRYTPO_lock / CRYPTO_add_lock functions for library
locking. For -portable, crypto_lock.c can be reimplemented with
OS-specific primitives as needed.

ok beck@, tb@, looks sane guenther@

Remove NPN test coverage.

Treat "ERROR in STARTUP" as an actual error, rather than failing without
exiting non-zero (which has been masking a DTLS related issue). Also make
the message consistent with other errors.

Spotted by inogochi@

Remove commented out code and fix indentation of surrounding statements.

Remove handling for SSLv2.

Use prime256v1 for tests unless otherwise specified.

remove e_os2.h includes
ok jsing@

Remove SSLv3 support from LibreSSL regression tests.

Reject DH keys sent by a server if they are considered too small; inspired
by a similar BoringSSL change, but raising the limit to 1024 bits.
ok jsing@ markus@ guenther@ deraadt@

unifdef OPENSSL_NO_NEXTPROTONEG

Add regress for ALPN.

Based on OpenSSL.

The -ssl2 flag does nothing - remove the flag and any tests that were
using it.

Remove _XOPEN_SOURCE_EXTENDED since we're not too concerned about
gethostname being declared properly on Compaq platforms that use DEC C...

BIO_free() and SSL_CTX_free() have explicit NULL checks, so there is no
need to have additional checks here.

Add NPN regress tests from OpenSSL. However, unlike OpenSSL, actually exit
with a failure if the NPN verification fails.

More KNF.

Remove #ifndefs for OPENSSL_NO_DH, OPENSSL_NO_ECDH and
OPENSSL_NO_X509_VERIFY. We're not going to build with these and the same
removal has already been done for libssl.

Remove PSK from the ssl regress.

Uncompress ssltest.

Add DTLS support to ssltest and wire up some regress tests.

ok miod@

Remove support for the `opaque PRF input' extension, which draft has expired
7 years ago and never made it into an RFC. That code wasn't compiled in
anyway unless one would define the actual on-the-wire extension id bytes;
crank libssl major.

With help and enlightenment from Brendan MacDonell.

Build with WARNINGS=Yes and Werror.

Move ssltest.c to a regress test.

Avoid memcmp() with NULL pointer and 0 length

Prepare the ssltest for the upcoming bump

This is a hack. The test is in rather poor shape and it is hard to tell
whether it still does what it is supposed to be doing. Hopefully somemone
will rewrite this in a style that doesn't make me squeal on opening this
file...

Plug leak in the ssltest

Removing -tls1 moved some tests from the legacy stack to the TLSv1.3 stack.
On a HRR, the alpn callback would be called twice and allocate the global
twice, thereby leaking. So free it up front.

Joint suffering with bcook and beck

Disable TLS 1.0 and TLS 1.1 in libssl

Their time has long since past, and they should not be used.
This change restricts ssl to versions 1.2 and 1.3, and changes
the regression tests to understand we no longer speak the legacy
protocols.

For the moment the magical "golden" byte for byte comparison
tests of raw handshake values are disabled util jsing fixes them.

ok jsing@ tb@

ssltest: Drop more policy go from this test.

Hopefully that is all. What an absolutely horrid mess.

ssltest: initial pass of dropping proxy cert goo

Sync function prototypes and declarations to satisfy clang 15.

ok jsing@

Make internal header file names consistent

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names
used for internal headers. Move all these headers we inherited from
OpenSSL to *_local.h, reserving the name *_internal.h for our own code.
Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h.
constant_time_locl.h is moved to constant_time.h since it's special.

Adjust all .c files in libcrypto, libssl and regress.

The diff is mechanical with the exception of tls13_quic.c, where
#include <ssl_locl.h> was fixed manually.

discussed with jsing,
no objection bcook

Make the ssltest security level aware.

From beck

Switch ssltest to using the newly generated certs that use SHA-256 instead
of SHA-1. This helps the switch to security-level aware ssltest.

From jsing

Prepare ssltest for opaque DH

Fix ssltest to work with opaque EVP_PKEY.

Make this test compile again after the damage done in libcrypto

Pull in ssl_locl.h so that we can keep reaching into libssl internals.

ssltest.c does not need param.h

From Jonas Termansen

Garbage collect do_test_cipherlist().

This code no longer compiles and the equivalent test coverage has been
added to regress/lib/libssl/ciphers (and is actually run).

Disable some code that reaches into libssl internals.

This should be moved to a dedicated regress test.

Add a -tls1_2 option so we can force TLSv1.2 for testing.

Remove temporary RSA keys/callbacks code.

This was removed from libssl a very long time ago...

exitting -> exiting

From Michael Scovetta, PR #108

Add automatic threading initialization for libcrypto.

This implements automatic thread support initialization in libcrypto.
This does not remove any functions from the ABI, but does turn them into
no-ops. Stub implementations of pthread_mutex_(init|lock|unlock) are
provided for ramdisks.

This does not implement the new OpenSSL 1.1 thread API internally,
keeping the original CRYTPO_lock / CRYPTO_add_lock functions for library
locking. For -portable, crypto_lock.c can be reimplemented with
OS-specific primitives as needed.

ok beck@, tb@, looks sane guenther@

Remove NPN test coverage.

Treat "ERROR in STARTUP" as an actual error, rather than failing without
exiting non-zero (which has been masking a DTLS related issue). Also make
the message consistent with other errors.

Spotted by inogochi@

Remove commented out code and fix indentation of surrounding statements.

Remove handling for SSLv2.

Use prime256v1 for tests unless otherwise specified.

remove e_os2.h includes
ok jsing@

Remove SSLv3 support from LibreSSL regression tests.

Reject DH keys sent by a server if they are considered too small; inspired
by a similar BoringSSL change, but raising the limit to 1024 bits.
ok jsing@ markus@ guenther@ deraadt@

unifdef OPENSSL_NO_NEXTPROTONEG

Add regress for ALPN.

Based on OpenSSL.

The -ssl2 flag does nothing - remove the flag and any tests that were
using it.

Remove _XOPEN_SOURCE_EXTENDED since we're not too concerned about
gethostname being declared properly on Compaq platforms that use DEC C...

BIO_free() and SSL_CTX_free() have explicit NULL checks, so there is no
need to have additional checks here.

Add NPN regress tests from OpenSSL. However, unlike OpenSSL, actually exit
with a failure if the NPN verification fails.

More KNF.

Remove #ifndefs for OPENSSL_NO_DH, OPENSSL_NO_ECDH and
OPENSSL_NO_X509_VERIFY. We're not going to build with these and the same
removal has already been done for libssl.

Remove PSK from the ssl regress.

Uncompress ssltest.

Add DTLS support to ssltest and wire up some regress tests.

ok miod@

Remove support for the `opaque PRF input' extension, which draft has expired
7 years ago and never made it into an RFC. That code wasn't compiled in
anyway unless one would define the actual on-the-wire extension id bytes;
crank libssl major.

With help and enlightenment from Brendan MacDonell.

Build with WARNINGS=Yes and Werror.

Move ssltest.c to a regress test.

Prepare the ssltest for the upcoming bump

This is a hack. The test is in rather poor shape and it is hard to tell
whether it still does what it is supposed to be doing. Hopefully somemone
will rewrite this in a style that doesn't make me squeal on opening this
file...

Plug leak in the ssltest

Removing -tls1 moved some tests from the legacy stack to the TLSv1.3 stack.
On a HRR, the alpn callback would be called twice and allocate the global
twice, thereby leaking. So free it up front.

Joint suffering with bcook and beck

Disable TLS 1.0 and TLS 1.1 in libssl

Their time has long since past, and they should not be used.
This change restricts ssl to versions 1.2 and 1.3, and changes
the regression tests to understand we no longer speak the legacy
protocols.

For the moment the magical "golden" byte for byte comparison
tests of raw handshake values are disabled util jsing fixes them.

ok jsing@ tb@

ssltest: Drop more policy go from this test.

Hopefully that is all. What an absolutely horrid mess.

ssltest: initial pass of dropping proxy cert goo

Sync function prototypes and declarations to satisfy clang 15.

ok jsing@

Make internal header file names consistent

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names
used for internal headers. Move all these headers we inherited from
OpenSSL to *_local.h, reserving the name *_internal.h for our own code.
Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h.
constant_time_locl.h is moved to constant_time.h since it's special.

Adjust all .c files in libcrypto, libssl and regress.

The diff is mechanical with the exception of tls13_quic.c, where
#include <ssl_locl.h> was fixed manually.

discussed with jsing,
no objection bcook

Make the ssltest security level aware.

From beck

Switch ssltest to using the newly generated certs that use SHA-256 instead
of SHA-1. This helps the switch to security-level aware ssltest.

From jsing

Prepare ssltest for opaque DH

Fix ssltest to work with opaque EVP_PKEY.

Make this test compile again after the damage done in libcrypto

Pull in ssl_locl.h so that we can keep reaching into libssl internals.

ssltest.c does not need param.h

From Jonas Termansen

Garbage collect do_test_cipherlist().

This code no longer compiles and the equivalent test coverage has been
added to regress/lib/libssl/ciphers (and is actually run).

Disable some code that reaches into libssl internals.

This should be moved to a dedicated regress test.

Add a -tls1_2 option so we can force TLSv1.2 for testing.

Remove temporary RSA keys/callbacks code.

This was removed from libssl a very long time ago...

exitting -> exiting

From Michael Scovetta, PR #108

Add automatic threading initialization for libcrypto.

This implements automatic thread support initialization in libcrypto.
This does not remove any functions from the ABI, but does turn them into
no-ops. Stub implementations of pthread_mutex_(init|lock|unlock) are
provided for ramdisks.

This does not implement the new OpenSSL 1.1 thread API internally,
keeping the original CRYTPO_lock / CRYPTO_add_lock functions for library
locking. For -portable, crypto_lock.c can be reimplemented with
OS-specific primitives as needed.

ok beck@, tb@, looks sane guenther@

Remove NPN test coverage.

Treat "ERROR in STARTUP" as an actual error, rather than failing without
exiting non-zero (which has been masking a DTLS related issue). Also make
the message consistent with other errors.

Spotted by inogochi@

Remove commented out code and fix indentation of surrounding statements.

Remove handling for SSLv2.

Use prime256v1 for tests unless otherwise specified.

remove e_os2.h includes
ok jsing@

Remove SSLv3 support from LibreSSL regression tests.

Reject DH keys sent by a server if they are considered too small; inspired
by a similar BoringSSL change, but raising the limit to 1024 bits.
ok jsing@ markus@ guenther@ deraadt@

unifdef OPENSSL_NO_NEXTPROTONEG

Add regress for ALPN.

Based on OpenSSL.

The -ssl2 flag does nothing - remove the flag and any tests that were
using it.

Remove _XOPEN_SOURCE_EXTENDED since we're not too concerned about
gethostname being declared properly on Compaq platforms that use DEC C...

BIO_free() and SSL_CTX_free() have explicit NULL checks, so there is no
need to have additional checks here.

Add NPN regress tests from OpenSSL. However, unlike OpenSSL, actually exit
with a failure if the NPN verification fails.

More KNF.

Remove #ifndefs for OPENSSL_NO_DH, OPENSSL_NO_ECDH and
OPENSSL_NO_X509_VERIFY. We're not going to build with these and the same
removal has already been done for libssl.

Remove PSK from the ssl regress.

Uncompress ssltest.

Add DTLS support to ssltest and wire up some regress tests.

ok miod@

Remove support for the `opaque PRF input' extension, which draft has expired
7 years ago and never made it into an RFC. That code wasn't compiled in
anyway unless one would define the actual on-the-wire extension id bytes;
crank libssl major.

With help and enlightenment from Brendan MacDonell.

Build with WARNINGS=Yes and Werror.

Move ssltest.c to a regress test.

Plug leak in the ssltest

Removing -tls1 moved some tests from the legacy stack to the TLSv1.3 stack.
On a HRR, the alpn callback would be called twice and allocate the global
twice, thereby leaking. So free it up front.

Joint suffering with bcook and beck

Disable TLS 1.0 and TLS 1.1 in libssl

Their time has long since past, and they should not be used.
This change restricts ssl to versions 1.2 and 1.3, and changes
the regression tests to understand we no longer speak the legacy
protocols.

For the moment the magical "golden" byte for byte comparison
tests of raw handshake values are disabled util jsing fixes them.

ok jsing@ tb@

ssltest: Drop more policy go from this test.

Hopefully that is all. What an absolutely horrid mess.

ssltest: initial pass of dropping proxy cert goo

Sync function prototypes and declarations to satisfy clang 15.

ok jsing@

Make internal header file names consistent

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names
used for internal headers. Move all these headers we inherited from
OpenSSL to *_local.h, reserving the name *_internal.h for our own code.
Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h.
constant_time_locl.h is moved to constant_time.h since it's special.

Adjust all .c files in libcrypto, libssl and regress.

The diff is mechanical with the exception of tls13_quic.c, where
#include <ssl_locl.h> was fixed manually.

discussed with jsing,
no objection bcook

Make the ssltest security level aware.

From beck

Switch ssltest to using the newly generated certs that use SHA-256 instead
of SHA-1. This helps the switch to security-level aware ssltest.

From jsing

Prepare ssltest for opaque DH

Fix ssltest to work with opaque EVP_PKEY.

Make this test compile again after the damage done in libcrypto

Pull in ssl_locl.h so that we can keep reaching into libssl internals.

ssltest.c does not need param.h

From Jonas Termansen

Garbage collect do_test_cipherlist().

This code no longer compiles and the equivalent test coverage has been
added to regress/lib/libssl/ciphers (and is actually run).

Disable some code that reaches into libssl internals.

This should be moved to a dedicated regress test.

Add a -tls1_2 option so we can force TLSv1.2 for testing.

Remove temporary RSA keys/callbacks code.

This was removed from libssl a very long time ago...

exitting -> exiting

From Michael Scovetta, PR #108

Add automatic threading initialization for libcrypto.

This implements automatic thread support initialization in libcrypto.
This does not remove any functions from the ABI, but does turn them into
no-ops. Stub implementations of pthread_mutex_(init|lock|unlock) are
provided for ramdisks.

This does not implement the new OpenSSL 1.1 thread API internally,
keeping the original CRYTPO_lock / CRYPTO_add_lock functions for library
locking. For -portable, crypto_lock.c can be reimplemented with
OS-specific primitives as needed.

ok beck@, tb@, looks sane guenther@

Remove NPN test coverage.

Treat "ERROR in STARTUP" as an actual error, rather than failing without
exiting non-zero (which has been masking a DTLS related issue). Also make
the message consistent with other errors.

Spotted by inogochi@

Remove commented out code and fix indentation of surrounding statements.

Remove handling for SSLv2.

Use prime256v1 for tests unless otherwise specified.

remove e_os2.h includes
ok jsing@

Remove SSLv3 support from LibreSSL regression tests.

Reject DH keys sent by a server if they are considered too small; inspired
by a similar BoringSSL change, but raising the limit to 1024 bits.
ok jsing@ markus@ guenther@ deraadt@

unifdef OPENSSL_NO_NEXTPROTONEG

Add regress for ALPN.

Based on OpenSSL.

The -ssl2 flag does nothing - remove the flag and any tests that were
using it.

Remove _XOPEN_SOURCE_EXTENDED since we're not too concerned about
gethostname being declared properly on Compaq platforms that use DEC C...

BIO_free() and SSL_CTX_free() have explicit NULL checks, so there is no
need to have additional checks here.

Add NPN regress tests from OpenSSL. However, unlike OpenSSL, actually exit
with a failure if the NPN verification fails.

More KNF.

Remove #ifndefs for OPENSSL_NO_DH, OPENSSL_NO_ECDH and
OPENSSL_NO_X509_VERIFY. We're not going to build with these and the same
removal has already been done for libssl.

Remove PSK from the ssl regress.

Uncompress ssltest.

Add DTLS support to ssltest and wire up some regress tests.

ok miod@

Remove support for the `opaque PRF input' extension, which draft has expired
7 years ago and never made it into an RFC. That code wasn't compiled in
anyway unless one would define the actual on-the-wire extension id bytes;
crank libssl major.

With help and enlightenment from Brendan MacDonell.

Build with WARNINGS=Yes and Werror.

Move ssltest.c to a regress test.

ssltest: Drop more policy go from this test.

Hopefully that is all. What an absolutely horrid mess.

ssltest: initial pass of dropping proxy cert goo

Sync function prototypes and declarations to satisfy clang 15.

ok jsing@

Make internal header file names consistent

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names
used for internal headers. Move all these headers we inherited from
OpenSSL to *_local.h, reserving the name *_internal.h for our own code.
Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h.
constant_time_locl.h is moved to constant_time.h since it's special.

Adjust all .c files in libcrypto, libssl and regress.

The diff is mechanical with the exception of tls13_quic.c, where
#include <ssl_locl.h> was fixed manually.

discussed with jsing,
no objection bcook

Make the ssltest security level aware.

From beck

Switch ssltest to using the newly generated certs that use SHA-256 instead
of SHA-1. This helps the switch to security-level aware ssltest.

From jsing

Prepare ssltest for opaque DH

Fix ssltest to work with opaque EVP_PKEY.

Make this test compile again after the damage done in libcrypto

Pull in ssl_locl.h so that we can keep reaching into libssl internals.

ssltest.c does not need param.h

From Jonas Termansen

Garbage collect do_test_cipherlist().

This code no longer compiles and the equivalent test coverage has been
added to regress/lib/libssl/ciphers (and is actually run).

Disable some code that reaches into libssl internals.

This should be moved to a dedicated regress test.

Add a -tls1_2 option so we can force TLSv1.2 for testing.

Remove temporary RSA keys/callbacks code.

This was removed from libssl a very long time ago...

exitting -> exiting

From Michael Scovetta, PR #108

Add automatic threading initialization for libcrypto.

This implements automatic thread support initialization in libcrypto.
This does not remove any functions from the ABI, but does turn them into
no-ops. Stub implementations of pthread_mutex_(init|lock|unlock) are
provided for ramdisks.

This does not implement the new OpenSSL 1.1 thread API internally,
keeping the original CRYTPO_lock / CRYPTO_add_lock functions for library
locking. For -portable, crypto_lock.c can be reimplemented with
OS-specific primitives as needed.

ok beck@, tb@, looks sane guenther@

Remove NPN test coverage.

Treat "ERROR in STARTUP" as an actual error, rather than failing without
exiting non-zero (which has been masking a DTLS related issue). Also make
the message consistent with other errors.

Spotted by inogochi@

Remove commented out code and fix indentation of surrounding statements.

Remove handling for SSLv2.

Use prime256v1 for tests unless otherwise specified.

remove e_os2.h includes
ok jsing@

Remove SSLv3 support from LibreSSL regression tests.

Reject DH keys sent by a server if they are considered too small; inspired
by a similar BoringSSL change, but raising the limit to 1024 bits.
ok jsing@ markus@ guenther@ deraadt@

unifdef OPENSSL_NO_NEXTPROTONEG

Add regress for ALPN.

Based on OpenSSL.

The -ssl2 flag does nothing - remove the flag and any tests that were
using it.

Remove _XOPEN_SOURCE_EXTENDED since we're not too concerned about
gethostname being declared properly on Compaq platforms that use DEC C...

BIO_free() and SSL_CTX_free() have explicit NULL checks, so there is no
need to have additional checks here.

Add NPN regress tests from OpenSSL. However, unlike OpenSSL, actually exit
with a failure if the NPN verification fails.

More KNF.

Remove #ifndefs for OPENSSL_NO_DH, OPENSSL_NO_ECDH and
OPENSSL_NO_X509_VERIFY. We're not going to build with these and the same
removal has already been done for libssl.

Remove PSK from the ssl regress.

Uncompress ssltest.

Add DTLS support to ssltest and wire up some regress tests.

ok miod@

Remove support for the `opaque PRF input' extension, which draft has expired
7 years ago and never made it into an RFC. That code wasn't compiled in
anyway unless one would define the actual on-the-wire extension id bytes;
crank libssl major.

With help and enlightenment from Brendan MacDonell.

Build with WARNINGS=Yes and Werror.

Move ssltest.c to a regress test.

Sync function prototypes and declarations to satisfy clang 15.

ok jsing@

Make internal header file names consistent

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names
used for internal headers. Move all these headers we inherited from
OpenSSL to *_local.h, reserving the name *_internal.h for our own code.
Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h.
constant_time_locl.h is moved to constant_time.h since it's special.

Adjust all .c files in libcrypto, libssl and regress.

The diff is mechanical with the exception of tls13_quic.c, where
#include <ssl_locl.h> was fixed manually.

discussed with jsing,
no objection bcook

Make the ssltest security level aware.

From beck

Switch ssltest to using the newly generated certs that use SHA-256 instead
of SHA-1. This helps the switch to security-level aware ssltest.

From jsing

Prepare ssltest for opaque DH

Fix ssltest to work with opaque EVP_PKEY.

Make this test compile again after the damage done in libcrypto

Pull in ssl_locl.h so that we can keep reaching into libssl internals.

ssltest.c does not need param.h

From Jonas Termansen

Garbage collect do_test_cipherlist().

This code no longer compiles and the equivalent test coverage has been
added to regress/lib/libssl/ciphers (and is actually run).

Disable some code that reaches into libssl internals.

This should be moved to a dedicated regress test.

Add a -tls1_2 option so we can force TLSv1.2 for testing.

Remove temporary RSA keys/callbacks code.

This was removed from libssl a very long time ago...

exitting -> exiting

From Michael Scovetta, PR #108

Add automatic threading initialization for libcrypto.

This implements automatic thread support initialization in libcrypto.
This does not remove any functions from the ABI, but does turn them into
no-ops. Stub implementations of pthread_mutex_(init|lock|unlock) are
provided for ramdisks.

This does not implement the new OpenSSL 1.1 thread API internally,
keeping the original CRYTPO_lock / CRYPTO_add_lock functions for library
locking. For -portable, crypto_lock.c can be reimplemented with
OS-specific primitives as needed.

ok beck@, tb@, looks sane guenther@

Remove NPN test coverage.

Treat "ERROR in STARTUP" as an actual error, rather than failing without
exiting non-zero (which has been masking a DTLS related issue). Also make
the message consistent with other errors.

Spotted by inogochi@

Remove commented out code and fix indentation of surrounding statements.

Remove handling for SSLv2.

Use prime256v1 for tests unless otherwise specified.

remove e_os2.h includes
ok jsing@

Remove SSLv3 support from LibreSSL regression tests.

Reject DH keys sent by a server if they are considered too small; inspired
by a similar BoringSSL change, but raising the limit to 1024 bits.
ok jsing@ markus@ guenther@ deraadt@

unifdef OPENSSL_NO_NEXTPROTONEG

Add regress for ALPN.

Based on OpenSSL.

The -ssl2 flag does nothing - remove the flag and any tests that were
using it.

Remove _XOPEN_SOURCE_EXTENDED since we're not too concerned about
gethostname being declared properly on Compaq platforms that use DEC C...

BIO_free() and SSL_CTX_free() have explicit NULL checks, so there is no
need to have additional checks here.

Add NPN regress tests from OpenSSL. However, unlike OpenSSL, actually exit
with a failure if the NPN verification fails.

More KNF.

Remove #ifndefs for OPENSSL_NO_DH, OPENSSL_NO_ECDH and
OPENSSL_NO_X509_VERIFY. We're not going to build with these and the same
removal has already been done for libssl.

Remove PSK from the ssl regress.

Uncompress ssltest.

Add DTLS support to ssltest and wire up some regress tests.

ok miod@

Remove support for the `opaque PRF input' extension, which draft has expired
7 years ago and never made it into an RFC. That code wasn't compiled in
anyway unless one would define the actual on-the-wire extension id bytes;
crank libssl major.

With help and enlightenment from Brendan MacDonell.

Build with WARNINGS=Yes and Werror.

Move ssltest.c to a regress test.

Make internal header file names consistent

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names
used for internal headers. Move all these headers we inherited from
OpenSSL to *_local.h, reserving the name *_internal.h for our own code.
Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h.
constant_time_locl.h is moved to constant_time.h since it's special.

Adjust all .c files in libcrypto, libssl and regress.

The diff is mechanical with the exception of tls13_quic.c, where
#include <ssl_locl.h> was fixed manually.

discussed with jsing,
no objection bcook

Make the ssltest security level aware.

From beck

Switch ssltest to using the newly generated certs that use SHA-256 instead
of SHA-1. This helps the switch to security-level aware ssltest.

From jsing

Prepare ssltest for opaque DH

Fix ssltest to work with opaque EVP_PKEY.

Make this test compile again after the damage done in libcrypto

Pull in ssl_locl.h so that we can keep reaching into libssl internals.

ssltest.c does not need param.h

From Jonas Termansen

Garbage collect do_test_cipherlist().

This code no longer compiles and the equivalent test coverage has been
added to regress/lib/libssl/ciphers (and is actually run).

Disable some code that reaches into libssl internals.

This should be moved to a dedicated regress test.

Add a -tls1_2 option so we can force TLSv1.2 for testing.

Remove temporary RSA keys/callbacks code.

This was removed from libssl a very long time ago...

exitting -> exiting

From Michael Scovetta, PR #108

Add automatic threading initialization for libcrypto.

This implements automatic thread support initialization in libcrypto.
This does not remove any functions from the ABI, but does turn them into
no-ops. Stub implementations of pthread_mutex_(init|lock|unlock) are
provided for ramdisks.

This does not implement the new OpenSSL 1.1 thread API internally,
keeping the original CRYTPO_lock / CRYPTO_add_lock functions for library
locking. For -portable, crypto_lock.c can be reimplemented with
OS-specific primitives as needed.

ok beck@, tb@, looks sane guenther@

Remove NPN test coverage.

Treat "ERROR in STARTUP" as an actual error, rather than failing without
exiting non-zero (which has been masking a DTLS related issue). Also make
the message consistent with other errors.

Spotted by inogochi@

Remove commented out code and fix indentation of surrounding statements.

Remove handling for SSLv2.

Use prime256v1 for tests unless otherwise specified.

remove e_os2.h includes
ok jsing@

Remove SSLv3 support from LibreSSL regression tests.

Reject DH keys sent by a server if they are considered too small; inspired
by a similar BoringSSL change, but raising the limit to 1024 bits.
ok jsing@ markus@ guenther@ deraadt@

unifdef OPENSSL_NO_NEXTPROTONEG

Add regress for ALPN.

Based on OpenSSL.

The -ssl2 flag does nothing - remove the flag and any tests that were
using it.

Remove _XOPEN_SOURCE_EXTENDED since we're not too concerned about
gethostname being declared properly on Compaq platforms that use DEC C...

BIO_free() and SSL_CTX_free() have explicit NULL checks, so there is no
need to have additional checks here.

Add NPN regress tests from OpenSSL. However, unlike OpenSSL, actually exit
with a failure if the NPN verification fails.

More KNF.

Remove #ifndefs for OPENSSL_NO_DH, OPENSSL_NO_ECDH and
OPENSSL_NO_X509_VERIFY. We're not going to build with these and the same
removal has already been done for libssl.

Remove PSK from the ssl regress.

Uncompress ssltest.

Add DTLS support to ssltest and wire up some regress tests.

ok miod@

Remove support for the `opaque PRF input' extension, which draft has expired
7 years ago and never made it into an RFC. That code wasn't compiled in
anyway unless one would define the actual on-the-wire extension id bytes;
crank libssl major.

With help and enlightenment from Brendan MacDonell.

Build with WARNINGS=Yes and Werror.

Move ssltest.c to a regress test.

Make the ssltest security level aware.

From beck

Switch ssltest to using the newly generated certs that use SHA-256 instead
of SHA-1. This helps the switch to security-level aware ssltest.

From jsing

Prepare ssltest for opaque DH

Fix ssltest to work with opaque EVP_PKEY.

Make this test compile again after the damage done in libcrypto

Pull in ssl_locl.h so that we can keep reaching into libssl internals.

ssltest.c does not need param.h

From Jonas Termansen

Garbage collect do_test_cipherlist().

This code no longer compiles and the equivalent test coverage has been
added to regress/lib/libssl/ciphers (and is actually run).

Disable some code that reaches into libssl internals.

This should be moved to a dedicated regress test.

Add a -tls1_2 option so we can force TLSv1.2 for testing.

Remove temporary RSA keys/callbacks code.

This was removed from libssl a very long time ago...

exitting -> exiting

From Michael Scovetta, PR #108

Add automatic threading initialization for libcrypto.

This implements automatic thread support initialization in libcrypto.
This does not remove any functions from the ABI, but does turn them into
no-ops. Stub implementations of pthread_mutex_(init|lock|unlock) are
provided for ramdisks.

This does not implement the new OpenSSL 1.1 thread API internally,
keeping the original CRYTPO_lock / CRYPTO_add_lock functions for library
locking. For -portable, crypto_lock.c can be reimplemented with
OS-specific primitives as needed.

ok beck@, tb@, looks sane guenther@

Remove NPN test coverage.

Treat "ERROR in STARTUP" as an actual error, rather than failing without
exiting non-zero (which has been masking a DTLS related issue). Also make
the message consistent with other errors.

Spotted by inogochi@

Remove commented out code and fix indentation of surrounding statements.

Remove handling for SSLv2.

Use prime256v1 for tests unless otherwise specified.

remove e_os2.h includes
ok jsing@

Remove SSLv3 support from LibreSSL regression tests.

Reject DH keys sent by a server if they are considered too small; inspired
by a similar BoringSSL change, but raising the limit to 1024 bits.
ok jsing@ markus@ guenther@ deraadt@

unifdef OPENSSL_NO_NEXTPROTONEG

Add regress for ALPN.

Based on OpenSSL.

The -ssl2 flag does nothing - remove the flag and any tests that were
using it.

Remove _XOPEN_SOURCE_EXTENDED since we're not too concerned about
gethostname being declared properly on Compaq platforms that use DEC C...

BIO_free() and SSL_CTX_free() have explicit NULL checks, so there is no
need to have additional checks here.

Add NPN regress tests from OpenSSL. However, unlike OpenSSL, actually exit
with a failure if the NPN verification fails.

More KNF.

Remove #ifndefs for OPENSSL_NO_DH, OPENSSL_NO_ECDH and
OPENSSL_NO_X509_VERIFY. We're not going to build with these and the same
removal has already been done for libssl.

Remove PSK from the ssl regress.

Uncompress ssltest.

Add DTLS support to ssltest and wire up some regress tests.

ok miod@

Remove support for the `opaque PRF input' extension, which draft has expired
7 years ago and never made it into an RFC. That code wasn't compiled in
anyway unless one would define the actual on-the-wire extension id bytes;
crank libssl major.

With help and enlightenment from Brendan MacDonell.

Build with WARNINGS=Yes and Werror.

Move ssltest.c to a regress test.

Prepare ssltest for opaque DH

Fix ssltest to work with opaque EVP_PKEY.

Make this test compile again after the damage done in libcrypto

Pull in ssl_locl.h so that we can keep reaching into libssl internals.

ssltest.c does not need param.h

From Jonas Termansen

Garbage collect do_test_cipherlist().

This code no longer compiles and the equivalent test coverage has been
added to regress/lib/libssl/ciphers (and is actually run).

Disable some code that reaches into libssl internals.

This should be moved to a dedicated regress test.

Add a -tls1_2 option so we can force TLSv1.2 for testing.

Remove temporary RSA keys/callbacks code.

This was removed from libssl a very long time ago...

exitting -> exiting

From Michael Scovetta, PR #108

Add automatic threading initialization for libcrypto.

This implements automatic thread support initialization in libcrypto.
This does not remove any functions from the ABI, but does turn them into
no-ops. Stub implementations of pthread_mutex_(init|lock|unlock) are
provided for ramdisks.

This does not implement the new OpenSSL 1.1 thread API internally,
keeping the original CRYTPO_lock / CRYPTO_add_lock functions for library
locking. For -portable, crypto_lock.c can be reimplemented with
OS-specific primitives as needed.

ok beck@, tb@, looks sane guenther@

Remove NPN test coverage.

Treat "ERROR in STARTUP" as an actual error, rather than failing without
exiting non-zero (which has been masking a DTLS related issue). Also make
the message consistent with other errors.

Spotted by inogochi@

Remove commented out code and fix indentation of surrounding statements.

Remove handling for SSLv2.

Use prime256v1 for tests unless otherwise specified.

remove e_os2.h includes
ok jsing@

Remove SSLv3 support from LibreSSL regression tests.

Reject DH keys sent by a server if they are considered too small; inspired
by a similar BoringSSL change, but raising the limit to 1024 bits.
ok jsing@ markus@ guenther@ deraadt@

unifdef OPENSSL_NO_NEXTPROTONEG

Add regress for ALPN.

Based on OpenSSL.

The -ssl2 flag does nothing - remove the flag and any tests that were
using it.

Remove _XOPEN_SOURCE_EXTENDED since we're not too concerned about
gethostname being declared properly on Compaq platforms that use DEC C...

BIO_free() and SSL_CTX_free() have explicit NULL checks, so there is no
need to have additional checks here.

Add NPN regress tests from OpenSSL. However, unlike OpenSSL, actually exit
with a failure if the NPN verification fails.

More KNF.

Remove #ifndefs for OPENSSL_NO_DH, OPENSSL_NO_ECDH and
OPENSSL_NO_X509_VERIFY. We're not going to build with these and the same
removal has already been done for libssl.

Remove PSK from the ssl regress.

Uncompress ssltest.

Add DTLS support to ssltest and wire up some regress tests.

ok miod@

Remove support for the `opaque PRF input' extension, which draft has expired
7 years ago and never made it into an RFC. That code wasn't compiled in
anyway unless one would define the actual on-the-wire extension id bytes;
crank libssl major.

With help and enlightenment from Brendan MacDonell.

Build with WARNINGS=Yes and Werror.

Move ssltest.c to a regress test.

Fix ssltest to work with opaque EVP_PKEY.

Make this test compile again after the damage done in libcrypto

Pull in ssl_locl.h so that we can keep reaching into libssl internals.

ssltest.c does not need param.h

From Jonas Termansen

Garbage collect do_test_cipherlist().

This code no longer compiles and the equivalent test coverage has been
added to regress/lib/libssl/ciphers (and is actually run).

Disable some code that reaches into libssl internals.

This should be moved to a dedicated regress test.

Add a -tls1_2 option so we can force TLSv1.2 for testing.

Remove temporary RSA keys/callbacks code.

This was removed from libssl a very long time ago...

exitting -> exiting

From Michael Scovetta, PR #108

Add automatic threading initialization for libcrypto.

This implements automatic thread support initialization in libcrypto.
This does not remove any functions from the ABI, but does turn them into
no-ops. Stub implementations of pthread_mutex_(init|lock|unlock) are
provided for ramdisks.

This does not implement the new OpenSSL 1.1 thread API internally,
keeping the original CRYTPO_lock / CRYPTO_add_lock functions for library
locking. For -portable, crypto_lock.c can be reimplemented with
OS-specific primitives as needed.

ok beck@, tb@, looks sane guenther@

Remove NPN test coverage.

Treat "ERROR in STARTUP" as an actual error, rather than failing without
exiting non-zero (which has been masking a DTLS related issue). Also make
the message consistent with other errors.

Spotted by inogochi@

Remove commented out code and fix indentation of surrounding statements.

Remove handling for SSLv2.

Use prime256v1 for tests unless otherwise specified.

remove e_os2.h includes
ok jsing@

Remove SSLv3 support from LibreSSL regression tests.

Reject DH keys sent by a server if they are considered too small; inspired
by a similar BoringSSL change, but raising the limit to 1024 bits.
ok jsing@ markus@ guenther@ deraadt@

unifdef OPENSSL_NO_NEXTPROTONEG

Add regress for ALPN.

Based on OpenSSL.

The -ssl2 flag does nothing - remove the flag and any tests that were
using it.

Remove _XOPEN_SOURCE_EXTENDED since we're not too concerned about
gethostname being declared properly on Compaq platforms that use DEC C...

BIO_free() and SSL_CTX_free() have explicit NULL checks, so there is no
need to have additional checks here.

Add NPN regress tests from OpenSSL. However, unlike OpenSSL, actually exit
with a failure if the NPN verification fails.

More KNF.

Remove #ifndefs for OPENSSL_NO_DH, OPENSSL_NO_ECDH and
OPENSSL_NO_X509_VERIFY. We're not going to build with these and the same
removal has already been done for libssl.

Remove PSK from the ssl regress.

Uncompress ssltest.

Add DTLS support to ssltest and wire up some regress tests.

ok miod@

Remove support for the `opaque PRF input' extension, which draft has expired
7 years ago and never made it into an RFC. That code wasn't compiled in
anyway unless one would define the actual on-the-wire extension id bytes;
crank libssl major.

With help and enlightenment from Brendan MacDonell.

Build with WARNINGS=Yes and Werror.

Move ssltest.c to a regress test.

Make this test compile again after the damage done in libcrypto

Pull in ssl_locl.h so that we can keep reaching into libssl internals.

ssltest.c does not need param.h

From Jonas Termansen

Garbage collect do_test_cipherlist().

This code no longer compiles and the equivalent test coverage has been
added to regress/lib/libssl/ciphers (and is actually run).

Disable some code that reaches into libssl internals.

This should be moved to a dedicated regress test.

Add a -tls1_2 option so we can force TLSv1.2 for testing.

Remove temporary RSA keys/callbacks code.

This was removed from libssl a very long time ago...

exitting -> exiting

From Michael Scovetta, PR #108

Add automatic threading initialization for libcrypto.

This implements automatic thread support initialization in libcrypto.
This does not remove any functions from the ABI, but does turn them into
no-ops. Stub implementations of pthread_mutex_(init|lock|unlock) are
provided for ramdisks.

This does not implement the new OpenSSL 1.1 thread API internally,
keeping the original CRYTPO_lock / CRYPTO_add_lock functions for library
locking. For -portable, crypto_lock.c can be reimplemented with
OS-specific primitives as needed.

ok beck@, tb@, looks sane guenther@

Remove NPN test coverage.

Treat "ERROR in STARTUP" as an actual error, rather than failing without
exiting non-zero (which has been masking a DTLS related issue). Also make
the message consistent with other errors.

Spotted by inogochi@

Remove commented out code and fix indentation of surrounding statements.

Remove handling for SSLv2.

Use prime256v1 for tests unless otherwise specified.

remove e_os2.h includes
ok jsing@

Remove SSLv3 support from LibreSSL regression tests.