userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@. With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

Use /tmp as opposed of /var/tmp as the default directory for temporary
files.

remove a couple hundred sys/param.h includes in userland code, and
also whack some sys/cdefs.h early includes which is such a brutally
bad pattern
ok bluhm mbuhl

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

no need to declare "extern optarg" and "extern optind"
when <unistd.h> is included;
patch from Jan Stary <hans at stare dot cz>;
OK millert

Fix all clang warnings in libc regress and cleanup some make files.

Use INT_MAX instead of SIZE_MAX as the maximum file size we can handle.
Fixes this test on 64-bit architectures.

ok visa@

Cast ctype functions' arguments to unsigned char.

SIZE_MAX is standard, we should be using it in preference to the
obsolete SIZE_T_MAX. OK miod@ beck@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

various cleanups; david says results are same

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Rename private err() function to dberr() to avoid collision with
libc's err().

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

$OpenBSD$

#if __STDC__ --> #ifdef __STDC__

r?index -> strr?chr

getopt(3) returns -1 when out of args, not EOF, whee!

db release 1.85

branches: 1.1.1;
Initial revision

Use /tmp as opposed of /var/tmp as the default directory for temporary
files.

remove a couple hundred sys/param.h includes in userland code, and
also whack some sys/cdefs.h early includes which is such a brutally
bad pattern
ok bluhm mbuhl

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

no need to declare "extern optarg" and "extern optind"
when <unistd.h> is included;
patch from Jan Stary <hans at stare dot cz>;
OK millert

Fix all clang warnings in libc regress and cleanup some make files.

Use INT_MAX instead of SIZE_MAX as the maximum file size we can handle.
Fixes this test on 64-bit architectures.

ok visa@

Cast ctype functions' arguments to unsigned char.

SIZE_MAX is standard, we should be using it in preference to the
obsolete SIZE_T_MAX. OK miod@ beck@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

various cleanups; david says results are same

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Rename private err() function to dberr() to avoid collision with
libc's err().

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

$OpenBSD$

#if __STDC__ --> #ifdef __STDC__

r?index -> strr?chr

getopt(3) returns -1 when out of args, not EOF, whee!

db release 1.85

branches: 1.1.1;
Initial revision

remove a couple hundred sys/param.h includes in userland code, and
also whack some sys/cdefs.h early includes which is such a brutally
bad pattern
ok bluhm mbuhl

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

no need to declare "extern optarg" and "extern optind"
when <unistd.h> is included;
patch from Jan Stary <hans at stare dot cz>;
OK millert

Fix all clang warnings in libc regress and cleanup some make files.

Use INT_MAX instead of SIZE_MAX as the maximum file size we can handle.
Fixes this test on 64-bit architectures.

ok visa@

Cast ctype functions' arguments to unsigned char.

SIZE_MAX is standard, we should be using it in preference to the
obsolete SIZE_T_MAX. OK miod@ beck@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

various cleanups; david says results are same

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Rename private err() function to dberr() to avoid collision with
libc's err().

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

$OpenBSD$

#if __STDC__ --> #ifdef __STDC__

r?index -> strr?chr

getopt(3) returns -1 when out of args, not EOF, whee!

db release 1.85

branches: 1.1.1;
Initial revision

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

no need to declare "extern optarg" and "extern optind"
when <unistd.h> is included;
patch from Jan Stary <hans at stare dot cz>;
OK millert

Fix all clang warnings in libc regress and cleanup some make files.

Use INT_MAX instead of SIZE_MAX as the maximum file size we can handle.
Fixes this test on 64-bit architectures.

ok visa@

Cast ctype functions' arguments to unsigned char.

SIZE_MAX is standard, we should be using it in preference to the
obsolete SIZE_T_MAX. OK miod@ beck@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

various cleanups; david says results are same

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Rename private err() function to dberr() to avoid collision with
libc's err().

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

$OpenBSD$

#if __STDC__ --> #ifdef __STDC__

r?index -> strr?chr

getopt(3) returns -1 when out of args, not EOF, whee!

db release 1.85

branches: 1.1.1;
Initial revision

no need to declare "extern optarg" and "extern optind"
when <unistd.h> is included;
patch from Jan Stary <hans at stare dot cz>;
OK millert

Fix all clang warnings in libc regress and cleanup some make files.

Use INT_MAX instead of SIZE_MAX as the maximum file size we can handle.
Fixes this test on 64-bit architectures.

ok visa@

Cast ctype functions' arguments to unsigned char.

SIZE_MAX is standard, we should be using it in preference to the
obsolete SIZE_T_MAX. OK miod@ beck@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

various cleanups; david says results are same

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Rename private err() function to dberr() to avoid collision with
libc's err().

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

$OpenBSD$

#if __STDC__ --> #ifdef __STDC__

r?index -> strr?chr

getopt(3) returns -1 when out of args, not EOF, whee!

db release 1.85

branches: 1.1.1;
Initial revision

Fix all clang warnings in libc regress and cleanup some make files.

Use INT_MAX instead of SIZE_MAX as the maximum file size we can handle.
Fixes this test on 64-bit architectures.

ok visa@

Cast ctype functions' arguments to unsigned char.

SIZE_MAX is standard, we should be using it in preference to the
obsolete SIZE_T_MAX. OK miod@ beck@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

various cleanups; david says results are same

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Rename private err() function to dberr() to avoid collision with
libc's err().

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

$OpenBSD$

#if __STDC__ --> #ifdef __STDC__

r?index -> strr?chr

getopt(3) returns -1 when out of args, not EOF, whee!

db release 1.85

branches: 1.1.1;
Initial revision