Remove unused variables; ok millert@

We know about optreset from unistd.h.
From Jan Stary, thanks.
OK martijn

Simplify globbing of ftpd(8)s list and nlst commands.
Also avoid command option injection for ls(1).

OK martijn@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

rm dead code and simplify ftpd_popen. this code has only called
its statically linked ls_main for some time now.
from Jan Klemkow
ok deraadt

Kill unused variable.

fix custom popen to return pid to caller instead of tracking in a giant
array. this implies we can't use a function pointer for close, but also
means we get to repair some abuse of the comma operator.
ok miod

Check that gl_pathc is bigger than zero before derefencing gl_pathv. While
this shouldn't happen since we specifiy GLOB_NOMAGIC, it doesn't hurt to be
paranoid, even if we fix the bug in glob(3) that causes gl_pathc to be zero
even if we specify GLOB_NOMAGIC.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

branches: 1.22.4; 1.22.8;
Include file order must be "monitor.h" before "extern.h" otherwise enum
auth_ret is referenced before it is declared, which is not allowed by C99.

Ok krw@, millert@, gilles@

malloc(x * y) -> calloc(x, y) from adobriyan AT gmail.com, with tweaks
suggested by kjell@; ok otto@ pat@ millert@ jaredy@

spacing

ansi cleanup; ok ian markus

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

* use lostconn() as the SIGALRM handler in receive_data() as originally
done by downsj@ in revision 1.54.

* some -Wall cleanup
- only declare check_host() if TCPWRAPPERS is defined.
- use socklen_t where appropriate instead of int (pointer signedness
warnings).
- {u_}char * pointer signedness warnings.

ok millert@

More pid_t cleanup. Since 'pid' is pid_t we should:
o) in ftpd_popen() convert 'pids' from int to pid_t too;
o) in ftpd_pclose() return '-1', not pid_t, because it returns int;

millert@ ok

pid_t cleanup

Use always '.' in the end of the fatal() message. Consistency is good.

millert@ ok.

use GLOB_LIMIT

proto ls_main()

branches: 1.11.4;
IPv6 support from KAME.
XXX kerberos and tcp_wrapper needs checking

implement internal ls

partial Wall

Checks to see that strdup() worked, dies with error message on failure.

Spacing nits

Better bounds checking on argv and gargv to eliminate a fencepost error
on argv and gargv variables.

nearly impossible oflow

*** empty log message ***

closelog() before exec.

bounds check on argv and gargv

branches: 1.1.1;
Initial revision

We know about optreset from unistd.h.
From Jan Stary, thanks.
OK martijn

Simplify globbing of ftpd(8)s list and nlst commands.
Also avoid command option injection for ls(1).

OK martijn@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

rm dead code and simplify ftpd_popen. this code has only called
its statically linked ls_main for some time now.
from Jan Klemkow
ok deraadt

Kill unused variable.

fix custom popen to return pid to caller instead of tracking in a giant
array. this implies we can't use a function pointer for close, but also
means we get to repair some abuse of the comma operator.
ok miod

Check that gl_pathc is bigger than zero before derefencing gl_pathv. While
this shouldn't happen since we specifiy GLOB_NOMAGIC, it doesn't hurt to be
paranoid, even if we fix the bug in glob(3) that causes gl_pathc to be zero
even if we specify GLOB_NOMAGIC.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

branches: 1.22.4; 1.22.8;
Include file order must be "monitor.h" before "extern.h" otherwise enum
auth_ret is referenced before it is declared, which is not allowed by C99.

Ok krw@, millert@, gilles@

malloc(x * y) -> calloc(x, y) from adobriyan AT gmail.com, with tweaks
suggested by kjell@; ok otto@ pat@ millert@ jaredy@

spacing

ansi cleanup; ok ian markus

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

* use lostconn() as the SIGALRM handler in receive_data() as originally
done by downsj@ in revision 1.54.

* some -Wall cleanup
- only declare check_host() if TCPWRAPPERS is defined.
- use socklen_t where appropriate instead of int (pointer signedness
warnings).
- {u_}char * pointer signedness warnings.

ok millert@

More pid_t cleanup. Since 'pid' is pid_t we should:
o) in ftpd_popen() convert 'pids' from int to pid_t too;
o) in ftpd_pclose() return '-1', not pid_t, because it returns int;

millert@ ok

pid_t cleanup

Use always '.' in the end of the fatal() message. Consistency is good.

millert@ ok.

use GLOB_LIMIT

proto ls_main()

branches: 1.11.4;
IPv6 support from KAME.
XXX kerberos and tcp_wrapper needs checking

implement internal ls

partial Wall

Checks to see that strdup() worked, dies with error message on failure.

Spacing nits

Better bounds checking on argv and gargv to eliminate a fencepost error
on argv and gargv variables.

nearly impossible oflow

*** empty log message ***

closelog() before exec.

bounds check on argv and gargv

branches: 1.1.1;
Initial revision

Simplify globbing of ftpd(8)s list and nlst commands.
Also avoid command option injection for ls(1).

OK martijn@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

rm dead code and simplify ftpd_popen. this code has only called
its statically linked ls_main for some time now.
from Jan Klemkow
ok deraadt

Kill unused variable.

fix custom popen to return pid to caller instead of tracking in a giant
array. this implies we can't use a function pointer for close, but also
means we get to repair some abuse of the comma operator.
ok miod

Check that gl_pathc is bigger than zero before derefencing gl_pathv. While
this shouldn't happen since we specifiy GLOB_NOMAGIC, it doesn't hurt to be
paranoid, even if we fix the bug in glob(3) that causes gl_pathc to be zero
even if we specify GLOB_NOMAGIC.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

branches: 1.22.4; 1.22.8;
Include file order must be "monitor.h" before "extern.h" otherwise enum
auth_ret is referenced before it is declared, which is not allowed by C99.

Ok krw@, millert@, gilles@

malloc(x * y) -> calloc(x, y) from adobriyan AT gmail.com, with tweaks
suggested by kjell@; ok otto@ pat@ millert@ jaredy@

spacing

ansi cleanup; ok ian markus

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

* use lostconn() as the SIGALRM handler in receive_data() as originally
done by downsj@ in revision 1.54.

* some -Wall cleanup
- only declare check_host() if TCPWRAPPERS is defined.
- use socklen_t where appropriate instead of int (pointer signedness
warnings).
- {u_}char * pointer signedness warnings.

ok millert@

More pid_t cleanup. Since 'pid' is pid_t we should:
o) in ftpd_popen() convert 'pids' from int to pid_t too;
o) in ftpd_pclose() return '-1', not pid_t, because it returns int;

millert@ ok

pid_t cleanup

Use always '.' in the end of the fatal() message. Consistency is good.

millert@ ok.

use GLOB_LIMIT

proto ls_main()

branches: 1.11.4;
IPv6 support from KAME.
XXX kerberos and tcp_wrapper needs checking

implement internal ls

partial Wall

Checks to see that strdup() worked, dies with error message on failure.

Spacing nits

Better bounds checking on argv and gargv to eliminate a fencepost error
on argv and gargv variables.

nearly impossible oflow

*** empty log message ***

closelog() before exec.

bounds check on argv and gargv

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

rm dead code and simplify ftpd_popen. this code has only called
its statically linked ls_main for some time now.
from Jan Klemkow
ok deraadt

Kill unused variable.

fix custom popen to return pid to caller instead of tracking in a giant
array. this implies we can't use a function pointer for close, but also
means we get to repair some abuse of the comma operator.
ok miod

Check that gl_pathc is bigger than zero before derefencing gl_pathv. While
this shouldn't happen since we specifiy GLOB_NOMAGIC, it doesn't hurt to be
paranoid, even if we fix the bug in glob(3) that causes gl_pathc to be zero
even if we specify GLOB_NOMAGIC.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

branches: 1.22.4; 1.22.8;
Include file order must be "monitor.h" before "extern.h" otherwise enum
auth_ret is referenced before it is declared, which is not allowed by C99.

Ok krw@, millert@, gilles@

malloc(x * y) -> calloc(x, y) from adobriyan AT gmail.com, with tweaks
suggested by kjell@; ok otto@ pat@ millert@ jaredy@

spacing

ansi cleanup; ok ian markus

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

* use lostconn() as the SIGALRM handler in receive_data() as originally
done by downsj@ in revision 1.54.

* some -Wall cleanup
- only declare check_host() if TCPWRAPPERS is defined.
- use socklen_t where appropriate instead of int (pointer signedness
warnings).
- {u_}char * pointer signedness warnings.

ok millert@

More pid_t cleanup. Since 'pid' is pid_t we should:
o) in ftpd_popen() convert 'pids' from int to pid_t too;
o) in ftpd_pclose() return '-1', not pid_t, because it returns int;

millert@ ok

pid_t cleanup

Use always '.' in the end of the fatal() message. Consistency is good.

millert@ ok.

use GLOB_LIMIT

proto ls_main()

branches: 1.11.4;
IPv6 support from KAME.
XXX kerberos and tcp_wrapper needs checking

implement internal ls

partial Wall

Checks to see that strdup() worked, dies with error message on failure.

Spacing nits

Better bounds checking on argv and gargv to eliminate a fencepost error
on argv and gargv variables.

nearly impossible oflow

*** empty log message ***

closelog() before exec.

bounds check on argv and gargv

branches: 1.1.1;
Initial revision

rm dead code and simplify ftpd_popen. this code has only called
its statically linked ls_main for some time now.
from Jan Klemkow
ok deraadt

Kill unused variable.

fix custom popen to return pid to caller instead of tracking in a giant
array. this implies we can't use a function pointer for close, but also
means we get to repair some abuse of the comma operator.
ok miod

Check that gl_pathc is bigger than zero before derefencing gl_pathv. While
this shouldn't happen since we specifiy GLOB_NOMAGIC, it doesn't hurt to be
paranoid, even if we fix the bug in glob(3) that causes gl_pathc to be zero
even if we specify GLOB_NOMAGIC.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

branches: 1.22.4; 1.22.8;
Include file order must be "monitor.h" before "extern.h" otherwise enum
auth_ret is referenced before it is declared, which is not allowed by C99.

Ok krw@, millert@, gilles@

malloc(x * y) -> calloc(x, y) from adobriyan AT gmail.com, with tweaks
suggested by kjell@; ok otto@ pat@ millert@ jaredy@

spacing

ansi cleanup; ok ian markus

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

* use lostconn() as the SIGALRM handler in receive_data() as originally
done by downsj@ in revision 1.54.

* some -Wall cleanup
- only declare check_host() if TCPWRAPPERS is defined.
- use socklen_t where appropriate instead of int (pointer signedness
warnings).
- {u_}char * pointer signedness warnings.

ok millert@

More pid_t cleanup. Since 'pid' is pid_t we should:
o) in ftpd_popen() convert 'pids' from int to pid_t too;
o) in ftpd_pclose() return '-1', not pid_t, because it returns int;

millert@ ok

pid_t cleanup

Use always '.' in the end of the fatal() message. Consistency is good.

millert@ ok.

use GLOB_LIMIT

proto ls_main()

branches: 1.11.4;
IPv6 support from KAME.
XXX kerberos and tcp_wrapper needs checking

implement internal ls

partial Wall

Checks to see that strdup() worked, dies with error message on failure.

Spacing nits

Better bounds checking on argv and gargv to eliminate a fencepost error
on argv and gargv variables.

nearly impossible oflow

*** empty log message ***

closelog() before exec.

bounds check on argv and gargv

branches: 1.1.1;
Initial revision

Kill unused variable.

fix custom popen to return pid to caller instead of tracking in a giant
array. this implies we can't use a function pointer for close, but also
means we get to repair some abuse of the comma operator.
ok miod

Check that gl_pathc is bigger than zero before derefencing gl_pathv. While
this shouldn't happen since we specifiy GLOB_NOMAGIC, it doesn't hurt to be
paranoid, even if we fix the bug in glob(3) that causes gl_pathc to be zero
even if we specify GLOB_NOMAGIC.

ok deraadt@

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

branches: 1.22.4; 1.22.8;
Include file order must be "monitor.h" before "extern.h" otherwise enum
auth_ret is referenced before it is declared, which is not allowed by C99.

Ok krw@, millert@, gilles@

malloc(x * y) -> calloc(x, y) from adobriyan AT gmail.com, with tweaks
suggested by kjell@; ok otto@ pat@ millert@ jaredy@

spacing

ansi cleanup; ok ian markus

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

* use lostconn() as the SIGALRM handler in receive_data() as originally
done by downsj@ in revision 1.54.

* some -Wall cleanup
- only declare check_host() if TCPWRAPPERS is defined.
- use socklen_t where appropriate instead of int (pointer signedness
warnings).
- {u_}char * pointer signedness warnings.

ok millert@

More pid_t cleanup. Since 'pid' is pid_t we should:
o) in ftpd_popen() convert 'pids' from int to pid_t too;
o) in ftpd_pclose() return '-1', not pid_t, because it returns int;

millert@ ok

pid_t cleanup

Use always '.' in the end of the fatal() message. Consistency is good.

millert@ ok.

use GLOB_LIMIT

proto ls_main()

branches: 1.11.4;
IPv6 support from KAME.
XXX kerberos and tcp_wrapper needs checking

implement internal ls

partial Wall

Checks to see that strdup() worked, dies with error message on failure.

Spacing nits

Better bounds checking on argv and gargv to eliminate a fencepost error
on argv and gargv variables.

nearly impossible oflow

*** empty log message ***

closelog() before exec.

bounds check on argv and gargv

branches: 1.1.1;
Initial revision