When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Currently we have about a 50/50 split over fcntl(n, F_GETFL [,0])
idioms.

Adopt the more concise fcntl(n, F_GETFL) over fcntl(n, F_GETFL, 0)
where it is obvious further investigation will not yield and
even better way.

Obviousness evaluation and ok guenther@

Remove some #ifdef from libevent.
OK nicm@

Remove the remaining #ifdef HAVE_ and the #define _GNU_SOURCE.
OK nicm@

Remove some #ifdef HAVE_syscall.
OK nicm@

Remove #ifdef HAVE_.*_H, just include the header files.
Do not include sys/param.h.
OK nicm@

Remove #ifdef HAVE_CONFIG_H, there is no config.h file.
OK nicm@

iRemove the #ifdef WIN32 implementation from libevent.
OK nicm@

Update to 1.4.14b.

From their change log:
o Fix memory-leak of signal handler array with kqueue. [backport]
o Make evutil_make_socket_nonblocking() leave any other flags alone.
o Adjusted fcntl() retval comparison on evutil_make_socket_nonblocking().
o Re-add event_siglcb; some old code _was_ still using it. :(
o Fix a free(NULL) in min_heap.h
o Clean up properly when adding a signal handler fails.

Also a local change to use an int rather than a long for fcntl().

ok guenther deraadt

Clean up the awful _EVENT_* poo in the libevent headers, and don't
install event-config.h.

Pointed out by deraadt.

Update libevent to 1.4.13.

This is the core library only, the DNS parts are removed and it does not
include the other extra bits (HTTP, DNS, and RPC), a separate port for
these will appear in due course.

Thanks to jsg, sthen, alek, gilles, jacekm, bernd and any others I've
forgotten for testing/comments.

Note that /usr/include/evdns.h should be removed after updating.

ok deraadt

Currently we have about a 50/50 split over fcntl(n, F_GETFL [,0])
idioms.

Adopt the more concise fcntl(n, F_GETFL) over fcntl(n, F_GETFL, 0)
where it is obvious further investigation will not yield and
even better way.

Obviousness evaluation and ok guenther@

Remove some #ifdef from libevent.
OK nicm@

Remove the remaining #ifdef HAVE_ and the #define _GNU_SOURCE.
OK nicm@

Remove some #ifdef HAVE_syscall.
OK nicm@

Remove #ifdef HAVE_.*_H, just include the header files.
Do not include sys/param.h.
OK nicm@

Remove #ifdef HAVE_CONFIG_H, there is no config.h file.
OK nicm@

iRemove the #ifdef WIN32 implementation from libevent.
OK nicm@

Update to 1.4.14b.

From their change log:
o Fix memory-leak of signal handler array with kqueue. [backport]
o Make evutil_make_socket_nonblocking() leave any other flags alone.
o Adjusted fcntl() retval comparison on evutil_make_socket_nonblocking().
o Re-add event_siglcb; some old code _was_ still using it. :(
o Fix a free(NULL) in min_heap.h
o Clean up properly when adding a signal handler fails.

Also a local change to use an int rather than a long for fcntl().

ok guenther deraadt

Clean up the awful _EVENT_* poo in the libevent headers, and don't
install event-config.h.

Pointed out by deraadt.

Update libevent to 1.4.13.

This is the core library only, the DNS parts are removed and it does not
include the other extra bits (HTTP, DNS, and RPC), a separate port for
these will appear in due course.

Thanks to jsg, sthen, alek, gilles, jacekm, bernd and any others I've
forgotten for testing/comments.

Note that /usr/include/evdns.h should be removed after updating.

ok deraadt