Remove support for static buffers in HMAC/digests

HMAC() and the one-step digests used to support passing a NULL buffer and
would return the digest in a static buffer. This design is firmly from the
nineties, not thread safe and it saves callers a single line. The few ports
that used to rely this were fixed with patches sent to non-hostile (and
non-dead) upstreams. It's early enough in the release cycle that remaining
uses hidden from the compiler should be caught, at least the ones that
matter.

There won't be that many since BoringSSL removed this feature in 2017.
https://boringssl-review.googlesource.com/14528

Add non-null attributes to the headers and add a few missing bounded
attributes.

ok beck jsing

Load in the top of the loop, as we do for other hash implementations.

Stop including md32_common.h in md5.c and remove unused defines.

This is now no longer needed.

ok tb@

Include stdint.h for uintptr_t.

Demacro MD5 and improve data loading.

Use static inline functions instead of macros and improve handling of
aligned data. Also number rounds as per RFC 1321.

ok tb@

Clean up alignment handling.

Instead of using HOST_{c2l,l2c} macros, provide and use
crypto_load_le32toh() and crypto_store_htole32(). In some cases just
use htole32() directly.

ok tb@

Use MD5_LONG instead of unsigned int for consistency.

ok tb@

Condition only on #ifdef MD5_ASM.

There are a bunch of unnecessary preprocessor directives - just condition
on MD5_ASM, the same as we do elsewhere.

ok tb@

Inline INIT_DATA_* defines.

ok tb@

style(9)

Remove now unnecessary 'do {} while (0);' and move variable declaration.

No functional change.

Expand HASH_MAKE_STRING.

No change to generated assembly.

Remove MD32_XARRAY remnants.

Reorder functions.

No functional change.

Implement MD5_{Update,Transform,Final}() directly in md5.c.

Copy the update, transform and final functions from md32_common.h, manually
expanding the macros for MD5. This will allow for further clean up to
occur.

No change in generated assembly.

Tidy includes.

Remove MD32_REG_T.

This is a hack that is only enabled on a handful of 64 bit platforms, as
a workaround for poor compiler optimisation. If you're running an archiac
compiler on an archiac architecture, then you can deal with slightly lower
performance.

ok tb@

Combine md5 into a single C file.

Remove various test stubs. The good ones have been moved by jsing
and others to the regress framework. These remaining ones just
muddle us up when re-reading code repeatedly.
ok jsing

Unsurprisingly, since <unistd.h> was so darn hard to find for OpenSSL developers
they had resorted to manually protyping read(2) instead of incredible amount of
preprocessor wizardry needed to find the ever illusive <unistd.h>. Let's just
include <unistd.h> and we don't need to do this.. While we're at it flense
out _OSD_POSIX and __DGJPP__ cruft.
ok krw@

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

OpenSSL 0.9.4 merge

branches: 1.1.1;
Initial revision

Load in the top of the loop, as we do for other hash implementations.

Stop including md32_common.h in md5.c and remove unused defines.

This is now no longer needed.

ok tb@

Include stdint.h for uintptr_t.

Demacro MD5 and improve data loading.

Use static inline functions instead of macros and improve handling of
aligned data. Also number rounds as per RFC 1321.

ok tb@

Clean up alignment handling.

Instead of using HOST_{c2l,l2c} macros, provide and use
crypto_load_le32toh() and crypto_store_htole32(). In some cases just
use htole32() directly.

ok tb@

Use MD5_LONG instead of unsigned int for consistency.

ok tb@

Condition only on #ifdef MD5_ASM.

There are a bunch of unnecessary preprocessor directives - just condition
on MD5_ASM, the same as we do elsewhere.

ok tb@

Inline INIT_DATA_* defines.

ok tb@

style(9)

Remove now unnecessary 'do {} while (0);' and move variable declaration.

No functional change.

Expand HASH_MAKE_STRING.

No change to generated assembly.

Remove MD32_XARRAY remnants.

Reorder functions.

No functional change.

Implement MD5_{Update,Transform,Final}() directly in md5.c.

Copy the update, transform and final functions from md32_common.h, manually
expanding the macros for MD5. This will allow for further clean up to
occur.

No change in generated assembly.

Tidy includes.

Remove MD32_REG_T.

This is a hack that is only enabled on a handful of 64 bit platforms, as
a workaround for poor compiler optimisation. If you're running an archiac
compiler on an archiac architecture, then you can deal with slightly lower
performance.

ok tb@

Combine md5 into a single C file.

Remove various test stubs. The good ones have been moved by jsing
and others to the regress framework. These remaining ones just
muddle us up when re-reading code repeatedly.
ok jsing

Unsurprisingly, since <unistd.h> was so darn hard to find for OpenSSL developers
they had resorted to manually protyping read(2) instead of incredible amount of
preprocessor wizardry needed to find the ever illusive <unistd.h>. Let's just
include <unistd.h> and we don't need to do this.. While we're at it flense
out _OSD_POSIX and __DGJPP__ cruft.
ok krw@

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

OpenSSL 0.9.4 merge

branches: 1.1.1;
Initial revision

Stop including md32_common.h in md5.c and remove unused defines.

This is now no longer needed.

ok tb@

Include stdint.h for uintptr_t.

Demacro MD5 and improve data loading.

Use static inline functions instead of macros and improve handling of
aligned data. Also number rounds as per RFC 1321.

ok tb@

Clean up alignment handling.

Instead of using HOST_{c2l,l2c} macros, provide and use
crypto_load_le32toh() and crypto_store_htole32(). In some cases just
use htole32() directly.

ok tb@

Use MD5_LONG instead of unsigned int for consistency.

ok tb@

Condition only on #ifdef MD5_ASM.

There are a bunch of unnecessary preprocessor directives - just condition
on MD5_ASM, the same as we do elsewhere.

ok tb@

Inline INIT_DATA_* defines.

ok tb@

style(9)

Remove now unnecessary 'do {} while (0);' and move variable declaration.

No functional change.

Expand HASH_MAKE_STRING.

No change to generated assembly.

Remove MD32_XARRAY remnants.

Reorder functions.

No functional change.

Implement MD5_{Update,Transform,Final}() directly in md5.c.

Copy the update, transform and final functions from md32_common.h, manually
expanding the macros for MD5. This will allow for further clean up to
occur.

No change in generated assembly.

Tidy includes.

Remove MD32_REG_T.

This is a hack that is only enabled on a handful of 64 bit platforms, as
a workaround for poor compiler optimisation. If you're running an archiac
compiler on an archiac architecture, then you can deal with slightly lower
performance.

ok tb@

Combine md5 into a single C file.

Remove various test stubs. The good ones have been moved by jsing
and others to the regress framework. These remaining ones just
muddle us up when re-reading code repeatedly.
ok jsing

Unsurprisingly, since <unistd.h> was so darn hard to find for OpenSSL developers
they had resorted to manually protyping read(2) instead of incredible amount of
preprocessor wizardry needed to find the ever illusive <unistd.h>. Let's just
include <unistd.h> and we don't need to do this.. While we're at it flense
out _OSD_POSIX and __DGJPP__ cruft.
ok krw@

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

OpenSSL 0.9.4 merge

branches: 1.1.1;
Initial revision

Clean up alignment handling.

Instead of using HOST_{c2l,l2c} macros, provide and use
crypto_load_le32toh() and crypto_store_htole32(). In some cases just
use htole32() directly.

ok tb@

Use MD5_LONG instead of unsigned int for consistency.

ok tb@

Condition only on #ifdef MD5_ASM.

There are a bunch of unnecessary preprocessor directives - just condition
on MD5_ASM, the same as we do elsewhere.

ok tb@

Inline INIT_DATA_* defines.

ok tb@

style(9)

Remove now unnecessary 'do {} while (0);' and move variable declaration.

No functional change.

Expand HASH_MAKE_STRING.

No change to generated assembly.

Remove MD32_XARRAY remnants.

Reorder functions.

No functional change.

Implement MD5_{Update,Transform,Final}() directly in md5.c.

Copy the update, transform and final functions from md32_common.h, manually
expanding the macros for MD5. This will allow for further clean up to
occur.

No change in generated assembly.

Tidy includes.

Remove MD32_REG_T.

This is a hack that is only enabled on a handful of 64 bit platforms, as
a workaround for poor compiler optimisation. If you're running an archiac
compiler on an archiac architecture, then you can deal with slightly lower
performance.

ok tb@

Combine md5 into a single C file.

Remove various test stubs. The good ones have been moved by jsing
and others to the regress framework. These remaining ones just
muddle us up when re-reading code repeatedly.
ok jsing

Unsurprisingly, since <unistd.h> was so darn hard to find for OpenSSL developers
they had resorted to manually protyping read(2) instead of incredible amount of
preprocessor wizardry needed to find the ever illusive <unistd.h>. Let's just
include <unistd.h> and we don't need to do this.. While we're at it flense
out _OSD_POSIX and __DGJPP__ cruft.
ok krw@

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

OpenSSL 0.9.4 merge

branches: 1.1.1;
Initial revision

Remove now unnecessary 'do {} while (0);' and move variable declaration.

No functional change.

Expand HASH_MAKE_STRING.

No change to generated assembly.

Remove MD32_XARRAY remnants.

Reorder functions.

No functional change.

Implement MD5_{Update,Transform,Final}() directly in md5.c.

Copy the update, transform and final functions from md32_common.h, manually
expanding the macros for MD5. This will allow for further clean up to
occur.

No change in generated assembly.

Tidy includes.

Remove MD32_REG_T.

This is a hack that is only enabled on a handful of 64 bit platforms, as
a workaround for poor compiler optimisation. If you're running an archiac
compiler on an archiac architecture, then you can deal with slightly lower
performance.

ok tb@

Combine md5 into a single C file.

Remove various test stubs. The good ones have been moved by jsing
and others to the regress framework. These remaining ones just
muddle us up when re-reading code repeatedly.
ok jsing

Unsurprisingly, since <unistd.h> was so darn hard to find for OpenSSL developers
they had resorted to manually protyping read(2) instead of incredible amount of
preprocessor wizardry needed to find the ever illusive <unistd.h>. Let's just
include <unistd.h> and we don't need to do this.. While we're at it flense
out _OSD_POSIX and __DGJPP__ cruft.
ok krw@

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

OpenSSL 0.9.4 merge

branches: 1.1.1;
Initial revision