Make ASN1_{primitive,template}_* internal

These were long removed from the public OpenSSL API, so we can do the
same. Remove ASN1_template_{d2i,i2d}() - those are unused internally.

ok jsing

Hide symbols in asn1 and bio

ok jsing@

Make internal header file names consistent

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names
used for internal headers. Move all these headers we inherited from
OpenSSL to *_local.h, reserving the name *_internal.h for our own code.
Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h.
constant_time_locl.h is moved to constant_time.h since it's special.

Adjust all .c files in libcrypto, libssl and regress.

The diff is mechanical with the exception of tls13_quic.c, where
#include <ssl_locl.h> was fixed manually.

discussed with jsing,
no objection bcook

Remove ASN.1 combining.

This was an option used to combine ASN.1 into a single structure, which was
only ever used by DSAPublicKey and X509_ATTRIBUTE. Since they no longer use
it we can mop this up and simplify all of the related code.

ok tb@

A few more files need asn1_locl.h.

Indent goto labels for diffability.

Whitespace change only.

unifdef -U CRYPTO_MDEBUG -m tasn_new.c

Require all ASN1_PRIMITIVE_FUNCS functions to be provided.

If an ASN.1 item provides its own ASN1_PRIMITIVE_FUNCS functions, require
all functions to be provided (currently excluding prim_clear). This avoids
situations such as having a custom allocator that returns a specific struct
but then is then printed using the default primative print functions, which
interpret the memory as a different struct.

Found by oss-fuzz, fixes issue #13799.

ok beck@, tb@

Send the function codes from the error functions to the bit bucket,
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@

Expand ASN1_ITEM_rptr and ASN1_ITEM_ptr macros - no change in generated
assembly.

Use V_ASN1_UNDEF instead of -1.
Make sure ASN1_primitive_new() will return NULL in *pval in all error
situations.

ok bcook@ doug@

Remove IMPLEMENT_COMPAT_ASN1() and related support code. Nothing uses it in
libcrypto/libssl, and nothing seems to use it in the wild, apart from embedded
copies of OpenSSL.
ok jsing@

Possible NULL pointer dereferences. Coverity CID 21719, 21732.
ok doug@ jsing@

Spell NULL correctly, be explicit with NULL checks and it is also easier to
initialise during declaration and drop the else statement.

ok doug@ miod@

tags as requested by miod and tedu

improve realloc/calloc/malloc patterns; ok guenther

More KNF.

lob a few more knf grenades in here to soften things up.

putting most of the braces in the right column is the very least we can do.

Change library to use intrinsic memory allocation functions instead of
OPENSSL_foo wrappers. This changes:
OPENSSL_malloc->malloc
OPENSSL_free->free
OPENSSL_relloc->realloc
OPENSSL_freeFunc->free

resolve conflicts, fix local changes

resolve conflicts

resolve conflicts

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

branches: 1.1.1;
OpenSSL 0.9.7 stable 2002 05 08 merge

Hide symbols in asn1 and bio

ok jsing@

Make internal header file names consistent

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names
used for internal headers. Move all these headers we inherited from
OpenSSL to *_local.h, reserving the name *_internal.h for our own code.
Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h.
constant_time_locl.h is moved to constant_time.h since it's special.

Adjust all .c files in libcrypto, libssl and regress.

The diff is mechanical with the exception of tls13_quic.c, where
#include <ssl_locl.h> was fixed manually.

discussed with jsing,
no objection bcook

Remove ASN.1 combining.

This was an option used to combine ASN.1 into a single structure, which was
only ever used by DSAPublicKey and X509_ATTRIBUTE. Since they no longer use
it we can mop this up and simplify all of the related code.

ok tb@

A few more files need asn1_locl.h.

Indent goto labels for diffability.

Whitespace change only.

unifdef -U CRYPTO_MDEBUG -m tasn_new.c

Require all ASN1_PRIMITIVE_FUNCS functions to be provided.

If an ASN.1 item provides its own ASN1_PRIMITIVE_FUNCS functions, require
all functions to be provided (currently excluding prim_clear). This avoids
situations such as having a custom allocator that returns a specific struct
but then is then printed using the default primative print functions, which
interpret the memory as a different struct.

Found by oss-fuzz, fixes issue #13799.

ok beck@, tb@

Send the function codes from the error functions to the bit bucket,
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@

Expand ASN1_ITEM_rptr and ASN1_ITEM_ptr macros - no change in generated
assembly.

Use V_ASN1_UNDEF instead of -1.
Make sure ASN1_primitive_new() will return NULL in *pval in all error
situations.

ok bcook@ doug@

Remove IMPLEMENT_COMPAT_ASN1() and related support code. Nothing uses it in
libcrypto/libssl, and nothing seems to use it in the wild, apart from embedded
copies of OpenSSL.
ok jsing@

Possible NULL pointer dereferences. Coverity CID 21719, 21732.
ok doug@ jsing@

Spell NULL correctly, be explicit with NULL checks and it is also easier to
initialise during declaration and drop the else statement.

ok doug@ miod@

tags as requested by miod and tedu

improve realloc/calloc/malloc patterns; ok guenther

More KNF.

lob a few more knf grenades in here to soften things up.

putting most of the braces in the right column is the very least we can do.

Change library to use intrinsic memory allocation functions instead of
OPENSSL_foo wrappers. This changes:
OPENSSL_malloc->malloc
OPENSSL_free->free
OPENSSL_relloc->realloc
OPENSSL_freeFunc->free

resolve conflicts, fix local changes

resolve conflicts

resolve conflicts

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

branches: 1.1.1;
OpenSSL 0.9.7 stable 2002 05 08 merge

Make internal header file names consistent

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names
used for internal headers. Move all these headers we inherited from
OpenSSL to *_local.h, reserving the name *_internal.h for our own code.
Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h.
constant_time_locl.h is moved to constant_time.h since it's special.

Adjust all .c files in libcrypto, libssl and regress.

The diff is mechanical with the exception of tls13_quic.c, where
#include <ssl_locl.h> was fixed manually.

discussed with jsing,
no objection bcook

Remove ASN.1 combining.

This was an option used to combine ASN.1 into a single structure, which was
only ever used by DSAPublicKey and X509_ATTRIBUTE. Since they no longer use
it we can mop this up and simplify all of the related code.

ok tb@

A few more files need asn1_locl.h.

Indent goto labels for diffability.

Whitespace change only.

unifdef -U CRYPTO_MDEBUG -m tasn_new.c

Require all ASN1_PRIMITIVE_FUNCS functions to be provided.

If an ASN.1 item provides its own ASN1_PRIMITIVE_FUNCS functions, require
all functions to be provided (currently excluding prim_clear). This avoids
situations such as having a custom allocator that returns a specific struct
but then is then printed using the default primative print functions, which
interpret the memory as a different struct.

Found by oss-fuzz, fixes issue #13799.

ok beck@, tb@

Send the function codes from the error functions to the bit bucket,
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@

Expand ASN1_ITEM_rptr and ASN1_ITEM_ptr macros - no change in generated
assembly.

Use V_ASN1_UNDEF instead of -1.
Make sure ASN1_primitive_new() will return NULL in *pval in all error
situations.

ok bcook@ doug@

Remove IMPLEMENT_COMPAT_ASN1() and related support code. Nothing uses it in
libcrypto/libssl, and nothing seems to use it in the wild, apart from embedded
copies of OpenSSL.
ok jsing@

Possible NULL pointer dereferences. Coverity CID 21719, 21732.
ok doug@ jsing@

Spell NULL correctly, be explicit with NULL checks and it is also easier to
initialise during declaration and drop the else statement.

ok doug@ miod@

tags as requested by miod and tedu

improve realloc/calloc/malloc patterns; ok guenther

More KNF.

lob a few more knf grenades in here to soften things up.

putting most of the braces in the right column is the very least we can do.

Change library to use intrinsic memory allocation functions instead of
OPENSSL_foo wrappers. This changes:
OPENSSL_malloc->malloc
OPENSSL_free->free
OPENSSL_relloc->realloc
OPENSSL_freeFunc->free

resolve conflicts, fix local changes

resolve conflicts

resolve conflicts

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

branches: 1.1.1;
OpenSSL 0.9.7 stable 2002 05 08 merge

Remove ASN.1 combining.

This was an option used to combine ASN.1 into a single structure, which was
only ever used by DSAPublicKey and X509_ATTRIBUTE. Since they no longer use
it we can mop this up and simplify all of the related code.

ok tb@

A few more files need asn1_locl.h.

Indent goto labels for diffability.

Whitespace change only.

unifdef -U CRYPTO_MDEBUG -m tasn_new.c

Require all ASN1_PRIMITIVE_FUNCS functions to be provided.

If an ASN.1 item provides its own ASN1_PRIMITIVE_FUNCS functions, require
all functions to be provided (currently excluding prim_clear). This avoids
situations such as having a custom allocator that returns a specific struct
but then is then printed using the default primative print functions, which
interpret the memory as a different struct.

Found by oss-fuzz, fixes issue #13799.

ok beck@, tb@

Send the function codes from the error functions to the bit bucket,
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@

Expand ASN1_ITEM_rptr and ASN1_ITEM_ptr macros - no change in generated
assembly.

Use V_ASN1_UNDEF instead of -1.
Make sure ASN1_primitive_new() will return NULL in *pval in all error
situations.

ok bcook@ doug@

Remove IMPLEMENT_COMPAT_ASN1() and related support code. Nothing uses it in
libcrypto/libssl, and nothing seems to use it in the wild, apart from embedded
copies of OpenSSL.
ok jsing@

Possible NULL pointer dereferences. Coverity CID 21719, 21732.
ok doug@ jsing@

Spell NULL correctly, be explicit with NULL checks and it is also easier to
initialise during declaration and drop the else statement.

ok doug@ miod@

tags as requested by miod and tedu

improve realloc/calloc/malloc patterns; ok guenther

More KNF.

lob a few more knf grenades in here to soften things up.

putting most of the braces in the right column is the very least we can do.

Change library to use intrinsic memory allocation functions instead of
OPENSSL_foo wrappers. This changes:
OPENSSL_malloc->malloc
OPENSSL_free->free
OPENSSL_relloc->realloc
OPENSSL_freeFunc->free

resolve conflicts, fix local changes

resolve conflicts

resolve conflicts

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

branches: 1.1.1;
OpenSSL 0.9.7 stable 2002 05 08 merge

A few more files need asn1_locl.h.

Indent goto labels for diffability.

Whitespace change only.

unifdef -U CRYPTO_MDEBUG -m tasn_new.c

Require all ASN1_PRIMITIVE_FUNCS functions to be provided.

If an ASN.1 item provides its own ASN1_PRIMITIVE_FUNCS functions, require
all functions to be provided (currently excluding prim_clear). This avoids
situations such as having a custom allocator that returns a specific struct
but then is then printed using the default primative print functions, which
interpret the memory as a different struct.

Found by oss-fuzz, fixes issue #13799.

ok beck@, tb@

Send the function codes from the error functions to the bit bucket,
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@

Expand ASN1_ITEM_rptr and ASN1_ITEM_ptr macros - no change in generated
assembly.

Use V_ASN1_UNDEF instead of -1.
Make sure ASN1_primitive_new() will return NULL in *pval in all error
situations.

ok bcook@ doug@

Remove IMPLEMENT_COMPAT_ASN1() and related support code. Nothing uses it in
libcrypto/libssl, and nothing seems to use it in the wild, apart from embedded
copies of OpenSSL.
ok jsing@

Possible NULL pointer dereferences. Coverity CID 21719, 21732.
ok doug@ jsing@

Spell NULL correctly, be explicit with NULL checks and it is also easier to
initialise during declaration and drop the else statement.

ok doug@ miod@

tags as requested by miod and tedu

improve realloc/calloc/malloc patterns; ok guenther

More KNF.

lob a few more knf grenades in here to soften things up.

putting most of the braces in the right column is the very least we can do.

Change library to use intrinsic memory allocation functions instead of
OPENSSL_foo wrappers. This changes:
OPENSSL_malloc->malloc
OPENSSL_free->free
OPENSSL_relloc->realloc
OPENSSL_freeFunc->free

resolve conflicts, fix local changes

resolve conflicts

resolve conflicts

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

branches: 1.1.1;
OpenSSL 0.9.7 stable 2002 05 08 merge

Indent goto labels for diffability.

Whitespace change only.

unifdef -U CRYPTO_MDEBUG -m tasn_new.c

Require all ASN1_PRIMITIVE_FUNCS functions to be provided.

If an ASN.1 item provides its own ASN1_PRIMITIVE_FUNCS functions, require
all functions to be provided (currently excluding prim_clear). This avoids
situations such as having a custom allocator that returns a specific struct
but then is then printed using the default primative print functions, which
interpret the memory as a different struct.

Found by oss-fuzz, fixes issue #13799.

ok beck@, tb@

Send the function codes from the error functions to the bit bucket,
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@

Expand ASN1_ITEM_rptr and ASN1_ITEM_ptr macros - no change in generated
assembly.

Use V_ASN1_UNDEF instead of -1.
Make sure ASN1_primitive_new() will return NULL in *pval in all error
situations.

ok bcook@ doug@

Remove IMPLEMENT_COMPAT_ASN1() and related support code. Nothing uses it in
libcrypto/libssl, and nothing seems to use it in the wild, apart from embedded
copies of OpenSSL.
ok jsing@

Possible NULL pointer dereferences. Coverity CID 21719, 21732.
ok doug@ jsing@

Spell NULL correctly, be explicit with NULL checks and it is also easier to
initialise during declaration and drop the else statement.

ok doug@ miod@

tags as requested by miod and tedu

improve realloc/calloc/malloc patterns; ok guenther

More KNF.

lob a few more knf grenades in here to soften things up.

putting most of the braces in the right column is the very least we can do.

Change library to use intrinsic memory allocation functions instead of
OPENSSL_foo wrappers. This changes:
OPENSSL_malloc->malloc
OPENSSL_free->free
OPENSSL_relloc->realloc
OPENSSL_freeFunc->free

resolve conflicts, fix local changes

resolve conflicts

resolve conflicts

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

branches: 1.1.1;
OpenSSL 0.9.7 stable 2002 05 08 merge

unifdef -U CRYPTO_MDEBUG -m tasn_new.c

Require all ASN1_PRIMITIVE_FUNCS functions to be provided.

If an ASN.1 item provides its own ASN1_PRIMITIVE_FUNCS functions, require
all functions to be provided (currently excluding prim_clear). This avoids
situations such as having a custom allocator that returns a specific struct
but then is then printed using the default primative print functions, which
interpret the memory as a different struct.

Found by oss-fuzz, fixes issue #13799.

ok beck@, tb@

Send the function codes from the error functions to the bit bucket,
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@

Expand ASN1_ITEM_rptr and ASN1_ITEM_ptr macros - no change in generated
assembly.

Use V_ASN1_UNDEF instead of -1.
Make sure ASN1_primitive_new() will return NULL in *pval in all error
situations.

ok bcook@ doug@

Remove IMPLEMENT_COMPAT_ASN1() and related support code. Nothing uses it in
libcrypto/libssl, and nothing seems to use it in the wild, apart from embedded
copies of OpenSSL.
ok jsing@

Possible NULL pointer dereferences. Coverity CID 21719, 21732.
ok doug@ jsing@

Spell NULL correctly, be explicit with NULL checks and it is also easier to
initialise during declaration and drop the else statement.

ok doug@ miod@

tags as requested by miod and tedu

improve realloc/calloc/malloc patterns; ok guenther

More KNF.

lob a few more knf grenades in here to soften things up.

putting most of the braces in the right column is the very least we can do.

Change library to use intrinsic memory allocation functions instead of
OPENSSL_foo wrappers. This changes:
OPENSSL_malloc->malloc
OPENSSL_free->free
OPENSSL_relloc->realloc
OPENSSL_freeFunc->free

resolve conflicts, fix local changes

resolve conflicts

resolve conflicts

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

branches: 1.1.1;
OpenSSL 0.9.7 stable 2002 05 08 merge

Require all ASN1_PRIMITIVE_FUNCS functions to be provided.

If an ASN.1 item provides its own ASN1_PRIMITIVE_FUNCS functions, require
all functions to be provided (currently excluding prim_clear). This avoids
situations such as having a custom allocator that returns a specific struct
but then is then printed using the default primative print functions, which
interpret the memory as a different struct.

Found by oss-fuzz, fixes issue #13799.

ok beck@, tb@

Send the function codes from the error functions to the bit bucket,
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@

Expand ASN1_ITEM_rptr and ASN1_ITEM_ptr macros - no change in generated
assembly.

Use V_ASN1_UNDEF instead of -1.
Make sure ASN1_primitive_new() will return NULL in *pval in all error
situations.

ok bcook@ doug@

Remove IMPLEMENT_COMPAT_ASN1() and related support code. Nothing uses it in
libcrypto/libssl, and nothing seems to use it in the wild, apart from embedded
copies of OpenSSL.
ok jsing@

Possible NULL pointer dereferences. Coverity CID 21719, 21732.
ok doug@ jsing@

Spell NULL correctly, be explicit with NULL checks and it is also easier to
initialise during declaration and drop the else statement.

ok doug@ miod@

tags as requested by miod and tedu

improve realloc/calloc/malloc patterns; ok guenther

More KNF.

lob a few more knf grenades in here to soften things up.

putting most of the braces in the right column is the very least we can do.

Change library to use intrinsic memory allocation functions instead of
OPENSSL_foo wrappers. This changes:
OPENSSL_malloc->malloc
OPENSSL_free->free
OPENSSL_relloc->realloc
OPENSSL_freeFunc->free

resolve conflicts, fix local changes

resolve conflicts

resolve conflicts

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

branches: 1.1.1;
OpenSSL 0.9.7 stable 2002 05 08 merge

Send the function codes from the error functions to the bit bucket,
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@

Expand ASN1_ITEM_rptr and ASN1_ITEM_ptr macros - no change in generated
assembly.

Use V_ASN1_UNDEF instead of -1.
Make sure ASN1_primitive_new() will return NULL in *pval in all error
situations.

ok bcook@ doug@

Remove IMPLEMENT_COMPAT_ASN1() and related support code. Nothing uses it in
libcrypto/libssl, and nothing seems to use it in the wild, apart from embedded
copies of OpenSSL.
ok jsing@

Possible NULL pointer dereferences. Coverity CID 21719, 21732.
ok doug@ jsing@

Spell NULL correctly, be explicit with NULL checks and it is also easier to
initialise during declaration and drop the else statement.

ok doug@ miod@

tags as requested by miod and tedu

improve realloc/calloc/malloc patterns; ok guenther

More KNF.

lob a few more knf grenades in here to soften things up.

putting most of the braces in the right column is the very least we can do.

Change library to use intrinsic memory allocation functions instead of
OPENSSL_foo wrappers. This changes:
OPENSSL_malloc->malloc
OPENSSL_free->free
OPENSSL_relloc->realloc
OPENSSL_freeFunc->free

resolve conflicts, fix local changes

resolve conflicts

resolve conflicts

merge 0.9.7b with local changes; crank majors for libssl/libcrypto

branches: 1.1.1;
OpenSSL 0.9.7 stable 2002 05 08 merge