Add scandirat(3); from freebsd

To be used in httpd(8) shortly to prevent toctu issues.

This makes __fdopendir internally accessible to avoid unnecessary
syscalls in scandirat(3). Suggested & diff by guenther

suggested by & OK millert
tweak & OK guenther
OK tb, jca

This rides the libc crank.

Zap trailing whitespace.

OK tb

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

All these files include <stdlib.h>, so do not need to cast
malloc/calloc/realloc* returns.

Include stdint.h, not limits.h to get SIZE_MAX. OK guenther@

Move to the <limits.h> universe.
review by millert, binary checking process with doug, concept with guenther

obvious reallocarray()

add some prototypes, casts, includes, parenthesis, and whatnot to
silence some warnings.

Change scandir()'s 'select' argument from
int (*)(struct dirent *)
to
int (*)(const struct dirent *)
to match POSIX.

ok millert@, ports check by naddy@

Make DIR a private type within libc, give it the same underlying
typedef regardless of __BSD_VISIBLE, and eliminate the dirfd() macro.

ok guenther@

Update alphasort() and scandir()'s argument types to match POSIX:
use "const struct dirent **" instead of "const void *". Also, add
__restrict to readdir_r().

ok matthew@

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

It seems st_size is not always a good estimator for the number of
directory entries. ZFS, for instance, sets st_size to the number
of entries.

Use the same algorithm for the initial estimate but keep a minimum
to prevent a divide by zero. When the buffer is filled, instead
of re-using the same flawed algorithm, double the buffer size.

Also add check for integer overflow.

Bug reported by Ed Ravin, ZFS testing environment provided by Bryan
Allen.

OK millert

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

ansify function definitions and zap some `register'

ok millert@

don't leak memory. free and netbsd via Patrick Latifi

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

malloc paranoia; it is unlikely that any filesystem will support
enough directory entries to cause a problem but it is good form anyway.
deraadt@ OK.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

realloc repair

copy d_type; giles@nemeton.com.au

Fix RCS ids
Make sure everything uses {SYS,}LIBC_SCCS properly

branches: 1.1.1;
Initial revision

Zap trailing whitespace.

OK tb

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

All these files include <stdlib.h>, so do not need to cast
malloc/calloc/realloc* returns.

Include stdint.h, not limits.h to get SIZE_MAX. OK guenther@

Move to the <limits.h> universe.
review by millert, binary checking process with doug, concept with guenther

obvious reallocarray()

add some prototypes, casts, includes, parenthesis, and whatnot to
silence some warnings.

Change scandir()'s 'select' argument from
int (*)(struct dirent *)
to
int (*)(const struct dirent *)
to match POSIX.

ok millert@, ports check by naddy@

Make DIR a private type within libc, give it the same underlying
typedef regardless of __BSD_VISIBLE, and eliminate the dirfd() macro.

ok guenther@

Update alphasort() and scandir()'s argument types to match POSIX:
use "const struct dirent **" instead of "const void *". Also, add
__restrict to readdir_r().

ok matthew@

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

It seems st_size is not always a good estimator for the number of
directory entries. ZFS, for instance, sets st_size to the number
of entries.

Use the same algorithm for the initial estimate but keep a minimum
to prevent a divide by zero. When the buffer is filled, instead
of re-using the same flawed algorithm, double the buffer size.

Also add check for integer overflow.

Bug reported by Ed Ravin, ZFS testing environment provided by Bryan
Allen.

OK millert

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

ansify function definitions and zap some `register'

ok millert@

don't leak memory. free and netbsd via Patrick Latifi

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

malloc paranoia; it is unlikely that any filesystem will support
enough directory entries to cause a problem but it is good form anyway.
deraadt@ OK.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

realloc repair

copy d_type; giles@nemeton.com.au

Fix RCS ids
Make sure everything uses {SYS,}LIBC_SCCS properly

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

All these files include <stdlib.h>, so do not need to cast
malloc/calloc/realloc* returns.

Include stdint.h, not limits.h to get SIZE_MAX. OK guenther@

Move to the <limits.h> universe.
review by millert, binary checking process with doug, concept with guenther

obvious reallocarray()

add some prototypes, casts, includes, parenthesis, and whatnot to
silence some warnings.

Change scandir()'s 'select' argument from
int (*)(struct dirent *)
to
int (*)(const struct dirent *)
to match POSIX.

ok millert@, ports check by naddy@

Make DIR a private type within libc, give it the same underlying
typedef regardless of __BSD_VISIBLE, and eliminate the dirfd() macro.

ok guenther@

Update alphasort() and scandir()'s argument types to match POSIX:
use "const struct dirent **" instead of "const void *". Also, add
__restrict to readdir_r().

ok matthew@

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

It seems st_size is not always a good estimator for the number of
directory entries. ZFS, for instance, sets st_size to the number
of entries.

Use the same algorithm for the initial estimate but keep a minimum
to prevent a divide by zero. When the buffer is filled, instead
of re-using the same flawed algorithm, double the buffer size.

Also add check for integer overflow.

Bug reported by Ed Ravin, ZFS testing environment provided by Bryan
Allen.

OK millert

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

ansify function definitions and zap some `register'

ok millert@

don't leak memory. free and netbsd via Patrick Latifi

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

malloc paranoia; it is unlikely that any filesystem will support
enough directory entries to cause a problem but it is good form anyway.
deraadt@ OK.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

realloc repair

copy d_type; giles@nemeton.com.au

Fix RCS ids
Make sure everything uses {SYS,}LIBC_SCCS properly

branches: 1.1.1;
Initial revision

All these files include <stdlib.h>, so do not need to cast
malloc/calloc/realloc* returns.

Include stdint.h, not limits.h to get SIZE_MAX. OK guenther@

Move to the <limits.h> universe.
review by millert, binary checking process with doug, concept with guenther

obvious reallocarray()

add some prototypes, casts, includes, parenthesis, and whatnot to
silence some warnings.

Change scandir()'s 'select' argument from
int (*)(struct dirent *)
to
int (*)(const struct dirent *)
to match POSIX.

ok millert@, ports check by naddy@

Make DIR a private type within libc, give it the same underlying
typedef regardless of __BSD_VISIBLE, and eliminate the dirfd() macro.

ok guenther@

Update alphasort() and scandir()'s argument types to match POSIX:
use "const struct dirent **" instead of "const void *". Also, add
__restrict to readdir_r().

ok matthew@

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

It seems st_size is not always a good estimator for the number of
directory entries. ZFS, for instance, sets st_size to the number
of entries.

Use the same algorithm for the initial estimate but keep a minimum
to prevent a divide by zero. When the buffer is filled, instead
of re-using the same flawed algorithm, double the buffer size.

Also add check for integer overflow.

Bug reported by Ed Ravin, ZFS testing environment provided by Bryan
Allen.

OK millert

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

ansify function definitions and zap some `register'

ok millert@

don't leak memory. free and netbsd via Patrick Latifi

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

malloc paranoia; it is unlikely that any filesystem will support
enough directory entries to cause a problem but it is good form anyway.
deraadt@ OK.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

realloc repair

copy d_type; giles@nemeton.com.au

Fix RCS ids
Make sure everything uses {SYS,}LIBC_SCCS properly

branches: 1.1.1;
Initial revision