Do some easy .data -> .rodata/.data.rel.ro conversions

ok millert@ deraadt@

Prevent infinite for loop since i went from ssize_t to size_t. Patch from
eagleoflqj via OpenSSH github PR#178, ok djm@, feedback & ok millert@

Make gl_pathc, gl_matchc and gl_offs size_t in glob_t to match POSIX.
This requires a libc major version bump. OK deraadt@

Fix exponential CPU use with repeated '*' operators by changing '*'
handling to be interative instead of recursive.
Fix by Yves Orton, ported to OpenBSD glob.c by Ray Lai. OK tb@

Remove NULL-checks before free() and a few related dead assignments.

ok and valuable input from millert@

Use reentrant versions of getpw{nam,uid} and getgr{nam,gid} within
libc to avoid reusing the static buffers returned by the non-reentrant
versions. Since this is inside libc we can use constants for the
buffer sizes instead of having to call sysconf().
OK guenther@ deraadt@

remove null check before free. from Michael McConville
ok semarie

in glob() initialize the glob_t before the first failure check.
from j@pureftpd.org
ok millert stsp

Include stdint.h, not limits.h to get SIZE_MAX. OK guenther@

obvious realloc -> reallocarray conversion

Use PATH_MAX, NAME_MAX and LOGIN_NAME_MAX not MAXPATHNAMELEN,
MAXNAMLEN or MAXLOGNAME where possible. OK deraadt@

the glob stat limit is way too low. bump to 2048.
while here, failed stats should count against the limit too.
ok deraadt sthen stsp

fix GLOB_KEEPSTAT without GLOB_NOSORT; the implicit sort was being
applied only to the gl_pathv vector and not the corresponding gl_statv
array. reported in OpenSSH bz#1935; feedback and okay matthew@

In glob(3), limit recursion during matching attempts. Similar to fnmatch fix.
Also collapse consecutive '*' (from NetBSD).
ok miod deraadt

When the max number of items for a directory has reached GLOB_LIMIT_READDIR
an error is returned but closedir() is not called.

spotted and fix provided by Frank Denis obsd-tech@pureftpd.org

ok otto@, millert@

avoid some integer overflows mostly with GLOB_APPEND and GLOB_DOOFFS
and sanity check arguments (these will be unnecessary when we switch
struct glob members from being type into to size_t in the future);
"looks ok" tedu@ feedback guenther@

Extend GLOB_LIMIT to cover readdir and stat and bump the malloc limit
from ARG_MAX to 64K.

Fixes glob-using programs (notably ftp) able to be triggered to hit
resource limits.

Idea from a similar NetBSD change, original problem reported by jasper@.

ok millert tedu jasper

oops, don't free array before freeing members; spotted by dkrause@

add a GLOB_KEEPSTAT option that retains a copy of the struct stat
information that is looked up while matching glob(3)s

Keeping this information around can make a big difference when
fetching it is expensive, e.g. in sftp which uses GLOB_ALTDIRFUNC

feedback millert@ jmc@

"get it in before the libc crank" deraadt@

remove unused variable

ok nicm@

Fix glob(3) to correctly return an error when its buffer space is
exhausted and GLOB_BRACE is given. globexp2() was ignoring errors
returned from lower levels.

While here, change globexp2() to return its return value normally rather
putting it in a int pointer then always returning 0.

ok otto

replacing malloc/realloc dance, by only one realloc

ok millert@

Add missing braces. This is why we use braces for indented block that
are more than a couple of lines...

POSIX character class support for fnmatch(3) and glob(3). OK deraadt@

unused arg in internal static API

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

Kill register and fix some whilespace goofs in a do {} while loop.

ansify function definitions and zap some `register'

ok millert@

protos

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

spelling; from Brian Poole <raj@cerias.purdue.edu>

try to use strlcpy and snprintf more; ok various

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

remove extra continue statements

use a len in g_Ctoc, easier code; freebsd

Fix some glob defects:
o use MAXPATHLEN, not MAXPATHLEN + 1
o when manipulating static buffers, pass functions a pointer to
the end of the buffer so we can avoid any overflows

Work by Theo and myself.

must spec +1 in this one case...

avoid g_Ctoc() overflows; art@ ok

KNF

set gl_pathv to NULL after we free it; christos@netbsd.org

GLOB_LIMIT changes from christos

branches: 1.8.10;
realloc repair

Add GLOB_NOESCAPE to turn off backslash escaping and make backslash escaping
the default. For xpg4.2.

Make glob(3) XPG4.2 compliant. This means changing GLOB_ABEND to
GLOB_ABORT and defining GLOB_NOMATCH and GLOB_NOSYS (the latter is
not used).

Different fix for buffer overflow. From Keith Bostic <bostic@bostic.com>

be careful in the non-setuid case too, what the heck

protect $HOME expansion; from das33@cornell.edu

Fix RCS ids
Make sure everything uses {SYS,}LIBC_SCCS properly

branches: 1.1.1;
Initial revision

Prevent infinite for loop since i went from ssize_t to size_t. Patch from
eagleoflqj via OpenSSH github PR#178, ok djm@, feedback & ok millert@

Make gl_pathc, gl_matchc and gl_offs size_t in glob_t to match POSIX.
This requires a libc major version bump. OK deraadt@

Fix exponential CPU use with repeated '*' operators by changing '*'
handling to be interative instead of recursive.
Fix by Yves Orton, ported to OpenBSD glob.c by Ray Lai. OK tb@

Remove NULL-checks before free() and a few related dead assignments.

ok and valuable input from millert@

Use reentrant versions of getpw{nam,uid} and getgr{nam,gid} within
libc to avoid reusing the static buffers returned by the non-reentrant
versions. Since this is inside libc we can use constants for the
buffer sizes instead of having to call sysconf().
OK guenther@ deraadt@

remove null check before free. from Michael McConville
ok semarie

in glob() initialize the glob_t before the first failure check.
from j@pureftpd.org
ok millert stsp

Include stdint.h, not limits.h to get SIZE_MAX. OK guenther@

obvious realloc -> reallocarray conversion

Use PATH_MAX, NAME_MAX and LOGIN_NAME_MAX not MAXPATHNAMELEN,
MAXNAMLEN or MAXLOGNAME where possible. OK deraadt@

the glob stat limit is way too low. bump to 2048.
while here, failed stats should count against the limit too.
ok deraadt sthen stsp

fix GLOB_KEEPSTAT without GLOB_NOSORT; the implicit sort was being
applied only to the gl_pathv vector and not the corresponding gl_statv
array. reported in OpenSSH bz#1935; feedback and okay matthew@

In glob(3), limit recursion during matching attempts. Similar to fnmatch fix.
Also collapse consecutive '*' (from NetBSD).
ok miod deraadt

When the max number of items for a directory has reached GLOB_LIMIT_READDIR
an error is returned but closedir() is not called.

spotted and fix provided by Frank Denis obsd-tech@pureftpd.org

ok otto@, millert@

avoid some integer overflows mostly with GLOB_APPEND and GLOB_DOOFFS
and sanity check arguments (these will be unnecessary when we switch
struct glob members from being type into to size_t in the future);
"looks ok" tedu@ feedback guenther@

Extend GLOB_LIMIT to cover readdir and stat and bump the malloc limit
from ARG_MAX to 64K.

Fixes glob-using programs (notably ftp) able to be triggered to hit
resource limits.

Idea from a similar NetBSD change, original problem reported by jasper@.

ok millert tedu jasper

oops, don't free array before freeing members; spotted by dkrause@

add a GLOB_KEEPSTAT option that retains a copy of the struct stat
information that is looked up while matching glob(3)s

Keeping this information around can make a big difference when
fetching it is expensive, e.g. in sftp which uses GLOB_ALTDIRFUNC

feedback millert@ jmc@

"get it in before the libc crank" deraadt@

remove unused variable

ok nicm@

Fix glob(3) to correctly return an error when its buffer space is
exhausted and GLOB_BRACE is given. globexp2() was ignoring errors
returned from lower levels.

While here, change globexp2() to return its return value normally rather
putting it in a int pointer then always returning 0.

ok otto

replacing malloc/realloc dance, by only one realloc

ok millert@

Add missing braces. This is why we use braces for indented block that
are more than a couple of lines...

POSIX character class support for fnmatch(3) and glob(3). OK deraadt@

unused arg in internal static API

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

Kill register and fix some whilespace goofs in a do {} while loop.

ansify function definitions and zap some `register'

ok millert@

protos

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

spelling; from Brian Poole <raj@cerias.purdue.edu>

try to use strlcpy and snprintf more; ok various

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

remove extra continue statements

use a len in g_Ctoc, easier code; freebsd

Fix some glob defects:
o use MAXPATHLEN, not MAXPATHLEN + 1
o when manipulating static buffers, pass functions a pointer to
the end of the buffer so we can avoid any overflows

Work by Theo and myself.

must spec +1 in this one case...

avoid g_Ctoc() overflows; art@ ok

KNF

set gl_pathv to NULL after we free it; christos@netbsd.org

GLOB_LIMIT changes from christos

branches: 1.8.10;
realloc repair

Add GLOB_NOESCAPE to turn off backslash escaping and make backslash escaping
the default. For xpg4.2.

Make glob(3) XPG4.2 compliant. This means changing GLOB_ABEND to
GLOB_ABORT and defining GLOB_NOMATCH and GLOB_NOSYS (the latter is
not used).

Different fix for buffer overflow. From Keith Bostic <bostic@bostic.com>

be careful in the non-setuid case too, what the heck

protect $HOME expansion; from das33@cornell.edu

Fix RCS ids
Make sure everything uses {SYS,}LIBC_SCCS properly

branches: 1.1.1;
Initial revision

Make gl_pathc, gl_matchc and gl_offs size_t in glob_t to match POSIX.
This requires a libc major version bump. OK deraadt@

Fix exponential CPU use with repeated '*' operators by changing '*'
handling to be interative instead of recursive.
Fix by Yves Orton, ported to OpenBSD glob.c by Ray Lai. OK tb@

Remove NULL-checks before free() and a few related dead assignments.

ok and valuable input from millert@

Use reentrant versions of getpw{nam,uid} and getgr{nam,gid} within
libc to avoid reusing the static buffers returned by the non-reentrant
versions. Since this is inside libc we can use constants for the
buffer sizes instead of having to call sysconf().
OK guenther@ deraadt@

remove null check before free. from Michael McConville
ok semarie

in glob() initialize the glob_t before the first failure check.
from j@pureftpd.org
ok millert stsp

Include stdint.h, not limits.h to get SIZE_MAX. OK guenther@

obvious realloc -> reallocarray conversion

Use PATH_MAX, NAME_MAX and LOGIN_NAME_MAX not MAXPATHNAMELEN,
MAXNAMLEN or MAXLOGNAME where possible. OK deraadt@

the glob stat limit is way too low. bump to 2048.
while here, failed stats should count against the limit too.
ok deraadt sthen stsp

fix GLOB_KEEPSTAT without GLOB_NOSORT; the implicit sort was being
applied only to the gl_pathv vector and not the corresponding gl_statv
array. reported in OpenSSH bz#1935; feedback and okay matthew@

In glob(3), limit recursion during matching attempts. Similar to fnmatch fix.
Also collapse consecutive '*' (from NetBSD).
ok miod deraadt

When the max number of items for a directory has reached GLOB_LIMIT_READDIR
an error is returned but closedir() is not called.

spotted and fix provided by Frank Denis obsd-tech@pureftpd.org

ok otto@, millert@

avoid some integer overflows mostly with GLOB_APPEND and GLOB_DOOFFS
and sanity check arguments (these will be unnecessary when we switch
struct glob members from being type into to size_t in the future);
"looks ok" tedu@ feedback guenther@

Extend GLOB_LIMIT to cover readdir and stat and bump the malloc limit
from ARG_MAX to 64K.

Fixes glob-using programs (notably ftp) able to be triggered to hit
resource limits.

Idea from a similar NetBSD change, original problem reported by jasper@.

ok millert tedu jasper

oops, don't free array before freeing members; spotted by dkrause@

add a GLOB_KEEPSTAT option that retains a copy of the struct stat
information that is looked up while matching glob(3)s

Keeping this information around can make a big difference when
fetching it is expensive, e.g. in sftp which uses GLOB_ALTDIRFUNC

feedback millert@ jmc@

"get it in before the libc crank" deraadt@

remove unused variable

ok nicm@

Fix glob(3) to correctly return an error when its buffer space is
exhausted and GLOB_BRACE is given. globexp2() was ignoring errors
returned from lower levels.

While here, change globexp2() to return its return value normally rather
putting it in a int pointer then always returning 0.

ok otto

replacing malloc/realloc dance, by only one realloc

ok millert@

Add missing braces. This is why we use braces for indented block that
are more than a couple of lines...

POSIX character class support for fnmatch(3) and glob(3). OK deraadt@

unused arg in internal static API

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

Kill register and fix some whilespace goofs in a do {} while loop.

ansify function definitions and zap some `register'

ok millert@

protos

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

spelling; from Brian Poole <raj@cerias.purdue.edu>

try to use strlcpy and snprintf more; ok various

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

remove extra continue statements

use a len in g_Ctoc, easier code; freebsd

Fix some glob defects:
o use MAXPATHLEN, not MAXPATHLEN + 1
o when manipulating static buffers, pass functions a pointer to
the end of the buffer so we can avoid any overflows

Work by Theo and myself.

must spec +1 in this one case...

avoid g_Ctoc() overflows; art@ ok

KNF

set gl_pathv to NULL after we free it; christos@netbsd.org

GLOB_LIMIT changes from christos

branches: 1.8.10;
realloc repair

Add GLOB_NOESCAPE to turn off backslash escaping and make backslash escaping
the default. For xpg4.2.

Make glob(3) XPG4.2 compliant. This means changing GLOB_ABEND to
GLOB_ABORT and defining GLOB_NOMATCH and GLOB_NOSYS (the latter is
not used).

Different fix for buffer overflow. From Keith Bostic <bostic@bostic.com>

be careful in the non-setuid case too, what the heck

protect $HOME expansion; from das33@cornell.edu

Fix RCS ids
Make sure everything uses {SYS,}LIBC_SCCS properly

branches: 1.1.1;
Initial revision

Fix exponential CPU use with repeated '*' operators by changing '*'
handling to be interative instead of recursive.
Fix by Yves Orton, ported to OpenBSD glob.c by Ray Lai. OK tb@

Remove NULL-checks before free() and a few related dead assignments.

ok and valuable input from millert@

Use reentrant versions of getpw{nam,uid} and getgr{nam,gid} within
libc to avoid reusing the static buffers returned by the non-reentrant
versions. Since this is inside libc we can use constants for the
buffer sizes instead of having to call sysconf().
OK guenther@ deraadt@

remove null check before free. from Michael McConville
ok semarie

in glob() initialize the glob_t before the first failure check.
from j@pureftpd.org
ok millert stsp

Include stdint.h, not limits.h to get SIZE_MAX. OK guenther@

obvious realloc -> reallocarray conversion

Use PATH_MAX, NAME_MAX and LOGIN_NAME_MAX not MAXPATHNAMELEN,
MAXNAMLEN or MAXLOGNAME where possible. OK deraadt@

the glob stat limit is way too low. bump to 2048.
while here, failed stats should count against the limit too.
ok deraadt sthen stsp

fix GLOB_KEEPSTAT without GLOB_NOSORT; the implicit sort was being
applied only to the gl_pathv vector and not the corresponding gl_statv
array. reported in OpenSSH bz#1935; feedback and okay matthew@

In glob(3), limit recursion during matching attempts. Similar to fnmatch fix.
Also collapse consecutive '*' (from NetBSD).
ok miod deraadt

When the max number of items for a directory has reached GLOB_LIMIT_READDIR
an error is returned but closedir() is not called.

spotted and fix provided by Frank Denis obsd-tech@pureftpd.org

ok otto@, millert@

avoid some integer overflows mostly with GLOB_APPEND and GLOB_DOOFFS
and sanity check arguments (these will be unnecessary when we switch
struct glob members from being type into to size_t in the future);
"looks ok" tedu@ feedback guenther@

Extend GLOB_LIMIT to cover readdir and stat and bump the malloc limit
from ARG_MAX to 64K.

Fixes glob-using programs (notably ftp) able to be triggered to hit
resource limits.

Idea from a similar NetBSD change, original problem reported by jasper@.

ok millert tedu jasper

oops, don't free array before freeing members; spotted by dkrause@

add a GLOB_KEEPSTAT option that retains a copy of the struct stat
information that is looked up while matching glob(3)s

Keeping this information around can make a big difference when
fetching it is expensive, e.g. in sftp which uses GLOB_ALTDIRFUNC

feedback millert@ jmc@

"get it in before the libc crank" deraadt@

remove unused variable

ok nicm@

Fix glob(3) to correctly return an error when its buffer space is
exhausted and GLOB_BRACE is given. globexp2() was ignoring errors
returned from lower levels.

While here, change globexp2() to return its return value normally rather
putting it in a int pointer then always returning 0.

ok otto

replacing malloc/realloc dance, by only one realloc

ok millert@

Add missing braces. This is why we use braces for indented block that
are more than a couple of lines...

POSIX character class support for fnmatch(3) and glob(3). OK deraadt@

unused arg in internal static API

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

Kill register and fix some whilespace goofs in a do {} while loop.

ansify function definitions and zap some `register'

ok millert@

protos

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

spelling; from Brian Poole <raj@cerias.purdue.edu>

try to use strlcpy and snprintf more; ok various

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

remove extra continue statements

use a len in g_Ctoc, easier code; freebsd

Fix some glob defects:
o use MAXPATHLEN, not MAXPATHLEN + 1
o when manipulating static buffers, pass functions a pointer to
the end of the buffer so we can avoid any overflows

Work by Theo and myself.

must spec +1 in this one case...

avoid g_Ctoc() overflows; art@ ok

KNF

set gl_pathv to NULL after we free it; christos@netbsd.org

GLOB_LIMIT changes from christos

branches: 1.8.10;
realloc repair

Add GLOB_NOESCAPE to turn off backslash escaping and make backslash escaping
the default. For xpg4.2.

Make glob(3) XPG4.2 compliant. This means changing GLOB_ABEND to
GLOB_ABORT and defining GLOB_NOMATCH and GLOB_NOSYS (the latter is
not used).

Different fix for buffer overflow. From Keith Bostic <bostic@bostic.com>

be careful in the non-setuid case too, what the heck

protect $HOME expansion; from das33@cornell.edu

Fix RCS ids
Make sure everything uses {SYS,}LIBC_SCCS properly

branches: 1.1.1;
Initial revision