getpwnam(3) uses dbopen(3), which pulls all 3 database backends into
static binaries. If we call libc-private __hash_open() instead, it
results in a ~40K reduction in many static binaries.
ok millert

Only compile _ng_print() #ifdef DEBUG_NG; ok millert@

Christos Zoulas agreed to rescind clause 3 and 4 in
NetBSD fsck.8 rev 1.35 fsutil.h rev 1.14 pathnames.h rev 1.2
netgroup_mkdb.8 rev 1.9 netgroup_mkdb.c rev 1.18 str.c rev 1.7
str.h rev 1.4 rdate.8 rev 1.11 rdate.c rev 1.19 extern.h rev 1.14
getnetgrent.c rev 1.41 netgroup.h rev 1.10
fparseln.3 rev 1.4 fparseln.c rev 1.10

our stringlist.c/stringlist.h are derived from getnetgrent.c
rfc868time.c from rdate.c
newfs/pathnames.h from fsck/pathnames.h

https://mail-index.netbsd.org/source-changes/2009/10/21/msg002182.html
Not all files are covered as some had copyright assigned to TNF in 1998.

1) The yp_bind/yp_unbind and internal _yp_dobind/_yp_unbind sequences shared
dom_binding structs between threads, which is unsafe -- example, dom_vers
signalled retry events, and structs+socket would get deallocated in _yp_unbind.
Change all yp_first (and similar) functions to understand that _yp_dobind now
provides a private dom_binding and socket, which must be released using
_yp_unbind. Use similar methods in the one-step yp_all function.
2) domainname caching in get* is not neccessary now that the domainname cannot
change relative to ypconnect(2)'s decisions.
Many fields in dom_binding struct become unused, so delete them.
ok jmatthew, also tested by miod

Fix matching when all of user, host and domain are specified.
OK guenther@

remove null check before free. from Michael McConville
ok semarie

Wrap <netgroup.h> so internal calls go direct and the symbols are all weak

Hide netgroup internals inside libc. The parts that netgroup_mkdb
wants to use, well.... copy them there.
ok guenther

Add framework for resolving (pun intended) libc namespace issues, using
wrapper .h files and asm labels to let internal calls resolve directly and
not be overridable or use the PLT. Then, apply that framework to most of
the functions in stdio.h, string.h, err.h, and wchar.h. Delete the
should-have-been-hidden-all-along _v?(err|warn)[cx]? symbols while here.

tests clean on i386, amd64, sparc64, powerpc, and mips64

naming feedback from kettenis@ and millert@
ok kettenis@

reallocarray() to detect potential int overflow; ok doug

fix leaks in error cases found by parfait
ok blambert@ miod@ deraadt@

Check snprintf(3) return value for error or truncation.
Mostly path construction, where truncation could be bad.

ok and input from deraadt@ millert@ ray@

Fix debugging code, which tried to print the netgroup name
using the return value of _ng_print(), which returns void.

ok millert@

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

Remove _err() calls from getnetgrent.c. This is a minor API change
as _ng_sl_add() now returns a value. The only consumer of that
interface is netgroup_mkdb(8). Adapted from NetBSD.
OK deraadt@

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

fix use after free, netbsd pr 30832, from phirerunner@comcast.net

ansify function definitions and zap some `register'

ok millert@

unchecked strdup; ok henning; spotted by jjy2+@pitt.edu

KNF

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

avoid incorrect free; reported by danh@nfol.com, my fix

proper protos

realloc repair

NO abort() CALLS IN LIBC

tabify

Back out stringlist

stringlist routines are now public (ftp uses them)

Fix RCS ids
Make sure everything uses {SYS,}LIBC_SCCS properly

from netbsd:
- grab prototypes from netgroup.h
- added _ng_print, netgroup pretty printing function

branches: 1.1.1;
Initial revision

Only compile _ng_print() #ifdef DEBUG_NG; ok millert@

Christos Zoulas agreed to rescind clause 3 and 4 in
NetBSD fsck.8 rev 1.35 fsutil.h rev 1.14 pathnames.h rev 1.2
netgroup_mkdb.8 rev 1.9 netgroup_mkdb.c rev 1.18 str.c rev 1.7
str.h rev 1.4 rdate.8 rev 1.11 rdate.c rev 1.19 extern.h rev 1.14
getnetgrent.c rev 1.41 netgroup.h rev 1.10
fparseln.3 rev 1.4 fparseln.c rev 1.10

our stringlist.c/stringlist.h are derived from getnetgrent.c
rfc868time.c from rdate.c
newfs/pathnames.h from fsck/pathnames.h

https://mail-index.netbsd.org/source-changes/2009/10/21/msg002182.html
Not all files are covered as some had copyright assigned to TNF in 1998.

1) The yp_bind/yp_unbind and internal _yp_dobind/_yp_unbind sequences shared
dom_binding structs between threads, which is unsafe -- example, dom_vers
signalled retry events, and structs+socket would get deallocated in _yp_unbind.
Change all yp_first (and similar) functions to understand that _yp_dobind now
provides a private dom_binding and socket, which must be released using
_yp_unbind. Use similar methods in the one-step yp_all function.
2) domainname caching in get* is not neccessary now that the domainname cannot
change relative to ypconnect(2)'s decisions.
Many fields in dom_binding struct become unused, so delete them.
ok jmatthew, also tested by miod

Fix matching when all of user, host and domain are specified.
OK guenther@

remove null check before free. from Michael McConville
ok semarie

Wrap <netgroup.h> so internal calls go direct and the symbols are all weak

Hide netgroup internals inside libc. The parts that netgroup_mkdb
wants to use, well.... copy them there.
ok guenther

Add framework for resolving (pun intended) libc namespace issues, using
wrapper .h files and asm labels to let internal calls resolve directly and
not be overridable or use the PLT. Then, apply that framework to most of
the functions in stdio.h, string.h, err.h, and wchar.h. Delete the
should-have-been-hidden-all-along _v?(err|warn)[cx]? symbols while here.

tests clean on i386, amd64, sparc64, powerpc, and mips64

naming feedback from kettenis@ and millert@
ok kettenis@

reallocarray() to detect potential int overflow; ok doug

fix leaks in error cases found by parfait
ok blambert@ miod@ deraadt@

Check snprintf(3) return value for error or truncation.
Mostly path construction, where truncation could be bad.

ok and input from deraadt@ millert@ ray@

Fix debugging code, which tried to print the netgroup name
using the return value of _ng_print(), which returns void.

ok millert@

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

Remove _err() calls from getnetgrent.c. This is a minor API change
as _ng_sl_add() now returns a value. The only consumer of that
interface is netgroup_mkdb(8). Adapted from NetBSD.
OK deraadt@

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

fix use after free, netbsd pr 30832, from phirerunner@comcast.net

ansify function definitions and zap some `register'

ok millert@

unchecked strdup; ok henning; spotted by jjy2+@pitt.edu

KNF

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

avoid incorrect free; reported by danh@nfol.com, my fix

proper protos

realloc repair

NO abort() CALLS IN LIBC

tabify

Back out stringlist

stringlist routines are now public (ftp uses them)

Fix RCS ids
Make sure everything uses {SYS,}LIBC_SCCS properly

from netbsd:
- grab prototypes from netgroup.h
- added _ng_print, netgroup pretty printing function

branches: 1.1.1;
Initial revision

Christos Zoulas agreed to rescind clause 3 and 4 in
NetBSD fsck.8 rev 1.35 fsutil.h rev 1.14 pathnames.h rev 1.2
netgroup_mkdb.8 rev 1.9 netgroup_mkdb.c rev 1.18 str.c rev 1.7
str.h rev 1.4 rdate.8 rev 1.11 rdate.c rev 1.19 extern.h rev 1.14
getnetgrent.c rev 1.41 netgroup.h rev 1.10
fparseln.3 rev 1.4 fparseln.c rev 1.10

our stringlist.c/stringlist.h are derived from getnetgrent.c
rfc868time.c from rdate.c
newfs/pathnames.h from fsck/pathnames.h

https://mail-index.netbsd.org/source-changes/2009/10/21/msg002182.html
Not all files are covered as some had copyright assigned to TNF in 1998.

1) The yp_bind/yp_unbind and internal _yp_dobind/_yp_unbind sequences shared
dom_binding structs between threads, which is unsafe -- example, dom_vers
signalled retry events, and structs+socket would get deallocated in _yp_unbind.
Change all yp_first (and similar) functions to understand that _yp_dobind now
provides a private dom_binding and socket, which must be released using
_yp_unbind. Use similar methods in the one-step yp_all function.
2) domainname caching in get* is not neccessary now that the domainname cannot
change relative to ypconnect(2)'s decisions.
Many fields in dom_binding struct become unused, so delete them.
ok jmatthew, also tested by miod

Fix matching when all of user, host and domain are specified.
OK guenther@

remove null check before free. from Michael McConville
ok semarie

Wrap <netgroup.h> so internal calls go direct and the symbols are all weak

Hide netgroup internals inside libc. The parts that netgroup_mkdb
wants to use, well.... copy them there.
ok guenther

Add framework for resolving (pun intended) libc namespace issues, using
wrapper .h files and asm labels to let internal calls resolve directly and
not be overridable or use the PLT. Then, apply that framework to most of
the functions in stdio.h, string.h, err.h, and wchar.h. Delete the
should-have-been-hidden-all-along _v?(err|warn)[cx]? symbols while here.

tests clean on i386, amd64, sparc64, powerpc, and mips64

naming feedback from kettenis@ and millert@
ok kettenis@

reallocarray() to detect potential int overflow; ok doug

fix leaks in error cases found by parfait
ok blambert@ miod@ deraadt@

Check snprintf(3) return value for error or truncation.
Mostly path construction, where truncation could be bad.

ok and input from deraadt@ millert@ ray@

Fix debugging code, which tried to print the netgroup name
using the return value of _ng_print(), which returns void.

ok millert@

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

Remove _err() calls from getnetgrent.c. This is a minor API change
as _ng_sl_add() now returns a value. The only consumer of that
interface is netgroup_mkdb(8). Adapted from NetBSD.
OK deraadt@

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

fix use after free, netbsd pr 30832, from phirerunner@comcast.net

ansify function definitions and zap some `register'

ok millert@

unchecked strdup; ok henning; spotted by jjy2+@pitt.edu

KNF

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

avoid incorrect free; reported by danh@nfol.com, my fix

proper protos

realloc repair

NO abort() CALLS IN LIBC

tabify

Back out stringlist

stringlist routines are now public (ftp uses them)

Fix RCS ids
Make sure everything uses {SYS,}LIBC_SCCS properly

from netbsd:
- grab prototypes from netgroup.h
- added _ng_print, netgroup pretty printing function

branches: 1.1.1;
Initial revision

1) The yp_bind/yp_unbind and internal _yp_dobind/_yp_unbind sequences shared
dom_binding structs between threads, which is unsafe -- example, dom_vers
signalled retry events, and structs+socket would get deallocated in _yp_unbind.
Change all yp_first (and similar) functions to understand that _yp_dobind now
provides a private dom_binding and socket, which must be released using
_yp_unbind. Use similar methods in the one-step yp_all function.
2) domainname caching in get* is not neccessary now that the domainname cannot
change relative to ypconnect(2)'s decisions.
Many fields in dom_binding struct become unused, so delete them.
ok jmatthew, also tested by miod

Fix matching when all of user, host and domain are specified.
OK guenther@

remove null check before free. from Michael McConville
ok semarie

Wrap <netgroup.h> so internal calls go direct and the symbols are all weak

Hide netgroup internals inside libc. The parts that netgroup_mkdb
wants to use, well.... copy them there.
ok guenther

Add framework for resolving (pun intended) libc namespace issues, using
wrapper .h files and asm labels to let internal calls resolve directly and
not be overridable or use the PLT. Then, apply that framework to most of
the functions in stdio.h, string.h, err.h, and wchar.h. Delete the
should-have-been-hidden-all-along _v?(err|warn)[cx]? symbols while here.

tests clean on i386, amd64, sparc64, powerpc, and mips64

naming feedback from kettenis@ and millert@
ok kettenis@

reallocarray() to detect potential int overflow; ok doug

fix leaks in error cases found by parfait
ok blambert@ miod@ deraadt@

Check snprintf(3) return value for error or truncation.
Mostly path construction, where truncation could be bad.

ok and input from deraadt@ millert@ ray@

Fix debugging code, which tried to print the netgroup name
using the return value of _ng_print(), which returns void.

ok millert@

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

Remove _err() calls from getnetgrent.c. This is a minor API change
as _ng_sl_add() now returns a value. The only consumer of that
interface is netgroup_mkdb(8). Adapted from NetBSD.
OK deraadt@

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

fix use after free, netbsd pr 30832, from phirerunner@comcast.net

ansify function definitions and zap some `register'

ok millert@

unchecked strdup; ok henning; spotted by jjy2+@pitt.edu

KNF

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

avoid incorrect free; reported by danh@nfol.com, my fix

proper protos

realloc repair

NO abort() CALLS IN LIBC

tabify

Back out stringlist

stringlist routines are now public (ftp uses them)

Fix RCS ids
Make sure everything uses {SYS,}LIBC_SCCS properly

from netbsd:
- grab prototypes from netgroup.h
- added _ng_print, netgroup pretty printing function

branches: 1.1.1;
Initial revision

Fix matching when all of user, host and domain are specified.
OK guenther@

remove null check before free. from Michael McConville
ok semarie

Wrap <netgroup.h> so internal calls go direct and the symbols are all weak

Hide netgroup internals inside libc. The parts that netgroup_mkdb
wants to use, well.... copy them there.
ok guenther

Add framework for resolving (pun intended) libc namespace issues, using
wrapper .h files and asm labels to let internal calls resolve directly and
not be overridable or use the PLT. Then, apply that framework to most of
the functions in stdio.h, string.h, err.h, and wchar.h. Delete the
should-have-been-hidden-all-along _v?(err|warn)[cx]? symbols while here.

tests clean on i386, amd64, sparc64, powerpc, and mips64

naming feedback from kettenis@ and millert@
ok kettenis@

reallocarray() to detect potential int overflow; ok doug

fix leaks in error cases found by parfait
ok blambert@ miod@ deraadt@

Check snprintf(3) return value for error or truncation.
Mostly path construction, where truncation could be bad.

ok and input from deraadt@ millert@ ray@

Fix debugging code, which tried to print the netgroup name
using the return value of _ng_print(), which returns void.

ok millert@

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

Remove _err() calls from getnetgrent.c. This is a minor API change
as _ng_sl_add() now returns a value. The only consumer of that
interface is netgroup_mkdb(8). Adapted from NetBSD.
OK deraadt@

zap remaining rcsid.

Kill old files that are no longer compiled.

okay theo

fix use after free, netbsd pr 30832, from phirerunner@comcast.net

ansify function definitions and zap some `register'

ok millert@

unchecked strdup; ok henning; spotted by jjy2+@pitt.edu

KNF

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

avoid incorrect free; reported by danh@nfol.com, my fix

proper protos

realloc repair

NO abort() CALLS IN LIBC

tabify

Back out stringlist

stringlist routines are now public (ftp uses them)

Fix RCS ids
Make sure everything uses {SYS,}LIBC_SCCS properly

from netbsd:
- grab prototypes from netgroup.h
- added _ng_print, netgroup pretty printing function

branches: 1.1.1;
Initial revision