In 32 bits sqrt(val) + 1 can overflow, so some big primes still
aren't recognized as such, for example 18446744073709551577 given
in the commit message of factor.c r1.7 from NetBSD. Move the
return type of usqrt() from u_int32_t to u_int64_t.

ok guenther, tom, otto

Convert remaining calls to strtoq/strtouq in base with strtoll/strtoull.
Fix a type mismatch in ftp's "page" command and could make transfers restart
at the wrong position.

ok and a ull->ll tweak from natano@, ok tedu@

Instead of using the floating point square root, use an integer version
of the Newton method from ping.c. Fixes a rounding issue that caused
failure to factor numbers close to 2^64, e.g. 18446744030759878681.
While there, fix an off by one error that caused 4295360521 to be
reported as a prime. Issues reported by Paul Stoeber and Michael Bozon.

ok tedu, deraadt

- General changes:
- Remove -? from getopt(3) options, but still keep (or add) -h where applicable
- Replace hardcoded program strings by getprogname(3)

- Specific changes:
- atc(6): this used -? and -u for usage(), remove both from game and manpage
- bcd(6): use __progname instead of getprogname(3), no need to include stdlib.h
- hunt(6): replace fputs(3) by fprintf(3)

OK tb@ after his suggestions

Some basic code maintenance in games/

- in main() replace exit with return
- drop some /* NOTREACHED */ lint comments along the way.
- make more use of standard CFLAGS, esp. -Wimplicit-function-declaration
- add and sort some headers when needed
- add straightforward pledges to some programs used at compile time

discussed with and ok mestre@

More headers removal and sorted the remaining alphabetically.

Most noticeable that were removed are sys/types.h which will be included from
stdlib.h and in turn also brings along sys/cdefs.h. The other one is limits.h
that was used with the old idiom (denom * random() / LONG_MAX), although it was
only removed were applicable (some files still need that header).

OK tb@

Michal Mazurek pointed out on tech@ that the factor.6 manual needs a bit
of clarification. Thus, express the description both more concisely and
more precisely. Drop details about spaces in the output formatting.
While there, update the corresponding comment in the source code.

With input from jmc@ and mestre@; detailed discussion with sobrado@.

ok sobrado@

Declare usage() functions as __dead void, if they don't return, on games section.

Found another one in arithmetic(6) which also didn't return, and removed a function from number(6) which is not used anymore.

OK tb@

Cast isblank()'s argument to unsigned char.

ok guenther@

Pledge "stdio" for simple games.

ok semarie@

cosmetic fixes

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

synchronization between usage and synopsis; add some missing "usage:"'s

ok jmc@

use strcspn to properly overwrite '\n' in fgets returned buffer

ok moritz@ ray@

exit code 1 on usage; adobriyan@gmail

ansi; khalek@linuxgamers.net

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

No dm -> no need to revoke setegid.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

typo; ericyu@mail2000.com.tw

If primes(6) will generate 32-bit primes, factor should factor 64-bit numbers.

Use u_int32_t rather than unsigned long, both for platform invariance and
because the primes generation table really depends on there not being more
than 32 bits.

remove extraneous newline from error output; PR 2014 and patch from
Tim J. Robbins <tim@robbins.dropbear.id.au>, with one line added so
that trailing whitespace doesn't make a number seem badly formatted.

Correct documentation: rogoyski@cs.utexas.edu in PR 927.

Tidying and minor changes from or based on jsm28@cam.ac.uk's work for the
Linux bsd-games package and NetBSD. Mainly using 'const'.

tags, formatting, ANSI-fication, prototypes, de-typos, and the occasional
initialization, removal of unused variable, or other minor fix. Most
changes are from or inspired by NetBSD.

getopt(3) returns -1 when out of args, not EOF, whee!

proper gid revoke

setgid games, not setuid games. closes a neat set of holes

branches: 1.1.1;
Initial revision