When comparing mtimes for the -u and -Z options and the target is
'too old', use pathconfat(_PC_TIMESTAMP_RESOLUTION, AT_SYMLINK_NOFOLLOW)
to get the timestamp resolution to which the _source_ timestamp
should be truncated for a stable comparison.

Problem reported by Walter Alejandro Iglesias (wai(at)roquesor.com)
ok millert@

Don't open files that will be skipped

Previously, when creating an archive file with pax(1), pax will attempt
to open a file even if the file will be skipped due to an -s replacement
with the empty string. With this change, pax will not attempt to open
files that it knows will be skipped.

When doing direct copies to a directory (-rw), pax already skips
the file before attempting to open it. So this makes the behavior
more consistent.

This can measurably speed up pax when skipping a large number of files.

OK tb@

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Need <time.h> for time() and others. Pulled in by coincidence previously

noted by tb@

reduce and sort #includes

Replace name_{uid,gid}() with the libc routines user_from_uid() and
group_from_gid(). Eliminate some superfluous strncpy() calls.

ok millert@

Use struct timespec internally. This gives nanosecond precision to pax -rw
and a basis for support of mtime and atime values in pax-format extended
header records.

ok millert@

Add PAX_IS_{REG,HARDLINK,LINK} macros to simply many file type tests

ok millert@

If an archive isn't a recognized type, then check whether it looks
like compress, gzip, bzip2, or xz output. If so then error out with
a useful message directing the user to the correct option and error
out instead of scanning forward for an embedded tar/cpio header.

wording help from sobrado@
ok millert@ deraadt@

Unrevert post-unlock:
* Prevent an archive from esacaping the current directory by itself:
when extracting a symlink whose value is absolute or contains ".."
components, just create a zero-length normal file (with additional
tracking of the mode and hardlinks to the symlink) until everything
else is extracted, then go back and replace it with the requested
link (if it's still that zero-length placeholder).

* For tar without -P, if a path in the archive has any ".." components
then strip everything up to and including the last of them (if
it ends in ".." then it becomes ".")
This mostly follows GNU tar's behavior, except for 'tar tf' and
'tar xvf' we report the modified path that would be/was actually
created instead of the raw path from the archive

Above two fixes prompted by a report from Daniel Cegielka
(daniel.cegielka (at) gmail.com)

* For directories whose times or mode will be fixed up in the
clean-up pass, record their dev+ino and then use
open(O_DIRECTORY)+fstat() to verify that we're updating the correct
directory before using futimens() and fchmod().

* Correct buffer overflow in handling of pax extension headers,
caught by the memcpy() overlap check.


previously ok millert@ deraadt@

branches: 1.41.2;
Recent changes haven't been completely stable, so revert for the 5.7 release

requested by deraadt@

Prevent an archive from esacaping the current directory by itself:
when extracting a symlink whose value is absolute or contains ".."
components, just create a zero-length normal file (with additional
tracking of the mode and hardlinks to the symlink) until everything
else is extracted, then go back and replace it with the requested
link (if its still that zero-length placeholder).

This and previous symlink and ".." path fixes prompted by a report
from Daniel Cegielka (daniel.cegielka (at) gmail.com)

ok millert@

branches: 1.39.4;
Make the signal handler safe: block signals when updating data-structures
that are walked by routines called from the signal handler and use
dprintf() instead fprintf() in ar_close().

ok millert@

make pax cope with a stripped down format list, e.g. when compiled
with -DNOCPIO
- ignore empty entries (millert@, halex@)
- replace bsort with linear scan (guenther@)

ok millert@ guenther@

abstraction for the sake of abstraction is distracting.

zap extra func pointer going to the same routines for all formats.
okay millert@

Zap trailing whitespace

Use size_t where appropriate

ok fgsch@

remove some unnecessary sys/param.h inclusions

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

when pax is running in -u mode, and no files are beeing updated because
not one changed, we should not exit with an error but zero to indicate
success (matches solaris behaviour).
need to track wether files were skipped because of the -u checks for that
and take that into account later when taking the exit code decision.
ok theo, comments from otto and miod

Fix extracting and setting permissions for tar archives when
(multiple) -C options are present and/or (multiple) file selections
args are used. Based on a diff in NetBSD PR 22995. Tested by ckuethe@
and jaredy@; ok jaredy@

Prevent segfault when "cpio -o" is called with no input.

Found and fix provided by Alf Schlichting <a dot schlichting at
lemarit dot com>.

OK millert@ and markus@.

append without a file list should not corrupt a tar file;
report Rainer Giedat; ok millert@

spacing

Add support for expanding GNU long links from NetBSD. I've had this
in my tree for ages but didn't have a proper test case. Thanks to
otto@ for providing one.

more "if (foo);" ok millert@

protos. this requires changing the api for the *trail() functions a bit

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

typos;
from netbsd(svs+pr@grep.ru)
suggested by deraadt@

Pull in some changes from NetBSD
o When extracting GNU tar archives, honor @LongLink long links/files
o Add an option to prevent pax from prompting for the next volume
upon premature end of archive.

sprinkle const; mostly from NetBSD

Fix comment typos; most from NetBSD and FreeBSD

kill register

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Add a safe_print() function that uses vis(3) if output is a tty.
Uses the vis C-style mode which is consistent with what GNU tar
does (though GNU tar does vis(3) regardless of whether output is a tty).

It may make sense to add a flag to force vis(3)ification like ls does
but I have not done that here as I'm reticent to add more flags.

use proper str*cpy functions instead of home grown one, spaces; millert@ ok

When invoked as tar, print verbose output to stdout, not stderr. If in list mode or in create mode where create output is to stdout print to stderr

Do not error out on archives without the
customary block of zeroes at the end.

i am bored enough to fix terminal space/tab uglies

#if __STDC__ --> #ifdef __STDC__

Stash fd of cwd instead of using getcwd() to stash path.
This works in cases where the parent dir is not readable.

tabify

(foo *)NULL -> NULL

Fix usage of l_strncpy() (noticed by Theo) and make l_strncpy()
pad with NULL's like strncpy(3). This eliminates the need for
zf_strncpy(); ocurrences of zf_strncpy() have been changed to l_strncpy().

fix pr system/124, reported by Janjaap van Velthooven (janjaap@stack.nl).

Support multiple -v options like GNU tar (> 1 -v means do ls-like output).

Initial cut -C support in paxtar. Exceeds GNU tar by quite a bit.
General pax still seems to work ok.

update rcsid

Correct compile warnings
Rename warn() to paxwarn() so <err.h> can be included

Remove #include <ctype.h> when not needed; from FreeBSD

branches: 1.1.1;
Initial revision

Don't open files that will be skipped

Previously, when creating an archive file with pax(1), pax will attempt
to open a file even if the file will be skipped due to an -s replacement
with the empty string. With this change, pax will not attempt to open
files that it knows will be skipped.

When doing direct copies to a directory (-rw), pax already skips
the file before attempting to open it. So this makes the behavior
more consistent.

This can measurably speed up pax when skipping a large number of files.

OK tb@

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Need <time.h> for time() and others. Pulled in by coincidence previously

noted by tb@

reduce and sort #includes

Replace name_{uid,gid}() with the libc routines user_from_uid() and
group_from_gid(). Eliminate some superfluous strncpy() calls.

ok millert@

Use struct timespec internally. This gives nanosecond precision to pax -rw
and a basis for support of mtime and atime values in pax-format extended
header records.

ok millert@

Add PAX_IS_{REG,HARDLINK,LINK} macros to simply many file type tests

ok millert@

If an archive isn't a recognized type, then check whether it looks
like compress, gzip, bzip2, or xz output. If so then error out with
a useful message directing the user to the correct option and error
out instead of scanning forward for an embedded tar/cpio header.

wording help from sobrado@
ok millert@ deraadt@

Unrevert post-unlock:
* Prevent an archive from esacaping the current directory by itself:
when extracting a symlink whose value is absolute or contains ".."
components, just create a zero-length normal file (with additional
tracking of the mode and hardlinks to the symlink) until everything
else is extracted, then go back and replace it with the requested
link (if it's still that zero-length placeholder).

* For tar without -P, if a path in the archive has any ".." components
then strip everything up to and including the last of them (if
it ends in ".." then it becomes ".")
This mostly follows GNU tar's behavior, except for 'tar tf' and
'tar xvf' we report the modified path that would be/was actually
created instead of the raw path from the archive

Above two fixes prompted by a report from Daniel Cegielka
(daniel.cegielka (at) gmail.com)

* For directories whose times or mode will be fixed up in the
clean-up pass, record their dev+ino and then use
open(O_DIRECTORY)+fstat() to verify that we're updating the correct
directory before using futimens() and fchmod().

* Correct buffer overflow in handling of pax extension headers,
caught by the memcpy() overlap check.


previously ok millert@ deraadt@

branches: 1.41.2;
Recent changes haven't been completely stable, so revert for the 5.7 release

requested by deraadt@

Prevent an archive from esacaping the current directory by itself:
when extracting a symlink whose value is absolute or contains ".."
components, just create a zero-length normal file (with additional
tracking of the mode and hardlinks to the symlink) until everything
else is extracted, then go back and replace it with the requested
link (if its still that zero-length placeholder).

This and previous symlink and ".." path fixes prompted by a report
from Daniel Cegielka (daniel.cegielka (at) gmail.com)

ok millert@

branches: 1.39.4;
Make the signal handler safe: block signals when updating data-structures
that are walked by routines called from the signal handler and use
dprintf() instead fprintf() in ar_close().

ok millert@

make pax cope with a stripped down format list, e.g. when compiled
with -DNOCPIO
- ignore empty entries (millert@, halex@)
- replace bsort with linear scan (guenther@)

ok millert@ guenther@

abstraction for the sake of abstraction is distracting.

zap extra func pointer going to the same routines for all formats.
okay millert@

Zap trailing whitespace

Use size_t where appropriate

ok fgsch@

remove some unnecessary sys/param.h inclusions

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

when pax is running in -u mode, and no files are beeing updated because
not one changed, we should not exit with an error but zero to indicate
success (matches solaris behaviour).
need to track wether files were skipped because of the -u checks for that
and take that into account later when taking the exit code decision.
ok theo, comments from otto and miod

Fix extracting and setting permissions for tar archives when
(multiple) -C options are present and/or (multiple) file selections
args are used. Based on a diff in NetBSD PR 22995. Tested by ckuethe@
and jaredy@; ok jaredy@

Prevent segfault when "cpio -o" is called with no input.

Found and fix provided by Alf Schlichting <a dot schlichting at
lemarit dot com>.

OK millert@ and markus@.

append without a file list should not corrupt a tar file;
report Rainer Giedat; ok millert@

spacing

Add support for expanding GNU long links from NetBSD. I've had this
in my tree for ages but didn't have a proper test case. Thanks to
otto@ for providing one.

more "if (foo);" ok millert@

protos. this requires changing the api for the *trail() functions a bit

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

typos;
from netbsd(svs+pr@grep.ru)
suggested by deraadt@

Pull in some changes from NetBSD
o When extracting GNU tar archives, honor @LongLink long links/files
o Add an option to prevent pax from prompting for the next volume
upon premature end of archive.

sprinkle const; mostly from NetBSD

Fix comment typos; most from NetBSD and FreeBSD

kill register

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Add a safe_print() function that uses vis(3) if output is a tty.
Uses the vis C-style mode which is consistent with what GNU tar
does (though GNU tar does vis(3) regardless of whether output is a tty).

It may make sense to add a flag to force vis(3)ification like ls does
but I have not done that here as I'm reticent to add more flags.

use proper str*cpy functions instead of home grown one, spaces; millert@ ok

When invoked as tar, print verbose output to stdout, not stderr. If in list mode or in create mode where create output is to stdout print to stderr

Do not error out on archives without the
customary block of zeroes at the end.

i am bored enough to fix terminal space/tab uglies

#if __STDC__ --> #ifdef __STDC__

Stash fd of cwd instead of using getcwd() to stash path.
This works in cases where the parent dir is not readable.

tabify

(foo *)NULL -> NULL

Fix usage of l_strncpy() (noticed by Theo) and make l_strncpy()
pad with NULL's like strncpy(3). This eliminates the need for
zf_strncpy(); ocurrences of zf_strncpy() have been changed to l_strncpy().

fix pr system/124, reported by Janjaap van Velthooven (janjaap@stack.nl).

Support multiple -v options like GNU tar (> 1 -v means do ls-like output).

Initial cut -C support in paxtar. Exceeds GNU tar by quite a bit.
General pax still seems to work ok.

update rcsid

Correct compile warnings
Rename warn() to paxwarn() so <err.h> can be included

Remove #include <ctype.h> when not needed; from FreeBSD

branches: 1.1.1;
Initial revision

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Need <time.h> for time() and others. Pulled in by coincidence previously

noted by tb@

reduce and sort #includes

Replace name_{uid,gid}() with the libc routines user_from_uid() and
group_from_gid(). Eliminate some superfluous strncpy() calls.

ok millert@

Use struct timespec internally. This gives nanosecond precision to pax -rw
and a basis for support of mtime and atime values in pax-format extended
header records.

ok millert@

Add PAX_IS_{REG,HARDLINK,LINK} macros to simply many file type tests

ok millert@

If an archive isn't a recognized type, then check whether it looks
like compress, gzip, bzip2, or xz output. If so then error out with
a useful message directing the user to the correct option and error
out instead of scanning forward for an embedded tar/cpio header.

wording help from sobrado@
ok millert@ deraadt@

Unrevert post-unlock:
* Prevent an archive from esacaping the current directory by itself:
when extracting a symlink whose value is absolute or contains ".."
components, just create a zero-length normal file (with additional
tracking of the mode and hardlinks to the symlink) until everything
else is extracted, then go back and replace it with the requested
link (if it's still that zero-length placeholder).

* For tar without -P, if a path in the archive has any ".." components
then strip everything up to and including the last of them (if
it ends in ".." then it becomes ".")
This mostly follows GNU tar's behavior, except for 'tar tf' and
'tar xvf' we report the modified path that would be/was actually
created instead of the raw path from the archive

Above two fixes prompted by a report from Daniel Cegielka
(daniel.cegielka (at) gmail.com)

* For directories whose times or mode will be fixed up in the
clean-up pass, record their dev+ino and then use
open(O_DIRECTORY)+fstat() to verify that we're updating the correct
directory before using futimens() and fchmod().

* Correct buffer overflow in handling of pax extension headers,
caught by the memcpy() overlap check.


previously ok millert@ deraadt@

branches: 1.41.2;
Recent changes haven't been completely stable, so revert for the 5.7 release

requested by deraadt@

Prevent an archive from esacaping the current directory by itself:
when extracting a symlink whose value is absolute or contains ".."
components, just create a zero-length normal file (with additional
tracking of the mode and hardlinks to the symlink) until everything
else is extracted, then go back and replace it with the requested
link (if its still that zero-length placeholder).

This and previous symlink and ".." path fixes prompted by a report
from Daniel Cegielka (daniel.cegielka (at) gmail.com)

ok millert@

branches: 1.39.4;
Make the signal handler safe: block signals when updating data-structures
that are walked by routines called from the signal handler and use
dprintf() instead fprintf() in ar_close().

ok millert@

make pax cope with a stripped down format list, e.g. when compiled
with -DNOCPIO
- ignore empty entries (millert@, halex@)
- replace bsort with linear scan (guenther@)

ok millert@ guenther@

abstraction for the sake of abstraction is distracting.

zap extra func pointer going to the same routines for all formats.
okay millert@

Zap trailing whitespace

Use size_t where appropriate

ok fgsch@

remove some unnecessary sys/param.h inclusions

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

when pax is running in -u mode, and no files are beeing updated because
not one changed, we should not exit with an error but zero to indicate
success (matches solaris behaviour).
need to track wether files were skipped because of the -u checks for that
and take that into account later when taking the exit code decision.
ok theo, comments from otto and miod

Fix extracting and setting permissions for tar archives when
(multiple) -C options are present and/or (multiple) file selections
args are used. Based on a diff in NetBSD PR 22995. Tested by ckuethe@
and jaredy@; ok jaredy@

Prevent segfault when "cpio -o" is called with no input.

Found and fix provided by Alf Schlichting <a dot schlichting at
lemarit dot com>.

OK millert@ and markus@.

append without a file list should not corrupt a tar file;
report Rainer Giedat; ok millert@

spacing

Add support for expanding GNU long links from NetBSD. I've had this
in my tree for ages but didn't have a proper test case. Thanks to
otto@ for providing one.

more "if (foo);" ok millert@

protos. this requires changing the api for the *trail() functions a bit

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

typos;
from netbsd(svs+pr@grep.ru)
suggested by deraadt@

Pull in some changes from NetBSD
o When extracting GNU tar archives, honor @LongLink long links/files
o Add an option to prevent pax from prompting for the next volume
upon premature end of archive.

sprinkle const; mostly from NetBSD

Fix comment typos; most from NetBSD and FreeBSD

kill register

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Add a safe_print() function that uses vis(3) if output is a tty.
Uses the vis C-style mode which is consistent with what GNU tar
does (though GNU tar does vis(3) regardless of whether output is a tty).

It may make sense to add a flag to force vis(3)ification like ls does
but I have not done that here as I'm reticent to add more flags.

use proper str*cpy functions instead of home grown one, spaces; millert@ ok

When invoked as tar, print verbose output to stdout, not stderr. If in list mode or in create mode where create output is to stdout print to stderr

Do not error out on archives without the
customary block of zeroes at the end.

i am bored enough to fix terminal space/tab uglies

#if __STDC__ --> #ifdef __STDC__

Stash fd of cwd instead of using getcwd() to stash path.
This works in cases where the parent dir is not readable.

tabify

(foo *)NULL -> NULL

Fix usage of l_strncpy() (noticed by Theo) and make l_strncpy()
pad with NULL's like strncpy(3). This eliminates the need for
zf_strncpy(); ocurrences of zf_strncpy() have been changed to l_strncpy().

fix pr system/124, reported by Janjaap van Velthooven (janjaap@stack.nl).

Support multiple -v options like GNU tar (> 1 -v means do ls-like output).

Initial cut -C support in paxtar. Exceeds GNU tar by quite a bit.
General pax still seems to work ok.

update rcsid

Correct compile warnings
Rename warn() to paxwarn() so <err.h> can be included

Remove #include <ctype.h> when not needed; from FreeBSD

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Need <time.h> for time() and others. Pulled in by coincidence previously

noted by tb@

reduce and sort #includes

Replace name_{uid,gid}() with the libc routines user_from_uid() and
group_from_gid(). Eliminate some superfluous strncpy() calls.

ok millert@

Use struct timespec internally. This gives nanosecond precision to pax -rw
and a basis for support of mtime and atime values in pax-format extended
header records.

ok millert@

Add PAX_IS_{REG,HARDLINK,LINK} macros to simply many file type tests

ok millert@

If an archive isn't a recognized type, then check whether it looks
like compress, gzip, bzip2, or xz output. If so then error out with
a useful message directing the user to the correct option and error
out instead of scanning forward for an embedded tar/cpio header.

wording help from sobrado@
ok millert@ deraadt@

Unrevert post-unlock:
* Prevent an archive from esacaping the current directory by itself:
when extracting a symlink whose value is absolute or contains ".."
components, just create a zero-length normal file (with additional
tracking of the mode and hardlinks to the symlink) until everything
else is extracted, then go back and replace it with the requested
link (if it's still that zero-length placeholder).

* For tar without -P, if a path in the archive has any ".." components
then strip everything up to and including the last of them (if
it ends in ".." then it becomes ".")
This mostly follows GNU tar's behavior, except for 'tar tf' and
'tar xvf' we report the modified path that would be/was actually
created instead of the raw path from the archive

Above two fixes prompted by a report from Daniel Cegielka
(daniel.cegielka (at) gmail.com)

* For directories whose times or mode will be fixed up in the
clean-up pass, record their dev+ino and then use
open(O_DIRECTORY)+fstat() to verify that we're updating the correct
directory before using futimens() and fchmod().

* Correct buffer overflow in handling of pax extension headers,
caught by the memcpy() overlap check.


previously ok millert@ deraadt@

branches: 1.41.2;
Recent changes haven't been completely stable, so revert for the 5.7 release

requested by deraadt@

Prevent an archive from esacaping the current directory by itself:
when extracting a symlink whose value is absolute or contains ".."
components, just create a zero-length normal file (with additional
tracking of the mode and hardlinks to the symlink) until everything
else is extracted, then go back and replace it with the requested
link (if its still that zero-length placeholder).

This and previous symlink and ".." path fixes prompted by a report
from Daniel Cegielka (daniel.cegielka (at) gmail.com)

ok millert@

branches: 1.39.4;
Make the signal handler safe: block signals when updating data-structures
that are walked by routines called from the signal handler and use
dprintf() instead fprintf() in ar_close().

ok millert@

make pax cope with a stripped down format list, e.g. when compiled
with -DNOCPIO
- ignore empty entries (millert@, halex@)
- replace bsort with linear scan (guenther@)

ok millert@ guenther@

abstraction for the sake of abstraction is distracting.

zap extra func pointer going to the same routines for all formats.
okay millert@

Zap trailing whitespace

Use size_t where appropriate

ok fgsch@

remove some unnecessary sys/param.h inclusions

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

when pax is running in -u mode, and no files are beeing updated because
not one changed, we should not exit with an error but zero to indicate
success (matches solaris behaviour).
need to track wether files were skipped because of the -u checks for that
and take that into account later when taking the exit code decision.
ok theo, comments from otto and miod

Fix extracting and setting permissions for tar archives when
(multiple) -C options are present and/or (multiple) file selections
args are used. Based on a diff in NetBSD PR 22995. Tested by ckuethe@
and jaredy@; ok jaredy@

Prevent segfault when "cpio -o" is called with no input.

Found and fix provided by Alf Schlichting <a dot schlichting at
lemarit dot com>.

OK millert@ and markus@.

append without a file list should not corrupt a tar file;
report Rainer Giedat; ok millert@

spacing

Add support for expanding GNU long links from NetBSD. I've had this
in my tree for ages but didn't have a proper test case. Thanks to
otto@ for providing one.

more "if (foo);" ok millert@

protos. this requires changing the api for the *trail() functions a bit

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

typos;
from netbsd(svs+pr@grep.ru)
suggested by deraadt@

Pull in some changes from NetBSD
o When extracting GNU tar archives, honor @LongLink long links/files
o Add an option to prevent pax from prompting for the next volume
upon premature end of archive.

sprinkle const; mostly from NetBSD

Fix comment typos; most from NetBSD and FreeBSD

kill register

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Add a safe_print() function that uses vis(3) if output is a tty.
Uses the vis C-style mode which is consistent with what GNU tar
does (though GNU tar does vis(3) regardless of whether output is a tty).

It may make sense to add a flag to force vis(3)ification like ls does
but I have not done that here as I'm reticent to add more flags.

use proper str*cpy functions instead of home grown one, spaces; millert@ ok

When invoked as tar, print verbose output to stdout, not stderr. If in list mode or in create mode where create output is to stdout print to stderr

Do not error out on archives without the
customary block of zeroes at the end.

i am bored enough to fix terminal space/tab uglies

#if __STDC__ --> #ifdef __STDC__

Stash fd of cwd instead of using getcwd() to stash path.
This works in cases where the parent dir is not readable.

tabify

(foo *)NULL -> NULL

Fix usage of l_strncpy() (noticed by Theo) and make l_strncpy()
pad with NULL's like strncpy(3). This eliminates the need for
zf_strncpy(); ocurrences of zf_strncpy() have been changed to l_strncpy().

fix pr system/124, reported by Janjaap van Velthooven (janjaap@stack.nl).

Support multiple -v options like GNU tar (> 1 -v means do ls-like output).

Initial cut -C support in paxtar. Exceeds GNU tar by quite a bit.
General pax still seems to work ok.

update rcsid

Correct compile warnings
Rename warn() to paxwarn() so <err.h> can be included

Remove #include <ctype.h> when not needed; from FreeBSD

branches: 1.1.1;
Initial revision

Need <time.h> for time() and others. Pulled in by coincidence previously

noted by tb@

reduce and sort #includes

Replace name_{uid,gid}() with the libc routines user_from_uid() and
group_from_gid(). Eliminate some superfluous strncpy() calls.

ok millert@

Use struct timespec internally. This gives nanosecond precision to pax -rw
and a basis for support of mtime and atime values in pax-format extended
header records.

ok millert@

Add PAX_IS_{REG,HARDLINK,LINK} macros to simply many file type tests

ok millert@

If an archive isn't a recognized type, then check whether it looks
like compress, gzip, bzip2, or xz output. If so then error out with
a useful message directing the user to the correct option and error
out instead of scanning forward for an embedded tar/cpio header.

wording help from sobrado@
ok millert@ deraadt@

Unrevert post-unlock:
* Prevent an archive from esacaping the current directory by itself:
when extracting a symlink whose value is absolute or contains ".."
components, just create a zero-length normal file (with additional
tracking of the mode and hardlinks to the symlink) until everything
else is extracted, then go back and replace it with the requested
link (if it's still that zero-length placeholder).

* For tar without -P, if a path in the archive has any ".." components
then strip everything up to and including the last of them (if
it ends in ".." then it becomes ".")
This mostly follows GNU tar's behavior, except for 'tar tf' and
'tar xvf' we report the modified path that would be/was actually
created instead of the raw path from the archive

Above two fixes prompted by a report from Daniel Cegielka
(daniel.cegielka (at) gmail.com)

* For directories whose times or mode will be fixed up in the
clean-up pass, record their dev+ino and then use
open(O_DIRECTORY)+fstat() to verify that we're updating the correct
directory before using futimens() and fchmod().

* Correct buffer overflow in handling of pax extension headers,
caught by the memcpy() overlap check.


previously ok millert@ deraadt@

branches: 1.41.2;
Recent changes haven't been completely stable, so revert for the 5.7 release

requested by deraadt@

Prevent an archive from esacaping the current directory by itself:
when extracting a symlink whose value is absolute or contains ".."
components, just create a zero-length normal file (with additional
tracking of the mode and hardlinks to the symlink) until everything
else is extracted, then go back and replace it with the requested
link (if its still that zero-length placeholder).

This and previous symlink and ".." path fixes prompted by a report
from Daniel Cegielka (daniel.cegielka (at) gmail.com)

ok millert@

branches: 1.39.4;
Make the signal handler safe: block signals when updating data-structures
that are walked by routines called from the signal handler and use
dprintf() instead fprintf() in ar_close().

ok millert@

make pax cope with a stripped down format list, e.g. when compiled
with -DNOCPIO
- ignore empty entries (millert@, halex@)
- replace bsort with linear scan (guenther@)

ok millert@ guenther@

abstraction for the sake of abstraction is distracting.

zap extra func pointer going to the same routines for all formats.
okay millert@

Zap trailing whitespace

Use size_t where appropriate

ok fgsch@

remove some unnecessary sys/param.h inclusions

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

when pax is running in -u mode, and no files are beeing updated because
not one changed, we should not exit with an error but zero to indicate
success (matches solaris behaviour).
need to track wether files were skipped because of the -u checks for that
and take that into account later when taking the exit code decision.
ok theo, comments from otto and miod

Fix extracting and setting permissions for tar archives when
(multiple) -C options are present and/or (multiple) file selections
args are used. Based on a diff in NetBSD PR 22995. Tested by ckuethe@
and jaredy@; ok jaredy@

Prevent segfault when "cpio -o" is called with no input.

Found and fix provided by Alf Schlichting <a dot schlichting at
lemarit dot com>.

OK millert@ and markus@.

append without a file list should not corrupt a tar file;
report Rainer Giedat; ok millert@

spacing

Add support for expanding GNU long links from NetBSD. I've had this
in my tree for ages but didn't have a proper test case. Thanks to
otto@ for providing one.

more "if (foo);" ok millert@

protos. this requires changing the api for the *trail() functions a bit

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

typos;
from netbsd(svs+pr@grep.ru)
suggested by deraadt@

Pull in some changes from NetBSD
o When extracting GNU tar archives, honor @LongLink long links/files
o Add an option to prevent pax from prompting for the next volume
upon premature end of archive.

sprinkle const; mostly from NetBSD

Fix comment typos; most from NetBSD and FreeBSD

kill register

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

Add a safe_print() function that uses vis(3) if output is a tty.
Uses the vis C-style mode which is consistent with what GNU tar
does (though GNU tar does vis(3) regardless of whether output is a tty).

It may make sense to add a flag to force vis(3)ification like ls does
but I have not done that here as I'm reticent to add more flags.

use proper str*cpy functions instead of home grown one, spaces; millert@ ok

When invoked as tar, print verbose output to stdout, not stderr. If in list mode or in create mode where create output is to stdout print to stderr

Do not error out on archives without the
customary block of zeroes at the end.

i am bored enough to fix terminal space/tab uglies

#if __STDC__ --> #ifdef __STDC__

Stash fd of cwd instead of using getcwd() to stash path.
This works in cases where the parent dir is not readable.

tabify

(foo *)NULL -> NULL

Fix usage of l_strncpy() (noticed by Theo) and make l_strncpy()
pad with NULL's like strncpy(3). This eliminates the need for
zf_strncpy(); ocurrences of zf_strncpy() have been changed to l_strncpy().

fix pr system/124, reported by Janjaap van Velthooven (janjaap@stack.nl).

Support multiple -v options like GNU tar (> 1 -v means do ls-like output).

Initial cut -C support in paxtar. Exceeds GNU tar by quite a bit.
General pax still seems to work ok.

update rcsid

Correct compile warnings
Rename warn() to paxwarn() so <err.h> can be included

Remove #include <ctype.h> when not needed; from FreeBSD

branches: 1.1.1;
Initial revision