Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

snprintf/vsnprintf return < 0 on error, rather than -1.

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

ensure tape name and tape commands are not too long. passing too long
commands to the other side could cause problems.
ok guenther tb

add unsigned char casts for specific calls to ctype.h macros.
ok guenther step

replace sys/param.h with sys/types.h (and sometimes add limits.h if needed)
ok guenther

remove sunos backwards compat

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Check for strdup() failure.

OK jaredy@

use strdup() instead; adobriyan@gmail

ARGSUSED on signal handler

ansification, art ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

strlcpy

kill more registers.

millert@ ok

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

in a signal handler, change errx() to warnx() + _exit; millert ok

Don't put newline's in warnx()

(foo *)0 -> NULL

Don't complain if setsockopt() fails. It will fail if we used rcmdsh()
instead of rcmd() and there's no easy way to detect which we used now.

not setuid, silence TCP_MAXSEG for non-root

check rcmd() return val and exit nicely.

sprintf -> snprintf

From NetBSD:
Add remote tape capabilities.
Since we're setuid, let's be paranoid.
Picked up a little lint in the dryer.

snprintf/vsnprintf return < 0 on error, rather than -1.

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

ensure tape name and tape commands are not too long. passing too long
commands to the other side could cause problems.
ok guenther tb

add unsigned char casts for specific calls to ctype.h macros.
ok guenther step

replace sys/param.h with sys/types.h (and sometimes add limits.h if needed)
ok guenther

remove sunos backwards compat

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Check for strdup() failure.

OK jaredy@

use strdup() instead; adobriyan@gmail

ARGSUSED on signal handler

ansification, art ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

strlcpy

kill more registers.

millert@ ok

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

in a signal handler, change errx() to warnx() + _exit; millert ok

Don't put newline's in warnx()

(foo *)0 -> NULL

Don't complain if setsockopt() fails. It will fail if we used rcmdsh()
instead of rcmd() and there's no easy way to detect which we used now.

not setuid, silence TCP_MAXSEG for non-root

check rcmd() return val and exit nicely.

sprintf -> snprintf

From NetBSD:
Add remote tape capabilities.
Since we're setuid, let's be paranoid.
Picked up a little lint in the dryer.

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

ensure tape name and tape commands are not too long. passing too long
commands to the other side could cause problems.
ok guenther tb

add unsigned char casts for specific calls to ctype.h macros.
ok guenther step

replace sys/param.h with sys/types.h (and sometimes add limits.h if needed)
ok guenther

remove sunos backwards compat

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Check for strdup() failure.

OK jaredy@

use strdup() instead; adobriyan@gmail

ARGSUSED on signal handler

ansification, art ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

strlcpy

kill more registers.

millert@ ok

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

in a signal handler, change errx() to warnx() + _exit; millert ok

Don't put newline's in warnx()

(foo *)0 -> NULL

Don't complain if setsockopt() fails. It will fail if we used rcmdsh()
instead of rcmd() and there's no easy way to detect which we used now.

not setuid, silence TCP_MAXSEG for non-root

check rcmd() return val and exit nicely.

sprintf -> snprintf

From NetBSD:
Add remote tape capabilities.
Since we're setuid, let's be paranoid.
Picked up a little lint in the dryer.

ensure tape name and tape commands are not too long. passing too long
commands to the other side could cause problems.
ok guenther tb

add unsigned char casts for specific calls to ctype.h macros.
ok guenther step

replace sys/param.h with sys/types.h (and sometimes add limits.h if needed)
ok guenther

remove sunos backwards compat

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Check for strdup() failure.

OK jaredy@

use strdup() instead; adobriyan@gmail

ARGSUSED on signal handler

ansification, art ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

strlcpy

kill more registers.

millert@ ok

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

in a signal handler, change errx() to warnx() + _exit; millert ok

Don't put newline's in warnx()

(foo *)0 -> NULL

Don't complain if setsockopt() fails. It will fail if we used rcmdsh()
instead of rcmd() and there's no easy way to detect which we used now.

not setuid, silence TCP_MAXSEG for non-root

check rcmd() return val and exit nicely.

sprintf -> snprintf

From NetBSD:
Add remote tape capabilities.
Since we're setuid, let's be paranoid.
Picked up a little lint in the dryer.

add unsigned char casts for specific calls to ctype.h macros.
ok guenther step

replace sys/param.h with sys/types.h (and sometimes add limits.h if needed)
ok guenther

remove sunos backwards compat

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Check for strdup() failure.

OK jaredy@

use strdup() instead; adobriyan@gmail

ARGSUSED on signal handler

ansification, art ok

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

strlcpy

kill more registers.

millert@ ok

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

in a signal handler, change errx() to warnx() + _exit; millert ok

Don't put newline's in warnx()

(foo *)0 -> NULL

Don't complain if setsockopt() fails. It will fail if we used rcmdsh()
instead of rcmd() and there's no easy way to detect which we used now.

not setuid, silence TCP_MAXSEG for non-root

check rcmd() return val and exit nicely.

sprintf -> snprintf

From NetBSD:
Add remote tape capabilities.
Since we're setuid, let's be paranoid.
Picked up a little lint in the dryer.