Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

When it's the possessive of 'it', it's spelled "its", without the
apostrophe.

funopen(): change seekfn argument to use off_t, not fpos_t
On BSD, fpos_t is typedef'd to off_t but some systems use a struct.
This means fpos_t is not a portable function argument or return value.
Both FreeBSD and the Linux libbsd funopen() have switched to off_t
for this--we should too. From Joe Nelson. OK deraadt@

Fix multiple variable definitions to avoid errors with -fno-common.

ok millert@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Fix some minor issues found by coverity.

OK millert@ and miko@

blkfree() takes no action for NULL pointer so callers can avoid checking.

ok jca@

Passing NULL to free() is fine; from Michael W. Bombardieri.

Include hostname in shell prompts by default

With tmux, ssh and vmd, we tend to open shells on many different hosts
simultaneously and the default prompts '$ ' and '# ' for {,k}sh as well
as '% ' and '# ' for csh become dangerous: it's very easy to issue a
command on the wrong host.

This can easily be avoided by displaying the hostname in the prompt.
Everything beyond "hostname{$,#,%} " is going to be a matter of taste,
so we left it at that. If you use an FQDN, only the first part (the
output of 'hostname -s') will be printed.

requested by and ok deraadt; mostly positive feedback many
ok anton, brynet, bcallah and others

Fix pasting of long (>BUFSIZ) lines in csh with filec enabled. NUL-terminating
the input buffer instructs csh that the buffer contains a complete command. This
is wrong and should only happen when buffer is not full, otherwise more data has
to be read in order form a complete command.

While here, do not print the prompt again when the input exceeds the input
buffer and while inserting a line continuation (backslash).

Postpone printing of prompt if filec is enabled in csh. Any I/O should be
performed first when canonical mode has been disabled on the tty just like ksh
does. Discovered by the regress tests.

Joint work with bluhm@, ok deraadt@

Turn off the close-on-exec bit with fcntl() instead of ioctl().

Remove some now useless "#include <ioctl.h>" lines.

Inspired by & ok millert@

Replace ioctl(fd, FIOCLEX) with fcntl(fd, F_SETFD, FD_CLOEXEC)
No functional change. "I like the idea" from guenther@

Replace handrolled xfree() function by directly using free(3)

OK mmcc@

exit() after perror() for pledge failure. Perhaps this got introduced
as a test idiom, either when pledge was young or during the transition
to strings.... dunno

unifdef _PATH_*

miscellaneous cruft:
* remove lint
* unifdef S_IFLNK, S_ISFIFO, S_ISLNK, S_ISSOCK, O_APPEND
* remove 0, NOTUSED, notdef -- untouched since original import
* remove IIASA

remove the profiling and debugging ifdefs; ok zhuk@

Clean up cruft made visible by the NLS unifdefing:
* remove setlocale() calls
* remove write-only variable AsciiOnly
* remove now unused string constants STRLANG, STRLC_CTYPE
* remove hardcoded support for ISO8859-1

ok millert@

unifdef BUILTIN (unused), NLS (always set), SHORT_STRINGS (always set)
and remove a few unused defines; no binary changes; ok tedu@ zhuk@

setlocale() before pledge()... until we learn more

With TIOCSTI supported in pledge "tty proc", csh is good enough to run
with pledge "stdio rpath wpath cpath fattr getpw proc exec tty". (Note
that ksh "emacs mode" is also a abus^Wconsumer of TIOCSTI, but we had
let that slide for a week since noone uses it...)

delete many more ptr_t casts

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Use reallocarray() and remove a few archaic memory allocation practices.
ok deraadt

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

do not name file descriptors fp, either

unused code and variables

spacing

de-register and ansify functions

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

bring in strlcpy and strlcat-like things for dealing with Char types,
this fixes at least 15 buffer overflows; some help from dhartmei.
Anyone want to go do the same in ksh, and help with some of the while
(*s++ = *p++) loops in here?

knf

spelling; moritz@jodeit.org

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

mark signal races, and remove junk

Use mkstemp(3) for here document (<<) temporary files instead of $$
Problem noted by proton@ENERGYMECH.NET

even better fix for importpath(); from christos@zoulas.com; millert@ ok

prevent core dumps when stderror() is called before reslab is initialized

NUL not NULL

spelling

make signal handlers errno safe

#if __STDC__ --> #ifdef __STDC__

tabify

Update from NetBSD (christos)
Quote all imported environment variables.

compile

Don't honor $HOME if >= MAXPATHLEN

update rcsid

branches: 1.1.1;
Initial revision

When it's the possessive of 'it', it's spelled "its", without the
apostrophe.

funopen(): change seekfn argument to use off_t, not fpos_t
On BSD, fpos_t is typedef'd to off_t but some systems use a struct.
This means fpos_t is not a portable function argument or return value.
Both FreeBSD and the Linux libbsd funopen() have switched to off_t
for this--we should too. From Joe Nelson. OK deraadt@

Fix multiple variable definitions to avoid errors with -fno-common.

ok millert@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Fix some minor issues found by coverity.

OK millert@ and miko@

blkfree() takes no action for NULL pointer so callers can avoid checking.

ok jca@

Passing NULL to free() is fine; from Michael W. Bombardieri.

Include hostname in shell prompts by default

With tmux, ssh and vmd, we tend to open shells on many different hosts
simultaneously and the default prompts '$ ' and '# ' for {,k}sh as well
as '% ' and '# ' for csh become dangerous: it's very easy to issue a
command on the wrong host.

This can easily be avoided by displaying the hostname in the prompt.
Everything beyond "hostname{$,#,%} " is going to be a matter of taste,
so we left it at that. If you use an FQDN, only the first part (the
output of 'hostname -s') will be printed.

requested by and ok deraadt; mostly positive feedback many
ok anton, brynet, bcallah and others

Fix pasting of long (>BUFSIZ) lines in csh with filec enabled. NUL-terminating
the input buffer instructs csh that the buffer contains a complete command. This
is wrong and should only happen when buffer is not full, otherwise more data has
to be read in order form a complete command.

While here, do not print the prompt again when the input exceeds the input
buffer and while inserting a line continuation (backslash).

Postpone printing of prompt if filec is enabled in csh. Any I/O should be
performed first when canonical mode has been disabled on the tty just like ksh
does. Discovered by the regress tests.

Joint work with bluhm@, ok deraadt@

Turn off the close-on-exec bit with fcntl() instead of ioctl().

Remove some now useless "#include <ioctl.h>" lines.

Inspired by & ok millert@

Replace ioctl(fd, FIOCLEX) with fcntl(fd, F_SETFD, FD_CLOEXEC)
No functional change. "I like the idea" from guenther@

Replace handrolled xfree() function by directly using free(3)

OK mmcc@

exit() after perror() for pledge failure. Perhaps this got introduced
as a test idiom, either when pledge was young or during the transition
to strings.... dunno

unifdef _PATH_*

miscellaneous cruft:
* remove lint
* unifdef S_IFLNK, S_ISFIFO, S_ISLNK, S_ISSOCK, O_APPEND
* remove 0, NOTUSED, notdef -- untouched since original import
* remove IIASA

remove the profiling and debugging ifdefs; ok zhuk@

Clean up cruft made visible by the NLS unifdefing:
* remove setlocale() calls
* remove write-only variable AsciiOnly
* remove now unused string constants STRLANG, STRLC_CTYPE
* remove hardcoded support for ISO8859-1

ok millert@

unifdef BUILTIN (unused), NLS (always set), SHORT_STRINGS (always set)
and remove a few unused defines; no binary changes; ok tedu@ zhuk@

setlocale() before pledge()... until we learn more

With TIOCSTI supported in pledge "tty proc", csh is good enough to run
with pledge "stdio rpath wpath cpath fattr getpw proc exec tty". (Note
that ksh "emacs mode" is also a abus^Wconsumer of TIOCSTI, but we had
let that slide for a week since noone uses it...)

delete many more ptr_t casts

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Use reallocarray() and remove a few archaic memory allocation practices.
ok deraadt

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

do not name file descriptors fp, either

unused code and variables

spacing

de-register and ansify functions

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

bring in strlcpy and strlcat-like things for dealing with Char types,
this fixes at least 15 buffer overflows; some help from dhartmei.
Anyone want to go do the same in ksh, and help with some of the while
(*s++ = *p++) loops in here?

knf

spelling; moritz@jodeit.org

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

mark signal races, and remove junk

Use mkstemp(3) for here document (<<) temporary files instead of $$
Problem noted by proton@ENERGYMECH.NET

even better fix for importpath(); from christos@zoulas.com; millert@ ok

prevent core dumps when stderror() is called before reslab is initialized

NUL not NULL

spelling

make signal handlers errno safe

#if __STDC__ --> #ifdef __STDC__

tabify

Update from NetBSD (christos)
Quote all imported environment variables.

compile

Don't honor $HOME if >= MAXPATHLEN

update rcsid

branches: 1.1.1;
Initial revision

funopen(): change seekfn argument to use off_t, not fpos_t
On BSD, fpos_t is typedef'd to off_t but some systems use a struct.
This means fpos_t is not a portable function argument or return value.
Both FreeBSD and the Linux libbsd funopen() have switched to off_t
for this--we should too. From Joe Nelson. OK deraadt@

Fix multiple variable definitions to avoid errors with -fno-common.

ok millert@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Fix some minor issues found by coverity.

OK millert@ and miko@

blkfree() takes no action for NULL pointer so callers can avoid checking.

ok jca@

Passing NULL to free() is fine; from Michael W. Bombardieri.

Include hostname in shell prompts by default

With tmux, ssh and vmd, we tend to open shells on many different hosts
simultaneously and the default prompts '$ ' and '# ' for {,k}sh as well
as '% ' and '# ' for csh become dangerous: it's very easy to issue a
command on the wrong host.

This can easily be avoided by displaying the hostname in the prompt.
Everything beyond "hostname{$,#,%} " is going to be a matter of taste,
so we left it at that. If you use an FQDN, only the first part (the
output of 'hostname -s') will be printed.

requested by and ok deraadt; mostly positive feedback many
ok anton, brynet, bcallah and others

Fix pasting of long (>BUFSIZ) lines in csh with filec enabled. NUL-terminating
the input buffer instructs csh that the buffer contains a complete command. This
is wrong and should only happen when buffer is not full, otherwise more data has
to be read in order form a complete command.

While here, do not print the prompt again when the input exceeds the input
buffer and while inserting a line continuation (backslash).

Postpone printing of prompt if filec is enabled in csh. Any I/O should be
performed first when canonical mode has been disabled on the tty just like ksh
does. Discovered by the regress tests.

Joint work with bluhm@, ok deraadt@

Turn off the close-on-exec bit with fcntl() instead of ioctl().

Remove some now useless "#include <ioctl.h>" lines.

Inspired by & ok millert@

Replace ioctl(fd, FIOCLEX) with fcntl(fd, F_SETFD, FD_CLOEXEC)
No functional change. "I like the idea" from guenther@

Replace handrolled xfree() function by directly using free(3)

OK mmcc@

exit() after perror() for pledge failure. Perhaps this got introduced
as a test idiom, either when pledge was young or during the transition
to strings.... dunno

unifdef _PATH_*

miscellaneous cruft:
* remove lint
* unifdef S_IFLNK, S_ISFIFO, S_ISLNK, S_ISSOCK, O_APPEND
* remove 0, NOTUSED, notdef -- untouched since original import
* remove IIASA

remove the profiling and debugging ifdefs; ok zhuk@

Clean up cruft made visible by the NLS unifdefing:
* remove setlocale() calls
* remove write-only variable AsciiOnly
* remove now unused string constants STRLANG, STRLC_CTYPE
* remove hardcoded support for ISO8859-1

ok millert@

unifdef BUILTIN (unused), NLS (always set), SHORT_STRINGS (always set)
and remove a few unused defines; no binary changes; ok tedu@ zhuk@

setlocale() before pledge()... until we learn more

With TIOCSTI supported in pledge "tty proc", csh is good enough to run
with pledge "stdio rpath wpath cpath fattr getpw proc exec tty". (Note
that ksh "emacs mode" is also a abus^Wconsumer of TIOCSTI, but we had
let that slide for a week since noone uses it...)

delete many more ptr_t casts

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Use reallocarray() and remove a few archaic memory allocation practices.
ok deraadt

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

do not name file descriptors fp, either

unused code and variables

spacing

de-register and ansify functions

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

bring in strlcpy and strlcat-like things for dealing with Char types,
this fixes at least 15 buffer overflows; some help from dhartmei.
Anyone want to go do the same in ksh, and help with some of the while
(*s++ = *p++) loops in here?

knf

spelling; moritz@jodeit.org

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

mark signal races, and remove junk

Use mkstemp(3) for here document (<<) temporary files instead of $$
Problem noted by proton@ENERGYMECH.NET

even better fix for importpath(); from christos@zoulas.com; millert@ ok

prevent core dumps when stderror() is called before reslab is initialized

NUL not NULL

spelling

make signal handlers errno safe

#if __STDC__ --> #ifdef __STDC__

tabify

Update from NetBSD (christos)
Quote all imported environment variables.

compile

Don't honor $HOME if >= MAXPATHLEN

update rcsid

branches: 1.1.1;
Initial revision

Fix multiple variable definitions to avoid errors with -fno-common.

ok millert@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Fix some minor issues found by coverity.

OK millert@ and miko@

blkfree() takes no action for NULL pointer so callers can avoid checking.

ok jca@

Passing NULL to free() is fine; from Michael W. Bombardieri.

Include hostname in shell prompts by default

With tmux, ssh and vmd, we tend to open shells on many different hosts
simultaneously and the default prompts '$ ' and '# ' for {,k}sh as well
as '% ' and '# ' for csh become dangerous: it's very easy to issue a
command on the wrong host.

This can easily be avoided by displaying the hostname in the prompt.
Everything beyond "hostname{$,#,%} " is going to be a matter of taste,
so we left it at that. If you use an FQDN, only the first part (the
output of 'hostname -s') will be printed.

requested by and ok deraadt; mostly positive feedback many
ok anton, brynet, bcallah and others

Fix pasting of long (>BUFSIZ) lines in csh with filec enabled. NUL-terminating
the input buffer instructs csh that the buffer contains a complete command. This
is wrong and should only happen when buffer is not full, otherwise more data has
to be read in order form a complete command.

While here, do not print the prompt again when the input exceeds the input
buffer and while inserting a line continuation (backslash).

Postpone printing of prompt if filec is enabled in csh. Any I/O should be
performed first when canonical mode has been disabled on the tty just like ksh
does. Discovered by the regress tests.

Joint work with bluhm@, ok deraadt@

Turn off the close-on-exec bit with fcntl() instead of ioctl().

Remove some now useless "#include <ioctl.h>" lines.

Inspired by & ok millert@

Replace ioctl(fd, FIOCLEX) with fcntl(fd, F_SETFD, FD_CLOEXEC)
No functional change. "I like the idea" from guenther@

Replace handrolled xfree() function by directly using free(3)

OK mmcc@

exit() after perror() for pledge failure. Perhaps this got introduced
as a test idiom, either when pledge was young or during the transition
to strings.... dunno

unifdef _PATH_*

miscellaneous cruft:
* remove lint
* unifdef S_IFLNK, S_ISFIFO, S_ISLNK, S_ISSOCK, O_APPEND
* remove 0, NOTUSED, notdef -- untouched since original import
* remove IIASA

remove the profiling and debugging ifdefs; ok zhuk@

Clean up cruft made visible by the NLS unifdefing:
* remove setlocale() calls
* remove write-only variable AsciiOnly
* remove now unused string constants STRLANG, STRLC_CTYPE
* remove hardcoded support for ISO8859-1

ok millert@

unifdef BUILTIN (unused), NLS (always set), SHORT_STRINGS (always set)
and remove a few unused defines; no binary changes; ok tedu@ zhuk@

setlocale() before pledge()... until we learn more

With TIOCSTI supported in pledge "tty proc", csh is good enough to run
with pledge "stdio rpath wpath cpath fattr getpw proc exec tty". (Note
that ksh "emacs mode" is also a abus^Wconsumer of TIOCSTI, but we had
let that slide for a week since noone uses it...)

delete many more ptr_t casts

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Use reallocarray() and remove a few archaic memory allocation practices.
ok deraadt

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

do not name file descriptors fp, either

unused code and variables

spacing

de-register and ansify functions

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

bring in strlcpy and strlcat-like things for dealing with Char types,
this fixes at least 15 buffer overflows; some help from dhartmei.
Anyone want to go do the same in ksh, and help with some of the while
(*s++ = *p++) loops in here?

knf

spelling; moritz@jodeit.org

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

mark signal races, and remove junk

Use mkstemp(3) for here document (<<) temporary files instead of $$
Problem noted by proton@ENERGYMECH.NET

even better fix for importpath(); from christos@zoulas.com; millert@ ok

prevent core dumps when stderror() is called before reslab is initialized

NUL not NULL

spelling

make signal handlers errno safe

#if __STDC__ --> #ifdef __STDC__

tabify

Update from NetBSD (christos)
Quote all imported environment variables.

compile

Don't honor $HOME if >= MAXPATHLEN

update rcsid

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Fix some minor issues found by coverity.

OK millert@ and miko@

blkfree() takes no action for NULL pointer so callers can avoid checking.

ok jca@

Passing NULL to free() is fine; from Michael W. Bombardieri.

Include hostname in shell prompts by default

With tmux, ssh and vmd, we tend to open shells on many different hosts
simultaneously and the default prompts '$ ' and '# ' for {,k}sh as well
as '% ' and '# ' for csh become dangerous: it's very easy to issue a
command on the wrong host.

This can easily be avoided by displaying the hostname in the prompt.
Everything beyond "hostname{$,#,%} " is going to be a matter of taste,
so we left it at that. If you use an FQDN, only the first part (the
output of 'hostname -s') will be printed.

requested by and ok deraadt; mostly positive feedback many
ok anton, brynet, bcallah and others

Fix pasting of long (>BUFSIZ) lines in csh with filec enabled. NUL-terminating
the input buffer instructs csh that the buffer contains a complete command. This
is wrong and should only happen when buffer is not full, otherwise more data has
to be read in order form a complete command.

While here, do not print the prompt again when the input exceeds the input
buffer and while inserting a line continuation (backslash).

Postpone printing of prompt if filec is enabled in csh. Any I/O should be
performed first when canonical mode has been disabled on the tty just like ksh
does. Discovered by the regress tests.

Joint work with bluhm@, ok deraadt@

Turn off the close-on-exec bit with fcntl() instead of ioctl().

Remove some now useless "#include <ioctl.h>" lines.

Inspired by & ok millert@

Replace ioctl(fd, FIOCLEX) with fcntl(fd, F_SETFD, FD_CLOEXEC)
No functional change. "I like the idea" from guenther@

Replace handrolled xfree() function by directly using free(3)

OK mmcc@

exit() after perror() for pledge failure. Perhaps this got introduced
as a test idiom, either when pledge was young or during the transition
to strings.... dunno

unifdef _PATH_*

miscellaneous cruft:
* remove lint
* unifdef S_IFLNK, S_ISFIFO, S_ISLNK, S_ISSOCK, O_APPEND
* remove 0, NOTUSED, notdef -- untouched since original import
* remove IIASA

remove the profiling and debugging ifdefs; ok zhuk@

Clean up cruft made visible by the NLS unifdefing:
* remove setlocale() calls
* remove write-only variable AsciiOnly
* remove now unused string constants STRLANG, STRLC_CTYPE
* remove hardcoded support for ISO8859-1

ok millert@

unifdef BUILTIN (unused), NLS (always set), SHORT_STRINGS (always set)
and remove a few unused defines; no binary changes; ok tedu@ zhuk@

setlocale() before pledge()... until we learn more

With TIOCSTI supported in pledge "tty proc", csh is good enough to run
with pledge "stdio rpath wpath cpath fattr getpw proc exec tty". (Note
that ksh "emacs mode" is also a abus^Wconsumer of TIOCSTI, but we had
let that slide for a week since noone uses it...)

delete many more ptr_t casts

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Use reallocarray() and remove a few archaic memory allocation practices.
ok deraadt

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

do not name file descriptors fp, either

unused code and variables

spacing

de-register and ansify functions

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

bring in strlcpy and strlcat-like things for dealing with Char types,
this fixes at least 15 buffer overflows; some help from dhartmei.
Anyone want to go do the same in ksh, and help with some of the while
(*s++ = *p++) loops in here?

knf

spelling; moritz@jodeit.org

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

mark signal races, and remove junk

Use mkstemp(3) for here document (<<) temporary files instead of $$
Problem noted by proton@ENERGYMECH.NET

even better fix for importpath(); from christos@zoulas.com; millert@ ok

prevent core dumps when stderror() is called before reslab is initialized

NUL not NULL

spelling

make signal handlers errno safe

#if __STDC__ --> #ifdef __STDC__

tabify

Update from NetBSD (christos)
Quote all imported environment variables.

compile

Don't honor $HOME if >= MAXPATHLEN

update rcsid

branches: 1.1.1;
Initial revision

Fix some minor issues found by coverity.

OK millert@ and miko@

blkfree() takes no action for NULL pointer so callers can avoid checking.

ok jca@

Passing NULL to free() is fine; from Michael W. Bombardieri.

Include hostname in shell prompts by default

With tmux, ssh and vmd, we tend to open shells on many different hosts
simultaneously and the default prompts '$ ' and '# ' for {,k}sh as well
as '% ' and '# ' for csh become dangerous: it's very easy to issue a
command on the wrong host.

This can easily be avoided by displaying the hostname in the prompt.
Everything beyond "hostname{$,#,%} " is going to be a matter of taste,
so we left it at that. If you use an FQDN, only the first part (the
output of 'hostname -s') will be printed.

requested by and ok deraadt; mostly positive feedback many
ok anton, brynet, bcallah and others

Fix pasting of long (>BUFSIZ) lines in csh with filec enabled. NUL-terminating
the input buffer instructs csh that the buffer contains a complete command. This
is wrong and should only happen when buffer is not full, otherwise more data has
to be read in order form a complete command.

While here, do not print the prompt again when the input exceeds the input
buffer and while inserting a line continuation (backslash).

Postpone printing of prompt if filec is enabled in csh. Any I/O should be
performed first when canonical mode has been disabled on the tty just like ksh
does. Discovered by the regress tests.

Joint work with bluhm@, ok deraadt@

Turn off the close-on-exec bit with fcntl() instead of ioctl().

Remove some now useless "#include <ioctl.h>" lines.

Inspired by & ok millert@

Replace ioctl(fd, FIOCLEX) with fcntl(fd, F_SETFD, FD_CLOEXEC)
No functional change. "I like the idea" from guenther@

Replace handrolled xfree() function by directly using free(3)

OK mmcc@

exit() after perror() for pledge failure. Perhaps this got introduced
as a test idiom, either when pledge was young or during the transition
to strings.... dunno

unifdef _PATH_*

miscellaneous cruft:
* remove lint
* unifdef S_IFLNK, S_ISFIFO, S_ISLNK, S_ISSOCK, O_APPEND
* remove 0, NOTUSED, notdef -- untouched since original import
* remove IIASA

remove the profiling and debugging ifdefs; ok zhuk@

Clean up cruft made visible by the NLS unifdefing:
* remove setlocale() calls
* remove write-only variable AsciiOnly
* remove now unused string constants STRLANG, STRLC_CTYPE
* remove hardcoded support for ISO8859-1

ok millert@

unifdef BUILTIN (unused), NLS (always set), SHORT_STRINGS (always set)
and remove a few unused defines; no binary changes; ok tedu@ zhuk@

setlocale() before pledge()... until we learn more

With TIOCSTI supported in pledge "tty proc", csh is good enough to run
with pledge "stdio rpath wpath cpath fattr getpw proc exec tty". (Note
that ksh "emacs mode" is also a abus^Wconsumer of TIOCSTI, but we had
let that slide for a week since noone uses it...)

delete many more ptr_t casts

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Use reallocarray() and remove a few archaic memory allocation practices.
ok deraadt

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

do not name file descriptors fp, either

unused code and variables

spacing

de-register and ansify functions

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

bring in strlcpy and strlcat-like things for dealing with Char types,
this fixes at least 15 buffer overflows; some help from dhartmei.
Anyone want to go do the same in ksh, and help with some of the while
(*s++ = *p++) loops in here?

knf

spelling; moritz@jodeit.org

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

mark signal races, and remove junk

Use mkstemp(3) for here document (<<) temporary files instead of $$
Problem noted by proton@ENERGYMECH.NET

even better fix for importpath(); from christos@zoulas.com; millert@ ok

prevent core dumps when stderror() is called before reslab is initialized

NUL not NULL

spelling

make signal handlers errno safe

#if __STDC__ --> #ifdef __STDC__

tabify

Update from NetBSD (christos)
Quote all imported environment variables.

compile

Don't honor $HOME if >= MAXPATHLEN

update rcsid

branches: 1.1.1;
Initial revision

blkfree() takes no action for NULL pointer so callers can avoid checking.

ok jca@

Passing NULL to free() is fine; from Michael W. Bombardieri.

Include hostname in shell prompts by default

With tmux, ssh and vmd, we tend to open shells on many different hosts
simultaneously and the default prompts '$ ' and '# ' for {,k}sh as well
as '% ' and '# ' for csh become dangerous: it's very easy to issue a
command on the wrong host.

This can easily be avoided by displaying the hostname in the prompt.
Everything beyond "hostname{$,#,%} " is going to be a matter of taste,
so we left it at that. If you use an FQDN, only the first part (the
output of 'hostname -s') will be printed.

requested by and ok deraadt; mostly positive feedback many
ok anton, brynet, bcallah and others

Fix pasting of long (>BUFSIZ) lines in csh with filec enabled. NUL-terminating
the input buffer instructs csh that the buffer contains a complete command. This
is wrong and should only happen when buffer is not full, otherwise more data has
to be read in order form a complete command.

While here, do not print the prompt again when the input exceeds the input
buffer and while inserting a line continuation (backslash).

Postpone printing of prompt if filec is enabled in csh. Any I/O should be
performed first when canonical mode has been disabled on the tty just like ksh
does. Discovered by the regress tests.

Joint work with bluhm@, ok deraadt@

Turn off the close-on-exec bit with fcntl() instead of ioctl().

Remove some now useless "#include <ioctl.h>" lines.

Inspired by & ok millert@

Replace ioctl(fd, FIOCLEX) with fcntl(fd, F_SETFD, FD_CLOEXEC)
No functional change. "I like the idea" from guenther@

Replace handrolled xfree() function by directly using free(3)

OK mmcc@

exit() after perror() for pledge failure. Perhaps this got introduced
as a test idiom, either when pledge was young or during the transition
to strings.... dunno

unifdef _PATH_*

miscellaneous cruft:
* remove lint
* unifdef S_IFLNK, S_ISFIFO, S_ISLNK, S_ISSOCK, O_APPEND
* remove 0, NOTUSED, notdef -- untouched since original import
* remove IIASA

remove the profiling and debugging ifdefs; ok zhuk@

Clean up cruft made visible by the NLS unifdefing:
* remove setlocale() calls
* remove write-only variable AsciiOnly
* remove now unused string constants STRLANG, STRLC_CTYPE
* remove hardcoded support for ISO8859-1

ok millert@

unifdef BUILTIN (unused), NLS (always set), SHORT_STRINGS (always set)
and remove a few unused defines; no binary changes; ok tedu@ zhuk@

setlocale() before pledge()... until we learn more

With TIOCSTI supported in pledge "tty proc", csh is good enough to run
with pledge "stdio rpath wpath cpath fattr getpw proc exec tty". (Note
that ksh "emacs mode" is also a abus^Wconsumer of TIOCSTI, but we had
let that slide for a week since noone uses it...)

delete many more ptr_t casts

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Use reallocarray() and remove a few archaic memory allocation practices.
ok deraadt

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

do not name file descriptors fp, either

unused code and variables

spacing

de-register and ansify functions

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

bring in strlcpy and strlcat-like things for dealing with Char types,
this fixes at least 15 buffer overflows; some help from dhartmei.
Anyone want to go do the same in ksh, and help with some of the while
(*s++ = *p++) loops in here?

knf

spelling; moritz@jodeit.org

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

mark signal races, and remove junk

Use mkstemp(3) for here document (<<) temporary files instead of $$
Problem noted by proton@ENERGYMECH.NET

even better fix for importpath(); from christos@zoulas.com; millert@ ok

prevent core dumps when stderror() is called before reslab is initialized

NUL not NULL

spelling

make signal handlers errno safe

#if __STDC__ --> #ifdef __STDC__

tabify

Update from NetBSD (christos)
Quote all imported environment variables.

compile

Don't honor $HOME if >= MAXPATHLEN

update rcsid

branches: 1.1.1;
Initial revision

Passing NULL to free() is fine; from Michael W. Bombardieri.

Include hostname in shell prompts by default

With tmux, ssh and vmd, we tend to open shells on many different hosts
simultaneously and the default prompts '$ ' and '# ' for {,k}sh as well
as '% ' and '# ' for csh become dangerous: it's very easy to issue a
command on the wrong host.

This can easily be avoided by displaying the hostname in the prompt.
Everything beyond "hostname{$,#,%} " is going to be a matter of taste,
so we left it at that. If you use an FQDN, only the first part (the
output of 'hostname -s') will be printed.

requested by and ok deraadt; mostly positive feedback many
ok anton, brynet, bcallah and others

Fix pasting of long (>BUFSIZ) lines in csh with filec enabled. NUL-terminating
the input buffer instructs csh that the buffer contains a complete command. This
is wrong and should only happen when buffer is not full, otherwise more data has
to be read in order form a complete command.

While here, do not print the prompt again when the input exceeds the input
buffer and while inserting a line continuation (backslash).

Postpone printing of prompt if filec is enabled in csh. Any I/O should be
performed first when canonical mode has been disabled on the tty just like ksh
does. Discovered by the regress tests.

Joint work with bluhm@, ok deraadt@

Turn off the close-on-exec bit with fcntl() instead of ioctl().

Remove some now useless "#include <ioctl.h>" lines.

Inspired by & ok millert@

Replace ioctl(fd, FIOCLEX) with fcntl(fd, F_SETFD, FD_CLOEXEC)
No functional change. "I like the idea" from guenther@

Replace handrolled xfree() function by directly using free(3)

OK mmcc@

exit() after perror() for pledge failure. Perhaps this got introduced
as a test idiom, either when pledge was young or during the transition
to strings.... dunno

unifdef _PATH_*

miscellaneous cruft:
* remove lint
* unifdef S_IFLNK, S_ISFIFO, S_ISLNK, S_ISSOCK, O_APPEND
* remove 0, NOTUSED, notdef -- untouched since original import
* remove IIASA

remove the profiling and debugging ifdefs; ok zhuk@

Clean up cruft made visible by the NLS unifdefing:
* remove setlocale() calls
* remove write-only variable AsciiOnly
* remove now unused string constants STRLANG, STRLC_CTYPE
* remove hardcoded support for ISO8859-1

ok millert@

unifdef BUILTIN (unused), NLS (always set), SHORT_STRINGS (always set)
and remove a few unused defines; no binary changes; ok tedu@ zhuk@

setlocale() before pledge()... until we learn more

With TIOCSTI supported in pledge "tty proc", csh is good enough to run
with pledge "stdio rpath wpath cpath fattr getpw proc exec tty". (Note
that ksh "emacs mode" is also a abus^Wconsumer of TIOCSTI, but we had
let that slide for a week since noone uses it...)

delete many more ptr_t casts

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Use reallocarray() and remove a few archaic memory allocation practices.
ok deraadt

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

do not name file descriptors fp, either

unused code and variables

spacing

de-register and ansify functions

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

bring in strlcpy and strlcat-like things for dealing with Char types,
this fixes at least 15 buffer overflows; some help from dhartmei.
Anyone want to go do the same in ksh, and help with some of the while
(*s++ = *p++) loops in here?

knf

spelling; moritz@jodeit.org

We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

mark signal races, and remove junk

Use mkstemp(3) for here document (<<) temporary files instead of $$
Problem noted by proton@ENERGYMECH.NET

even better fix for importpath(); from christos@zoulas.com; millert@ ok

prevent core dumps when stderror() is called before reslab is initialized

NUL not NULL

spelling

make signal handlers errno safe

#if __STDC__ --> #ifdef __STDC__

tabify

Update from NetBSD (christos)
Quote all imported environment variables.

compile

Don't honor $HOME if >= MAXPATHLEN

update rcsid

branches: 1.1.1;
Initial revision