cat(1): drop "rpath" promise in no-file case

If we're only working with the standard input we don't need "rpath".

Tweaked by mestre@.

Thread: https://marc.info/?l=openbsd-tech&m=163941848104274&w=2

No objections on tech@ after several weeks.

cat(1): refactor cook_args()/raw_args() into single function, cat_file()

- Combine the open/close portions of cook_args()/raw_args() into a single
function, cat_file().

- Push the flag-checking conditional in main() down into cat_file().

- Pull the argv loop in cat_file() up into main().

These changes -- especially pulling the argv look up into main() --
will allow us to drop the "rpath" promise in a single spot in a
subsequent patch.

Tweaked by mestre@. Descriptor leak in earlier version spotted by
Matthew Martin.

Thread: https://marc.info/?l=openbsd-tech&m=163941848104274&w=2

No objections on tech@ after several weeks.

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

cat(1): -n flag: correctly enumerate files with more than INT_MAX lines

If we bump 'lines' from an int to an unsigned long long we can
trivially support files with more than INT_MAX lines.

ok millert@

cat(1): misc. style(9)

- Use getprogname(3) instead of __progname.
- Sprinkle in some missing braces.
- Prefer err(..., NULL) when malloc(3) fails.
- Remove an unnecessary cast to from ssize_t to size_t.

cat(1): simplify argv processing loops

cook_args() and raw_args() do some peculiar things in order to avoid
calling cook_buf() and raw_cat(), respectively, in more than one
place. The result is a convoluted. If we isolate the special cases
from the normal case and just call these functions in multiple places
the loops will be easier to read.

Three things:

1. Pull the no-args case out of the loop. If *argv is NULL when we
get into the argv processing function we just want to operate on
the standard input and return early. It makes no sense to handle
this case *in* the loop.

2. Isolate the "-" case from the filename case. If *argv is "-" we want
to operate on the standard input. We can then do any stdin-specific
cleanup within the same branch, which makes it easier to understand
both the "-" case and the normal filename case. This also allows us
to remove the 'filename' intermediate variable from both argv processing
functions.

3. While we're here, use a for-loop and iterate argv in the loop header.
Now argv is incremented in one place.

ok martijn@

cat(1): remove global 'filename' variable

There is no need for the global filename variable. Both cook_buf()
and raw_cat() can accept a filename variable from the caller to use
for printing warnings.

ok martijn@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Delete useless setlocale(3) in src/bin/.
Minor cleanup while here: return from main, static void __dead usage, etc.
Based on a patch from Jan Stary <hans at stare dot cz>.
Feedback and OK tb@, OK millert@.

For -be, indent the $ on blank lines.
Patch from Giles Lean (NetBSD PR bin/4841), tweaked by kleink at
NetBSD (rev. 1.17 1998-01-27), version for OpenBSD sent in by Sevan
Janiyan <venture37 at geeklan dot co dot uk>.
OK deraadt@

replace setbuf with setvbuf, from Frederic Nowak

Change all tame callers to namechange to pledge(2).

obvious tame "stdio rpath"
ok semarie

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

sync usage(); from Tobias Stoeckmann

Fix handling of multiple stdin arguments in cooked mode, closes PR 5418.
From Johan Veenhuizen

change incorrect filename in output on fstat() failure

from Cedric Berger <cedric@berger.to>

ok otto

minor cleanups / shut up lint, ok pedro tedu

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi

Fix 'cat -se'; the '$' was not being printed for blank lines.
Based on a patch from Denis Afonin.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

o) __progname aria;

millert@ ok.

remove extra externs not needed because of unistd.h (rest of tree will be done later.. contact me if you want to help)

(foo *)NULL -> NULL

-Wall'ing.

Back out last change, getopt on OpenBSD returns -1, not EOF

Fix the return value of test of getopt. It is documented to return
EOF when there are no more args to process. This happens also to be a
trivial difference between FreeBSD and OpenBSD which FreeBSD has
right. Shouldn't break anything because EOF is #defined to be -1 on
BSD systems.

Exit with status >0 if any error occured; from FreeBSD

zap getopt() case of -?, come on, it is the default!

update rcsid

branches: 1.1.1;
Initial revision

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert

cat(1): -n flag: correctly enumerate files with more than INT_MAX lines

If we bump 'lines' from an int to an unsigned long long we can
trivially support files with more than INT_MAX lines.

ok millert@

cat(1): misc. style(9)

- Use getprogname(3) instead of __progname.
- Sprinkle in some missing braces.
- Prefer err(..., NULL) when malloc(3) fails.
- Remove an unnecessary cast to from ssize_t to size_t.

cat(1): simplify argv processing loops

cook_args() and raw_args() do some peculiar things in order to avoid
calling cook_buf() and raw_cat(), respectively, in more than one
place. The result is a convoluted. If we isolate the special cases
from the normal case and just call these functions in multiple places
the loops will be easier to read.

Three things:

1. Pull the no-args case out of the loop. If *argv is NULL when we
get into the argv processing function we just want to operate on
the standard input and return early. It makes no sense to handle
this case *in* the loop.

2. Isolate the "-" case from the filename case. If *argv is "-" we want
to operate on the standard input. We can then do any stdin-specific
cleanup within the same branch, which makes it easier to understand
both the "-" case and the normal filename case. This also allows us
to remove the 'filename' intermediate variable from both argv processing
functions.

3. While we're here, use a for-loop and iterate argv in the loop header.
Now argv is incremented in one place.

ok martijn@

cat(1): remove global 'filename' variable

There is no need for the global filename variable. Both cook_buf()
and raw_cat() can accept a filename variable from the caller to use
for printing warnings.

ok martijn@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Delete useless setlocale(3) in src/bin/.
Minor cleanup while here: return from main, static void __dead usage, etc.
Based on a patch from Jan Stary <hans at stare dot cz>.
Feedback and OK tb@, OK millert@.

For -be, indent the $ on blank lines.
Patch from Giles Lean (NetBSD PR bin/4841), tweaked by kleink at
NetBSD (rev. 1.17 1998-01-27), version for OpenBSD sent in by Sevan
Janiyan <venture37 at geeklan dot co dot uk>.
OK deraadt@

replace setbuf with setvbuf, from Frederic Nowak

Change all tame callers to namechange to pledge(2).

obvious tame "stdio rpath"
ok semarie

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

sync usage(); from Tobias Stoeckmann

Fix handling of multiple stdin arguments in cooked mode, closes PR 5418.
From Johan Veenhuizen

change incorrect filename in output on fstat() failure

from Cedric Berger <cedric@berger.to>

ok otto

minor cleanups / shut up lint, ok pedro tedu

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi

Fix 'cat -se'; the '$' was not being printed for blank lines.
Based on a patch from Denis Afonin.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

o) __progname aria;

millert@ ok.

remove extra externs not needed because of unistd.h (rest of tree will be done later.. contact me if you want to help)

(foo *)NULL -> NULL

-Wall'ing.

Back out last change, getopt on OpenBSD returns -1, not EOF

Fix the return value of test of getopt. It is documented to return
EOF when there are no more args to process. This happens also to be a
trivial difference between FreeBSD and OpenBSD which FreeBSD has
right. Shouldn't break anything because EOF is #defined to be -1 on
BSD systems.

Exit with status >0 if any error occured; from FreeBSD

zap getopt() case of -?, come on, it is the default!

update rcsid

branches: 1.1.1;
Initial revision

cat(1): -n flag: correctly enumerate files with more than INT_MAX lines

If we bump 'lines' from an int to an unsigned long long we can
trivially support files with more than INT_MAX lines.

ok millert@

cat(1): misc. style(9)

- Use getprogname(3) instead of __progname.
- Sprinkle in some missing braces.
- Prefer err(..., NULL) when malloc(3) fails.
- Remove an unnecessary cast to from ssize_t to size_t.

cat(1): simplify argv processing loops

cook_args() and raw_args() do some peculiar things in order to avoid
calling cook_buf() and raw_cat(), respectively, in more than one
place. The result is a convoluted. If we isolate the special cases
from the normal case and just call these functions in multiple places
the loops will be easier to read.

Three things:

1. Pull the no-args case out of the loop. If *argv is NULL when we
get into the argv processing function we just want to operate on
the standard input and return early. It makes no sense to handle
this case *in* the loop.

2. Isolate the "-" case from the filename case. If *argv is "-" we want
to operate on the standard input. We can then do any stdin-specific
cleanup within the same branch, which makes it easier to understand
both the "-" case and the normal filename case. This also allows us
to remove the 'filename' intermediate variable from both argv processing
functions.

3. While we're here, use a for-loop and iterate argv in the loop header.
Now argv is incremented in one place.

ok martijn@

cat(1): remove global 'filename' variable

There is no need for the global filename variable. Both cook_buf()
and raw_cat() can accept a filename variable from the caller to use
for printing warnings.

ok martijn@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Delete useless setlocale(3) in src/bin/.
Minor cleanup while here: return from main, static void __dead usage, etc.
Based on a patch from Jan Stary <hans at stare dot cz>.
Feedback and OK tb@, OK millert@.

For -be, indent the $ on blank lines.
Patch from Giles Lean (NetBSD PR bin/4841), tweaked by kleink at
NetBSD (rev. 1.17 1998-01-27), version for OpenBSD sent in by Sevan
Janiyan <venture37 at geeklan dot co dot uk>.
OK deraadt@

replace setbuf with setvbuf, from Frederic Nowak

Change all tame callers to namechange to pledge(2).

obvious tame "stdio rpath"
ok semarie

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

sync usage(); from Tobias Stoeckmann

Fix handling of multiple stdin arguments in cooked mode, closes PR 5418.
From Johan Veenhuizen

change incorrect filename in output on fstat() failure

from Cedric Berger <cedric@berger.to>

ok otto

minor cleanups / shut up lint, ok pedro tedu

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi

Fix 'cat -se'; the '$' was not being printed for blank lines.
Based on a patch from Denis Afonin.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

o) __progname aria;

millert@ ok.

remove extra externs not needed because of unistd.h (rest of tree will be done later.. contact me if you want to help)

(foo *)NULL -> NULL

-Wall'ing.

Back out last change, getopt on OpenBSD returns -1, not EOF

Fix the return value of test of getopt. It is documented to return
EOF when there are no more args to process. This happens also to be a
trivial difference between FreeBSD and OpenBSD which FreeBSD has
right. Shouldn't break anything because EOF is #defined to be -1 on
BSD systems.

Exit with status >0 if any error occured; from FreeBSD

zap getopt() case of -?, come on, it is the default!

update rcsid

branches: 1.1.1;
Initial revision

cat(1): misc. style(9)

- Use getprogname(3) instead of __progname.
- Sprinkle in some missing braces.
- Prefer err(..., NULL) when malloc(3) fails.
- Remove an unnecessary cast to from ssize_t to size_t.

cat(1): simplify argv processing loops

cook_args() and raw_args() do some peculiar things in order to avoid
calling cook_buf() and raw_cat(), respectively, in more than one
place. The result is a convoluted. If we isolate the special cases
from the normal case and just call these functions in multiple places
the loops will be easier to read.

Three things:

1. Pull the no-args case out of the loop. If *argv is NULL when we
get into the argv processing function we just want to operate on
the standard input and return early. It makes no sense to handle
this case *in* the loop.

2. Isolate the "-" case from the filename case. If *argv is "-" we want
to operate on the standard input. We can then do any stdin-specific
cleanup within the same branch, which makes it easier to understand
both the "-" case and the normal filename case. This also allows us
to remove the 'filename' intermediate variable from both argv processing
functions.

3. While we're here, use a for-loop and iterate argv in the loop header.
Now argv is incremented in one place.

ok martijn@

cat(1): remove global 'filename' variable

There is no need for the global filename variable. Both cook_buf()
and raw_cat() can accept a filename variable from the caller to use
for printing warnings.

ok martijn@

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Delete useless setlocale(3) in src/bin/.
Minor cleanup while here: return from main, static void __dead usage, etc.
Based on a patch from Jan Stary <hans at stare dot cz>.
Feedback and OK tb@, OK millert@.

For -be, indent the $ on blank lines.
Patch from Giles Lean (NetBSD PR bin/4841), tweaked by kleink at
NetBSD (rev. 1.17 1998-01-27), version for OpenBSD sent in by Sevan
Janiyan <venture37 at geeklan dot co dot uk>.
OK deraadt@

replace setbuf with setvbuf, from Frederic Nowak

Change all tame callers to namechange to pledge(2).

obvious tame "stdio rpath"
ok semarie

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

sync usage(); from Tobias Stoeckmann

Fix handling of multiple stdin arguments in cooked mode, closes PR 5418.
From Johan Veenhuizen

change incorrect filename in output on fstat() failure

from Cedric Berger <cedric@berger.to>

ok otto

minor cleanups / shut up lint, ok pedro tedu

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi

Fix 'cat -se'; the '$' was not being printed for blank lines.
Based on a patch from Denis Afonin.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

o) __progname aria;

millert@ ok.

remove extra externs not needed because of unistd.h (rest of tree will be done later.. contact me if you want to help)

(foo *)NULL -> NULL

-Wall'ing.

Back out last change, getopt on OpenBSD returns -1, not EOF

Fix the return value of test of getopt. It is documented to return
EOF when there are no more args to process. This happens also to be a
trivial difference between FreeBSD and OpenBSD which FreeBSD has
right. Shouldn't break anything because EOF is #defined to be -1 on
BSD systems.

Exit with status >0 if any error occured; from FreeBSD

zap getopt() case of -?, come on, it is the default!

update rcsid

branches: 1.1.1;
Initial revision

When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Delete useless setlocale(3) in src/bin/.
Minor cleanup while here: return from main, static void __dead usage, etc.
Based on a patch from Jan Stary <hans at stare dot cz>.
Feedback and OK tb@, OK millert@.

For -be, indent the $ on blank lines.
Patch from Giles Lean (NetBSD PR bin/4841), tweaked by kleink at
NetBSD (rev. 1.17 1998-01-27), version for OpenBSD sent in by Sevan
Janiyan <venture37 at geeklan dot co dot uk>.
OK deraadt@

replace setbuf with setvbuf, from Frederic Nowak

Change all tame callers to namechange to pledge(2).

obvious tame "stdio rpath"
ok semarie

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

sync usage(); from Tobias Stoeckmann

Fix handling of multiple stdin arguments in cooked mode, closes PR 5418.
From Johan Veenhuizen

change incorrect filename in output on fstat() failure

from Cedric Berger <cedric@berger.to>

ok otto

minor cleanups / shut up lint, ok pedro tedu

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi

Fix 'cat -se'; the '$' was not being printed for blank lines.
Based on a patch from Denis Afonin.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

o) __progname aria;

millert@ ok.

remove extra externs not needed because of unistd.h (rest of tree will be done later.. contact me if you want to help)

(foo *)NULL -> NULL

-Wall'ing.

Back out last change, getopt on OpenBSD returns -1, not EOF

Fix the return value of test of getopt. It is documented to return
EOF when there are no more args to process. This happens also to be a
trivial difference between FreeBSD and OpenBSD which FreeBSD has
right. Shouldn't break anything because EOF is #defined to be -1 on
BSD systems.

Exit with status >0 if any error occured; from FreeBSD

zap getopt() case of -?, come on, it is the default!

update rcsid

branches: 1.1.1;
Initial revision

Delete useless setlocale(3) in src/bin/.
Minor cleanup while here: return from main, static void __dead usage, etc.
Based on a patch from Jan Stary <hans at stare dot cz>.
Feedback and OK tb@, OK millert@.

For -be, indent the $ on blank lines.
Patch from Giles Lean (NetBSD PR bin/4841), tweaked by kleink at
NetBSD (rev. 1.17 1998-01-27), version for OpenBSD sent in by Sevan
Janiyan <venture37 at geeklan dot co dot uk>.
OK deraadt@

replace setbuf with setvbuf, from Frederic Nowak

Change all tame callers to namechange to pledge(2).

obvious tame "stdio rpath"
ok semarie

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

sync usage(); from Tobias Stoeckmann

Fix handling of multiple stdin arguments in cooked mode, closes PR 5418.
From Johan Veenhuizen

change incorrect filename in output on fstat() failure

from Cedric Berger <cedric@berger.to>

ok otto

minor cleanups / shut up lint, ok pedro tedu

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999. Proofed by myself and Theo.

ansi

Fix 'cat -se'; the '$' was not being printed for blank lines.
Based on a patch from Denis Afonin.

Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.

kill more registers;

millert@ ok

o) __progname aria;

millert@ ok.

remove extra externs not needed because of unistd.h (rest of tree will be done later.. contact me if you want to help)

(foo *)NULL -> NULL

-Wall'ing.

Back out last change, getopt on OpenBSD returns -1, not EOF

Fix the return value of test of getopt. It is documented to return
EOF when there are no more args to process. This happens also to be a
trivial difference between FreeBSD and OpenBSD which FreeBSD has
right. Shouldn't break anything because EOF is #defined to be -1 on
BSD systems.

Exit with status >0 if any error occured; from FreeBSD

zap getopt() case of -?, come on, it is the default!

update rcsid

branches: 1.1.1;
Initial revision