lint: add wrapper for <ctype.h> functions, for strict bool mode

When using the Clang preprocessor (with MKLLVM=yes), the preprocessor
output does not indicate which tokens come from a system header and
which tokens come from the user code. Lint's strict bool mode relies on
this information to treat the character classification functions from
<ctype.h> as if their return type were bool instead of int.

These wrapper functions are only used when their argument is indeed a
'char', but not when the argument might be 'EOF or representable as an
unsigned char', such as when reading a byte from the input.

lint: don't call memcpy with null pointer

Even copying 0 bytes from a null pointer invokes undefined behavior.

lint: move code for parsing balanced token sequences to lex.c

To access yytext from lex.c, the lexer needs to be in %pointer mode,
which was specified in IEEE Std 1003.1, 2004 Edition and thus should be
old enough to be available on platforms other than NetBSD, for use in
tools/lint1 where lint1 is built before yacc and lex.

lint: in C23 mode, support the nullptr constant

lint: in C23 mode, support the keywords 'bool', 'false' and 'true'

lint: clean up

lint: clean up string parsing and snprintb check

lint: remove custom wrappers around <ctype.h> functions

lint: fix misleading initializer for string iterator

The field 'start' marks the start of the previous matching character,
not the current iterator position.

No binary change.

lint: fix type error in strict bool mode (since yesterday)

lint1: remove redundant type table for integer constant suffixes

lint: clean up variable names, parameter order, comments

No functional change.

lint: clean up redundant braces

No functional change.

lint: use consistent variable names, reduce code for reading a byte

No functional change.

lint: unify rules for determining the type of an integer constant

Previously, in traditional C mode, large decimal numbers were treated as
unsigned, which disagreed with the book from 1978.

lint: warn about short octal escape followed by '8' or '9'

These mistakes is typically found in snprintb format directives but is
probably a typo everywhere else as well.

lint: keep strings in their source representation

This allows further analysis depending on whether individual characters are
escaped as octal, hexadecimal or not at all.

lint: allow hexadecimal character escapes up to UINT_MAX

Previously, any value larger than INT_MAX was regarded as negative and
thus terminated the loop around get_escaped_char.

lint: clean up comments, reduce scope of variables

lint: remove unused code for converting multibyte character sequences

lint: allow larger numbers in escapes for wide characters and strings

lint: make newline in a string literal an error in C90 and later

lint: reuse buffer editing code across lint1

Fix cat_strings to update the capacity of the buffer, to prevent
quadratic runtime when concatenating string literals.

lint: use standard buffer for storing string values

No functional change.

lint: do not remember content of wide string literals

The plain char literals are needed for checking printf/scanf format
strings; lint has no similar check for wide strings. These format
strings are checked by modern compilers, making this check less
relevant.

lint: fix type of large integer constants

lint: split determining the type of an integer constant

No functional change.

lint: extract signedness detection from lexing an integer constant

An integer constant that is signed in traditional C but unsigned since
C90 is an edge case that should not clutter the main code of determining
the resulting type of the constant.

The code for lexing an integer constant doesn't implement the C99 rules
yet, which convert a constant to the 'long long' types if the 'long'
types don't suffice.

lint: rename symt_t to symbol_kind

It was confusing to have two kinds of "symbol type" (s_type and s_symt),
so rename all related identifiers to be more distinctive.

No functional change.

lint: allow '\e' only in GCC mode

add \e

lint: allow querying for invisible characters in literals and constants

lint: in declarations, replace tab with space

Previously, in some cases, the keywords 'const' or 'struct' were
followed by a tab, which doesn't make sense.

No functional change.

lint: re-wrap comments

No functional change.

lint: indent statement continuations consistently

No binary change.

lint: rename NOSCL to NO_SCL

For symmetry with NO_TSPEC. No functional change.

lint: make diagnostics about ANSI C more international

lint: clean up lexing of preprocessing lines

The relation between 'c' and 'cp' was tricky to follow.

No functional change.

lint: improve debug logging for declarators

lint: in debug mode, default to indenting the debug log

Only the 'parsing' lines are not indented, as line breaks are
independent from the structure of the code.

lint: add detailed logging for finding memory allocation bugs

lint: add debug logging for memory management and the symbol table

lint: document which keywords are available in which language levels

lint: use separate types for parsing pointer types and type qualifiers

The documentation of the previous 'qual_ptr_t' was misleading, as that
type was used for other type qualifier lists as well, even if these were
not related to pointer types.

lint: in C23 mode, recognize the keyword 'thread_local'

lint: _Thread_local is a storage class, not a type qualifier

lint: indent copyright lines consistently

lint: clean up reading lint comments

lint: reduce code size for handling lint comments

lint: clean up code related to lint comments

Remove type information from variable names, as the word 'flag' did not
indicate that the variables were negated.

Remove contradicting comments. Suppressing a warning for 'this line',
'this and the following line' and 'this statement or declaration' cannot
all be accurate at the same time.

lint: reduce runtime relocations

lint: reject _Noreturn if it occurs in invalid places

C11 introduced _Noreturn as a function-specifier, not as a type
attribute. The latter may occur in more places.

lint: don't treat 'inline' as a storage class

The additional conflict in the grammar is in the same place as the other
conflicts, as T_SCLASS and T_FUNCTION_SPECIFIER are now separate tokens.

No functional change.

lint: condense keyword table

This prepares for modelling 'inline' not as a storage class, but more
correctly as a function specifier.

lint: add debug logging for symbol kinds in the parser

An identifier can refer to a variable, type, member, tag or label.
Switching between these namespaces is tightly coupled with the
evaluation order of the grammar rules.

lint: clean up wchar_t and hash tables

lint: miscellaneous cleanup

lint: clean up wording in diagnostics

Use the term 'parameter' as defined in C99 3.15.

lint: clean up the wording of a few diagnostics

lint: fix handling of 'long double' in cross-compiled mode

When lint is compiled on x86-64 (where 'long double' has a 64-bit
mantissa) and targets arm (where 'long double' has a 53-bit mantissa),
warn if a constant cannot fit in the 'long double' of the target
platform, not of the host platform.

lint: clean up redundant casts

lint: rename uppercase QUAD to LLONG

No binary change.

lint: rename 'quad' to 'signed int' or 'unsigned int'

No functional change.

lint: extend debug logging for declaration levels

Indent the debug logging according to the declaration level.

Since there are a few cases where the enclosing declaration levels are
modified, log the whole declaration level stack whenever a level begins
or ends.

lint: clean up names related to declaration levels

The previous prefix 'DK_' (declaration level kind) had a conflict with
the 'DK_' (designator kind) in init.c, so change the prefix to 'DLK_'.
The new name for dinfo_t is decl_level, which is more expressive.

No functional change.

lint: replace macro for unique identifiers with function

No functional change.

lint: clean up member names of declaration levels

No functional change outside debug mode.

lint: add query for comparing 'char' with plain integers

lint: miscellaneous clean-ups

No binary change, except for line numbers in assertions.

lint: indent local variables consistently

No binary change.

lint: don't wrongly warn about overflow in complex constants

Seen in lib/libm.

lint: reduce clutter in parsing preprocessor lines

No functional change.

lint: fix duplicate warning when parsing big float constants

lint: allow querying for octal integer constants

lint: do not warn about traditional C migration in C99 mode

For large integer constants, the resulting type could differ between
traditional C and C90. In C99 mode, this difference is no longer
relevant since it is too far away from traditional C.

tests/lint: fix and extend tests for C90 migration warning

lint: remove dead code from lex_floating_constant

Neither traditional C nor C11 allows a trailing 'd' or 'D' on floating
point constants. Java does, but lint does not cover Java programs.

lint: reduce scope of local variables

No functional change.

lint: use strtold for parsing floating constants

Supported since C99.

lint: remove compat code for lexing hex floating point literals

Hex floating literals are required by C99.

lint: clean up

In symtab_search, most of the conditions were redundant, so remove them.

In read_byte, using CHAR_MASK was conceptually wrong, as that constant
is from the target platform while the lexical analysis happens on the
host platform. It was unnecessary as well, as a hypothetical host
platform with 36-bit chars might encode the characters from the basic
source character set as numbers higher than 0x0_0000_00ff. Since lint
assumes that both the source character set as well as the execution
character set are the same and based on 8-bit bytes, nothing changes.

No functional change.

lint: inline an expression, clean up comments

No functional change.

lint: clean up the lexer

No functional change.

lint: prevent undefined behavior for signed '<<'

Found by manual code inspection, verified by MKSANITIZER=yes
USE_SANITIZER=undefined.

lint: use more expressive variable names in lexer

The name 't' could easily be mistaken to mean a tspec_t.

No functional change.

lint: reduce clutter in lexer

No functional change.

lint: add support for C11 '_Atomic' as atomic-type-specifier

Following the C11 grammar, the keyword '_Atomic' needs to be a separate
syntactic category, to avoid further conflicts in the grammar.

The two newly added conflicts in the grammar would come into play when
mixing traditional C with C11, in a type name without an implicit 'int'.
If the type '_Atomic(int)*' were parsed as '_Atomic int(int)*', the
trailing '*' would be a syntax error.

lint: add support for the C11 type qualifier '_Atomic'

That keyword can be used as a type specifier as well, support for that
will be added later.

lint: use simpler integers for parsing hex escapes

No functional change.

lint: use longer variable names, don't count digits in hex escapes

No functional change.

lint: eliminate forward declaration for get_escaped_char

No functional change.

lint: extract reading of escaped character constants

No functional change.

lint: extract parsing character escapes into separate functions

No functional change.

lint: document how reading tokens from the input works

Rename inpc to read_byte, to make the name more expressive. Since C99,
lint is no longer required to use overly short identifiers.

No functional change.

lint: miscellaneous cleanup

No functional change.

lint: remove explicit list of known GCC attributes

Most GCC attributes consist of a single identifier. Up to now, it was
necessary to list each of these identifiers in the grammar, even those
that only apply to a single target architecture.

Instead, parse the general form of attributes, matching the few
attributes that lint handles by name instead. While here, rename the
grammar rules to use the GCC terms.

To avoid conflicts between the global function 'printf' and the GCC
attribute of the same name, do not add GCC attributes to the symbol
table, and don't make these symbols 'extern' either.

ok christos@.

lint: make definition of type keywords simpler

The only type keyword that is available in more than one variant is
'signed', which can also be written '__signed'. Neither of the type
keywords is declared as being specific to GCC, even though __int128_t
and __uint128_t actually are non-standard.

No binary change.

lint: use __RCSID in lint mode as well

Since 1995-10-02, lint supports __asm statements and __asm modifiers.

No binary change.

lint: fix support for __alignof__, add support for __alignof

Broken since lex.c 1.129 from yesterday.

gcc also allows __alignof

lint: inline macro 'sflag'

Mark all places where lint's C90 mode is stricter than its C99 mode.

Most of the situations in which lint produces only warnings instead of
errors covered by the "Constraints" sections in the relevant standards.
This doesn't prevent a specific compiler from accepting it though.

No functional change.

lint: inline macro 'tflag'

The definition of the macro tested both allow_trad and allow_c90, but
there is only a single mode in which allow_c90 is false, therefore it
suffices to test only that.

While double-checking each occurrence of tflag individually, I learned
why lint performs lookups of struct members only by name, independently
of the struct in which they are declared. See typeok_arrow for details.

No functional change.

lint: document why in GCC mode, C99 keywords are enabled

lint: document why C11 keywords are available in C99 mode as well

lint: move GCC attributes to the bottom of the list

These identifiers have a simpler definition than the other keywords
since they do not define when they were introduced.

No functional change.

lint: remove null marker from keyword table

No functional change.

lint: prepare keyword table for C11

The C11 keywords had been listed as being C99 keywords. Instead of
initializing the individual fields separately, merge them by specifying
the year of the standard in which they appeared.

No binary change, except for line numbers in assertions.

lint: migrate gflag to allow_gcc

No functional change.

lint: clean up keyword definitions for the lexer

There is only one specialized keyword that is also a GCC attribute, it's
"section". All other keywords passed 0 in that macro argument.

No binary change.

lint: fix lint warning on platforms where size_t == unsigned int

lex.c(1451): warning: argument #1 is converted from 'int' to
'unsigned int' due to prototype [259]

A more thorough fix would be to change the type of block_level from int
to size_t, to match mem_block_level, but that change would generate
further signedness warnings because the type of sym_t.s_block_level
would have to be changed from int to size_t as well, but some symbols
have s_block_level == -1, so that's a larger and more error-prone
change. Leave that for later.

Whether message 259 makes sense at all in C99 mode is an entirely
different question that needs to be answered separately.

No functional change.

lint: distinguish between storage class and declaration kind

These types overlap but are not the same.

No functional change.

lint: disambiguate sym_t.s_value

Having a single variable for 4 different purposes with different types
makes the code unnecessarily hard to follow.

No functional change.

lint: inline member access macros for sym_t

Having the 'u.' explicitly in the code serves as a reminder that these
members are only defined under certain conditions.

No functional change.

lint: rename dinfo_t.d_next to d_enclosing

The name d_next gave the wrong impression that the declaration infos
would be independent of each other, but they are nested.

No functional change.

lint: add debug logging for the declaration stack

To track down the wrong edge cases in decl_direct_abstract.c.

lint: clean up comments, explain assertion in inssym

lint: use an unsigned counter for temporary variable names

No functional change.

lint: improve debug logging for the symbol table

Only print the heading for the symbol table level if there is actually a
symbol on that level.

Ensure that no symbol with block level -1 is ever in the symbol table
(see rmsym).

lint: fix off-by-one error in symbol table

No functional change since the error was in the "safe" direction.

lint: rename function 'cleanup' to be more expressive

No functional change.

lint: remove redundant assignments to string buffer length

No functional change.

lint: add debug logging for symbols and the symbol table

This logging is not active by default, the functions debug_sym and
debug_symtab can be called as needed during a debug session.

lint: constify lexer keywords

No functional change.

lint: reorganize lexer functions

Move the keywords table to the top, reduce forward declarations.

No functional change.

lint: group symbol table functions

No functional change.

lint: merge duplicate code for handling plain and wide strings

No functional change. As before, the string literals "1" "2" "3" are
not concatenated from left to right, instead concatenation starts with
"23" and then proceeds to "123".

lint: unabbreviate some fields in sym_t

No functional change.

lint: encode lifetime of allocated memory in the function names

No functional change.

lint: clean up memory management for string buffers

There is no reason to duplicate all the work that is already done by the
memory allocator.

No functional change.

lint: clean up memory allocation

No functional change.

lint: improve debug logging for symbol kinds

Add clang's optnone attribute.

lint: don't try to trick mathematics by defining ZERO to a nonzero value

No binary change.

lint: remove redundant EOF tests in lexer

No functional change.

lint: clean up lex.c

Rename 'struct kwtab' to 'struct keyword' since a single keyword is not
a whole keyword table.

Sync comment for lex_name with reality: sbuf_t no longer contains the
hash value.

Remove redundant tests for EOF, as EOF is neither a space nor a digit
nor an xdigit.

No functional change.

lint: remove spaces around bit-field colon

As seen in /usr/share/misc/style.

No binary change.

lint: rename C89 to C90 in variable names

No binary change.

lint: use C90 instead of C89 when referring to the C standard

Add more attributes

Improve restrict handling.

Add target attribute

lint: finish renaming of fcon to lex_floating_constant

lint: rename attron to in_gcc_attribute

No functional change.

lint: move all declarations above statements

All code that is used by src/tools is supposed to be compatible with C90.

No functional change.

use isfinite(3) instead of finite(3) for portability

Fixes tools build on macOS 11.6 arm64 hosts.

Extra commit to fix the actual wrong comment before:
Add _Static_assert grammar and keyword

remove the lint kludges

lint: fix lint warnings

lint: allow 'fallthrough' as alternative spelling of FALLTHROUGH

Seen in unbound/lookup3.c.

No change to the documentation since the canonical spelling is still the
same.

lint: accept keyword variant FALL THROUGH as alias to FALLTHROUGH

Seen in archive_string.c, macro WRITE_UC.

No documentation change since the canonical spelling of this keyword
stays the same.

lint: clean up hash functions

No functional change.

lint: remove unreachable code for parsing integer constants

The largest possible type of an integer constant is 'unsigned long
long'. Any larger type can only be expressed using casts.

See also https://gcc.gnu.org/onlinedocs/gcc/_005f_005fint128.html.

lint: fold constants in hash functions

All platforms supported by lint have sizeof(unsigned int) == 4 and
CHAR_BIT == 8. There is no need to encode these expressions in a hash
function, they only made the code harder to read.

No functional change.

lint: replace obsolete strtouq with equivalent strtoull

lint: fix lexing of character constants

The final value of the character constant must be determined by the
target platform, not the host platform.

This allows to run the tests for a target platform with different
signedness of characters, by editing targparam.h and t_integration.

Lint is not completely cross-compileable though. 64-bit host platforms
can run lint for 32-bit platforms, but not vice versa, since 32-bit GCC
does not provide 128-bit integer types.

lint: explicitly ignore return value of some function calls

This fixes the warning from lint2 that these functions return values
which are sometimes ignored.

The remaining calls to fprintf that ignore the return value come from
scan.c. Lint does not currently detect the auto-generated portions of
that file and the interesting ones since it assumes that scan.c is the
main filename, see expr_zalloc_tnode.

No functional change.

lint: use 'unsigned int' for bit-size of types in convert_integer

There was no need to have two separate magic values (0 and -1) to mean
the same.

No functional change.

lint: un-abbreviate unsigned integer types

No functional change.

lint: add __attribute__ regparm

Seen in libexec/ld.elf_so/rtld.h.

lint: inline msb

This reduces the binary size on x86_64 by about 500 bytes.

No functional change.

lint: remove unnecessary width parameter for msb

No functional change.

lint: use unsigned integers for storing hash values

The computation of the hash values is unchanged, only the resulting
value (which is always less than 1009 anyway, see HSHSIZ2) is stored as
unsigned as well.

No functional change.

lint: save some memory

Before lint1.h 1.47 from 2021-01-02, adjacent bit-field struct members
shared storage. Restore that using smaller types.

No functional change.

lint: change return type of 'msb' from int to bool

No functional change.

lint: clean up lex_integer_constant

When lexing an integer constant, it does not make sense to check for
'struct', 'void' or other types. Furthermore, the constants were listed
in some random-looking order, which made the code hard to read.

Add returns_nonnull attribute

lint: remove hash value from symbol buffer

Conceptually, a symbol buffer does not need to remember its hash value
since that belongs to the symbol table. This makes the code for the
symbol table simpler. The number of hash calculations increases by
about 5%, which is negligible.

No functional change.

lint: merge duplicate code for removing a symbol from the table

No functional change.

lint: extract duplicate code for modifying the symbol table

No functional change.

lint: add debug logging for symbol table, clean up debug logging

When I tried to fix msg_115, I quickly ran into a segmentation fault,
probably related to the symbol table. To better understand this part,
log insertions and deletions.

The other debug log messages do not need to mention the current file
position anymore, this is what lex_next_line takes care of since scan.l
1.113 from 2021-01-05.

lint: clean up debug logging

The calls to debug_step, unlike printf, don't need a trailing newline.

Remove the debug_step0 macro and its relatives since lint already uses
enough other features from C99 that it essentially requires this
standard, which supports varargs macro arguments. Among these features
are __func__ and printf("%zu").

In non-debug mode, do not evaluate the arguments of debug_step.
Evaluating the arguments had caused an internal error when running the
test op_shl_lp64. This is indeed a bug since initdecl should have
initialized the type table for __uint128_t. This had been forgotten
when support for __uint128_t was added in decl.c 1.69 from 2018-09-07.

No functional change.

lint: reduce indentation in 'search'

No functional change.

lint: write canonical form of keywords

For keywords that have a single spelling variant (such as __packed),
write this form in the source, to make it searchable. This also avoids
a few calls to malloc.

Previously, some keywords had leading underscores and some hadn't, this
was inconsistent.

No functional change.

lint: support __attribute__((hot))

The corresponding attribute 'cold' was already added in cgram.y 1.84
from 2016-12-29.

lint: rename y_sb to y_name

That buffer is only used for names of identifiers, so be more specific.

No functional change.

lint: remove double negation in comment

No functional change.

lint: constify keyword in lexer

No functional change.

lint: __real__ and __imag__ are GNU extensions

https://gcc.gnu.org/onlinedocs/gcc/Complex.html

lint: inline 'sign' into convert_integer

No functional change.

lint: rename xsign to convert_integer

The term sign-extend was too specific, the function actually does a
broader conversion.

No functional change.

lint: clean up lex_character_constant

No functional change.

lint: fix lexical analysis of character constants in traditional C

The code now follows the wording of the C Reference Manual from 1978.

lint: rename val_t.v_unsigned to avoid confusion

The name v_unsigned suggested that the value would be interpreted as
unsigned, which was wrong. Whether a value is signed or unsigned is
decided by v_tspec instead.

Revert the previous commit for boolen constants since their value is
already interpreted as unsigned, and there is no need for any warning
about differences between traditional C and ANSI C since the _Bool type
has only been added ten years later in C99.

The code for printing a tree node was also confused by this struct
member, even with its old name v_ansiu. That code will be fixed in a
follow-up commit.

No functional change.

lint: rename val_t.v_ansiu to v_unsigned

When lint was written in 1995, traditional C was still nearby since C90
had been around for only 5 years. 26 years later, almost all code
adheres to C90 or even C99 or C11, therefore "C90 or later" can safely
be assumed as the default.

No functional change.

lint: fix confusing variable name in lex_wide_character_constant

By convention, i is an index, not a count.

No functional change.

lint: reduce indentation in lexer for character constants

No functional change.

lint: fix check for empty wide character constant

This bug got almost 26 years old, it was already there at the initial
commit in 1995.

lint: fix endless loop on unfinished comment at EOF

Found using afl.

lint: fix endless loop when scanning string or character literals

If the code contains an unfinished string or character literal at the
EOF, the lexer got into an endless loop. Curiously, inpc() returned 0
in such a case instead of the common EOF.

Found by making lint1 with CC=afl-gcc and then running:

afl-fuzz \
-m 200 \
-i in_dir \
-o lint1 \
$src/usr.bin/xlint/lint1/lint1 @@ /dev/null

lint: revert fix for endless loop in lexer for string literals

String literals may contain null bytes, and these must be passed further
on.

This reintroduces the endless loop in the lexer, but that must be fixed
in another way that doesn't destroy the error handling.

lint: fix hang on unfinished string literal at end-of-file

The input file that triggered this bug was:

a"b"c"d

Found using afl.

lint: replace array access with function calls

First and foremost, the test d_c99_complex_split accessed the array
qlmasks out-of-bounds, with an index of 128 for the type 'double
_Complex'. This invoked undefined behavior since the maximum allowed
index was 64.

Replacing the raw array accesses with function calls allows for bounds
checks to catch these errors early.

Determining the value bits for a 'double _Complex' does not make sense
at all since it is not an integer type. This means that lint didn't
handle these types correctly for several years. Support for int128_t
has been added in inittyp.c 1.12 from 2018-09-07, support for _Complex
has been added in inittyp.c 1.9 from 2008-04-26.

Determining the value bits for an int128_t would make sense, but the
unit tests don't contain examples for this type since at the moment all
unit tests must produce the same results on 32-bit and 64-bit platforms,
and the 32-bit platforms don't support int128_t.

lint: undefine macros for defining keywords after use

No functional change.

lint: remove redundancy when defining classic keywords

No functional change.

lint: reduce redundancy when defining GCC attributes

This macro would have prevented the unintended inconsistency in the
attribute 'pcs' (for ARM).

No functional change. The generated code is the same, except for the
line numbers in lint_assert.

lint: allow variables to be named 'pcs'

lint: fix compiler warning about signedness mismatch

No functional change.

put back nonnull. I meant to just sort it.

- add nonstring attribute
- allow attributes after labels (for unused)
XXX: split the attributes into function, variable, etc attributes
so that we don't accept all attributes in all places (only where they make
sense)

Add common attribute

lint: fix storage class of compound literal in initializer

A compound literal that occurs at block_level 0 does not have storage
class AUTO. Instead, its storage class is either EXTERN or STATIC.

While removing the temporary objects from the symbol table had prevented
the assertion, it did not properly fix the underlying problem, which was
that since C99 the initializers can contain references to unnamed
objects that are created on-the-fly. For C90 it was correct to always
use AUTO as the storage class of a temporary symbol.

Add attribute fallthrough

lint: clean up handling of preprocessing output lines

No functional change.

lint: in code from included files, print stack trace

Previously, the standard NetBSD build generated several lint warnings in
lhash.h from OpenSSL, without providing any hint as to which file
actually included that header. In cases like these, lint now interprets
the line number information in the preprocessor output from GCC to
reconstruct the exact include path to the file in question.

The program check-expect.lua had to be rewritten almost completely since
it assumed that all diagnostics would come from the main file. In all
existing tests, this was true, but these tests did not cover all cases
that occurred in practice. Now it records the complete location of the
diagnostic instead of just the line number.

lint: sync comment with reality after renaming several functions

No functional change.

lint: reduce memory usage

No functional change.

lint: add parentheses after sizeof, as required by share/misc/style

No functional change.

lint: sprinkle const on function declarations

No functional change.

lint: rename LERROR to INTERNAL_ERROR

The '#ifndef' in tyname.c is meant to distinguish between lint1 and
lint2, it is not meant to be defined from anywhere outside the lint code
itself.

No functional change.

lint: rename filename management functions

No functional change.

lint: remove space between 'sizeof ('

No functional change.

lint: in malloc calls, use 'sizeof *ptr' instead of 'sizeof(type)'

No functional change.

Add _Alignas()

lint: rename functions for handling control statements

No functional change.

lint: make lint's own code pass the strict bool mode

No functional change.

lint: use macro for initializing keywords table

Since today, lint's strict bool mode requires initializers to have the
correct type. The flags in kwtab are of type bool and were initialized
with an int, for brevity. Keep the brevity and do the conversion from
int to bool in a macro.

By defining several macros for the different kinds of keywords, reduce
the clutter of having 2 additional zeroes per line. The macros also
remove the redundancy and thereby the possible inconsistency of filling
the wrong fields since these depend on the token type.

No functional change. The only change to the binary is due to the
changed line numbers in the calls to lint_assert.

lint: rename 'blklev' to 'block_level'

No functional change.

lint: only warn once about integer constant overflow on 32-bit

Previously, the test msg_056.c warned twice about the integer literal,
but only on 32-bit platforms. On 64-bit platforms, there was only a
single warning since the integer constant was converted to type
__uint128_t, and this prevented the second warning. On 32-bit targets,
there is no __uint128_t though.

Fixes part of PR bin/55976.

lint: rename members and access macros of the basic types

Having the measurement unit in the variable name prevents accidental
confusion between bits and bytes, especially since usually the word
'size' means the size in bytes, while 'width' means the size in bits, at
least for integer types.

No functional change.

lint: change spelling of initialisation to initialization

That's the wording from the ISO C99 standard.

lint: make parsing of GCC line directives stricter

The previous code accepted '# 123 "file.c" 23' as specifying a system
header, just because that number ends with '3'. The original intention
was to compare the complete word, not its suffix. Fix that.

No practical change since the only flags that are used by GCC are all
single-digit.

lint: fix build on Cygwin

Cygwin does not conform to C99, which says that MB_CUR_MAX has type
size_t.

Instead, Cygwin defines it as type int. This leads to compile errors
because comparing signed with unsigned expressions is surprising in C.

lint: expand abbreviations in lexer function names

No functional change.

lint: explain why !finite(x) is not allowed in strict bool mode

fix the build

lint: apply strict bool mode to lex.c

There are 2 remaining expressions:

In line 244, !(kw->kw_deco & deco) is a bitwise and. This is already
allowed for enums, it needs to be allowed for arbitrary integer
expressions as well. This covers the many places where plain integers
are used for bit fields, together with #define. This pattern is not as
typesafe as using enums, still it is common practice.

In line 769, the expression !finite(f) is a legitimate use of a function
that has return type int for traditional reasons. It's the same as for
ferror.

There are several other functions like unlink, open or strcmp that have
return type int as well, but with a different meaning. It is not yet
clear what the best way is to handle these different meanings. Having
to write finite(f) == 0 in strict bool mode doesn't look idiomatic, on
the other hand, !strcmp(s1, s2) is exactly the pattern that strict bool
mode wants to avoid.

lint: clean up comments and variable names in lex.c

lint: move lexer code from scan.l to lex.c

Previously, the generated scan.c was not included when running "make
lint". Similarly, cgram.c is still not included.

lint: in C23 mode, support the nullptr constant

lint: in C23 mode, support the keywords 'bool', 'false' and 'true'

lint: clean up

lint: clean up string parsing and snprintb check

lint: remove custom wrappers around <ctype.h> functions

lint: fix misleading initializer for string iterator

The field 'start' marks the start of the previous matching character,
not the current iterator position.

No binary change.

lint: fix type error in strict bool mode (since yesterday)

lint1: remove redundant type table for integer constant suffixes

lint: clean up variable names, parameter order, comments

No functional change.

lint: clean up redundant braces

No functional change.

lint: use consistent variable names, reduce code for reading a byte

No functional change.

lint: unify rules for determining the type of an integer constant

Previously, in traditional C mode, large decimal numbers were treated as
unsigned, which disagreed with the book from 1978.

lint: warn about short octal escape followed by '8' or '9'

These mistakes is typically found in snprintb format directives but is
probably a typo everywhere else as well.

lint: keep strings in their source representation

This allows further analysis depending on whether individual characters are
escaped as octal, hexadecimal or not at all.

lint: allow hexadecimal character escapes up to UINT_MAX

Previously, any value larger than INT_MAX was regarded as negative and
thus terminated the loop around get_escaped_char.

lint: clean up comments, reduce scope of variables

lint: remove unused code for converting multibyte character sequences

lint: allow larger numbers in escapes for wide characters and strings

lint: make newline in a string literal an error in C90 and later

lint: reuse buffer editing code across lint1

Fix cat_strings to update the capacity of the buffer, to prevent
quadratic runtime when concatenating string literals.

lint: use standard buffer for storing string values

No functional change.

lint: do not remember content of wide string literals

The plain char literals are needed for checking printf/scanf format
strings; lint has no similar check for wide strings. These format
strings are checked by modern compilers, making this check less
relevant.

lint: fix type of large integer constants

lint: split determining the type of an integer constant

No functional change.

lint: extract signedness detection from lexing an integer constant

An integer constant that is signed in traditional C but unsigned since
C90 is an edge case that should not clutter the main code of determining
the resulting type of the constant.

The code for lexing an integer constant doesn't implement the C99 rules
yet, which convert a constant to the 'long long' types if the 'long'
types don't suffice.

lint: rename symt_t to symbol_kind

It was confusing to have two kinds of "symbol type" (s_type and s_symt),
so rename all related identifiers to be more distinctive.

No functional change.

lint: allow '\e' only in GCC mode

add \e

lint: allow querying for invisible characters in literals and constants

lint: in declarations, replace tab with space

Previously, in some cases, the keywords 'const' or 'struct' were
followed by a tab, which doesn't make sense.

No functional change.

lint: re-wrap comments

No functional change.

lint: indent statement continuations consistently

No binary change.

lint: rename NOSCL to NO_SCL

For symmetry with NO_TSPEC. No functional change.

lint: make diagnostics about ANSI C more international

lint: clean up lexing of preprocessing lines

The relation between 'c' and 'cp' was tricky to follow.

No functional change.

lint: improve debug logging for declarators

lint: in debug mode, default to indenting the debug log

Only the 'parsing' lines are not indented, as line breaks are
independent from the structure of the code.

lint: add detailed logging for finding memory allocation bugs

lint: add debug logging for memory management and the symbol table

lint: document which keywords are available in which language levels

lint: use separate types for parsing pointer types and type qualifiers

The documentation of the previous 'qual_ptr_t' was misleading, as that
type was used for other type qualifier lists as well, even if these were
not related to pointer types.

lint: in C23 mode, recognize the keyword 'thread_local'

lint: _Thread_local is a storage class, not a type qualifier

lint: indent copyright lines consistently

lint: clean up reading lint comments

lint: reduce code size for handling lint comments

lint: clean up code related to lint comments

Remove type information from variable names, as the word 'flag' did not
indicate that the variables were negated.

Remove contradicting comments. Suppressing a warning for 'this line',
'this and the following line' and 'this statement or declaration' cannot
all be accurate at the same time.

lint: reduce runtime relocations

lint: reject _Noreturn if it occurs in invalid places

C11 introduced _Noreturn as a function-specifier, not as a type
attribute. The latter may occur in more places.

lint: don't treat 'inline' as a storage class

The additional conflict in the grammar is in the same place as the other
conflicts, as T_SCLASS and T_FUNCTION_SPECIFIER are now separate tokens.

No functional change.

lint: condense keyword table

This prepares for modelling 'inline' not as a storage class, but more
correctly as a function specifier.

lint: add debug logging for symbol kinds in the parser

An identifier can refer to a variable, type, member, tag or label.
Switching between these namespaces is tightly coupled with the
evaluation order of the grammar rules.

lint: clean up wchar_t and hash tables

lint: miscellaneous cleanup

lint: clean up wording in diagnostics

Use the term 'parameter' as defined in C99 3.15.

lint: clean up the wording of a few diagnostics

lint: fix handling of 'long double' in cross-compiled mode

When lint is compiled on x86-64 (where 'long double' has a 64-bit
mantissa) and targets arm (where 'long double' has a 53-bit mantissa),
warn if a constant cannot fit in the 'long double' of the target
platform, not of the host platform.

lint: clean up redundant casts

lint: rename uppercase QUAD to LLONG

No binary change.

lint: rename 'quad' to 'signed int' or 'unsigned int'

No functional change.

lint: extend debug logging for declaration levels

Indent the debug logging according to the declaration level.

Since there are a few cases where the enclosing declaration levels are
modified, log the whole declaration level stack whenever a level begins
or ends.

lint: clean up names related to declaration levels

The previous prefix 'DK_' (declaration level kind) had a conflict with
the 'DK_' (designator kind) in init.c, so change the prefix to 'DLK_'.
The new name for dinfo_t is decl_level, which is more expressive.

No functional change.

lint: replace macro for unique identifiers with function

No functional change.

lint: clean up member names of declaration levels

No functional change outside debug mode.

lint: add query for comparing 'char' with plain integers

lint: miscellaneous clean-ups

No binary change, except for line numbers in assertions.

lint: indent local variables consistently

No binary change.

lint: don't wrongly warn about overflow in complex constants

Seen in lib/libm.

lint: reduce clutter in parsing preprocessor lines

No functional change.

lint: fix duplicate warning when parsing big float constants

lint: allow querying for octal integer constants

lint: do not warn about traditional C migration in C99 mode

For large integer constants, the resulting type could differ between
traditional C and C90. In C99 mode, this difference is no longer
relevant since it is too far away from traditional C.

tests/lint: fix and extend tests for C90 migration warning

lint: remove dead code from lex_floating_constant

Neither traditional C nor C11 allows a trailing 'd' or 'D' on floating
point constants. Java does, but lint does not cover Java programs.

lint: reduce scope of local variables

No functional change.

lint: use strtold for parsing floating constants

Supported since C99.

lint: remove compat code for lexing hex floating point literals

Hex floating literals are required by C99.

lint: clean up

In symtab_search, most of the conditions were redundant, so remove them.

In read_byte, using CHAR_MASK was conceptually wrong, as that constant
is from the target platform while the lexical analysis happens on the
host platform. It was unnecessary as well, as a hypothetical host
platform with 36-bit chars might encode the characters from the basic
source character set as numbers higher than 0x0_0000_00ff. Since lint
assumes that both the source character set as well as the execution
character set are the same and based on 8-bit bytes, nothing changes.

No functional change.

lint: inline an expression, clean up comments

No functional change.

lint: clean up the lexer

No functional change.

lint: prevent undefined behavior for signed '<<'

Found by manual code inspection, verified by MKSANITIZER=yes
USE_SANITIZER=undefined.

lint: use more expressive variable names in lexer

The name 't' could easily be mistaken to mean a tspec_t.

No functional change.

lint: reduce clutter in lexer

No functional change.

lint: add support for C11 '_Atomic' as atomic-type-specifier

Following the C11 grammar, the keyword '_Atomic' needs to be a separate
syntactic category, to avoid further conflicts in the grammar.

The two newly added conflicts in the grammar would come into play when
mixing traditional C with C11, in a type name without an implicit 'int'.
If the type '_Atomic(int)*' were parsed as '_Atomic int(int)*', the
trailing '*' would be a syntax error.

lint: add support for the C11 type qualifier '_Atomic'

That keyword can be used as a type specifier as well, support for that
will be added later.

lint: use simpler integers for parsing hex escapes

No functional change.

lint: use longer variable names, don't count digits in hex escapes

No functional change.

lint: eliminate forward declaration for get_escaped_char

No functional change.

lint: extract reading of escaped character constants

No functional change.

lint: extract parsing character escapes into separate functions

No functional change.

lint: document how reading tokens from the input works

Rename inpc to read_byte, to make the name more expressive. Since C99,
lint is no longer required to use overly short identifiers.

No functional change.

lint: miscellaneous cleanup

No functional change.

lint: remove explicit list of known GCC attributes

Most GCC attributes consist of a single identifier. Up to now, it was
necessary to list each of these identifiers in the grammar, even those
that only apply to a single target architecture.

Instead, parse the general form of attributes, matching the few
attributes that lint handles by name instead. While here, rename the
grammar rules to use the GCC terms.

To avoid conflicts between the global function 'printf' and the GCC
attribute of the same name, do not add GCC attributes to the symbol
table, and don't make these symbols 'extern' either.

ok christos@.

lint: make definition of type keywords simpler

The only type keyword that is available in more than one variant is
'signed', which can also be written '__signed'. Neither of the type
keywords is declared as being specific to GCC, even though __int128_t
and __uint128_t actually are non-standard.

No binary change.

lint: use __RCSID in lint mode as well

Since 1995-10-02, lint supports __asm statements and __asm modifiers.

No binary change.

lint: fix support for __alignof__, add support for __alignof

Broken since lex.c 1.129 from yesterday.

gcc also allows __alignof

lint: inline macro 'sflag'

Mark all places where lint's C90 mode is stricter than its C99 mode.

Most of the situations in which lint produces only warnings instead of
errors covered by the "Constraints" sections in the relevant standards.
This doesn't prevent a specific compiler from accepting it though.

No functional change.

lint: inline macro 'tflag'

The definition of the macro tested both allow_trad and allow_c90, but
there is only a single mode in which allow_c90 is false, therefore it
suffices to test only that.

While double-checking each occurrence of tflag individually, I learned
why lint performs lookups of struct members only by name, independently
of the struct in which they are declared. See typeok_arrow for details.

No functional change.

lint: document why in GCC mode, C99 keywords are enabled

lint: document why C11 keywords are available in C99 mode as well

lint: move GCC attributes to the bottom of the list

These identifiers have a simpler definition than the other keywords
since they do not define when they were introduced.

No functional change.

lint: remove null marker from keyword table

No functional change.

lint: prepare keyword table for C11

The C11 keywords had been listed as being C99 keywords. Instead of
initializing the individual fields separately, merge them by specifying
the year of the standard in which they appeared.

No binary change, except for line numbers in assertions.

lint: migrate gflag to allow_gcc

No functional change.

lint: clean up keyword definitions for the lexer

There is only one specialized keyword that is also a GCC attribute, it's
"section". All other keywords passed 0 in that macro argument.

No binary change.

lint: fix lint warning on platforms where size_t == unsigned int

lex.c(1451): warning: argument #1 is converted from 'int' to
'unsigned int' due to prototype [259]

A more thorough fix would be to change the type of block_level from int
to size_t, to match mem_block_level, but that change would generate
further signedness warnings because the type of sym_t.s_block_level
would have to be changed from int to size_t as well, but some symbols
have s_block_level == -1, so that's a larger and more error-prone
change. Leave that for later.

Whether message 259 makes sense at all in C99 mode is an entirely
different question that needs to be answered separately.

No functional change.

lint: distinguish between storage class and declaration kind

These types overlap but are not the same.

No functional change.

lint: disambiguate sym_t.s_value

Having a single variable for 4 different purposes with different types
makes the code unnecessarily hard to follow.

No functional change.

lint: inline member access macros for sym_t

Having the 'u.' explicitly in the code serves as a reminder that these
members are only defined under certain conditions.

No functional change.

lint: rename dinfo_t.d_next to d_enclosing

The name d_next gave the wrong impression that the declaration infos
would be independent of each other, but they are nested.

No functional change.

lint: add debug logging for the declaration stack

To track down the wrong edge cases in decl_direct_abstract.c.

lint: clean up comments, explain assertion in inssym

lint: use an unsigned counter for temporary variable names

No functional change.

lint: improve debug logging for the symbol table

Only print the heading for the symbol table level if there is actually a
symbol on that level.

Ensure that no symbol with block level -1 is ever in the symbol table
(see rmsym).

lint: fix off-by-one error in symbol table

No functional change since the error was in the "safe" direction.

lint: rename function 'cleanup' to be more expressive

No functional change.

lint: remove redundant assignments to string buffer length

No functional change.

lint: add debug logging for symbols and the symbol table

This logging is not active by default, the functions debug_sym and
debug_symtab can be called as needed during a debug session.

lint: constify lexer keywords

No functional change.

lint: reorganize lexer functions

Move the keywords table to the top, reduce forward declarations.

No functional change.

lint: group symbol table functions

No functional change.

lint: merge duplicate code for handling plain and wide strings

No functional change. As before, the string literals "1" "2" "3" are
not concatenated from left to right, instead concatenation starts with
"23" and then proceeds to "123".

lint: unabbreviate some fields in sym_t

No functional change.

lint: encode lifetime of allocated memory in the function names

No functional change.

lint: clean up memory management for string buffers

There is no reason to duplicate all the work that is already done by the
memory allocator.

No functional change.

lint: clean up memory allocation

No functional change.

lint: improve debug logging for symbol kinds

Add clang's optnone attribute.

lint: don't try to trick mathematics by defining ZERO to a nonzero value

No binary change.

lint: remove redundant EOF tests in lexer

No functional change.

lint: clean up lex.c

Rename 'struct kwtab' to 'struct keyword' since a single keyword is not
a whole keyword table.

Sync comment for lex_name with reality: sbuf_t no longer contains the
hash value.

Remove redundant tests for EOF, as EOF is neither a space nor a digit
nor an xdigit.

No functional change.

lint: remove spaces around bit-field colon

As seen in /usr/share/misc/style.

No binary change.

lint: rename C89 to C90 in variable names

No binary change.

lint: use C90 instead of C89 when referring to the C standard

Add more attributes

Improve restrict handling.

Add target attribute

lint: finish renaming of fcon to lex_floating_constant

lint: rename attron to in_gcc_attribute

No functional change.

lint: move all declarations above statements

All code that is used by src/tools is supposed to be compatible with C90.

No functional change.

use isfinite(3) instead of finite(3) for portability

Fixes tools build on macOS 11.6 arm64 hosts.

Extra commit to fix the actual wrong comment before:
Add _Static_assert grammar and keyword

remove the lint kludges

lint: fix lint warnings

lint: allow 'fallthrough' as alternative spelling of FALLTHROUGH

Seen in unbound/lookup3.c.

No change to the documentation since the canonical spelling is still the
same.

lint: accept keyword variant FALL THROUGH as alias to FALLTHROUGH

Seen in archive_string.c, macro WRITE_UC.

No documentation change since the canonical spelling of this keyword
stays the same.

lint: clean up hash functions

No functional change.

lint: remove unreachable code for parsing integer constants

The largest possible type of an integer constant is 'unsigned long
long'. Any larger type can only be expressed using casts.

See also https://gcc.gnu.org/onlinedocs/gcc/_005f_005fint128.html.

lint: fold constants in hash functions

All platforms supported by lint have sizeof(unsigned int) == 4 and
CHAR_BIT == 8. There is no need to encode these expressions in a hash
function, they only made the code harder to read.

No functional change.

lint: replace obsolete strtouq with equivalent strtoull

lint: fix lexing of character constants

The final value of the character constant must be determined by the
target platform, not the host platform.

This allows to run the tests for a target platform with different
signedness of characters, by editing targparam.h and t_integration.

Lint is not completely cross-compileable though. 64-bit host platforms
can run lint for 32-bit platforms, but not vice versa, since 32-bit GCC
does not provide 128-bit integer types.

lint: explicitly ignore return value of some function calls

This fixes the warning from lint2 that these functions return values
which are sometimes ignored.

The remaining calls to fprintf that ignore the return value come from
scan.c. Lint does not currently detect the auto-generated portions of
that file and the interesting ones since it assumes that scan.c is the
main filename, see expr_zalloc_tnode.

No functional change.

lint: use 'unsigned int' for bit-size of types in convert_integer

There was no need to have two separate magic values (0 and -1) to mean
the same.

No functional change.

lint: un-abbreviate unsigned integer types

No functional change.

lint: add __attribute__ regparm

Seen in libexec/ld.elf_so/rtld.h.

lint: inline msb

This reduces the binary size on x86_64 by about 500 bytes.

No functional change.

lint: remove unnecessary width parameter for msb

No functional change.

lint: use unsigned integers for storing hash values

The computation of the hash values is unchanged, only the resulting
value (which is always less than 1009 anyway, see HSHSIZ2) is stored as
unsigned as well.

No functional change.

lint: save some memory

Before lint1.h 1.47 from 2021-01-02, adjacent bit-field struct members
shared storage. Restore that using smaller types.

No functional change.

lint: change return type of 'msb' from int to bool

No functional change.

lint: clean up lex_integer_constant

When lexing an integer constant, it does not make sense to check for
'struct', 'void' or other types. Furthermore, the constants were listed
in some random-looking order, which made the code hard to read.

Add returns_nonnull attribute

lint: remove hash value from symbol buffer

Conceptually, a symbol buffer does not need to remember its hash value
since that belongs to the symbol table. This makes the code for the
symbol table simpler. The number of hash calculations increases by
about 5%, which is negligible.

No functional change.

lint: merge duplicate code for removing a symbol from the table

No functional change.

lint: extract duplicate code for modifying the symbol table

No functional change.

lint: add debug logging for symbol table, clean up debug logging

When I tried to fix msg_115, I quickly ran into a segmentation fault,
probably related to the symbol table. To better understand this part,
log insertions and deletions.

The other debug log messages do not need to mention the current file
position anymore, this is what lex_next_line takes care of since scan.l
1.113 from 2021-01-05.

lint: clean up debug logging

The calls to debug_step, unlike printf, don't need a trailing newline.

Remove the debug_step0 macro and its relatives since lint already uses
enough other features from C99 that it essentially requires this
standard, which supports varargs macro arguments. Among these features
are __func__ and printf("%zu").

In non-debug mode, do not evaluate the arguments of debug_step.
Evaluating the arguments had caused an internal error when running the
test op_shl_lp64. This is indeed a bug since initdecl should have
initialized the type table for __uint128_t. This had been forgotten
when support for __uint128_t was added in decl.c 1.69 from 2018-09-07.

No functional change.

lint: reduce indentation in 'search'

No functional change.

lint: write canonical form of keywords

For keywords that have a single spelling variant (such as __packed),
write this form in the source, to make it searchable. This also avoids
a few calls to malloc.

Previously, some keywords had leading underscores and some hadn't, this
was inconsistent.

No functional change.

lint: support __attribute__((hot))

The corresponding attribute 'cold' was already added in cgram.y 1.84
from 2016-12-29.

lint: rename y_sb to y_name

That buffer is only used for names of identifiers, so be more specific.

No functional change.

lint: remove double negation in comment

No functional change.

lint: constify keyword in lexer

No functional change.

lint: __real__ and __imag__ are GNU extensions

https://gcc.gnu.org/onlinedocs/gcc/Complex.html

lint: inline 'sign' into convert_integer

No functional change.

lint: rename xsign to convert_integer

The term sign-extend was too specific, the function actually does a
broader conversion.

No functional change.

lint: clean up lex_character_constant

No functional change.

lint: fix lexical analysis of character constants in traditional C

The code now follows the wording of the C Reference Manual from 1978.

lint: rename val_t.v_unsigned to avoid confusion

The name v_unsigned suggested that the value would be interpreted as
unsigned, which was wrong. Whether a value is signed or unsigned is
decided by v_tspec instead.

Revert the previous commit for boolen constants since their value is
already interpreted as unsigned, and there is no need for any warning
about differences between traditional C and ANSI C since the _Bool type
has only been added ten years later in C99.

The code for printing a tree node was also confused by this struct
member, even with its old name v_ansiu. That code will be fixed in a
follow-up commit.

No functional change.

lint: rename val_t.v_ansiu to v_unsigned

When lint was written in 1995, traditional C was still nearby since C90
had been around for only 5 years. 26 years later, almost all code
adheres to C90 or even C99 or C11, therefore "C90 or later" can safely
be assumed as the default.

No functional change.

lint: fix confusing variable name in lex_wide_character_constant

By convention, i is an index, not a count.

No functional change.

lint: reduce indentation in lexer for character constants

No functional change.

lint: fix check for empty wide character constant

This bug got almost 26 years old, it was already there at the initial
commit in 1995.

lint: fix endless loop on unfinished comment at EOF

Found using afl.

lint: fix endless loop when scanning string or character literals

If the code contains an unfinished string or character literal at the
EOF, the lexer got into an endless loop. Curiously, inpc() returned 0
in such a case instead of the common EOF.

Found by making lint1 with CC=afl-gcc and then running:

afl-fuzz \
-m 200 \
-i in_dir \
-o lint1 \
$src/usr.bin/xlint/lint1/lint1 @@ /dev/null

lint: revert fix for endless loop in lexer for string literals

String literals may contain null bytes, and these must be passed further
on.

This reintroduces the endless loop in the lexer, but that must be fixed
in another way that doesn't destroy the error handling.

lint: fix hang on unfinished string literal at end-of-file

The input file that triggered this bug was:

a"b"c"d

Found using afl.

lint: replace array access with function calls

First and foremost, the test d_c99_complex_split accessed the array
qlmasks out-of-bounds, with an index of 128 for the type 'double
_Complex'. This invoked undefined behavior since the maximum allowed
index was 64.

Replacing the raw array accesses with function calls allows for bounds
checks to catch these errors early.

Determining the value bits for a 'double _Complex' does not make sense
at all since it is not an integer type. This means that lint didn't
handle these types correctly for several years. Support for int128_t
has been added in inittyp.c 1.12 from 2018-09-07, support for _Complex
has been added in inittyp.c 1.9 from 2008-04-26.

Determining the value bits for an int128_t would make sense, but the
unit tests don't contain examples for this type since at the moment all
unit tests must produce the same results on 32-bit and 64-bit platforms,
and the 32-bit platforms don't support int128_t.

lint: undefine macros for defining keywords after use

No functional change.

lint: remove redundancy when defining classic keywords

No functional change.

lint: reduce redundancy when defining GCC attributes

This macro would have prevented the unintended inconsistency in the
attribute 'pcs' (for ARM).

No functional change. The generated code is the same, except for the
line numbers in lint_assert.

lint: allow variables to be named 'pcs'

lint: fix compiler warning about signedness mismatch

No functional change.

put back nonnull. I meant to just sort it.

- add nonstring attribute
- allow attributes after labels (for unused)
XXX: split the attributes into function, variable, etc attributes
so that we don't accept all attributes in all places (only where they make
sense)

Add common attribute

lint: fix storage class of compound literal in initializer

A compound literal that occurs at block_level 0 does not have storage
class AUTO. Instead, its storage class is either EXTERN or STATIC.

While removing the temporary objects from the symbol table had prevented
the assertion, it did not properly fix the underlying problem, which was
that since C99 the initializers can contain references to unnamed
objects that are created on-the-fly. For C90 it was correct to always
use AUTO as the storage class of a temporary symbol.

Add attribute fallthrough

lint: clean up handling of preprocessing output lines

No functional change.

lint: in code from included files, print stack trace

Previously, the standard NetBSD build generated several lint warnings in
lhash.h from OpenSSL, without providing any hint as to which file
actually included that header. In cases like these, lint now interprets
the line number information in the preprocessor output from GCC to
reconstruct the exact include path to the file in question.

The program check-expect.lua had to be rewritten almost completely since
it assumed that all diagnostics would come from the main file. In all
existing tests, this was true, but these tests did not cover all cases
that occurred in practice. Now it records the complete location of the
diagnostic instead of just the line number.

lint: sync comment with reality after renaming several functions

No functional change.

lint: reduce memory usage

No functional change.

lint: add parentheses after sizeof, as required by share/misc/style

No functional change.

lint: sprinkle const on function declarations

No functional change.

lint: rename LERROR to INTERNAL_ERROR

The '#ifndef' in tyname.c is meant to distinguish between lint1 and
lint2, it is not meant to be defined from anywhere outside the lint code
itself.

No functional change.

lint: rename filename management functions

No functional change.

lint: remove space between 'sizeof ('

No functional change.