better check st_size == 0, than st_dev == -1

PR/57851: Ricardo Branco: stat(2) does not return correct size information
for kernfs/procfs files. Minor KNF.

Don't try to use stdin after clobbering it with a failed freopen().
Prevents an extra "Bad file descriptor" message when trying to hexdump
a single nonexistent file.

The intended behavior seems to have been to read from stdin if there
was one filename given and it wasn't valid. But this seems like a bad
idea, so prevent that case instead of hacking it up so it works.

Don't use one function for two different things. Two functions is the
ticket.

use "static"

don't read random garbage from the stack

branches: 1.21.8; 1.21.14;
Integer values, no matter what their width, are cast to int64_t or
uint64_t for printing. Because of this, parse.c:rewrite() should use
PRI[diouxX]64 as the printf format; the previous revision which used
"lld" and friends was a temporary measure. We assume that PRId64 ends
with 'd', PRIx64 ends with 'x', etc.

In display.c:display(), change some u_intNN_t types to C99 standard
uintNN_t types, and consistently cast to [u]int64_t when printing
integer values (even in two cases where it's not really necessary but it
makes the code look more consistent).

More programs using efun.

de-__P, ANSIfy prototypes

Overhaul how `build.sh tools' are used:

* Rename "config.h" to "nbtool_config.h" and
HAVE_CONFIG_H to HAVE_NBTOOL_CONFIG_H.
This makes in more obvious in the source when we're using
tools/compat/config.h versus "standard autoconf" config.h

* Consistently move the inclusion of nbtool_config.h to before
<sys/cdefs.h> so that the former can provide __RCSID() (et al),
and there's no need to protect those macros any more.

These changes should make it easier to "tool-ify" a program by adding:
#if HAVE_NBTOOL_CONFIG_H
#include "nbtool_config.h"
#endif
to the top of the source files (for the general case).

add
#if HAVE_CONFIG_H
#include "config.h"
#endif
to get this to build under solaris-2.6/sparc with gcc-2.95.1 as part of
the NetBSD cross toolchain build. Fixes PR23211. Patch approved by
Alistair Crooks.

include <inttypes.h> to get uint64_t defined

This is a host tool: use {u,}int64_t instead of {u_,}quad_t.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Two more __RCSID checks that I missed.

WARNS=2

Enable support for printing 8-byte integers. For some reason, most of the
code for this was present, but disabled.
This is required for POSIX compliance on platforms with 8-byte longs.

PR/9195: Tanaka Akira: od does not display short files containing nulls. Fix
from Andrew Brown.

printf() pedant - even if we are sure that there's no %-formatted in a
varaiable, don't pass variable alone to printf().
From: kris@freebsd.org (FreeBSD-current usr.bin/hexdump/display.c 1.4 -> 1.6)

branches: 1.8.4;
Since our gcc doesn't warn about NULL format strings anymore, we can
fix the incorrect err(1, "%s", "") et al.
Closes PR bin/7592 by cgd.

branches: 1.7.8;
WARNSify, fix .Nm usage, deprecate register

merge lite-2.

add explicit return types to many functions
pull global variable declarations and function prototypes into hexdump.h
add #includes where necessary for prototypes
replace index() with strchr(), const-poison static string vars, etc.

RCS ID police

Include appropriate header files to bring prototypes into scope.
Removed explicit errno declarations.

Add RCS identifiers.

branches: 1.1.1;
Initial revision

Don't try to use stdin after clobbering it with a failed freopen().
Prevents an extra "Bad file descriptor" message when trying to hexdump
a single nonexistent file.

The intended behavior seems to have been to read from stdin if there
was one filename given and it wasn't valid. But this seems like a bad
idea, so prevent that case instead of hacking it up so it works.

Don't use one function for two different things. Two functions is the
ticket.

use "static"

don't read random garbage from the stack

branches: 1.21.8; 1.21.14;
Integer values, no matter what their width, are cast to int64_t or
uint64_t for printing. Because of this, parse.c:rewrite() should use
PRI[diouxX]64 as the printf format; the previous revision which used
"lld" and friends was a temporary measure. We assume that PRId64 ends
with 'd', PRIx64 ends with 'x', etc.

In display.c:display(), change some u_intNN_t types to C99 standard
uintNN_t types, and consistently cast to [u]int64_t when printing
integer values (even in two cases where it's not really necessary but it
makes the code look more consistent).

More programs using efun.

de-__P, ANSIfy prototypes

Overhaul how `build.sh tools' are used:

* Rename "config.h" to "nbtool_config.h" and
HAVE_CONFIG_H to HAVE_NBTOOL_CONFIG_H.
This makes in more obvious in the source when we're using
tools/compat/config.h versus "standard autoconf" config.h

* Consistently move the inclusion of nbtool_config.h to before
<sys/cdefs.h> so that the former can provide __RCSID() (et al),
and there's no need to protect those macros any more.

These changes should make it easier to "tool-ify" a program by adding:
#if HAVE_NBTOOL_CONFIG_H
#include "nbtool_config.h"
#endif
to the top of the source files (for the general case).

add
#if HAVE_CONFIG_H
#include "config.h"
#endif
to get this to build under solaris-2.6/sparc with gcc-2.95.1 as part of
the NetBSD cross toolchain build. Fixes PR23211. Patch approved by
Alistair Crooks.

include <inttypes.h> to get uint64_t defined

This is a host tool: use {u,}int64_t instead of {u_,}quad_t.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22365, verified by myself.

Two more __RCSID checks that I missed.

WARNS=2

Enable support for printing 8-byte integers. For some reason, most of the
code for this was present, but disabled.
This is required for POSIX compliance on platforms with 8-byte longs.

PR/9195: Tanaka Akira: od does not display short files containing nulls. Fix
from Andrew Brown.

printf() pedant - even if we are sure that there's no %-formatted in a
varaiable, don't pass variable alone to printf().
From: kris@freebsd.org (FreeBSD-current usr.bin/hexdump/display.c 1.4 -> 1.6)

branches: 1.8.4;
Since our gcc doesn't warn about NULL format strings anymore, we can
fix the incorrect err(1, "%s", "") et al.
Closes PR bin/7592 by cgd.

branches: 1.7.8;
WARNSify, fix .Nm usage, deprecate register

merge lite-2.

add explicit return types to many functions
pull global variable declarations and function prototypes into hexdump.h
add #includes where necessary for prototypes
replace index() with strchr(), const-poison static string vars, etc.

RCS ID police

Include appropriate header files to bring prototypes into scope.
Removed explicit errno declarations.

Add RCS identifiers.

branches: 1.1.1;
Initial revision