tests/libcurses: constify

tests/libcurses: sprinkle 'const', normalize sizeof

No functional change.

tests/libcurses: fix names of over-the-wire data types

The test 'mvscanw' reported that it would send '%s' as 'numeric', which
was rather suspicious.

tests/libcurses: clean up table of input functions

The previous "table" was an insult to any reader. It was unsorted,
listed the functions shuffled, and was not even formatted consistently.

No functional change.

tests/libcurses: don't waste time calling strlen needlessly

Simplify to avoid copy based on the size of the source.

tests/libcurses: fix error handling for non-system errors

These errors are unrelated to errno. The scanf family of functions also
does not set errno.

tests/libcurses: fix error messages

tests/libcurses: clean up inclusion guards, function declarations

No functional change.

tests/libcurses: fix pipe handling in the parent process

The parent process, like the child process, needs only 2 of the 4 pipe
ends.

In verbose mode (now at testlang_parse.y:1151 and :1154), both ends of the
pipe_from_slave were examined. This looked like a typo and has been fixed
to those pipe ends that are relevant to the parent process.

tests/libcurses: add missing space after control flow keywords

tests/libcurses: fix off-by-one error in line numbers in diagnostics

I had broken this in testlang_parse.y 1.22 from 2021-02-07, when I
extracted the common 'eol' from the statements. Extracting 'eol' had
the effect that the action for the statement was run before the line
number increased.

Now the line numbers in the diagnostics are the same again as before.

For lines that end with a backslash, the reported line number is the one
from the last of these lines, not the first one, also as before. This
feature is not used by any of the current tests though.

tests/libcurses: use consistent indentation for grammar rules

tests/libcurses: extract functions 'input' and 'noinput' from grammar

tests/libcurses: indent grammar functions consistently

tests/libcurses: declare %type in grammar

It looks as if the original author just didn't know how to declare the
type of non-terminals. The explicit types in the '$' expressions were
all consistent.

No functional change.

tests/libcurses: extract function 'delay_millis' from the grammar

tests/libcurses: move function 'check' out of the grammar section

This removes the inconsistent indentation.

tests/libcurses: fix typo in license text

tests/libcurses: remove unused token DRAIN

There is a special function named 'DRAIN', but not a statement. The
function name does not need its own token.

tests/libcurses: use a single message style for diagnostics

Previously, there were several concurring styles:

$msg in line %zu of file %s
$msg line %zu of file %s
%s, %zu: $msg

All these are now replaced with "%s:%zu: $msg".

tests/libcurses: make grammar for test cases conflict-free

No functional change.

tests/libcurses: fix grammar for arrays

Previously, commas were completely ignored by the grammar. Erroring out
on invalid characters made some of the tests fail since the comma was
not recognized anymore. Add it back, but only for defining arrays. It
would have been possible to leave out the commas or make them optional,
but since the current tests do not make use of that, keep the grammar as
strict as possible.

Fix an unclosed string literal in a test. This had been wrongly
accepted before by the grammar.

tests/libcurses: add missing semicolon in grammar

tests/libcurses: add const to some function parameters

tests/libcurses: simplify code for writing to the .exp file

If a write(2) returns less than 1, it must be an error.

tests/libcurses: actually compare the stream to an absolute path

Up to now, the test command "compare /dev/null" was a no-op since the
command was only parsed but not run at all. Now run it.

This makes the test mvwin fail. That test will have to be fixed.

Comparing to /dev/null is certainly possible and may make sense,
comparing to /dev/zero is nonsense since the actual stream can never be
endless. Some tests do that nevertheless, for whatever reason.

In order to have the expected test output closer to the curses commands
that cause it, it may be a good idea to add another command
'compare_str' that would work independently of an external file and at
the same time allow the expected output to be commented and explained.
This is not possible right now since the .chk files are read exactly
as-is.

tests/libcurses: use more common abbreviations for tokens

tests/libcurses: use standard indentation for grammar rule 'arg'

tests/libcurses: extract grammar rule 'arg'

tests/libcurses: fail on syntax errors in test files

Previously, a syntax error in a test file made the test pass, which was
outright dangerous.

tests/libcurses: use a single indentation style in the test grammar

The grammar rule 'args' has been left as-is since it needs to be split
into 'args' and 'arg' first, to avoid the redundancy.

The braces in "if (create_check_file)" were misleading. It's strange that
GCC didn't reject this.

tests/libcurses: clean up test case grammar for statements

Previously, each statement ended with 'eol'. This was unnecessarily
verbose since the 'eol' is not really part of the statement, it's part
of a line.

No functional change.

tests/libcurses: fix name of grammar rule

A list of assignments is not a statement, it's several statements.

No functional change.

tests/libcurses: unary minus doesn't make sense on bool expressions

No functional change since -1 is as non-zero as 1.

Remove extra parens

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

saved_output is owned by director.c

Rototill to add complex character support:

- Add cchar command to director test language to allow a complex character
to be defined and passed to the slave.
- Removed the distinction between args and returns internally to prevent
confusing the two which leads to errors and/or crashes.
- Converted mutt_test to use the new cchar definition and fixed the
check files for the test.

Bracket strings being validated with markers to ensure sneaky whitespeace
is noticed.

branches: 1.14.16;
add proper include files.

* Add scanw family function calls as input functions

branches: 1.12.2; 1.12.8;
fix printf format strings

- Add erase and kill to the terminal attributes so we can test
fetching them
- Remove functions from the input_functions array that don't really do
input
- Re-enable the reporting of poll events after a function call
- Check that the return_type from the slave matches the expected one
- If verbose then print out the byte streams being compared in
validate_byte
- When reporting a length mismatch during a byte validation, report
the actual lengths.

- Add a delay just after the function is passed to the slave, this
gives the slave time to process the command and produce output before
the director drains output from the slave. This is particularly
important when the slave is set up for timed input because the ioctl
used by curses to set the tty parameters waits for pending output to
drain.
- make a debug statement conditional on verbose again
- make a warning about output from the slave conditional on verbose
- fix setting the minimum input delay, it should be milliseconds not
nanoseconds.
- Handle nanosleep returning early due to a signal, restart the sleep
with the remaining time.

- err -> errx mistakes
- make sure that -v does not change the program behavior
- don't set revents in poll
- add more debugging
- only call read when we have POLLIN
- don't mix I/O from master while processing input

Fix enums confusion.

Try to initialize retval to something sensible.

vis'ify the excess byte printing so that xstlproc does not barf.

- pass things in arguments instead of environment
- sanity check arguments
- disable extra data warning, old tests gave it too
- print more detailed errors
- use err/warn more
*some tests still fail; more than they used to*

Turn warns on for all tests and fix all the bugs.

branches: 1.3.2;
if you don't include the proper include files, you are going to end up
calling functions incorrectly.

Allow a NULL pointer to be passed as an argument to a call.

Add atf for libcurses with some tests

tests/libcurses: sprinkle 'const', normalize sizeof

No functional change.

tests/libcurses: fix names of over-the-wire data types

The test 'mvscanw' reported that it would send '%s' as 'numeric', which
was rather suspicious.

tests/libcurses: clean up table of input functions

The previous "table" was an insult to any reader. It was unsorted,
listed the functions shuffled, and was not even formatted consistently.

No functional change.

tests/libcurses: don't waste time calling strlen needlessly

Simplify to avoid copy based on the size of the source.

tests/libcurses: fix error handling for non-system errors

These errors are unrelated to errno. The scanf family of functions also
does not set errno.

tests/libcurses: fix error messages

tests/libcurses: clean up inclusion guards, function declarations

No functional change.

tests/libcurses: fix pipe handling in the parent process

The parent process, like the child process, needs only 2 of the 4 pipe
ends.

In verbose mode (now at testlang_parse.y:1151 and :1154), both ends of the
pipe_from_slave were examined. This looked like a typo and has been fixed
to those pipe ends that are relevant to the parent process.

tests/libcurses: add missing space after control flow keywords

tests/libcurses: fix off-by-one error in line numbers in diagnostics

I had broken this in testlang_parse.y 1.22 from 2021-02-07, when I
extracted the common 'eol' from the statements. Extracting 'eol' had
the effect that the action for the statement was run before the line
number increased.

Now the line numbers in the diagnostics are the same again as before.

For lines that end with a backslash, the reported line number is the one
from the last of these lines, not the first one, also as before. This
feature is not used by any of the current tests though.

tests/libcurses: use consistent indentation for grammar rules

tests/libcurses: extract functions 'input' and 'noinput' from grammar

tests/libcurses: indent grammar functions consistently

tests/libcurses: declare %type in grammar

It looks as if the original author just didn't know how to declare the
type of non-terminals. The explicit types in the '$' expressions were
all consistent.

No functional change.

tests/libcurses: extract function 'delay_millis' from the grammar

tests/libcurses: move function 'check' out of the grammar section

This removes the inconsistent indentation.

tests/libcurses: fix typo in license text

tests/libcurses: remove unused token DRAIN

There is a special function named 'DRAIN', but not a statement. The
function name does not need its own token.

tests/libcurses: use a single message style for diagnostics

Previously, there were several concurring styles:

$msg in line %zu of file %s
$msg line %zu of file %s
%s, %zu: $msg

All these are now replaced with "%s:%zu: $msg".

tests/libcurses: make grammar for test cases conflict-free

No functional change.

tests/libcurses: fix grammar for arrays

Previously, commas were completely ignored by the grammar. Erroring out
on invalid characters made some of the tests fail since the comma was
not recognized anymore. Add it back, but only for defining arrays. It
would have been possible to leave out the commas or make them optional,
but since the current tests do not make use of that, keep the grammar as
strict as possible.

Fix an unclosed string literal in a test. This had been wrongly
accepted before by the grammar.

tests/libcurses: add missing semicolon in grammar

tests/libcurses: add const to some function parameters

tests/libcurses: simplify code for writing to the .exp file

If a write(2) returns less than 1, it must be an error.

tests/libcurses: actually compare the stream to an absolute path

Up to now, the test command "compare /dev/null" was a no-op since the
command was only parsed but not run at all. Now run it.

This makes the test mvwin fail. That test will have to be fixed.

Comparing to /dev/null is certainly possible and may make sense,
comparing to /dev/zero is nonsense since the actual stream can never be
endless. Some tests do that nevertheless, for whatever reason.

In order to have the expected test output closer to the curses commands
that cause it, it may be a good idea to add another command
'compare_str' that would work independently of an external file and at
the same time allow the expected output to be commented and explained.
This is not possible right now since the .chk files are read exactly
as-is.

tests/libcurses: use more common abbreviations for tokens

tests/libcurses: use standard indentation for grammar rule 'arg'

tests/libcurses: extract grammar rule 'arg'

tests/libcurses: fail on syntax errors in test files

Previously, a syntax error in a test file made the test pass, which was
outright dangerous.

tests/libcurses: use a single indentation style in the test grammar

The grammar rule 'args' has been left as-is since it needs to be split
into 'args' and 'arg' first, to avoid the redundancy.

The braces in "if (create_check_file)" were misleading. It's strange that
GCC didn't reject this.

tests/libcurses: clean up test case grammar for statements

Previously, each statement ended with 'eol'. This was unnecessarily
verbose since the 'eol' is not really part of the statement, it's part
of a line.

No functional change.

tests/libcurses: fix name of grammar rule

A list of assignments is not a statement, it's several statements.

No functional change.

tests/libcurses: unary minus doesn't make sense on bool expressions

No functional change since -1 is as non-zero as 1.

Remove extra parens

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

saved_output is owned by director.c

Rototill to add complex character support:

- Add cchar command to director test language to allow a complex character
to be defined and passed to the slave.
- Removed the distinction between args and returns internally to prevent
confusing the two which leads to errors and/or crashes.
- Converted mutt_test to use the new cchar definition and fixed the
check files for the test.

Bracket strings being validated with markers to ensure sneaky whitespeace
is noticed.

branches: 1.14.16;
add proper include files.

* Add scanw family function calls as input functions

branches: 1.12.2; 1.12.8;
fix printf format strings

- Add erase and kill to the terminal attributes so we can test
fetching them
- Remove functions from the input_functions array that don't really do
input
- Re-enable the reporting of poll events after a function call
- Check that the return_type from the slave matches the expected one
- If verbose then print out the byte streams being compared in
validate_byte
- When reporting a length mismatch during a byte validation, report
the actual lengths.

- Add a delay just after the function is passed to the slave, this
gives the slave time to process the command and produce output before
the director drains output from the slave. This is particularly
important when the slave is set up for timed input because the ioctl
used by curses to set the tty parameters waits for pending output to
drain.
- make a debug statement conditional on verbose again
- make a warning about output from the slave conditional on verbose
- fix setting the minimum input delay, it should be milliseconds not
nanoseconds.
- Handle nanosleep returning early due to a signal, restart the sleep
with the remaining time.

- err -> errx mistakes
- make sure that -v does not change the program behavior
- don't set revents in poll
- add more debugging
- only call read when we have POLLIN
- don't mix I/O from master while processing input

Fix enums confusion.

Try to initialize retval to something sensible.

vis'ify the excess byte printing so that xstlproc does not barf.

- pass things in arguments instead of environment
- sanity check arguments
- disable extra data warning, old tests gave it too
- print more detailed errors
- use err/warn more
*some tests still fail; more than they used to*

Turn warns on for all tests and fix all the bugs.

branches: 1.3.2;
if you don't include the proper include files, you are going to end up
calling functions incorrectly.

Allow a NULL pointer to be passed as an argument to a call.

Add atf for libcurses with some tests

tests/libcurses: fix names of over-the-wire data types

The test 'mvscanw' reported that it would send '%s' as 'numeric', which
was rather suspicious.

tests/libcurses: clean up table of input functions

The previous "table" was an insult to any reader. It was unsorted,
listed the functions shuffled, and was not even formatted consistently.

No functional change.

tests/libcurses: don't waste time calling strlen needlessly

Simplify to avoid copy based on the size of the source.

tests/libcurses: fix error handling for non-system errors

These errors are unrelated to errno. The scanf family of functions also
does not set errno.

tests/libcurses: fix error messages

tests/libcurses: clean up inclusion guards, function declarations

No functional change.

tests/libcurses: fix pipe handling in the parent process

The parent process, like the child process, needs only 2 of the 4 pipe
ends.

In verbose mode (now at testlang_parse.y:1151 and :1154), both ends of the
pipe_from_slave were examined. This looked like a typo and has been fixed
to those pipe ends that are relevant to the parent process.

tests/libcurses: add missing space after control flow keywords

tests/libcurses: fix off-by-one error in line numbers in diagnostics

I had broken this in testlang_parse.y 1.22 from 2021-02-07, when I
extracted the common 'eol' from the statements. Extracting 'eol' had
the effect that the action for the statement was run before the line
number increased.

Now the line numbers in the diagnostics are the same again as before.

For lines that end with a backslash, the reported line number is the one
from the last of these lines, not the first one, also as before. This
feature is not used by any of the current tests though.

tests/libcurses: use consistent indentation for grammar rules

tests/libcurses: extract functions 'input' and 'noinput' from grammar

tests/libcurses: indent grammar functions consistently

tests/libcurses: declare %type in grammar

It looks as if the original author just didn't know how to declare the
type of non-terminals. The explicit types in the '$' expressions were
all consistent.

No functional change.

tests/libcurses: extract function 'delay_millis' from the grammar

tests/libcurses: move function 'check' out of the grammar section

This removes the inconsistent indentation.

tests/libcurses: fix typo in license text

tests/libcurses: remove unused token DRAIN

There is a special function named 'DRAIN', but not a statement. The
function name does not need its own token.

tests/libcurses: use a single message style for diagnostics

Previously, there were several concurring styles:

$msg in line %zu of file %s
$msg line %zu of file %s
%s, %zu: $msg

All these are now replaced with "%s:%zu: $msg".

tests/libcurses: make grammar for test cases conflict-free

No functional change.

tests/libcurses: fix grammar for arrays

Previously, commas were completely ignored by the grammar. Erroring out
on invalid characters made some of the tests fail since the comma was
not recognized anymore. Add it back, but only for defining arrays. It
would have been possible to leave out the commas or make them optional,
but since the current tests do not make use of that, keep the grammar as
strict as possible.

Fix an unclosed string literal in a test. This had been wrongly
accepted before by the grammar.

tests/libcurses: add missing semicolon in grammar

tests/libcurses: add const to some function parameters

tests/libcurses: simplify code for writing to the .exp file

If a write(2) returns less than 1, it must be an error.

tests/libcurses: actually compare the stream to an absolute path

Up to now, the test command "compare /dev/null" was a no-op since the
command was only parsed but not run at all. Now run it.

This makes the test mvwin fail. That test will have to be fixed.

Comparing to /dev/null is certainly possible and may make sense,
comparing to /dev/zero is nonsense since the actual stream can never be
endless. Some tests do that nevertheless, for whatever reason.

In order to have the expected test output closer to the curses commands
that cause it, it may be a good idea to add another command
'compare_str' that would work independently of an external file and at
the same time allow the expected output to be commented and explained.
This is not possible right now since the .chk files are read exactly
as-is.

tests/libcurses: use more common abbreviations for tokens

tests/libcurses: use standard indentation for grammar rule 'arg'

tests/libcurses: extract grammar rule 'arg'

tests/libcurses: fail on syntax errors in test files

Previously, a syntax error in a test file made the test pass, which was
outright dangerous.

tests/libcurses: use a single indentation style in the test grammar

The grammar rule 'args' has been left as-is since it needs to be split
into 'args' and 'arg' first, to avoid the redundancy.

The braces in "if (create_check_file)" were misleading. It's strange that
GCC didn't reject this.

tests/libcurses: clean up test case grammar for statements

Previously, each statement ended with 'eol'. This was unnecessarily
verbose since the 'eol' is not really part of the statement, it's part
of a line.

No functional change.

tests/libcurses: fix name of grammar rule

A list of assignments is not a statement, it's several statements.

No functional change.

tests/libcurses: unary minus doesn't make sense on bool expressions

No functional change since -1 is as non-zero as 1.

Remove extra parens

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

saved_output is owned by director.c

Rototill to add complex character support:

- Add cchar command to director test language to allow a complex character
to be defined and passed to the slave.
- Removed the distinction between args and returns internally to prevent
confusing the two which leads to errors and/or crashes.
- Converted mutt_test to use the new cchar definition and fixed the
check files for the test.

Bracket strings being validated with markers to ensure sneaky whitespeace
is noticed.

branches: 1.14.16;
add proper include files.

* Add scanw family function calls as input functions

branches: 1.12.2; 1.12.8;
fix printf format strings

- Add erase and kill to the terminal attributes so we can test
fetching them
- Remove functions from the input_functions array that don't really do
input
- Re-enable the reporting of poll events after a function call
- Check that the return_type from the slave matches the expected one
- If verbose then print out the byte streams being compared in
validate_byte
- When reporting a length mismatch during a byte validation, report
the actual lengths.

- Add a delay just after the function is passed to the slave, this
gives the slave time to process the command and produce output before
the director drains output from the slave. This is particularly
important when the slave is set up for timed input because the ioctl
used by curses to set the tty parameters waits for pending output to
drain.
- make a debug statement conditional on verbose again
- make a warning about output from the slave conditional on verbose
- fix setting the minimum input delay, it should be milliseconds not
nanoseconds.
- Handle nanosleep returning early due to a signal, restart the sleep
with the remaining time.

- err -> errx mistakes
- make sure that -v does not change the program behavior
- don't set revents in poll
- add more debugging
- only call read when we have POLLIN
- don't mix I/O from master while processing input

Fix enums confusion.

Try to initialize retval to something sensible.

vis'ify the excess byte printing so that xstlproc does not barf.

- pass things in arguments instead of environment
- sanity check arguments
- disable extra data warning, old tests gave it too
- print more detailed errors
- use err/warn more
*some tests still fail; more than they used to*

Turn warns on for all tests and fix all the bugs.

branches: 1.3.2;
if you don't include the proper include files, you are going to end up
calling functions incorrectly.

Allow a NULL pointer to be passed as an argument to a call.

Add atf for libcurses with some tests

Simplify to avoid copy based on the size of the source.

tests/libcurses: fix error handling for non-system errors

These errors are unrelated to errno. The scanf family of functions also
does not set errno.

tests/libcurses: fix error messages

tests/libcurses: clean up inclusion guards, function declarations

No functional change.

tests/libcurses: fix pipe handling in the parent process

The parent process, like the child process, needs only 2 of the 4 pipe
ends.

In verbose mode (now at testlang_parse.y:1151 and :1154), both ends of the
pipe_from_slave were examined. This looked like a typo and has been fixed
to those pipe ends that are relevant to the parent process.

tests/libcurses: add missing space after control flow keywords

tests/libcurses: fix off-by-one error in line numbers in diagnostics

I had broken this in testlang_parse.y 1.22 from 2021-02-07, when I
extracted the common 'eol' from the statements. Extracting 'eol' had
the effect that the action for the statement was run before the line
number increased.

Now the line numbers in the diagnostics are the same again as before.

For lines that end with a backslash, the reported line number is the one
from the last of these lines, not the first one, also as before. This
feature is not used by any of the current tests though.

tests/libcurses: use consistent indentation for grammar rules

tests/libcurses: extract functions 'input' and 'noinput' from grammar

tests/libcurses: indent grammar functions consistently

tests/libcurses: declare %type in grammar

It looks as if the original author just didn't know how to declare the
type of non-terminals. The explicit types in the '$' expressions were
all consistent.

No functional change.

tests/libcurses: extract function 'delay_millis' from the grammar

tests/libcurses: move function 'check' out of the grammar section

This removes the inconsistent indentation.

tests/libcurses: fix typo in license text

tests/libcurses: remove unused token DRAIN

There is a special function named 'DRAIN', but not a statement. The
function name does not need its own token.

tests/libcurses: use a single message style for diagnostics

Previously, there were several concurring styles:

$msg in line %zu of file %s
$msg line %zu of file %s
%s, %zu: $msg

All these are now replaced with "%s:%zu: $msg".

tests/libcurses: make grammar for test cases conflict-free

No functional change.

tests/libcurses: fix grammar for arrays

Previously, commas were completely ignored by the grammar. Erroring out
on invalid characters made some of the tests fail since the comma was
not recognized anymore. Add it back, but only for defining arrays. It
would have been possible to leave out the commas or make them optional,
but since the current tests do not make use of that, keep the grammar as
strict as possible.

Fix an unclosed string literal in a test. This had been wrongly
accepted before by the grammar.

tests/libcurses: add missing semicolon in grammar

tests/libcurses: add const to some function parameters

tests/libcurses: simplify code for writing to the .exp file

If a write(2) returns less than 1, it must be an error.

tests/libcurses: actually compare the stream to an absolute path

Up to now, the test command "compare /dev/null" was a no-op since the
command was only parsed but not run at all. Now run it.

This makes the test mvwin fail. That test will have to be fixed.

Comparing to /dev/null is certainly possible and may make sense,
comparing to /dev/zero is nonsense since the actual stream can never be
endless. Some tests do that nevertheless, for whatever reason.

In order to have the expected test output closer to the curses commands
that cause it, it may be a good idea to add another command
'compare_str' that would work independently of an external file and at
the same time allow the expected output to be commented and explained.
This is not possible right now since the .chk files are read exactly
as-is.

tests/libcurses: use more common abbreviations for tokens

tests/libcurses: use standard indentation for grammar rule 'arg'

tests/libcurses: extract grammar rule 'arg'

tests/libcurses: fail on syntax errors in test files

Previously, a syntax error in a test file made the test pass, which was
outright dangerous.

tests/libcurses: use a single indentation style in the test grammar

The grammar rule 'args' has been left as-is since it needs to be split
into 'args' and 'arg' first, to avoid the redundancy.

The braces in "if (create_check_file)" were misleading. It's strange that
GCC didn't reject this.

tests/libcurses: clean up test case grammar for statements

Previously, each statement ended with 'eol'. This was unnecessarily
verbose since the 'eol' is not really part of the statement, it's part
of a line.

No functional change.

tests/libcurses: fix name of grammar rule

A list of assignments is not a statement, it's several statements.

No functional change.

tests/libcurses: unary minus doesn't make sense on bool expressions

No functional change since -1 is as non-zero as 1.

Remove extra parens

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

saved_output is owned by director.c

Rototill to add complex character support:

- Add cchar command to director test language to allow a complex character
to be defined and passed to the slave.
- Removed the distinction between args and returns internally to prevent
confusing the two which leads to errors and/or crashes.
- Converted mutt_test to use the new cchar definition and fixed the
check files for the test.

Bracket strings being validated with markers to ensure sneaky whitespeace
is noticed.

branches: 1.14.16;
add proper include files.

* Add scanw family function calls as input functions

branches: 1.12.2; 1.12.8;
fix printf format strings

- Add erase and kill to the terminal attributes so we can test
fetching them
- Remove functions from the input_functions array that don't really do
input
- Re-enable the reporting of poll events after a function call
- Check that the return_type from the slave matches the expected one
- If verbose then print out the byte streams being compared in
validate_byte
- When reporting a length mismatch during a byte validation, report
the actual lengths.

- Add a delay just after the function is passed to the slave, this
gives the slave time to process the command and produce output before
the director drains output from the slave. This is particularly
important when the slave is set up for timed input because the ioctl
used by curses to set the tty parameters waits for pending output to
drain.
- make a debug statement conditional on verbose again
- make a warning about output from the slave conditional on verbose
- fix setting the minimum input delay, it should be milliseconds not
nanoseconds.
- Handle nanosleep returning early due to a signal, restart the sleep
with the remaining time.

- err -> errx mistakes
- make sure that -v does not change the program behavior
- don't set revents in poll
- add more debugging
- only call read when we have POLLIN
- don't mix I/O from master while processing input

Fix enums confusion.

Try to initialize retval to something sensible.

vis'ify the excess byte printing so that xstlproc does not barf.

- pass things in arguments instead of environment
- sanity check arguments
- disable extra data warning, old tests gave it too
- print more detailed errors
- use err/warn more
*some tests still fail; more than they used to*

Turn warns on for all tests and fix all the bugs.

branches: 1.3.2;
if you don't include the proper include files, you are going to end up
calling functions incorrectly.

Allow a NULL pointer to be passed as an argument to a call.

Add atf for libcurses with some tests

tests/libcurses: fix error handling for non-system errors

These errors are unrelated to errno. The scanf family of functions also
does not set errno.

tests/libcurses: fix error messages

tests/libcurses: clean up inclusion guards, function declarations

No functional change.

tests/libcurses: fix pipe handling in the parent process

The parent process, like the child process, needs only 2 of the 4 pipe
ends.

In verbose mode (now at testlang_parse.y:1151 and :1154), both ends of the
pipe_from_slave were examined. This looked like a typo and has been fixed
to those pipe ends that are relevant to the parent process.

tests/libcurses: add missing space after control flow keywords

tests/libcurses: fix off-by-one error in line numbers in diagnostics

I had broken this in testlang_parse.y 1.22 from 2021-02-07, when I
extracted the common 'eol' from the statements. Extracting 'eol' had
the effect that the action for the statement was run before the line
number increased.

Now the line numbers in the diagnostics are the same again as before.

For lines that end with a backslash, the reported line number is the one
from the last of these lines, not the first one, also as before. This
feature is not used by any of the current tests though.

tests/libcurses: use consistent indentation for grammar rules

tests/libcurses: extract functions 'input' and 'noinput' from grammar

tests/libcurses: indent grammar functions consistently

tests/libcurses: declare %type in grammar

It looks as if the original author just didn't know how to declare the
type of non-terminals. The explicit types in the '$' expressions were
all consistent.

No functional change.

tests/libcurses: extract function 'delay_millis' from the grammar

tests/libcurses: move function 'check' out of the grammar section

This removes the inconsistent indentation.

tests/libcurses: fix typo in license text

tests/libcurses: remove unused token DRAIN

There is a special function named 'DRAIN', but not a statement. The
function name does not need its own token.

tests/libcurses: use a single message style for diagnostics

Previously, there were several concurring styles:

$msg in line %zu of file %s
$msg line %zu of file %s
%s, %zu: $msg

All these are now replaced with "%s:%zu: $msg".

tests/libcurses: make grammar for test cases conflict-free

No functional change.

tests/libcurses: fix grammar for arrays

Previously, commas were completely ignored by the grammar. Erroring out
on invalid characters made some of the tests fail since the comma was
not recognized anymore. Add it back, but only for defining arrays. It
would have been possible to leave out the commas or make them optional,
but since the current tests do not make use of that, keep the grammar as
strict as possible.

Fix an unclosed string literal in a test. This had been wrongly
accepted before by the grammar.

tests/libcurses: add missing semicolon in grammar

tests/libcurses: add const to some function parameters

tests/libcurses: simplify code for writing to the .exp file

If a write(2) returns less than 1, it must be an error.

tests/libcurses: actually compare the stream to an absolute path

Up to now, the test command "compare /dev/null" was a no-op since the
command was only parsed but not run at all. Now run it.

This makes the test mvwin fail. That test will have to be fixed.

Comparing to /dev/null is certainly possible and may make sense,
comparing to /dev/zero is nonsense since the actual stream can never be
endless. Some tests do that nevertheless, for whatever reason.

In order to have the expected test output closer to the curses commands
that cause it, it may be a good idea to add another command
'compare_str' that would work independently of an external file and at
the same time allow the expected output to be commented and explained.
This is not possible right now since the .chk files are read exactly
as-is.

tests/libcurses: use more common abbreviations for tokens

tests/libcurses: use standard indentation for grammar rule 'arg'

tests/libcurses: extract grammar rule 'arg'

tests/libcurses: fail on syntax errors in test files

Previously, a syntax error in a test file made the test pass, which was
outright dangerous.

tests/libcurses: use a single indentation style in the test grammar

The grammar rule 'args' has been left as-is since it needs to be split
into 'args' and 'arg' first, to avoid the redundancy.

The braces in "if (create_check_file)" were misleading. It's strange that
GCC didn't reject this.

tests/libcurses: clean up test case grammar for statements

Previously, each statement ended with 'eol'. This was unnecessarily
verbose since the 'eol' is not really part of the statement, it's part
of a line.

No functional change.

tests/libcurses: fix name of grammar rule

A list of assignments is not a statement, it's several statements.

No functional change.

tests/libcurses: unary minus doesn't make sense on bool expressions

No functional change since -1 is as non-zero as 1.

Remove extra parens

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

saved_output is owned by director.c

Rototill to add complex character support:

- Add cchar command to director test language to allow a complex character
to be defined and passed to the slave.
- Removed the distinction between args and returns internally to prevent
confusing the two which leads to errors and/or crashes.
- Converted mutt_test to use the new cchar definition and fixed the
check files for the test.

Bracket strings being validated with markers to ensure sneaky whitespeace
is noticed.

branches: 1.14.16;
add proper include files.

* Add scanw family function calls as input functions

branches: 1.12.2; 1.12.8;
fix printf format strings

- Add erase and kill to the terminal attributes so we can test
fetching them
- Remove functions from the input_functions array that don't really do
input
- Re-enable the reporting of poll events after a function call
- Check that the return_type from the slave matches the expected one
- If verbose then print out the byte streams being compared in
validate_byte
- When reporting a length mismatch during a byte validation, report
the actual lengths.

- Add a delay just after the function is passed to the slave, this
gives the slave time to process the command and produce output before
the director drains output from the slave. This is particularly
important when the slave is set up for timed input because the ioctl
used by curses to set the tty parameters waits for pending output to
drain.
- make a debug statement conditional on verbose again
- make a warning about output from the slave conditional on verbose
- fix setting the minimum input delay, it should be milliseconds not
nanoseconds.
- Handle nanosleep returning early due to a signal, restart the sleep
with the remaining time.

- err -> errx mistakes
- make sure that -v does not change the program behavior
- don't set revents in poll
- add more debugging
- only call read when we have POLLIN
- don't mix I/O from master while processing input

Fix enums confusion.

Try to initialize retval to something sensible.

vis'ify the excess byte printing so that xstlproc does not barf.

- pass things in arguments instead of environment
- sanity check arguments
- disable extra data warning, old tests gave it too
- print more detailed errors
- use err/warn more
*some tests still fail; more than they used to*

Turn warns on for all tests and fix all the bugs.

branches: 1.3.2;
if you don't include the proper include files, you are going to end up
calling functions incorrectly.

Allow a NULL pointer to be passed as an argument to a call.

Add atf for libcurses with some tests

tests/libcurses: fix error messages

tests/libcurses: clean up inclusion guards, function declarations

No functional change.

tests/libcurses: fix pipe handling in the parent process

The parent process, like the child process, needs only 2 of the 4 pipe
ends.

In verbose mode (now at testlang_parse.y:1151 and :1154), both ends of the
pipe_from_slave were examined. This looked like a typo and has been fixed
to those pipe ends that are relevant to the parent process.

tests/libcurses: add missing space after control flow keywords

tests/libcurses: fix off-by-one error in line numbers in diagnostics

I had broken this in testlang_parse.y 1.22 from 2021-02-07, when I
extracted the common 'eol' from the statements. Extracting 'eol' had
the effect that the action for the statement was run before the line
number increased.

Now the line numbers in the diagnostics are the same again as before.

For lines that end with a backslash, the reported line number is the one
from the last of these lines, not the first one, also as before. This
feature is not used by any of the current tests though.

tests/libcurses: use consistent indentation for grammar rules

tests/libcurses: extract functions 'input' and 'noinput' from grammar

tests/libcurses: indent grammar functions consistently

tests/libcurses: declare %type in grammar

It looks as if the original author just didn't know how to declare the
type of non-terminals. The explicit types in the '$' expressions were
all consistent.

No functional change.

tests/libcurses: extract function 'delay_millis' from the grammar

tests/libcurses: move function 'check' out of the grammar section

This removes the inconsistent indentation.

tests/libcurses: fix typo in license text

tests/libcurses: remove unused token DRAIN

There is a special function named 'DRAIN', but not a statement. The
function name does not need its own token.

tests/libcurses: use a single message style for diagnostics

Previously, there were several concurring styles:

$msg in line %zu of file %s
$msg line %zu of file %s
%s, %zu: $msg

All these are now replaced with "%s:%zu: $msg".

tests/libcurses: make grammar for test cases conflict-free

No functional change.

tests/libcurses: fix grammar for arrays

Previously, commas were completely ignored by the grammar. Erroring out
on invalid characters made some of the tests fail since the comma was
not recognized anymore. Add it back, but only for defining arrays. It
would have been possible to leave out the commas or make them optional,
but since the current tests do not make use of that, keep the grammar as
strict as possible.

Fix an unclosed string literal in a test. This had been wrongly
accepted before by the grammar.

tests/libcurses: add missing semicolon in grammar

tests/libcurses: add const to some function parameters

tests/libcurses: simplify code for writing to the .exp file

If a write(2) returns less than 1, it must be an error.

tests/libcurses: actually compare the stream to an absolute path

Up to now, the test command "compare /dev/null" was a no-op since the
command was only parsed but not run at all. Now run it.

This makes the test mvwin fail. That test will have to be fixed.

Comparing to /dev/null is certainly possible and may make sense,
comparing to /dev/zero is nonsense since the actual stream can never be
endless. Some tests do that nevertheless, for whatever reason.

In order to have the expected test output closer to the curses commands
that cause it, it may be a good idea to add another command
'compare_str' that would work independently of an external file and at
the same time allow the expected output to be commented and explained.
This is not possible right now since the .chk files are read exactly
as-is.

tests/libcurses: use more common abbreviations for tokens

tests/libcurses: use standard indentation for grammar rule 'arg'

tests/libcurses: extract grammar rule 'arg'

tests/libcurses: fail on syntax errors in test files

Previously, a syntax error in a test file made the test pass, which was
outright dangerous.

tests/libcurses: use a single indentation style in the test grammar

The grammar rule 'args' has been left as-is since it needs to be split
into 'args' and 'arg' first, to avoid the redundancy.

The braces in "if (create_check_file)" were misleading. It's strange that
GCC didn't reject this.

tests/libcurses: clean up test case grammar for statements

Previously, each statement ended with 'eol'. This was unnecessarily
verbose since the 'eol' is not really part of the statement, it's part
of a line.

No functional change.

tests/libcurses: fix name of grammar rule

A list of assignments is not a statement, it's several statements.

No functional change.

tests/libcurses: unary minus doesn't make sense on bool expressions

No functional change since -1 is as non-zero as 1.

Remove extra parens

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

saved_output is owned by director.c

Rototill to add complex character support:

- Add cchar command to director test language to allow a complex character
to be defined and passed to the slave.
- Removed the distinction between args and returns internally to prevent
confusing the two which leads to errors and/or crashes.
- Converted mutt_test to use the new cchar definition and fixed the
check files for the test.

Bracket strings being validated with markers to ensure sneaky whitespeace
is noticed.

branches: 1.14.16;
add proper include files.

* Add scanw family function calls as input functions

branches: 1.12.2; 1.12.8;
fix printf format strings

- Add erase and kill to the terminal attributes so we can test
fetching them
- Remove functions from the input_functions array that don't really do
input
- Re-enable the reporting of poll events after a function call
- Check that the return_type from the slave matches the expected one
- If verbose then print out the byte streams being compared in
validate_byte
- When reporting a length mismatch during a byte validation, report
the actual lengths.

- Add a delay just after the function is passed to the slave, this
gives the slave time to process the command and produce output before
the director drains output from the slave. This is particularly
important when the slave is set up for timed input because the ioctl
used by curses to set the tty parameters waits for pending output to
drain.
- make a debug statement conditional on verbose again
- make a warning about output from the slave conditional on verbose
- fix setting the minimum input delay, it should be milliseconds not
nanoseconds.
- Handle nanosleep returning early due to a signal, restart the sleep
with the remaining time.

- err -> errx mistakes
- make sure that -v does not change the program behavior
- don't set revents in poll
- add more debugging
- only call read when we have POLLIN
- don't mix I/O from master while processing input

Fix enums confusion.

Try to initialize retval to something sensible.

vis'ify the excess byte printing so that xstlproc does not barf.

- pass things in arguments instead of environment
- sanity check arguments
- disable extra data warning, old tests gave it too
- print more detailed errors
- use err/warn more
*some tests still fail; more than they used to*

Turn warns on for all tests and fix all the bugs.

branches: 1.3.2;
if you don't include the proper include files, you are going to end up
calling functions incorrectly.

Allow a NULL pointer to be passed as an argument to a call.

Add atf for libcurses with some tests

tests/libcurses: add missing space after control flow keywords

tests/libcurses: fix off-by-one error in line numbers in diagnostics

I had broken this in testlang_parse.y 1.22 from 2021-02-07, when I
extracted the common 'eol' from the statements. Extracting 'eol' had
the effect that the action for the statement was run before the line
number increased.

Now the line numbers in the diagnostics are the same again as before.

For lines that end with a backslash, the reported line number is the one
from the last of these lines, not the first one, also as before. This
feature is not used by any of the current tests though.

tests/libcurses: use consistent indentation for grammar rules

tests/libcurses: extract functions 'input' and 'noinput' from grammar

tests/libcurses: indent grammar functions consistently

tests/libcurses: declare %type in grammar

It looks as if the original author just didn't know how to declare the
type of non-terminals. The explicit types in the '$' expressions were
all consistent.

No functional change.

tests/libcurses: extract function 'delay_millis' from the grammar

tests/libcurses: move function 'check' out of the grammar section

This removes the inconsistent indentation.

tests/libcurses: fix typo in license text

tests/libcurses: remove unused token DRAIN

There is a special function named 'DRAIN', but not a statement. The
function name does not need its own token.

tests/libcurses: use a single message style for diagnostics

Previously, there were several concurring styles:

$msg in line %zu of file %s
$msg line %zu of file %s
%s, %zu: $msg

All these are now replaced with "%s:%zu: $msg".

tests/libcurses: make grammar for test cases conflict-free

No functional change.

tests/libcurses: fix grammar for arrays

Previously, commas were completely ignored by the grammar. Erroring out
on invalid characters made some of the tests fail since the comma was
not recognized anymore. Add it back, but only for defining arrays. It
would have been possible to leave out the commas or make them optional,
but since the current tests do not make use of that, keep the grammar as
strict as possible.

Fix an unclosed string literal in a test. This had been wrongly
accepted before by the grammar.

tests/libcurses: add missing semicolon in grammar

tests/libcurses: add const to some function parameters

tests/libcurses: simplify code for writing to the .exp file

If a write(2) returns less than 1, it must be an error.

tests/libcurses: actually compare the stream to an absolute path

Up to now, the test command "compare /dev/null" was a no-op since the
command was only parsed but not run at all. Now run it.

This makes the test mvwin fail. That test will have to be fixed.

Comparing to /dev/null is certainly possible and may make sense,
comparing to /dev/zero is nonsense since the actual stream can never be
endless. Some tests do that nevertheless, for whatever reason.

In order to have the expected test output closer to the curses commands
that cause it, it may be a good idea to add another command
'compare_str' that would work independently of an external file and at
the same time allow the expected output to be commented and explained.
This is not possible right now since the .chk files are read exactly
as-is.

tests/libcurses: use more common abbreviations for tokens

tests/libcurses: use standard indentation for grammar rule 'arg'

tests/libcurses: extract grammar rule 'arg'

tests/libcurses: fail on syntax errors in test files

Previously, a syntax error in a test file made the test pass, which was
outright dangerous.

tests/libcurses: use a single indentation style in the test grammar

The grammar rule 'args' has been left as-is since it needs to be split
into 'args' and 'arg' first, to avoid the redundancy.

The braces in "if (create_check_file)" were misleading. It's strange that
GCC didn't reject this.

tests/libcurses: clean up test case grammar for statements

Previously, each statement ended with 'eol'. This was unnecessarily
verbose since the 'eol' is not really part of the statement, it's part
of a line.

No functional change.

tests/libcurses: fix name of grammar rule

A list of assignments is not a statement, it's several statements.

No functional change.

tests/libcurses: unary minus doesn't make sense on bool expressions

No functional change since -1 is as non-zero as 1.

Remove extra parens

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

saved_output is owned by director.c

Rototill to add complex character support:

- Add cchar command to director test language to allow a complex character
to be defined and passed to the slave.
- Removed the distinction between args and returns internally to prevent
confusing the two which leads to errors and/or crashes.
- Converted mutt_test to use the new cchar definition and fixed the
check files for the test.

Bracket strings being validated with markers to ensure sneaky whitespeace
is noticed.

branches: 1.14.16;
add proper include files.

* Add scanw family function calls as input functions

branches: 1.12.2; 1.12.8;
fix printf format strings

- Add erase and kill to the terminal attributes so we can test
fetching them
- Remove functions from the input_functions array that don't really do
input
- Re-enable the reporting of poll events after a function call
- Check that the return_type from the slave matches the expected one
- If verbose then print out the byte streams being compared in
validate_byte
- When reporting a length mismatch during a byte validation, report
the actual lengths.

- Add a delay just after the function is passed to the slave, this
gives the slave time to process the command and produce output before
the director drains output from the slave. This is particularly
important when the slave is set up for timed input because the ioctl
used by curses to set the tty parameters waits for pending output to
drain.
- make a debug statement conditional on verbose again
- make a warning about output from the slave conditional on verbose
- fix setting the minimum input delay, it should be milliseconds not
nanoseconds.
- Handle nanosleep returning early due to a signal, restart the sleep
with the remaining time.

- err -> errx mistakes
- make sure that -v does not change the program behavior
- don't set revents in poll
- add more debugging
- only call read when we have POLLIN
- don't mix I/O from master while processing input

Fix enums confusion.

Try to initialize retval to something sensible.

vis'ify the excess byte printing so that xstlproc does not barf.

- pass things in arguments instead of environment
- sanity check arguments
- disable extra data warning, old tests gave it too
- print more detailed errors
- use err/warn more
*some tests still fail; more than they used to*

Turn warns on for all tests and fix all the bugs.

branches: 1.3.2;
if you don't include the proper include files, you are going to end up
calling functions incorrectly.

Allow a NULL pointer to be passed as an argument to a call.

Add atf for libcurses with some tests

tests/libcurses: fix off-by-one error in line numbers in diagnostics

I had broken this in testlang_parse.y 1.22 from 2021-02-07, when I
extracted the common 'eol' from the statements. Extracting 'eol' had
the effect that the action for the statement was run before the line
number increased.

Now the line numbers in the diagnostics are the same again as before.

For lines that end with a backslash, the reported line number is the one
from the last of these lines, not the first one, also as before. This
feature is not used by any of the current tests though.

tests/libcurses: use consistent indentation for grammar rules

tests/libcurses: extract functions 'input' and 'noinput' from grammar

tests/libcurses: indent grammar functions consistently

tests/libcurses: declare %type in grammar

It looks as if the original author just didn't know how to declare the
type of non-terminals. The explicit types in the '$' expressions were
all consistent.

No functional change.

tests/libcurses: extract function 'delay_millis' from the grammar

tests/libcurses: move function 'check' out of the grammar section

This removes the inconsistent indentation.

tests/libcurses: fix typo in license text

tests/libcurses: remove unused token DRAIN

There is a special function named 'DRAIN', but not a statement. The
function name does not need its own token.

tests/libcurses: use a single message style for diagnostics

Previously, there were several concurring styles:

$msg in line %zu of file %s
$msg line %zu of file %s
%s, %zu: $msg

All these are now replaced with "%s:%zu: $msg".

tests/libcurses: make grammar for test cases conflict-free

No functional change.

tests/libcurses: fix grammar for arrays

Previously, commas were completely ignored by the grammar. Erroring out
on invalid characters made some of the tests fail since the comma was
not recognized anymore. Add it back, but only for defining arrays. It
would have been possible to leave out the commas or make them optional,
but since the current tests do not make use of that, keep the grammar as
strict as possible.

Fix an unclosed string literal in a test. This had been wrongly
accepted before by the grammar.

tests/libcurses: add missing semicolon in grammar

tests/libcurses: add const to some function parameters

tests/libcurses: simplify code for writing to the .exp file

If a write(2) returns less than 1, it must be an error.

tests/libcurses: actually compare the stream to an absolute path

Up to now, the test command "compare /dev/null" was a no-op since the
command was only parsed but not run at all. Now run it.

This makes the test mvwin fail. That test will have to be fixed.

Comparing to /dev/null is certainly possible and may make sense,
comparing to /dev/zero is nonsense since the actual stream can never be
endless. Some tests do that nevertheless, for whatever reason.

In order to have the expected test output closer to the curses commands
that cause it, it may be a good idea to add another command
'compare_str' that would work independently of an external file and at
the same time allow the expected output to be commented and explained.
This is not possible right now since the .chk files are read exactly
as-is.

tests/libcurses: use more common abbreviations for tokens

tests/libcurses: use standard indentation for grammar rule 'arg'

tests/libcurses: extract grammar rule 'arg'

tests/libcurses: fail on syntax errors in test files

Previously, a syntax error in a test file made the test pass, which was
outright dangerous.

tests/libcurses: use a single indentation style in the test grammar

The grammar rule 'args' has been left as-is since it needs to be split
into 'args' and 'arg' first, to avoid the redundancy.

The braces in "if (create_check_file)" were misleading. It's strange that
GCC didn't reject this.

tests/libcurses: clean up test case grammar for statements

Previously, each statement ended with 'eol'. This was unnecessarily
verbose since the 'eol' is not really part of the statement, it's part
of a line.

No functional change.

tests/libcurses: fix name of grammar rule

A list of assignments is not a statement, it's several statements.

No functional change.

tests/libcurses: unary minus doesn't make sense on bool expressions

No functional change since -1 is as non-zero as 1.

Remove extra parens

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

saved_output is owned by director.c

Rototill to add complex character support:

- Add cchar command to director test language to allow a complex character
to be defined and passed to the slave.
- Removed the distinction between args and returns internally to prevent
confusing the two which leads to errors and/or crashes.
- Converted mutt_test to use the new cchar definition and fixed the
check files for the test.

Bracket strings being validated with markers to ensure sneaky whitespeace
is noticed.

branches: 1.14.16;
add proper include files.

* Add scanw family function calls as input functions

branches: 1.12.2; 1.12.8;
fix printf format strings

- Add erase and kill to the terminal attributes so we can test
fetching them
- Remove functions from the input_functions array that don't really do
input
- Re-enable the reporting of poll events after a function call
- Check that the return_type from the slave matches the expected one
- If verbose then print out the byte streams being compared in
validate_byte
- When reporting a length mismatch during a byte validation, report
the actual lengths.

- Add a delay just after the function is passed to the slave, this
gives the slave time to process the command and produce output before
the director drains output from the slave. This is particularly
important when the slave is set up for timed input because the ioctl
used by curses to set the tty parameters waits for pending output to
drain.
- make a debug statement conditional on verbose again
- make a warning about output from the slave conditional on verbose
- fix setting the minimum input delay, it should be milliseconds not
nanoseconds.
- Handle nanosleep returning early due to a signal, restart the sleep
with the remaining time.

- err -> errx mistakes
- make sure that -v does not change the program behavior
- don't set revents in poll
- add more debugging
- only call read when we have POLLIN
- don't mix I/O from master while processing input

Fix enums confusion.

Try to initialize retval to something sensible.

vis'ify the excess byte printing so that xstlproc does not barf.

- pass things in arguments instead of environment
- sanity check arguments
- disable extra data warning, old tests gave it too
- print more detailed errors
- use err/warn more
*some tests still fail; more than they used to*

Turn warns on for all tests and fix all the bugs.

branches: 1.3.2;
if you don't include the proper include files, you are going to end up
calling functions incorrectly.

Allow a NULL pointer to be passed as an argument to a call.

Add atf for libcurses with some tests

tests/libcurses: use a single message style for diagnostics

Previously, there were several concurring styles:

$msg in line %zu of file %s
$msg line %zu of file %s
%s, %zu: $msg

All these are now replaced with "%s:%zu: $msg".

tests/libcurses: make grammar for test cases conflict-free

No functional change.

tests/libcurses: fix grammar for arrays

Previously, commas were completely ignored by the grammar. Erroring out
on invalid characters made some of the tests fail since the comma was
not recognized anymore. Add it back, but only for defining arrays. It
would have been possible to leave out the commas or make them optional,
but since the current tests do not make use of that, keep the grammar as
strict as possible.

Fix an unclosed string literal in a test. This had been wrongly
accepted before by the grammar.

tests/libcurses: add missing semicolon in grammar

tests/libcurses: add const to some function parameters

tests/libcurses: simplify code for writing to the .exp file

If a write(2) returns less than 1, it must be an error.

tests/libcurses: actually compare the stream to an absolute path

Up to now, the test command "compare /dev/null" was a no-op since the
command was only parsed but not run at all. Now run it.

This makes the test mvwin fail. That test will have to be fixed.

Comparing to /dev/null is certainly possible and may make sense,
comparing to /dev/zero is nonsense since the actual stream can never be
endless. Some tests do that nevertheless, for whatever reason.

In order to have the expected test output closer to the curses commands
that cause it, it may be a good idea to add another command
'compare_str' that would work independently of an external file and at
the same time allow the expected output to be commented and explained.
This is not possible right now since the .chk files are read exactly
as-is.

tests/libcurses: use more common abbreviations for tokens

tests/libcurses: use standard indentation for grammar rule 'arg'

tests/libcurses: extract grammar rule 'arg'

tests/libcurses: fail on syntax errors in test files

Previously, a syntax error in a test file made the test pass, which was
outright dangerous.

tests/libcurses: use a single indentation style in the test grammar

The grammar rule 'args' has been left as-is since it needs to be split
into 'args' and 'arg' first, to avoid the redundancy.

The braces in "if (create_check_file)" were misleading. It's strange that
GCC didn't reject this.

tests/libcurses: clean up test case grammar for statements

Previously, each statement ended with 'eol'. This was unnecessarily
verbose since the 'eol' is not really part of the statement, it's part
of a line.

No functional change.

tests/libcurses: fix name of grammar rule

A list of assignments is not a statement, it's several statements.

No functional change.

tests/libcurses: unary minus doesn't make sense on bool expressions

No functional change since -1 is as non-zero as 1.

Remove extra parens

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

saved_output is owned by director.c

Rototill to add complex character support:

- Add cchar command to director test language to allow a complex character
to be defined and passed to the slave.
- Removed the distinction between args and returns internally to prevent
confusing the two which leads to errors and/or crashes.
- Converted mutt_test to use the new cchar definition and fixed the
check files for the test.

Bracket strings being validated with markers to ensure sneaky whitespeace
is noticed.

branches: 1.14.16;
add proper include files.

* Add scanw family function calls as input functions

branches: 1.12.2; 1.12.8;
fix printf format strings

- Add erase and kill to the terminal attributes so we can test
fetching them
- Remove functions from the input_functions array that don't really do
input
- Re-enable the reporting of poll events after a function call
- Check that the return_type from the slave matches the expected one
- If verbose then print out the byte streams being compared in
validate_byte
- When reporting a length mismatch during a byte validation, report
the actual lengths.

- Add a delay just after the function is passed to the slave, this
gives the slave time to process the command and produce output before
the director drains output from the slave. This is particularly
important when the slave is set up for timed input because the ioctl
used by curses to set the tty parameters waits for pending output to
drain.
- make a debug statement conditional on verbose again
- make a warning about output from the slave conditional on verbose
- fix setting the minimum input delay, it should be milliseconds not
nanoseconds.
- Handle nanosleep returning early due to a signal, restart the sleep
with the remaining time.

- err -> errx mistakes
- make sure that -v does not change the program behavior
- don't set revents in poll
- add more debugging
- only call read when we have POLLIN
- don't mix I/O from master while processing input

Fix enums confusion.

Try to initialize retval to something sensible.

vis'ify the excess byte printing so that xstlproc does not barf.

- pass things in arguments instead of environment
- sanity check arguments
- disable extra data warning, old tests gave it too
- print more detailed errors
- use err/warn more
*some tests still fail; more than they used to*

Turn warns on for all tests and fix all the bugs.

branches: 1.3.2;
if you don't include the proper include files, you are going to end up
calling functions incorrectly.

Allow a NULL pointer to be passed as an argument to a call.

Add atf for libcurses with some tests

Remove extra parens

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

saved_output is owned by director.c

Rototill to add complex character support:

- Add cchar command to director test language to allow a complex character
to be defined and passed to the slave.
- Removed the distinction between args and returns internally to prevent
confusing the two which leads to errors and/or crashes.
- Converted mutt_test to use the new cchar definition and fixed the
check files for the test.

Bracket strings being validated with markers to ensure sneaky whitespeace
is noticed.

branches: 1.14.16;
add proper include files.

* Add scanw family function calls as input functions