s/occured/occurred/ in comments, log messages and man pages.

Merge thorpej-cfargs2.

branches: 1.59.8;
Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

branches: 1.58.10;
in many device attach paths, allocate memory with M_WAITOK instead of M_NOWAIT
and remove code to handle failures that can no longer happen.

use pci_intr_establish_xname() everywhere

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.55.6; 1.55.14; 1.55.16;
Add a missing ')' in the call to bswap64().

Should fix compile error of twa module for sparc and sparc64

Modularize the ld driver and all of its attachments. Ensure that all
parents are capable of rescan (or otherwise provide a means of attaching
children post-initialization).

branches: 1.53.2;
KNF. Remove extra spaces. No functional change.

branches: 1.52.2;
fix size in memset() parameter. Thanks max.

fix memset size inconsistency

branches: 1.50.2;
Add d_discard to all struct cdevsw instances I could find.

All have been set to "nodiscard"; some should get a real implementation.

branches: 1.49.2;
make pci_intr_string and eisa_intr_string take a buffer and a length
instead of relying in local static storage.

Change (mostly mechanically) every cdevsw/bdevsw I can find to use
designated initializers.

I have not built every extant kernel so I have probably broken at
least one build; however I've also found and fixed some wrong
cdevsw/bdevsw entries so even if so I think we come out ahead.

Add __diagused.

Ensure that the top level sysctl nodes (kern, vfs, net, ...) exist before
the sysctl link sets are processed, and remove redundancy.

Shaves >13kB off of an amd64 GENERIC, not to mention >1k duplicate
lines of code.

- remove unused variables
- move debugging code inside debugging sections

Comment out twa_error_table, but keep it around for documentation
purposes.

branches: 1.43.2;
fix autoconf output (don't print from the match routine).

branches: 1.42.2;
Make this compile with i386/conf/ALL

Convert twa(4) to device_t (CFATTACH_DECL_NEW).

branches: 1.40.2;
Use pci_aprint_devinfo(9) instead of pci_devinfo+aprint_{normal,naive}
where it looks straightforward, and pci_aprint_devinfo_fancy in a few
others where drivers want to supply their own device names instead
of the pcidevs generated one. More complicated cases, where names
are composed at runtime, are left alone for now. It certainly makes
sense to simplify the drivers here rather than inventing a catch-all API.
This should serve as as example for new drivers, and also ensure
consistent output in the AB_QUIET ("boot -q") case. Also, it avoids
excessive stack usage where drivers attach child devices because the
buffer for the device name is not kept on the local stack anymore.

extending vmem(9) to be able to allocated resources for it's own needs.
simplifying uvm_map handling (no special kernel entries anymore no relocking)
make malloc(9) a thin wrapper around kmem(9)
(with private interface for interrupt safety reasons)

releng@ acknowledged

branches: 1.38.2; 1.38.6;
NULL does not need a cast

Explicitly get rid of constness.

branches: 1.36.2;
Extend the workaround for the 3ware 9650 full-queue bug to a full-fledged
quirk, and use it for the 9690 as well where it's also needed. Patch by me,
problem hunted down by Jiri Novotny and Zdenek Slavet and reported in
PR 44002.

Avoid pointless use of a sysctl definition, CTL_NAMES. Clean up whitespace.

Don't pull in the whole uvm(9) API to access only PAGE_SIZE and
some other constants. These are provided by sys/param.h now.

branches: 1.33.4;
put some strange text within an "#if 0"'d section into a comment
additionally to appease picky parsers

Disable completely bogus DIAGNOSTIC check.

use device_private().
"looks good" ad@
XXX for the device_t/softc split, please check the driver that no cases have been missed.

struct device * -> device_t, no functional changes intended.

struct cfdata * -> cfdata_t, no functional changes intended.

branches: 1.28.4; 1.28.8; 1.28.10; 1.28.12;
Unbreak twa after the last two commits.

branches: 1.27.2;
Revert unintentional whitespace changes. From simonb.

Ragge says that 6.5.4 clause 2 says:

"Unless the type name specifies a void type, the type name shall specify
qualified or unqualified scalar type and the operand shall have scalar
type."

Therefore, don't cast to a union.

branches: 1.25.2;
Mention 64bit support once during boot and not every time the controller
is reset.

Replace device_lookup() with device_lookup_private() on getting softc
for future device_t/softc spilt.

Remove #if 0'd code for flashing firmware. It was never active and even
the FreeBSD version of the driver removed it.

Add support for 3ware 9650 and 9690 based on patches contributed by
Wasabi Systems.

Fix bus_dma usage to fix write operations in the light of bounce buffers.
Use the 64bit bus_dma tag for 9550+ to avoid bouncing buffers.

branches: 1.21.2;
First part of twa(4) improvements:
- more/better diagnostic messages
- dynamically allocate units in preparation for 9650+ support
- better distribute queue slots over disks according to size
- drain large request queue on 9550
- keep track of resets, will be needed for 9650.

This changes have been contributed by Wasabi Systems.

Remove clause 3 and 4 from TNF licenses

branches: 1.19.2; 1.19.4;
use aprint_*_dev and device_xname

branches: 1.18.16;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

branches: 1.17.2; 1.17.14; 1.17.16; 1.17.20;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.16.2; 1.16.4; 1.16.12;
__unused removal on arguments; approved by core.

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

Size is the third argument to memset, not the second.

Tweak the twa(4) driver so that 3ware command line utility works with it.
This includes:
- fixing various structure definitions so that the ioctl parameter match
- adding a hw.twa*.driver_version sysctl
- do not refuse multiple device openings, as the management tool will do it.
I'm not sure we are safe. FreeBSD allows multiple openings, and use the
open flag only when an attempt to detach the device is done.

branches: 1.12.2; 1.12.4; 1.12.6;
- add missing initializer
- inline comes first

PR/34292: Aaron Hodgen: twa driver incorrectly reports drive size/description

Fix all the -D*DEBUG* code that it was rotting away and did not even compile.
Mostly from Arnaud Lacombe, many thanks!

branches: 1.9.2;
Add some missing splvm()/splx() around uvm_km_* I noticed.

Updated driver, contributed by Jordan Rhody of Wasabi Systems.

Main fix is to improve reliability under heavy load and frequent
status monitoring.

Use c99 uintN_t.

Sprinkle some KNF. Still a bit more needed...

Remove some incorrect licencing goop.

Update for timecounters (s/time.tv_sec/time_second/).

branches: 1.3.2; 1.3.4; 1.3.6; 1.3.8; 1.3.10;
Add $NetBSD: ids, which work better than $netbsd: ones.

Style changes from simonb at wasabisystems dot com:

Use config_stdsubmatch() instead of our own submatch function.
Use "__inline" in header files and "inline" in .c files.
Make some local function static.

3ware 9000 driver, contributed by Wasabi Systems and written
by Jordan Rhody (based on the FreeBSD driver).

Contributed in NetBSD PR 33364.

Merge thorpej-cfargs2.

branches: 1.59.8;
Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

branches: 1.58.10;
in many device attach paths, allocate memory with M_WAITOK instead of M_NOWAIT
and remove code to handle failures that can no longer happen.

use pci_intr_establish_xname() everywhere

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.55.6; 1.55.14; 1.55.16;
Add a missing ')' in the call to bswap64().

Should fix compile error of twa module for sparc and sparc64

Modularize the ld driver and all of its attachments. Ensure that all
parents are capable of rescan (or otherwise provide a means of attaching
children post-initialization).

branches: 1.53.2;
KNF. Remove extra spaces. No functional change.

branches: 1.52.2;
fix size in memset() parameter. Thanks max.

fix memset size inconsistency

branches: 1.50.2;
Add d_discard to all struct cdevsw instances I could find.

All have been set to "nodiscard"; some should get a real implementation.

branches: 1.49.2;
make pci_intr_string and eisa_intr_string take a buffer and a length
instead of relying in local static storage.

Change (mostly mechanically) every cdevsw/bdevsw I can find to use
designated initializers.

I have not built every extant kernel so I have probably broken at
least one build; however I've also found and fixed some wrong
cdevsw/bdevsw entries so even if so I think we come out ahead.

Add __diagused.

Ensure that the top level sysctl nodes (kern, vfs, net, ...) exist before
the sysctl link sets are processed, and remove redundancy.

Shaves >13kB off of an amd64 GENERIC, not to mention >1k duplicate
lines of code.

- remove unused variables
- move debugging code inside debugging sections

Comment out twa_error_table, but keep it around for documentation
purposes.

branches: 1.43.2;
fix autoconf output (don't print from the match routine).

branches: 1.42.2;
Make this compile with i386/conf/ALL

Convert twa(4) to device_t (CFATTACH_DECL_NEW).

branches: 1.40.2;
Use pci_aprint_devinfo(9) instead of pci_devinfo+aprint_{normal,naive}
where it looks straightforward, and pci_aprint_devinfo_fancy in a few
others where drivers want to supply their own device names instead
of the pcidevs generated one. More complicated cases, where names
are composed at runtime, are left alone for now. It certainly makes
sense to simplify the drivers here rather than inventing a catch-all API.
This should serve as as example for new drivers, and also ensure
consistent output in the AB_QUIET ("boot -q") case. Also, it avoids
excessive stack usage where drivers attach child devices because the
buffer for the device name is not kept on the local stack anymore.

extending vmem(9) to be able to allocated resources for it's own needs.
simplifying uvm_map handling (no special kernel entries anymore no relocking)
make malloc(9) a thin wrapper around kmem(9)
(with private interface for interrupt safety reasons)

releng@ acknowledged

branches: 1.38.2; 1.38.6;
NULL does not need a cast

Explicitly get rid of constness.

branches: 1.36.2;
Extend the workaround for the 3ware 9650 full-queue bug to a full-fledged
quirk, and use it for the 9690 as well where it's also needed. Patch by me,
problem hunted down by Jiri Novotny and Zdenek Slavet and reported in
PR 44002.

Avoid pointless use of a sysctl definition, CTL_NAMES. Clean up whitespace.

Don't pull in the whole uvm(9) API to access only PAGE_SIZE and
some other constants. These are provided by sys/param.h now.

branches: 1.33.4;
put some strange text within an "#if 0"'d section into a comment
additionally to appease picky parsers

Disable completely bogus DIAGNOSTIC check.

use device_private().
"looks good" ad@
XXX for the device_t/softc split, please check the driver that no cases have been missed.

struct device * -> device_t, no functional changes intended.

struct cfdata * -> cfdata_t, no functional changes intended.

branches: 1.28.4; 1.28.8; 1.28.10; 1.28.12;
Unbreak twa after the last two commits.

branches: 1.27.2;
Revert unintentional whitespace changes. From simonb.

Ragge says that 6.5.4 clause 2 says:

"Unless the type name specifies a void type, the type name shall specify
qualified or unqualified scalar type and the operand shall have scalar
type."

Therefore, don't cast to a union.

branches: 1.25.2;
Mention 64bit support once during boot and not every time the controller
is reset.

Replace device_lookup() with device_lookup_private() on getting softc
for future device_t/softc spilt.

Remove #if 0'd code for flashing firmware. It was never active and even
the FreeBSD version of the driver removed it.

Add support for 3ware 9650 and 9690 based on patches contributed by
Wasabi Systems.

Fix bus_dma usage to fix write operations in the light of bounce buffers.
Use the 64bit bus_dma tag for 9550+ to avoid bouncing buffers.

branches: 1.21.2;
First part of twa(4) improvements:
- more/better diagnostic messages
- dynamically allocate units in preparation for 9650+ support
- better distribute queue slots over disks according to size
- drain large request queue on 9550
- keep track of resets, will be needed for 9650.

This changes have been contributed by Wasabi Systems.

Remove clause 3 and 4 from TNF licenses

branches: 1.19.2; 1.19.4;
use aprint_*_dev and device_xname

branches: 1.18.16;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

branches: 1.17.2; 1.17.14; 1.17.16; 1.17.20;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.16.2; 1.16.4; 1.16.12;
__unused removal on arguments; approved by core.

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

Size is the third argument to memset, not the second.

Tweak the twa(4) driver so that 3ware command line utility works with it.
This includes:
- fixing various structure definitions so that the ioctl parameter match
- adding a hw.twa*.driver_version sysctl
- do not refuse multiple device openings, as the management tool will do it.
I'm not sure we are safe. FreeBSD allows multiple openings, and use the
open flag only when an attempt to detach the device is done.

branches: 1.12.2; 1.12.4; 1.12.6;
- add missing initializer
- inline comes first

PR/34292: Aaron Hodgen: twa driver incorrectly reports drive size/description

Fix all the -D*DEBUG* code that it was rotting away and did not even compile.
Mostly from Arnaud Lacombe, many thanks!

branches: 1.9.2;
Add some missing splvm()/splx() around uvm_km_* I noticed.

Updated driver, contributed by Jordan Rhody of Wasabi Systems.

Main fix is to improve reliability under heavy load and frequent
status monitoring.

Use c99 uintN_t.

Sprinkle some KNF. Still a bit more needed...

Remove some incorrect licencing goop.

Update for timecounters (s/time.tv_sec/time_second/).

branches: 1.3.2; 1.3.4; 1.3.6; 1.3.8; 1.3.10;
Add $NetBSD: ids, which work better than $netbsd: ones.

Style changes from simonb at wasabisystems dot com:

Use config_stdsubmatch() instead of our own submatch function.
Use "__inline" in header files and "inline" in .c files.
Make some local function static.

3ware 9000 driver, contributed by Wasabi Systems and written
by Jordan Rhody (based on the FreeBSD driver).

Contributed in NetBSD PR 33364.

Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

branches: 1.58.10;
in many device attach paths, allocate memory with M_WAITOK instead of M_NOWAIT
and remove code to handle failures that can no longer happen.

use pci_intr_establish_xname() everywhere

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.55.6; 1.55.14; 1.55.16;
Add a missing ')' in the call to bswap64().

Should fix compile error of twa module for sparc and sparc64

Modularize the ld driver and all of its attachments. Ensure that all
parents are capable of rescan (or otherwise provide a means of attaching
children post-initialization).

branches: 1.53.2;
KNF. Remove extra spaces. No functional change.

branches: 1.52.2;
fix size in memset() parameter. Thanks max.

fix memset size inconsistency

branches: 1.50.2;
Add d_discard to all struct cdevsw instances I could find.

All have been set to "nodiscard"; some should get a real implementation.

branches: 1.49.2;
make pci_intr_string and eisa_intr_string take a buffer and a length
instead of relying in local static storage.

Change (mostly mechanically) every cdevsw/bdevsw I can find to use
designated initializers.

I have not built every extant kernel so I have probably broken at
least one build; however I've also found and fixed some wrong
cdevsw/bdevsw entries so even if so I think we come out ahead.

Add __diagused.

Ensure that the top level sysctl nodes (kern, vfs, net, ...) exist before
the sysctl link sets are processed, and remove redundancy.

Shaves >13kB off of an amd64 GENERIC, not to mention >1k duplicate
lines of code.

- remove unused variables
- move debugging code inside debugging sections

Comment out twa_error_table, but keep it around for documentation
purposes.

branches: 1.43.2;
fix autoconf output (don't print from the match routine).

branches: 1.42.2;
Make this compile with i386/conf/ALL

Convert twa(4) to device_t (CFATTACH_DECL_NEW).

branches: 1.40.2;
Use pci_aprint_devinfo(9) instead of pci_devinfo+aprint_{normal,naive}
where it looks straightforward, and pci_aprint_devinfo_fancy in a few
others where drivers want to supply their own device names instead
of the pcidevs generated one. More complicated cases, where names
are composed at runtime, are left alone for now. It certainly makes
sense to simplify the drivers here rather than inventing a catch-all API.
This should serve as as example for new drivers, and also ensure
consistent output in the AB_QUIET ("boot -q") case. Also, it avoids
excessive stack usage where drivers attach child devices because the
buffer for the device name is not kept on the local stack anymore.

extending vmem(9) to be able to allocated resources for it's own needs.
simplifying uvm_map handling (no special kernel entries anymore no relocking)
make malloc(9) a thin wrapper around kmem(9)
(with private interface for interrupt safety reasons)

releng@ acknowledged

branches: 1.38.2; 1.38.6;
NULL does not need a cast

Explicitly get rid of constness.

branches: 1.36.2;
Extend the workaround for the 3ware 9650 full-queue bug to a full-fledged
quirk, and use it for the 9690 as well where it's also needed. Patch by me,
problem hunted down by Jiri Novotny and Zdenek Slavet and reported in
PR 44002.

Avoid pointless use of a sysctl definition, CTL_NAMES. Clean up whitespace.

Don't pull in the whole uvm(9) API to access only PAGE_SIZE and
some other constants. These are provided by sys/param.h now.

branches: 1.33.4;
put some strange text within an "#if 0"'d section into a comment
additionally to appease picky parsers

Disable completely bogus DIAGNOSTIC check.

use device_private().
"looks good" ad@
XXX for the device_t/softc split, please check the driver that no cases have been missed.

struct device * -> device_t, no functional changes intended.

struct cfdata * -> cfdata_t, no functional changes intended.

branches: 1.28.4; 1.28.8; 1.28.10; 1.28.12;
Unbreak twa after the last two commits.

branches: 1.27.2;
Revert unintentional whitespace changes. From simonb.

Ragge says that 6.5.4 clause 2 says:

"Unless the type name specifies a void type, the type name shall specify
qualified or unqualified scalar type and the operand shall have scalar
type."

Therefore, don't cast to a union.

branches: 1.25.2;
Mention 64bit support once during boot and not every time the controller
is reset.

Replace device_lookup() with device_lookup_private() on getting softc
for future device_t/softc spilt.

Remove #if 0'd code for flashing firmware. It was never active and even
the FreeBSD version of the driver removed it.

Add support for 3ware 9650 and 9690 based on patches contributed by
Wasabi Systems.

Fix bus_dma usage to fix write operations in the light of bounce buffers.
Use the 64bit bus_dma tag for 9550+ to avoid bouncing buffers.

branches: 1.21.2;
First part of twa(4) improvements:
- more/better diagnostic messages
- dynamically allocate units in preparation for 9650+ support
- better distribute queue slots over disks according to size
- drain large request queue on 9550
- keep track of resets, will be needed for 9650.

This changes have been contributed by Wasabi Systems.

Remove clause 3 and 4 from TNF licenses

branches: 1.19.2; 1.19.4;
use aprint_*_dev and device_xname

branches: 1.18.16;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

branches: 1.17.2; 1.17.14; 1.17.16; 1.17.20;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.16.2; 1.16.4; 1.16.12;
__unused removal on arguments; approved by core.

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

Size is the third argument to memset, not the second.

Tweak the twa(4) driver so that 3ware command line utility works with it.
This includes:
- fixing various structure definitions so that the ioctl parameter match
- adding a hw.twa*.driver_version sysctl
- do not refuse multiple device openings, as the management tool will do it.
I'm not sure we are safe. FreeBSD allows multiple openings, and use the
open flag only when an attempt to detach the device is done.

branches: 1.12.2; 1.12.4; 1.12.6;
- add missing initializer
- inline comes first

PR/34292: Aaron Hodgen: twa driver incorrectly reports drive size/description

Fix all the -D*DEBUG* code that it was rotting away and did not even compile.
Mostly from Arnaud Lacombe, many thanks!

branches: 1.9.2;
Add some missing splvm()/splx() around uvm_km_* I noticed.

Updated driver, contributed by Jordan Rhody of Wasabi Systems.

Main fix is to improve reliability under heavy load and frequent
status monitoring.

Use c99 uintN_t.

Sprinkle some KNF. Still a bit more needed...

Remove some incorrect licencing goop.

Update for timecounters (s/time.tv_sec/time_second/).

branches: 1.3.2; 1.3.4; 1.3.6; 1.3.8; 1.3.10;
Add $NetBSD: ids, which work better than $netbsd: ones.

Style changes from simonb at wasabisystems dot com:

Use config_stdsubmatch() instead of our own submatch function.
Use "__inline" in header files and "inline" in .c files.
Make some local function static.

3ware 9000 driver, contributed by Wasabi Systems and written
by Jordan Rhody (based on the FreeBSD driver).

Contributed in NetBSD PR 33364.

in many device attach paths, allocate memory with M_WAITOK instead of M_NOWAIT
and remove code to handle failures that can no longer happen.

use pci_intr_establish_xname() everywhere

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.55.6; 1.55.14; 1.55.16;
Add a missing ')' in the call to bswap64().

Should fix compile error of twa module for sparc and sparc64

Modularize the ld driver and all of its attachments. Ensure that all
parents are capable of rescan (or otherwise provide a means of attaching
children post-initialization).

branches: 1.53.2;
KNF. Remove extra spaces. No functional change.

branches: 1.52.2;
fix size in memset() parameter. Thanks max.

fix memset size inconsistency

branches: 1.50.2;
Add d_discard to all struct cdevsw instances I could find.

All have been set to "nodiscard"; some should get a real implementation.

branches: 1.49.2;
make pci_intr_string and eisa_intr_string take a buffer and a length
instead of relying in local static storage.

Change (mostly mechanically) every cdevsw/bdevsw I can find to use
designated initializers.

I have not built every extant kernel so I have probably broken at
least one build; however I've also found and fixed some wrong
cdevsw/bdevsw entries so even if so I think we come out ahead.

Add __diagused.

Ensure that the top level sysctl nodes (kern, vfs, net, ...) exist before
the sysctl link sets are processed, and remove redundancy.

Shaves >13kB off of an amd64 GENERIC, not to mention >1k duplicate
lines of code.

- remove unused variables
- move debugging code inside debugging sections

Comment out twa_error_table, but keep it around for documentation
purposes.

branches: 1.43.2;
fix autoconf output (don't print from the match routine).

branches: 1.42.2;
Make this compile with i386/conf/ALL

Convert twa(4) to device_t (CFATTACH_DECL_NEW).

branches: 1.40.2;
Use pci_aprint_devinfo(9) instead of pci_devinfo+aprint_{normal,naive}
where it looks straightforward, and pci_aprint_devinfo_fancy in a few
others where drivers want to supply their own device names instead
of the pcidevs generated one. More complicated cases, where names
are composed at runtime, are left alone for now. It certainly makes
sense to simplify the drivers here rather than inventing a catch-all API.
This should serve as as example for new drivers, and also ensure
consistent output in the AB_QUIET ("boot -q") case. Also, it avoids
excessive stack usage where drivers attach child devices because the
buffer for the device name is not kept on the local stack anymore.

extending vmem(9) to be able to allocated resources for it's own needs.
simplifying uvm_map handling (no special kernel entries anymore no relocking)
make malloc(9) a thin wrapper around kmem(9)
(with private interface for interrupt safety reasons)

releng@ acknowledged

branches: 1.38.2; 1.38.6;
NULL does not need a cast

Explicitly get rid of constness.

branches: 1.36.2;
Extend the workaround for the 3ware 9650 full-queue bug to a full-fledged
quirk, and use it for the 9690 as well where it's also needed. Patch by me,
problem hunted down by Jiri Novotny and Zdenek Slavet and reported in
PR 44002.

Avoid pointless use of a sysctl definition, CTL_NAMES. Clean up whitespace.

Don't pull in the whole uvm(9) API to access only PAGE_SIZE and
some other constants. These are provided by sys/param.h now.

branches: 1.33.4;
put some strange text within an "#if 0"'d section into a comment
additionally to appease picky parsers

Disable completely bogus DIAGNOSTIC check.

use device_private().
"looks good" ad@
XXX for the device_t/softc split, please check the driver that no cases have been missed.

struct device * -> device_t, no functional changes intended.

struct cfdata * -> cfdata_t, no functional changes intended.

branches: 1.28.4; 1.28.8; 1.28.10; 1.28.12;
Unbreak twa after the last two commits.

branches: 1.27.2;
Revert unintentional whitespace changes. From simonb.

Ragge says that 6.5.4 clause 2 says:

"Unless the type name specifies a void type, the type name shall specify
qualified or unqualified scalar type and the operand shall have scalar
type."

Therefore, don't cast to a union.

branches: 1.25.2;
Mention 64bit support once during boot and not every time the controller
is reset.

Replace device_lookup() with device_lookup_private() on getting softc
for future device_t/softc spilt.

Remove #if 0'd code for flashing firmware. It was never active and even
the FreeBSD version of the driver removed it.

Add support for 3ware 9650 and 9690 based on patches contributed by
Wasabi Systems.

Fix bus_dma usage to fix write operations in the light of bounce buffers.
Use the 64bit bus_dma tag for 9550+ to avoid bouncing buffers.

branches: 1.21.2;
First part of twa(4) improvements:
- more/better diagnostic messages
- dynamically allocate units in preparation for 9650+ support
- better distribute queue slots over disks according to size
- drain large request queue on 9550
- keep track of resets, will be needed for 9650.

This changes have been contributed by Wasabi Systems.

Remove clause 3 and 4 from TNF licenses

branches: 1.19.2; 1.19.4;
use aprint_*_dev and device_xname

branches: 1.18.16;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

branches: 1.17.2; 1.17.14; 1.17.16; 1.17.20;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.16.2; 1.16.4; 1.16.12;
__unused removal on arguments; approved by core.

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

Size is the third argument to memset, not the second.

Tweak the twa(4) driver so that 3ware command line utility works with it.
This includes:
- fixing various structure definitions so that the ioctl parameter match
- adding a hw.twa*.driver_version sysctl
- do not refuse multiple device openings, as the management tool will do it.
I'm not sure we are safe. FreeBSD allows multiple openings, and use the
open flag only when an attempt to detach the device is done.

branches: 1.12.2; 1.12.4; 1.12.6;
- add missing initializer
- inline comes first

PR/34292: Aaron Hodgen: twa driver incorrectly reports drive size/description

Fix all the -D*DEBUG* code that it was rotting away and did not even compile.
Mostly from Arnaud Lacombe, many thanks!

branches: 1.9.2;
Add some missing splvm()/splx() around uvm_km_* I noticed.

Updated driver, contributed by Jordan Rhody of Wasabi Systems.

Main fix is to improve reliability under heavy load and frequent
status monitoring.

Use c99 uintN_t.

Sprinkle some KNF. Still a bit more needed...

Remove some incorrect licencing goop.

Update for timecounters (s/time.tv_sec/time_second/).

branches: 1.3.2; 1.3.4; 1.3.6; 1.3.8; 1.3.10;
Add $NetBSD: ids, which work better than $netbsd: ones.

Style changes from simonb at wasabisystems dot com:

Use config_stdsubmatch() instead of our own submatch function.
Use "__inline" in header files and "inline" in .c files.
Make some local function static.

3ware 9000 driver, contributed by Wasabi Systems and written
by Jordan Rhody (based on the FreeBSD driver).

Contributed in NetBSD PR 33364.

use pci_intr_establish_xname() everywhere

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.55.6; 1.55.14;
Add a missing ')' in the call to bswap64().

Should fix compile error of twa module for sparc and sparc64

Modularize the ld driver and all of its attachments. Ensure that all
parents are capable of rescan (or otherwise provide a means of attaching
children post-initialization).

branches: 1.53.2;
KNF. Remove extra spaces. No functional change.

branches: 1.52.2;
fix size in memset() parameter. Thanks max.

fix memset size inconsistency

branches: 1.50.2;
Add d_discard to all struct cdevsw instances I could find.

All have been set to "nodiscard"; some should get a real implementation.

branches: 1.49.2;
make pci_intr_string and eisa_intr_string take a buffer and a length
instead of relying in local static storage.

Change (mostly mechanically) every cdevsw/bdevsw I can find to use
designated initializers.

I have not built every extant kernel so I have probably broken at
least one build; however I've also found and fixed some wrong
cdevsw/bdevsw entries so even if so I think we come out ahead.

Add __diagused.

Ensure that the top level sysctl nodes (kern, vfs, net, ...) exist before
the sysctl link sets are processed, and remove redundancy.

Shaves >13kB off of an amd64 GENERIC, not to mention >1k duplicate
lines of code.

- remove unused variables
- move debugging code inside debugging sections

Comment out twa_error_table, but keep it around for documentation
purposes.

branches: 1.43.2;
fix autoconf output (don't print from the match routine).

branches: 1.42.2;
Make this compile with i386/conf/ALL

Convert twa(4) to device_t (CFATTACH_DECL_NEW).

branches: 1.40.2;
Use pci_aprint_devinfo(9) instead of pci_devinfo+aprint_{normal,naive}
where it looks straightforward, and pci_aprint_devinfo_fancy in a few
others where drivers want to supply their own device names instead
of the pcidevs generated one. More complicated cases, where names
are composed at runtime, are left alone for now. It certainly makes
sense to simplify the drivers here rather than inventing a catch-all API.
This should serve as as example for new drivers, and also ensure
consistent output in the AB_QUIET ("boot -q") case. Also, it avoids
excessive stack usage where drivers attach child devices because the
buffer for the device name is not kept on the local stack anymore.

extending vmem(9) to be able to allocated resources for it's own needs.
simplifying uvm_map handling (no special kernel entries anymore no relocking)
make malloc(9) a thin wrapper around kmem(9)
(with private interface for interrupt safety reasons)

releng@ acknowledged

branches: 1.38.2; 1.38.6;
NULL does not need a cast

Explicitly get rid of constness.

branches: 1.36.2;
Extend the workaround for the 3ware 9650 full-queue bug to a full-fledged
quirk, and use it for the 9690 as well where it's also needed. Patch by me,
problem hunted down by Jiri Novotny and Zdenek Slavet and reported in
PR 44002.

Avoid pointless use of a sysctl definition, CTL_NAMES. Clean up whitespace.

Don't pull in the whole uvm(9) API to access only PAGE_SIZE and
some other constants. These are provided by sys/param.h now.

branches: 1.33.4;
put some strange text within an "#if 0"'d section into a comment
additionally to appease picky parsers

Disable completely bogus DIAGNOSTIC check.

use device_private().
"looks good" ad@
XXX for the device_t/softc split, please check the driver that no cases have been missed.

struct device * -> device_t, no functional changes intended.

struct cfdata * -> cfdata_t, no functional changes intended.

branches: 1.28.4; 1.28.8; 1.28.10; 1.28.12;
Unbreak twa after the last two commits.

branches: 1.27.2;
Revert unintentional whitespace changes. From simonb.

Ragge says that 6.5.4 clause 2 says:

"Unless the type name specifies a void type, the type name shall specify
qualified or unqualified scalar type and the operand shall have scalar
type."

Therefore, don't cast to a union.

branches: 1.25.2;
Mention 64bit support once during boot and not every time the controller
is reset.

Replace device_lookup() with device_lookup_private() on getting softc
for future device_t/softc spilt.

Remove #if 0'd code for flashing firmware. It was never active and even
the FreeBSD version of the driver removed it.

Add support for 3ware 9650 and 9690 based on patches contributed by
Wasabi Systems.

Fix bus_dma usage to fix write operations in the light of bounce buffers.
Use the 64bit bus_dma tag for 9550+ to avoid bouncing buffers.

branches: 1.21.2;
First part of twa(4) improvements:
- more/better diagnostic messages
- dynamically allocate units in preparation for 9650+ support
- better distribute queue slots over disks according to size
- drain large request queue on 9550
- keep track of resets, will be needed for 9650.

This changes have been contributed by Wasabi Systems.

Remove clause 3 and 4 from TNF licenses

branches: 1.19.2; 1.19.4;
use aprint_*_dev and device_xname

branches: 1.18.16;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

branches: 1.17.2; 1.17.14; 1.17.16; 1.17.20;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.16.2; 1.16.4; 1.16.12;
__unused removal on arguments; approved by core.

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

Size is the third argument to memset, not the second.

Tweak the twa(4) driver so that 3ware command line utility works with it.
This includes:
- fixing various structure definitions so that the ioctl parameter match
- adding a hw.twa*.driver_version sysctl
- do not refuse multiple device openings, as the management tool will do it.
I'm not sure we are safe. FreeBSD allows multiple openings, and use the
open flag only when an attempt to detach the device is done.

branches: 1.12.2; 1.12.4; 1.12.6;
- add missing initializer
- inline comes first

PR/34292: Aaron Hodgen: twa driver incorrectly reports drive size/description

Fix all the -D*DEBUG* code that it was rotting away and did not even compile.
Mostly from Arnaud Lacombe, many thanks!

branches: 1.9.2;
Add some missing splvm()/splx() around uvm_km_* I noticed.

Updated driver, contributed by Jordan Rhody of Wasabi Systems.

Main fix is to improve reliability under heavy load and frequent
status monitoring.

Use c99 uintN_t.

Sprinkle some KNF. Still a bit more needed...

Remove some incorrect licencing goop.

Update for timecounters (s/time.tv_sec/time_second/).

branches: 1.3.2; 1.3.4; 1.3.6; 1.3.8; 1.3.10;
Add $NetBSD: ids, which work better than $netbsd: ones.

Style changes from simonb at wasabisystems dot com:

Use config_stdsubmatch() instead of our own submatch function.
Use "__inline" in header files and "inline" in .c files.
Make some local function static.

3ware 9000 driver, contributed by Wasabi Systems and written
by Jordan Rhody (based on the FreeBSD driver).

Contributed in NetBSD PR 33364.

Add a missing ')' in the call to bswap64().

Should fix compile error of twa module for sparc and sparc64

Modularize the ld driver and all of its attachments. Ensure that all
parents are capable of rescan (or otherwise provide a means of attaching
children post-initialization).

branches: 1.53.2;
KNF. Remove extra spaces. No functional change.

branches: 1.52.2;
fix size in memset() parameter. Thanks max.

fix memset size inconsistency

branches: 1.50.2;
Add d_discard to all struct cdevsw instances I could find.

All have been set to "nodiscard"; some should get a real implementation.

branches: 1.49.2;
make pci_intr_string and eisa_intr_string take a buffer and a length
instead of relying in local static storage.

Change (mostly mechanically) every cdevsw/bdevsw I can find to use
designated initializers.

I have not built every extant kernel so I have probably broken at
least one build; however I've also found and fixed some wrong
cdevsw/bdevsw entries so even if so I think we come out ahead.

Add __diagused.

Ensure that the top level sysctl nodes (kern, vfs, net, ...) exist before
the sysctl link sets are processed, and remove redundancy.

Shaves >13kB off of an amd64 GENERIC, not to mention >1k duplicate
lines of code.

- remove unused variables
- move debugging code inside debugging sections

Comment out twa_error_table, but keep it around for documentation
purposes.

branches: 1.43.2;
fix autoconf output (don't print from the match routine).

branches: 1.42.2;
Make this compile with i386/conf/ALL

Convert twa(4) to device_t (CFATTACH_DECL_NEW).

branches: 1.40.2;
Use pci_aprint_devinfo(9) instead of pci_devinfo+aprint_{normal,naive}
where it looks straightforward, and pci_aprint_devinfo_fancy in a few
others where drivers want to supply their own device names instead
of the pcidevs generated one. More complicated cases, where names
are composed at runtime, are left alone for now. It certainly makes
sense to simplify the drivers here rather than inventing a catch-all API.
This should serve as as example for new drivers, and also ensure
consistent output in the AB_QUIET ("boot -q") case. Also, it avoids
excessive stack usage where drivers attach child devices because the
buffer for the device name is not kept on the local stack anymore.

extending vmem(9) to be able to allocated resources for it's own needs.
simplifying uvm_map handling (no special kernel entries anymore no relocking)
make malloc(9) a thin wrapper around kmem(9)
(with private interface for interrupt safety reasons)

releng@ acknowledged

branches: 1.38.2; 1.38.6;
NULL does not need a cast

Explicitly get rid of constness.

branches: 1.36.2;
Extend the workaround for the 3ware 9650 full-queue bug to a full-fledged
quirk, and use it for the 9690 as well where it's also needed. Patch by me,
problem hunted down by Jiri Novotny and Zdenek Slavet and reported in
PR 44002.

Avoid pointless use of a sysctl definition, CTL_NAMES. Clean up whitespace.

Don't pull in the whole uvm(9) API to access only PAGE_SIZE and
some other constants. These are provided by sys/param.h now.

branches: 1.33.4;
put some strange text within an "#if 0"'d section into a comment
additionally to appease picky parsers

Disable completely bogus DIAGNOSTIC check.

use device_private().
"looks good" ad@
XXX for the device_t/softc split, please check the driver that no cases have been missed.

struct device * -> device_t, no functional changes intended.

struct cfdata * -> cfdata_t, no functional changes intended.

branches: 1.28.4; 1.28.8; 1.28.10; 1.28.12;
Unbreak twa after the last two commits.

branches: 1.27.2;
Revert unintentional whitespace changes. From simonb.

Ragge says that 6.5.4 clause 2 says:

"Unless the type name specifies a void type, the type name shall specify
qualified or unqualified scalar type and the operand shall have scalar
type."

Therefore, don't cast to a union.

branches: 1.25.2;
Mention 64bit support once during boot and not every time the controller
is reset.

Replace device_lookup() with device_lookup_private() on getting softc
for future device_t/softc spilt.

Remove #if 0'd code for flashing firmware. It was never active and even
the FreeBSD version of the driver removed it.

Add support for 3ware 9650 and 9690 based on patches contributed by
Wasabi Systems.

Fix bus_dma usage to fix write operations in the light of bounce buffers.
Use the 64bit bus_dma tag for 9550+ to avoid bouncing buffers.

branches: 1.21.2;
First part of twa(4) improvements:
- more/better diagnostic messages
- dynamically allocate units in preparation for 9650+ support
- better distribute queue slots over disks according to size
- drain large request queue on 9550
- keep track of resets, will be needed for 9650.

This changes have been contributed by Wasabi Systems.

Remove clause 3 and 4 from TNF licenses

branches: 1.19.2; 1.19.4;
use aprint_*_dev and device_xname

branches: 1.18.16;
machine/{bus,cpu,intr}.h -> sys/{bus,cpu,intr}.h

branches: 1.17.2; 1.17.14; 1.17.16; 1.17.20;
Kill caddr_t; there will be some MI fallout, but it will be fixed shortly.

branches: 1.16.2; 1.16.4; 1.16.12;
__unused removal on arguments; approved by core.

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

Size is the third argument to memset, not the second.

Tweak the twa(4) driver so that 3ware command line utility works with it.
This includes:
- fixing various structure definitions so that the ioctl parameter match
- adding a hw.twa*.driver_version sysctl
- do not refuse multiple device openings, as the management tool will do it.
I'm not sure we are safe. FreeBSD allows multiple openings, and use the
open flag only when an attempt to detach the device is done.

branches: 1.12.2; 1.12.4; 1.12.6;
- add missing initializer
- inline comes first

PR/34292: Aaron Hodgen: twa driver incorrectly reports drive size/description

Fix all the -D*DEBUG* code that it was rotting away and did not even compile.
Mostly from Arnaud Lacombe, many thanks!

branches: 1.9.2;
Add some missing splvm()/splx() around uvm_km_* I noticed.

Updated driver, contributed by Jordan Rhody of Wasabi Systems.

Main fix is to improve reliability under heavy load and frequent
status monitoring.

Use c99 uintN_t.

Sprinkle some KNF. Still a bit more needed...

Remove some incorrect licencing goop.

Update for timecounters (s/time.tv_sec/time_second/).

branches: 1.3.2; 1.3.4; 1.3.6; 1.3.8; 1.3.10;
Add $NetBSD: ids, which work better than $netbsd: ones.

Style changes from simonb at wasabisystems dot com:

Use config_stdsubmatch() instead of our own submatch function.
Use "__inline" in header files and "inline" in .c files.
Make some local function static.

3ware 9000 driver, contributed by Wasabi Systems and written
by Jordan Rhody (based on the FreeBSD driver).

Contributed in NetBSD PR 33364.