bwfm.c: KNF a comment (spaces->tabs)

fix simple mis-matched function prototype and definitions.

most of these are like, eg

void foo(int[2]);

with either of these

void foo(int*) { ... }
void foo(int[]) { ... }

in some cases (such as stat or utimes* calls found in our header files),
we now match standard definition from opengroup.

found by GCC 12.

Make power save mode configurable by ifconfig, now defaults to non-powersave
like other interfaces.
Remove cargo-culted check for manual roaming.

Fix bug in protocol parser that often caused fatal 'checksum error'.
Defer power save setting to interface start.
More verbose on errors.
Allow build without FDT.

Add OpenBSD to code to optionally load CLM (Country Locale Matrix) files.

if_attach and if_initialize cannot fail, don't test return value

These were originally made failable back in 2017 when if_initialize
allocated a softint in every interface for link state changes, so
that it could fail gracefully instead of panicking:

https://mail-index.NetBSD.org/source-changes/2017/10/23/msg089053.html

However, this spawned many seldom- or never-tested error branches,
which are risky to have around. And that softint in every interface
has since been replaced by a single global workqueue, because link
state changes require thread context but not low latency or high
throughput:

https://mail-index.NetBSD.org/source-changes/2020/02/06/msg113759.html

So there is no longer any reason for if_initialize to fail. (The
subroutine if_stats_init can't fail because percpu_alloc can't fail
either.)

There is a snag: the softint_establish in if_percpuq_create could
fail, potentially leading to bad consequences later on trying to use
the softint. This change doesn't introduce any new bugs because of
the snag -- if_percpuq_attach was already broken. However, the snag
can be better addressed without spawning error branches, either by
using a single softint or making softints less scarce.

(Separate commit will change the signatures of if_attach and
if_initialize to return void, scheduled to ride whatever is the next
convenient kernel bump.)

Patch and testing on amd64 and evbmips64-eb by maya@; commit message
soliloquy, and compile-testing on evbppc/i386/earmv7hf, by me.

branches: 1.30.2;
remove extra line that clearly isn't meant to be there and may trigger
uninitialised reads of variables.

branches: 1.29.4;
bwfm: Switch from pcq to pool_cache.

pcq_get is required to be serialized, but it's far from clear that it
is serialized here.

Add include guards and appropriate includes to bwfmreg.h, bwfmvar.h.

No functional change intended.

Sort #includes. Nix trailing whitespace.

No functional change intended.

move some of the patching of callbacks and other data after
ieee80211_ifattach() but before if_deferred_start_init().

may fix panic i saw in after restarting wpa_supplicant.

from mlelstv.

discussed with thorpej@, and it seems it's better to allocate the bss
alignment buffer statically (as part of softc) just to be sure to not
affect performance

reduce stack usage in bwfm_rx_event_cb(), can use KM_SLEEP because
this is called from workqueue handler (i.e. thread context)

constify, and make static where possible

Add a file type entry for CLM files.

- Refactor the firmware loading code into a set of common routines in the
core driver that understand how to find model-specific files before the
generic files. This greatly simplifies the firmware loading procedure
in each of the bus front ends. Adding additional firmware file types
(such as CLM files) much simpler.
- Make firmware image selection table-driven rather than a set of switch()
and if() statements.
- Add several additional firmware image entries.

Adopt <net/if_stats.h>.

branches: 1.19.2;
s/suport/support/

More code from OpenBSD
no need to splnet() when enqueing packets
explicit structure padding
make internal functions static

also prepare for GPIO interrupts.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2; 1.14.6;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

fix simple mis-matched function prototype and definitions.

most of these are like, eg

void foo(int[2]);

with either of these

void foo(int*) { ... }
void foo(int[]) { ... }

in some cases (such as stat or utimes* calls found in our header files),
we now match standard definition from opengroup.

found by GCC 12.

Make power save mode configurable by ifconfig, now defaults to non-powersave
like other interfaces.
Remove cargo-culted check for manual roaming.

Fix bug in protocol parser that often caused fatal 'checksum error'.
Defer power save setting to interface start.
More verbose on errors.
Allow build without FDT.

Add OpenBSD to code to optionally load CLM (Country Locale Matrix) files.

if_attach and if_initialize cannot fail, don't test return value

These were originally made failable back in 2017 when if_initialize
allocated a softint in every interface for link state changes, so
that it could fail gracefully instead of panicking:

https://mail-index.NetBSD.org/source-changes/2017/10/23/msg089053.html

However, this spawned many seldom- or never-tested error branches,
which are risky to have around. And that softint in every interface
has since been replaced by a single global workqueue, because link
state changes require thread context but not low latency or high
throughput:

https://mail-index.NetBSD.org/source-changes/2020/02/06/msg113759.html

So there is no longer any reason for if_initialize to fail. (The
subroutine if_stats_init can't fail because percpu_alloc can't fail
either.)

There is a snag: the softint_establish in if_percpuq_create could
fail, potentially leading to bad consequences later on trying to use
the softint. This change doesn't introduce any new bugs because of
the snag -- if_percpuq_attach was already broken. However, the snag
can be better addressed without spawning error branches, either by
using a single softint or making softints less scarce.

(Separate commit will change the signatures of if_attach and
if_initialize to return void, scheduled to ride whatever is the next
convenient kernel bump.)

Patch and testing on amd64 and evbmips64-eb by maya@; commit message
soliloquy, and compile-testing on evbppc/i386/earmv7hf, by me.

branches: 1.30.2;
remove extra line that clearly isn't meant to be there and may trigger
uninitialised reads of variables.

branches: 1.29.4;
bwfm: Switch from pcq to pool_cache.

pcq_get is required to be serialized, but it's far from clear that it
is serialized here.

Add include guards and appropriate includes to bwfmreg.h, bwfmvar.h.

No functional change intended.

Sort #includes. Nix trailing whitespace.

No functional change intended.

move some of the patching of callbacks and other data after
ieee80211_ifattach() but before if_deferred_start_init().

may fix panic i saw in after restarting wpa_supplicant.

from mlelstv.

discussed with thorpej@, and it seems it's better to allocate the bss
alignment buffer statically (as part of softc) just to be sure to not
affect performance

reduce stack usage in bwfm_rx_event_cb(), can use KM_SLEEP because
this is called from workqueue handler (i.e. thread context)

constify, and make static where possible

Add a file type entry for CLM files.

- Refactor the firmware loading code into a set of common routines in the
core driver that understand how to find model-specific files before the
generic files. This greatly simplifies the firmware loading procedure
in each of the bus front ends. Adding additional firmware file types
(such as CLM files) much simpler.
- Make firmware image selection table-driven rather than a set of switch()
and if() statements.
- Add several additional firmware image entries.

Adopt <net/if_stats.h>.

branches: 1.19.2;
s/suport/support/

More code from OpenBSD
no need to splnet() when enqueing packets
explicit structure padding
make internal functions static

also prepare for GPIO interrupts.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2; 1.14.6;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

Make power save mode configurable by ifconfig, now defaults to non-powersave
like other interfaces.
Remove cargo-culted check for manual roaming.

Fix bug in protocol parser that often caused fatal 'checksum error'.
Defer power save setting to interface start.
More verbose on errors.
Allow build without FDT.

Add OpenBSD to code to optionally load CLM (Country Locale Matrix) files.

if_attach and if_initialize cannot fail, don't test return value

These were originally made failable back in 2017 when if_initialize
allocated a softint in every interface for link state changes, so
that it could fail gracefully instead of panicking:

https://mail-index.NetBSD.org/source-changes/2017/10/23/msg089053.html

However, this spawned many seldom- or never-tested error branches,
which are risky to have around. And that softint in every interface
has since been replaced by a single global workqueue, because link
state changes require thread context but not low latency or high
throughput:

https://mail-index.NetBSD.org/source-changes/2020/02/06/msg113759.html

So there is no longer any reason for if_initialize to fail. (The
subroutine if_stats_init can't fail because percpu_alloc can't fail
either.)

There is a snag: the softint_establish in if_percpuq_create could
fail, potentially leading to bad consequences later on trying to use
the softint. This change doesn't introduce any new bugs because of
the snag -- if_percpuq_attach was already broken. However, the snag
can be better addressed without spawning error branches, either by
using a single softint or making softints less scarce.

(Separate commit will change the signatures of if_attach and
if_initialize to return void, scheduled to ride whatever is the next
convenient kernel bump.)

Patch and testing on amd64 and evbmips64-eb by maya@; commit message
soliloquy, and compile-testing on evbppc/i386/earmv7hf, by me.

branches: 1.30.2;
remove extra line that clearly isn't meant to be there and may trigger
uninitialised reads of variables.

branches: 1.29.4;
bwfm: Switch from pcq to pool_cache.

pcq_get is required to be serialized, but it's far from clear that it
is serialized here.

Add include guards and appropriate includes to bwfmreg.h, bwfmvar.h.

No functional change intended.

Sort #includes. Nix trailing whitespace.

No functional change intended.

move some of the patching of callbacks and other data after
ieee80211_ifattach() but before if_deferred_start_init().

may fix panic i saw in after restarting wpa_supplicant.

from mlelstv.

discussed with thorpej@, and it seems it's better to allocate the bss
alignment buffer statically (as part of softc) just to be sure to not
affect performance

reduce stack usage in bwfm_rx_event_cb(), can use KM_SLEEP because
this is called from workqueue handler (i.e. thread context)

constify, and make static where possible

Add a file type entry for CLM files.

- Refactor the firmware loading code into a set of common routines in the
core driver that understand how to find model-specific files before the
generic files. This greatly simplifies the firmware loading procedure
in each of the bus front ends. Adding additional firmware file types
(such as CLM files) much simpler.
- Make firmware image selection table-driven rather than a set of switch()
and if() statements.
- Add several additional firmware image entries.

Adopt <net/if_stats.h>.

branches: 1.19.2;
s/suport/support/

More code from OpenBSD
no need to splnet() when enqueing packets
explicit structure padding
make internal functions static

also prepare for GPIO interrupts.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2; 1.14.6;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

Add OpenBSD to code to optionally load CLM (Country Locale Matrix) files.

if_attach and if_initialize cannot fail, don't test return value

These were originally made failable back in 2017 when if_initialize
allocated a softint in every interface for link state changes, so
that it could fail gracefully instead of panicking:

https://mail-index.NetBSD.org/source-changes/2017/10/23/msg089053.html

However, this spawned many seldom- or never-tested error branches,
which are risky to have around. And that softint in every interface
has since been replaced by a single global workqueue, because link
state changes require thread context but not low latency or high
throughput:

https://mail-index.NetBSD.org/source-changes/2020/02/06/msg113759.html

So there is no longer any reason for if_initialize to fail. (The
subroutine if_stats_init can't fail because percpu_alloc can't fail
either.)

There is a snag: the softint_establish in if_percpuq_create could
fail, potentially leading to bad consequences later on trying to use
the softint. This change doesn't introduce any new bugs because of
the snag -- if_percpuq_attach was already broken. However, the snag
can be better addressed without spawning error branches, either by
using a single softint or making softints less scarce.

(Separate commit will change the signatures of if_attach and
if_initialize to return void, scheduled to ride whatever is the next
convenient kernel bump.)

Patch and testing on amd64 and evbmips64-eb by maya@; commit message
soliloquy, and compile-testing on evbppc/i386/earmv7hf, by me.

branches: 1.30.2;
remove extra line that clearly isn't meant to be there and may trigger
uninitialised reads of variables.

branches: 1.29.4;
bwfm: Switch from pcq to pool_cache.

pcq_get is required to be serialized, but it's far from clear that it
is serialized here.

Add include guards and appropriate includes to bwfmreg.h, bwfmvar.h.

No functional change intended.

Sort #includes. Nix trailing whitespace.

No functional change intended.

move some of the patching of callbacks and other data after
ieee80211_ifattach() but before if_deferred_start_init().

may fix panic i saw in after restarting wpa_supplicant.

from mlelstv.

discussed with thorpej@, and it seems it's better to allocate the bss
alignment buffer statically (as part of softc) just to be sure to not
affect performance

reduce stack usage in bwfm_rx_event_cb(), can use KM_SLEEP because
this is called from workqueue handler (i.e. thread context)

constify, and make static where possible

Add a file type entry for CLM files.

- Refactor the firmware loading code into a set of common routines in the
core driver that understand how to find model-specific files before the
generic files. This greatly simplifies the firmware loading procedure
in each of the bus front ends. Adding additional firmware file types
(such as CLM files) much simpler.
- Make firmware image selection table-driven rather than a set of switch()
and if() statements.
- Add several additional firmware image entries.

Adopt <net/if_stats.h>.

branches: 1.19.2;
s/suport/support/

More code from OpenBSD
no need to splnet() when enqueing packets
explicit structure padding
make internal functions static

also prepare for GPIO interrupts.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2; 1.14.6;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

if_attach and if_initialize cannot fail, don't test return value

These were originally made failable back in 2017 when if_initialize
allocated a softint in every interface for link state changes, so
that it could fail gracefully instead of panicking:

https://mail-index.NetBSD.org/source-changes/2017/10/23/msg089053.html

However, this spawned many seldom- or never-tested error branches,
which are risky to have around. And that softint in every interface
has since been replaced by a single global workqueue, because link
state changes require thread context but not low latency or high
throughput:

https://mail-index.NetBSD.org/source-changes/2020/02/06/msg113759.html

So there is no longer any reason for if_initialize to fail. (The
subroutine if_stats_init can't fail because percpu_alloc can't fail
either.)

There is a snag: the softint_establish in if_percpuq_create could
fail, potentially leading to bad consequences later on trying to use
the softint. This change doesn't introduce any new bugs because of
the snag -- if_percpuq_attach was already broken. However, the snag
can be better addressed without spawning error branches, either by
using a single softint or making softints less scarce.

(Separate commit will change the signatures of if_attach and
if_initialize to return void, scheduled to ride whatever is the next
convenient kernel bump.)

Patch and testing on amd64 and evbmips64-eb by maya@; commit message
soliloquy, and compile-testing on evbppc/i386/earmv7hf, by me.

remove extra line that clearly isn't meant to be there and may trigger
uninitialised reads of variables.

branches: 1.29.4;
bwfm: Switch from pcq to pool_cache.

pcq_get is required to be serialized, but it's far from clear that it
is serialized here.

Add include guards and appropriate includes to bwfmreg.h, bwfmvar.h.

No functional change intended.

Sort #includes. Nix trailing whitespace.

No functional change intended.

move some of the patching of callbacks and other data after
ieee80211_ifattach() but before if_deferred_start_init().

may fix panic i saw in after restarting wpa_supplicant.

from mlelstv.

discussed with thorpej@, and it seems it's better to allocate the bss
alignment buffer statically (as part of softc) just to be sure to not
affect performance

reduce stack usage in bwfm_rx_event_cb(), can use KM_SLEEP because
this is called from workqueue handler (i.e. thread context)

constify, and make static where possible

Add a file type entry for CLM files.

- Refactor the firmware loading code into a set of common routines in the
core driver that understand how to find model-specific files before the
generic files. This greatly simplifies the firmware loading procedure
in each of the bus front ends. Adding additional firmware file types
(such as CLM files) much simpler.
- Make firmware image selection table-driven rather than a set of switch()
and if() statements.
- Add several additional firmware image entries.

Adopt <net/if_stats.h>.

branches: 1.19.2;
s/suport/support/

More code from OpenBSD
no need to splnet() when enqueing packets
explicit structure padding
make internal functions static

also prepare for GPIO interrupts.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2; 1.14.6;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

remove extra line that clearly isn't meant to be there and may trigger
uninitialised reads of variables.

bwfm: Switch from pcq to pool_cache.

pcq_get is required to be serialized, but it's far from clear that it
is serialized here.

Add include guards and appropriate includes to bwfmreg.h, bwfmvar.h.

No functional change intended.

Sort #includes. Nix trailing whitespace.

No functional change intended.

move some of the patching of callbacks and other data after
ieee80211_ifattach() but before if_deferred_start_init().

may fix panic i saw in after restarting wpa_supplicant.

from mlelstv.

discussed with thorpej@, and it seems it's better to allocate the bss
alignment buffer statically (as part of softc) just to be sure to not
affect performance

reduce stack usage in bwfm_rx_event_cb(), can use KM_SLEEP because
this is called from workqueue handler (i.e. thread context)

constify, and make static where possible

Add a file type entry for CLM files.

- Refactor the firmware loading code into a set of common routines in the
core driver that understand how to find model-specific files before the
generic files. This greatly simplifies the firmware loading procedure
in each of the bus front ends. Adding additional firmware file types
(such as CLM files) much simpler.
- Make firmware image selection table-driven rather than a set of switch()
and if() statements.
- Add several additional firmware image entries.

Adopt <net/if_stats.h>.

branches: 1.19.2;
s/suport/support/

More code from OpenBSD
no need to splnet() when enqueing packets
explicit structure padding
make internal functions static

also prepare for GPIO interrupts.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2; 1.14.6;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

bwfm: Switch from pcq to pool_cache.

pcq_get is required to be serialized, but it's far from clear that it
is serialized here.

Add include guards and appropriate includes to bwfmreg.h, bwfmvar.h.

No functional change intended.

Sort #includes. Nix trailing whitespace.

No functional change intended.

move some of the patching of callbacks and other data after
ieee80211_ifattach() but before if_deferred_start_init().

may fix panic i saw in after restarting wpa_supplicant.

from mlelstv.

discussed with thorpej@, and it seems it's better to allocate the bss
alignment buffer statically (as part of softc) just to be sure to not
affect performance

reduce stack usage in bwfm_rx_event_cb(), can use KM_SLEEP because
this is called from workqueue handler (i.e. thread context)

constify, and make static where possible

Add a file type entry for CLM files.

- Refactor the firmware loading code into a set of common routines in the
core driver that understand how to find model-specific files before the
generic files. This greatly simplifies the firmware loading procedure
in each of the bus front ends. Adding additional firmware file types
(such as CLM files) much simpler.
- Make firmware image selection table-driven rather than a set of switch()
and if() statements.
- Add several additional firmware image entries.

Adopt <net/if_stats.h>.

branches: 1.19.2;
s/suport/support/

More code from OpenBSD
no need to splnet() when enqueing packets
explicit structure padding
make internal functions static

also prepare for GPIO interrupts.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2; 1.14.6;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

move some of the patching of callbacks and other data after
ieee80211_ifattach() but before if_deferred_start_init().

may fix panic i saw in after restarting wpa_supplicant.

from mlelstv.

discussed with thorpej@, and it seems it's better to allocate the bss
alignment buffer statically (as part of softc) just to be sure to not
affect performance

reduce stack usage in bwfm_rx_event_cb(), can use KM_SLEEP because
this is called from workqueue handler (i.e. thread context)

constify, and make static where possible

Add a file type entry for CLM files.

- Refactor the firmware loading code into a set of common routines in the
core driver that understand how to find model-specific files before the
generic files. This greatly simplifies the firmware loading procedure
in each of the bus front ends. Adding additional firmware file types
(such as CLM files) much simpler.
- Make firmware image selection table-driven rather than a set of switch()
and if() statements.
- Add several additional firmware image entries.

Adopt <net/if_stats.h>.

branches: 1.19.2;
s/suport/support/

More code from OpenBSD
no need to splnet() when enqueing packets
explicit structure padding
make internal functions static

also prepare for GPIO interrupts.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2; 1.14.6;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

discussed with thorpej@, and it seems it's better to allocate the bss
alignment buffer statically (as part of softc) just to be sure to not
affect performance

reduce stack usage in bwfm_rx_event_cb(), can use KM_SLEEP because
this is called from workqueue handler (i.e. thread context)

constify, and make static where possible

Add a file type entry for CLM files.

- Refactor the firmware loading code into a set of common routines in the
core driver that understand how to find model-specific files before the
generic files. This greatly simplifies the firmware loading procedure
in each of the bus front ends. Adding additional firmware file types
(such as CLM files) much simpler.
- Make firmware image selection table-driven rather than a set of switch()
and if() statements.
- Add several additional firmware image entries.

Adopt <net/if_stats.h>.

branches: 1.19.2;
s/suport/support/

More code from OpenBSD
no need to splnet() when enqueing packets
explicit structure padding
make internal functions static

also prepare for GPIO interrupts.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2; 1.14.6;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

Add a file type entry for CLM files.

- Refactor the firmware loading code into a set of common routines in the
core driver that understand how to find model-specific files before the
generic files. This greatly simplifies the firmware loading procedure
in each of the bus front ends. Adding additional firmware file types
(such as CLM files) much simpler.
- Make firmware image selection table-driven rather than a set of switch()
and if() statements.
- Add several additional firmware image entries.

Adopt <net/if_stats.h>.

branches: 1.19.2;
s/suport/support/

More code from OpenBSD
no need to splnet() when enqueing packets
explicit structure padding
make internal functions static

also prepare for GPIO interrupts.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2; 1.14.6;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

Adopt <net/if_stats.h>.

s/suport/support/

More code from OpenBSD
no need to splnet() when enqueing packets
explicit structure padding
make internal functions static

also prepare for GPIO interrupts.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

s/suport/support/

More code from OpenBSD
no need to splnet() when enqueing packets
explicit structure padding
make internal functions static

also prepare for GPIO interrupts.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

More code from OpenBSD
no need to splnet() when enqueing packets
explicit structure padding
make internal functions static

also prepare for GPIO interrupts.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

If firmware is connected in HT or VHT mode, report it to SIOCGIFMEDIA

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

tagging work queue as MPSAFE was premature. Revert.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

From OpenBSD:
- move event handling to workqueue
- check for save/restore capability
Tag work queue as MPsafe and increase length.
Juse use bpf_mtap(), the 802.11 encapsulation is handled by firmware.

branches: 1.14.2;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

branches: 1.12.2;
Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

branches: 1.14.2;
Initialize if_stop so suspend won't jump to NULL.

bwfm has only one tx descriptor; limit mbuf chains to one segment.

PR kern/53287

Can't use m_defrag because it always yields two segments.

Discussion on tech-net:
https://mail-index.netbsd.org/tech-net/2018/09/01/msg007031.html

Diagnosed and tested by maya.

Implement the BPF direction filter (BIOC[GS]DIRECTION). It provides backward
compatibility with BIOC[GS]SEESENT ioctl. The userland interface is the same
as FreeBSD.

This change also fixes a bug that the direction is misunderstand on some
environment by passing the direction to bpf_mtap*() instead of checking
m->m_pkthdr.rcvif.

sync with openbsd bwfm to some extent.

add a txcheck
set chip active/passive for more kinds of chips
add wrapper around setting active/passive
detect chip RAM
make bwfm_rx take an mbuf

branches: 1.10.2;
Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode

Use ieee80211_media_status

Stop the device at attach in case it was previously initialized

branches: 1.4.2;
Initialize txrate to 0 for new associations; firmware handles rate adaptation for us

If if_initialize() failed in the attach function, free resources and return.

Fix an alignment problem with scan results within an escan event

Add driver for Broadcom 802.11a/b/g/n/ac USB wireless devices, based on
the OpenBSD bwfm(4) driver.

Prepend 'sp_' to the name of the fields, so that they can easily be found
via NXR or grep.

Mmh refix previous, we also need to make sure frm[1] is there.

Fix overflow, noted by Maya.

Support promiscuous mode