ddb(9): Make db_symstr safe to use concurrently with pserialize(9).

ddb(4): Use db_num_to_strbuf in db_symstr.

Simplifies it and will make safer to use.

mv out: label into the #ifdef _KERNEL section, as it is only
referenced from there. Hopefully ubbreak buikd of usr.sbin/crash

ddb: fix function names of "noreturn" functions in stack traces.

when looking up function names for stack traces (where the addresses are the
return addresses of function calls), if the address is the first instruction
in the function, assume that the function being called is marked "noreturn"
and that the function containing the call is actually the function immediately
before the address that we looked up. to find the correct function name,
do the lookup again with (address - 1) and then add one to the offset within
the function that we find.

avoid assigning both signed and unsigned variables in the same statement.

branches: 1.66.6;
Remove a.out leftovers (unused)

branches: 1.65.4;
Handle absolute relocations coming from the kernel: preserve SHN_ABS in
the kernel and module symbols, and when relocating a symbol that has
SHN_ABS, take its value as-is and don't return an error if it equals zero.

Sent on tech-kern@.

branches: 1.64.6;
fix printf formats.

Re-indent, and factor out strlen() now that we have more space.
No functional change.

Remove bogus code in the non kernel case involving end[]. In this case
end[] is the end of the crash program symbols, so using that as the
end of the kernel symbol table is just wrong.

branches: 1.61.4; 1.61.8;
avoid compiling dead code into crash.

obsolete DB_AOUT_SYMBOLS. however, we need to leave most of the code
in db_sym.[ch] as it is used by the elf version of crash(8).

i will be cleaning up the db_sym.c code in a follow up commit to avoid
having dead code compiled.

branches: 1.59.4; 1.59.6;
Make ddb compile and work in userspace. Mostly this is comprised of three
types of changes:

- Add a few new methods to replace stuff like p_find(), CPU_INFO_FOREACH.

- Use db_read_bytes() instead of accessing kernel structures directly,
and similar changes.

- Add ifdef _KERNEL where the above hasn't been done, and an XXX comment.

branches: 1.58.4;
As discussed on tech-kern: mutex_init is too heavyweight for early bootstrap
phases, so move the initialization of the ksyms mutex back into main via
a function called ksyms_init. Rename the existing (but quite different)
ksyms_init* variations into ksyms_addsyms_elf() and ksyms_addsyms_explicit()
and adapt machdep code accordingly.

branches: 1.57.2;
don't hold locks in ddb (call ksyms_getval_unlocked()), pointed out by ad.

branches: 1.56.38; 1.56.42; 1.56.48;
TRUE -> true, FALSE -> false

Replace the Mach-derived boolean_t type with the C99 bool type. A
future commit will replace use of TRUE and FALSE with true and false.

branches: 1.54.4;
__unused removal on arguments; approved by core.

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.52.20; 1.52.22;
merge ktrace-lwp.

branches: 1.51.2;
Add lots of const.

remove stray error(1) comment.

nuke trailing whitespace

The way I handled /dev/ksyms requests vs. kernel requests was completely
broken. Inside the kernel, we always have to use the real values of the
st_name fields, and only do the math when the request comes from userland.

No need for ksyms_getval_from{kernel,userland} hack anymore. However, a
different version will be asked for pull-up in -2{,-0}, one that doesn't
break the API, that is.

Fixes PR#29133 from Jens Kessmeier.

branches: 1.47.2;
reduce db_maxoff from 256MB to 1MB, that should be plenty.

branches: 1.46.4;
kill sprintf, use snprintf

o Fix a bug in ksyms that changed the real meaning of st_name entries for
symbols, and made it impossible for the kernel to use that value, and
correctly find symbols from LKMs.
o Allow LKM users to use DDB to debug the entry function of a LKM by
loading the symbol table with the temporary name /lkmtemp/ before calling
it, and then renaming it once we know the module name.

Approved by ragge@.

fix uninitialized variable

Tweak the previous change to ensure symbol addresses are correctly
sign-extended on cpus with 64-bit registers.

long -> unsigned long, so that correct pointer is sent in function call.

branches: 1.41.2;
Don't assume sizeof(db_expr_t) == sizeof(long).
Ditto for sizeof(db_addr_t), although I don't think this
one is currently an issue.

use strlcpy [change prototype of db_symstr to pass size_t; noone seem to use it]

make couple ksym functions' arguments const

By accident db_symstr() was removed, which H�vard pointed out.
Readded now.

Mobe the SYMTAB_SPACE stuff to ksyms_init, so that it can be used without
DDB compiled-in.

db_sym_numargs() disappeared by mistake, restore it.

Teach DDB to use ksyms instead of it's own symbol table management.
Note: For a.out kernels (beware!) DDB will still use the old stuff.

make parameter 'name' for db_del_symbol_table() const

Fix signed/unsigned comparison warnings.

Dump DDB_* and SYMTAB_SPACE options to opt_ddbparam.h rather than opt_ddb.h.
These options are used in limited files but #include "opt_ddb.h" are
everywhere, and changing them caused almost full recompilation.

ANSIfy, KNF.
Make some variables and functions static when not used outside of a module.
Make variables in headers extern.
Delete the unused db_find_watchpoint() function.

Add db_symstr(), a parallel interface to db_printsym() that
writes to a string rather than outputs to the supplied printer.
This is convenient for disassemblers that are structured to
build a long string and print it later.

Perhaps db_printsym() should be changed to use this interface...

- pull in opt_kgdb.h where necessary
- replace opt_kgdb_machdep.h with opt_kgdb.h
- defparam opt_kgdb.h:
KGDB_DEV KGDB_DEVNAME KGDB_DEVADDR KGDB_DEVRATE KGDB_DEVMODE
- move from opt_ddbparam.h to opt_ddb.h:
DDB_FROMCONSOLE DDB_ONPANIC DDB_HISTORY_SIZE DDB_BREAK_CHAR SYMTAB_SPACE
- replace KGDBDEV with KGDB_DEV
- replace KGDBADDR with KGDB_DEVADDR
- replace KGDBMODE with KGDB_DEVMODE
- replace KGDBRATE with KGDB_DEVRATE
- use `9600' instead of `0x2580' for 9600 baud rate
- use correct quotes for options KGDB_DEVNAME="\"com\""
- use correct quotes for options KGDB_DEV="17*256+0"
- remove unnecessary dependancy on Makefile for kgdb_stub.o
- minor whitespace cleanup

add RCSIDs

PR/14498: Wesley Chen: Print a return after enumerating the matching symbols.

branches: 1.26.2; 1.26.6;
Add a port to IBM's PPC405GP Reference Board (the "walnut")
by Eduardo Horvath and Simon Burge of Wasabi Systems.

IBM 4xx series CPU features:
- New pmap and revised trap handler.
- Support on-chip timers, PCI controller, UARTs
- Framework for on-chip ethernet and watchdog timer.
General PowerPC features:
- Add in-kernel PPC floating point emulation
- New in{,4}_cksum that is between 1.5 and 5 times faster than the
old version depending on CPU type.
General changes:
- Kernel support for generic dbsym-style symbols.

branches: 1.25.2;
constify a little

Missed change of parameter for %r->db_format_radix() change.

Add two new functions, db_format_radix() and db_format_hex(), which supplant
the former %r and %z nonstandard kprintf strings.

Stop using DDB-specific "%n" kprintf() format specifier. This was
important as db_sym() can be called through printf() rather than
db_printf(), causing a trap as the standard %n usage is invoked.

The DDB-specific %n code should disappear from subr_prf.c soon...

branches: 1.21.2;
Interface change: db_printsym() takes a third argument, pr, a function
pointer indicating how to print the symbol. This allows db_printsym()
to called in places where db_printf() is not an appropriate output
function.

While straightforward, apologies in advance if I've introduced any minor
syntax errors; I was unable to test compilation this on all the affected
platforms.

Add a "sifting" command to ddb (named from the Sun OpenPROM command of
the same name); it searches the symbol table(s) for all symbols matching
a given substring, and prints.

Extremely useful for when you forget that critical symbol name.

Also, with /F support (cf. "ls -F") to print a char indicating the
symbol type.

Die, register, die!

branches: 1.18.2;
Fix tyop in error message.

Quote "AS IS" as in the majority of Carnegy Mellon notices.

Fix a pasto in copyright text which has been procreating like rabbits..

branches: 1.15.4;
- Make the ddb_init() interface consistent for a.out and ELF.
- Allow DDB to run-time switch for a.out or ELF symbol table support.

Pass the current DDB symbol table to X_db_symbol_values().

fix various 64-bitness bugs.
fix various db_printf format bugs (long vs. int, etc.).

DDB prototype changes.

fix paste-o

db_lastsym (cast from pointer) should be long not int. db_maxoff -> db_expr_t

Avoid printing values as "end+0x...."

db_error() does not return.

New RCS ID's, take two. they're more aesthecially pleasant, and use 'NetBSD'

Canonicalize all #includes.

branches: 1.5.2;
Add RCS identifiers, remove some completely useless RCS logs and patchkit
headers, and a few other insignificant changes.

Allow adding more than one symbol table at runtime. For LKM.

Print symbolic args and line no's in stack traces.

add explicit rcs id

branches: 1.1.1;
Initial revision

mv out: label into the #ifdef _KERNEL section, as it is only
referenced from there. Hopefully ubbreak buikd of usr.sbin/crash

ddb: fix function names of "noreturn" functions in stack traces.

when looking up function names for stack traces (where the addresses are the
return addresses of function calls), if the address is the first instruction
in the function, assume that the function being called is marked "noreturn"
and that the function containing the call is actually the function immediately
before the address that we looked up. to find the correct function name,
do the lookup again with (address - 1) and then add one to the offset within
the function that we find.

avoid assigning both signed and unsigned variables in the same statement.

branches: 1.66.6;
Remove a.out leftovers (unused)

branches: 1.65.4;
Handle absolute relocations coming from the kernel: preserve SHN_ABS in
the kernel and module symbols, and when relocating a symbol that has
SHN_ABS, take its value as-is and don't return an error if it equals zero.

Sent on tech-kern@.

branches: 1.64.6;
fix printf formats.

Re-indent, and factor out strlen() now that we have more space.
No functional change.

Remove bogus code in the non kernel case involving end[]. In this case
end[] is the end of the crash program symbols, so using that as the
end of the kernel symbol table is just wrong.

branches: 1.61.4; 1.61.8;
avoid compiling dead code into crash.

obsolete DB_AOUT_SYMBOLS. however, we need to leave most of the code
in db_sym.[ch] as it is used by the elf version of crash(8).

i will be cleaning up the db_sym.c code in a follow up commit to avoid
having dead code compiled.

branches: 1.59.4; 1.59.6;
Make ddb compile and work in userspace. Mostly this is comprised of three
types of changes:

- Add a few new methods to replace stuff like p_find(), CPU_INFO_FOREACH.

- Use db_read_bytes() instead of accessing kernel structures directly,
and similar changes.

- Add ifdef _KERNEL where the above hasn't been done, and an XXX comment.

branches: 1.58.4;
As discussed on tech-kern: mutex_init is too heavyweight for early bootstrap
phases, so move the initialization of the ksyms mutex back into main via
a function called ksyms_init. Rename the existing (but quite different)
ksyms_init* variations into ksyms_addsyms_elf() and ksyms_addsyms_explicit()
and adapt machdep code accordingly.

branches: 1.57.2;
don't hold locks in ddb (call ksyms_getval_unlocked()), pointed out by ad.

branches: 1.56.38; 1.56.42; 1.56.48;
TRUE -> true, FALSE -> false

Replace the Mach-derived boolean_t type with the C99 bool type. A
future commit will replace use of TRUE and FALSE with true and false.

branches: 1.54.4;
__unused removal on arguments; approved by core.

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.52.20; 1.52.22;
merge ktrace-lwp.

branches: 1.51.2;
Add lots of const.

remove stray error(1) comment.

nuke trailing whitespace

The way I handled /dev/ksyms requests vs. kernel requests was completely
broken. Inside the kernel, we always have to use the real values of the
st_name fields, and only do the math when the request comes from userland.

No need for ksyms_getval_from{kernel,userland} hack anymore. However, a
different version will be asked for pull-up in -2{,-0}, one that doesn't
break the API, that is.

Fixes PR#29133 from Jens Kessmeier.

branches: 1.47.2;
reduce db_maxoff from 256MB to 1MB, that should be plenty.

branches: 1.46.4;
kill sprintf, use snprintf

o Fix a bug in ksyms that changed the real meaning of st_name entries for
symbols, and made it impossible for the kernel to use that value, and
correctly find symbols from LKMs.
o Allow LKM users to use DDB to debug the entry function of a LKM by
loading the symbol table with the temporary name /lkmtemp/ before calling
it, and then renaming it once we know the module name.

Approved by ragge@.

fix uninitialized variable

Tweak the previous change to ensure symbol addresses are correctly
sign-extended on cpus with 64-bit registers.

long -> unsigned long, so that correct pointer is sent in function call.

branches: 1.41.2;
Don't assume sizeof(db_expr_t) == sizeof(long).
Ditto for sizeof(db_addr_t), although I don't think this
one is currently an issue.

use strlcpy [change prototype of db_symstr to pass size_t; noone seem to use it]

make couple ksym functions' arguments const

By accident db_symstr() was removed, which H�vard pointed out.
Readded now.

Mobe the SYMTAB_SPACE stuff to ksyms_init, so that it can be used without
DDB compiled-in.

db_sym_numargs() disappeared by mistake, restore it.

Teach DDB to use ksyms instead of it's own symbol table management.
Note: For a.out kernels (beware!) DDB will still use the old stuff.

make parameter 'name' for db_del_symbol_table() const

Fix signed/unsigned comparison warnings.

Dump DDB_* and SYMTAB_SPACE options to opt_ddbparam.h rather than opt_ddb.h.
These options are used in limited files but #include "opt_ddb.h" are
everywhere, and changing them caused almost full recompilation.

ANSIfy, KNF.
Make some variables and functions static when not used outside of a module.
Make variables in headers extern.
Delete the unused db_find_watchpoint() function.

Add db_symstr(), a parallel interface to db_printsym() that
writes to a string rather than outputs to the supplied printer.
This is convenient for disassemblers that are structured to
build a long string and print it later.

Perhaps db_printsym() should be changed to use this interface...

- pull in opt_kgdb.h where necessary
- replace opt_kgdb_machdep.h with opt_kgdb.h
- defparam opt_kgdb.h:
KGDB_DEV KGDB_DEVNAME KGDB_DEVADDR KGDB_DEVRATE KGDB_DEVMODE
- move from opt_ddbparam.h to opt_ddb.h:
DDB_FROMCONSOLE DDB_ONPANIC DDB_HISTORY_SIZE DDB_BREAK_CHAR SYMTAB_SPACE
- replace KGDBDEV with KGDB_DEV
- replace KGDBADDR with KGDB_DEVADDR
- replace KGDBMODE with KGDB_DEVMODE
- replace KGDBRATE with KGDB_DEVRATE
- use `9600' instead of `0x2580' for 9600 baud rate
- use correct quotes for options KGDB_DEVNAME="\"com\""
- use correct quotes for options KGDB_DEV="17*256+0"
- remove unnecessary dependancy on Makefile for kgdb_stub.o
- minor whitespace cleanup

add RCSIDs

PR/14498: Wesley Chen: Print a return after enumerating the matching symbols.

branches: 1.26.2; 1.26.6;
Add a port to IBM's PPC405GP Reference Board (the "walnut")
by Eduardo Horvath and Simon Burge of Wasabi Systems.

IBM 4xx series CPU features:
- New pmap and revised trap handler.
- Support on-chip timers, PCI controller, UARTs
- Framework for on-chip ethernet and watchdog timer.
General PowerPC features:
- Add in-kernel PPC floating point emulation
- New in{,4}_cksum that is between 1.5 and 5 times faster than the
old version depending on CPU type.
General changes:
- Kernel support for generic dbsym-style symbols.

branches: 1.25.2;
constify a little

Missed change of parameter for %r->db_format_radix() change.

Add two new functions, db_format_radix() and db_format_hex(), which supplant
the former %r and %z nonstandard kprintf strings.

Stop using DDB-specific "%n" kprintf() format specifier. This was
important as db_sym() can be called through printf() rather than
db_printf(), causing a trap as the standard %n usage is invoked.

The DDB-specific %n code should disappear from subr_prf.c soon...

branches: 1.21.2;
Interface change: db_printsym() takes a third argument, pr, a function
pointer indicating how to print the symbol. This allows db_printsym()
to called in places where db_printf() is not an appropriate output
function.

While straightforward, apologies in advance if I've introduced any minor
syntax errors; I was unable to test compilation this on all the affected
platforms.

Add a "sifting" command to ddb (named from the Sun OpenPROM command of
the same name); it searches the symbol table(s) for all symbols matching
a given substring, and prints.

Extremely useful for when you forget that critical symbol name.

Also, with /F support (cf. "ls -F") to print a char indicating the
symbol type.

Die, register, die!

branches: 1.18.2;
Fix tyop in error message.

Quote "AS IS" as in the majority of Carnegy Mellon notices.

Fix a pasto in copyright text which has been procreating like rabbits..

branches: 1.15.4;
- Make the ddb_init() interface consistent for a.out and ELF.
- Allow DDB to run-time switch for a.out or ELF symbol table support.

Pass the current DDB symbol table to X_db_symbol_values().

fix various 64-bitness bugs.
fix various db_printf format bugs (long vs. int, etc.).

DDB prototype changes.

fix paste-o

db_lastsym (cast from pointer) should be long not int. db_maxoff -> db_expr_t

Avoid printing values as "end+0x...."

db_error() does not return.

New RCS ID's, take two. they're more aesthecially pleasant, and use 'NetBSD'

Canonicalize all #includes.

branches: 1.5.2;
Add RCS identifiers, remove some completely useless RCS logs and patchkit
headers, and a few other insignificant changes.

Allow adding more than one symbol table at runtime. For LKM.

Print symbolic args and line no's in stack traces.

add explicit rcs id

branches: 1.1.1;
Initial revision

avoid assigning both signed and unsigned variables in the same statement.

Remove a.out leftovers (unused)

branches: 1.65.4;
Handle absolute relocations coming from the kernel: preserve SHN_ABS in
the kernel and module symbols, and when relocating a symbol that has
SHN_ABS, take its value as-is and don't return an error if it equals zero.

Sent on tech-kern@.

branches: 1.64.6;
fix printf formats.

Re-indent, and factor out strlen() now that we have more space.
No functional change.

Remove bogus code in the non kernel case involving end[]. In this case
end[] is the end of the crash program symbols, so using that as the
end of the kernel symbol table is just wrong.

branches: 1.61.4; 1.61.8;
avoid compiling dead code into crash.

obsolete DB_AOUT_SYMBOLS. however, we need to leave most of the code
in db_sym.[ch] as it is used by the elf version of crash(8).

i will be cleaning up the db_sym.c code in a follow up commit to avoid
having dead code compiled.

branches: 1.59.4; 1.59.6;
Make ddb compile and work in userspace. Mostly this is comprised of three
types of changes:

- Add a few new methods to replace stuff like p_find(), CPU_INFO_FOREACH.

- Use db_read_bytes() instead of accessing kernel structures directly,
and similar changes.

- Add ifdef _KERNEL where the above hasn't been done, and an XXX comment.

branches: 1.58.4;
As discussed on tech-kern: mutex_init is too heavyweight for early bootstrap
phases, so move the initialization of the ksyms mutex back into main via
a function called ksyms_init. Rename the existing (but quite different)
ksyms_init* variations into ksyms_addsyms_elf() and ksyms_addsyms_explicit()
and adapt machdep code accordingly.

branches: 1.57.2;
don't hold locks in ddb (call ksyms_getval_unlocked()), pointed out by ad.

branches: 1.56.38; 1.56.42; 1.56.48;
TRUE -> true, FALSE -> false

Replace the Mach-derived boolean_t type with the C99 bool type. A
future commit will replace use of TRUE and FALSE with true and false.

branches: 1.54.4;
__unused removal on arguments; approved by core.

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.52.20; 1.52.22;
merge ktrace-lwp.

branches: 1.51.2;
Add lots of const.

remove stray error(1) comment.

nuke trailing whitespace

The way I handled /dev/ksyms requests vs. kernel requests was completely
broken. Inside the kernel, we always have to use the real values of the
st_name fields, and only do the math when the request comes from userland.

No need for ksyms_getval_from{kernel,userland} hack anymore. However, a
different version will be asked for pull-up in -2{,-0}, one that doesn't
break the API, that is.

Fixes PR#29133 from Jens Kessmeier.

branches: 1.47.2;
reduce db_maxoff from 256MB to 1MB, that should be plenty.

branches: 1.46.4;
kill sprintf, use snprintf

o Fix a bug in ksyms that changed the real meaning of st_name entries for
symbols, and made it impossible for the kernel to use that value, and
correctly find symbols from LKMs.
o Allow LKM users to use DDB to debug the entry function of a LKM by
loading the symbol table with the temporary name /lkmtemp/ before calling
it, and then renaming it once we know the module name.

Approved by ragge@.

fix uninitialized variable

Tweak the previous change to ensure symbol addresses are correctly
sign-extended on cpus with 64-bit registers.

long -> unsigned long, so that correct pointer is sent in function call.

branches: 1.41.2;
Don't assume sizeof(db_expr_t) == sizeof(long).
Ditto for sizeof(db_addr_t), although I don't think this
one is currently an issue.

use strlcpy [change prototype of db_symstr to pass size_t; noone seem to use it]

make couple ksym functions' arguments const

By accident db_symstr() was removed, which H�vard pointed out.
Readded now.

Mobe the SYMTAB_SPACE stuff to ksyms_init, so that it can be used without
DDB compiled-in.

db_sym_numargs() disappeared by mistake, restore it.

Teach DDB to use ksyms instead of it's own symbol table management.
Note: For a.out kernels (beware!) DDB will still use the old stuff.

make parameter 'name' for db_del_symbol_table() const

Fix signed/unsigned comparison warnings.

Dump DDB_* and SYMTAB_SPACE options to opt_ddbparam.h rather than opt_ddb.h.
These options are used in limited files but #include "opt_ddb.h" are
everywhere, and changing them caused almost full recompilation.

ANSIfy, KNF.
Make some variables and functions static when not used outside of a module.
Make variables in headers extern.
Delete the unused db_find_watchpoint() function.

Add db_symstr(), a parallel interface to db_printsym() that
writes to a string rather than outputs to the supplied printer.
This is convenient for disassemblers that are structured to
build a long string and print it later.

Perhaps db_printsym() should be changed to use this interface...

- pull in opt_kgdb.h where necessary
- replace opt_kgdb_machdep.h with opt_kgdb.h
- defparam opt_kgdb.h:
KGDB_DEV KGDB_DEVNAME KGDB_DEVADDR KGDB_DEVRATE KGDB_DEVMODE
- move from opt_ddbparam.h to opt_ddb.h:
DDB_FROMCONSOLE DDB_ONPANIC DDB_HISTORY_SIZE DDB_BREAK_CHAR SYMTAB_SPACE
- replace KGDBDEV with KGDB_DEV
- replace KGDBADDR with KGDB_DEVADDR
- replace KGDBMODE with KGDB_DEVMODE
- replace KGDBRATE with KGDB_DEVRATE
- use `9600' instead of `0x2580' for 9600 baud rate
- use correct quotes for options KGDB_DEVNAME="\"com\""
- use correct quotes for options KGDB_DEV="17*256+0"
- remove unnecessary dependancy on Makefile for kgdb_stub.o
- minor whitespace cleanup

add RCSIDs

PR/14498: Wesley Chen: Print a return after enumerating the matching symbols.

branches: 1.26.2; 1.26.6;
Add a port to IBM's PPC405GP Reference Board (the "walnut")
by Eduardo Horvath and Simon Burge of Wasabi Systems.

IBM 4xx series CPU features:
- New pmap and revised trap handler.
- Support on-chip timers, PCI controller, UARTs
- Framework for on-chip ethernet and watchdog timer.
General PowerPC features:
- Add in-kernel PPC floating point emulation
- New in{,4}_cksum that is between 1.5 and 5 times faster than the
old version depending on CPU type.
General changes:
- Kernel support for generic dbsym-style symbols.

branches: 1.25.2;
constify a little

Missed change of parameter for %r->db_format_radix() change.

Add two new functions, db_format_radix() and db_format_hex(), which supplant
the former %r and %z nonstandard kprintf strings.

Stop using DDB-specific "%n" kprintf() format specifier. This was
important as db_sym() can be called through printf() rather than
db_printf(), causing a trap as the standard %n usage is invoked.

The DDB-specific %n code should disappear from subr_prf.c soon...

branches: 1.21.2;
Interface change: db_printsym() takes a third argument, pr, a function
pointer indicating how to print the symbol. This allows db_printsym()
to called in places where db_printf() is not an appropriate output
function.

While straightforward, apologies in advance if I've introduced any minor
syntax errors; I was unable to test compilation this on all the affected
platforms.

Add a "sifting" command to ddb (named from the Sun OpenPROM command of
the same name); it searches the symbol table(s) for all symbols matching
a given substring, and prints.

Extremely useful for when you forget that critical symbol name.

Also, with /F support (cf. "ls -F") to print a char indicating the
symbol type.

Die, register, die!

branches: 1.18.2;
Fix tyop in error message.

Quote "AS IS" as in the majority of Carnegy Mellon notices.

Fix a pasto in copyright text which has been procreating like rabbits..

branches: 1.15.4;
- Make the ddb_init() interface consistent for a.out and ELF.
- Allow DDB to run-time switch for a.out or ELF symbol table support.

Pass the current DDB symbol table to X_db_symbol_values().

fix various 64-bitness bugs.
fix various db_printf format bugs (long vs. int, etc.).

DDB prototype changes.

fix paste-o

db_lastsym (cast from pointer) should be long not int. db_maxoff -> db_expr_t

Avoid printing values as "end+0x...."

db_error() does not return.

New RCS ID's, take two. they're more aesthecially pleasant, and use 'NetBSD'

Canonicalize all #includes.

branches: 1.5.2;
Add RCS identifiers, remove some completely useless RCS logs and patchkit
headers, and a few other insignificant changes.

Allow adding more than one symbol table at runtime. For LKM.

Print symbolic args and line no's in stack traces.

add explicit rcs id

branches: 1.1.1;
Initial revision

Remove a.out leftovers (unused)

Handle absolute relocations coming from the kernel: preserve SHN_ABS in
the kernel and module symbols, and when relocating a symbol that has
SHN_ABS, take its value as-is and don't return an error if it equals zero.

Sent on tech-kern@.

branches: 1.64.6;
fix printf formats.

Re-indent, and factor out strlen() now that we have more space.
No functional change.

Remove bogus code in the non kernel case involving end[]. In this case
end[] is the end of the crash program symbols, so using that as the
end of the kernel symbol table is just wrong.

branches: 1.61.4; 1.61.8;
avoid compiling dead code into crash.

obsolete DB_AOUT_SYMBOLS. however, we need to leave most of the code
in db_sym.[ch] as it is used by the elf version of crash(8).

i will be cleaning up the db_sym.c code in a follow up commit to avoid
having dead code compiled.

branches: 1.59.4; 1.59.6;
Make ddb compile and work in userspace. Mostly this is comprised of three
types of changes:

- Add a few new methods to replace stuff like p_find(), CPU_INFO_FOREACH.

- Use db_read_bytes() instead of accessing kernel structures directly,
and similar changes.

- Add ifdef _KERNEL where the above hasn't been done, and an XXX comment.

branches: 1.58.4;
As discussed on tech-kern: mutex_init is too heavyweight for early bootstrap
phases, so move the initialization of the ksyms mutex back into main via
a function called ksyms_init. Rename the existing (but quite different)
ksyms_init* variations into ksyms_addsyms_elf() and ksyms_addsyms_explicit()
and adapt machdep code accordingly.

branches: 1.57.2;
don't hold locks in ddb (call ksyms_getval_unlocked()), pointed out by ad.

branches: 1.56.38; 1.56.42; 1.56.48;
TRUE -> true, FALSE -> false

Replace the Mach-derived boolean_t type with the C99 bool type. A
future commit will replace use of TRUE and FALSE with true and false.

branches: 1.54.4;
__unused removal on arguments; approved by core.

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.52.20; 1.52.22;
merge ktrace-lwp.

branches: 1.51.2;
Add lots of const.

remove stray error(1) comment.

nuke trailing whitespace

The way I handled /dev/ksyms requests vs. kernel requests was completely
broken. Inside the kernel, we always have to use the real values of the
st_name fields, and only do the math when the request comes from userland.

No need for ksyms_getval_from{kernel,userland} hack anymore. However, a
different version will be asked for pull-up in -2{,-0}, one that doesn't
break the API, that is.

Fixes PR#29133 from Jens Kessmeier.

branches: 1.47.2;
reduce db_maxoff from 256MB to 1MB, that should be plenty.

branches: 1.46.4;
kill sprintf, use snprintf

o Fix a bug in ksyms that changed the real meaning of st_name entries for
symbols, and made it impossible for the kernel to use that value, and
correctly find symbols from LKMs.
o Allow LKM users to use DDB to debug the entry function of a LKM by
loading the symbol table with the temporary name /lkmtemp/ before calling
it, and then renaming it once we know the module name.

Approved by ragge@.

fix uninitialized variable

Tweak the previous change to ensure symbol addresses are correctly
sign-extended on cpus with 64-bit registers.

long -> unsigned long, so that correct pointer is sent in function call.

branches: 1.41.2;
Don't assume sizeof(db_expr_t) == sizeof(long).
Ditto for sizeof(db_addr_t), although I don't think this
one is currently an issue.

use strlcpy [change prototype of db_symstr to pass size_t; noone seem to use it]

make couple ksym functions' arguments const

By accident db_symstr() was removed, which H�vard pointed out.
Readded now.

Mobe the SYMTAB_SPACE stuff to ksyms_init, so that it can be used without
DDB compiled-in.

db_sym_numargs() disappeared by mistake, restore it.

Teach DDB to use ksyms instead of it's own symbol table management.
Note: For a.out kernels (beware!) DDB will still use the old stuff.

make parameter 'name' for db_del_symbol_table() const

Fix signed/unsigned comparison warnings.

Dump DDB_* and SYMTAB_SPACE options to opt_ddbparam.h rather than opt_ddb.h.
These options are used in limited files but #include "opt_ddb.h" are
everywhere, and changing them caused almost full recompilation.

ANSIfy, KNF.
Make some variables and functions static when not used outside of a module.
Make variables in headers extern.
Delete the unused db_find_watchpoint() function.

Add db_symstr(), a parallel interface to db_printsym() that
writes to a string rather than outputs to the supplied printer.
This is convenient for disassemblers that are structured to
build a long string and print it later.

Perhaps db_printsym() should be changed to use this interface...

- pull in opt_kgdb.h where necessary
- replace opt_kgdb_machdep.h with opt_kgdb.h
- defparam opt_kgdb.h:
KGDB_DEV KGDB_DEVNAME KGDB_DEVADDR KGDB_DEVRATE KGDB_DEVMODE
- move from opt_ddbparam.h to opt_ddb.h:
DDB_FROMCONSOLE DDB_ONPANIC DDB_HISTORY_SIZE DDB_BREAK_CHAR SYMTAB_SPACE
- replace KGDBDEV with KGDB_DEV
- replace KGDBADDR with KGDB_DEVADDR
- replace KGDBMODE with KGDB_DEVMODE
- replace KGDBRATE with KGDB_DEVRATE
- use `9600' instead of `0x2580' for 9600 baud rate
- use correct quotes for options KGDB_DEVNAME="\"com\""
- use correct quotes for options KGDB_DEV="17*256+0"
- remove unnecessary dependancy on Makefile for kgdb_stub.o
- minor whitespace cleanup

add RCSIDs

PR/14498: Wesley Chen: Print a return after enumerating the matching symbols.

branches: 1.26.2; 1.26.6;
Add a port to IBM's PPC405GP Reference Board (the "walnut")
by Eduardo Horvath and Simon Burge of Wasabi Systems.

IBM 4xx series CPU features:
- New pmap and revised trap handler.
- Support on-chip timers, PCI controller, UARTs
- Framework for on-chip ethernet and watchdog timer.
General PowerPC features:
- Add in-kernel PPC floating point emulation
- New in{,4}_cksum that is between 1.5 and 5 times faster than the
old version depending on CPU type.
General changes:
- Kernel support for generic dbsym-style symbols.

branches: 1.25.2;
constify a little

Missed change of parameter for %r->db_format_radix() change.

Add two new functions, db_format_radix() and db_format_hex(), which supplant
the former %r and %z nonstandard kprintf strings.

Stop using DDB-specific "%n" kprintf() format specifier. This was
important as db_sym() can be called through printf() rather than
db_printf(), causing a trap as the standard %n usage is invoked.

The DDB-specific %n code should disappear from subr_prf.c soon...

branches: 1.21.2;
Interface change: db_printsym() takes a third argument, pr, a function
pointer indicating how to print the symbol. This allows db_printsym()
to called in places where db_printf() is not an appropriate output
function.

While straightforward, apologies in advance if I've introduced any minor
syntax errors; I was unable to test compilation this on all the affected
platforms.

Add a "sifting" command to ddb (named from the Sun OpenPROM command of
the same name); it searches the symbol table(s) for all symbols matching
a given substring, and prints.

Extremely useful for when you forget that critical symbol name.

Also, with /F support (cf. "ls -F") to print a char indicating the
symbol type.

Die, register, die!

branches: 1.18.2;
Fix tyop in error message.

Quote "AS IS" as in the majority of Carnegy Mellon notices.

Fix a pasto in copyright text which has been procreating like rabbits..

branches: 1.15.4;
- Make the ddb_init() interface consistent for a.out and ELF.
- Allow DDB to run-time switch for a.out or ELF symbol table support.

Pass the current DDB symbol table to X_db_symbol_values().

fix various 64-bitness bugs.
fix various db_printf format bugs (long vs. int, etc.).

DDB prototype changes.

fix paste-o

db_lastsym (cast from pointer) should be long not int. db_maxoff -> db_expr_t

Avoid printing values as "end+0x...."

db_error() does not return.

New RCS ID's, take two. they're more aesthecially pleasant, and use 'NetBSD'

Canonicalize all #includes.

branches: 1.5.2;
Add RCS identifiers, remove some completely useless RCS logs and patchkit
headers, and a few other insignificant changes.

Allow adding more than one symbol table at runtime. For LKM.

Print symbolic args and line no's in stack traces.

add explicit rcs id

branches: 1.1.1;
Initial revision

Handle absolute relocations coming from the kernel: preserve SHN_ABS in
the kernel and module symbols, and when relocating a symbol that has
SHN_ABS, take its value as-is and don't return an error if it equals zero.

Sent on tech-kern@.

branches: 1.64.6;
fix printf formats.

Re-indent, and factor out strlen() now that we have more space.
No functional change.

Remove bogus code in the non kernel case involving end[]. In this case
end[] is the end of the crash program symbols, so using that as the
end of the kernel symbol table is just wrong.

branches: 1.61.4; 1.61.8;
avoid compiling dead code into crash.

obsolete DB_AOUT_SYMBOLS. however, we need to leave most of the code
in db_sym.[ch] as it is used by the elf version of crash(8).

i will be cleaning up the db_sym.c code in a follow up commit to avoid
having dead code compiled.

branches: 1.59.4; 1.59.6;
Make ddb compile and work in userspace. Mostly this is comprised of three
types of changes:

- Add a few new methods to replace stuff like p_find(), CPU_INFO_FOREACH.

- Use db_read_bytes() instead of accessing kernel structures directly,
and similar changes.

- Add ifdef _KERNEL where the above hasn't been done, and an XXX comment.

branches: 1.58.4;
As discussed on tech-kern: mutex_init is too heavyweight for early bootstrap
phases, so move the initialization of the ksyms mutex back into main via
a function called ksyms_init. Rename the existing (but quite different)
ksyms_init* variations into ksyms_addsyms_elf() and ksyms_addsyms_explicit()
and adapt machdep code accordingly.

branches: 1.57.2;
don't hold locks in ddb (call ksyms_getval_unlocked()), pointed out by ad.

branches: 1.56.38; 1.56.42; 1.56.48;
TRUE -> true, FALSE -> false

Replace the Mach-derived boolean_t type with the C99 bool type. A
future commit will replace use of TRUE and FALSE with true and false.

branches: 1.54.4;
__unused removal on arguments; approved by core.

- sprinkle __unused on function decls.
- fix a couple of unused bugs
- no more -Wno-unused for i386

branches: 1.52.20; 1.52.22;
merge ktrace-lwp.

branches: 1.51.2;
Add lots of const.

remove stray error(1) comment.

nuke trailing whitespace

The way I handled /dev/ksyms requests vs. kernel requests was completely
broken. Inside the kernel, we always have to use the real values of the
st_name fields, and only do the math when the request comes from userland.

No need for ksyms_getval_from{kernel,userland} hack anymore. However, a
different version will be asked for pull-up in -2{,-0}, one that doesn't
break the API, that is.

Fixes PR#29133 from Jens Kessmeier.

branches: 1.47.2;
reduce db_maxoff from 256MB to 1MB, that should be plenty.

branches: 1.46.4;
kill sprintf, use snprintf

o Fix a bug in ksyms that changed the real meaning of st_name entries for
symbols, and made it impossible for the kernel to use that value, and
correctly find symbols from LKMs.
o Allow LKM users to use DDB to debug the entry function of a LKM by
loading the symbol table with the temporary name /lkmtemp/ before calling
it, and then renaming it once we know the module name.

Approved by ragge@.

fix uninitialized variable

Tweak the previous change to ensure symbol addresses are correctly
sign-extended on cpus with 64-bit registers.

long -> unsigned long, so that correct pointer is sent in function call.

branches: 1.41.2;
Don't assume sizeof(db_expr_t) == sizeof(long).
Ditto for sizeof(db_addr_t), although I don't think this
one is currently an issue.

use strlcpy [change prototype of db_symstr to pass size_t; noone seem to use it]

make couple ksym functions' arguments const

By accident db_symstr() was removed, which H�vard pointed out.
Readded now.

Mobe the SYMTAB_SPACE stuff to ksyms_init, so that it can be used without
DDB compiled-in.

db_sym_numargs() disappeared by mistake, restore it.

Teach DDB to use ksyms instead of it's own symbol table management.
Note: For a.out kernels (beware!) DDB will still use the old stuff.

make parameter 'name' for db_del_symbol_table() const

Fix signed/unsigned comparison warnings.

Dump DDB_* and SYMTAB_SPACE options to opt_ddbparam.h rather than opt_ddb.h.
These options are used in limited files but #include "opt_ddb.h" are
everywhere, and changing them caused almost full recompilation.

ANSIfy, KNF.
Make some variables and functions static when not used outside of a module.
Make variables in headers extern.
Delete the unused db_find_watchpoint() function.

Add db_symstr(), a parallel interface to db_printsym() that
writes to a string rather than outputs to the supplied printer.
This is convenient for disassemblers that are structured to
build a long string and print it later.

Perhaps db_printsym() should be changed to use this interface...

- pull in opt_kgdb.h where necessary
- replace opt_kgdb_machdep.h with opt_kgdb.h
- defparam opt_kgdb.h:
KGDB_DEV KGDB_DEVNAME KGDB_DEVADDR KGDB_DEVRATE KGDB_DEVMODE
- move from opt_ddbparam.h to opt_ddb.h:
DDB_FROMCONSOLE DDB_ONPANIC DDB_HISTORY_SIZE DDB_BREAK_CHAR SYMTAB_SPACE
- replace KGDBDEV with KGDB_DEV
- replace KGDBADDR with KGDB_DEVADDR
- replace KGDBMODE with KGDB_DEVMODE
- replace KGDBRATE with KGDB_DEVRATE
- use `9600' instead of `0x2580' for 9600 baud rate
- use correct quotes for options KGDB_DEVNAME="\"com\""
- use correct quotes for options KGDB_DEV="17*256+0"
- remove unnecessary dependancy on Makefile for kgdb_stub.o
- minor whitespace cleanup

add RCSIDs

PR/14498: Wesley Chen: Print a return after enumerating the matching symbols.

branches: 1.26.2; 1.26.6;
Add a port to IBM's PPC405GP Reference Board (the "walnut")
by Eduardo Horvath and Simon Burge of Wasabi Systems.

IBM 4xx series CPU features:
- New pmap and revised trap handler.
- Support on-chip timers, PCI controller, UARTs
- Framework for on-chip ethernet and watchdog timer.
General PowerPC features:
- Add in-kernel PPC floating point emulation
- New in{,4}_cksum that is between 1.5 and 5 times faster than the
old version depending on CPU type.
General changes:
- Kernel support for generic dbsym-style symbols.

branches: 1.25.2;
constify a little

Missed change of parameter for %r->db_format_radix() change.

Add two new functions, db_format_radix() and db_format_hex(), which supplant
the former %r and %z nonstandard kprintf strings.

Stop using DDB-specific "%n" kprintf() format specifier. This was
important as db_sym() can be called through printf() rather than
db_printf(), causing a trap as the standard %n usage is invoked.

The DDB-specific %n code should disappear from subr_prf.c soon...

branches: 1.21.2;
Interface change: db_printsym() takes a third argument, pr, a function
pointer indicating how to print the symbol. This allows db_printsym()
to called in places where db_printf() is not an appropriate output
function.

While straightforward, apologies in advance if I've introduced any minor
syntax errors; I was unable to test compilation this on all the affected
platforms.

Add a "sifting" command to ddb (named from the Sun OpenPROM command of
the same name); it searches the symbol table(s) for all symbols matching
a given substring, and prints.

Extremely useful for when you forget that critical symbol name.

Also, with /F support (cf. "ls -F") to print a char indicating the
symbol type.

Die, register, die!

branches: 1.18.2;
Fix tyop in error message.

Quote "AS IS" as in the majority of Carnegy Mellon notices.

Fix a pasto in copyright text which has been procreating like rabbits..

branches: 1.15.4;
- Make the ddb_init() interface consistent for a.out and ELF.
- Allow DDB to run-time switch for a.out or ELF symbol table support.

Pass the current DDB symbol table to X_db_symbol_values().

fix various 64-bitness bugs.
fix various db_printf format bugs (long vs. int, etc.).

DDB prototype changes.

fix paste-o

db_lastsym (cast from pointer) should be long not int. db_maxoff -> db_expr_t

Avoid printing values as "end+0x...."

db_error() does not return.

New RCS ID's, take two. they're more aesthecially pleasant, and use 'NetBSD'

Canonicalize all #includes.

branches: 1.5.2;
Add RCS identifiers, remove some completely useless RCS logs and patchkit
headers, and a few other insignificant changes.

Allow adding more than one symbol table at runtime. For LKM.

Print symbolic args and line no's in stack traces.

add explicit rcs id

branches: 1.1.1;
Initial revision