yet another tsleep/wakeup -> cv_*

branches: 1.29.2;
Merge thorpej-cfargs2.

branches: 1.28.2; 1.28.8;
Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

branches: 1.27.2;
Convert to intr_establish_xname().

branches: 1.26.2;
Adapt to new proplib API

Adapt to new proplib API

Cleanup i2c bus acquire / release, centralizing all of the logic into
iic_acquire_bus() / iic_release_bus(). "acquire" and "release" hooks
no longer need to be provided by back-end controller drivers (only if
they need special handling, e.g. powering on the i2c controller).
This results in the removal of a bunch of rendundant code from each
back-end controller driver.

Assert that we are not in hard interrupt context in iic_acquire_bus(),
iic_exec(), and iic_release_bus().

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.22.2; 1.22.4;
direct configure i2c devices

zero the i2c_attach_args structure before filling it in.
fixes occasional crashes in iic_attach().

branches: 1.20.2;
if we get garbage from the RTC try again a couple times
this seems to happen more frequently when the PRAM battery goes bad

remove various set-but-unused variables.

Strip redundant parenthesis.

branches: 1.17.2; 1.17.12; 1.17.16;
#include <sys/bus.h> instead of <machine/bus.h>.

struct device * -> device_t
struct cfdata * -> cfdata_t
use device accessors, use device_private.
some softc/device_t splits (macppc needs a bunch more)
aprint*_dev used considerably more

branches: 1.15.10;
Remove `volatile' qualifier from argument types of
struct timeval passed to todr_gettime(9) and todr_settime(9).
We no longer have an ancient and volatile struct timeval `time'
global since we have switched to MI timercounter(9) on all port.

XXX1: some of these RTC drivers still assume 32bit time_t
XXX2: some of these should be rewritten to use todr_[gs]ettime_ymdhms()
XXX3: todr(9) man page doesn't mention todr_[gs]ettime_ymdhms()

Ansify function definitions w/o arguments. Generated with sed.

branches: 1.13.2;
Return error status if an attempt is made to use the quick_{read,write}
i2c protocols, since we don't (yet) know how to make the controller do it.

fix format instead of casting wildly

don't truncate the print.

deal with 64bit time_t
Noticed by Wojciech Galazka

Fix attach messages. (extra colons, misplaced newline etc.)

branches: 1.8.4; 1.8.6; 1.8.8;
struct device * -> device_t

branches: 1.7.2;
Convert to new 2 clause license

branches: 1.6.12; 1.6.14; 1.6.16;
lockmgr -> mutex

branches: 1.5.2;
Convert macppc to shared ofw_autoconf.c. Compile tested only.

branches: 1.4.2;
Merge the ppcoea-renovation branch to HEAD.

This branch was a major cleanup and rototill of many of the various OEA
cpu based PPC ports that focused on sharing as much code as possible
between the various ports to eliminate near-identical copies of files in
every tree. Additionally there is a new PIC system that unifies the
interface to interrupt code for all different OEA ppc arches. The work
for this branch was done by a variety of people, too long to list here.

TODO:
bebox still needs work to complete the transition to -renovation.
ofppc still needs a bunch of work, which I will be looking at.
ev64260 still needs to be renovated
amigappc was not attempted.

NOTES:
pmppc was removed as an arch, and moved to a evbppc target.

branches: 1.3.4; 1.3.8; 1.3.12; 1.3.16; 1.3.24; 1.3.26; 1.3.28; 1.3.30;
don't use IPL_HIGH

- don't go CUDA_IDLE before calling message handlers, that way we force all
writes they might issue to be delayed which keeps us from deadlocking
- don't splhigh() in cuda_intr() - usually we're there already. Instead do
the splhigh()/splx() dance when we're polling
- remove some leftover debugging gunk

branches: 1.1.2;
new drivers for pmu and cuda

Merge thorpej-cfargs2.

branches: 1.28.2; 1.28.8;
Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

branches: 1.27.2;
Convert to intr_establish_xname().

branches: 1.26.2;
Adapt to new proplib API

Adapt to new proplib API

Cleanup i2c bus acquire / release, centralizing all of the logic into
iic_acquire_bus() / iic_release_bus(). "acquire" and "release" hooks
no longer need to be provided by back-end controller drivers (only if
they need special handling, e.g. powering on the i2c controller).
This results in the removal of a bunch of rendundant code from each
back-end controller driver.

Assert that we are not in hard interrupt context in iic_acquire_bus(),
iic_exec(), and iic_release_bus().

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.22.2; 1.22.4;
direct configure i2c devices

zero the i2c_attach_args structure before filling it in.
fixes occasional crashes in iic_attach().

branches: 1.20.2;
if we get garbage from the RTC try again a couple times
this seems to happen more frequently when the PRAM battery goes bad

remove various set-but-unused variables.

Strip redundant parenthesis.

branches: 1.17.2; 1.17.12; 1.17.16;
#include <sys/bus.h> instead of <machine/bus.h>.

struct device * -> device_t
struct cfdata * -> cfdata_t
use device accessors, use device_private.
some softc/device_t splits (macppc needs a bunch more)
aprint*_dev used considerably more

branches: 1.15.10;
Remove `volatile' qualifier from argument types of
struct timeval passed to todr_gettime(9) and todr_settime(9).
We no longer have an ancient and volatile struct timeval `time'
global since we have switched to MI timercounter(9) on all port.

XXX1: some of these RTC drivers still assume 32bit time_t
XXX2: some of these should be rewritten to use todr_[gs]ettime_ymdhms()
XXX3: todr(9) man page doesn't mention todr_[gs]ettime_ymdhms()

Ansify function definitions w/o arguments. Generated with sed.

branches: 1.13.2;
Return error status if an attempt is made to use the quick_{read,write}
i2c protocols, since we don't (yet) know how to make the controller do it.

fix format instead of casting wildly

don't truncate the print.

deal with 64bit time_t
Noticed by Wojciech Galazka

Fix attach messages. (extra colons, misplaced newline etc.)

branches: 1.8.4; 1.8.6; 1.8.8;
struct device * -> device_t

branches: 1.7.2;
Convert to new 2 clause license

branches: 1.6.12; 1.6.14; 1.6.16;
lockmgr -> mutex

branches: 1.5.2;
Convert macppc to shared ofw_autoconf.c. Compile tested only.

branches: 1.4.2;
Merge the ppcoea-renovation branch to HEAD.

This branch was a major cleanup and rototill of many of the various OEA
cpu based PPC ports that focused on sharing as much code as possible
between the various ports to eliminate near-identical copies of files in
every tree. Additionally there is a new PIC system that unifies the
interface to interrupt code for all different OEA ppc arches. The work
for this branch was done by a variety of people, too long to list here.

TODO:
bebox still needs work to complete the transition to -renovation.
ofppc still needs a bunch of work, which I will be looking at.
ev64260 still needs to be renovated
amigappc was not attempted.

NOTES:
pmppc was removed as an arch, and moved to a evbppc target.

branches: 1.3.4; 1.3.8; 1.3.12; 1.3.16; 1.3.24; 1.3.26; 1.3.28; 1.3.30;
don't use IPL_HIGH

- don't go CUDA_IDLE before calling message handlers, that way we force all
writes they might issue to be delayed which keeps us from deadlocking
- don't splhigh() in cuda_intr() - usually we're there already. Instead do
the splhigh()/splx() dance when we're polling
- remove some leftover debugging gunk

branches: 1.1.2;
new drivers for pmu and cuda

Merge thorpej-cfargs branch:

Simplify and make extensible the config_search() / config_found() /
config_attach() interfaces: rather than having different variants for
which arguments you want pass along, just have a single call that
takes a variadic list of tag-value arguments.

Adjust all call sites:
- Simplify wherever possible; don't pass along arguments that aren't
actually needed.
- Don't be explicit about what interface attribute is attaching if
the device only has one. (More simplification.)
- Add a config_probe() function to be used in indirect configuiration
situations, making is visibly easier to see when indirect config is
in play, and allowing for future change in semantics. (As of now,
this is just a wrapper around config_match(), but that is an
implementation detail.)

Remove unnecessary or redundant interface attributes where they're not
needed.

There are currently 5 "cfargs" defined:
- CFARG_SUBMATCH (submatch function for direct config)
- CFARG_SEARCH (search function for indirect config)
- CFARG_IATTR (interface attribte)
- CFARG_LOCATORS (locators array)
- CFARG_DEVHANDLE (devhandle_t - wraps OFW, ACPI, etc. handles)

...and a sentinel value CFARG_EOL.

Add some extra sanity checking to ensure that interface attributes
aren't ambiguous.

Use CFARG_DEVHANDLE in MI FDT, OFW, and ACPI code, and macppc and shark
ports to associate those device handles with device_t instance. This
will trickle trough to more places over time (need back-end for pre-OFW
Sun OBP; any others?).

branches: 1.27.2;
Convert to intr_establish_xname().

branches: 1.26.2;
Adapt to new proplib API

Adapt to new proplib API

Cleanup i2c bus acquire / release, centralizing all of the logic into
iic_acquire_bus() / iic_release_bus(). "acquire" and "release" hooks
no longer need to be provided by back-end controller drivers (only if
they need special handling, e.g. powering on the i2c controller).
This results in the removal of a bunch of rendundant code from each
back-end controller driver.

Assert that we are not in hard interrupt context in iic_acquire_bus(),
iic_exec(), and iic_release_bus().

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.22.2; 1.22.4;
direct configure i2c devices

zero the i2c_attach_args structure before filling it in.
fixes occasional crashes in iic_attach().

branches: 1.20.2;
if we get garbage from the RTC try again a couple times
this seems to happen more frequently when the PRAM battery goes bad

remove various set-but-unused variables.

Strip redundant parenthesis.

branches: 1.17.2; 1.17.12; 1.17.16;
#include <sys/bus.h> instead of <machine/bus.h>.

struct device * -> device_t
struct cfdata * -> cfdata_t
use device accessors, use device_private.
some softc/device_t splits (macppc needs a bunch more)
aprint*_dev used considerably more

branches: 1.15.10;
Remove `volatile' qualifier from argument types of
struct timeval passed to todr_gettime(9) and todr_settime(9).
We no longer have an ancient and volatile struct timeval `time'
global since we have switched to MI timercounter(9) on all port.

XXX1: some of these RTC drivers still assume 32bit time_t
XXX2: some of these should be rewritten to use todr_[gs]ettime_ymdhms()
XXX3: todr(9) man page doesn't mention todr_[gs]ettime_ymdhms()

Ansify function definitions w/o arguments. Generated with sed.

branches: 1.13.2;
Return error status if an attempt is made to use the quick_{read,write}
i2c protocols, since we don't (yet) know how to make the controller do it.

fix format instead of casting wildly

don't truncate the print.

deal with 64bit time_t
Noticed by Wojciech Galazka

Fix attach messages. (extra colons, misplaced newline etc.)

branches: 1.8.4; 1.8.6; 1.8.8;
struct device * -> device_t

branches: 1.7.2;
Convert to new 2 clause license

branches: 1.6.12; 1.6.14; 1.6.16;
lockmgr -> mutex

branches: 1.5.2;
Convert macppc to shared ofw_autoconf.c. Compile tested only.

branches: 1.4.2;
Merge the ppcoea-renovation branch to HEAD.

This branch was a major cleanup and rototill of many of the various OEA
cpu based PPC ports that focused on sharing as much code as possible
between the various ports to eliminate near-identical copies of files in
every tree. Additionally there is a new PIC system that unifies the
interface to interrupt code for all different OEA ppc arches. The work
for this branch was done by a variety of people, too long to list here.

TODO:
bebox still needs work to complete the transition to -renovation.
ofppc still needs a bunch of work, which I will be looking at.
ev64260 still needs to be renovated
amigappc was not attempted.

NOTES:
pmppc was removed as an arch, and moved to a evbppc target.

branches: 1.3.4; 1.3.8; 1.3.12; 1.3.16; 1.3.24; 1.3.26; 1.3.28; 1.3.30;
don't use IPL_HIGH

- don't go CUDA_IDLE before calling message handlers, that way we force all
writes they might issue to be delayed which keeps us from deadlocking
- don't splhigh() in cuda_intr() - usually we're there already. Instead do
the splhigh()/splx() dance when we're polling
- remove some leftover debugging gunk

branches: 1.1.2;
new drivers for pmu and cuda

Convert to intr_establish_xname().

Adapt to new proplib API

Adapt to new proplib API

Cleanup i2c bus acquire / release, centralizing all of the logic into
iic_acquire_bus() / iic_release_bus(). "acquire" and "release" hooks
no longer need to be provided by back-end controller drivers (only if
they need special handling, e.g. powering on the i2c controller).
This results in the removal of a bunch of rendundant code from each
back-end controller driver.

Assert that we are not in hard interrupt context in iic_acquire_bus(),
iic_exec(), and iic_release_bus().

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.22.2; 1.22.4;
direct configure i2c devices

zero the i2c_attach_args structure before filling it in.
fixes occasional crashes in iic_attach().

branches: 1.20.2;
if we get garbage from the RTC try again a couple times
this seems to happen more frequently when the PRAM battery goes bad

remove various set-but-unused variables.

Strip redundant parenthesis.

branches: 1.17.2; 1.17.12; 1.17.16;
#include <sys/bus.h> instead of <machine/bus.h>.

struct device * -> device_t
struct cfdata * -> cfdata_t
use device accessors, use device_private.
some softc/device_t splits (macppc needs a bunch more)
aprint*_dev used considerably more

branches: 1.15.10;
Remove `volatile' qualifier from argument types of
struct timeval passed to todr_gettime(9) and todr_settime(9).
We no longer have an ancient and volatile struct timeval `time'
global since we have switched to MI timercounter(9) on all port.

XXX1: some of these RTC drivers still assume 32bit time_t
XXX2: some of these should be rewritten to use todr_[gs]ettime_ymdhms()
XXX3: todr(9) man page doesn't mention todr_[gs]ettime_ymdhms()

Ansify function definitions w/o arguments. Generated with sed.

branches: 1.13.2;
Return error status if an attempt is made to use the quick_{read,write}
i2c protocols, since we don't (yet) know how to make the controller do it.

fix format instead of casting wildly

don't truncate the print.

deal with 64bit time_t
Noticed by Wojciech Galazka

Fix attach messages. (extra colons, misplaced newline etc.)

branches: 1.8.4; 1.8.6; 1.8.8;
struct device * -> device_t

branches: 1.7.2;
Convert to new 2 clause license

branches: 1.6.12; 1.6.14; 1.6.16;
lockmgr -> mutex

branches: 1.5.2;
Convert macppc to shared ofw_autoconf.c. Compile tested only.

branches: 1.4.2;
Merge the ppcoea-renovation branch to HEAD.

This branch was a major cleanup and rototill of many of the various OEA
cpu based PPC ports that focused on sharing as much code as possible
between the various ports to eliminate near-identical copies of files in
every tree. Additionally there is a new PIC system that unifies the
interface to interrupt code for all different OEA ppc arches. The work
for this branch was done by a variety of people, too long to list here.

TODO:
bebox still needs work to complete the transition to -renovation.
ofppc still needs a bunch of work, which I will be looking at.
ev64260 still needs to be renovated
amigappc was not attempted.

NOTES:
pmppc was removed as an arch, and moved to a evbppc target.

branches: 1.3.4; 1.3.8; 1.3.12; 1.3.16; 1.3.24; 1.3.26; 1.3.28; 1.3.30;
don't use IPL_HIGH

- don't go CUDA_IDLE before calling message handlers, that way we force all
writes they might issue to be delayed which keeps us from deadlocking
- don't splhigh() in cuda_intr() - usually we're there already. Instead do
the splhigh()/splx() dance when we're polling
- remove some leftover debugging gunk

branches: 1.1.2;
new drivers for pmu and cuda

Adapt to new proplib API

Adapt to new proplib API

Cleanup i2c bus acquire / release, centralizing all of the logic into
iic_acquire_bus() / iic_release_bus(). "acquire" and "release" hooks
no longer need to be provided by back-end controller drivers (only if
they need special handling, e.g. powering on the i2c controller).
This results in the removal of a bunch of rendundant code from each
back-end controller driver.

Assert that we are not in hard interrupt context in iic_acquire_bus(),
iic_exec(), and iic_release_bus().

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.22.2; 1.22.4;
direct configure i2c devices

zero the i2c_attach_args structure before filling it in.
fixes occasional crashes in iic_attach().

branches: 1.20.2;
if we get garbage from the RTC try again a couple times
this seems to happen more frequently when the PRAM battery goes bad

remove various set-but-unused variables.

Strip redundant parenthesis.

branches: 1.17.2; 1.17.12; 1.17.16;
#include <sys/bus.h> instead of <machine/bus.h>.

struct device * -> device_t
struct cfdata * -> cfdata_t
use device accessors, use device_private.
some softc/device_t splits (macppc needs a bunch more)
aprint*_dev used considerably more

branches: 1.15.10;
Remove `volatile' qualifier from argument types of
struct timeval passed to todr_gettime(9) and todr_settime(9).
We no longer have an ancient and volatile struct timeval `time'
global since we have switched to MI timercounter(9) on all port.

XXX1: some of these RTC drivers still assume 32bit time_t
XXX2: some of these should be rewritten to use todr_[gs]ettime_ymdhms()
XXX3: todr(9) man page doesn't mention todr_[gs]ettime_ymdhms()

Ansify function definitions w/o arguments. Generated with sed.

branches: 1.13.2;
Return error status if an attempt is made to use the quick_{read,write}
i2c protocols, since we don't (yet) know how to make the controller do it.

fix format instead of casting wildly

don't truncate the print.

deal with 64bit time_t
Noticed by Wojciech Galazka

Fix attach messages. (extra colons, misplaced newline etc.)

branches: 1.8.4; 1.8.6; 1.8.8;
struct device * -> device_t

branches: 1.7.2;
Convert to new 2 clause license

branches: 1.6.12; 1.6.14; 1.6.16;
lockmgr -> mutex

branches: 1.5.2;
Convert macppc to shared ofw_autoconf.c. Compile tested only.

branches: 1.4.2;
Merge the ppcoea-renovation branch to HEAD.

This branch was a major cleanup and rototill of many of the various OEA
cpu based PPC ports that focused on sharing as much code as possible
between the various ports to eliminate near-identical copies of files in
every tree. Additionally there is a new PIC system that unifies the
interface to interrupt code for all different OEA ppc arches. The work
for this branch was done by a variety of people, too long to list here.

TODO:
bebox still needs work to complete the transition to -renovation.
ofppc still needs a bunch of work, which I will be looking at.
ev64260 still needs to be renovated
amigappc was not attempted.

NOTES:
pmppc was removed as an arch, and moved to a evbppc target.

branches: 1.3.4; 1.3.8; 1.3.12; 1.3.16; 1.3.24; 1.3.26; 1.3.28; 1.3.30;
don't use IPL_HIGH

- don't go CUDA_IDLE before calling message handlers, that way we force all
writes they might issue to be delayed which keeps us from deadlocking
- don't splhigh() in cuda_intr() - usually we're there already. Instead do
the splhigh()/splx() dance when we're polling
- remove some leftover debugging gunk

branches: 1.1.2;
new drivers for pmu and cuda

Cleanup i2c bus acquire / release, centralizing all of the logic into
iic_acquire_bus() / iic_release_bus(). "acquire" and "release" hooks
no longer need to be provided by back-end controller drivers (only if
they need special handling, e.g. powering on the i2c controller).
This results in the removal of a bunch of rendundant code from each
back-end controller driver.

Assert that we are not in hard interrupt context in iic_acquire_bus(),
iic_exec(), and iic_release_bus().

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.22.2; 1.22.4;
direct configure i2c devices

zero the i2c_attach_args structure before filling it in.
fixes occasional crashes in iic_attach().

branches: 1.20.2;
if we get garbage from the RTC try again a couple times
this seems to happen more frequently when the PRAM battery goes bad

remove various set-but-unused variables.

Strip redundant parenthesis.

branches: 1.17.2; 1.17.12; 1.17.16;
#include <sys/bus.h> instead of <machine/bus.h>.

struct device * -> device_t
struct cfdata * -> cfdata_t
use device accessors, use device_private.
some softc/device_t splits (macppc needs a bunch more)
aprint*_dev used considerably more

branches: 1.15.10;
Remove `volatile' qualifier from argument types of
struct timeval passed to todr_gettime(9) and todr_settime(9).
We no longer have an ancient and volatile struct timeval `time'
global since we have switched to MI timercounter(9) on all port.

XXX1: some of these RTC drivers still assume 32bit time_t
XXX2: some of these should be rewritten to use todr_[gs]ettime_ymdhms()
XXX3: todr(9) man page doesn't mention todr_[gs]ettime_ymdhms()

Ansify function definitions w/o arguments. Generated with sed.

branches: 1.13.2;
Return error status if an attempt is made to use the quick_{read,write}
i2c protocols, since we don't (yet) know how to make the controller do it.

fix format instead of casting wildly

don't truncate the print.

deal with 64bit time_t
Noticed by Wojciech Galazka

Fix attach messages. (extra colons, misplaced newline etc.)

branches: 1.8.4; 1.8.6; 1.8.8;
struct device * -> device_t

branches: 1.7.2;
Convert to new 2 clause license

branches: 1.6.12; 1.6.14; 1.6.16;
lockmgr -> mutex

branches: 1.5.2;
Convert macppc to shared ofw_autoconf.c. Compile tested only.

branches: 1.4.2;
Merge the ppcoea-renovation branch to HEAD.

This branch was a major cleanup and rototill of many of the various OEA
cpu based PPC ports that focused on sharing as much code as possible
between the various ports to eliminate near-identical copies of files in
every tree. Additionally there is a new PIC system that unifies the
interface to interrupt code for all different OEA ppc arches. The work
for this branch was done by a variety of people, too long to list here.

TODO:
bebox still needs work to complete the transition to -renovation.
ofppc still needs a bunch of work, which I will be looking at.
ev64260 still needs to be renovated
amigappc was not attempted.

NOTES:
pmppc was removed as an arch, and moved to a evbppc target.

branches: 1.3.4; 1.3.8; 1.3.12; 1.3.16; 1.3.24; 1.3.26; 1.3.28; 1.3.30;
don't use IPL_HIGH

- don't go CUDA_IDLE before calling message handlers, that way we force all
writes they might issue to be delayed which keeps us from deadlocking
- don't splhigh() in cuda_intr() - usually we're there already. Instead do
the splhigh()/splx() dance when we're polling
- remove some leftover debugging gunk

branches: 1.1.2;
new drivers for pmu and cuda

Rename min/max -> uimin/uimax for better honesty.

These functions are defined on unsigned int. The generic name
min/max should not silently truncate to 32 bits on 64-bit systems.
This is purely a name change -- no functional change intended.

HOWEVER! Some subsystems have

#define min(a, b) ((a) < (b) ? (a) : (b))
#define max(a, b) ((a) > (b) ? (a) : (b))

even though our standard name for that is MIN/MAX. Although these
may invite multiple evaluation bugs, these do _not_ cause integer
truncation.

To avoid `fixing' these cases, I first changed the name in libkern,
and then compile-tested every file where min/max occurred in order to
confirm that it failed -- and thus confirm that nothing shadowed
min/max -- before changing it.

I have left a handful of bootloaders that are too annoying to
compile-test, and some dead code:

cobalt ews4800mips hp300 hppa ia64 luna68k vax
acorn32/if_ie.c (not included in any kernels)
macppc/if_gm.c (superseded by gem(4))

It should be easy to fix the fallout once identified -- this way of
doing things fails safe, and the goal here, after all, is to _avoid_
silent integer truncations, not introduce them.

Maybe one day we can reintroduce min/max as type-generic things that
never silently truncate. But we should avoid doing that for a while,
so that existing code has a chance to be detected by the compiler for
conversion to uimin/uimax without changing the semantics until we can
properly audit it all. (Who knows, maybe in some cases integer
truncation is actually intended!)

branches: 1.22.2;
direct configure i2c devices

zero the i2c_attach_args structure before filling it in.
fixes occasional crashes in iic_attach().

branches: 1.20.2;
if we get garbage from the RTC try again a couple times
this seems to happen more frequently when the PRAM battery goes bad

remove various set-but-unused variables.

Strip redundant parenthesis.

branches: 1.17.2; 1.17.12; 1.17.16;
#include <sys/bus.h> instead of <machine/bus.h>.

struct device * -> device_t
struct cfdata * -> cfdata_t
use device accessors, use device_private.
some softc/device_t splits (macppc needs a bunch more)
aprint*_dev used considerably more

branches: 1.15.10;
Remove `volatile' qualifier from argument types of
struct timeval passed to todr_gettime(9) and todr_settime(9).
We no longer have an ancient and volatile struct timeval `time'
global since we have switched to MI timercounter(9) on all port.

XXX1: some of these RTC drivers still assume 32bit time_t
XXX2: some of these should be rewritten to use todr_[gs]ettime_ymdhms()
XXX3: todr(9) man page doesn't mention todr_[gs]ettime_ymdhms()

Ansify function definitions w/o arguments. Generated with sed.

branches: 1.13.2;
Return error status if an attempt is made to use the quick_{read,write}
i2c protocols, since we don't (yet) know how to make the controller do it.

fix format instead of casting wildly

don't truncate the print.

deal with 64bit time_t
Noticed by Wojciech Galazka

Fix attach messages. (extra colons, misplaced newline etc.)

branches: 1.8.4; 1.8.6; 1.8.8;
struct device * -> device_t

branches: 1.7.2;
Convert to new 2 clause license

branches: 1.6.12; 1.6.14; 1.6.16;
lockmgr -> mutex

branches: 1.5.2;
Convert macppc to shared ofw_autoconf.c. Compile tested only.

branches: 1.4.2;
Merge the ppcoea-renovation branch to HEAD.

This branch was a major cleanup and rototill of many of the various OEA
cpu based PPC ports that focused on sharing as much code as possible
between the various ports to eliminate near-identical copies of files in
every tree. Additionally there is a new PIC system that unifies the
interface to interrupt code for all different OEA ppc arches. The work
for this branch was done by a variety of people, too long to list here.

TODO:
bebox still needs work to complete the transition to -renovation.
ofppc still needs a bunch of work, which I will be looking at.
ev64260 still needs to be renovated
amigappc was not attempted.

NOTES:
pmppc was removed as an arch, and moved to a evbppc target.

branches: 1.3.4; 1.3.8; 1.3.12; 1.3.16; 1.3.24; 1.3.26; 1.3.28; 1.3.30;
don't use IPL_HIGH

- don't go CUDA_IDLE before calling message handlers, that way we force all
writes they might issue to be delayed which keeps us from deadlocking
- don't splhigh() in cuda_intr() - usually we're there already. Instead do
the splhigh()/splx() dance when we're polling
- remove some leftover debugging gunk

branches: 1.1.2;
new drivers for pmu and cuda

direct configure i2c devices

zero the i2c_attach_args structure before filling it in.
fixes occasional crashes in iic_attach().

branches: 1.20.2;
if we get garbage from the RTC try again a couple times
this seems to happen more frequently when the PRAM battery goes bad

remove various set-but-unused variables.

Strip redundant parenthesis.

branches: 1.17.2; 1.17.12; 1.17.16;
#include <sys/bus.h> instead of <machine/bus.h>.

struct device * -> device_t
struct cfdata * -> cfdata_t
use device accessors, use device_private.
some softc/device_t splits (macppc needs a bunch more)
aprint*_dev used considerably more

branches: 1.15.10;
Remove `volatile' qualifier from argument types of
struct timeval passed to todr_gettime(9) and todr_settime(9).
We no longer have an ancient and volatile struct timeval `time'
global since we have switched to MI timercounter(9) on all port.

XXX1: some of these RTC drivers still assume 32bit time_t
XXX2: some of these should be rewritten to use todr_[gs]ettime_ymdhms()
XXX3: todr(9) man page doesn't mention todr_[gs]ettime_ymdhms()

Ansify function definitions w/o arguments. Generated with sed.

branches: 1.13.2;
Return error status if an attempt is made to use the quick_{read,write}
i2c protocols, since we don't (yet) know how to make the controller do it.

fix format instead of casting wildly

don't truncate the print.

deal with 64bit time_t
Noticed by Wojciech Galazka

Fix attach messages. (extra colons, misplaced newline etc.)

branches: 1.8.4; 1.8.6; 1.8.8;
struct device * -> device_t

branches: 1.7.2;
Convert to new 2 clause license

branches: 1.6.12; 1.6.14; 1.6.16;
lockmgr -> mutex

branches: 1.5.2;
Convert macppc to shared ofw_autoconf.c. Compile tested only.

branches: 1.4.2;
Merge the ppcoea-renovation branch to HEAD.

This branch was a major cleanup and rototill of many of the various OEA
cpu based PPC ports that focused on sharing as much code as possible
between the various ports to eliminate near-identical copies of files in
every tree. Additionally there is a new PIC system that unifies the
interface to interrupt code for all different OEA ppc arches. The work
for this branch was done by a variety of people, too long to list here.

TODO:
bebox still needs work to complete the transition to -renovation.
ofppc still needs a bunch of work, which I will be looking at.
ev64260 still needs to be renovated
amigappc was not attempted.

NOTES:
pmppc was removed as an arch, and moved to a evbppc target.

branches: 1.3.4; 1.3.8; 1.3.12; 1.3.16; 1.3.24; 1.3.26; 1.3.28; 1.3.30;
don't use IPL_HIGH

- don't go CUDA_IDLE before calling message handlers, that way we force all
writes they might issue to be delayed which keeps us from deadlocking
- don't splhigh() in cuda_intr() - usually we're there already. Instead do
the splhigh()/splx() dance when we're polling
- remove some leftover debugging gunk

branches: 1.1.2;
new drivers for pmu and cuda

zero the i2c_attach_args structure before filling it in.
fixes occasional crashes in iic_attach().

branches: 1.20.2;
if we get garbage from the RTC try again a couple times
this seems to happen more frequently when the PRAM battery goes bad

remove various set-but-unused variables.

Strip redundant parenthesis.

branches: 1.17.2; 1.17.12; 1.17.16;
#include <sys/bus.h> instead of <machine/bus.h>.

struct device * -> device_t
struct cfdata * -> cfdata_t
use device accessors, use device_private.
some softc/device_t splits (macppc needs a bunch more)
aprint*_dev used considerably more

branches: 1.15.10;
Remove `volatile' qualifier from argument types of
struct timeval passed to todr_gettime(9) and todr_settime(9).
We no longer have an ancient and volatile struct timeval `time'
global since we have switched to MI timercounter(9) on all port.

XXX1: some of these RTC drivers still assume 32bit time_t
XXX2: some of these should be rewritten to use todr_[gs]ettime_ymdhms()
XXX3: todr(9) man page doesn't mention todr_[gs]ettime_ymdhms()

Ansify function definitions w/o arguments. Generated with sed.

branches: 1.13.2;
Return error status if an attempt is made to use the quick_{read,write}
i2c protocols, since we don't (yet) know how to make the controller do it.

fix format instead of casting wildly

don't truncate the print.

deal with 64bit time_t
Noticed by Wojciech Galazka

Fix attach messages. (extra colons, misplaced newline etc.)

branches: 1.8.4; 1.8.6; 1.8.8;
struct device * -> device_t

branches: 1.7.2;
Convert to new 2 clause license

branches: 1.6.12; 1.6.14; 1.6.16;
lockmgr -> mutex

branches: 1.5.2;
Convert macppc to shared ofw_autoconf.c. Compile tested only.

branches: 1.4.2;
Merge the ppcoea-renovation branch to HEAD.

This branch was a major cleanup and rototill of many of the various OEA
cpu based PPC ports that focused on sharing as much code as possible
between the various ports to eliminate near-identical copies of files in
every tree. Additionally there is a new PIC system that unifies the
interface to interrupt code for all different OEA ppc arches. The work
for this branch was done by a variety of people, too long to list here.

TODO:
bebox still needs work to complete the transition to -renovation.
ofppc still needs a bunch of work, which I will be looking at.
ev64260 still needs to be renovated
amigappc was not attempted.

NOTES:
pmppc was removed as an arch, and moved to a evbppc target.

branches: 1.3.4; 1.3.8; 1.3.12; 1.3.16; 1.3.24; 1.3.26; 1.3.28; 1.3.30;
don't use IPL_HIGH

- don't go CUDA_IDLE before calling message handlers, that way we force all
writes they might issue to be delayed which keeps us from deadlocking
- don't splhigh() in cuda_intr() - usually we're there already. Instead do
the splhigh()/splx() dance when we're polling
- remove some leftover debugging gunk

branches: 1.1.2;
new drivers for pmu and cuda