fix various typos in comments and log messages.

Fix off by one in telrcv()

In case of "\r" in the data buffer, the code was unconditionally looking ahead
to next character, even if "\r" was last character in the buffer. That
condition leads to read outside of the data (one byte after the array)

Thanks christos@ for the review

s/fist/first/

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.30.14;
acknowleg -> acknowledg, proceedure -> procedure.
only comments were changed.

from miod

branches: 1.29.22;
PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

there is a macro for that, use it.

branches: 1.27.34;
Move ctype.h from headers to files which really need it
From: Slava Semushin <slava.semushin@gmail.com>

Remove static local variable so its easier to correctly use strlcpy.

branches: 1.25.2;
de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

branches: 1.24.2; 1.24.4;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

achive is not a good word.

Remove lots of #ifdef's for dead Cray hardware and obsolete UNICOS releases;
also some Cray-specific fixes. No change for NetBSD.
From Brian Ginsbach of Cray Inc. in bin/13614 and private mail.

Typo fixes and syslog string improvements, from bin/13667 by Brian Ginsbach.

Add some (const char *) casts per bin/13667 by Brian Ginsbach.

Fix compilation without -DLINEMODE, per bin/13571 from Onno van der Linden.

vsnprintf() can return value longer than the actual string. from assar

try netflush() if buffer is too low.

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

fix redundant declarations.

Format string cleanups by sommerfeld.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.11.4; 1.11.12;
WARNS?=1. RCS ids.

Block ENV and BASH_ENV from client. From David Holland <dholland@hcs.harvard.edu>

RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

Cleanup, from Mark Eichin.

Filter potentially dangerous environment variables passed from
telnet client.

branches: 1.5.4;
new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Nuke remaining patchkit headers.

Add RCS identifiers.

after 0.2.2 "stable" patches applied

branches: 1.1.1;
Initial revision

Fix off by one in telrcv()

In case of "\r" in the data buffer, the code was unconditionally looking ahead
to next character, even if "\r" was last character in the buffer. That
condition leads to read outside of the data (one byte after the array)

Thanks christos@ for the review

s/fist/first/

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.30.14;
acknowleg -> acknowledg, proceedure -> procedure.
only comments were changed.

from miod

branches: 1.29.22;
PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

there is a macro for that, use it.

branches: 1.27.34;
Move ctype.h from headers to files which really need it
From: Slava Semushin <slava.semushin@gmail.com>

Remove static local variable so its easier to correctly use strlcpy.

branches: 1.25.2;
de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

branches: 1.24.2; 1.24.4;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

achive is not a good word.

Remove lots of #ifdef's for dead Cray hardware and obsolete UNICOS releases;
also some Cray-specific fixes. No change for NetBSD.
From Brian Ginsbach of Cray Inc. in bin/13614 and private mail.

Typo fixes and syslog string improvements, from bin/13667 by Brian Ginsbach.

Add some (const char *) casts per bin/13667 by Brian Ginsbach.

Fix compilation without -DLINEMODE, per bin/13571 from Onno van der Linden.

vsnprintf() can return value longer than the actual string. from assar

try netflush() if buffer is too low.

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

fix redundant declarations.

Format string cleanups by sommerfeld.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.11.4; 1.11.12;
WARNS?=1. RCS ids.

Block ENV and BASH_ENV from client. From David Holland <dholland@hcs.harvard.edu>

RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

Cleanup, from Mark Eichin.

Filter potentially dangerous environment variables passed from
telnet client.

branches: 1.5.4;
new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Nuke remaining patchkit headers.

Add RCS identifiers.

after 0.2.2 "stable" patches applied

branches: 1.1.1;
Initial revision

s/fist/first/

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

branches: 1.30.14;
acknowleg -> acknowledg, proceedure -> procedure.
only comments were changed.

from miod

branches: 1.29.22;
PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

there is a macro for that, use it.

branches: 1.27.34;
Move ctype.h from headers to files which really need it
From: Slava Semushin <slava.semushin@gmail.com>

Remove static local variable so its easier to correctly use strlcpy.

branches: 1.25.2;
de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

branches: 1.24.2; 1.24.4;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

achive is not a good word.

Remove lots of #ifdef's for dead Cray hardware and obsolete UNICOS releases;
also some Cray-specific fixes. No change for NetBSD.
From Brian Ginsbach of Cray Inc. in bin/13614 and private mail.

Typo fixes and syslog string improvements, from bin/13667 by Brian Ginsbach.

Add some (const char *) casts per bin/13667 by Brian Ginsbach.

Fix compilation without -DLINEMODE, per bin/13571 from Onno van der Linden.

vsnprintf() can return value longer than the actual string. from assar

try netflush() if buffer is too low.

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

fix redundant declarations.

Format string cleanups by sommerfeld.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.11.4; 1.11.12;
WARNS?=1. RCS ids.

Block ENV and BASH_ENV from client. From David Holland <dholland@hcs.harvard.edu>

RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

Cleanup, from Mark Eichin.

Filter potentially dangerous environment variables passed from
telnet client.

branches: 1.5.4;
new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Nuke remaining patchkit headers.

Add RCS identifiers.

after 0.2.2 "stable" patches applied

branches: 1.1.1;
Initial revision

- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

acknowleg -> acknowledg, proceedure -> procedure.
only comments were changed.

from miod

branches: 1.29.22;
PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

there is a macro for that, use it.

branches: 1.27.34;
Move ctype.h from headers to files which really need it
From: Slava Semushin <slava.semushin@gmail.com>

Remove static local variable so its easier to correctly use strlcpy.

branches: 1.25.2;
de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

branches: 1.24.2; 1.24.4;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

achive is not a good word.

Remove lots of #ifdef's for dead Cray hardware and obsolete UNICOS releases;
also some Cray-specific fixes. No change for NetBSD.
From Brian Ginsbach of Cray Inc. in bin/13614 and private mail.

Typo fixes and syslog string improvements, from bin/13667 by Brian Ginsbach.

Add some (const char *) casts per bin/13667 by Brian Ginsbach.

Fix compilation without -DLINEMODE, per bin/13571 from Onno van der Linden.

vsnprintf() can return value longer than the actual string. from assar

try netflush() if buffer is too low.

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

fix redundant declarations.

Format string cleanups by sommerfeld.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.11.4; 1.11.12;
WARNS?=1. RCS ids.

Block ENV and BASH_ENV from client. From David Holland <dholland@hcs.harvard.edu>

RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

Cleanup, from Mark Eichin.

Filter potentially dangerous environment variables passed from
telnet client.

branches: 1.5.4;
new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Nuke remaining patchkit headers.

Add RCS identifiers.

after 0.2.2 "stable" patches applied

branches: 1.1.1;
Initial revision

acknowleg -> acknowledg, proceedure -> procedure.
only comments were changed.

from miod

PR/45805: Borodin Oleg: telnet/telnetd with -DAUTHENTICATION -DENCRYPTION
(rfc2941)
- separate MKCRYPTO from USE_KERBEROS
- WARNS=4

there is a macro for that, use it.

branches: 1.27.34;
Move ctype.h from headers to files which really need it
From: Slava Semushin <slava.semushin@gmail.com>

Remove static local variable so its easier to correctly use strlcpy.

branches: 1.25.2;
de-__P, ANSIfy function declarations, remove obsolete "register" declarations.

branches: 1.24.2; 1.24.4;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22284, verified by myself.

remove unneeded #ifdefs. improves readability.
(confirmed that exact same *.o is produced)

achive is not a good word.

Remove lots of #ifdef's for dead Cray hardware and obsolete UNICOS releases;
also some Cray-specific fixes. No change for NetBSD.
From Brian Ginsbach of Cray Inc. in bin/13614 and private mail.

Typo fixes and syslog string improvements, from bin/13667 by Brian Ginsbach.

Add some (const char *) casts per bin/13667 by Brian Ginsbach.

Fix compilation without -DLINEMODE, per bin/13571 from Onno van der Linden.

vsnprintf() can return value longer than the actual string. from assar

try netflush() if buffer is too low.

bound-check all "*nfrontp++" code. from openbsd/heimdal.
bark if file descriptor goes above FD_SETSIZE. from openbsd.

XXX needs more checking.
XXX what is tab stop size for this code? need more consistency...
XXX we should really remove #ifdef CRAY, UNICOS5 and such.
we just cannot read it through.

fix redundant declarations.

Format string cleanups by sommerfeld.

Bring the telnet situation back into better shape. Specifically,
pull in just about all of the differences from the crypto-us telnet
suite (which includes Kerberos 4 and connection encryption support).
Also bring in the Kerberos 5 support from the Heimdal telnet, and
frob a little so that it can work with the non-Heimdal telnet suite.

There is still some work left to do, specifically:
- Add Heimdal's ticket forwarding support to the Berkeley Kerberos 4
module.
- Add connection encryption support to the Heimdal Kerberos 5
module. Hints on this can be taken from the MIT Kerberos 5
module which still exists in crypto-us.

However, even with the shortcomings listed above, this is a
better situation than using the stock Heimdal telnet suite,
which does not understand the IPSec policy stuff, and is also
based on much older code which contains bugs that we have already
fixed in the NetBSD sources.

branches: 1.11.4; 1.11.12;
WARNS?=1. RCS ids.

Block ENV and BASH_ENV from client. From David Holland <dholland@hcs.harvard.edu>

RCS id cosmetics.

update to telnetd from 95.10.23 version. Includes Borman's scrub_env()
to keep stuff out of the environment on the way to exec (we already have
one in the state machine that keeps them from arriving over the wire, so
this should be redundant, but it'll make any further updates easier to
have it present).

also, RCS Id police.

Cleanup, from Mark Eichin.

Filter potentially dangerous environment variables passed from
telnet client.

branches: 1.5.4;
new telnetd from ftp.cray.com. Encryption support ripped out, pending
figuring out what to do about it...

Nuke remaining patchkit headers.

Add RCS identifiers.

after 0.2.2 "stable" patches applied

branches: 1.1.1;
Initial revision