- fix memory leak
- xxx questionable allocation
- remove casts
- use sizeof(*var)
- bcopy -> memcpy/memmove

PR/50919: David Binderman: Re-do all the debug stuff in a more sustainable way.

Counting from 0 to n-1 can go wrong badly, if n is unsigned and zero and
the counter variable is not of a type larger than n. Fixes PR 50490.

Constify set_field_buffer.

src is too big these days to tolerate superfluous apostrophes. It's
"its", people!

branches: 1.27.4;
Simplify previous.

Correct the allocation for the reformat buffer, thanks to mlelstv for
the fix.

branches: 1.25.6; 1.25.12;
Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

We want size_t arguments, so just cast to size_t, instead of casting
to unsigned long and getting a warning on i386.

* Rewrote internal handling of multiline field line data to fix a bug
where a newly opened line would immediately get wrapped out of existence.
The old method of handling lines in a multiline field did not cope with
this elegantly.

* Added new field flag O_REFORMAT which, when set, returns the field
buffer with newlines inserted where the line wrapped. Previously, there
was no way of preserving the on screen format of a multiline field.

* Added new file gdbinit which contains a macro to verify and print
the multiline field line data structure.

* Bumped libform major number due to changes in the _form_field structure.

use __RCSID()

Added extension to interface, set_field_printf which allows a printf
style setting of field buffers.

set_field_opts and field_opts_on were both using the wrong pointer
resulting in libform crashing if O_STATIC was set on the default field.

Redraw field when the flags for the field change iff the field is
attached to a form and the form is posted.

Reposition form cursor after field redrawn when setting a field value,
since the field set may not be the current one. This fixes PR 17533.

* Fix cursor motion bugs referred to in pr 17480
* Handle cursor motion for justifications other than left justified.

Prevent set_field_buffer from redrawing field that is attached to a form
when the form is not posted.

* Major rework to allow the TAB character in fields.

Add missing function and make some error returns into proper eti.h
errors.

Fix limits on dynamic fields.

withough -> without

* Only line wrap buffer 0 in set_field_buffer since this is the
only one displayed.

* Rototilled internals to make multiline fields work correctly. Some
bugs remain such as vertical scrolling is not working and the field
is not correctly redrawn after being cleared. There are bound to be
others.

* Fixed horizontal scrolling.

* truncate field contents to field length if field is or becomes static
* Allow field options to be changed when field posted unless field
is the current one.
* Allow field justification to be changed when field posted unless it
is the current one.
* dynamic_field_info now returns field size in rows and columns if
the field is static - previously this was an error.

replace strncpy with strlcpy.... 'nuff said.

Truncate the buffer string to the field buffer size if the field is static.

Buffer now wrapped and redrawn when buffer is set.

When buffers are created they are given an empty string instead of just
being set to NULL. Stops us returning a NULL pointer for buffers that
are never set.

Multiple fixes:

* A debug version of libform will be build if DEBUG_FORMS is defined
* Can no longer edit fields that do not have O_EDIT set
* Changed background attribute to A_NORMAL like ncurses
* Fixed truncation of field contents when content length == field length
* Current field is set to first visible & active field on form post

* Changed type of userptr to be void * (now matches ncurses)
* Bumped lib major version due to above.
* Changed debug output to go to a file instead of stderr, the file gets
opened when the form is posted iff one is not already open.

Added early release version of libform - please be gentle.

PR/50919: David Binderman: Re-do all the debug stuff in a more sustainable way.

Counting from 0 to n-1 can go wrong badly, if n is unsigned and zero and
the counter variable is not of a type larger than n. Fixes PR 50490.

Constify set_field_buffer.

src is too big these days to tolerate superfluous apostrophes. It's
"its", people!

branches: 1.27.4;
Simplify previous.

Correct the allocation for the reformat buffer, thanks to mlelstv for
the fix.

branches: 1.25.6; 1.25.12;
Userland now builds and uses terminfo instead of termcap.

OK: core@, jdc@

We want size_t arguments, so just cast to size_t, instead of casting
to unsigned long and getting a warning on i386.

* Rewrote internal handling of multiline field line data to fix a bug
where a newly opened line would immediately get wrapped out of existence.
The old method of handling lines in a multiline field did not cope with
this elegantly.

* Added new field flag O_REFORMAT which, when set, returns the field
buffer with newlines inserted where the line wrapped. Previously, there
was no way of preserving the on screen format of a multiline field.

* Added new file gdbinit which contains a macro to verify and print
the multiline field line data structure.

* Bumped libform major number due to changes in the _form_field structure.

use __RCSID()

Added extension to interface, set_field_printf which allows a printf
style setting of field buffers.

set_field_opts and field_opts_on were both using the wrong pointer
resulting in libform crashing if O_STATIC was set on the default field.

Redraw field when the flags for the field change iff the field is
attached to a form and the form is posted.

Reposition form cursor after field redrawn when setting a field value,
since the field set may not be the current one. This fixes PR 17533.

* Fix cursor motion bugs referred to in pr 17480
* Handle cursor motion for justifications other than left justified.

Prevent set_field_buffer from redrawing field that is attached to a form
when the form is not posted.

* Major rework to allow the TAB character in fields.

Add missing function and make some error returns into proper eti.h
errors.

Fix limits on dynamic fields.

withough -> without

* Only line wrap buffer 0 in set_field_buffer since this is the
only one displayed.

* Rototilled internals to make multiline fields work correctly. Some
bugs remain such as vertical scrolling is not working and the field
is not correctly redrawn after being cleared. There are bound to be
others.

* Fixed horizontal scrolling.

* truncate field contents to field length if field is or becomes static
* Allow field options to be changed when field posted unless field
is the current one.
* Allow field justification to be changed when field posted unless it
is the current one.
* dynamic_field_info now returns field size in rows and columns if
the field is static - previously this was an error.

replace strncpy with strlcpy.... 'nuff said.

Truncate the buffer string to the field buffer size if the field is static.

Buffer now wrapped and redrawn when buffer is set.

When buffers are created they are given an empty string instead of just
being set to NULL. Stops us returning a NULL pointer for buffers that
are never set.

Multiple fixes:

* A debug version of libform will be build if DEBUG_FORMS is defined
* Can no longer edit fields that do not have O_EDIT set
* Changed background attribute to A_NORMAL like ncurses
* Fixed truncation of field contents when content length == field length
* Current field is set to first visible & active field on form post

* Changed type of userptr to be void * (now matches ncurses)
* Bumped lib major version due to above.
* Changed debug output to go to a file instead of stderr, the file gets
opened when the form is posted iff one is not already open.

Added early release version of libform - please be gentle.