Remove unused stuff, and limit the scope of some of the used ones.
(from des@freebsd)

improvements in malloc/free handling.

Add casts to appease conversions between wchar_t and wint_t

Fix numeric variable handling in settc (lyzliyuzhi at 163 dot com)

use strlcpy() instead of strncpy() for gcc happiness

PR/54654: Soren Tempel: Make sure el_cursor.v < el_terminal.t_size.v when
moving around.

Fix type and remove cast (Yuichiro NAITO/FreeBSD).

PR/54399: S�ren Tempel: Uninitialized memory access in libedit history.
Initialize the buffer using calloc. While here change all malloc(a * sizeof(b))
to calloc(a, sizeof(b)). XXX: should fix realloc similarly.

Add a comment explaining why we don't use DO here. Correct the attribution
on the previous patch: The patch was from Jordan Lewis and the report from
Raphael Poss.

PR/54329: Raphael Ross: According to https://www.gnu.org/software/termutils/\
manual/termcap-1.3/html_chapter/termcap_4.html#SEC23 the cursor move multiple
escapes have undefined results when moving out of the screen. Stop using DO
to move down multiple lines and use a loop of newlines instead.

PR/52359: Benjamin Lorenz: When resizing because of a signal save and restore
the cursor position, since it does not change.

PR/53983: Jonathan Perkins: Fix types for readline compatibility

PR/53682: Jordan Lewis: use newlines instead of padded spaces when restoring
multi-line histories.

branches: 1.33.4; 1.33.6;
- handle literal escape sequence printing.
- factor out common code in allocation and freeing of the display.

branches: 1.32.8;
s/protected/libedit_private/g

eliminate static buffer with custom resizing code.

From Ingo Schwarze:
* Replace fcns.c by a shorter and simpler func.h
and include it only in the one file needing it, map.c.
* Combine help.h and help.c into a simplified help.h
and include it only in the one file needing it, map.c.
* Check the very simple, static files editline.c, historyn.c, and
tokenizern.c into CVS rather than needlessly generating them.
* So we no longer autogenerate any C files. :-)
* Shorten and simplify makelist by deleting the options -n, -e, -bc,
and -m; the latter was unused and useless in the first place.
* Move the declaration of el_func_t from fcns.h to the header
actually needing it, map.h. Since that header is already
included by el.h for unrelated reasons, that makes el_func_t
just as globally available as before.
* No longer include the simplified fcns.h into el.h,
include it directly into the *.c files needing it.

Get rid of private/public; keep protected (Ingo Schwarze)

Char -> wchar_t from Ingo Schwarze.

more macro WIDECHAR undoing from Ingo Schwarze.

More WIDECHAR elimination (Ingo Schwarze)

Start removing the WIDECHAR ifdefs; building without it has stopped working
anyway. (Ingo Schwarze)

put back NUL check (Ingo Schwarze)

PR/50880: David Binderman: Remove redundant code.
While here, fix all debugging formats.

whitespace and header sorting changes (Ingo Schwarze). No functional changes.

From Ingo Scharze:
Let "el.h" include everything needed for struct editline,
and don't include that stuff multiple times. That also improves
consistency, also avoids circular inclusions, and also makes it
easier to follow what is going on, even though not quite as nice.
But it seems like the best we can do...

cleanup chartype.h includes (Ingo Schwarze)

cleanup inclusion of histedit.h (Ingo Schwarze)

OpenBSD term.c rev. 1.7 2002/11/29 20:13:39 deraadt
spelling

OpenBSD term.c rev. 1.13 2009/12/11 18:58:59 jacekm
fix two memory leaks

From Ingo Schwarze:

As we have seen before, "histedit.h" can never get rid of including
the <wchar.h> header because using the data types defined there is
deeply ingrained in the public interfaces of libedit.

Now POSIX unconditionally requires that <wchar.h> defines the type
wint_t. Consequently, it can be used unconditionally, no matter
whether WIDECHAR is active or not. Consequently, the #define Int
is pointless.

Note that removing it is not gratuitious churn. Auditing for
integer signedness problems is already hard when only fundamental
types like "int" and "unsigned" are involved. It gets very hard
when types come into the picture that have platform-dependent
signedness, like "char" and "wint_t". Adding yet another layer
on top, changing both the signedness and the width in a platform-
dependent way, makes auditing yet harder, which IMHO is really
dangerous. Note that while removing the #define, i already found
one bug caused by this excessive complication - in the function
re_putc() in refresh.c. If WIDECHAR was defined, it printed an
Int = wint_t value with %c. Fortunately, that bug only affects
debugging, not production. The fix is contained in the patch.

With WIDECHAR, this doesn't change anything. For the case without
WIDECHAR, i checked that none of the places wants to store values
that might not fit in wint_t.

This only changes internal interfaces; public ones remain unchanged.

- Add some more Char casts
- reduce ifdefs by providing empty defs for nls functions (Ingo Schwarze)

don't include both term.h and termcap.h

From: Jilles Tjoelker: Add a mapping for the cursor delete key

Initialize termbuf (Kamil Dudka)

check for negative return of ct_visual_char (Kamil Dudka)

branches: 1.10.2;

fixed warnings where wint_t is unsigned.

fix broken change (parenthesis in the wrong place). From Nirbhay Choubey

re-enable -Wconversion

pass -Wconversion

kill ifdef notdef

KNF return (\1); -> return \1;

kill ptr_t and ioctl_t, add * sizeof(*foo) to all allocations.

whitespace

Rename key to keymacro to avoid conflicts with term.h. The renaming of term
to terminal was again to avoid conflicts with term.h. term.h is a moving
namespace violation.

term -> terminal
XXX: need to rename key_ too.

improvements in malloc/free handling.

Add casts to appease conversions between wchar_t and wint_t

Fix numeric variable handling in settc (lyzliyuzhi at 163 dot com)

use strlcpy() instead of strncpy() for gcc happiness

PR/54654: Soren Tempel: Make sure el_cursor.v < el_terminal.t_size.v when
moving around.

Fix type and remove cast (Yuichiro NAITO/FreeBSD).

PR/54399: S�ren Tempel: Uninitialized memory access in libedit history.
Initialize the buffer using calloc. While here change all malloc(a * sizeof(b))
to calloc(a, sizeof(b)). XXX: should fix realloc similarly.

Add a comment explaining why we don't use DO here. Correct the attribution
on the previous patch: The patch was from Jordan Lewis and the report from
Raphael Poss.

PR/54329: Raphael Ross: According to https://www.gnu.org/software/termutils/\
manual/termcap-1.3/html_chapter/termcap_4.html#SEC23 the cursor move multiple
escapes have undefined results when moving out of the screen. Stop using DO
to move down multiple lines and use a loop of newlines instead.

PR/52359: Benjamin Lorenz: When resizing because of a signal save and restore
the cursor position, since it does not change.

PR/53983: Jonathan Perkins: Fix types for readline compatibility

PR/53682: Jordan Lewis: use newlines instead of padded spaces when restoring
multi-line histories.

branches: 1.33.4; 1.33.6;
- handle literal escape sequence printing.
- factor out common code in allocation and freeing of the display.

branches: 1.32.8;
s/protected/libedit_private/g

eliminate static buffer with custom resizing code.

From Ingo Schwarze:
* Replace fcns.c by a shorter and simpler func.h
and include it only in the one file needing it, map.c.
* Combine help.h and help.c into a simplified help.h
and include it only in the one file needing it, map.c.
* Check the very simple, static files editline.c, historyn.c, and
tokenizern.c into CVS rather than needlessly generating them.
* So we no longer autogenerate any C files. :-)
* Shorten and simplify makelist by deleting the options -n, -e, -bc,
and -m; the latter was unused and useless in the first place.
* Move the declaration of el_func_t from fcns.h to the header
actually needing it, map.h. Since that header is already
included by el.h for unrelated reasons, that makes el_func_t
just as globally available as before.
* No longer include the simplified fcns.h into el.h,
include it directly into the *.c files needing it.

Get rid of private/public; keep protected (Ingo Schwarze)

Char -> wchar_t from Ingo Schwarze.

more macro WIDECHAR undoing from Ingo Schwarze.

More WIDECHAR elimination (Ingo Schwarze)

Start removing the WIDECHAR ifdefs; building without it has stopped working
anyway. (Ingo Schwarze)

put back NUL check (Ingo Schwarze)

PR/50880: David Binderman: Remove redundant code.
While here, fix all debugging formats.

whitespace and header sorting changes (Ingo Schwarze). No functional changes.

From Ingo Scharze:
Let "el.h" include everything needed for struct editline,
and don't include that stuff multiple times. That also improves
consistency, also avoids circular inclusions, and also makes it
easier to follow what is going on, even though not quite as nice.
But it seems like the best we can do...

cleanup chartype.h includes (Ingo Schwarze)

cleanup inclusion of histedit.h (Ingo Schwarze)

OpenBSD term.c rev. 1.7 2002/11/29 20:13:39 deraadt
spelling

OpenBSD term.c rev. 1.13 2009/12/11 18:58:59 jacekm
fix two memory leaks

From Ingo Schwarze:

As we have seen before, "histedit.h" can never get rid of including
the <wchar.h> header because using the data types defined there is
deeply ingrained in the public interfaces of libedit.

Now POSIX unconditionally requires that <wchar.h> defines the type
wint_t. Consequently, it can be used unconditionally, no matter
whether WIDECHAR is active or not. Consequently, the #define Int
is pointless.

Note that removing it is not gratuitious churn. Auditing for
integer signedness problems is already hard when only fundamental
types like "int" and "unsigned" are involved. It gets very hard
when types come into the picture that have platform-dependent
signedness, like "char" and "wint_t". Adding yet another layer
on top, changing both the signedness and the width in a platform-
dependent way, makes auditing yet harder, which IMHO is really
dangerous. Note that while removing the #define, i already found
one bug caused by this excessive complication - in the function
re_putc() in refresh.c. If WIDECHAR was defined, it printed an
Int = wint_t value with %c. Fortunately, that bug only affects
debugging, not production. The fix is contained in the patch.

With WIDECHAR, this doesn't change anything. For the case without
WIDECHAR, i checked that none of the places wants to store values
that might not fit in wint_t.

This only changes internal interfaces; public ones remain unchanged.

- Add some more Char casts
- reduce ifdefs by providing empty defs for nls functions (Ingo Schwarze)

don't include both term.h and termcap.h

From: Jilles Tjoelker: Add a mapping for the cursor delete key

Initialize termbuf (Kamil Dudka)

check for negative return of ct_visual_char (Kamil Dudka)

branches: 1.10.2;

fixed warnings where wint_t is unsigned.

fix broken change (parenthesis in the wrong place). From Nirbhay Choubey

re-enable -Wconversion

pass -Wconversion

kill ifdef notdef

KNF return (\1); -> return \1;

kill ptr_t and ioctl_t, add * sizeof(*foo) to all allocations.

whitespace

Rename key to keymacro to avoid conflicts with term.h. The renaming of term
to terminal was again to avoid conflicts with term.h. term.h is a moving
namespace violation.

term -> terminal
XXX: need to rename key_ too.

Add casts to appease conversions between wchar_t and wint_t

Fix numeric variable handling in settc (lyzliyuzhi at 163 dot com)

use strlcpy() instead of strncpy() for gcc happiness

PR/54654: Soren Tempel: Make sure el_cursor.v < el_terminal.t_size.v when
moving around.

Fix type and remove cast (Yuichiro NAITO/FreeBSD).

PR/54399: S�ren Tempel: Uninitialized memory access in libedit history.
Initialize the buffer using calloc. While here change all malloc(a * sizeof(b))
to calloc(a, sizeof(b)). XXX: should fix realloc similarly.

Add a comment explaining why we don't use DO here. Correct the attribution
on the previous patch: The patch was from Jordan Lewis and the report from
Raphael Poss.

PR/54329: Raphael Ross: According to https://www.gnu.org/software/termutils/\
manual/termcap-1.3/html_chapter/termcap_4.html#SEC23 the cursor move multiple
escapes have undefined results when moving out of the screen. Stop using DO
to move down multiple lines and use a loop of newlines instead.

PR/52359: Benjamin Lorenz: When resizing because of a signal save and restore
the cursor position, since it does not change.

PR/53983: Jonathan Perkins: Fix types for readline compatibility

PR/53682: Jordan Lewis: use newlines instead of padded spaces when restoring
multi-line histories.

branches: 1.33.4; 1.33.6;
- handle literal escape sequence printing.
- factor out common code in allocation and freeing of the display.

branches: 1.32.8;
s/protected/libedit_private/g

eliminate static buffer with custom resizing code.

From Ingo Schwarze:
* Replace fcns.c by a shorter and simpler func.h
and include it only in the one file needing it, map.c.
* Combine help.h and help.c into a simplified help.h
and include it only in the one file needing it, map.c.
* Check the very simple, static files editline.c, historyn.c, and
tokenizern.c into CVS rather than needlessly generating them.
* So we no longer autogenerate any C files. :-)
* Shorten and simplify makelist by deleting the options -n, -e, -bc,
and -m; the latter was unused and useless in the first place.
* Move the declaration of el_func_t from fcns.h to the header
actually needing it, map.h. Since that header is already
included by el.h for unrelated reasons, that makes el_func_t
just as globally available as before.
* No longer include the simplified fcns.h into el.h,
include it directly into the *.c files needing it.

Get rid of private/public; keep protected (Ingo Schwarze)

Char -> wchar_t from Ingo Schwarze.

more macro WIDECHAR undoing from Ingo Schwarze.

More WIDECHAR elimination (Ingo Schwarze)

Start removing the WIDECHAR ifdefs; building without it has stopped working
anyway. (Ingo Schwarze)

put back NUL check (Ingo Schwarze)

PR/50880: David Binderman: Remove redundant code.
While here, fix all debugging formats.

whitespace and header sorting changes (Ingo Schwarze). No functional changes.

From Ingo Scharze:
Let "el.h" include everything needed for struct editline,
and don't include that stuff multiple times. That also improves
consistency, also avoids circular inclusions, and also makes it
easier to follow what is going on, even though not quite as nice.
But it seems like the best we can do...

cleanup chartype.h includes (Ingo Schwarze)

cleanup inclusion of histedit.h (Ingo Schwarze)

OpenBSD term.c rev. 1.7 2002/11/29 20:13:39 deraadt
spelling

OpenBSD term.c rev. 1.13 2009/12/11 18:58:59 jacekm
fix two memory leaks

From Ingo Schwarze:

As we have seen before, "histedit.h" can never get rid of including
the <wchar.h> header because using the data types defined there is
deeply ingrained in the public interfaces of libedit.

Now POSIX unconditionally requires that <wchar.h> defines the type
wint_t. Consequently, it can be used unconditionally, no matter
whether WIDECHAR is active or not. Consequently, the #define Int
is pointless.

Note that removing it is not gratuitious churn. Auditing for
integer signedness problems is already hard when only fundamental
types like "int" and "unsigned" are involved. It gets very hard
when types come into the picture that have platform-dependent
signedness, like "char" and "wint_t". Adding yet another layer
on top, changing both the signedness and the width in a platform-
dependent way, makes auditing yet harder, which IMHO is really
dangerous. Note that while removing the #define, i already found
one bug caused by this excessive complication - in the function
re_putc() in refresh.c. If WIDECHAR was defined, it printed an
Int = wint_t value with %c. Fortunately, that bug only affects
debugging, not production. The fix is contained in the patch.

With WIDECHAR, this doesn't change anything. For the case without
WIDECHAR, i checked that none of the places wants to store values
that might not fit in wint_t.

This only changes internal interfaces; public ones remain unchanged.

- Add some more Char casts
- reduce ifdefs by providing empty defs for nls functions (Ingo Schwarze)

don't include both term.h and termcap.h

From: Jilles Tjoelker: Add a mapping for the cursor delete key

Initialize termbuf (Kamil Dudka)

check for negative return of ct_visual_char (Kamil Dudka)

branches: 1.10.2;

fixed warnings where wint_t is unsigned.

fix broken change (parenthesis in the wrong place). From Nirbhay Choubey

re-enable -Wconversion

pass -Wconversion

kill ifdef notdef

KNF return (\1); -> return \1;

kill ptr_t and ioctl_t, add * sizeof(*foo) to all allocations.

whitespace

Rename key to keymacro to avoid conflicts with term.h. The renaming of term
to terminal was again to avoid conflicts with term.h. term.h is a moving
namespace violation.

term -> terminal
XXX: need to rename key_ too.

Fix numeric variable handling in settc (lyzliyuzhi at 163 dot com)

use strlcpy() instead of strncpy() for gcc happiness

PR/54654: Soren Tempel: Make sure el_cursor.v < el_terminal.t_size.v when
moving around.

Fix type and remove cast (Yuichiro NAITO/FreeBSD).

PR/54399: S�ren Tempel: Uninitialized memory access in libedit history.
Initialize the buffer using calloc. While here change all malloc(a * sizeof(b))
to calloc(a, sizeof(b)). XXX: should fix realloc similarly.

Add a comment explaining why we don't use DO here. Correct the attribution
on the previous patch: The patch was from Jordan Lewis and the report from
Raphael Poss.

PR/54329: Raphael Ross: According to https://www.gnu.org/software/termutils/\
manual/termcap-1.3/html_chapter/termcap_4.html#SEC23 the cursor move multiple
escapes have undefined results when moving out of the screen. Stop using DO
to move down multiple lines and use a loop of newlines instead.

PR/52359: Benjamin Lorenz: When resizing because of a signal save and restore
the cursor position, since it does not change.

PR/53983: Jonathan Perkins: Fix types for readline compatibility

PR/53682: Jordan Lewis: use newlines instead of padded spaces when restoring
multi-line histories.

branches: 1.33.4; 1.33.6;
- handle literal escape sequence printing.
- factor out common code in allocation and freeing of the display.

branches: 1.32.8;
s/protected/libedit_private/g

eliminate static buffer with custom resizing code.

From Ingo Schwarze:
* Replace fcns.c by a shorter and simpler func.h
and include it only in the one file needing it, map.c.
* Combine help.h and help.c into a simplified help.h
and include it only in the one file needing it, map.c.
* Check the very simple, static files editline.c, historyn.c, and
tokenizern.c into CVS rather than needlessly generating them.
* So we no longer autogenerate any C files. :-)
* Shorten and simplify makelist by deleting the options -n, -e, -bc,
and -m; the latter was unused and useless in the first place.
* Move the declaration of el_func_t from fcns.h to the header
actually needing it, map.h. Since that header is already
included by el.h for unrelated reasons, that makes el_func_t
just as globally available as before.
* No longer include the simplified fcns.h into el.h,
include it directly into the *.c files needing it.

Get rid of private/public; keep protected (Ingo Schwarze)

Char -> wchar_t from Ingo Schwarze.

more macro WIDECHAR undoing from Ingo Schwarze.

More WIDECHAR elimination (Ingo Schwarze)

Start removing the WIDECHAR ifdefs; building without it has stopped working
anyway. (Ingo Schwarze)

put back NUL check (Ingo Schwarze)

PR/50880: David Binderman: Remove redundant code.
While here, fix all debugging formats.

whitespace and header sorting changes (Ingo Schwarze). No functional changes.

From Ingo Scharze:
Let "el.h" include everything needed for struct editline,
and don't include that stuff multiple times. That also improves
consistency, also avoids circular inclusions, and also makes it
easier to follow what is going on, even though not quite as nice.
But it seems like the best we can do...

cleanup chartype.h includes (Ingo Schwarze)

cleanup inclusion of histedit.h (Ingo Schwarze)

OpenBSD term.c rev. 1.7 2002/11/29 20:13:39 deraadt
spelling

OpenBSD term.c rev. 1.13 2009/12/11 18:58:59 jacekm
fix two memory leaks

From Ingo Schwarze:

As we have seen before, "histedit.h" can never get rid of including
the <wchar.h> header because using the data types defined there is
deeply ingrained in the public interfaces of libedit.

Now POSIX unconditionally requires that <wchar.h> defines the type
wint_t. Consequently, it can be used unconditionally, no matter
whether WIDECHAR is active or not. Consequently, the #define Int
is pointless.

Note that removing it is not gratuitious churn. Auditing for
integer signedness problems is already hard when only fundamental
types like "int" and "unsigned" are involved. It gets very hard
when types come into the picture that have platform-dependent
signedness, like "char" and "wint_t". Adding yet another layer
on top, changing both the signedness and the width in a platform-
dependent way, makes auditing yet harder, which IMHO is really
dangerous. Note that while removing the #define, i already found
one bug caused by this excessive complication - in the function
re_putc() in refresh.c. If WIDECHAR was defined, it printed an
Int = wint_t value with %c. Fortunately, that bug only affects
debugging, not production. The fix is contained in the patch.

With WIDECHAR, this doesn't change anything. For the case without
WIDECHAR, i checked that none of the places wants to store values
that might not fit in wint_t.

This only changes internal interfaces; public ones remain unchanged.

- Add some more Char casts
- reduce ifdefs by providing empty defs for nls functions (Ingo Schwarze)

don't include both term.h and termcap.h

From: Jilles Tjoelker: Add a mapping for the cursor delete key

Initialize termbuf (Kamil Dudka)

check for negative return of ct_visual_char (Kamil Dudka)

branches: 1.10.2;

fixed warnings where wint_t is unsigned.

fix broken change (parenthesis in the wrong place). From Nirbhay Choubey

re-enable -Wconversion

pass -Wconversion

kill ifdef notdef

KNF return (\1); -> return \1;

kill ptr_t and ioctl_t, add * sizeof(*foo) to all allocations.

whitespace

Rename key to keymacro to avoid conflicts with term.h. The renaming of term
to terminal was again to avoid conflicts with term.h. term.h is a moving
namespace violation.

term -> terminal
XXX: need to rename key_ too.

use strlcpy() instead of strncpy() for gcc happiness

PR/54654: Soren Tempel: Make sure el_cursor.v < el_terminal.t_size.v when
moving around.

Fix type and remove cast (Yuichiro NAITO/FreeBSD).

PR/54399: S�ren Tempel: Uninitialized memory access in libedit history.
Initialize the buffer using calloc. While here change all malloc(a * sizeof(b))
to calloc(a, sizeof(b)). XXX: should fix realloc similarly.

Add a comment explaining why we don't use DO here. Correct the attribution
on the previous patch: The patch was from Jordan Lewis and the report from
Raphael Poss.

PR/54329: Raphael Ross: According to https://www.gnu.org/software/termutils/\
manual/termcap-1.3/html_chapter/termcap_4.html#SEC23 the cursor move multiple
escapes have undefined results when moving out of the screen. Stop using DO
to move down multiple lines and use a loop of newlines instead.

PR/52359: Benjamin Lorenz: When resizing because of a signal save and restore
the cursor position, since it does not change.

PR/53983: Jonathan Perkins: Fix types for readline compatibility

PR/53682: Jordan Lewis: use newlines instead of padded spaces when restoring
multi-line histories.

branches: 1.33.4; 1.33.6;
- handle literal escape sequence printing.
- factor out common code in allocation and freeing of the display.

branches: 1.32.8;
s/protected/libedit_private/g

eliminate static buffer with custom resizing code.

From Ingo Schwarze:
* Replace fcns.c by a shorter and simpler func.h
and include it only in the one file needing it, map.c.
* Combine help.h and help.c into a simplified help.h
and include it only in the one file needing it, map.c.
* Check the very simple, static files editline.c, historyn.c, and
tokenizern.c into CVS rather than needlessly generating them.
* So we no longer autogenerate any C files. :-)
* Shorten and simplify makelist by deleting the options -n, -e, -bc,
and -m; the latter was unused and useless in the first place.
* Move the declaration of el_func_t from fcns.h to the header
actually needing it, map.h. Since that header is already
included by el.h for unrelated reasons, that makes el_func_t
just as globally available as before.
* No longer include the simplified fcns.h into el.h,
include it directly into the *.c files needing it.

Get rid of private/public; keep protected (Ingo Schwarze)

Char -> wchar_t from Ingo Schwarze.

more macro WIDECHAR undoing from Ingo Schwarze.

More WIDECHAR elimination (Ingo Schwarze)

Start removing the WIDECHAR ifdefs; building without it has stopped working
anyway. (Ingo Schwarze)

put back NUL check (Ingo Schwarze)

PR/50880: David Binderman: Remove redundant code.
While here, fix all debugging formats.

whitespace and header sorting changes (Ingo Schwarze). No functional changes.

From Ingo Scharze:
Let "el.h" include everything needed for struct editline,
and don't include that stuff multiple times. That also improves
consistency, also avoids circular inclusions, and also makes it
easier to follow what is going on, even though not quite as nice.
But it seems like the best we can do...

cleanup chartype.h includes (Ingo Schwarze)

cleanup inclusion of histedit.h (Ingo Schwarze)

OpenBSD term.c rev. 1.7 2002/11/29 20:13:39 deraadt
spelling

OpenBSD term.c rev. 1.13 2009/12/11 18:58:59 jacekm
fix two memory leaks

From Ingo Schwarze:

As we have seen before, "histedit.h" can never get rid of including
the <wchar.h> header because using the data types defined there is
deeply ingrained in the public interfaces of libedit.

Now POSIX unconditionally requires that <wchar.h> defines the type
wint_t. Consequently, it can be used unconditionally, no matter
whether WIDECHAR is active or not. Consequently, the #define Int
is pointless.

Note that removing it is not gratuitious churn. Auditing for
integer signedness problems is already hard when only fundamental
types like "int" and "unsigned" are involved. It gets very hard
when types come into the picture that have platform-dependent
signedness, like "char" and "wint_t". Adding yet another layer
on top, changing both the signedness and the width in a platform-
dependent way, makes auditing yet harder, which IMHO is really
dangerous. Note that while removing the #define, i already found
one bug caused by this excessive complication - in the function
re_putc() in refresh.c. If WIDECHAR was defined, it printed an
Int = wint_t value with %c. Fortunately, that bug only affects
debugging, not production. The fix is contained in the patch.

With WIDECHAR, this doesn't change anything. For the case without
WIDECHAR, i checked that none of the places wants to store values
that might not fit in wint_t.

This only changes internal interfaces; public ones remain unchanged.

- Add some more Char casts
- reduce ifdefs by providing empty defs for nls functions (Ingo Schwarze)

don't include both term.h and termcap.h

From: Jilles Tjoelker: Add a mapping for the cursor delete key

Initialize termbuf (Kamil Dudka)

check for negative return of ct_visual_char (Kamil Dudka)

branches: 1.10.2;

fixed warnings where wint_t is unsigned.

fix broken change (parenthesis in the wrong place). From Nirbhay Choubey

re-enable -Wconversion

pass -Wconversion

kill ifdef notdef

KNF return (\1); -> return \1;

kill ptr_t and ioctl_t, add * sizeof(*foo) to all allocations.

whitespace

Rename key to keymacro to avoid conflicts with term.h. The renaming of term
to terminal was again to avoid conflicts with term.h. term.h is a moving
namespace violation.

term -> terminal
XXX: need to rename key_ too.

PR/54654: Soren Tempel: Make sure el_cursor.v < el_terminal.t_size.v when
moving around.

Fix type and remove cast (Yuichiro NAITO/FreeBSD).

PR/54399: S�ren Tempel: Uninitialized memory access in libedit history.
Initialize the buffer using calloc. While here change all malloc(a * sizeof(b))
to calloc(a, sizeof(b)). XXX: should fix realloc similarly.

Add a comment explaining why we don't use DO here. Correct the attribution
on the previous patch: The patch was from Jordan Lewis and the report from
Raphael Poss.

PR/54329: Raphael Ross: According to https://www.gnu.org/software/termutils/\
manual/termcap-1.3/html_chapter/termcap_4.html#SEC23 the cursor move multiple
escapes have undefined results when moving out of the screen. Stop using DO
to move down multiple lines and use a loop of newlines instead.

PR/52359: Benjamin Lorenz: When resizing because of a signal save and restore
the cursor position, since it does not change.

PR/53983: Jonathan Perkins: Fix types for readline compatibility

PR/53682: Jordan Lewis: use newlines instead of padded spaces when restoring
multi-line histories.

branches: 1.33.4; 1.33.6;
- handle literal escape sequence printing.
- factor out common code in allocation and freeing of the display.

branches: 1.32.8;
s/protected/libedit_private/g

eliminate static buffer with custom resizing code.

From Ingo Schwarze:
* Replace fcns.c by a shorter and simpler func.h
and include it only in the one file needing it, map.c.
* Combine help.h and help.c into a simplified help.h
and include it only in the one file needing it, map.c.
* Check the very simple, static files editline.c, historyn.c, and
tokenizern.c into CVS rather than needlessly generating them.
* So we no longer autogenerate any C files. :-)
* Shorten and simplify makelist by deleting the options -n, -e, -bc,
and -m; the latter was unused and useless in the first place.
* Move the declaration of el_func_t from fcns.h to the header
actually needing it, map.h. Since that header is already
included by el.h for unrelated reasons, that makes el_func_t
just as globally available as before.
* No longer include the simplified fcns.h into el.h,
include it directly into the *.c files needing it.

Get rid of private/public; keep protected (Ingo Schwarze)

Char -> wchar_t from Ingo Schwarze.

more macro WIDECHAR undoing from Ingo Schwarze.

More WIDECHAR elimination (Ingo Schwarze)

Start removing the WIDECHAR ifdefs; building without it has stopped working
anyway. (Ingo Schwarze)

put back NUL check (Ingo Schwarze)

PR/50880: David Binderman: Remove redundant code.
While here, fix all debugging formats.

whitespace and header sorting changes (Ingo Schwarze). No functional changes.

From Ingo Scharze:
Let "el.h" include everything needed for struct editline,
and don't include that stuff multiple times. That also improves
consistency, also avoids circular inclusions, and also makes it
easier to follow what is going on, even though not quite as nice.
But it seems like the best we can do...

cleanup chartype.h includes (Ingo Schwarze)

cleanup inclusion of histedit.h (Ingo Schwarze)

OpenBSD term.c rev. 1.7 2002/11/29 20:13:39 deraadt
spelling

OpenBSD term.c rev. 1.13 2009/12/11 18:58:59 jacekm
fix two memory leaks

From Ingo Schwarze:

As we have seen before, "histedit.h" can never get rid of including
the <wchar.h> header because using the data types defined there is
deeply ingrained in the public interfaces of libedit.

Now POSIX unconditionally requires that <wchar.h> defines the type
wint_t. Consequently, it can be used unconditionally, no matter
whether WIDECHAR is active or not. Consequently, the #define Int
is pointless.

Note that removing it is not gratuitious churn. Auditing for
integer signedness problems is already hard when only fundamental
types like "int" and "unsigned" are involved. It gets very hard
when types come into the picture that have platform-dependent
signedness, like "char" and "wint_t". Adding yet another layer
on top, changing both the signedness and the width in a platform-
dependent way, makes auditing yet harder, which IMHO is really
dangerous. Note that while removing the #define, i already found
one bug caused by this excessive complication - in the function
re_putc() in refresh.c. If WIDECHAR was defined, it printed an
Int = wint_t value with %c. Fortunately, that bug only affects
debugging, not production. The fix is contained in the patch.

With WIDECHAR, this doesn't change anything. For the case without
WIDECHAR, i checked that none of the places wants to store values
that might not fit in wint_t.

This only changes internal interfaces; public ones remain unchanged.

- Add some more Char casts
- reduce ifdefs by providing empty defs for nls functions (Ingo Schwarze)

don't include both term.h and termcap.h

From: Jilles Tjoelker: Add a mapping for the cursor delete key

Initialize termbuf (Kamil Dudka)

check for negative return of ct_visual_char (Kamil Dudka)

branches: 1.10.2;

fixed warnings where wint_t is unsigned.

fix broken change (parenthesis in the wrong place). From Nirbhay Choubey

re-enable -Wconversion

pass -Wconversion

kill ifdef notdef

KNF return (\1); -> return \1;

kill ptr_t and ioctl_t, add * sizeof(*foo) to all allocations.

whitespace

Rename key to keymacro to avoid conflicts with term.h. The renaming of term
to terminal was again to avoid conflicts with term.h. term.h is a moving
namespace violation.

term -> terminal
XXX: need to rename key_ too.

Fix type and remove cast (Yuichiro NAITO/FreeBSD).

PR/54399: S�ren Tempel: Uninitialized memory access in libedit history.
Initialize the buffer using calloc. While here change all malloc(a * sizeof(b))
to calloc(a, sizeof(b)). XXX: should fix realloc similarly.

Add a comment explaining why we don't use DO here. Correct the attribution
on the previous patch: The patch was from Jordan Lewis and the report from
Raphael Poss.

PR/54329: Raphael Ross: According to https://www.gnu.org/software/termutils/\
manual/termcap-1.3/html_chapter/termcap_4.html#SEC23 the cursor move multiple
escapes have undefined results when moving out of the screen. Stop using DO
to move down multiple lines and use a loop of newlines instead.

PR/52359: Benjamin Lorenz: When resizing because of a signal save and restore
the cursor position, since it does not change.

PR/53983: Jonathan Perkins: Fix types for readline compatibility

PR/53682: Jordan Lewis: use newlines instead of padded spaces when restoring
multi-line histories.

branches: 1.33.4; 1.33.6;
- handle literal escape sequence printing.
- factor out common code in allocation and freeing of the display.

branches: 1.32.8;
s/protected/libedit_private/g

eliminate static buffer with custom resizing code.

From Ingo Schwarze:
* Replace fcns.c by a shorter and simpler func.h
and include it only in the one file needing it, map.c.
* Combine help.h and help.c into a simplified help.h
and include it only in the one file needing it, map.c.
* Check the very simple, static files editline.c, historyn.c, and
tokenizern.c into CVS rather than needlessly generating them.
* So we no longer autogenerate any C files. :-)
* Shorten and simplify makelist by deleting the options -n, -e, -bc,
and -m; the latter was unused and useless in the first place.
* Move the declaration of el_func_t from fcns.h to the header
actually needing it, map.h. Since that header is already
included by el.h for unrelated reasons, that makes el_func_t
just as globally available as before.
* No longer include the simplified fcns.h into el.h,
include it directly into the *.c files needing it.

Get rid of private/public; keep protected (Ingo Schwarze)

Char -> wchar_t from Ingo Schwarze.

more macro WIDECHAR undoing from Ingo Schwarze.

More WIDECHAR elimination (Ingo Schwarze)

Start removing the WIDECHAR ifdefs; building without it has stopped working
anyway. (Ingo Schwarze)

put back NUL check (Ingo Schwarze)

PR/50880: David Binderman: Remove redundant code.
While here, fix all debugging formats.

whitespace and header sorting changes (Ingo Schwarze). No functional changes.

From Ingo Scharze:
Let "el.h" include everything needed for struct editline,
and don't include that stuff multiple times. That also improves
consistency, also avoids circular inclusions, and also makes it
easier to follow what is going on, even though not quite as nice.
But it seems like the best we can do...

cleanup chartype.h includes (Ingo Schwarze)

cleanup inclusion of histedit.h (Ingo Schwarze)

OpenBSD term.c rev. 1.7 2002/11/29 20:13:39 deraadt
spelling

OpenBSD term.c rev. 1.13 2009/12/11 18:58:59 jacekm
fix two memory leaks

From Ingo Schwarze:

As we have seen before, "histedit.h" can never get rid of including
the <wchar.h> header because using the data types defined there is
deeply ingrained in the public interfaces of libedit.

Now POSIX unconditionally requires that <wchar.h> defines the type
wint_t. Consequently, it can be used unconditionally, no matter
whether WIDECHAR is active or not. Consequently, the #define Int
is pointless.

Note that removing it is not gratuitious churn. Auditing for
integer signedness problems is already hard when only fundamental
types like "int" and "unsigned" are involved. It gets very hard
when types come into the picture that have platform-dependent
signedness, like "char" and "wint_t". Adding yet another layer
on top, changing both the signedness and the width in a platform-
dependent way, makes auditing yet harder, which IMHO is really
dangerous. Note that while removing the #define, i already found
one bug caused by this excessive complication - in the function
re_putc() in refresh.c. If WIDECHAR was defined, it printed an
Int = wint_t value with %c. Fortunately, that bug only affects
debugging, not production. The fix is contained in the patch.

With WIDECHAR, this doesn't change anything. For the case without
WIDECHAR, i checked that none of the places wants to store values
that might not fit in wint_t.

This only changes internal interfaces; public ones remain unchanged.

- Add some more Char casts
- reduce ifdefs by providing empty defs for nls functions (Ingo Schwarze)

don't include both term.h and termcap.h

From: Jilles Tjoelker: Add a mapping for the cursor delete key

Initialize termbuf (Kamil Dudka)

check for negative return of ct_visual_char (Kamil Dudka)

branches: 1.10.2;

fixed warnings where wint_t is unsigned.

fix broken change (parenthesis in the wrong place). From Nirbhay Choubey

re-enable -Wconversion

pass -Wconversion

kill ifdef notdef

KNF return (\1); -> return \1;

kill ptr_t and ioctl_t, add * sizeof(*foo) to all allocations.

whitespace

Rename key to keymacro to avoid conflicts with term.h. The renaming of term
to terminal was again to avoid conflicts with term.h. term.h is a moving
namespace violation.

term -> terminal
XXX: need to rename key_ too.

PR/54399: S�ren Tempel: Uninitialized memory access in libedit history.
Initialize the buffer using calloc. While here change all malloc(a * sizeof(b))
to calloc(a, sizeof(b)). XXX: should fix realloc similarly.

Add a comment explaining why we don't use DO here. Correct the attribution
on the previous patch: The patch was from Jordan Lewis and the report from
Raphael Poss.

PR/54329: Raphael Ross: According to https://www.gnu.org/software/termutils/\
manual/termcap-1.3/html_chapter/termcap_4.html#SEC23 the cursor move multiple
escapes have undefined results when moving out of the screen. Stop using DO
to move down multiple lines and use a loop of newlines instead.

PR/52359: Benjamin Lorenz: When resizing because of a signal save and restore
the cursor position, since it does not change.

PR/53983: Jonathan Perkins: Fix types for readline compatibility

PR/53682: Jordan Lewis: use newlines instead of padded spaces when restoring
multi-line histories.

branches: 1.33.4; 1.33.6;
- handle literal escape sequence printing.
- factor out common code in allocation and freeing of the display.

branches: 1.32.8;
s/protected/libedit_private/g

eliminate static buffer with custom resizing code.

From Ingo Schwarze:
* Replace fcns.c by a shorter and simpler func.h
and include it only in the one file needing it, map.c.
* Combine help.h and help.c into a simplified help.h
and include it only in the one file needing it, map.c.
* Check the very simple, static files editline.c, historyn.c, and
tokenizern.c into CVS rather than needlessly generating them.
* So we no longer autogenerate any C files. :-)
* Shorten and simplify makelist by deleting the options -n, -e, -bc,
and -m; the latter was unused and useless in the first place.
* Move the declaration of el_func_t from fcns.h to the header
actually needing it, map.h. Since that header is already
included by el.h for unrelated reasons, that makes el_func_t
just as globally available as before.
* No longer include the simplified fcns.h into el.h,
include it directly into the *.c files needing it.

Get rid of private/public; keep protected (Ingo Schwarze)

Char -> wchar_t from Ingo Schwarze.

more macro WIDECHAR undoing from Ingo Schwarze.

More WIDECHAR elimination (Ingo Schwarze)

Start removing the WIDECHAR ifdefs; building without it has stopped working
anyway. (Ingo Schwarze)

put back NUL check (Ingo Schwarze)

PR/50880: David Binderman: Remove redundant code.
While here, fix all debugging formats.

whitespace and header sorting changes (Ingo Schwarze). No functional changes.

From Ingo Scharze:
Let "el.h" include everything needed for struct editline,
and don't include that stuff multiple times. That also improves
consistency, also avoids circular inclusions, and also makes it
easier to follow what is going on, even though not quite as nice.
But it seems like the best we can do...

cleanup chartype.h includes (Ingo Schwarze)

cleanup inclusion of histedit.h (Ingo Schwarze)

OpenBSD term.c rev. 1.7 2002/11/29 20:13:39 deraadt
spelling

OpenBSD term.c rev. 1.13 2009/12/11 18:58:59 jacekm
fix two memory leaks

From Ingo Schwarze:

As we have seen before, "histedit.h" can never get rid of including
the <wchar.h> header because using the data types defined there is
deeply ingrained in the public interfaces of libedit.

Now POSIX unconditionally requires that <wchar.h> defines the type
wint_t. Consequently, it can be used unconditionally, no matter
whether WIDECHAR is active or not. Consequently, the #define Int
is pointless.

Note that removing it is not gratuitious churn. Auditing for
integer signedness problems is already hard when only fundamental
types like "int" and "unsigned" are involved. It gets very hard
when types come into the picture that have platform-dependent
signedness, like "char" and "wint_t". Adding yet another layer
on top, changing both the signedness and the width in a platform-
dependent way, makes auditing yet harder, which IMHO is really
dangerous. Note that while removing the #define, i already found
one bug caused by this excessive complication - in the function
re_putc() in refresh.c. If WIDECHAR was defined, it printed an
Int = wint_t value with %c. Fortunately, that bug only affects
debugging, not production. The fix is contained in the patch.

With WIDECHAR, this doesn't change anything. For the case without
WIDECHAR, i checked that none of the places wants to store values
that might not fit in wint_t.

This only changes internal interfaces; public ones remain unchanged.

- Add some more Char casts
- reduce ifdefs by providing empty defs for nls functions (Ingo Schwarze)

don't include both term.h and termcap.h

From: Jilles Tjoelker: Add a mapping for the cursor delete key

Initialize termbuf (Kamil Dudka)

check for negative return of ct_visual_char (Kamil Dudka)

branches: 1.10.2;

fixed warnings where wint_t is unsigned.

fix broken change (parenthesis in the wrong place). From Nirbhay Choubey

re-enable -Wconversion

pass -Wconversion

kill ifdef notdef

KNF return (\1); -> return \1;

kill ptr_t and ioctl_t, add * sizeof(*foo) to all allocations.

whitespace

Rename key to keymacro to avoid conflicts with term.h. The renaming of term
to terminal was again to avoid conflicts with term.h. term.h is a moving
namespace violation.

term -> terminal
XXX: need to rename key_ too.

Add a comment explaining why we don't use DO here. Correct the attribution
on the previous patch: The patch was from Jordan Lewis and the report from
Raphael Poss.

PR/54329: Raphael Ross: According to https://www.gnu.org/software/termutils/\
manual/termcap-1.3/html_chapter/termcap_4.html#SEC23 the cursor move multiple
escapes have undefined results when moving out of the screen. Stop using DO
to move down multiple lines and use a loop of newlines instead.

PR/52359: Benjamin Lorenz: When resizing because of a signal save and restore
the cursor position, since it does not change.

PR/53983: Jonathan Perkins: Fix types for readline compatibility

PR/53682: Jordan Lewis: use newlines instead of padded spaces when restoring
multi-line histories.

branches: 1.33.4; 1.33.6;
- handle literal escape sequence printing.
- factor out common code in allocation and freeing of the display.

branches: 1.32.8;
s/protected/libedit_private/g

eliminate static buffer with custom resizing code.

From Ingo Schwarze:
* Replace fcns.c by a shorter and simpler func.h
and include it only in the one file needing it, map.c.
* Combine help.h and help.c into a simplified help.h
and include it only in the one file needing it, map.c.
* Check the very simple, static files editline.c, historyn.c, and
tokenizern.c into CVS rather than needlessly generating them.
* So we no longer autogenerate any C files. :-)
* Shorten and simplify makelist by deleting the options -n, -e, -bc,
and -m; the latter was unused and useless in the first place.
* Move the declaration of el_func_t from fcns.h to the header
actually needing it, map.h. Since that header is already
included by el.h for unrelated reasons, that makes el_func_t
just as globally available as before.
* No longer include the simplified fcns.h into el.h,
include it directly into the *.c files needing it.

Get rid of private/public; keep protected (Ingo Schwarze)

Char -> wchar_t from Ingo Schwarze.

more macro WIDECHAR undoing from Ingo Schwarze.

More WIDECHAR elimination (Ingo Schwarze)

Start removing the WIDECHAR ifdefs; building without it has stopped working
anyway. (Ingo Schwarze)

put back NUL check (Ingo Schwarze)

PR/50880: David Binderman: Remove redundant code.
While here, fix all debugging formats.

whitespace and header sorting changes (Ingo Schwarze). No functional changes.

From Ingo Scharze:
Let "el.h" include everything needed for struct editline,
and don't include that stuff multiple times. That also improves
consistency, also avoids circular inclusions, and also makes it
easier to follow what is going on, even though not quite as nice.
But it seems like the best we can do...

cleanup chartype.h includes (Ingo Schwarze)

cleanup inclusion of histedit.h (Ingo Schwarze)

OpenBSD term.c rev. 1.7 2002/11/29 20:13:39 deraadt
spelling

OpenBSD term.c rev. 1.13 2009/12/11 18:58:59 jacekm
fix two memory leaks

From Ingo Schwarze:

As we have seen before, "histedit.h" can never get rid of including
the <wchar.h> header because using the data types defined there is
deeply ingrained in the public interfaces of libedit.

Now POSIX unconditionally requires that <wchar.h> defines the type
wint_t. Consequently, it can be used unconditionally, no matter
whether WIDECHAR is active or not. Consequently, the #define Int
is pointless.

Note that removing it is not gratuitious churn. Auditing for
integer signedness problems is already hard when only fundamental
types like "int" and "unsigned" are involved. It gets very hard
when types come into the picture that have platform-dependent
signedness, like "char" and "wint_t". Adding yet another layer
on top, changing both the signedness and the width in a platform-
dependent way, makes auditing yet harder, which IMHO is really
dangerous. Note that while removing the #define, i already found
one bug caused by this excessive complication - in the function
re_putc() in refresh.c. If WIDECHAR was defined, it printed an
Int = wint_t value with %c. Fortunately, that bug only affects
debugging, not production. The fix is contained in the patch.

With WIDECHAR, this doesn't change anything. For the case without
WIDECHAR, i checked that none of the places wants to store values
that might not fit in wint_t.

This only changes internal interfaces; public ones remain unchanged.

- Add some more Char casts
- reduce ifdefs by providing empty defs for nls functions (Ingo Schwarze)

don't include both term.h and termcap.h

From: Jilles Tjoelker: Add a mapping for the cursor delete key

Initialize termbuf (Kamil Dudka)

check for negative return of ct_visual_char (Kamil Dudka)

branches: 1.10.2;

fixed warnings where wint_t is unsigned.

fix broken change (parenthesis in the wrong place). From Nirbhay Choubey

re-enable -Wconversion

pass -Wconversion

kill ifdef notdef

KNF return (\1); -> return \1;

kill ptr_t and ioctl_t, add * sizeof(*foo) to all allocations.

whitespace

Rename key to keymacro to avoid conflicts with term.h. The renaming of term
to terminal was again to avoid conflicts with term.h. term.h is a moving
namespace violation.

term -> terminal
XXX: need to rename key_ too.

PR/54329: Raphael Ross: According to https://www.gnu.org/software/termutils/\
manual/termcap-1.3/html_chapter/termcap_4.html#SEC23 the cursor move multiple
escapes have undefined results when moving out of the screen. Stop using DO
to move down multiple lines and use a loop of newlines instead.

PR/52359: Benjamin Lorenz: When resizing because of a signal save and restore
the cursor position, since it does not change.

PR/53983: Jonathan Perkins: Fix types for readline compatibility

PR/53682: Jordan Lewis: use newlines instead of padded spaces when restoring
multi-line histories.

branches: 1.33.4; 1.33.6;
- handle literal escape sequence printing.
- factor out common code in allocation and freeing of the display.

branches: 1.32.8;
s/protected/libedit_private/g

eliminate static buffer with custom resizing code.

From Ingo Schwarze:
* Replace fcns.c by a shorter and simpler func.h
and include it only in the one file needing it, map.c.
* Combine help.h and help.c into a simplified help.h
and include it only in the one file needing it, map.c.
* Check the very simple, static files editline.c, historyn.c, and
tokenizern.c into CVS rather than needlessly generating them.
* So we no longer autogenerate any C files. :-)
* Shorten and simplify makelist by deleting the options -n, -e, -bc,
and -m; the latter was unused and useless in the first place.
* Move the declaration of el_func_t from fcns.h to the header
actually needing it, map.h. Since that header is already
included by el.h for unrelated reasons, that makes el_func_t
just as globally available as before.
* No longer include the simplified fcns.h into el.h,
include it directly into the *.c files needing it.

Get rid of private/public; keep protected (Ingo Schwarze)

Char -> wchar_t from Ingo Schwarze.

more macro WIDECHAR undoing from Ingo Schwarze.

More WIDECHAR elimination (Ingo Schwarze)

Start removing the WIDECHAR ifdefs; building without it has stopped working
anyway. (Ingo Schwarze)

put back NUL check (Ingo Schwarze)

PR/50880: David Binderman: Remove redundant code.
While here, fix all debugging formats.

whitespace and header sorting changes (Ingo Schwarze). No functional changes.

From Ingo Scharze:
Let "el.h" include everything needed for struct editline,
and don't include that stuff multiple times. That also improves
consistency, also avoids circular inclusions, and also makes it
easier to follow what is going on, even though not quite as nice.
But it seems like the best we can do...

cleanup chartype.h includes (Ingo Schwarze)

cleanup inclusion of histedit.h (Ingo Schwarze)

OpenBSD term.c rev. 1.7 2002/11/29 20:13:39 deraadt
spelling

OpenBSD term.c rev. 1.13 2009/12/11 18:58:59 jacekm
fix two memory leaks

From Ingo Schwarze:

As we have seen before, "histedit.h" can never get rid of including
the <wchar.h> header because using the data types defined there is
deeply ingrained in the public interfaces of libedit.

Now POSIX unconditionally requires that <wchar.h> defines the type
wint_t. Consequently, it can be used unconditionally, no matter
whether WIDECHAR is active or not. Consequently, the #define Int
is pointless.

Note that removing it is not gratuitious churn. Auditing for
integer signedness problems is already hard when only fundamental
types like "int" and "unsigned" are involved. It gets very hard
when types come into the picture that have platform-dependent
signedness, like "char" and "wint_t". Adding yet another layer
on top, changing both the signedness and the width in a platform-
dependent way, makes auditing yet harder, which IMHO is really
dangerous. Note that while removing the #define, i already found
one bug caused by this excessive complication - in the function
re_putc() in refresh.c. If WIDECHAR was defined, it printed an
Int = wint_t value with %c. Fortunately, that bug only affects
debugging, not production. The fix is contained in the patch.

With WIDECHAR, this doesn't change anything. For the case without
WIDECHAR, i checked that none of the places wants to store values
that might not fit in wint_t.

This only changes internal interfaces; public ones remain unchanged.

- Add some more Char casts
- reduce ifdefs by providing empty defs for nls functions (Ingo Schwarze)

don't include both term.h and termcap.h

From: Jilles Tjoelker: Add a mapping for the cursor delete key

Initialize termbuf (Kamil Dudka)

check for negative return of ct_visual_char (Kamil Dudka)

branches: 1.10.2;

fixed warnings where wint_t is unsigned.

fix broken change (parenthesis in the wrong place). From Nirbhay Choubey

re-enable -Wconversion

pass -Wconversion

kill ifdef notdef

KNF return (\1); -> return \1;

kill ptr_t and ioctl_t, add * sizeof(*foo) to all allocations.

whitespace

Rename key to keymacro to avoid conflicts with term.h. The renaming of term
to terminal was again to avoid conflicts with term.h. term.h is a moving
namespace violation.

term -> terminal
XXX: need to rename key_ too.

PR/52359: Benjamin Lorenz: When resizing because of a signal save and restore
the cursor position, since it does not change.

PR/53983: Jonathan Perkins: Fix types for readline compatibility

PR/53682: Jordan Lewis: use newlines instead of padded spaces when restoring
multi-line histories.

branches: 1.33.4;
- handle literal escape sequence printing.
- factor out common code in allocation and freeing of the display.

branches: 1.32.8;
s/protected/libedit_private/g

eliminate static buffer with custom resizing code.

From Ingo Schwarze:
* Replace fcns.c by a shorter and simpler func.h
and include it only in the one file needing it, map.c.
* Combine help.h and help.c into a simplified help.h
and include it only in the one file needing it, map.c.
* Check the very simple, static files editline.c, historyn.c, and
tokenizern.c into CVS rather than needlessly generating them.
* So we no longer autogenerate any C files. :-)
* Shorten and simplify makelist by deleting the options -n, -e, -bc,
and -m; the latter was unused and useless in the first place.
* Move the declaration of el_func_t from fcns.h to the header
actually needing it, map.h. Since that header is already
included by el.h for unrelated reasons, that makes el_func_t
just as globally available as before.
* No longer include the simplified fcns.h into el.h,
include it directly into the *.c files needing it.

Get rid of private/public; keep protected (Ingo Schwarze)

Char -> wchar_t from Ingo Schwarze.

more macro WIDECHAR undoing from Ingo Schwarze.

More WIDECHAR elimination (Ingo Schwarze)

Start removing the WIDECHAR ifdefs; building without it has stopped working
anyway. (Ingo Schwarze)

put back NUL check (Ingo Schwarze)

PR/50880: David Binderman: Remove redundant code.
While here, fix all debugging formats.

whitespace and header sorting changes (Ingo Schwarze). No functional changes.

From Ingo Scharze:
Let "el.h" include everything needed for struct editline,
and don't include that stuff multiple times. That also improves
consistency, also avoids circular inclusions, and also makes it
easier to follow what is going on, even though not quite as nice.
But it seems like the best we can do...

cleanup chartype.h includes (Ingo Schwarze)

cleanup inclusion of histedit.h (Ingo Schwarze)

OpenBSD term.c rev. 1.7 2002/11/29 20:13:39 deraadt
spelling

OpenBSD term.c rev. 1.13 2009/12/11 18:58:59 jacekm
fix two memory leaks

From Ingo Schwarze:

As we have seen before, "histedit.h" can never get rid of including
the <wchar.h> header because using the data types defined there is
deeply ingrained in the public interfaces of libedit.

Now POSIX unconditionally requires that <wchar.h> defines the type
wint_t. Consequently, it can be used unconditionally, no matter
whether WIDECHAR is active or not. Consequently, the #define Int
is pointless.

Note that removing it is not gratuitious churn. Auditing for
integer signedness problems is already hard when only fundamental
types like "int" and "unsigned" are involved. It gets very hard
when types come into the picture that have platform-dependent
signedness, like "char" and "wint_t". Adding yet another layer
on top, changing both the signedness and the width in a platform-
dependent way, makes auditing yet harder, which IMHO is really
dangerous. Note that while removing the #define, i already found
one bug caused by this excessive complication - in the function
re_putc() in refresh.c. If WIDECHAR was defined, it printed an
Int = wint_t value with %c. Fortunately, that bug only affects
debugging, not production. The fix is contained in the patch.

With WIDECHAR, this doesn't change anything. For the case without
WIDECHAR, i checked that none of the places wants to store values
that might not fit in wint_t.

This only changes internal interfaces; public ones remain unchanged.

- Add some more Char casts
- reduce ifdefs by providing empty defs for nls functions (Ingo Schwarze)

don't include both term.h and termcap.h

From: Jilles Tjoelker: Add a mapping for the cursor delete key

Initialize termbuf (Kamil Dudka)

check for negative return of ct_visual_char (Kamil Dudka)

branches: 1.10.2;

fixed warnings where wint_t is unsigned.

fix broken change (parenthesis in the wrong place). From Nirbhay Choubey

re-enable -Wconversion

pass -Wconversion

kill ifdef notdef

KNF return (\1); -> return \1;

kill ptr_t and ioctl_t, add * sizeof(*foo) to all allocations.

whitespace

Rename key to keymacro to avoid conflicts with term.h. The renaming of term
to terminal was again to avoid conflicts with term.h. term.h is a moving
namespace violation.

term -> terminal
XXX: need to rename key_ too.