Catch up with all the lint warnings since exit on warning was disabled.
Disable 'missing header declaration' and 'nested extern' warnings for now.

include <sys/stat.h>

branches: 1.20.2;
add a couple of casts.

Fix "shadows a global declaration" compile error.

add mkostemp, mkostemps, mkstemps from FreeBSD.

branches: 1.17.2;
Handle case where a 0 length template string or a template
of all 'X' would dereference, and maybe assign to, memory
before the template. Simplify.

PR/47757: Eric Radman: mktemp(3) mangles the pathname if not given an absolute
path
1. on error, gettemp() did not restore the path string
2. when emulating mktemp() it is not an error for the pattern not to represent
a real directory structure
XXX[1]: pullup-5, pullup-6
XXX[2]: the default pattern is the simplistic <pid><X> for mktemp.

branches: 1.15.2;
- ansify, knf.
- no functional changes

branches: 1.14.2; 1.14.4; 1.14.20; 1.14.22;
The tools/compat versions of mkstemp() and mkdtemp() need to call the
internal function that's usually named "__gettemp". However in a cross
build, "__gettemp" is in a namespace reserved for the host system, so we
can't use that. Use "__nbcompat_gettemp" instead, following the example
of several other functions or macros in tools/compat. Previously, this
was handled by using the name "gettemp", but that conflicts with the
local gettemp() function in dist/nawk.

Spaces.

Overhaul how `build.sh tools' are used:

* Rename "config.h" to "nbtool_config.h" and
HAVE_CONFIG_H to HAVE_NBTOOL_CONFIG_H.
This makes in more obvious in the source when we're using
tools/compat/config.h versus "standard autoconf" config.h

* Consistently move the inclusion of nbtool_config.h to before
<sys/cdefs.h> so that the former can provide __RCSID() (et al),
and there's no need to protect those macros any more.

These changes should make it easier to "tool-ify" a program by adding:
#if HAVE_NBTOOL_CONFIG_H
#include "nbtool_config.h"
#endif
to the top of the source files (for the general case).

Move include for reentrant.h inside CONFIG_H test so this works correctly
with tools/compat. Fixes PR#21344

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22280, verified by myself.

Merge the nathanw_sa branch.

Allow mktemp to be built as a host tool.

branches: 1.7.2;
Revert addition of mkdtemp() to libnbcompat. I don't think we need mktemp(1)
after all.

Add mkdtemp to libnbcompat, since glibc doesn't have it an mktemp(1) will
need it.

branches: 1.5.10;
back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

braces for gcc-2.8.1

Add a mktempdir(), like mkstemp(), but it creates a directory.

If AUDIT, do not compile certain functions.

include <sys/stat.h>

add a couple of casts.

Fix "shadows a global declaration" compile error.

add mkostemp, mkostemps, mkstemps from FreeBSD.

branches: 1.17.2;
Handle case where a 0 length template string or a template
of all 'X' would dereference, and maybe assign to, memory
before the template. Simplify.

PR/47757: Eric Radman: mktemp(3) mangles the pathname if not given an absolute
path
1. on error, gettemp() did not restore the path string
2. when emulating mktemp() it is not an error for the pattern not to represent
a real directory structure
XXX[1]: pullup-5, pullup-6
XXX[2]: the default pattern is the simplistic <pid><X> for mktemp.

branches: 1.15.2;
- ansify, knf.
- no functional changes

branches: 1.14.2; 1.14.4; 1.14.20; 1.14.22;
The tools/compat versions of mkstemp() and mkdtemp() need to call the
internal function that's usually named "__gettemp". However in a cross
build, "__gettemp" is in a namespace reserved for the host system, so we
can't use that. Use "__nbcompat_gettemp" instead, following the example
of several other functions or macros in tools/compat. Previously, this
was handled by using the name "gettemp", but that conflicts with the
local gettemp() function in dist/nawk.

Spaces.

Overhaul how `build.sh tools' are used:

* Rename "config.h" to "nbtool_config.h" and
HAVE_CONFIG_H to HAVE_NBTOOL_CONFIG_H.
This makes in more obvious in the source when we're using
tools/compat/config.h versus "standard autoconf" config.h

* Consistently move the inclusion of nbtool_config.h to before
<sys/cdefs.h> so that the former can provide __RCSID() (et al),
and there's no need to protect those macros any more.

These changes should make it easier to "tool-ify" a program by adding:
#if HAVE_NBTOOL_CONFIG_H
#include "nbtool_config.h"
#endif
to the top of the source files (for the general case).

Move include for reentrant.h inside CONFIG_H test so this works correctly
with tools/compat. Fixes PR#21344

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22280, verified by myself.

Merge the nathanw_sa branch.

Allow mktemp to be built as a host tool.

branches: 1.7.2;
Revert addition of mkdtemp() to libnbcompat. I don't think we need mktemp(1)
after all.

Add mkdtemp to libnbcompat, since glibc doesn't have it an mktemp(1) will
need it.

branches: 1.5.10;
back out the #ifdef _DIAGNOSTIC argument checks; too many people complained.
_DIAGASSERT() is still retained.

* use _DIAGASSERT() to check pointer arguments against NULL and file
descriptors against -1 (as appropriate).
* add actual checks which to detect stuff that would trigger_DIAGASSERT(),
and attempt to return a sane error condition.
* knf some code
* remove some `register' decls.

the first two items result in the addition of code similar to the
following in various functions:

_DIAGASSERT(path != NULL)
#ifdef _DIAGNOSTIC
if (path == NULL) {
errno = EFAULT;
return (-1);
}
#endif

braces for gcc-2.8.1

Add a mktempdir(), like mkstemp(), but it creates a directory.

If AUDIT, do not compile certain functions.