fix nested extern warnings

s/listner/listener/

introduce a SOL_LOCAL for unix-domain socket level socket options
as an alias of the current 0 used for these options, as in FreeBSD.

reviewed by many.

fix compilation/lint

PR/50408: Pedro Giffuni: Provide a way for rpc to use poll(2) instead of
select(2), and the linux svc_pollfd and svc_maxpollfd members. Our select(2)
implementation does not suffer from the FD_SETSIZE limitation so this is
not turned on by default.

check for errors and recover instead of core-dumping.

- Provide multi-threaded fdset's for everyone not just rump if requested.
- Abstract fd_set access, and don't limit the fd_set size.
- Maintain binary compatibility by keeping the old global variables around.

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

make this usable from RUMP

PR/47617: Thorsten Brehm: Memory and socket leak in librpc

fix error messages and warnings.

branches: 1.26.2;
Use C89 definitions
Remove use of __P

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.24.4; 1.24.6;
PR/44514: Andrey Simonenko: Buffer underflow in RPC library for non-blocking
TCP sockets

knf - no functional changes

branches: 1.22.2;
sign-compare fix

branches: 1.21.8; 1.21.10;
- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.20.16;
Only retry if we were able to clean up some descriptors, otherwise we get
into an infinite loop.

Centralize the TCP_NODELAY handling as discussed in tech-net.

-fix uninitialized variable introduced in previous
(found by gcc:-)
-minor prototype cleanup

Coverity CID 2291: Move function call before allocating storage to prevent
memory leak on error.

Coverity CID 2292: Plug memory leak.

XXXGCC: Make a local extern for abort and the vax compiler is happy again.

fix a typo , instead of ; From Johnny Billquist

Convert the rest of the code to use pollts for consistency. XXX: We should
really use kqueue.

branches: 1.12.6; 1.12.10;
Merge the nathanw_sa branch.

Add extern svc_fd_lock if __REENT and include rpc_internal.h only once.

* Adapt include files for rpc_com.h/rpc_internal.h split.
* Add rpc_control to svc.c
* Implement non-blocking connections.

branches: 1.9.2;
Fix spelling mistake (from Onno van der Linden; PR#15793).

branches: 1.8.2;
whitespace consistency fixups

For an accepted connection (tcp), set xp_netid, as it might be examined
by some applications, most notably rpcbind.

De-delint previous: svc_vc_rendezvous_ops() isn't unused unless the single
reference to it is accidently deleted; from Shuuichirou Murata in PR lib/10537.

add __RPC_GETXID macro
don't const castway __rpc_getconf and __rpc_getconfig. It might try to
write const strings
fix non-portable casts
remove duplicated prototypes
cast things to proper types
remove extraneous casts to NULL
fix variable cast mismatches
remove register var declarations

branches: 1.4.2; 1.4.4;
Correct misleading error messages.

- An initialized variable kept LOCAL_CREDS from being set on
the listen socket properly. This caused spurious rpcbind(8)
failures.
- Don't define a "credmsg" structure. Instead, dynamically
allocate a buffer of the correct size of the message with
CMSG_SPACE() and free it when we're done. This gets the
size of the buffer right on LP64 platforms, which has padding
for alignment thrown in.
- Check for non-present or truncated cred messages when recvmsg(2)
returns.

Zero out the xprt in makefd_xprt to avoid bad free() calls in some cases.

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

s/listner/listener/

introduce a SOL_LOCAL for unix-domain socket level socket options
as an alias of the current 0 used for these options, as in FreeBSD.

reviewed by many.

fix compilation/lint

PR/50408: Pedro Giffuni: Provide a way for rpc to use poll(2) instead of
select(2), and the linux svc_pollfd and svc_maxpollfd members. Our select(2)
implementation does not suffer from the FD_SETSIZE limitation so this is
not turned on by default.

check for errors and recover instead of core-dumping.

- Provide multi-threaded fdset's for everyone not just rump if requested.
- Abstract fd_set access, and don't limit the fd_set size.
- Maintain binary compatibility by keeping the old global variables around.

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

make this usable from RUMP

PR/47617: Thorsten Brehm: Memory and socket leak in librpc

fix error messages and warnings.

branches: 1.26.2;
Use C89 definitions
Remove use of __P

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.24.4; 1.24.6;
PR/44514: Andrey Simonenko: Buffer underflow in RPC library for non-blocking
TCP sockets

knf - no functional changes

branches: 1.22.2;
sign-compare fix

branches: 1.21.8; 1.21.10;
- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.20.16;
Only retry if we were able to clean up some descriptors, otherwise we get
into an infinite loop.

Centralize the TCP_NODELAY handling as discussed in tech-net.

-fix uninitialized variable introduced in previous
(found by gcc:-)
-minor prototype cleanup

Coverity CID 2291: Move function call before allocating storage to prevent
memory leak on error.

Coverity CID 2292: Plug memory leak.

XXXGCC: Make a local extern for abort and the vax compiler is happy again.

fix a typo , instead of ; From Johnny Billquist

Convert the rest of the code to use pollts for consistency. XXX: We should
really use kqueue.

branches: 1.12.6; 1.12.10;
Merge the nathanw_sa branch.

Add extern svc_fd_lock if __REENT and include rpc_internal.h only once.

* Adapt include files for rpc_com.h/rpc_internal.h split.
* Add rpc_control to svc.c
* Implement non-blocking connections.

branches: 1.9.2;
Fix spelling mistake (from Onno van der Linden; PR#15793).

branches: 1.8.2;
whitespace consistency fixups

For an accepted connection (tcp), set xp_netid, as it might be examined
by some applications, most notably rpcbind.

De-delint previous: svc_vc_rendezvous_ops() isn't unused unless the single
reference to it is accidently deleted; from Shuuichirou Murata in PR lib/10537.

add __RPC_GETXID macro
don't const castway __rpc_getconf and __rpc_getconfig. It might try to
write const strings
fix non-portable casts
remove duplicated prototypes
cast things to proper types
remove extraneous casts to NULL
fix variable cast mismatches
remove register var declarations

branches: 1.4.2; 1.4.4;
Correct misleading error messages.

- An initialized variable kept LOCAL_CREDS from being set on
the listen socket properly. This caused spurious rpcbind(8)
failures.
- Don't define a "credmsg" structure. Instead, dynamically
allocate a buffer of the correct size of the message with
CMSG_SPACE() and free it when we're done. This gets the
size of the buffer right on LP64 platforms, which has padding
for alignment thrown in.
- Check for non-present or truncated cred messages when recvmsg(2)
returns.

Zero out the xprt in makefd_xprt to avoid bad free() calls in some cases.

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

introduce a SOL_LOCAL for unix-domain socket level socket options
as an alias of the current 0 used for these options, as in FreeBSD.

reviewed by many.

fix compilation/lint

PR/50408: Pedro Giffuni: Provide a way for rpc to use poll(2) instead of
select(2), and the linux svc_pollfd and svc_maxpollfd members. Our select(2)
implementation does not suffer from the FD_SETSIZE limitation so this is
not turned on by default.

check for errors and recover instead of core-dumping.

- Provide multi-threaded fdset's for everyone not just rump if requested.
- Abstract fd_set access, and don't limit the fd_set size.
- Maintain binary compatibility by keeping the old global variables around.

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

make this usable from RUMP

PR/47617: Thorsten Brehm: Memory and socket leak in librpc

fix error messages and warnings.

branches: 1.26.2;
Use C89 definitions
Remove use of __P

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.24.4; 1.24.6;
PR/44514: Andrey Simonenko: Buffer underflow in RPC library for non-blocking
TCP sockets

knf - no functional changes

branches: 1.22.2;
sign-compare fix

branches: 1.21.8; 1.21.10;
- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.20.16;
Only retry if we were able to clean up some descriptors, otherwise we get
into an infinite loop.

Centralize the TCP_NODELAY handling as discussed in tech-net.

-fix uninitialized variable introduced in previous
(found by gcc:-)
-minor prototype cleanup

Coverity CID 2291: Move function call before allocating storage to prevent
memory leak on error.

Coverity CID 2292: Plug memory leak.

XXXGCC: Make a local extern for abort and the vax compiler is happy again.

fix a typo , instead of ; From Johnny Billquist

Convert the rest of the code to use pollts for consistency. XXX: We should
really use kqueue.

branches: 1.12.6; 1.12.10;
Merge the nathanw_sa branch.

Add extern svc_fd_lock if __REENT and include rpc_internal.h only once.

* Adapt include files for rpc_com.h/rpc_internal.h split.
* Add rpc_control to svc.c
* Implement non-blocking connections.

branches: 1.9.2;
Fix spelling mistake (from Onno van der Linden; PR#15793).

branches: 1.8.2;
whitespace consistency fixups

For an accepted connection (tcp), set xp_netid, as it might be examined
by some applications, most notably rpcbind.

De-delint previous: svc_vc_rendezvous_ops() isn't unused unless the single
reference to it is accidently deleted; from Shuuichirou Murata in PR lib/10537.

add __RPC_GETXID macro
don't const castway __rpc_getconf and __rpc_getconfig. It might try to
write const strings
fix non-portable casts
remove duplicated prototypes
cast things to proper types
remove extraneous casts to NULL
fix variable cast mismatches
remove register var declarations

branches: 1.4.2; 1.4.4;
Correct misleading error messages.

- An initialized variable kept LOCAL_CREDS from being set on
the listen socket properly. This caused spurious rpcbind(8)
failures.
- Don't define a "credmsg" structure. Instead, dynamically
allocate a buffer of the correct size of the message with
CMSG_SPACE() and free it when we're done. This gets the
size of the buffer right on LP64 platforms, which has padding
for alignment thrown in.
- Check for non-present or truncated cred messages when recvmsg(2)
returns.

Zero out the xprt in makefd_xprt to avoid bad free() calls in some cases.

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.

fix compilation/lint

PR/50408: Pedro Giffuni: Provide a way for rpc to use poll(2) instead of
select(2), and the linux svc_pollfd and svc_maxpollfd members. Our select(2)
implementation does not suffer from the FD_SETSIZE limitation so this is
not turned on by default.

check for errors and recover instead of core-dumping.

- Provide multi-threaded fdset's for everyone not just rump if requested.
- Abstract fd_set access, and don't limit the fd_set size.
- Maintain binary compatibility by keeping the old global variables around.

Replace previous Sun Microsystems, Inc. license with a standard
BSD 3-clause license granted by Oracle America, Inc..
This license change was approved by Wim Coekaerts, Senior Vice President,
Linux and Virtualization at Oracle Corporation.

This fixes PR lib/45293 by Pedro Giffuni.

make this usable from RUMP

PR/47617: Thorsten Brehm: Memory and socket leak in librpc

fix error messages and warnings.

branches: 1.26.2;
Use C89 definitions
Remove use of __P

PR/45989: Martin Husemann: lint invocation does include -w only on i386

- turn lint -w for all the platforms after fixing the lint warnings.
- add _DIAGASSERTS() for casts that would assign values to types that
would not fit.
- change types, add casts
- change into ansii prototypes
- turn on _DIAGNOSTIC for libc (during current, to be eliminated for release
builds)

approved by core@

branches: 1.24.4; 1.24.6;
PR/44514: Andrey Simonenko: Buffer underflow in RPC library for non-blocking
TCP sockets

knf - no functional changes

branches: 1.22.2;
sign-compare fix

branches: 1.21.8; 1.21.10;
- always check malloc results
- don't leak fds on error
- don't cast malloc
- don't cast NULL

branches: 1.20.16;
Only retry if we were able to clean up some descriptors, otherwise we get
into an infinite loop.

Centralize the TCP_NODELAY handling as discussed in tech-net.

-fix uninitialized variable introduced in previous
(found by gcc:-)
-minor prototype cleanup

Coverity CID 2291: Move function call before allocating storage to prevent
memory leak on error.

Coverity CID 2292: Plug memory leak.

XXXGCC: Make a local extern for abort and the vax compiler is happy again.

fix a typo , instead of ; From Johnny Billquist

Convert the rest of the code to use pollts for consistency. XXX: We should
really use kqueue.

branches: 1.12.6; 1.12.10;
Merge the nathanw_sa branch.

Add extern svc_fd_lock if __REENT and include rpc_internal.h only once.

* Adapt include files for rpc_com.h/rpc_internal.h split.
* Add rpc_control to svc.c
* Implement non-blocking connections.

branches: 1.9.2;
Fix spelling mistake (from Onno van der Linden; PR#15793).

branches: 1.8.2;
whitespace consistency fixups

For an accepted connection (tcp), set xp_netid, as it might be examined
by some applications, most notably rpcbind.

De-delint previous: svc_vc_rendezvous_ops() isn't unused unless the single
reference to it is accidently deleted; from Shuuichirou Murata in PR lib/10537.

add __RPC_GETXID macro
don't const castway __rpc_getconf and __rpc_getconfig. It might try to
write const strings
fix non-portable casts
remove duplicated prototypes
cast things to proper types
remove extraneous casts to NULL
fix variable cast mismatches
remove register var declarations

branches: 1.4.2; 1.4.4;
Correct misleading error messages.

- An initialized variable kept LOCAL_CREDS from being set on
the listen socket properly. This caused spurious rpcbind(8)
failures.
- Don't define a "credmsg" structure. Instead, dynamically
allocate a buffer of the correct size of the message with
CMSG_SPACE() and free it when we're done. This gets the
size of the buffer right on LP64 platforms, which has padding
for alignment thrown in.
- Check for non-present or truncated cred messages when recvmsg(2)
returns.

Zero out the xprt in makefd_xprt to avoid bad free() calls in some cases.

Add new RPC code, based on Sun's TI-RPC code. Adapted to not use XTI,
but sockets instead, internally. Old, backward compatible interfaces
maintained.