- add or adjust /* FALLTHROUGH */ where appropriate
- add __unreachable() after functions that can return but won't in
this case, and thus can't be marked __dead easily

Rework curses handling.

The most visible change is that the scrolling buffer of messages now
actually scrolls and keeps history, and you type on the bottom line only.
For now you can page through the history with ^P/^N; that's not ideal but
one can't fix everything all at once.

Use resizeable array code (roughly the same that I floated a while ago
in connection with make) to hold the scroll.

Move all curses bits to pl_7.c.

Create some abstraction for sending messages.
Make a send and receive function for each possible message.
Make these have useful argument signatures.
Hide the list of message codes inside sync.c.

Sprinkle some "bool". And don't use '\0' to mean 'false'.

Lines <= 80 chars, remove trailing whitespace, other formatting adjustments.
No functional change.

String buffer cleanup. sprintf bad.

branches: 1.19.12;
Build with WARNS=4. Sort out the game's shadowing of its own variables,
which fixes at least one bug.

branches: 1.18.10;
If none of the boarding parties are set do not fall off the end of the
list. Addresses Coverity CID 1507. Also put pointers before shorts in
a struct rather than mixing them up

Add (unsigned char) cast to ctype functions

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

remove redundant decls.

need string.h for prototype (checked with alpha)

Normalize signature of ship handling functions -- struct ship * from and
struct ship * to are now always the first two args.

Break out curses display-related globals into a new header file, so that
<curses.h> doesn't have to be included all over the place.

More rationalization of include files:

a.) Don't include a zillion system headers from "extern.h" (actually, don't
include any).
b.) Break a global jmp_buf variable into a new file, so <setjmp.h> doesn't
have to be pulled in everywhere (it's only used in two places).

The (one line) new file is (c) TNF with a three-clause license, FW(L)IW.

Rationalize inclusion of header files: cut down on `include everything
everywhere' a little (more to go), and as per KNF, local includes after
system includes.

Second half of static-ization of local funcs.

ANSIfy in preparation for further work.

The game sail(6) has a function Write() which is used both with
integer arguments and with string arguments (cast to long, and in one
place to int). The patch here cleans this up, making it into two
separate functions; this allows for the game to be made const-correct
in future and improves portability.

The patch also contains two other fragments: a change to use the
symbolic constant SEEK_END with fseek(), and a change to use snprintf
in one place to avoid a buffer overrun.

Via PR 6569 by Joseph Myers <jsm28@cam.ac.uk>.

- make sure that the arguments to the printf like functions are correct
- add a makemsg() function to accompany makesignal.

Warns fixes:
use varargs properly
use unsigned chars where appropriate
fix typos
eliminate gcc warnings

Various changes to make games compile w/o warnings on the alpha:
Include appropriate includes, delete bogus function declarations,
change sizes of variables and casts.

clean up import, NetBSD RCS IDs

Add RCS identifiers.

branches: 1.1.1;
Initial revision