gomoku: use consistent variable names

Previously, the name 's' was used for the index of a spot on the board,
as well as for the value of a combo, and for a few other purposes. Use
different names and mark the spot indexes using a custom type.

No binary change.

gomoku: fix error handling when reading moves from a file

The columns of the board are labeled from A to H and J to T, which makes
I5 or i5 an invalid coordinate. Previously, reading this invalid
coordinate from a file resulted in the string "<6" appearing in the move
log.

The 'i' was converted into the nonexistent column 20, and PT(20, 5) got
an out-of-bounds argument, resulting in spot 120. Converting this spot
back into coordinates resulted in PT(0, 6). The '<' comes from
'letters[0]'.

gomoku: right-align column header for move number

gomoku: clean up version control sections

Lint can handle these definitions, and the '#if 0' is redundant.

No functional change.

gomoku: reduce scope of 'for' loop variables

No binary change.

gomoku: inline macros BSZ1, BSZ2, BSZ3, BSZ4

These macro names didn't convey any meaning, so replace them with their
replacement text, to have fewer identifiers to worry about.

No binary change.

gomoku: remove redundant parentheses around return values

No binary change.

gomoku: apply some style fixes towards KNF

There are still parts of the code that use an indentation level of 4
instead of the usual 8. Fixing that right now would introduce more
unnatural line breaks, so defer that until later.

No binary change.

games: remove trailing whitespace in *.c and *.h

sprinkle static

sprintf -> snprintf

ANSIfy function declarations.x

Fixed wrong use of the <ctype.h> functions by adding an explicit conversion
to unsigned char. Approved by christos.

Add (unsigned char) cast to ctype functions

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

More include additions for exit, abs, strcmp, etc.

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

WARNSify

fix NetBSD RCS ID headers

add gomoku game, from 4.4BSD-Lite2

branches: 1.1.1;
Initial revision

gomoku: fix error handling when reading moves from a file

The columns of the board are labeled from A to H and J to T, which makes
I5 or i5 an invalid coordinate. Previously, reading this invalid
coordinate from a file resulted in the string "<6" appearing in the move
log.

The 'i' was converted into the nonexistent column 20, and PT(20, 5) got
an out-of-bounds argument, resulting in spot 120. Converting this spot
back into coordinates resulted in PT(0, 6). The '<' comes from
'letters[0]'.

gomoku: right-align column header for move number

gomoku: clean up version control sections

Lint can handle these definitions, and the '#if 0' is redundant.

No functional change.

gomoku: reduce scope of 'for' loop variables

No binary change.

gomoku: inline macros BSZ1, BSZ2, BSZ3, BSZ4

These macro names didn't convey any meaning, so replace them with their
replacement text, to have fewer identifiers to worry about.

No binary change.

gomoku: remove redundant parentheses around return values

No binary change.

gomoku: apply some style fixes towards KNF

There are still parts of the code that use an indentation level of 4
instead of the usual 8. Fixing that right now would introduce more
unnatural line breaks, so defer that until later.

No binary change.

games: remove trailing whitespace in *.c and *.h

sprinkle static

sprintf -> snprintf

ANSIfy function declarations.x

Fixed wrong use of the <ctype.h> functions by adding an explicit conversion
to unsigned char. Approved by christos.

Add (unsigned char) cast to ctype functions

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

More include additions for exit, abs, strcmp, etc.

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

WARNSify

fix NetBSD RCS ID headers

add gomoku game, from 4.4BSD-Lite2

branches: 1.1.1;
Initial revision