gomoku: reduce usage of magic numbers in the code

No binary change.

gomoku: refine the type of some functions and variables

Assisted by WARNS=6. At that level, there are several warnings about
type conversion between small integer types that would only clutter the
code, therefore stay at WARNS=5. Same for lint's -aa option.

No functional change.

gomoku: add type player_color

No functional change.

gomoku: don't use 'i' as special-purpose variable name

No binary change.

gomoku: consistently name the offset of a spot in a frame 'off'

Leave 'i' for general purpose loops.

No functional change.

gomoku: add data type for one of the 4 directions of a frame

No functional change.

gomoku: use proper types when indexing 'board' and 'frames'

No functional change.

gomoku: turn spotstr.s_frame into a frame index

Most calculations are done on the frame index, not the pointer. This
avoids dealing with ptrdiff_t conversion to int.

Changing the type of s_frame changes the size of struct spotstr, it is
now 56 bytes on LP64 and 48 bytes on ILP32, neither of which is a power
of two. Remove the dummy padding since compilers no longer generate
division instructions for divisions by small integer constants, so that
optimization is no longer necessary.

No functional change.

gomoku: migrate 'makemove' to using spot_index instead of pointer

No functional change.

gomoku: migrate spot_index from int to unsigned short

This matches the type of 'intersect'.

No functional change.

gomoku: highlight the winning frame

gomoku: group movelog and nmoves into a game struct

No functional change.

gomoku: split makemove into smaller functions

No functional change.

gomoku: announce tie as early as possible

gomoku: extract update_overlap_different_direction

No functional change.

gomoku: extract separate function update_overlap_same_direction

No functional change.

gomoku: reduce number of variables in update_overlap

No functional change.

gomoku: reduce scope of local variable

No functional change.

gomoku: reduce variable reuse, make code more uniform

No functional change.

gomoku: reduce scope of local variables

No binary change.

gomoku: allow Black to win the game in the very last move

gomoku: fix off-by-one error when deciding that the game is a tie

gomoku: replace 1-based movenum with 0-based nmoves

No functional change, not even the TIE that is wrongly announced when
the very last spot on the board is yet to be filled by Black. Even
without this off-by-one error, it could be that filling the very last
spot completes a frame, so that code has been wrong all the time.

In practical terms, this situation only arises when the human player is
unconcentrated or the computer player has a bad strategy. The latter
may well be, as the computer moves in the (boring) endgame are not
directed towards winning -- they fill irrelevant spots before relevant
ones.

gomoku: provide readable names for c.a and c.b

No binary change.

gomoku: inline macro MAXCOMBO

The name of the macro was not descriptive enough, the other constants in
bdinit also don't have names.

No binary change.

gomoku: clean up version control sections

Lint can handle these definitions, and the '#if 0' is redundant.

No functional change.

gomoku: reduce scope of 'for' loop variables

No binary change.

gomoku: enable lint's strict bool mode

No functional change.

gomoku: prepare lint's strict bool mode

No binary change.

gomoku: fix lint warnings

Most warnings were about implicit conversions from ptrdiff_t to int; add
explicit cast for them, as they are far from overflowing int.

The casts from one pointer type to 'struct combostr **' were indeed
suspicious. In these cases, a single region of memory is allocated to
store two objects of different type, without declaring a struct type for
their combination. The second object is an array of variable size.

No binary change.

gomoku: remove redundant parentheses around return values

No binary change.

gomoku: apply some style fixes towards KNF

There are still parts of the code that use an indentation level of 4
instead of the usual 8. Fixing that right now would introduce more
unnatural line breaks, so defer that until later.

No binary change.

sprinkle static

Increase spending on vowels. No object file diffs.

ANSIfy function declarations.x

avoid a pointer sign difference.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Fix doubled 'the'.

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

WARNSify

fix NetBSD RCS ID headers

add gomoku game, from 4.4BSD-Lite2

branches: 1.1.1;
Initial revision

gomoku: refine the type of some functions and variables

Assisted by WARNS=6. At that level, there are several warnings about
type conversion between small integer types that would only clutter the
code, therefore stay at WARNS=5. Same for lint's -aa option.

No functional change.

gomoku: add type player_color

No functional change.

gomoku: don't use 'i' as special-purpose variable name

No binary change.

gomoku: consistently name the offset of a spot in a frame 'off'

Leave 'i' for general purpose loops.

No functional change.

gomoku: add data type for one of the 4 directions of a frame

No functional change.

gomoku: use proper types when indexing 'board' and 'frames'

No functional change.

gomoku: turn spotstr.s_frame into a frame index

Most calculations are done on the frame index, not the pointer. This
avoids dealing with ptrdiff_t conversion to int.

Changing the type of s_frame changes the size of struct spotstr, it is
now 56 bytes on LP64 and 48 bytes on ILP32, neither of which is a power
of two. Remove the dummy padding since compilers no longer generate
division instructions for divisions by small integer constants, so that
optimization is no longer necessary.

No functional change.

gomoku: migrate 'makemove' to using spot_index instead of pointer

No functional change.

gomoku: migrate spot_index from int to unsigned short

This matches the type of 'intersect'.

No functional change.

gomoku: highlight the winning frame

gomoku: group movelog and nmoves into a game struct

No functional change.

gomoku: split makemove into smaller functions

No functional change.

gomoku: announce tie as early as possible

gomoku: extract update_overlap_different_direction

No functional change.

gomoku: extract separate function update_overlap_same_direction

No functional change.

gomoku: reduce number of variables in update_overlap

No functional change.

gomoku: reduce scope of local variable

No functional change.

gomoku: reduce variable reuse, make code more uniform

No functional change.

gomoku: reduce scope of local variables

No binary change.

gomoku: allow Black to win the game in the very last move

gomoku: fix off-by-one error when deciding that the game is a tie

gomoku: replace 1-based movenum with 0-based nmoves

No functional change, not even the TIE that is wrongly announced when
the very last spot on the board is yet to be filled by Black. Even
without this off-by-one error, it could be that filling the very last
spot completes a frame, so that code has been wrong all the time.

In practical terms, this situation only arises when the human player is
unconcentrated or the computer player has a bad strategy. The latter
may well be, as the computer moves in the (boring) endgame are not
directed towards winning -- they fill irrelevant spots before relevant
ones.

gomoku: provide readable names for c.a and c.b

No binary change.

gomoku: inline macro MAXCOMBO

The name of the macro was not descriptive enough, the other constants in
bdinit also don't have names.

No binary change.

gomoku: clean up version control sections

Lint can handle these definitions, and the '#if 0' is redundant.

No functional change.

gomoku: reduce scope of 'for' loop variables

No binary change.

gomoku: enable lint's strict bool mode

No functional change.

gomoku: prepare lint's strict bool mode

No binary change.

gomoku: fix lint warnings

Most warnings were about implicit conversions from ptrdiff_t to int; add
explicit cast for them, as they are far from overflowing int.

The casts from one pointer type to 'struct combostr **' were indeed
suspicious. In these cases, a single region of memory is allocated to
store two objects of different type, without declaring a struct type for
their combination. The second object is an array of variable size.

No binary change.

gomoku: remove redundant parentheses around return values

No binary change.

gomoku: apply some style fixes towards KNF

There are still parts of the code that use an indentation level of 4
instead of the usual 8. Fixing that right now would introduce more
unnatural line breaks, so defer that until later.

No binary change.

sprinkle static

Increase spending on vowels. No object file diffs.

ANSIfy function declarations.x

avoid a pointer sign difference.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Fix doubled 'the'.

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

WARNSify

fix NetBSD RCS ID headers

add gomoku game, from 4.4BSD-Lite2

branches: 1.1.1;
Initial revision

gomoku: don't use 'i' as special-purpose variable name

No binary change.

gomoku: consistently name the offset of a spot in a frame 'off'

Leave 'i' for general purpose loops.

No functional change.

gomoku: add data type for one of the 4 directions of a frame

No functional change.

gomoku: use proper types when indexing 'board' and 'frames'

No functional change.

gomoku: turn spotstr.s_frame into a frame index

Most calculations are done on the frame index, not the pointer. This
avoids dealing with ptrdiff_t conversion to int.

Changing the type of s_frame changes the size of struct spotstr, it is
now 56 bytes on LP64 and 48 bytes on ILP32, neither of which is a power
of two. Remove the dummy padding since compilers no longer generate
division instructions for divisions by small integer constants, so that
optimization is no longer necessary.

No functional change.

gomoku: migrate 'makemove' to using spot_index instead of pointer

No functional change.

gomoku: migrate spot_index from int to unsigned short

This matches the type of 'intersect'.

No functional change.

gomoku: highlight the winning frame

gomoku: group movelog and nmoves into a game struct

No functional change.

gomoku: split makemove into smaller functions

No functional change.

gomoku: announce tie as early as possible

gomoku: extract update_overlap_different_direction

No functional change.

gomoku: extract separate function update_overlap_same_direction

No functional change.

gomoku: reduce number of variables in update_overlap

No functional change.

gomoku: reduce scope of local variable

No functional change.

gomoku: reduce variable reuse, make code more uniform

No functional change.

gomoku: reduce scope of local variables

No binary change.

gomoku: allow Black to win the game in the very last move

gomoku: fix off-by-one error when deciding that the game is a tie

gomoku: replace 1-based movenum with 0-based nmoves

No functional change, not even the TIE that is wrongly announced when
the very last spot on the board is yet to be filled by Black. Even
without this off-by-one error, it could be that filling the very last
spot completes a frame, so that code has been wrong all the time.

In practical terms, this situation only arises when the human player is
unconcentrated or the computer player has a bad strategy. The latter
may well be, as the computer moves in the (boring) endgame are not
directed towards winning -- they fill irrelevant spots before relevant
ones.

gomoku: provide readable names for c.a and c.b

No binary change.

gomoku: inline macro MAXCOMBO

The name of the macro was not descriptive enough, the other constants in
bdinit also don't have names.

No binary change.

gomoku: clean up version control sections

Lint can handle these definitions, and the '#if 0' is redundant.

No functional change.

gomoku: reduce scope of 'for' loop variables

No binary change.

gomoku: enable lint's strict bool mode

No functional change.

gomoku: prepare lint's strict bool mode

No binary change.

gomoku: fix lint warnings

Most warnings were about implicit conversions from ptrdiff_t to int; add
explicit cast for them, as they are far from overflowing int.

The casts from one pointer type to 'struct combostr **' were indeed
suspicious. In these cases, a single region of memory is allocated to
store two objects of different type, without declaring a struct type for
their combination. The second object is an array of variable size.

No binary change.

gomoku: remove redundant parentheses around return values

No binary change.

gomoku: apply some style fixes towards KNF

There are still parts of the code that use an indentation level of 4
instead of the usual 8. Fixing that right now would introduce more
unnatural line breaks, so defer that until later.

No binary change.

sprinkle static

Increase spending on vowels. No object file diffs.

ANSIfy function declarations.x

avoid a pointer sign difference.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Fix doubled 'the'.

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

WARNSify

fix NetBSD RCS ID headers

add gomoku game, from 4.4BSD-Lite2

branches: 1.1.1;
Initial revision

gomoku: highlight the winning frame

gomoku: group movelog and nmoves into a game struct

No functional change.

gomoku: split makemove into smaller functions

No functional change.

gomoku: announce tie as early as possible

gomoku: extract update_overlap_different_direction

No functional change.

gomoku: extract separate function update_overlap_same_direction

No functional change.

gomoku: reduce number of variables in update_overlap

No functional change.

gomoku: reduce scope of local variable

No functional change.

gomoku: reduce variable reuse, make code more uniform

No functional change.

gomoku: reduce scope of local variables

No binary change.

gomoku: allow Black to win the game in the very last move

gomoku: fix off-by-one error when deciding that the game is a tie

gomoku: replace 1-based movenum with 0-based nmoves

No functional change, not even the TIE that is wrongly announced when
the very last spot on the board is yet to be filled by Black. Even
without this off-by-one error, it could be that filling the very last
spot completes a frame, so that code has been wrong all the time.

In practical terms, this situation only arises when the human player is
unconcentrated or the computer player has a bad strategy. The latter
may well be, as the computer moves in the (boring) endgame are not
directed towards winning -- they fill irrelevant spots before relevant
ones.

gomoku: provide readable names for c.a and c.b

No binary change.

gomoku: inline macro MAXCOMBO

The name of the macro was not descriptive enough, the other constants in
bdinit also don't have names.

No binary change.

gomoku: clean up version control sections

Lint can handle these definitions, and the '#if 0' is redundant.

No functional change.

gomoku: reduce scope of 'for' loop variables

No binary change.

gomoku: enable lint's strict bool mode

No functional change.

gomoku: prepare lint's strict bool mode

No binary change.

gomoku: fix lint warnings

Most warnings were about implicit conversions from ptrdiff_t to int; add
explicit cast for them, as they are far from overflowing int.

The casts from one pointer type to 'struct combostr **' were indeed
suspicious. In these cases, a single region of memory is allocated to
store two objects of different type, without declaring a struct type for
their combination. The second object is an array of variable size.

No binary change.

gomoku: remove redundant parentheses around return values

No binary change.

gomoku: apply some style fixes towards KNF

There are still parts of the code that use an indentation level of 4
instead of the usual 8. Fixing that right now would introduce more
unnatural line breaks, so defer that until later.

No binary change.

sprinkle static

Increase spending on vowels. No object file diffs.

ANSIfy function declarations.x

avoid a pointer sign difference.

Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

Fix doubled 'the'.

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

WARNSify

fix NetBSD RCS ID headers

add gomoku game, from 4.4BSD-Lite2

branches: 1.1.1;
Initial revision