gomoku: refine the type of some functions and variables

Assisted by WARNS=6. At that level, there are several warnings about
type conversion between small integer types that would only clutter the
code, therefore stay at WARNS=5. Same for lint's -aa option.

No functional change.

gomoku: when starting a new game, start in the middle of the board

Previously, when starting a new game, the user coordinate was kept at
the previously selected spot. Since playing in the center is common
sense, reset the coordinate.

gomoku: after accepting a spot via the mouse, clear current coordinate

gomoku: don't use 'i' as special-purpose variable name

No binary change.

gomoku: use consistent variable names

Previously, the name 's' was used for the index of a spot on the board,
as well as for the value of a combo, and for a few other purposes. Use
different names and mark the spot indexes using a custom type.

No binary change.

gomoku: remove redundant parentheses, braces, newlines, clean up get_key

No functional change.

gomoku: highlight the winning frame

gomoku: group movelog and nmoves into a game struct

No functional change.

gomoku: replace 1-based movenum with 0-based nmoves

No functional change, not even the TIE that is wrongly announced when
the very last spot on the board is yet to be filled by Black. Even
without this off-by-one error, it could be that filling the very last
spot completes a frame, so that code has been wrong all the time.

In practical terms, this situation only arises when the human player is
unconcentrated or the computer player has a bad strategy. The latter
may well be, as the computer moves in the (boring) endgame are not
directed towards winning -- they fill irrelevant spots before relevant
ones.

gomoku: add mouse support

NetBSD 10 provides the mouse handling functions from <curses.h> but does
not actually implement the mouse handling. For the benefit of other
platforms, add mouse support; when linked with ncurses instead of
curses, it works.

Depending on the input device, mouse clicks are either reported as
"button 1 clicked" (mouse) or "button 1 pressed/released" (touchpad);
support both.

Be strict about the X coordinate when clicking. Since the coordinates
are integer numbers, getting the location between two spots is
ambiguous, as it could be just one pixel away or right in the middle of
the space between the spots.

gomoku: clean up coordinate calculations in get_coord

No functional change.

gomoku: make coordinates in get_coord 1-based

The rest of the game has 1-based coordinates as well.

No functional change.

gomoku: extract save_game from main

No functional change.

gomoku: right-align column header for move number

gomoku: move comments closer to their corresponding entities

No binary change.

gomoku: warn before overwriting a saved game file

gomoku: do not accept overly long lines from the input

Typing beyond the screen and then pressing and holding backspace still
removes the prompt, just as before.

gomoku: fix deleting a character when reading a line

gomoku: make drawing the player's names simpler

No functional change.

gomoku: use combined curses functions

To save some screen space in the source code and some bytes in the
generated binary.

No functional change.

gomoku: clean up coordinate for the currently selected spot

There is no need to make this coordinate dependent on the board size.

No binary change.

gomoku: clean up version control sections

Lint can handle these definitions, and the '#if 0' is redundant.

No functional change.

gomoku: replace magic numbers with proper coordinate calculation

gomoku: properly center the player's names

gomoku: de-obfuscate screen coordinate calculation

Modern compilers optimize linear integer arithmetic, so there is no
reason to use strange or misleading formulas.

Replace several magic numbers with proper formulas.

No binary change.

gomoku: fix error message for small screen

- gomoku: Screen too small (need 8018d)
+ gomoku: Screen too small (need 80x24)

gomoku: fix type mismatch in call to curses function

Not yet detected by lint, as lint is more permissive for type mismatches
if the value is a constant 0. Being permissive doesn't make sense in
this case. Now the calls to 'keypad' and 'leaveok' are consistent.

No binary change.

gomoku: reduce scope of 'for' loop variables

No binary change.

gomoku: highlight the last played move

gomoku: enable lint's strict bool mode

No functional change.

gomoku: fix most lint warnings in -DDEBUG mode

No binary change.

gomoku: prepare lint's strict bool mode

No binary change.

gomoku: fix lint warnings

Most warnings were about implicit conversions from ptrdiff_t to int; add
explicit cast for them, as they are far from overflowing int.

The casts from one pointer type to 'struct combostr **' were indeed
suspicious. In these cases, a single region of memory is allocated to
store two objects of different type, without declaring a struct type for
their combination. The second object is an array of variable size.

No binary change.

gomoku: inline macros BSZ1, BSZ2, BSZ3, BSZ4

These macro names didn't convey any meaning, so replace them with their
replacement text, to have fewer identifiers to worry about.

No binary change.

gomoku: remove redundant parentheses around return values

No binary change.

gomoku: apply some style fixes towards KNF

There are still parts of the code that use an indentation level of 4
instead of the usual 8. Fixing that right now would introduce more
unnatural line breaks, so defer that until later.

No binary change.

gomoku: clean up unused code and lint warnings

No binary change.

games: remove trailing whitespace in *.c and *.h

move extern decls to .h files

branches: 1.16.2;
Fix conflicting variable definitions

branches: 1.15.6;
Some improvements to the new UI.

Better user interface. From OpenBSD, written by Paul Janzen quite a
long time ago. A few minor adjustments by yours truly.

Don't exit(0) on failure. Use errx() instead of fprintf.

Rename internal getline() function to get_line() so it does
conflict with the soon to be added getline(3) libc function.

Increase spending on vowels. No object file diffs.

ANSIfy function declarations.x

if initscr() fails, exit with a message rather than crash in the
next curses call

branches: 1.8.32;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

fix nested externs

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

WARNSify

fix NetBSD RCS ID headers

include string.h and stdlib.h for prototypes, as appropriate

add gomoku game, from 4.4BSD-Lite2

branches: 1.1.1;
Initial revision

gomoku: don't use 'i' as special-purpose variable name

No binary change.

gomoku: use consistent variable names

Previously, the name 's' was used for the index of a spot on the board,
as well as for the value of a combo, and for a few other purposes. Use
different names and mark the spot indexes using a custom type.

No binary change.

gomoku: remove redundant parentheses, braces, newlines, clean up get_key

No functional change.

gomoku: highlight the winning frame

gomoku: group movelog and nmoves into a game struct

No functional change.

gomoku: replace 1-based movenum with 0-based nmoves

No functional change, not even the TIE that is wrongly announced when
the very last spot on the board is yet to be filled by Black. Even
without this off-by-one error, it could be that filling the very last
spot completes a frame, so that code has been wrong all the time.

In practical terms, this situation only arises when the human player is
unconcentrated or the computer player has a bad strategy. The latter
may well be, as the computer moves in the (boring) endgame are not
directed towards winning -- they fill irrelevant spots before relevant
ones.

gomoku: add mouse support

NetBSD 10 provides the mouse handling functions from <curses.h> but does
not actually implement the mouse handling. For the benefit of other
platforms, add mouse support; when linked with ncurses instead of
curses, it works.

Depending on the input device, mouse clicks are either reported as
"button 1 clicked" (mouse) or "button 1 pressed/released" (touchpad);
support both.

Be strict about the X coordinate when clicking. Since the coordinates
are integer numbers, getting the location between two spots is
ambiguous, as it could be just one pixel away or right in the middle of
the space between the spots.

gomoku: clean up coordinate calculations in get_coord

No functional change.

gomoku: make coordinates in get_coord 1-based

The rest of the game has 1-based coordinates as well.

No functional change.

gomoku: extract save_game from main

No functional change.

gomoku: right-align column header for move number

gomoku: move comments closer to their corresponding entities

No binary change.

gomoku: warn before overwriting a saved game file

gomoku: do not accept overly long lines from the input

Typing beyond the screen and then pressing and holding backspace still
removes the prompt, just as before.

gomoku: fix deleting a character when reading a line

gomoku: make drawing the player's names simpler

No functional change.

gomoku: use combined curses functions

To save some screen space in the source code and some bytes in the
generated binary.

No functional change.

gomoku: clean up coordinate for the currently selected spot

There is no need to make this coordinate dependent on the board size.

No binary change.

gomoku: clean up version control sections

Lint can handle these definitions, and the '#if 0' is redundant.

No functional change.

gomoku: replace magic numbers with proper coordinate calculation

gomoku: properly center the player's names

gomoku: de-obfuscate screen coordinate calculation

Modern compilers optimize linear integer arithmetic, so there is no
reason to use strange or misleading formulas.

Replace several magic numbers with proper formulas.

No binary change.

gomoku: fix error message for small screen

- gomoku: Screen too small (need 8018d)
+ gomoku: Screen too small (need 80x24)

gomoku: fix type mismatch in call to curses function

Not yet detected by lint, as lint is more permissive for type mismatches
if the value is a constant 0. Being permissive doesn't make sense in
this case. Now the calls to 'keypad' and 'leaveok' are consistent.

No binary change.

gomoku: reduce scope of 'for' loop variables

No binary change.

gomoku: highlight the last played move

gomoku: enable lint's strict bool mode

No functional change.

gomoku: fix most lint warnings in -DDEBUG mode

No binary change.

gomoku: prepare lint's strict bool mode

No binary change.

gomoku: fix lint warnings

Most warnings were about implicit conversions from ptrdiff_t to int; add
explicit cast for them, as they are far from overflowing int.

The casts from one pointer type to 'struct combostr **' were indeed
suspicious. In these cases, a single region of memory is allocated to
store two objects of different type, without declaring a struct type for
their combination. The second object is an array of variable size.

No binary change.

gomoku: inline macros BSZ1, BSZ2, BSZ3, BSZ4

These macro names didn't convey any meaning, so replace them with their
replacement text, to have fewer identifiers to worry about.

No binary change.

gomoku: remove redundant parentheses around return values

No binary change.

gomoku: apply some style fixes towards KNF

There are still parts of the code that use an indentation level of 4
instead of the usual 8. Fixing that right now would introduce more
unnatural line breaks, so defer that until later.

No binary change.

gomoku: clean up unused code and lint warnings

No binary change.

games: remove trailing whitespace in *.c and *.h

move extern decls to .h files

branches: 1.16.2;
Fix conflicting variable definitions

branches: 1.15.6;
Some improvements to the new UI.

Better user interface. From OpenBSD, written by Paul Janzen quite a
long time ago. A few minor adjustments by yours truly.

Don't exit(0) on failure. Use errx() instead of fprintf.

Rename internal getline() function to get_line() so it does
conflict with the soon to be added getline(3) libc function.

Increase spending on vowels. No object file diffs.

ANSIfy function declarations.x

if initscr() fails, exit with a message rather than crash in the
next curses call

branches: 1.8.32;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

fix nested externs

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

WARNSify

fix NetBSD RCS ID headers

include string.h and stdlib.h for prototypes, as appropriate

add gomoku game, from 4.4BSD-Lite2

branches: 1.1.1;
Initial revision

gomoku: highlight the winning frame

gomoku: group movelog and nmoves into a game struct

No functional change.

gomoku: replace 1-based movenum with 0-based nmoves

No functional change, not even the TIE that is wrongly announced when
the very last spot on the board is yet to be filled by Black. Even
without this off-by-one error, it could be that filling the very last
spot completes a frame, so that code has been wrong all the time.

In practical terms, this situation only arises when the human player is
unconcentrated or the computer player has a bad strategy. The latter
may well be, as the computer moves in the (boring) endgame are not
directed towards winning -- they fill irrelevant spots before relevant
ones.

gomoku: add mouse support

NetBSD 10 provides the mouse handling functions from <curses.h> but does
not actually implement the mouse handling. For the benefit of other
platforms, add mouse support; when linked with ncurses instead of
curses, it works.

Depending on the input device, mouse clicks are either reported as
"button 1 clicked" (mouse) or "button 1 pressed/released" (touchpad);
support both.

Be strict about the X coordinate when clicking. Since the coordinates
are integer numbers, getting the location between two spots is
ambiguous, as it could be just one pixel away or right in the middle of
the space between the spots.

gomoku: clean up coordinate calculations in get_coord

No functional change.

gomoku: make coordinates in get_coord 1-based

The rest of the game has 1-based coordinates as well.

No functional change.

gomoku: extract save_game from main

No functional change.

gomoku: right-align column header for move number

gomoku: move comments closer to their corresponding entities

No binary change.

gomoku: warn before overwriting a saved game file

gomoku: do not accept overly long lines from the input

Typing beyond the screen and then pressing and holding backspace still
removes the prompt, just as before.

gomoku: fix deleting a character when reading a line

gomoku: make drawing the player's names simpler

No functional change.

gomoku: use combined curses functions

To save some screen space in the source code and some bytes in the
generated binary.

No functional change.

gomoku: clean up coordinate for the currently selected spot

There is no need to make this coordinate dependent on the board size.

No binary change.

gomoku: clean up version control sections

Lint can handle these definitions, and the '#if 0' is redundant.

No functional change.

gomoku: replace magic numbers with proper coordinate calculation

gomoku: properly center the player's names

gomoku: de-obfuscate screen coordinate calculation

Modern compilers optimize linear integer arithmetic, so there is no
reason to use strange or misleading formulas.

Replace several magic numbers with proper formulas.

No binary change.

gomoku: fix error message for small screen

- gomoku: Screen too small (need 8018d)
+ gomoku: Screen too small (need 80x24)

gomoku: fix type mismatch in call to curses function

Not yet detected by lint, as lint is more permissive for type mismatches
if the value is a constant 0. Being permissive doesn't make sense in
this case. Now the calls to 'keypad' and 'leaveok' are consistent.

No binary change.

gomoku: reduce scope of 'for' loop variables

No binary change.

gomoku: highlight the last played move

gomoku: enable lint's strict bool mode

No functional change.

gomoku: fix most lint warnings in -DDEBUG mode

No binary change.

gomoku: prepare lint's strict bool mode

No binary change.

gomoku: fix lint warnings

Most warnings were about implicit conversions from ptrdiff_t to int; add
explicit cast for them, as they are far from overflowing int.

The casts from one pointer type to 'struct combostr **' were indeed
suspicious. In these cases, a single region of memory is allocated to
store two objects of different type, without declaring a struct type for
their combination. The second object is an array of variable size.

No binary change.

gomoku: inline macros BSZ1, BSZ2, BSZ3, BSZ4

These macro names didn't convey any meaning, so replace them with their
replacement text, to have fewer identifiers to worry about.

No binary change.

gomoku: remove redundant parentheses around return values

No binary change.

gomoku: apply some style fixes towards KNF

There are still parts of the code that use an indentation level of 4
instead of the usual 8. Fixing that right now would introduce more
unnatural line breaks, so defer that until later.

No binary change.

gomoku: clean up unused code and lint warnings

No binary change.

games: remove trailing whitespace in *.c and *.h

move extern decls to .h files

branches: 1.16.2;
Fix conflicting variable definitions

branches: 1.15.6;
Some improvements to the new UI.

Better user interface. From OpenBSD, written by Paul Janzen quite a
long time ago. A few minor adjustments by yours truly.

Don't exit(0) on failure. Use errx() instead of fprintf.

Rename internal getline() function to get_line() so it does
conflict with the soon to be added getline(3) libc function.

Increase spending on vowels. No object file diffs.

ANSIfy function declarations.x

if initscr() fails, exit with a message rather than crash in the
next curses call

branches: 1.8.32;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

fix nested externs

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

WARNSify

fix NetBSD RCS ID headers

include string.h and stdlib.h for prototypes, as appropriate

add gomoku game, from 4.4BSD-Lite2

branches: 1.1.1;
Initial revision

gomoku: add mouse support

NetBSD 10 provides the mouse handling functions from <curses.h> but does
not actually implement the mouse handling. For the benefit of other
platforms, add mouse support; when linked with ncurses instead of
curses, it works.

Depending on the input device, mouse clicks are either reported as
"button 1 clicked" (mouse) or "button 1 pressed/released" (touchpad);
support both.

Be strict about the X coordinate when clicking. Since the coordinates
are integer numbers, getting the location between two spots is
ambiguous, as it could be just one pixel away or right in the middle of
the space between the spots.

gomoku: clean up coordinate calculations in get_coord

No functional change.

gomoku: make coordinates in get_coord 1-based

The rest of the game has 1-based coordinates as well.

No functional change.

gomoku: extract save_game from main

No functional change.

gomoku: right-align column header for move number

gomoku: move comments closer to their corresponding entities

No binary change.

gomoku: warn before overwriting a saved game file

gomoku: do not accept overly long lines from the input

Typing beyond the screen and then pressing and holding backspace still
removes the prompt, just as before.

gomoku: fix deleting a character when reading a line

gomoku: make drawing the player's names simpler

No functional change.

gomoku: use combined curses functions

To save some screen space in the source code and some bytes in the
generated binary.

No functional change.

gomoku: clean up coordinate for the currently selected spot

There is no need to make this coordinate dependent on the board size.

No binary change.

gomoku: clean up version control sections

Lint can handle these definitions, and the '#if 0' is redundant.

No functional change.

gomoku: replace magic numbers with proper coordinate calculation

gomoku: properly center the player's names

gomoku: de-obfuscate screen coordinate calculation

Modern compilers optimize linear integer arithmetic, so there is no
reason to use strange or misleading formulas.

Replace several magic numbers with proper formulas.

No binary change.

gomoku: fix error message for small screen

- gomoku: Screen too small (need 8018d)
+ gomoku: Screen too small (need 80x24)

gomoku: fix type mismatch in call to curses function

Not yet detected by lint, as lint is more permissive for type mismatches
if the value is a constant 0. Being permissive doesn't make sense in
this case. Now the calls to 'keypad' and 'leaveok' are consistent.

No binary change.

gomoku: reduce scope of 'for' loop variables

No binary change.

gomoku: highlight the last played move

gomoku: enable lint's strict bool mode

No functional change.

gomoku: fix most lint warnings in -DDEBUG mode

No binary change.

gomoku: prepare lint's strict bool mode

No binary change.

gomoku: fix lint warnings

Most warnings were about implicit conversions from ptrdiff_t to int; add
explicit cast for them, as they are far from overflowing int.

The casts from one pointer type to 'struct combostr **' were indeed
suspicious. In these cases, a single region of memory is allocated to
store two objects of different type, without declaring a struct type for
their combination. The second object is an array of variable size.

No binary change.

gomoku: inline macros BSZ1, BSZ2, BSZ3, BSZ4

These macro names didn't convey any meaning, so replace them with their
replacement text, to have fewer identifiers to worry about.

No binary change.

gomoku: remove redundant parentheses around return values

No binary change.

gomoku: apply some style fixes towards KNF

There are still parts of the code that use an indentation level of 4
instead of the usual 8. Fixing that right now would introduce more
unnatural line breaks, so defer that until later.

No binary change.

gomoku: clean up unused code and lint warnings

No binary change.

games: remove trailing whitespace in *.c and *.h

move extern decls to .h files

branches: 1.16.2;
Fix conflicting variable definitions

branches: 1.15.6;
Some improvements to the new UI.

Better user interface. From OpenBSD, written by Paul Janzen quite a
long time ago. A few minor adjustments by yours truly.

Don't exit(0) on failure. Use errx() instead of fprintf.

Rename internal getline() function to get_line() so it does
conflict with the soon to be added getline(3) libc function.

Increase spending on vowels. No object file diffs.

ANSIfy function declarations.x

if initscr() fails, exit with a message rather than crash in the
next curses call

branches: 1.8.32;
Move UCB-licensed code from 4-clause to 3-clause licence.

Patches provided by Joel Baker in PR 22269, verified by myself.

fix nested externs

Add use of `const' where appropriate to the games.

This merges in all such remaining changes from the Linux port of the
NetBSD games, except in hunt (where substantial changes from OpenBSD
need to be looked at).

Some such changes were previously covered in PRs bin/6041, bin/6146,
bin/6148, bin/6150, bin/6151, bin/6580, bin/6660, bin/7993, bin/7994,
bin/8039, bin/8057 and bin/8093.

WARNSify

fix NetBSD RCS ID headers

include string.h and stdlib.h for prototypes, as appropriate

add gomoku game, from 4.4BSD-Lite2

branches: 1.1.1;
Initial revision