#
5d88ce50 |
|
17-May-2023 |
Bagas Sanjaya <bagasdotme@gmail.com> |
drivers: staging: wlan-ng: Remove GPL/MPL boilerplate Remove the license boilerplate as there is already SPDX license identifier added in b24413180f5600 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") which fulfills the same intention as the boilerplate. Cc: Dan Carpenter <error27@gmail.com> Cc: Kate Stewart <kstewart@linuxfoundation.org> Cc: Philippe Ombredanne <pombredanne@nexb.com> Cc: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> Link: https://lore.kernel.org/r/20230517090418.1093091-4-bagasdotme@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
9fd32106 |
|
20-Apr-2023 |
Luke Koch <lu.ale.koch@gmail.com> |
staging: wlan-ng: replace rate macros Change p80211msg_dot11req_scan_results rate members to struct arrays instead of individually numbered member structs. Replace macros to set rates with loops to avoid checkpatch warning and adhere to linux coding style. Reported by checkpatch: CHECK: Macro argument reuse 'N' - possible side-effects? Signed-off-by: Luke Koch <lu.ale.koch@gmail.com> Link: https://lore.kernel.org/r/ZEFtOH83frrrireN@kernelhacking.kernelhacking.example.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8ffd91d9 |
|
28-Aug-2021 |
Aldas Taraškevičius <aldas60@gmail.com> |
staging: wlan-ng: Remove filenames from files Fix checkpatch warnings about having filenames in the files. Signed-off-by: Aldas Taraškevičius <aldas60@gmail.com> Link: https://lore.kernel.org/r/20210828195324.68-1-aldas60@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
16b37e7b |
|
22-Oct-2020 |
Izabela Bakollari <izabela.bakollari@gmail.com> |
staging/wlan-ng: Fix line alignment Fix code alignment. Issue reported by checkpatch.pl Signed-off-by: Izabela Bakollari <izabela.bakollari@gmail.com> Link: https://lore.kernel.org/r/20201022132218.235744-1-izabela.bakollari@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
1eb76a00 |
|
24-Aug-2020 |
Steff Richards <steff.richards.the.third@gmail.com> |
staging: wlan-ng: fix alignment to match open parentheses Indent a number of arguments so that they align with the opening parentheses of the function calls. Issues found by checkpatch. Signed-off-by: Steff Richards <steff.richards.the.third@gmail.com> Link: https://lore.kernel.org/r/20200824165356.GA5204@steffpad Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
4cc41cbc |
|
14-Jan-2020 |
Colin Ian King <colin.king@canonical.com> |
staging: wlan-ng: ensure error return is actually returned Currently when the call to prism2sta_ifst fails a netdev_err error is reported, error return variable result is set to -1 but the function always returns 0 for success. Fix this by returning the error value in variable result rather than 0. Addresses-Coverity: ("Unused value") Fixes: 00b3ed168508 ("Staging: add wlan-ng prism2 usb driver") Signed-off-by: Colin Ian King <colin.king@canonical.com> Cc: stable <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20200114181604.390235-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
460f6f8b |
|
06-Jul-2018 |
Tim Collier <osdevtc@gmail.com> |
staging: wlan-ng: remove unneeded parentheses from prism2mgmt.c remove parentheses reported as unnecessary by checkpatch Signed-off-by: Tim Collier <osdevtc@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e47b374c |
|
06-Jul-2018 |
Tim Collier <osdevtc@gmail.com> |
staging: wlan-ng: fix expression continuation in prism2mgmt.c checkpatch reports "CHECK: Logical continuations should be on the previous line" when a continuation line begins with an operator. Reformat the code so that the operator appears at the end of the line being continued. Signed-off-by: Tim Collier <osdevtc@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
39b2ef70 |
|
22-Jun-2018 |
Tim Collier <osdevtc@gmail.com> |
staging: wlan-ng: add parentheses to macro argument usage in prism2mgmt.c Fix two "CHECK: Macro argument 'N' may be better as '(N)' to avoid precedence issue" messages, reported by checkpatch, by adding parentheses around the offending macro argument references. Signed-off-by: Tim Collier <osdevtc@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b2679009 |
|
22-Jun-2018 |
Tim Collier <osdevtc@gmail.com> |
staging: wlan-ng: replace macro with inline function in prism2mgmt.c checkpatch gives the following message for the p80211rate_to_p2bit macro: CHECK: Macro argument reuse 'n' - possible side-effects? To fix the message, replace the macro with an equivalent inline function. Signed-off-by: Tim Collier <osdevtc@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
beb7b033 |
|
16-Feb-2018 |
Yash Omer <yashomer0007@gmail.com> |
Staging: wlan-ng: fix unnecessary parantheses in prism2mgmt.c This patch fixes up a unncessary paratheses warning found by checkpatch.pl script. Signed-off-by: Yash Omer <yashomer0007@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f7056d33 |
|
07-Nov-2017 |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
staging: wlan-ng: add SPDX identifiers to all wlan-ng driver files It's good to have SPDX identifiers in all files to make it easier to audit the kernel tree for correct licenses. Update the wlan-ng driver files with the correct SPDX license identifier based on the license text in the file itself. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. This work is based on a script and data from Thomas Gleixner, Philippe Ombredanne, and Kate Stewart. Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Kate Stewart <kstewart@linuxfoundation.org> Cc: Philippe Ombredanne <pombredanne@nexb.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0fb8997b |
|
12-Sep-2017 |
Haneen Mohammed <hamohammed.sa@gmail.com> |
staging: wlan-ng: Replace pr_debug with netdev_dbg This patch replace pr_debug with netdev_dbg when appropriate net_device structure is found. Issue found using the following Coccinelle script: @r exists@ identifier f, s, i; position p; @@ f(...,struct s *i,...) { <+... when != i == NULL ( pr_err@p(...); | pr_info@p(...); | pr_debug@p(...); ) ...+> } @rr@ identifier r.s, fld; @@ struct s { ... struct net_device *fld; ... }; @@ identifier r.i, r.s, rr.fld; position r.p; @@ ( -pr_err@p +netdev_err ( + i->fld, ...) | -pr_info@p +netdev_info ( + i->fld, ...) | -pr_debug@p +netdev_dbg ( + i->fld, ...) ) Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
18cd9021 |
|
15-Jun-2017 |
Suniel Mahesh <sunil.m@techveda.org> |
staging: wlan-ng: Fix struct definition's and variable type le16_to_cpu() accepts argument of type __le16 and cpu_to_le16() returns an argument of type __le16. This patch fixes: (a) the type of the variable that end's up getting return from cpu_to_le16(). (b) the member types of struct hfa384x_host_scan_request_data, struct hfa384x_bytestr32 and struct hfa384x_hscan_result_sub. The following type mismatch warnings reported by sparse have been fixed: warning: incorrect type in assignment (different base types) warning: cast to restricted __le16 Signed-off-by: Suniel Mahesh <sunil.m@techveda.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
dea20579 |
|
29-Apr-2017 |
Andrea della Porta <sfaragnaus@gmail.com> |
staging: wlan-ng: prism2mgmt.c: fixed a double endian conversion before calling hfa384x_drvr_setconfig16, also fixes relative sparse warning staging: wlan-ng: prism2mgmt.c: This patches fixes a double endian conversion. cpu_to_le16() was called twice first in prism2mgmt_scan and again inside hfa384x_drvr_setconfig16() for the same variable, hence it was swapped twice. Incidentally, it also fixed the following sparse warning: drivers/staging/wlan-ng/prism2mgmt.c:173:30: warning: incorrect type in assignment (different base types) drivers/staging/wlan-ng/prism2mgmt.c:173:30: expected unsigned short [unsigned] [usertype] word drivers/staging/wlan-ng/prism2mgmt.c:173:30: got restricted __le16 [usertype] <noident> Unfortunately, only compile tested. Signed-off-by: Andrea della Porta <sfaragnaus@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c519822a |
|
16-Feb-2017 |
Georgios Emmanouil <geo.emmnl@gmail.com> |
Staging: wlan-ng: prism2mgmt: Removed an empty line Removed an empty line. Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
55dd5a39 |
|
09-Feb-2017 |
Frans Klaver <fransklaver@gmail.com> |
staging: wlan_ng: fix logical continuation alignment It appears that our coding style prefers that logical continuations have the operator at the end of the line. Fix that. While at it, stick the 'if' after 'else' where it belongs. Signed-off-by: Frans Klaver <fransklaver@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
536e973c |
|
18-Nov-2016 |
Shiva Kerdel <shiva@exdev.nl> |
Staging: wlan-ng: prism2mgmt: Fixed operators spacing style issues Fixed spaces around operators to fix their coding style issues. Signed-off-by: Shiva Kerdel <shiva@exdev.nl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e0e69648 |
|
19-Oct-2016 |
Sergio Paracuellos <sergio.paracuellos@gmail.com> |
staging: wlan-ng: Replace data type declaration with variable of same type in prism2mgmt.c sizeof(var) instead of sizeof(struct XXX) is preferred. It also fix the following checkpatch.pl script warning: WARNING: line over 80 characters Fix this two in prism2mgmt.c file. Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
8f8149de |
|
19-Oct-2016 |
Sergio Paracuellos <sergio.paracuellos@gmail.com> |
staging: wlan-ng: avoid CamelCase: hfa384x_HScanResultSub Replace CamelCase struct name with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
e474b4d4 |
|
19-Oct-2016 |
Sergio Paracuellos <sergio.paracuellos@gmail.com> |
staging: wlan-ng: avoid CamelCase: hfa384x_HostScanRequest_data Replace CamelCase struct name and fields with underscores to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b937612f |
|
19-Oct-2016 |
Sergio Paracuellos <sergio.paracuellos@gmail.com> |
staging: wlan-ng: avoid CamelCase: HFA384x_RID_CNFAPBCNint Replace CamelCase define to comply with the standard kernel coding style. Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
01fe9c92 |
|
09-Oct-2016 |
Sergio Paracuellos <sergio.paracuellos@gmail.com> |
staging: wlan-ng: fix block comment warnings in prism2mgmt.c This patch fix the following checkpatch.pl warnings in prism2mgmt.c: WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5a2214e2 |
|
28-Sep-2016 |
Sergio Paracuellos <sergio.paracuellos@gmail.com> |
staging: wlang-ng: avoid new typedef: hfa384x_t This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_t Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b353d11a |
|
28-Sep-2016 |
Sergio Paracuellos <sergio.paracuellos@gmail.com> |
staging: wlang-ng: avoid new typedef: hfa384x_HScanResultSub_t This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_HScanResultSub_t Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
935cbfb2 |
|
28-Sep-2016 |
Sergio Paracuellos <sergio.paracuellos@gmail.com> |
staging: wlang-ng: avoid new typedef: hfa384x_HostScanRequest_data_t This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef hfa384x_HostScanRequest_data_t Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3fd1e3fc |
|
25-Sep-2016 |
Sergio Paracuellos <sergio.paracuellos@gmail.com> |
staging: wlan-ng: avoid new typedef: p80211pstrd_t This patch fixes the following checkpatch.pl warning in p80211types.h: WARNING: do not add new typedefs It applies for typedef p80211pstrd_t Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
0e21fa46 |
|
22-Sep-2016 |
Jannik Becher <becher.jannik@gmail.com> |
staging: wlan-ng: remove unnecessary spaces before casts Fixed a coding style issue by removing unnecessary spaces before casts. Signed-off-by: Jannik Becher <Becher.Jannik@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f4353ee3 |
|
19-Sep-2016 |
Rehas Sachdeva <aquannie@gmail.com> |
staging: wlan-ng: Remove unnecessary variable usage Instead of storing the return value into a variable and then returning it, we can club the two into a single return statement. This change was made using the following semantic patch by Coccinelle: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Rehas Sachdeva <aquannie@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
c9573a8d |
|
18-Sep-2016 |
sayli karnik <karniksayli1995@gmail.com> |
staging: wlan-ng: Remove the typedef to the 'wlandevice' structure This patch removes the typedef 'wlandevice_t' to the 'wlandevice' structure. Signed-off-by: sayli karnik <karniksayli1995@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
3cfcb95c |
|
25-Feb-2016 |
Janani Ravichandran <janani.rvchndrn@gmail.com> |
staging: wlan-ng: prism2mgmt.c: Drop void pointer cast Void pointers don't need to be cast to other pointer types. Semantic patch used: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x) [...] | ((T *)x)->f | - (T *) e ) Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
230fa11f |
|
14-Aug-2014 |
Jeshwanth Kumar N K <jeshkumar555@gmail.com> |
staging: wlan-ng: prism2mgmt.c Fix break not useful Fixed up warnings, break is not useful after return statement. And the exit Label is deleted, now returning inline. Signed-off-by: Jeshwanth Kumar N K <jeshkumar555@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
5d9c8d51 |
|
19-Jun-2014 |
Johannes Stadlinger <Johannes.Stadlinger@fau.de> |
wlan-ng/prism2mgmt:checkpatch: Insert blank line This patch inserts a blank line after a declaration to avoid checkpatch warning. Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@fau.de> Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email> CC: linux-kernel@i4.cs.fau.de Meh-by: Josh Triplett <josh@joshtriplett.org> CC: Himangi Saraogi <himangi774@gmail.com> CC: Vitaly Osipov <vitaly.osipov@gmail.com> CC: devel@driverdev.osuosl.org CC: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
17b37546 |
|
19-Jun-2014 |
Johannes Stadlinger <Johannes.Stadlinger@fau.de> |
wlan-ng/prism2mgmt:checkpatch: Fix string split This patch fixes all warnings of checkpatch about string splitting. Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@fau.de> Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email> CC: linux-kernel@i4.cs.fau.de CC: Himangi Saraogi <himangi774@gmail.com> CC: Vitaly Osipov <vitaly.osipov@gmail.com> CC: devel@driverdev.osuosl.org CC: linux-kernel@vger.kernel.org Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2cf1ba40 |
|
19-Jun-2014 |
Johannes Stadlinger <Johannes.Stadlinger@fau.de> |
wlan-ng/prism2mgmt:checkpatch: Fix long lines This patch fixes all warnings of checkpatch about lines over 80 characters. Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@fau.de> Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email> CC: linux-kernel@i4.cs.fau.de CC: Himangi Saraogi <himangi774@gmail.com> CC: Vitaly Osipov <vitaly.osipov@gmail.com> CC: devel@driverdev.osuosl.org CC: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
02d9b1eb |
|
18-May-2014 |
Vitaly Osipov <vitaly.osipov@gmail.com> |
staging: wlan-ng: use netdev_() instead of printk() Replaced all uses of printk() in wlan-ng with netdev_err / _warn where a netdev exists. If a few cases where a netdev does not yet exist, dev_ or pr_ was used. Checkpatch complains about lines over 80 chars or split string constants - the messages are just too long, keeping it completely happy would make the code less readable. Signed-off-by: Vitaly Osipov <vitaly.osipov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
b2119911 |
|
02-Nov-2013 |
Himangi Saraogi <himangi774@gmail.com> |
staging:wlan-ng:hfa384x.h: remove typedef struct hfa384x_bytestr __packed hfa384x_bytestr_t This patch removes the checkpatch.pl warning "do not add new typedefs" and changes all source files that use that typedef. Also lines were shortened to 80 characters to do away with the checkpatch.pl warning "line over 80 characters" generated due to replacement of the hfa384x_bytestr_t by struct hfa384x_bytestr in prism2mgmt.c, prism2mgmt.h, prism2mib.c, prism2sta.c. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
25c97da8 |
|
20-Jan-2013 |
Sebastian Wankerl <sisewank@cip.cs.fau.de> |
wlan-ng/prism2mgmt.c: formated too long lines Formated pr_debug() calls Signed-off-by: Sebastian Wankerl <sisewank@cip.cs.fau.de> Signed-off-by: Sebastian Ehrenfels <qi50dube@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
52070c70 |
|
20-Jan-2013 |
Sebastian Wankerl <sisewank@cip.cs.fau.de> |
wlan-ng/prism2mgmt.c: added parantheses to macro Enclose the macro into braces so that it can be closed by a semicolon Signed-off-by: Sebastian Wankerl <sisewank@cip.cs.fau.de> Signed-off-by: Sebastian Ehrenfels <qi50dube@cip.cs.fau.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
811a37ef |
|
09-Jan-2013 |
Tormod Volden <debian.tormod@gmail.com> |
staging: wlan-ng: Fix clamping of returned SSID length Commit 2e254212 broke listing of available network names, since it clamped the length of the returned SSID to WLAN_BSSID_LEN (6) instead of WLAN_SSID_MAXLEN (32). https://bugzilla.kernel.org/show_bug.cgi?id=52501 Signed-off-by: Tormod Volden <debian.tormod@gmail.com> Cc: stable <stable@vger.kernel.org> # 3.4+ Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
bb46f130 |
|
18-Apr-2012 |
Dan Carpenter <dan.carpenter@oracle.com> |
Staging: wlan-ng: off by one in prism2mgmt_scan_results() Count is used to cap "req->bssindex.data" which is used as an offset into the hw->scanresults->info.hscanresult.result[] array. The array has only HFA384x_SCANRESULT_MAX (31) elements so the 32 is off by one. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
2e254212 |
|
31-Jan-2012 |
Dan Carpenter <dan.carpenter@oracle.com> |
Staging: wlan-ng: cap the ssid length We're getting the ssid length from the scan here. Let's cap it before doing the memcpy(). Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
#
f83dfd06 |
|
06-Nov-2010 |
Johan Meiring <johanmeiring@gmail.com> |
Staging: wlan-ng: fix coding style issues in prism2mgmt.c This is a patch to prism2mgmt.c that fixes coding style issues found by checkpatch.pl. Three instances of the 80 char line limit being exceeded have been kept as is so that string literals are not split up. Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
b6bb56e6 |
|
02-Aug-2010 |
Edgardo Hames <ehames@gmail.com> |
Staging: wlan-ng: fix checkpatch issues in headers. This patch fix errors and warnings reported by checkpatch in p80211meta.h and p80211metstruct.h. Signed-off-by: Edgardo Hames <ehames@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
cb3126e6 |
|
03-Jun-2010 |
Karl Relton <karllinuxtest.relton@ntlworld.com> |
Staging: wlan-ng: Switch from wext to cfg80211 Switch driver over from wext to cfg80211 interface. Some Notes: - This patch moves the driver wholesale from wext to cfg80211. Wext support is still provided through the cfg80211 provided wext compatability layer. - Currently only infrastructure mode is implemented. Ad hoc mode is not yet implemented, but can be added. - It does not support connecting to a specified bssid, instead roaming is handled by the card itself. This matches the behaviour of the existing driver. - It has been tested using NetworkManager (via wpa_supplicant) configured to use the wext compatability layer, and then again with the native nl80211 layer. Signed-off-by: Karl Relton <karllinuxtest.relton@ntlworld.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
5a0e3ad6 |
|
24-Mar-2010 |
Tejun Heo <tj@kernel.org> |
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
|
#
ef1a0ed7 |
|
18-Feb-2010 |
Andrew Elwell <andrew.elwell@gmail.com> |
Staging: wlan-ng - checkpatch.pl fixups Basic fixups in the staging/wlan-ng directory. (First kernel patch - thanks to FOSDEM talk) Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
5dd8acc8 |
|
14-Feb-2010 |
Svenne Krap <svenne@krap.dk> |
Staging: wlan-ng: multiple safe style cleanups Cleanups as suggested by checkpatch.pl utiltiy. .o's from before and after cleanup have matching SHA1s. Signed-off-by: Svenne Krap <svenne@krap.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
0d0202fd |
|
21-Jun-2009 |
Moritz Muehlenhoff <jmm@debian.org> |
Staging: wlan-ng: Remove some superflous comments Signed-off-by: Moritz Muehlenhoff <jmm@debian.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
297f06ce |
|
10-Jun-2009 |
Mithlesh Thukral <mithlesh@linsyssoft.com> |
staging: wlan-ng: scripts/checkpatch.pl error fixes. scripts/checkpatch.pl error fixes. This is a TODO item. This patch fixes most of the errors reported by checkpatch.pl in wlan-ng directory of staging tree. Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
75f49e07 |
|
25-May-2009 |
Mithlesh Thukral <mithlesh@linsyssoft.com> |
Staging: wlan-ng: Lindent cleanups Lindent script cleanups in wlan-ng driver in the staging tree. This is a item in the TODO list. Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
f2b50b40 |
|
08-May-2009 |
Karl Relton <karllinuxtest.relton@ntlworld.com> |
Staging: wlan-ng: Change KERN_DEBUG or pr_debug to match orig driver Change uses of KERN_DEBUG over to pr_debug to match original driver where messages are only needed during driver development. Signed-off-by: Karl Relton <karllinuxtest.relton@ntlworld.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
18c7f792 |
|
18-Feb-2009 |
Moritz Muehlenhoff <jmm@debian.org> |
Staging: wlan-ng: Replace local byteorder macros Replace hfa384x2host_16(), hfa384x2host_32(), host2hfa384x_16() and host2hfa384x_32() with standard byteorder macros. Signed-off-by: Moritz Muehlenhoff <jmm@debian.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
465e7417 |
|
09-Feb-2009 |
Moritz Muehlenhoff <jmm@debian.org> |
Staging: wlan-ng: Remove the now empty wlan_compat.h Signed-off-by: Moritz Muehlenhoff <jmm@debian.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
450238ea |
|
07-Feb-2009 |
Moritz Muehlenhoff <jmm@debian.org> |
Staging: wlan-ng: prism2mgmt.c: Coding style cleanups Signed-off-by: Moritz Muehlenhoff <jmm@debian.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
a7cf7bae |
|
07-Feb-2009 |
Moritz Muehlenhoff <jmm@debian.org> |
Staging: wlan-ng: Replace WLAN_LOG_DEBUG() with printk(KERN_DEBUG Signed-off-by: Moritz Muehlenhoff <jmm@debian.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
ea045ba0 |
|
05-Feb-2009 |
Moritz Muehlenhoff <jmm@debian.org> |
Staging: wlan-ng: Remove WLAN_INCLUDE_DEBUG and some related, mostly unused Signed-off-by: Moritz Muehlenhoff <jmm@debian.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
7dd33a43 |
|
01-Feb-2009 |
Moritz Muehlenhoff <jmm@debian.org> |
Staging: wlan-ng: Remove dead code from prism2mgmt.c Signed-off-by: Moritz Muehlenhoff <jmm@debian.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
9b9556ec |
|
25-Jan-2009 |
Moritz Muehlenhoff <jmm@debian.org> |
Staging: wlan-ng: Replace WLAN_LOG_WARNING() with printk() Signed-off-by: Moritz Muehlenhoff <jmm@debian.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
edbd606c |
|
25-Jan-2009 |
Moritz Muehlenhoff <jmm@debian.org> |
Staging: wlan-ng: Replace WLAN_LOG_ERROR() with printk() Signed-off-by: Moritz Muehlenhoff <jmm@debian.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
350f2f4b |
|
25-Jan-2009 |
Moritz Muehlenhoff <jmm@debian.org> |
Staging: wlan-ng: Remove WLAN_LOG_INFO Replace WLAN_LOG_INFO with printk() and remove it. Signed-off-by: Moritz Muehlenhoff <jmm@debian.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
7f6e0e44 |
|
25-Jan-2009 |
Moritz Muehlenhoff <jmm@debian.org> |
Staging: wlan-ng: Replace BITx with the generic BIT(x) Signed-off-by: Moritz Muehlenhoff <jmm@debian.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
8a251b55 |
|
21-Jan-2009 |
Moritz Muehlenhoff <jmm@debian.org> |
Staging: wlan-ng: Remove DBFENTER/DBFEXIT macros Remove the ugly DBFENTER/DBFEXIT macros, which are only inserted to add "<---" and "--->" at the function start/end at higher debug levels and which make the code a lot less readable. Signed-off-by: Moritz Muehlenhoff <jmm@debian.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
d11e5f22 |
|
31-Oct-2008 |
Huang Weiyi <weiyi.huang@gmail.com> |
Staging: wlan-ng: remove unused #include <version.h> The file(s) below do not use LINUX_VERSION_CODE nor KERNEL_VERSION. drivers/staging/wlan-ng/p80211conv.c drivers/staging/wlan-ng/p80211req.c drivers/staging/wlan-ng/p80211wext.c drivers/staging/wlan-ng/prism2mgmt.c This patch removes the said #include <version.h>. Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
cbec30c4 |
|
29-Oct-2008 |
Solomon Peachy <pizza@shaftnet.org> |
Staging: wlan-ng: Delete a large pile of now-unused code. Signed-off-by: Solomon Peachy <pizza@shaftnet.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
aaad4303 |
|
29-Oct-2008 |
Solomon Peachy <pizza@shaftnet.org> |
Staging: wlan-ng: Use standard kernel integer (u32/s32/etc) types. wlan-ng needed to interact with userspace, and support very old kernels, so it used to define its own types for integers to ensure consistency. It's all rather irrelevant now. Signed-off-by: Solomon Peachy <pizza@shaftnet.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
ff1ae8f3 |
|
27-Oct-2008 |
Solomon Peachy <pizza@shaftnet.org> |
Staging: wlan-ng: Eliminate local 'version.h' The kernel provides us with the proper version of this file. Signed-off-by: Solomon Peachy <pizza@shaftnet.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
5db8dcc9 |
|
27-Oct-2008 |
Solomon Peachy <pizza@shaftnet.org> |
Staging: wlan-ng: Remove AP-only code from MLME functions. It is not needed in this driver. Signed-off-by: Solomon Peachy <pizza@shaftnet.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
f980c178 |
|
27-Oct-2008 |
Solomon Peachy <pizza@shaftnet.org> |
Staging: wlan-ng: Eliminate a boatload of tertiaryAP-only code. Signed-off-by: Solomon Peachy <pizza@shaftnet.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
dff1dc8c |
|
27-Oct-2008 |
Solomon Peachy <pizza@shaftnet.org> |
Staging: wlan-ng: Delete PCI/PLX/PCMCIA-specific code. Also delete a large pile of code that existed to support <2.6 kernels. Signed-off-by: Solomon Peachy <pizza@shaftnet.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|
#
00b3ed16 |
|
02-Oct-2008 |
Greg Kroah-Hartman <gregkh@suse.de> |
Staging: add wlan-ng prism2 usb driver This adds the wlan-ng prism2 USB driver to the drivers/staging tree. The code was originally written by the linux-wlan-ng team, patched by some Novell engineers to properly work on newer kernels, and then hacked into place in order to get it to build properly in a single subdirectory within the kernel tree by me. It supports a wide range of older USB prism2 devices, and contains a 80211 stack to support this single driver. Cc: Christian Zoz <zoz@suse.de> Cc: Andreas Gruenbacher <agruen@suse.de> Cc: linux-wireless <linux-wireless@vger.kernel.org> Cc: John Linville <linville@tuxdriver.com> Cc: Helmut Schaa <helmut.schaa@googlemail.com> Cc: linux-wlan-ng <solomon@linux-wlan.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
|